From nscott@redhat.com Sun Jun 2 20:40:22 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id D5FEC29DF8 for ; Sun, 2 Jun 2013 20:40:22 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id C8F5D304039 for ; Sun, 2 Jun 2013 18:40:19 -0700 (PDT) X-ASG-Debug-ID: 1370223617-04cb6c5af811aa70001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id BlPEaZIRCFPZ6X4g for ; Sun, 02 Jun 2013 18:40:17 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r531eHFd001824 for ; Sun, 2 Jun 2013 21:40:17 -0400 Date: Sun, 2 Jun 2013 21:40:17 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: PCP Message-ID: <1207056654.17450325.1370223617343.JavaMail.root@redhat.com> In-Reply-To: <1651951883.17449716.1370223470682.JavaMail.root@redhat.com> Subject: pcp updates: lvm, py pmda updates, docs, qa MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates: lvm, py pmda updates, docs, qa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pcp updates: lvm, py pmda updates, docs, qa Thread-Index: Xgy782uW7dyP2TzkjkBTrODOiz4d5A== X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1370223617 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.132794 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... Changes committed to git://oss.sgi.com/pcp/pcp.git dev man/man1/pmcd.1 | 28 +- qa/540 | 55 +++++ qa/540.out | 2 qa/group | 1 src/pmdas/linux/GNUmakefile | 33 +-- src/pmdas/linux/clusters.h | 1 src/pmdas/linux/devmapper.c | 80 ++++++++ src/pmdas/linux/devmapper.h | 29 ++ src/pmdas/linux/help | 1 src/pmdas/linux/indom.h | 1 src/pmdas/linux/pmda.c | 56 ++++- src/pmdas/linux/proc_lv.c | 174 ++++++++--------- src/pmdas/linux/proc_lv.h | 66 +++--- src/pmdas/linux/root_linux | 2 src/pmdas/simple/pmdasimple.py | 3 src/python/pcp/pmda.py | 57 +++-- src/python/pmda.c | 409 +++++++++++++++++++++++++++++++++++++++-- 17 files changed, 804 insertions(+), 194 deletions(-) commit af1cf9be821212677ceda7a1598a70114226b371 Author: Dave Brolley Date: Fri May 31 17:16:52 2013 -0400 Update ACCESS CONTROL section of pmcd.1 with IPv6 details. commit 4b63e2227ae5ad023af95470b2efc9789be188aa Author: Nathan Scott Date: Mon Jun 3 11:08:07 2013 +1000 Add an automated test exercising the hinv.map.lvname metric Test 540 added, comparing the instance domain and values for the hinv.map.lvname metric to the contents of /dev/mapper. commit a9cf740f71baa6ca1fcc820247f5b170e7c7544d Author: Nathan Scott Date: Mon Jun 3 11:02:44 2013 +1000 Updates for several small hinv.map.lvname issues from code review Addresses the following aspects: - prov_lv.c and proc_lv.h - these aren't manipulating procfs files, renamed to dev_mapper.[ch] (for code too - refresh_proc_lv etc). - copyright annotation in both files was incorrect. - code style inconsistent with the rest of pmdalinux coding-style. - path[64] and linkname[256] now using MAXPATHLEN. commit 8991691f6d273eb60e5fce383bef941dea753320 Author: Stan Cox Date: Mon Jun 3 09:57:41 2013 +1000 Implement a logical-volume-to-device-name mapping in pmdalinux Provides a mechanism for determining the logical volume names of a given Linux kernel device mapper device name, allowing client tools to use the higher level names. Sample Use: dbpmda> desc hinv.map.lvname PMID: 60.52.0 Data Type: string InDom: 60.22 0xf000016 Semantics: discrete Units: none dbpmda> instance 60.22 pmInDom: 60.22 [ 0] inst: 1 name: "dm-3" [ 1] inst: 2 name: "dm-2" [ 2] inst: 3 name: "dm-4" [ 3] inst: 4 name: "dm-0" [ 4] inst: 5 name: "dm-1" dbpmda> fetch hinv.map.lvname PMID(s): 60.52.0 pmResult dump from 0x187ecd0 timestamp: 0.000000 19:00:00.000 numpmid: 1 60.52.0 (hinv.map.lvname): numval: 5 valfmt: 1 vlist[]: inst [1 or ???] value "vg_dieyong-lv_work" inst [2 or ???] value "vg_dieyong-lv_images" inst [3 or ???] value "vg_dieyong-lv_home" inst [4 or ???] value "vg_dieyong-lv_swap" inst [5 or ???] value "vg_dieyong-lv_root" commit ee6de2f428c71502cb56d23d47daf20cb1016a87 Author: Nathan Scott Date: Mon Jun 3 09:48:12 2013 +1000 Initial implementation of the python pmda callback methods Provides the fetch, instance, cluster refresh, and store callback interfaces that sit between the C API and python PMDA class. Some of the other helper mechanisms provided by the perl wrapper are also now implemented (error/info logging, uptime metric help). From nscott@redhat.com Sun Jun 2 23:35:25 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id C190229DF8 for ; Sun, 2 Jun 2013 23:35:25 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id A52C68F8040 for ; Sun, 2 Jun 2013 21:35:25 -0700 (PDT) X-ASG-Debug-ID: 1370234120-04bdf0233f12bae0001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id xpT7Ax6eAaMkGuss for ; Sun, 02 Jun 2013 21:35:20 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r534ZKnm028105 for ; Mon, 3 Jun 2013 00:35:20 -0400 Date: Mon, 3 Jun 2013 00:35:20 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <790498298.17511284.1370234120453.JavaMail.root@redhat.com> Subject: pcp updates: lvm memleak, qa MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates: lvm memleak, qa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pcp updates: lvm memleak, qa Thread-Index: oC6jeHyhuxcdcb4KxDsSUJnID52RwA== X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1370234120 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.132805 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... Changes committed to git://oss.sgi.com/pcp/pcp.git dev qa/528 | 2 - qa/528.out | 45 ++++++++++++++++++-------------------------- qa/src/batch_import.perl | 15 ++++---------- src/pmdas/linux/devmapper.c | 9 +++++--- 4 files changed, 31 insertions(+), 40 deletions(-) commit 0550e0f716b93be4d4bff6540f75617c8520947b Author: Nathan Scott Date: Mon Jun 3 14:33:58 2013 +1000 Fix memory leak on new device mapper instance domain Thanks to Mark Goodwin for spotting this, we were leaking device mapper names on each successive call to hinv.map.lvname. Also we can remove the memset-to-zero after realloc'ing the pmdaInstid array since the very next step is to write to all of that memory. commit cde7dace96b8d2b454aec4ff9a2711cb220c29fa Author: Nathan Scott Date: Mon Jun 3 14:22:00 2013 +1000 Fix test 528 which attempted to insert two values for one metric This results in an error (DUP_METRIC_VALUE) when these are in the same pmResult, exposed by Markos recent improvements to the perl log import batching. Also noticed a floating-point rounding issue that would have made this test fail on some platforms, so changes to just use strings everywhere, since thats simpler and still exercises all of the functionality we're after here. From iana-shared@icann.org Mon Jun 3 11:31:47 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.9 required=5.0 tests=MISSING_HEADERS autolearn=no version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id A4E647CBF for ; Mon, 3 Jun 2013 11:31:47 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id 76102304089 for ; Mon, 3 Jun 2013 09:31:44 -0700 (PDT) X-ASG-Debug-ID: 1370277100-04bdf0233c1516e0001-S8gJnT Received: from smtp1.lax.icann.org (smtp01.icann.org [192.0.33.81]) by cuda.sgi.com with ESMTP id xLNzqLW5f9RYFt3M (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Mon, 03 Jun 2013 09:31:40 -0700 (PDT) X-Barracuda-Envelope-From: iana-shared@icann.org X-Barracuda-Apparent-Source-IP: 192.0.33.81 Received: from request1.lax.icann.org (request1.lax.icann.org [10.32.11.221]) by smtp1.lax.icann.org (8.13.8/8.13.8) with ESMTP id r53GVca6005537; Mon, 3 Jun 2013 16:31:38 GMT Received: by request1.lax.icann.org (Postfix, from userid 48) id 04B395606F8; Mon, 3 Jun 2013 16:31:38 +0000 (UTC) RT-Owner: pearl.liang Subject: [IANA #679881] Application for a Port Number and/or Service Name "pmwebapis" From: "Pearl Liang via RT" X-ASG-Orig-Subj: [IANA #679881] Application for a Port Number and/or Service Name "pmwebapis" Reply-To: iana-ports@iana.org In-Reply-To: References: <201305072055.r47Ktdpb021771@smtp1.lax.icann.org> <51968C26.6030902@internode.on.net> Message-ID: Precedence: bulk X-RT-Loop-Prevention: IANA RT-Ticket: IANA #679881 Managed-BY: RT 4.0.8 (http://www.bestpractical.com/rt/) RT-Originator: pearl.liang@icann.org CC: kenj@internode.on.net, pcp@oss.sgi.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-RT-Original-Encoding: utf-8 Date: Mon, 3 Jun 2013 16:31:37 +0000 X-Barracuda-Connect: smtp01.icann.org[192.0.33.81] X-Barracuda-Start-Time: 1370277100 X-Barracuda-Encrypted: AES256-SHA X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 1.21 X-Barracuda-Spam-Status: No, SCORE=1.21 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=MISSING_HEADERS X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.132853 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 1.21 MISSING_HEADERS Missing To: header Dear Ken, Thank you for your reply. We want to let you know that the requests are still in process. Email address must be one you and/or someone from the team can email responses and confirmation from. Please ensure that someone can email confirmation from pcp@oss.sgi.com. We will contact you when we have some more information. Thank you, Pearl Liang ICANN/IANA On Fri May 17 13:00:00 2013, kenj@internode.on.net wrote: > Hi Pearl. > > On 18/05/13 02:38, Pearl Liang via RT wrote: > > Hello, > > > > We are following up with you on this one. Please address the asked > > question #3 in the below message. > > Sorry for missing that in my last reply. > > As Frank has already responded, pcp@oss.sgi.com is the public mailing > list. It does not really matter if you follow up to me directly or to > the list (where I'm likely to respond if I'm awake, else Frank may well > respond as he's in Toronto and I'm in Melbourne so are days are not > really aligned). > > Hope you have all the info you need now. > > Cheers, Ken. > From brolley@redhat.com Mon Jun 3 21:43:06 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id EA8947CBF for ; Mon, 3 Jun 2013 21:43:06 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id CA3AA304059 for ; Mon, 3 Jun 2013 19:43:03 -0700 (PDT) X-ASG-Debug-ID: 1370313782-04cb6c5afa15f3e0001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id kOVYbEWGOw98jDkN for ; Mon, 03 Jun 2013 19:43:03 -0700 (PDT) X-Barracuda-Envelope-From: brolley@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r542h2wO009268 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 3 Jun 2013 22:43:02 -0400 Received: from [10.10.52.65] (vpn-52-65.rdu2.redhat.com [10.10.52.65]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r542h19q018194 for ; Mon, 3 Jun 2013 22:43:01 -0400 Message-ID: <51AD5434.9090200@redhat.com> Date: Mon, 03 Jun 2013 22:43:00 -0400 From: Dave Brolley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: PCP Subject: Unix Domain Sockets Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-ASG-Orig-Subj: Unix Domain Sockets Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1370313782 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 Hi, I've been looking into the ins and outs of adding the capability of listening on unix domain sockets to pmcd (and presumably pmproxy, and perhaps other components) via extensions to the API in src/libpcp/src/auxserver.c. I've written most of the code but, at this point, several user interface decisions must be made: 1) The default for pmcd (and pmproxy) is to listen on all available network interfaces, unless the -i option has been specified. It it not clear (to me) what the default should be for the unix domain. It is clear that a new option (-s or -u perhaps?) is in order for the specification of paths to these sockets. Let's assume -s for now. One possibility is to listen to none by default. One or more -s options could then be used to specify one or more unix domain sockets. A -s option with no argument could mean to use the default (/var/run/pcp/pmcd.socket perhaps?). This would be used in conjunction with an environment variable (PMCD_SOCKET perhaps?) which would specify additional socket paths, similar to how -p and PMCD_PORT work together. Another possibility is to listen on /var/run/pcp/pmcd.socket by default and to use -s and PMCD_SOCKET to override this. Once again an empty -s could be used to add the default path to the list. In either case it would be nice to have some way to say to use the default path within PMCD_SOCKET. Comments and suggestions please. It is interesting that there appears to be no support for specifying request socket addresses and ports in the pmcd config file. 2) Does the pmcd access control mechanism need to be extended to include a way to control access from unix domain sockets? If so, we would need some kind of syntax in order to distinguish a socket pathname from an ordinary host name. Once again comments and suggestions please. Thanks, Dave From nscott@redhat.com Tue Jun 4 03:04:17 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 1A0DE7CBF for ; Tue, 4 Jun 2013 03:04:17 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay2.corp.sgi.com (Postfix) with ESMTP id EA2DE304077 for ; Tue, 4 Jun 2013 01:04:13 -0700 (PDT) X-ASG-Debug-ID: 1370333049-04cbb0468f172e10001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id 3JuP8q6uF57DMRto for ; Tue, 04 Jun 2013 01:04:09 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5483wi0028192; Tue, 4 Jun 2013 04:03:58 -0400 Date: Tue, 4 Jun 2013 04:03:58 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Dave Brolley Cc: PCP Message-ID: <1004356284.18217432.1370333038213.JavaMail.root@redhat.com> In-Reply-To: <51AD5434.9090200@redhat.com> References: <51AD5434.9090200@redhat.com> Subject: Re: [pcp] Unix Domain Sockets MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] Unix Domain Sockets Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: Unix Domain Sockets Thread-Index: cFSivPYbLE8R4qNqmWDDnwCLY61lgg== X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1370333049 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.03 X-Barracuda-Spam-Status: No, SCORE=0.03 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH, THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.132915 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain Hi Dave, ----- Original Message ----- > Hi, > > I've been looking into the ins and outs of adding the capability of > listening on unix domain sockets to pmcd (and presumably pmproxy, and > perhaps other components) via extensions to the API in > src/libpcp/src/auxserver.c. I've written most of the code but, at this > point, several user interface decisions must be made: > > 1) The default for pmcd (and pmproxy) is to listen on all available > network interfaces, unless the -i option has been specified. It it not > clear (to me) what the default should be for the unix domain. It is > clear that a new option (-s or -u perhaps?) is in order for the > specification of paths to these sockets. Let's assume -s for now. I think the point we want to get to is to default to unix domain sockets on hosts that support them (so, everywhere except Windows) as this allows authentication information to be made available to pmcd without having to authenticate via SASL. This is a Big Win (tm) for agents like pmdaproc, so lets plan accordingly... > One possibility is to listen to none by default. One or more -s options > could then be used to specify one or more unix domain sockets. A -s > option with no argument could mean to use the default > (/var/run/pcp/pmcd.socket perhaps?). This would be used in conjunction I don't foresee any situation where more than one unix domain socket makes sense - is there a subtlety or situation I'm not seeing? If that's right, I think we should default to having pmcd create a local socket file (the suggested location above sounds good to me) and clients should default to using it (within pmNewContext) whenever possible - so instead of using an inet/ipv6 localhost/loopback socket as they do now. Certainly if a client tool (like pminfo) specifies no -h option it would be good to have it default to a unix domain socket connection. > with an environment variable (PMCD_SOCKET perhaps?) which would specify > additional socket paths, similar to how -p and PMCD_PORT work together. > Another possibility is to listen on /var/run/pcp/pmcd.socket by default > and to use -s and PMCD_SOCKET to override this. That sounds more like what I was thinking. The most likely users of -s and/or PMCD_SOCKET would be pcp/qa tests. > Once again an empty -s > could be used to add the default path to the list. In either case it Not a fan of "empty" -s. I'd suggest the behaviour be: "use the default /var/run/pcp/pmcd.socket unless -s present, if it is use that instead". > would be nice to have some way to say to use the default path within > PMCD_SOCKET. Comments and suggestions please. It is interesting that > there appears to be no support for specifying request socket addresses > and ports in the pmcd config file. pmcd.conf is more specifying complicated things that change at run-time (i.e. agents and access control) - for things that are simpler and set in stone for the life of pmcd, pmcd.options is used (which equates to command line arguments). > 2) Does the pmcd access control mechanism need to be extended to include > a way to control access from unix domain sockets? If so, we would need > some kind of syntax in order to distinguish a socket pathname from an > ordinary host name. Once again comments and suggestions please. Yeah, good question. Not sure yet. Since we will only have 1 unix socket path at a time (if my assumptions above hold), and the unix domain sockets will always pass in a userid/groupid (via SO_PASSCRED), the new user/group permissions model I've been hacking away at might be sufficient. cheers. -- Nathan From pevans@redhat.com Tue Jun 4 08:26:58 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 540787CBF for ; Tue, 4 Jun 2013 08:26:58 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id 29EE28F8035 for ; Tue, 4 Jun 2013 06:26:58 -0700 (PDT) X-ASG-Debug-ID: 1370352417-04cbb04690180600001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id BgdK5F6mXiUMhYJk for ; Tue, 04 Jun 2013 06:26:57 -0700 (PDT) X-Barracuda-Envelope-From: pevans@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r54DQusx026503 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 Jun 2013 09:26:57 -0400 Received: from [10.36.5.158] (vpn1-5-158.ams2.redhat.com [10.36.5.158]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r54DQtJD011793; Tue, 4 Jun 2013 09:26:56 -0400 Message-ID: <51ADEB1F.1060004@redhat.com> Date: Tue, 04 Jun 2013 14:26:55 +0100 From: Paul Evans User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Nathan Scott CC: pcp@oss.sgi.com Subject: Re: [pcp] Patch: gfs2 PMDA additional metrics for review/inclusion References: <517FBD63.3010804@redhat.com> <1117296374.7864618.1367373452615.JavaMail.root@redhat.com> <5180D92F.40809@redhat.com> <519E43ED.8020701@redhat.com> <1691226900.12032333.1369450053711.JavaMail.root@redhat.com> X-ASG-Orig-Subj: Re: [pcp] Patch: gfs2 PMDA additional metrics for review/inclusion In-Reply-To: <1691226900.12032333.1369450053711.JavaMail.root@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1370352417 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 Hi Nathan, I've completed another round of changes as based on your comments and fixed the issues with the QA tests: Removed the needless on-stack "value" local variable in gfs2_store() and all other related code belonging to it. Fixed and improved both QA tests to exercise the pmda 654 and 655. They have also had their expected outputs recorded into their respective .out files and changes have been made to common.gfs2 to reflect this. These changes are available at git://github.com/pauljevans/pcp.git gfs2 On 05/25/2013 03:47 AM, Nathan Scott wrote: > The next steps from there would be: > > - A man page for pmdagfs2 would be a good idea, esp. since its a fairly > complex agent - see man/man1/pmdacisco.1 as an example. Description of > the store-to-enable/disable mechanism would be helpful. > > - A client tool to drive the extraction and reporting of stats from the > various cluster nodes, manage the enabling / disabling of tracing, etc. > As discussed, python might be an appropriate language (other option is > C), some tests and a man page for the new tool would be a good idea as > well. Looking forward to this - should be an interesting bit of code! Looking forward these would be the most logical next steps to make, along with adding additional metrics. I look forward to feedback. Regards, Paul. From brolley@redhat.com Tue Jun 4 10:26:06 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id BA98A7CBF for ; Tue, 4 Jun 2013 10:26:06 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id 8989530405F for ; Tue, 4 Jun 2013 08:26:03 -0700 (PDT) X-ASG-Debug-ID: 1370359559-04bdf0233c18aa20001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id 3XhGGn6vSxsjCtcK for ; Tue, 04 Jun 2013 08:25:59 -0700 (PDT) X-Barracuda-Envelope-From: brolley@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r54FPx0w018189 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 Jun 2013 11:25:59 -0400 Received: from [10.15.16.119] (dhcp-10-15-16-119.yyz.redhat.com [10.15.16.119]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r54FPwak027794; Tue, 4 Jun 2013 11:25:58 -0400 Message-ID: <51AE0706.9010507@redhat.com> Date: Tue, 04 Jun 2013 11:25:58 -0400 From: Dave Brolley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Nathan Scott CC: PCP Subject: Re: [pcp] Unix Domain Sockets References: <51AD5434.9090200@redhat.com> <1004356284.18217432.1370333038213.JavaMail.root@redhat.com> X-ASG-Orig-Subj: Re: [pcp] Unix Domain Sockets In-Reply-To: <1004356284.18217432.1370333038213.JavaMail.root@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1370359559 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 On 06/04/2013 04:03 AM, Nathan Scott wrote: > Hi Dave, > > ----- Original Message ----- >> Hi, >> >> I've been looking into the ins and outs of adding the capability of >> listening on unix domain sockets to pmcd (and presumably pmproxy, and >> perhaps other components) via extensions to the API in >> src/libpcp/src/auxserver.c. I've written most of the code but, at this >> point, several user interface decisions must be made: >> >> 1) The default for pmcd (and pmproxy) is to listen on all available >> network interfaces, unless the -i option has been specified. It it not >> clear (to me) what the default should be for the unix domain. It is >> clear that a new option (-s or -u perhaps?) is in order for the >> specification of paths to these sockets. Let's assume -s for now. > I think the point we want to get to is to default to unix domain sockets > on hosts that support them (so, everywhere except Windows) as this allows > authentication information to be made available to pmcd without having to > authenticate via SASL. This is a Big Win (tm) for agents like pmdaproc, > so lets plan accordingly... > >> One possibility is to listen to none by default. One or more -s options >> could then be used to specify one or more unix domain sockets. A -s >> option with no argument could mean to use the default >> (/var/run/pcp/pmcd.socket perhaps?). This would be used in conjunction > I don't foresee any situation where more than one unix domain socket > makes sense - is there a subtlety or situation I'm not seeing? No, there's nothing subtle going on in my thinking. I just always lean toward flexibility when designing user interfaces. Since these are for local connections only, the only possible reason I can see for having more than one would be for access control, but even that is perhaps a stretch. The situation would be something like the ability to restrict a given unix domain socket to some subset of users or groups and then attaching the usual access controls to that socket. > > If that's right, I think we should default to having pmcd create a local > socket file (the suggested location above sounds good to me) and clients > should default to using it (within pmNewContext) whenever possible - so > instead of using an inet/ipv6 localhost/loopback socket as they do now. > Certainly if a client tool (like pminfo) specifies no -h option it would > be good to have it default to a unix domain socket connection. > >> with an environment variable (PMCD_SOCKET perhaps?) which would specify >> additional socket paths, similar to how -p and PMCD_PORT work together. >> Another possibility is to listen on /var/run/pcp/pmcd.socket by default >> and to use -s and PMCD_SOCKET to override this. > That sounds more like what I was thinking. The most likely users of -s > and/or PMCD_SOCKET would be pcp/qa tests. OK. So with the single unix domain socket assumption, then this becomes easy. We would use the path specified on -s. If none specified, then we use the path specified in PMCD_SOCKET. If that's not defined, then we use the default, /var/run/pcp/pmcd.socket. > >> Once again an empty -s >> could be used to add the default path to the list. In either case it > Not a fan of "empty" -s. I'd suggest the behaviour be: "use the default > /var/run/pcp/pmcd.socket unless -s present, if it is use that instead". Yes. With the single socket assumption, this is no longer needed. > >> would be nice to have some way to say to use the default path within >> PMCD_SOCKET. This is no longer needed as well. >> Comments and suggestions please. It is interesting that >> there appears to be no support for specifying request socket addresses >> and ports in the pmcd config file. > pmcd.conf is more specifying complicated things that change at run-time > (i.e. agents and access control) - for things that are simpler and set > in stone for the life of pmcd, pmcd.options is used (which equates to > command line arguments). > >> 2) Does the pmcd access control mechanism need to be extended to include >> a way to control access from unix domain sockets? If so, we would need >> some kind of syntax in order to distinguish a socket pathname from an >> ordinary host name. Once again comments and suggestions please. > Yeah, good question. Not sure yet. Since we will only have 1 unix socket > path at a time (if my assumptions above hold), and the unix domain sockets > will always pass in a userid/groupid (via SO_PASSCRED), the new user/group > permissions model I've been hacking away at might be sufficient. But, as mentioned above, could create the need for more than one unix domain socket, each with its own userid/groupid+access controls. Dave From fche@redhat.com Tue Jun 4 14:05:51 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 7ACF729DF8 for ; Tue, 4 Jun 2013 14:05:51 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id 69EFA8F8039 for ; Tue, 4 Jun 2013 12:05:51 -0700 (PDT) X-ASG-Debug-ID: 1370372746-04cb6c5af918a750001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id 99DZlBEEO2aasIo0 for ; Tue, 04 Jun 2013 12:05:47 -0700 (PDT) X-Barracuda-Envelope-From: fche@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r54J5k5M012331 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 Jun 2013 15:05:46 -0400 Received: from fche.csb (vpn-62-51.rdu2.redhat.com [10.10.62.51]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r54J5kX5023811; Tue, 4 Jun 2013 15:05:46 -0400 Received: by fche.csb (Postfix, from userid 2569) id 5FC905816C; Tue, 4 Jun 2013 15:05:45 -0400 (EDT) To: Dave Brolley Cc: Nathan Scott , pcp@oss.sgi.com Subject: Re: Unix Domain Sockets References: <51AD5434.9090200@redhat.com> <1004356284.18217432.1370333038213.JavaMail.root@redhat.com> <51AE0706.9010507@redhat.com> X-ASG-Orig-Subj: Re: Unix Domain Sockets From: fche@redhat.com (Frank Ch. Eigler) Date: Tue, 04 Jun 2013 15:05:45 -0400 In-Reply-To: <51AE0706.9010507@redhat.com> (Dave Brolley's message of "Tue, 04 Jun 2013 11:25:58 -0400") Message-ID: User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1370372746 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 Dave Brolley writes: > [...] But, as mentioned above, could create the need for more than > one unix domain socket, each with its own userid/groupid+access > controls. If that were required, it could be done via running multiple separate pmcd's. - FChE From brolley@redhat.com Tue Jun 4 15:28:17 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 555ED29DF8 for ; Tue, 4 Jun 2013 15:28:17 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id 445B78F8054 for ; Tue, 4 Jun 2013 13:28:14 -0700 (PDT) X-ASG-Debug-ID: 1370377690-04cbb0468e1939d0001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id dCKD3LFHzjs47vFm for ; Tue, 04 Jun 2013 13:28:10 -0700 (PDT) X-Barracuda-Envelope-From: brolley@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r54KSA13032480 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 Jun 2013 16:28:10 -0400 Received: from [10.15.16.119] (dhcp-10-15-16-119.yyz.redhat.com [10.15.16.119]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r54KS93N029940; Tue, 4 Jun 2013 16:28:09 -0400 Message-ID: <51AE4DD8.1070406@redhat.com> Date: Tue, 04 Jun 2013 16:28:08 -0400 From: Dave Brolley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: "Frank Ch. Eigler" CC: Nathan Scott , pcp@oss.sgi.com Subject: Re: Unix Domain Sockets References: <51AD5434.9090200@redhat.com> <1004356284.18217432.1370333038213.JavaMail.root@redhat.com> <51AE0706.9010507@redhat.com> X-ASG-Orig-Subj: Re: Unix Domain Sockets In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1370377690 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 On 06/04/2013 03:05 PM, Frank Ch. Eigler wrote: > Dave Brolley writes: > >> [...] But, as mentioned above, could create the need for more than >> one unix domain socket, each with its own userid/groupid+access >> controls. > If that were required, it could be done via running multiple separate > pmcd's. > We would then need a separate socket in the file system for each. i.e. /var/run/pcp/pmcd..socket. Is it even possible to run multiple separate pmcds? There is only one /var/run/pcp/pmcd.pid afaikt. Dave From fche@redhat.com Tue Jun 4 15:35:18 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id A4F4A29DF8 for ; Tue, 4 Jun 2013 15:35:18 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id 3F5D2AC00B for ; Tue, 4 Jun 2013 13:35:18 -0700 (PDT) X-ASG-Debug-ID: 1370378117-04bdf0233d19a930001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id nnS5rRS4AJhYFqxt for ; Tue, 04 Jun 2013 13:35:17 -0700 (PDT) X-Barracuda-Envelope-From: fche@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r54KZHIf013505 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 Jun 2013 16:35:17 -0400 Received: from fche.csb (vpn-62-51.rdu2.redhat.com [10.10.62.51]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r54KZH5B028088; Tue, 4 Jun 2013 16:35:17 -0400 Received: by fche.csb (Postfix, from userid 2569) id 83F4A5816C; Tue, 4 Jun 2013 16:35:16 -0400 (EDT) Date: Tue, 4 Jun 2013 16:35:16 -0400 From: "Frank Ch. Eigler" To: Dave Brolley Cc: Nathan Scott , pcp@oss.sgi.com Subject: Re: Unix Domain Sockets Message-ID: <20130604203516.GB15065@redhat.com> X-ASG-Orig-Subj: Re: Unix Domain Sockets References: <51AD5434.9090200@redhat.com> <1004356284.18217432.1370333038213.JavaMail.root@redhat.com> <51AE0706.9010507@redhat.com> <51AE4DD8.1070406@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51AE4DD8.1070406@redhat.com> User-Agent: Mutt/1.4.2.2i X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1370378117 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 Hi - On Tue, Jun 04, 2013 at 04:28:08PM -0400, Dave Brolley wrote: > We would then need a separate socket in the file system for each. i.e. > /var/run/pcp/pmcd..socket. Or some other user-specified name. > Is it even possible to run multiple separate pmcds? There is only > one /var/run/pcp/pmcd.pid afaikt. /var/run defaults are for distro-managed pmcd. A user that wishes to run his own pmcd for some reason would have to override all the defaults, including that pmcd.pid file, to avoid conflicts. - FChE From nscott@redhat.com Tue Jun 4 17:15:17 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 591F629DF8 for ; Tue, 4 Jun 2013 17:15:17 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay3.corp.sgi.com (Postfix) with ESMTP id DA14DAC003 for ; Tue, 4 Jun 2013 15:15:13 -0700 (PDT) X-ASG-Debug-ID: 1370384109-04cb6c5af81927e0001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id PuxNkpWdder3nnfV for ; Tue, 04 Jun 2013 15:15:09 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r54MF8Wn014645; Tue, 4 Jun 2013 18:15:09 -0400 Date: Tue, 4 Jun 2013 18:15:08 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: "Frank Ch. Eigler" , Dave Brolley Cc: pcp@oss.sgi.com Message-ID: <2144455046.18771690.1370384108925.JavaMail.root@redhat.com> In-Reply-To: <20130604203516.GB15065@redhat.com> References: <51AD5434.9090200@redhat.com> <1004356284.18217432.1370333038213.JavaMail.root@redhat.com> <51AE0706.9010507@redhat.com> <51AE4DD8.1070406@redhat.com> <20130604203516.GB15065@redhat.com> Subject: Re: Unix Domain Sockets MIME-Version: 1.0 X-ASG-Orig-Subj: Re: Unix Domain Sockets Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: Unix Domain Sockets Thread-Index: FF/ROy1BK9LF1BYP0tZX25CKKSqohw== X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1370384109 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.03 X-Barracuda-Spam-Status: No, SCORE=0.03 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH, THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.132971 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain Hey guys, ----- Original Message ----- > Hi - > > On Tue, Jun 04, 2013 at 04:28:08PM -0400, Dave Brolley wrote: > > We would then need a separate socket in the file system for each. i.e. > > /var/run/pcp/pmcd..socket. > (just to clarify, thats $PCP_RUN_DIR/pmcd.socket - pmcd should make use of pmGetConfig(3) when evaulating that path). > Or some other user-specified name. *nod*. > > Is it even possible to run multiple separate pmcds? There is only > > one /var/run/pcp/pmcd.pid afaikt. > > /var/run defaults are for distro-managed pmcd. A user that wishes to > run his own pmcd for some reason would have to override all the > defaults, including that pmcd.pid file, to avoid conflicts. *nod*. Or set PCP_DIR to point elsewhere, for a global prefix. Given the other mail, it sounds like a single unix socket is the way to go and the in-progress user/group permissions stuff will likely suffice for our needs here. cheers. -- Nathan From nscott@redhat.com Tue Jun 4 18:57:52 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 7A82429DF8 for ; Tue, 4 Jun 2013 18:57:52 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id 24CF2AC001 for ; Tue, 4 Jun 2013 16:57:48 -0700 (PDT) X-ASG-Debug-ID: 1370390261-04bdf0233f1a2340001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id ywOkMlt7Ge4uA9v5 for ; Tue, 04 Jun 2013 16:57:41 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r54NveVZ031645; Tue, 4 Jun 2013 19:57:41 -0400 Date: Tue, 4 Jun 2013 19:57:40 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Cc: Paul Evans Message-ID: <124219632.18792231.1370390260795.JavaMail.root@redhat.com> In-Reply-To: <170200043.18792001.1370390208377.JavaMail.root@redhat.com> Subject: pcp updates: pmdagfs2 updates, libpcp user/group acls, qa MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates: pmdagfs2 updates, libpcp user/group acls, qa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pcp updates: pmdagfs2 updates, libpcp user/group acls, qa Thread-Index: 2iB/svS5Nj0uVr7tLZIMBjGNht0rhA== X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1370390261 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.132979 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... Changes committed to git://oss.sgi.com/pcp/pcp.git dev configure | 23 configure.in | 5 qa/051 | 12 qa/051.out.1 | 1015 ----------------------------------- qa/051.out.4 | 1005 ++++++++++++++++++++++++++++++++++ qa/051.out.5 | 1006 ++++++++++++++++++++++++++++++++++ qa/449 | 9 qa/451 | 12 qa/470 | 12 qa/472 | 12 qa/473 | 12 qa/474 | 12 qa/475 | 12 qa/654 | 159 ++--- qa/654.out | 66 ++ qa/655 | 80 ++ qa/655.out | 70 ++ qa/GNUmakefile | 2 qa/common.filter | 3 qa/common.gfs2 | 134 ++++ qa/group | 1 qa/src/chkacc1.c | 16 qa/src/chkacc2.c | 16 qa/src/chkacc3.c | 8 qa/src/multithread2.c | 7 src/include/pcp/impl.h | 21 src/include/pcp/platform_header.h.in | 11 src/libpcp/src/GNUmakefile | 7 src/libpcp/src/access.c | 727 ++++++++++++++++++++++--- src/libpcp/src/accounts.c | 445 +++++++++++++++ src/libpcp/src/check-statics | 14 src/libpcp/src/internal.h | 6 src/libpcp/src/util.c | 107 --- src/pmcd/src/client.c | 2 src/pmcd/src/config.c | 205 +++++-- src/pmcd/src/pmcd.c | 5 src/pmdas/gfs2/GNUmakefile | 11 src/pmdas/gfs2/Install | 14 src/pmdas/gfs2/control.c | 121 +++- src/pmdas/gfs2/control.h | 31 + src/pmdas/gfs2/glocks.c | 1 src/pmdas/gfs2/glocks.h | 2 src/pmdas/gfs2/glstats.c | 119 +++- src/pmdas/gfs2/glstats.h | 57 + src/pmdas/gfs2/help | 271 ++++++--- src/pmdas/gfs2/lock_time.c | 940 +++++++++++++++++++++----------- src/pmdas/gfs2/lock_time.h | 117 +++- src/pmdas/gfs2/pmda.c | 270 +++++++-- src/pmdas/gfs2/pmdagfs2.h | 19 src/pmdas/gfs2/pmns | 36 + src/pmdas/gfs2/root | 9 src/pmdas/gfs2/sbstats.c | 11 src/pmdas/gfs2/sbstats.h | 2 src/pmlogger/ports.c | 4 54 files changed, 5327 insertions(+), 1967 deletions(-) commit c515049b166e5dfb3d43967a835fa3dcfb7f75f7 Merge: c607456 71399c3 Author: Nathan Scott Date: Wed Jun 5 09:16:47 2013 +1000 Merge branch 'dev' into gfs2 commit 71399c38a111a17368fe4bd7bcb0703f41085e12 Author: Nathan Scott Date: Wed Jun 5 09:07:08 2013 +1000 Convert the multi-threaded tests to use runtime feature detection The multi-threaded tests were all using the presence of a macro in the installed pcp/impl.h to determine whether they should run. This is problematic in that the header may be out of date, or may not be present at all if the devel package not installed. Now that we have a libpcp runtime feature test mechanism, use it. commit 744ecdac511f4905e8e8dd47f71c13af36208434 Author: Nathan Scott Date: Wed Jun 5 09:03:18 2013 +1000 Laying the groundwork for user and group access control lists Core functionality for user and group additions to the existing host based access control mechanism. Adds configure checks for reentrant/otherwise pwent and grent APIs. Support in libpcp for adding users and groups to access lists, for dumping these lists (diagnostics), and for saving/restoring lists. All user/group functionality in libpcp shifted into new accounts.c source file which provides platform-specific implementations making use of the appropriate pwent/grent APIs for each platform. Extensions to the pmcd access control parser to add the new keyworks for host/user/group differentiation on each access line (defaults to host, for backward-compatibility). Abstract the name parsing into a shared routine (ParseNames) used by all three of the ACL types. And switch pmcd diagnostic interfaces to make it report on all types. QA test modifications allow for the additional diagnostics with user and group ACLs alongside hosts. commit c6074566db75e6149eab7d7b57b1923cbaa126b8 Author: Paul Evans Date: Tue Jun 4 14:00:54 2013 +0100 pmdagfs2: gfs2_store() related cleanup and fixes to QA tests qa/654 qa/654 Removed the needless on-stack "value" local variable in gfs2_store() and all other related code belonging to it. Fixed both QA tests to exercise the pmda 654 runs and can now be passed on any machine that has the gfs2 modules through the use of loop-back mounted filesystems (expects no mounted gfs2 filesystem). 654.out has been updated in order to match the expected outcome of running this test. 655 has been updated to be able to exercise the gfs2_glock_lock_time metrics. In order to simulate a correct run, the test machine requires gfs2 modules to be loaded, an install with support for the additional gfs2 tracepoints and additionally a filesystem must be loaded in a shared cluster environment configuration. Because a locally mounted filesystem will not work, additional checks for cman are made otherwise the test will not run. An expected 655.out has been produced for this test. common.gfs2 has been updated to reflect the new changes made to both of the 654 and 655 QA tests. commit e7311d3443e3e5c4c5bf50751c4dfe950bb56f40 Author: Nathan Scott Date: Sat May 25 11:28:34 2013 +1000 Minor qa test tidying - update comments, dup localconfig use commit 9b97f90e2431607f0115b98e7920ac6c4ce35b2d Author: Nathan Scott Date: Fri May 24 17:12:49 2013 +1000 Bug fixes and refactoring in gfs2_refresh_lock_time The cache cull call on the lock_time_indom was being done inside the loop which accumulates glock stats; therefore whenever it takes multiple reads to consume the available glock stats, those from the previous reads would have been accidentally culled. One reason this was not immediately obvious, perhaps, was that the code to extract a single glock stat was interwoven within gfs2_refresh_lock_time - I've moved this out into its own function which clarifies things (to my eyes at least). It then also became clear that the "hash==NULL" check here can never fail, since hash is an on-stack buffer, so I simply removed that (dead) error-checking branch. Finally, this refactoring also makes the last buglet a bit clearer - we fopen a file (allocates and returns a FILE*), then extract the fd via fileno(3), but when we are cleaning up at the end we call close on the fd and not fclose on the fp - which leaks the FILE* structure. commit b031f3488296305c55ab1f1090f7408541a1b9c7 Author: Nathan Scott Date: Fri May 24 17:01:33 2013 +1000 Simplify pmdagfs2 gfs.control metric implementation a bit Removes an unreachable return case from gfs2_control_fetch, and makes the code a little more generalised (no switch). Simpligies gfs_control_check_value in two ways - removes a branch which (re)sets local "value" variable to zero, which it already was guaranteed to be (dead code removal). Also, make the onstack char array ("buffer") word aligned to make life easier for the compiler. commit 1c32e9cb98100bcfffd434826be1f31545aea7ae Author: Nathan Scott Date: Fri May 24 16:56:25 2013 +1000 Fix shell syntax error in qa/654 - misspelt function name Resolves "654: line 54: _filler_pminfo: command not found". commit bf8928be2f1bdd5dbc359ab320321ffbb9d8ffe1 Author: Nathan Scott Date: Fri May 24 16:52:27 2013 +1000 Small code consistency cleanups in pmdagfs2 code Resolve a handful of remaining funciton open-brace code style differences in qa scripts and C code. Annotated a couple of lock_time.c routines as static. Major/minor device number handling code is consistently making use of unsigned integers now, and when we sscanf 'em from a string, add a check to make doubly sure that values were returned. Removed a no-longer-used struct declaration in a header file (lock_time.h - struct node / linkedList_t). Fixed some gsf2 -> gfs2 typos in comments. commit 6354c3540e8ac8b81d77abd2fad50a674c15a01a Author: Paul Evans Date: Thu May 23 16:51:30 2013 +0100 pmdagfs2: changes based on review feedback on pcp mailing list Made general improvements with code for the pmda over last time whilst taking on suggestions made by Nathan Scott. Have improved collection code for the glock_lock_time trace-point metrics as well as switching to the provided pmdaCache(3) data structure instead of a home made linked-list datastructure. Introduced a new gfs2.control.glock_lock_time metric which can be used to enable/disable the glock_lock_time statistic collection based on its value, this can be set using pmStore(3)on this metric. On installs without the support for trace-point based statistics, the metrics are disabled by default because the necessary config files will not be found. Cleaned up the collection loop for the trace-point data, have moved to a single loop that removes the dependency on allocation of dynamic memory to achieve collection of the data. These changes will reduce the memory requirements of the pmda and speeds up the pmda with less iteration of the data. Changed the data structure to hold our collected data, we have gone from home made linked-list to the available pmdaCache(3) this reduces the amount of code, simplifies reading and reduces again the amount of iteration of the locks we have (no more remove duplicate and easier addition through a well defined hash). Changed the collection rate by changing the calling gfs2_refresh_lock_time() from once-per each file-system to once for all file-systems, this reduces the complexity of data storage. Reducing potential of lost lock data in-between refreshes. Changed the number of calls to gfs2_refresh_lock_time() from once per each filesystem to now being called once for all file-systems also removed forgotten testing code that was left within the gfs2_fetch_refresh function. Separated instance refresh so that the collection of dev_id is handled within another function in order to increase code readability. Introduced the necessary pmStore(3) hooks so that we can use the control based metrics to handle whether we are collecting statistics from the trace-point based metrics borrowing from the techniques used in the linux pmda. Split the QA files into two halves, the first 654 handles testing of the base part of the pmda (glstats, sbstats, glocks metrics). 655 then handles testing for the trace-point based metrics with not_run escapes in an event that trace-point based metrics are not available for the install (i.e. Debian unstable?). A new common.gfs2 script handles common functions used in both of the tests. commit 656068f562c5eed45bb84690e8648ff546e001ad Author: Nathan Scott Date: Wed May 1 11:44:00 2013 +1000 Rework the gfs2 qa test handling of trace file enablement Needs to take care that superuser privilege has been aquired, and if the file doesn't exist, we need to use _notrun rather than failing the test with an echo message. commit 3b11a4637465e9b0a84ca4ab05b311fd6ad5de7c Author: Nathan Scott Date: Wed May 1 11:38:04 2013 +1000 Fix typo in a pmdagfs2 comment commit 449c286a9f92968fd6fcef3e6729ab35ac4e311f Author: Paul Evans Date: Tue Apr 30 13:04:52 2013 +0100 Changes to pmdagfs2 to add addtional filesystem metrics and their corresponding help text. Changed the location on where the indom cache fetched filesystem names to /sys/fs/gfs2/ to allow the additional query for the device id of the filesystem which is needed for the gfs2_glock_lock_time tracepoint metrics. Also added the required code to support the additional metrics. Added metrics for glstats "/sys/kernel/debug/gfs2//glstats" these metrics can count the number of glocks that exists currently for the filesystem and separate how many per type of glock. Added metrics for the gfs2_glock_lock_time tracepoint. These metrics determine the current *worst* glock for the filesystem at the time of query. The data is fetched from "/sys/kernel/debug/tracing/trace_pipe" which lists the values of glocks for all filesystems as they are updated in (real-time). We read through the pipe taking all of the buffered values and calculate which is our worst glock, the device id for each filesystem is used to separate the locks for each filesystem. Created some additional qa tests in "qa/654". From nscott@redhat.com Tue Jun 4 19:09:29 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id DEA1029DF8 for ; Tue, 4 Jun 2013 19:09:29 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id 78285AC003 for ; Tue, 4 Jun 2013 17:09:26 -0700 (PDT) X-ASG-Debug-ID: 1370390965-04bdf0233c1a29d0001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id CdMuiWiHShcGUlTu for ; Tue, 04 Jun 2013 17:09:25 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5509OCP019653; Tue, 4 Jun 2013 20:09:24 -0400 Date: Tue, 4 Jun 2013 20:09:24 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Paul Evans Cc: pcp@oss.sgi.com Message-ID: <634736889.18802660.1370390964893.JavaMail.root@redhat.com> In-Reply-To: <51ADEB1F.1060004@redhat.com> References: <517FBD63.3010804@redhat.com> <1117296374.7864618.1367373452615.JavaMail.root@redhat.com> <5180D92F.40809@redhat.com> <519E43ED.8020701@redhat.com> <1691226900.12032333.1369450053711.JavaMail.root@redhat.com> <51ADEB1F.1060004@redhat.com> Subject: Re: [pcp] Patch: gfs2 PMDA additional metrics for review/inclusion MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] Patch: gfs2 PMDA additional metrics for review/inclusion Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: Patch: gfs2 PMDA additional metrics for review/inclusion Thread-Index: aeMypUm18+7mXnMIp1AltYcHW0uhtg== X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1370390965 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.03 X-Barracuda-Spam-Status: No, SCORE=0.03 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH, THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.132979 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain ----- Original Message ----- > Hi Nathan, > > I've completed another round of changes as based on your comments and > fixed the issues with the QA tests: > ... > These changes are available at git://github.com/pauljevans/pcp.git gfs2 > Looks good to me - thanks; all merged into dev now, and test 654 passing. I don't have a cluster setup, so 655 notruns for me - but thats fine. In some future update, might want to add a note into common.gfs2 about whats involved in setting up a gfs2 cluster (or add URL pointers to other docs) so that folks doing testing can opt-in to running that test too. cheers. -- Nathan From mgoodwin@redhat.com Tue Jun 4 22:52:29 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id BCFE829DF8 for ; Tue, 4 Jun 2013 22:52:29 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id 9B5038F8037 for ; Tue, 4 Jun 2013 20:52:26 -0700 (PDT) X-ASG-Debug-ID: 1370404345-04bdf0233c1acd80001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id LdEpjZxmTe5ZAl54 for ; Tue, 04 Jun 2013 20:52:25 -0700 (PDT) X-Barracuda-Envelope-From: mgoodwin@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r553qOpx011780 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 Jun 2013 23:52:25 -0400 Received: from fletch.usersys.redhat.com (vpn1-51-142.bne.redhat.com [10.64.51.142]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r553qMQt020244 for ; Tue, 4 Jun 2013 23:52:24 -0400 Message-ID: <51AEB5F4.4000601@redhat.com> Date: Wed, 05 Jun 2013 13:52:20 +1000 From: Mark Goodwin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20130206 Thunderbird/14.0 MIME-Version: 1.0 To: pcp Subject: pcpqa updates Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-ASG-Orig-Subj: pcpqa updates Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1370404345 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 Changes committed to git://oss.sgi.com/markgw/pcp/pcp.git dev commit 478766e37e9009263c7c3867bea25bbdb5237dd0 Author: Mark Goodwin Date: Wed Jun 5 13:47:23 2013 +1000 QA for collectl2pcp - first batch of tests, more still needed. modified: qa/536 modified: qa/536.out new file: qa/collectl/dynamic_instances.raw new file: qa/collectl/missing_instances.raw new file: qa/collectl/rhel6.raw.gz new file: qa/collectl/some_host.raw new file: qa/collectl/some_host_later.raw new file: qa/collectl/truncated.raw new file: qa/collectl/wrong_host.raw Signed-off-by: Mark Goodwin From brolley@redhat.com Wed Jun 5 15:32:32 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 8A08A7CBF for ; Wed, 5 Jun 2013 15:32:32 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay3.corp.sgi.com (Postfix) with ESMTP id 177EDAC002 for ; Wed, 5 Jun 2013 13:32:28 -0700 (PDT) X-ASG-Debug-ID: 1370464347-04cb6c5af91e1490001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id 4nIKYNEIR6u4ISZV for ; Wed, 05 Jun 2013 13:32:28 -0700 (PDT) X-Barracuda-Envelope-From: brolley@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r55KWRVt007582 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 5 Jun 2013 16:32:27 -0400 Received: from [10.10.50.115] (vpn-50-115.rdu2.redhat.com [10.10.50.115]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r55KWQZg017940; Wed, 5 Jun 2013 16:32:26 -0400 Message-ID: <51AFA054.8030005@redhat.com> Date: Wed, 05 Jun 2013 16:32:20 -0400 From: Dave Brolley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Nathan Scott CC: "Frank Ch. Eigler" , pcp@oss.sgi.com Subject: Re: Unix Domain Sockets References: <51AD5434.9090200@redhat.com> <1004356284.18217432.1370333038213.JavaMail.root@redhat.com> <51AE0706.9010507@redhat.com> <51AE4DD8.1070406@redhat.com> <20130604203516.GB15065@redhat.com> <2144455046.18771690.1370384108925.JavaMail.root@redhat.com> X-ASG-Orig-Subj: Re: Unix Domain Sockets In-Reply-To: <2144455046.18771690.1370384108925.JavaMail.root@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1370464347 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 Some file system permission issues have cropped up. It have a couple of solutions, but would like additional input. Unix(7) says that unlink(3) or remove(3) must be called on the file system object created after the address is bound (/var/run/pcp/pmcd.socket in our case) in order to remove it after the socket is closed. Actually, the unlink/remove can happen at any time after binding and the object will then be removed when the socket is closed (the link count becomes zero). Indeed, experimentation shows that failing to call remove/unlink on the object results in EADDRINUSE the next time pmcd tries to bind to this address. The problem is one of euid and file system permissions when running as a daemon, as installed. /var/run/pcp is 'drwxr-xr-x. 2 root root' which is fine when opening the socket, as the daemon is running as root. However at shutdown time, it is running as pcp and, so, the remove/unlink fails with EACCESS. I have 2 solutions and would like some help in choosing or perhaps there is another solution: 1) unlink/remove the object immediately after binding while we are still root. In this case, according to remove(3) (which calls unlink(3) in this case) and Unix(7), the object's name is removed from the directory listing, but the object continues to exist and the socket remains available until it is closed. The effect is that the object is no longer visible in /var/run/pcp (e.g. can't see it with ls) but continues to exist and remains usable until the socket is closed. Experimentation confirms that this is the case. 2) Rework the permissions of /var/run/pcp so that they are 'drwxrwxr-x. 2 root pcp'. In this case, the object is visible in var/run/pcp and can be successfully removed at shutdown time. I'm leaning toward option 1) as it makes no assumptions about the file system permissions or about running in daemon mode (as installed or otherwise). Does anyone have a preference or, perhaps, a better solution? Thanks, Dave From fche@redhat.com Wed Jun 5 16:00:36 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 819177CBF for ; Wed, 5 Jun 2013 16:00:36 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id 7125C8F8054 for ; Wed, 5 Jun 2013 14:00:33 -0700 (PDT) X-ASG-Debug-ID: 1370466032-04cbb046911e9540001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id x2KMlMZXCLiRjoTs for ; Wed, 05 Jun 2013 14:00:32 -0700 (PDT) X-Barracuda-Envelope-From: fche@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r55L0N2q015349 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 5 Jun 2013 17:00:31 -0400 Received: from fche.csb (vpn-62-51.rdu2.redhat.com [10.10.62.51]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r55L01Kj008535; Wed, 5 Jun 2013 17:00:01 -0400 Received: by fche.csb (Postfix, from userid 2569) id C993F5816C; Wed, 5 Jun 2013 17:00:00 -0400 (EDT) Date: Wed, 5 Jun 2013 17:00:00 -0400 From: "Frank Ch. Eigler" To: Dave Brolley Cc: Nathan Scott , pcp@oss.sgi.com Subject: Re: Unix Domain Sockets Message-ID: <20130605210000.GC15065@redhat.com> X-ASG-Orig-Subj: Re: Unix Domain Sockets References: <51AD5434.9090200@redhat.com> <1004356284.18217432.1370333038213.JavaMail.root@redhat.com> <51AE0706.9010507@redhat.com> <51AE4DD8.1070406@redhat.com> <20130604203516.GB15065@redhat.com> <2144455046.18771690.1370384108925.JavaMail.root@redhat.com> <51AFA054.8030005@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51AFA054.8030005@redhat.com> User-Agent: Mutt/1.4.2.2i X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1370466032 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 Hi - On Wed, Jun 05, 2013 at 04:32:20PM -0400, Dave Brolley wrote: > [...] Indeed, experimentation shows that failing to call > remove/unlink on the object results in EADDRINUSE the next time pmcd > tries to bind to this address. Correct, canonical unix-domain-socket code examples do unlink(2) *before* the bind(2) for this reason. (They can also do an unlink at program shutdown, just for filesystem cleanliness.) > The problem is one of euid and file system permissions when running as a > daemon, as installed. /var/run/pcp is 'drwxr-xr-x. 2 root root' [...] Ah indeed. > I have 2 solutions and would like some help in choosing or perhaps there > is another solution: > > 1) unlink/remove the object immediately after binding while we are still > root. (Note that it's not just the unlink that should require such privilege but also the initial bind.) > In this case, according to remove(3) (which calls unlink(3) in > this case) and Unix(7), the object's name is removed from the directory > listing, but the object continues to exist and the socket remains > available until it is closed. [...] Does this mean that *new* clients can connect to the unix-domain socket even after it's unlinked? That'd be very strange, and would seem to make it unnecessary to have all these unix-domain sockets sit around in a filesystem for longer than a split second. > 2) Rework the permissions of /var/run/pcp so that they are 'drwxrwxr-x. > 2 root pcp'. In this case, the object is visible in /var/run/pcp and can > be successfully removed at shutdown time. This is plausible to me. - FChE From brolley@redhat.com Wed Jun 5 16:16:22 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 705977CBF for ; Wed, 5 Jun 2013 16:16:22 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id 0B549AC006 for ; Wed, 5 Jun 2013 14:16:18 -0700 (PDT) X-ASG-Debug-ID: 1370466977-04cbb046911e9ed0001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id tjqED9taHcD0pKz4 for ; Wed, 05 Jun 2013 14:16:18 -0700 (PDT) X-Barracuda-Envelope-From: brolley@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r55LGHbl002313 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 5 Jun 2013 17:16:17 -0400 Received: from [10.10.50.115] (vpn-50-115.rdu2.redhat.com [10.10.50.115]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r55LGGST015877; Wed, 5 Jun 2013 17:16:17 -0400 Message-ID: <51AFAAA0.3090202@redhat.com> Date: Wed, 05 Jun 2013 17:16:16 -0400 From: Dave Brolley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: "Frank Ch. Eigler" CC: Nathan Scott , pcp@oss.sgi.com Subject: Re: Unix Domain Sockets References: <51AD5434.9090200@redhat.com> <1004356284.18217432.1370333038213.JavaMail.root@redhat.com> <51AE0706.9010507@redhat.com> <51AE4DD8.1070406@redhat.com> <20130604203516.GB15065@redhat.com> <2144455046.18771690.1370384108925.JavaMail.root@redhat.com> <51AFA054.8030005@redhat.com> <20130605210000.GC15065@redhat.com> X-ASG-Orig-Subj: Re: Unix Domain Sockets In-Reply-To: <20130605210000.GC15065@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1370466977 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 On 06/05/2013 05:00 PM, Frank Ch. Eigler wrote: >> In this case, according to remove(3) (which calls unlink(3) in >> this case) and Unix(7), the object's name is removed from the directory >> listing, but the object continues to exist and the socket remains >> available until it is closed. [...] > Does this mean that *new* clients can connect to the unix-domain > socket even after it's unlinked? That'd be very strange, and would > seem to make it unnecessary to have all these unix-domain sockets sit > around in a filesystem for longer than a split second. This is what I understood, although I haven't yet got to the point of trying to connect from clients yet. netstat does still show the socket is listening even though it's been unlinked. In re-reading unlink(2), perhaps you're right. It says that process that already have the handle may continue to use the socket. This would seem to exclude new clients. > > >> 2) Rework the permissions of /var/run/pcp so that they are 'drwxrwxr-x. >> 2 root pcp'. In this case, the object is visible in /var/run/pcp and can >> be successfully removed at shutdown time. > This is plausible to me. This along with an unlink before binding *and* at shutdown would seem optimal. That way if the socket really is still in use at startup time, it will stay that way, otherwise the stray object will be cleaned up. Dave From nscott@redhat.com Wed Jun 5 21:24:38 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id ABC5D29DF8 for ; Wed, 5 Jun 2013 21:24:37 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay3.corp.sgi.com (Postfix) with ESMTP id 28425AC002 for ; Wed, 5 Jun 2013 19:24:36 -0700 (PDT) X-ASG-Debug-ID: 1370485471-04cb6c5af81f1b10001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id Me0cAwusUazb3Cf9 for ; Wed, 05 Jun 2013 19:24:31 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r562OURW027721 for ; Wed, 5 Jun 2013 22:24:30 -0400 Date: Wed, 5 Jun 2013 22:24:30 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: PCP Message-ID: <1172659059.19621802.1370485470433.JavaMail.root@redhat.com> In-Reply-To: <488186212.19621698.1370485341508.JavaMail.root@redhat.com> Subject: pcp updates: collectl2pcp, qa MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates: collectl2pcp, qa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pcp updates: collectl2pcp, qa Thread-Index: pcxR9ypX6KwfCFxM7SxMJeuXu7sgHg== X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1370485471 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.133084 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... Changes committed to git://oss.sgi.com/pcp/pcp.git dev build/rpm/fedora.spec | 19 build/rpm/pcp.spec.in | 20 debian/GNUmakefile | 18 debian/control | 8 debian/pcp-import-collectl2pcp.install | 2 debian/rules | 5 man/man1/GNUmakefile | 2 man/man1/collectl2pcp.1 | 111 qa/536 | 97 qa/536.out | 78 qa/544 | 40 qa/544.out | 5002 +++++++++++++++++++++++++++++++ qa/GNUmakefile | 2 qa/collectl/GNUmakefile | 17 qa/collectl/debian_sid_defaults.raw.gz |binary qa/collectl/debian_sid_detailed.raw.gz |binary qa/collectl/dynamic_instances.raw | 40 qa/collectl/missing_instances.raw | 38 qa/collectl/rhel6.raw.gz |binary qa/collectl/some_host.raw | 43 qa/collectl/some_host_later.raw | 40 qa/collectl/truncated.raw | 38 qa/collectl/wrong_host.raw | 40 qa/group | 4 src/include/pcp/impl.h | 4 src/libpcp/src/access.c | 174 + src/libpcp/src/store.c | 9 src/pmcd/src/client.c | 31 src/pmcd/src/client.h | 2 src/pmcd/src/config.c | 12 src/pmcd/src/dopdus.c | 10 src/pmimport/GNUmakefile | 2 src/pmimport/collectl2pcp/.gitignore | 2 src/pmimport/collectl2pcp/GNUmakefile | 55 src/pmimport/collectl2pcp/collectl2pcp.c | 683 ++-- src/pmimport/collectl2pcp/cpu.c | 104 src/pmimport/collectl2pcp/disk.c | 111 src/pmimport/collectl2pcp/generic.c | 35 src/pmimport/collectl2pcp/header.c | 155 src/pmimport/collectl2pcp/load.c | 54 src/pmimport/collectl2pcp/metrics.c | 1668 ++++++++++ src/pmimport/collectl2pcp/metrics.h | 166 - src/pmimport/collectl2pcp/net.c | 138 src/pmimport/collectl2pcp/pmdesc.c | 84 src/pmimport/collectl2pcp/proc.c | 183 + src/pmimport/collectl2pcp/timestamp.c | 64 src/pmimport/collectl2pcp/util.c | 331 +- 47 files changed, 9268 insertions(+), 473 deletions(-) commit 709983e41759194bcf514559ee4df3846051274e Author: Nathan Scott Date: Thu Jun 6 12:18:36 2013 +1000 Fix problems found in testing collectl2pcp, esp process instances Some of the process metrics coming out of have tab-separation on certain fields, so remove the assumption that everything is space separated. Fix the process command name extraction (which becomes the inst name) - this was assuming all pids to be 5 characters, turns out they aren't always. Then, fix the way all the command line args were being dropped, these are expected/wanted in the per-process instance names. In extracting kernel.uname.distro drop the "Platform: xxx" suffix and add some (commented-out for now) code to export this through a new hinv.platform metric. Adds in qa test 544 to exercise the proc metrics in particular. commit e2ecaad175e081862dfae1f94f8f12645390be77 Author: Nathan Scott Date: Thu Jun 6 11:35:55 2013 +1000 Add in test data from default and detailed collectl runs on Debian Fills in some of Marks suggested remaining test items. In addition to verifying with the current-latest-collectl release here, this is adding in some more detailed pmval checks of the archive contents. commit df4889c3d1309562632aa21248b43e037907228f Author: Nathan Scott Date: Thu Jun 6 09:20:25 2013 +1000 Descend into collectl test data directory for pcp-testsuite packaging commit f1c76cc104a81a110bf728f3a36770e6ee8239e3 Merge: 1986289 478766e Author: Nathan Scott Date: Wed Jun 5 19:19:51 2013 +1000 Merge branch 'dev' of git://oss.sgi.com/markgw/pcp/pcp into dev commit 1986289c3b930ef9b4788e9cfc1941b41c660cc6 Author: Nathan Scott Date: Wed Jun 5 19:17:40 2013 +1000 Slight reduction in code in pmStore implementation, simpler commit 9c22519caaeb11c34862bf9f3797cc982aee75a8 Author: Nathan Scott Date: Wed Jun 5 19:16:48 2013 +1000 Account addition and deletion code for pmcd user/group ACL implementation Code for the pmcd client connection paths that does permission checks and performs the accounting for authenticated new client connections affected by user/group access controls. commit 478766e37e9009263c7c3867bea25bbdb5237dd0 Author: Mark Goodwin Date: Wed Jun 5 13:47:23 2013 +1000 QA for collectl2pcp - first batch of tests, more still needed. modified: qa/536 modified: qa/536.out new file: qa/collectl/dynamic_instances.raw new file: qa/collectl/missing_instances.raw new file: qa/collectl/rhel6.raw.gz new file: qa/collectl/some_host.raw new file: qa/collectl/some_host_later.raw new file: qa/collectl/truncated.raw new file: qa/collectl/wrong_host.raw Signed-off-by: Mark Goodwin commit 02e575095f1b4818da3ce8ec496a818decf944c0 Merge: bc7c164 0550e0f Author: Mark Goodwin Date: Mon Jun 3 19:27:44 2013 +1000 Merge branch 'dev' of git://oss.sgi.com/pcp/pcp into dev commit bc7c1645e2886873c5ef75912cb2224e8bf4079b Merge: f177810 43ee8b5 Author: Mark Goodwin Date: Wed May 29 13:50:10 2013 +1000 Merge branch 'dev' of git://oss.sgi.com/markgw/pcp/pcp into dev commit f177810188f127d2526065c233c313b9609cc38b Merge: 47ce416 d54962a Author: Mark Goodwin Date: Wed May 29 13:49:44 2013 +1000 Merge branch 'dev' of git://oss.sgi.com/pcp/pcp into dev commit 43ee8b54e762c1f4c1ac12dadffd53b69b3b2d30 Author: Mark Goodwin Date: Wed May 29 13:46:57 2013 +1000 Initial qa test for collectl2pcp new file: 536 new file: 536.out modified: group Signed-off-by: Mark Goodwin commit 1a2a50a05d50a3a1bdad471606562b4f144db913 Author: Mark Goodwin Date: Wed May 29 12:41:24 2013 +1000 Fix collectl2pcp build to handle pcp-libs-devel not installed in build root. Signed-off-by: Mark Goodwin commit 87cbeb4cda84b67770d594ba080dfe13d5cbacb4 Merge: d54962a 47ce416 Author: Mark Goodwin Date: Wed May 29 12:04:02 2013 +1000 Merge branch 'dev' of git://oss.sgi.com/markgw/pcp/pcp into dev commit 47ce4161dbe4799b2eb9c88f2644d3e766845870 Merge: bd0ed75 04736b4 Author: Mark Goodwin Date: Tue May 28 17:33:23 2013 +1000 Merge branch 'dev' of git://oss.sgi.com/pcp/pcp into dev commit bd0ed758e24987155a2d90a10c745e697eb30fc7 Author: Mark Goodwin Date: Tue May 28 17:22:14 2013 +1000 Adds support for more metrics (cpu, disk, net, mem.util, load, and some proc), improve parsing (replace strtok with "field" mini api), dynamic instance support (esp. for proc). Clean up main loop - split out header parsing, multiple input file temporal order checks. Rework cmdline args, man page update and improve archive layout for better replay performance. modified: man/man1/collectl2pcp.1 modified: src/pmimport/collectl2pcp/GNUmakefile modified: src/pmimport/collectl2pcp/collectl2pcp.c modified: src/pmimport/collectl2pcp/cpu.c modified: src/pmimport/collectl2pcp/disk.c new file: src/pmimport/collectl2pcp/generic.c new file: src/pmimport/collectl2pcp/header.c modified: src/pmimport/collectl2pcp/load.c modified: src/pmimport/collectl2pcp/metrics.h modified: src/pmimport/collectl2pcp/net.c new file: src/pmimport/collectl2pcp/proc.c modified: src/pmimport/collectl2pcp/timestamp.c modified: src/pmimport/collectl2pcp/util.c commit f19c74fa7d3f4882e77d63df156b66ed9cc637a2 Merge: 9a8dee1 1a35711 Author: Mark Goodwin Date: Sat May 18 08:18:03 2013 +1000 Merge branch 'dev' of git://oss.sgi.com/pcp/pcp into dev commit 9a8dee18447f4a019f28f3f36f90f341a9c81b0a Merge: d08ceaa 717347f Author: Mark Goodwin Date: Thu May 16 14:22:19 2013 +1000 Merge branch 'dev' of git://oss.sgi.com/pcp/pcp into dev commit d08ceaa19a20a7e1d2e217b6d80200f686ac6696 Merge: 0a4c3c7 5562a66 Author: Mark Goodwin Date: Tue May 14 15:42:36 2013 +1000 Merge branch 'dev' of git://oss.sgi.com/pcp/pcp into dev Fixed conflicts: man/man1/GNUmakefile commit 0a4c3c79b23cbfbe1d10169430bdcffab3143607 Author: Mark Goodwin Date: Tue May 14 15:34:54 2013 +1000 Tool to import collectl raw data archives to PCP archive. This is the initial version - so far it imports CPU, disk, network, loadavg and hinv metrics. It's functional but there are many TODO items. The tool is packaged in it's own subpackage, as is needed for most PCP import tools in order to isolate build and run-time dependencies from the main packages. modified: build/rpm/fedora.spec modified: build/rpm/pcp.spec.in modified: debian/GNUmakefile modified: debian/control new file: debian/pcp-import-collectl2pcp.install modified: debian/rules modified: man/man1/GNUmakefile new file: man/man1/collectl2pcp.1 modified: src/pmimport/GNUmakefile new file: src/pmimport/collectl2pcp/GNUmakefile new file: src/pmimport/collectl2pcp/collectl2pcp.c new file: src/pmimport/collectl2pcp/cpu.c new file: src/pmimport/collectl2pcp/disk.c new file: src/pmimport/collectl2pcp/load.c new file: src/pmimport/collectl2pcp/metrics.c new file: src/pmimport/collectl2pcp/metrics.h new file: src/pmimport/collectl2pcp/net.c new file: src/pmimport/collectl2pcp/pmdesc.c new file: src/pmimport/collectl2pcp/timestamp.c new file: src/pmimport/collectl2pcp/util.c From nscott@redhat.com Wed Jun 5 23:50:32 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 03C0029DF8 for ; Wed, 5 Jun 2013 23:50:32 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id E5DB6304075 for ; Wed, 5 Jun 2013 21:50:31 -0700 (PDT) X-ASG-Debug-ID: 1370494227-04cb6c5afa1f9400001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id WBxwhLzekVaD5VZU for ; Wed, 05 Jun 2013 21:50:27 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r564oQrJ026787 for ; Thu, 6 Jun 2013 00:50:26 -0400 Date: Thu, 6 Jun 2013 00:50:26 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: PCP Message-ID: <1856638687.19654240.1370494226653.JavaMail.root@redhat.com> In-Reply-To: <1242774355.19654151.1370494209841.JavaMail.root@redhat.com> Subject: pcp updates: collectl2pcp fixes, qa MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates: collectl2pcp fixes, qa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pcp updates: collectl2pcp fixes, qa Thread-Index: BvUB72Y1NV/WqIJ2wyB6I6kjHKnPHA== X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1370494227 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.133094 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... Changes committed to git://oss.sgi.com/pcp/pcp.git dev debian/control | 4 qa/544 | 131 qa/544.out | 5012 ------------------------------- src/pmimport/collectl2pcp/collectl2pcp.c | 38 src/pmimport/collectl2pcp/header.c | 4 src/pmimport/collectl2pcp/proc.c | 32 6 files changed, 195 insertions(+), 5026 deletions(-) commit 76839c44e9db808d2e8aeb64c3c550ebcee8f26e Author: Nathan Scott Date: Thu Jun 6 14:48:53 2013 +1000 collectl2pcp fixes and test 544 update for less verbosity Batch up a series of metric groups for pminfo, and checksum the results rather than dumping everything in the test. In doing this, noticed that hinv.ndisk was missing from one of the archives. Investigation revealed an off-by-one in the collectl file header parsing, resuling in that metric being inadvertantly skipped. In yet further discussions with Mark we noticed the process metrics proc.psinfo.cmd metric was not exporting the values as pmdaproc does (should be basename). So proc.psinfo.psargs added in with the original cmd value, as nature intended. commit 54a365884e3e0327f8e8c6eb6d95bc92be2d11df Author: Nathan Scott Date: Thu Jun 6 14:43:39 2013 +1000 Make collectl2pcp usage handling like other tools, ditch goto too commit b666b436d5260780c2c09019ae2351bcc2462dc2 Author: Nathan Scott Date: Thu Jun 6 14:42:46 2013 +1000 Correct debian packaging slightly - collectl2pcp is not noarch From nscott@redhat.com Thu Jun 6 17:18:08 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 56D487F37 for ; Thu, 6 Jun 2013 17:18:08 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay3.corp.sgi.com (Postfix) with ESMTP id C427EAC007 for ; Thu, 6 Jun 2013 15:18:07 -0700 (PDT) X-ASG-Debug-ID: 1370557081-04cb6c5af924b490001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id UFCGzfb7b3xOTi4f for ; Thu, 06 Jun 2013 15:18:01 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r56MI1Jj003716 for ; Thu, 6 Jun 2013 18:18:01 -0400 Date: Thu, 6 Jun 2013 18:18:01 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: PCP Message-ID: <1777138988.20335509.1370557081267.JavaMail.root@redhat.com> In-Reply-To: <1594037424.20334925.1370556910443.JavaMail.root@redhat.com> Subject: pcp updates: pmcollectl/pmatop, qa, hinv.ninterface MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates: pmcollectl/pmatop, qa, hinv.ninterface Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pcp updates: pmcollectl/pmatop, qa, hinv.ninterface Thread-Index: x/HtiaIu2InPbomKL/rHNyGYL2RNXw== X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1370557081 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.133164 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... Changes committed to git://oss.sgi.com/pcp/pcp.git dev debian/rules | 1 man/man1/pmatop.1 | 9 man/man1/pmcollectl.1 | 9 qa/544 | 1 qa/544.out | 4 qa/722 | 6 qa/722.out | 907 ++++++++++++++++++++---------------- qa/GNUmakefile | 4 qa/src/pmatop-722.0 |binary qa/src/pmatop-722.index |binary qa/src/pmatop-722.meta |binary src/pmatop/pmatop.py | 377 ++++++-------- src/pmcollectl/pmcollectl.py | 434 ++++++++--------- src/pmdas/linux/help | 1 src/pmdas/linux/pmda.c | 9 src/pmdas/linux/root_linux | 1 src/pmimport/collectl2pcp/header.c | 2 src/pmimport/collectl2pcp/metrics.c | 4 src/python/pcp/pmsubsys.py | 76 --- 19 files changed, 964 insertions(+), 881 deletions(-) commit 6d8d103055ca69230d0a1ffb934b32c4d1eef571 Author: Nathan Scott Date: Fri Jun 7 08:12:38 2013 +1000 Enable test 722 to run by default once more commit f3dc11171f31bf09d0bd6d2c3d9a1f625f59f26f Merge: a54660f 40232ce Author: Nathan Scott Date: Fri Jun 7 07:49:13 2013 +1000 Merge branch 'scox/dev' of ../pcpfans into dev commit a54660fb2b1fc782b401b073adc7e3bbf6d4a3af Author: Nathan Scott Date: Fri Jun 7 07:49:00 2013 +1000 Add new hinv.ninterface metric into pmdalinux and collectl2pcp commit 40232ce834529f08609559fecc99ccac37166b69 Author: Stan Cox Date: Thu Jun 6 17:18:14 2013 -0400 Use one object, Subsystem, for all system metrics. * qa/722.out: Fix LVM. * qa/src/pmatop-722*: New test archive. * pmsubsys.py (Subsystem): Collapse all classes into this one. * pmcollectl.py: Use Subsystem for _cpuCollectPrint, _interruptCollectPrint, _diskCollectPrint, _memoryCollectPrint, _netCollectPrint * pmatop.py: Use Subsystem for _ProcessorPrint, _InterruptPrint, _DiskPrint, _MemoryPrint, _NetPrint, _ProcPrint commit f0a8f82c9f02b7fdc842748cefa1f56dcd2e6009 Author: Nathan Scott Date: Thu Jun 6 16:18:21 2013 +1000 Correct the permissions on the installed common.gfs2 qa script file commit 1dd0151d7aa488c4d3e3a1d81e216478318e20ee Author: Nathan Scott Date: Thu Jun 6 16:17:52 2013 +1000 Add dh_link to debian build to fix up packaged relative symlinks commit f52de3efb0049c7f6b9171e643ce92696c427959 Author: Stan Cox Date: Wed May 29 12:48:14 2013 -0400 Allow metrics to come from another host. * pmatop.py (main): Add -h host. Use it to get a context. * pmcollectl.py (main): Likewise. * pmatop.1: Document -h. * pmcollectl.1: Likewise. From assa.contabilidad@gfarrera.com.mx Sun Jun 9 17:53:20 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=HTML_MESSAGE,T_FRT_CONTACT autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 85D9C29DF8 for ; Sun, 9 Jun 2013 17:53:20 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id 5BB1F304039 for ; Sun, 9 Jun 2013 15:53:17 -0700 (PDT) X-ASG-Debug-ID: 1370818392-04bdf02b8e11cd60001-S8gJnT Received: from mail.farrera.net (mail.farrera.net [201.134.223.179]) by cuda.sgi.com with ESMTP id RsIdZuDTS6UdOK26 for ; Sun, 09 Jun 2013 15:53:12 -0700 (PDT) X-Barracuda-Envelope-From: assa.contabilidad@gfarrera.com.mx X-Barracuda-Apparent-Source-IP: 201.134.223.179 Received: from localhost (localhost [127.0.0.1]) by mail.farrera.net (Postfix) with ESMTP id 07DC51F200F; Sun, 9 Jun 2013 17:31:54 -0500 (CDT) X-Virus-Scanned: amavisd-new at farrera.net Received: from mail.farrera.net ([127.0.0.1]) by localhost (mail.farrera.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t4FgCeMk9snW; Sun, 9 Jun 2013 17:31:53 -0500 (CDT) Received: from mail.farrera.net (mail.farrera.net [10.0.10.100]) by mail.farrera.net (Postfix) with ESMTP id 532DE1608478; Sun, 9 Jun 2013 17:31:53 -0500 (CDT) Date: Sun, 9 Jun 2013 17:31:53 -0500 (CDT) From: WERBUNG ZENTRUM Reply-To: WERBUNG ZENTRUM Message-ID: <374040601.27581.1370817113301.JavaMail.root@mail> Subject: Darlehen MIME-Version: 1.0 X-ASG-Orig-Subj: Darlehen Content-Type: multipart/alternative; boundary="----=_Part_27580_1908186757.1370817113300" X-Originating-IP: [42.152.65.46] X-Mailer: Zimbra 6.0.10_GA_2692 (ZimbraWebClient - SAF3 (Win)/6.0.10_GA_2692) To: undisclosed-recipients:; X-Barracuda-Connect: mail.farrera.net[201.134.223.179] X-Barracuda-Start-Time: 1370818392 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.50 X-Barracuda-Spam-Status: No, SCORE=0.50 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA620a, FUZZY_CREDIT, HTML_MESSAGE X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.133449 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 FUZZY_CREDIT BODY: Attempt to obfuscate words in spam 0.00 HTML_MESSAGE BODY: HTML included in message 0.50 BSF_SC0_SA620a Custom Rule SA620a ------=_Part_27580_1908186757.1370817113300 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Gr=C3=BC=C3=9Fe,=20 Diese Nachricht ist, Sie =C3=BCber unser Unternehmen saisonale Darlehen anb= ieten zu benachrichtigen.: Wir freuen uns, Sie =C3=BCber unser Unternehmen = finanzielle Werbung f=C3=BCr die Gew=C3=A4hrung finanzieller Hilfe der Hand= auf beide unsere alten und neuen Kunden im Bereich der pers=C3=B6nlichen D= arlehen, gewerbliche Kredite, Projektfinanzierungen, Kontraktion Kredite ei= nzuf=C3=BChren etc. Wir bieten alle Arten von Darlehen finanzieren-L=C3=B6s= ungen auf Ihre Bed=C3=BCrfnisse von Minimum Darlehen Angebot reicht von 20.= 000,00 =E2=82=AC anpassen, um maximale Reichweite von 10.000.000,00=E2=82= =AC zum Zinssatz von 2%. Greifen diese Lebensdauer finanzielles Angebot und= geben Sie Ihrem Unternehmen, Bildungseinrichtungen, Projekt, Bauen und Woh= nen ein Lift von oben bieten bieten.=20 Um das Darlehen Anwendung zu starten, sind Sie herzlich um uns zu beraten m= it den unten Details zur Abwicklung.=20 Darlehen Betrag:=20 Darlehen Dauer:=20 Telefon:=20 Land:=20 Gr=C3=BC=C3=9Fe,=20 Gesellschaft Direktor=20 Kredit Verwaltung=20 Von: Kunde Zentrum ------=_Part_27580_1908186757.1370817113300 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <= div style=3D'font-family: Times New Roman; font-size: 12pt; color: #000000'= >
Gr=C3=BC=C3=9Fe,
Diese Nachricht ist, Sie =C3=BCber u= nser Unternehmen saisonale Darlehen anbieten zu benachrichtigen.: Wir freue= n uns, Sie =C3=BCber unser Unternehmen finanzielle Werbung f=C3=BCr die Gew= =C3=A4hrung finanzieller Hilfe der Hand auf beide unsere alten und neuen Ku= nden im Bereich der pers=C3=B6nlichen Darlehen, gewerbliche Kredite, Projek= tfinanzierungen, Kontraktion Kredite einzuf=C3=BChren etc. Wir bieten alle = Arten von Darlehen finanzieren-L=C3=B6sungen auf Ihre Bed=C3=BCrfnisse von = Minimum Darlehen Angebot reicht von 20.000,00 =E2=82=AC anpassen, um maxima= le Reichweite von 10.000.000,00=E2=82=AC zum Zinssatz von 2%. Greifen diese= Lebensdauer finanzielles Angebot und geben Sie Ihrem Unternehmen, Bildungs= einrichtungen, Projekt, Bauen und Wohnen ein Lift von oben bieten bieten.

Um das Darlehen Anwendung zu starten, sind Sie herz= lich um uns zu beraten mit den unten Details zur Abwicklung.

=
Darlehen Betrag:
Darlehen Dauer:
Telefon:
Land:

Gr=C3=BC=C3=9Fe,
Gesellsch= aft Direktor
Kredit Verwaltung
Von: Kunde Zentrum
=
------=_Part_27580_1908186757.1370817113300-- From brolley@redhat.com Mon Jun 10 15:12:33 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 4FA397F37 for ; Mon, 10 Jun 2013 15:12:33 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id CED78AC007 for ; Mon, 10 Jun 2013 13:12:32 -0700 (PDT) X-ASG-Debug-ID: 1370895148-04cbb0469139a550001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id sG2aDwCDBGp2QlQg for ; Mon, 10 Jun 2013 13:12:28 -0700 (PDT) X-Barracuda-Envelope-From: brolley@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5AKCSWd029363 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 10 Jun 2013 16:12:28 -0400 Received: from [10.10.49.217] (vpn-49-217.rdu2.redhat.com [10.10.49.217]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5AKCRvK029980 for ; Mon, 10 Jun 2013 16:12:27 -0400 Message-ID: <51B6332A.90404@redhat.com> Date: Mon, 10 Jun 2013 16:12:26 -0400 From: Dave Brolley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: PCP Subject: Protecting AF_UNIX Code Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-ASG-Orig-Subj: Protecting AF_UNIX Code Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1370895148 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 Hi All, I see that some existing parts of pcp are using '#if !defined(IS_MINGW)' to protect against unsupported plattforms for AF_UNIX (e.g. src/libpcp_pmda/src/open.c) where I have been using '#if defined(HAVE_SYS_UN_H)' (already implemented in our autoconf stuff). We should probably be consistent. Is there a preference? Dave From nscott@redhat.com Mon Jun 10 18:08:15 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id C9C097F37 for ; Mon, 10 Jun 2013 18:08:15 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay3.corp.sgi.com (Postfix) with ESMTP id 544C8AC005 for ; Mon, 10 Jun 2013 16:08:15 -0700 (PDT) X-ASG-Debug-ID: 1370905690-04cb6c2a4110b3f0001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id FRrrBgeJnFvOSCgn for ; Mon, 10 Jun 2013 16:08:10 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5AN8ApT022419; Mon, 10 Jun 2013 19:08:10 -0400 Date: Mon, 10 Jun 2013 19:08:10 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Dave Brolley Cc: PCP Message-ID: <219290143.22611866.1370905690066.JavaMail.root@redhat.com> In-Reply-To: <51B6332A.90404@redhat.com> References: <51B6332A.90404@redhat.com> Subject: Re: [pcp] Protecting AF_UNIX Code MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] Protecting AF_UNIX Code Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: Protecting AF_UNIX Code Thread-Index: thAC0Q5S5YMK1uWdrcBkQfyzjyErHQ== X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1370905690 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.03 X-Barracuda-Spam-Status: No, SCORE=0.03 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH, THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.133545 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain Hi Dave, ----- Original Message ----- > Hi All, > > I see that some existing parts of pcp are using '#if !defined(IS_MINGW)' > to protect against unsupported plattforms for AF_UNIX (e.g. > src/libpcp_pmda/src/open.c) where I have been using '#if > defined(HAVE_SYS_UN_H)' (already implemented in our autoconf stuff). > > We should probably be consistent. Is there a preference? Strictly speaking the macro being used to protect conditional code compilation should match up with the thing it is protecting. So the header #include should be protected by HAVE_SYS_UN_H and the use of socket(AF_UNIX, ...) should be protected by HAVE_AF_UNIX. "Someone" (i.e. me) was a bit lazy on the latter and went with a pre-existing platform check macro (IS_MINGW) rather than adding a new configure macro. We should fix it by adding HAVE_AF_UNIX and make use of that in the body of the code IMO. Also the error message in that library code you mentioned should not refer to Windows explicitly, rather it should say ..., "__pmdaOpenUnix: Not supported on this platform"). cheers. -- Nathan From nscott@redhat.com Tue Jun 11 01:23:32 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 2347529DF8 for ; Tue, 11 Jun 2013 01:23:32 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id 0CB1B8F804B for ; Mon, 10 Jun 2013 23:23:32 -0700 (PDT) X-ASG-Debug-ID: 1370931804-04cbb0468e3bdcc0001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id qoONrKCGkZHoH2zn for ; Mon, 10 Jun 2013 23:23:24 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5B6NOqP025425 for ; Tue, 11 Jun 2013 02:23:24 -0400 Date: Tue, 11 Jun 2013 02:23:24 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: PCP Message-ID: <1910630807.22689483.1370931804487.JavaMail.root@redhat.com> In-Reply-To: <1157846510.22688254.1370931645928.JavaMail.root@redhat.com> Subject: pcp updates: mostly user/group ACLs MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates: mostly user/group ACLs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pcp updates: mostly user/group ACLs Thread-Index: tDxVdqRmro60oeEyWGm/d0X33eRLlQ== X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1370931804 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.133575 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... Changes committed to git://oss.sgi.com/pcp/pcp.git dev configure | 143 +++++++++++++++++++++++++++----- configure.in | 111 ++++++++++++++---------- qa/qa_hosts.master | 1 src/include/pcp/impl.h | 4 src/include/pcp/platform_header.h.in | 19 ++++ src/libpcp/src/GNUmakefile | 4 src/libpcp/src/access.c | 87 +++++++++++-------- src/libpcp/src/accounts.c | 156 ++++++++++++++++++++++++++--------- src/libpcp/src/internal.h | 22 +++- src/libpcp/src/win32.c | 100 +++++++++++++++++++++- src/pmcd/src/client.c | 23 +---- src/pmdas/linux/help | 4 12 files changed, 505 insertions(+), 169 deletions(-) commit 94a7c1581cc84cbe5c5f62e530d3747bb9b3713f Author: Nathan Scott Date: Tue Jun 11 16:13:19 2013 +1000 Push uid/gid details slightly further down in libpcp (out of impl.h) This removes the assumption from the __pmAccAddAccount interface that a uid and gid can be represented by an integer, which is not portable it turns out (fortunately, we don't need to make assumption as all of the low-level authentication/SASL2 code fundamentally using values as strings, which is just right for our needs here too). Adds configure.in check for uid_t, gid_t and SID (Win32 Security ID). While in there, added a sys/socket.h AF_UNIX check for Dave. commit 2ba8cf2f9bfa19704cd44a75411806f0331bfec7 Author: Nathan Scott Date: Tue Jun 11 13:23:04 2013 +1000 Add another QA testing host into my local mix commit 1899c5a48d8e8e6c863d53ce0742172d28811a49 Author: Nathan Scott Date: Tue Jun 11 13:22:47 2013 +1000 Make POSIX user/group account lookup code not built for Win32 commit 232237f32b8ed4eaa555f19052e8c262ef33e023 Author: Nathan Scott Date: Tue Jun 11 12:53:41 2013 +1000 Add missing help text for some Linux kernel hinv.map metrics Recently added hinv.map.lvname needed some help text added, as did hinv.map.cpu_node which has been missing some for years. commit f39dd5c3b5bbbd1c0cbdddcc568bf29335e061f2 Author: Nathan Scott Date: Fri Jun 7 15:36:18 2013 +1000 Correct the way the user list associated with a group is evaluated Previously we were only adding users explicitly listed in the groups file into a groups UID list - this meant the primary group in passwd file was not taken into account. In addition to fixing this, add in checks that no duplicates are ever added to the UID list. commit 0905d5664a417d670cb46a38ddc2ccb092f5713d Author: Nathan Scott Date: Fri Jun 7 15:30:16 2013 +1000 Report user/group ACLs descending like hosts, with catch-all case last From brolley@redhat.com Tue Jun 11 10:07:21 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 1EEB229DF8 for ; Tue, 11 Jun 2013 10:07:21 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id F3B89304053 for ; Tue, 11 Jun 2013 08:07:20 -0700 (PDT) X-ASG-Debug-ID: 1370963237-04cb6c2a4714c4a0001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id AFb2EEBRJxxtOALV for ; Tue, 11 Jun 2013 08:07:17 -0700 (PDT) X-Barracuda-Envelope-From: brolley@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5BF7GVS018536 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 11 Jun 2013 11:07:16 -0400 Received: from [10.10.55.6] (vpn-55-6.rdu2.redhat.com [10.10.55.6]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5BF7F2w022094; Tue, 11 Jun 2013 11:07:16 -0400 Message-ID: <51B73D23.5000109@redhat.com> Date: Tue, 11 Jun 2013 11:07:15 -0400 From: Dave Brolley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Nathan Scott CC: PCP Subject: Re: [pcp] Protecting AF_UNIX Code References: <51B6332A.90404@redhat.com> <219290143.22611866.1370905690066.JavaMail.root@redhat.com> X-ASG-Orig-Subj: Re: [pcp] Protecting AF_UNIX Code In-Reply-To: <219290143.22611866.1370905690066.JavaMail.root@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1370963237 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 On 06/10/2013 07:08 PM, Nathan Scott wrote: > Strictly speaking the macro being used to protect conditional code > compilation should match up with the thing it is protecting. So the > header #include should be protected by HAVE_SYS_UN_H and the use of > socket(AF_UNIX, ...) should be protected by HAVE_AF_UNIX. "Someone" > (i.e. me) was a bit lazy on the latter and went with a pre-existing > platform check macro (IS_MINGW) rather than adding a new configure > macro. We should fix it by adding HAVE_AF_UNIX and make use of that in > the body of the code IMO. Also the error message in that library code > you mentioned should not refer to Windows explicitly, rather it should > say ..., "__pmdaOpenUnix: Not supported on this platform"). cheers. -- > Nathan I want to argue that the presence of the header implies the presence of the macro, but I don't know if that's actually true. Dave From nscott@redhat.com Tue Jun 11 18:46:28 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 63D1129DF8 for ; Tue, 11 Jun 2013 18:46:28 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id E8D4BAC006 for ; Tue, 11 Jun 2013 16:46:24 -0700 (PDT) X-ASG-Debug-ID: 1370994380-04cbb04690406cd0001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id DXrwPMlsVqJ9BppX for ; Tue, 11 Jun 2013 16:46:20 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5BNkKV3014857; Tue, 11 Jun 2013 19:46:20 -0400 Date: Tue, 11 Jun 2013 19:46:20 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Dave Brolley Cc: PCP Message-ID: <627036805.23846707.1370994380239.JavaMail.root@redhat.com> In-Reply-To: <51B73D23.5000109@redhat.com> References: <51B6332A.90404@redhat.com> <219290143.22611866.1370905690066.JavaMail.root@redhat.com> <51B73D23.5000109@redhat.com> Subject: Re: [pcp] Protecting AF_UNIX Code MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] Protecting AF_UNIX Code Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: Protecting AF_UNIX Code Thread-Index: HsN8GsA7FXPkhJl1Fh0h36gvaOstrQ== X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1370994380 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.03 X-Barracuda-Spam-Status: No, SCORE=0.03 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH, THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.133642 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain Hi Dave, ----- Original Message ----- > On 06/10/2013 07:08 PM, Nathan Scott wrote: > > Strictly speaking the macro being used to protect conditional code > > compilation should match up with the thing it is protecting. ... > > I want to argue that the presence of the header implies the presence of > the macro, but I don't know if that's actually true. As discussed on IRC, MinGW headers define AF_UNIX for some inexplicable reason which complicates things yet further. I've pushed in a change to add HAVE_STRUCT_SOCKADDR_UN which appears to be an unambiguous, portable test we can use. Also, as mentioned on IRC, even on the Unix variants AF_UNIX is defined in sys/socket.h and not sys/un.h ... heh, what a twisty maze. cheers. -- Nathan From nscott@redhat.com Wed Jun 12 03:49:00 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 7F9C97CBF for ; Wed, 12 Jun 2013 03:49:00 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id 52A0D8F8049 for ; Wed, 12 Jun 2013 01:48:57 -0700 (PDT) X-ASG-Debug-ID: 1371026929-04bdf0233e42e1e0001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id MSA81kzmKCbuI6yn for ; Wed, 12 Jun 2013 01:48:50 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5C8mnTN004877 for ; Wed, 12 Jun 2013 04:48:49 -0400 Date: Wed, 12 Jun 2013 04:48:49 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: PCP Message-ID: <558715630.23966194.1371026929717.JavaMail.root@redhat.com> In-Reply-To: <742570508.23966097.1371026899281.JavaMail.root@redhat.com> Subject: pcp updates: pmdaproc, user/group ACLs MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates: pmdaproc, user/group ACLs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pcp updates: pmdaproc, user/group ACLs Thread-Index: 6eIpL09qSTqO2VbHk4mbFczfY1NbRw== X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1371026929 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Barracuda-BRTS-Status: 1 X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.133678 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... Changes committed to git://oss.sgi.com/pcp/pcp.git dev configure | 67 ++++++++-------- configure.in | 45 +++++------ qa/546 | 108 +++++++++++++++++++++++++++ qa/546.out | 45 +++++++++++ qa/group | 1 src/dbpmda/src/pmda.c | 2 src/include/pcp/platform_header.h.in | 10 +- src/libpcp/src/access.c | 93 +++++++++++++---------- src/libpcp_pmda/src/open.c | 8 -- src/pmcd/src/config.c | 4 - src/pmcd/src/dopdus.c | 9 +- src/pmdas/linux_proc/GNUmakefile | 5 - src/pmdas/linux_proc/contexts.c | 139 +++++++++++++++++++++++++++++++++++ src/pmdas/linux_proc/contexts.h | 44 +++++++++++ src/pmdas/linux_proc/pmda.c | 42 ++++------ src/pmdas/linux_proc/proc_pid.c | 6 - 16 files changed, 483 insertions(+), 145 deletions(-) commit a096510f0905b99b714955ce0fcc9555befd9ea2 Author: Nathan Scott Date: Wed Jun 12 18:45:36 2013 +1000 Implement per-context connection tracking in Linux process PMDA Introduces knowledge of each connection, and its security attrs (particularly uid and gid), in pmdaproc. This allows a suitably configured pmcd process (with user/group ACLs) and authenticated client connections to be able to retrieve sensitive information for the specific authenticated user and not others. Without ACL specification in pmcd.conf the behaviour is unchanged from today (i.e. pmdaproc always runs as root and can access everything). Exercised using dbpmda only so far, further automated testing to follow in later commits. commit 50d42cd83bc37b4a710a1526edbe6c12f63a0ec8 Author: Nathan Scott Date: Wed Jun 12 14:04:14 2013 +1000 Correct the logic in pmcd around enabling user/group access controls Needed to deal differently with the case where no ACLs are present, and the case where ACLs are present but no account information is available on the new clients connection. Also ensure the initial (wildcard) entry has a default-restrictive set of permissions, not default-to-open. Test case 546 added to exercise user/group ACL extensions to the pmcd configuration file parsing (error handling cases in particular). Finally, update several cases of direct uid/gid comparisons; need to use the accessor methods if this is ever to work on non-POSIX platforms. commit 0644708899cc6643ca42a00e2a478eca086a1c60 Author: Nathan Scott Date: Wed Jun 12 09:18:46 2013 +1000 Update the unix domain sockets configure checking It turns out that the current mingw headers (esp from the mingw64 project) define AF_UNIX, so testing for this is problematic. The structure sockaddr_un is not defined however, so this makes for a more appropriate test target. Update the code that directly reference IS_MINGW and update error messages accordingly. From fche@redhat.com Wed Jun 12 13:06:17 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id B34687F3F for ; Wed, 12 Jun 2013 13:06:17 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id A307A304051 for ; Wed, 12 Jun 2013 11:06:17 -0700 (PDT) X-ASG-Debug-ID: 1371060373-04cb6c2a471bc0b0001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id KEhE2fCQ0tMi795J for ; Wed, 12 Jun 2013 11:06:13 -0700 (PDT) X-Barracuda-Envelope-From: fche@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5CI6DNv010107 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Jun 2013 14:06:13 -0400 Received: from fche.csb (vpn-62-51.rdu2.redhat.com [10.10.62.51]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5CI6CIe026221; Wed, 12 Jun 2013 14:06:13 -0400 Received: by fche.csb (Postfix, from userid 2569) id 634C458502; Wed, 12 Jun 2013 14:06:12 -0400 (EDT) To: Nathan Scott Cc: PCP Subject: Re: pcp updates: pmdaproc, user/group ACLs References: <742570508.23966097.1371026899281.JavaMail.root@redhat.com> <558715630.23966194.1371026929717.JavaMail.root@redhat.com> X-ASG-Orig-Subj: Re: pcp updates: pmdaproc, user/group ACLs From: fche@redhat.com (Frank Ch. Eigler) Date: Wed, 12 Jun 2013 14:06:12 -0400 In-Reply-To: <558715630.23966194.1371026929717.JavaMail.root@redhat.com> (Nathan Scott's message of "Wed, 12 Jun 2013 04:48:49 -0400 (EDT)") Message-ID: User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1371060373 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 nathans wrote: > [...] > Introduces knowledge of each connection, and its security attrs > (particularly uid and gid), in pmdaproc. This allows a suitably > configured pmcd process (with user/group ACLs) and authenticated > client connections to be able to retrieve sensitive information > for the specific authenticated user and not others. Without ACL > specification in pmcd.conf the behaviour is unchanged from today > (i.e. pmdaproc always runs as root and can access everything). How would this ACL look in practice? We certainly wouldn't want to require a sysadmin to enumerate all userids in an ACL, just to have pmdaproc be willing to setuid-or-equivalent-check for them for proc file reading. Perhaps we need only an option for pmdaproc that says "show-own-processes-only": ie., for authenticated pcp connections, use the given uid for permission checks; for unauthenticated pcp connections, show nothing. This would allow us to enable pmdaproc by default. (Having a pmcd.conf level ACL can compose with this to impose further restrictions.) - FChE From nscott@redhat.com Wed Jun 12 19:12:09 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 8DD6E7F56 for ; Wed, 12 Jun 2013 19:12:09 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id 38688AC004 for ; Wed, 12 Jun 2013 17:12:06 -0700 (PDT) X-ASG-Debug-ID: 1371082324-04bdf02b8e2476c0001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id 7tIOc0AaxbnucLwf for ; Wed, 12 Jun 2013 17:12:04 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5D0C4t9006371; Wed, 12 Jun 2013 20:12:04 -0400 Date: Wed, 12 Jun 2013 20:12:04 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: "Frank Ch. Eigler" Cc: PCP Message-ID: <1214120499.24604443.1371082324107.JavaMail.root@redhat.com> In-Reply-To: References: <742570508.23966097.1371026899281.JavaMail.root@redhat.com> <558715630.23966194.1371026929717.JavaMail.root@redhat.com> Subject: Re: pcp updates: pmdaproc, user/group ACLs MIME-Version: 1.0 X-ASG-Orig-Subj: Re: pcp updates: pmdaproc, user/group ACLs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pcp updates: pmdaproc, user/group ACLs Thread-Index: 8dS/7NzFEAPXqpEbVfNPyOT+0fxxSQ== X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1371082324 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.03 X-Barracuda-Spam-Status: No, SCORE=0.03 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_MISMATCH_TO, BSF_SC0_SA_TO_FROM_DOMAIN_MATCH, THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.133740 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... 0.00 BSF_SC0_MISMATCH_TO Envelope rcpt doesn't match header 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain ----- Original Message ----- > > nathans wrote: > > > [...] > > Introduces knowledge of each connection, and its security attrs > > (particularly uid and gid), in pmdaproc. This allows a suitably > > configured pmcd process (with user/group ACLs) and authenticated > > client connections to be able to retrieve sensitive information > > for the specific authenticated user and not others. Without ACL > > specification in pmcd.conf the behaviour is unchanged from today > > (i.e. pmdaproc always runs as root and can access everything). > > How would this ACL look in practice? These ACLs are as described here... http://oss.sgi.com/pipermail/pcp/2013-May/003483.html > ... We certainly wouldn't want to > require a sysadmin to enumerate all userids in an ACL, just to have > pmdaproc be willing to setuid-or-equivalent-check for them for proc > file reading. Yep, agreed, that definitely won't work. > Perhaps we need only an option for pmdaproc that says > "show-own-processes-only": ie., for authenticated pcp connections, use > the given uid for permission checks; for unauthenticated pcp > connections, show nothing. This would allow us to enable pmdaproc by > default. (Having a pmcd.conf level ACL can compose with this to > impose further restrictions.) I think the desired outcomes can be achieved in pmcd without adding in new pmdaproc options (but I might be wrong there - its still early days). The current pmdaproc behaviour is dependent on how pmcd.conf is setup: - no user/group ACLs in [access] section Historical behaviour remains unchanged - everyone can access all process metrics. "everyone" in this context means both local and remote users. If someone chooses to authenticate, then some instances of some metrics may not be available to them (this is slightly wierd, but not much we can do about this AFAICT, and unlikely to be a problem in practice). - user/group ACLs in [access] section (including a wildcard entry) This will mean: no authentication, no access (to anything, not just proc). While this might seem draconian, the defaulting-to-authenticated AF_UNIX sockets (no username/password interaction) along with the possibility of getting SASL to allow password-less login will mean that we can become secure-by-default with no loss of functionality. I think. I haven't yet got a working no-password SASL connection for non-anonymous users, but I think thats more a coding issue on my part, not a fundamental limitation. It is highly likely that we will move toward having at least a "pcp" user entry in the [access] section by default down the track (and that implies a requirement for authentication for everyone). Anyway, back to pmdaproc - once all connections are authenticated, things hopefully make more sense. In particular your point about "unauthenticated pcp connections, show nothing" resolves itself in a backward-compatible way without the need for running pmdaproc in a special mode... (I hope!) Quite possible I've overlooked something, only just really starting to think through and observe the ramifications of all the authentication stuff. :) cheers. -- Nathan From nscott@redhat.com Fri Jun 14 04:41:52 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 1858D7F3F for ; Fri, 14 Jun 2013 04:41:52 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id D06888F8033 for ; Fri, 14 Jun 2013 02:41:48 -0700 (PDT) X-ASG-Debug-ID: 1371202903-04bdf0233f4f4e40001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id vdwecuAMk5FO68eW for ; Fri, 14 Jun 2013 02:41:43 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5E9fgDD030277 for ; Fri, 14 Jun 2013 05:41:43 -0400 Date: Fri, 14 Jun 2013 05:41:42 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: PCP Message-ID: <1853977798.794864.1371202902587.JavaMail.root@redhat.com> In-Reply-To: <1365430358.794615.1371202868411.JavaMail.root@redhat.com> Subject: pcp updates: python pmda work, bugfix release prep MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates: python pmda work, bugfix release prep Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pcp updates: python pmda work, bugfix release prep Thread-Index: kJFQYq/tS3S+NByMAKBXqeu7zNEseQ== X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1371202903 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.133872 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... Changes committed to git://oss.sgi.com/pcp/pcp.git dev qa/546 | 2 qa/635 | 8 - src/libpcp/src/access.c | 8 - src/perl/PMDA/PMDA.xs | 7 - src/pmcd/pmdaproc.sh | 20 +-- src/pmcd/src/config.c | 9 + src/pmdas/simple/GNUmakefile | 2 src/pmdas/simple/Install | 2 src/pmdas/simple/pmdasimple.perl | 157 ++++++++++++++++++++++++ src/pmdas/simple/pmdasimple.pl | 157 ------------------------ src/pmdas/simple/pmdasimple.py | 241 ------------------------------------- src/pmdas/simple/pmdasimple.python | 231 +++++++++++++++++++++++++++++++++++ src/pmdas/trace/src/client.c | 5 src/pmdas/trace/src/comms.c | 33 +++-- src/python/pcp/pmda.py | 95 +++++++++----- src/python/pmda.c | 97 +++++++++++--- 16 files changed, 591 insertions(+), 483 deletions(-) commit 590cd10136af13d7deedd0e4504db63068ac0978 Author: Nathan Scott Date: Fri Jun 14 19:39:46 2013 +1000 Fix an incorrect domain name from being generated by pmdasimple perl script commit 43e1f62c18d5467e50d5ea0a9257d6292782120f Author: Nathan Scott Date: Fri Jun 14 16:56:57 2013 +1000 Additional (big!) steps toward functioning python PMDAs This took alot of investigation and searching for alternatives. :| Thought I had it solved yesterday, but turned out the underlying C code (python/pmda.c) was not quite responding in the way I thought. Anyway, we now allocate temporary buffers in the python code, and cast to the correct types (pmdaIndom/pmdaMetric arrays) before calling into cpmda module code. Once there, we must decode these objects differently using the Py_buffer API. Hairy, hairy stuff. Also allow any of .pl, .perl, .py, .python as potential script name suffixes as part of the install process. commit 0f3ffb14f1e7641a8d76fc703f9cbd82ae14858a Author: Nathan Scott Date: Thu Jun 13 19:15:11 2013 +1000 Further strides toward a working python PMDA wrapper and pmdasimple.py Implemented code dealing with both forms of instance domain - list based (C array inst/name pairs) or dictionary based (using pmdaCache APIs). Work on the way the dispatch structure is populated; so far managing to avoid expanding it in python code, since its contains unions of sets of function pointers amongst other things - all a bit hairy to represent neatly in python. Fixed some incorrect @staticmethod callback-setter-method annotations. commit 563e63ef3921ffa600abf808808ffe144e978429 Author: Nathan Scott Date: Thu Jun 13 13:31:59 2013 +1000 Update test 635 to ensure netstat reported interfaces match ours It was noticed that on a host where an interface was marked down, pminfo and netstat output do not match, because netstat will only report on these interfaces when the -a option is presented. We export /proc/net/dev interfaces without that filtering (client is able to make use of network.interfaces.up to cull the riff-raff). Easily resolved by adding -a option to netstat now that the issue is understood. commit b54e199b7094399df0f5eaad9960b3057f9af7d2 Author: Nathan Scott Date: Thu Jun 13 11:43:01 2013 +1000 Mark as experimental the user/group ACLs (via ifdef) Temporarily marking the account-based access control extensions to pmcd as experimental, and compile out pmcd.conf support by default. Aim is to allow a bug-fix release to be made from the current dev branch without extensive branch surgery. Similarly mark qa/546 as notrun on earlier releases than the next one. commit e9805ec7f2acfd31c304bac76e7d748af36857ec Author: Nathan Scott Date: Thu Jun 13 11:28:08 2013 +1000 Fix a few socket address string memory leaks in diagnostics From fche@redhat.com Fri Jun 14 22:46:42 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 494CB7F37 for ; Fri, 14 Jun 2013 22:46:42 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id DFC05AC002 for ; Fri, 14 Jun 2013 20:46:38 -0700 (PDT) X-ASG-Debug-ID: 1371267994-04bdf0233c53cb30001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id DE5vHbarTqfQMgkF for ; Fri, 14 Jun 2013 20:46:35 -0700 (PDT) X-Barracuda-Envelope-From: fche@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5F3kYx2008417 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 14 Jun 2013 23:46:34 -0400 Received: from fche.csb (vpn-62-51.rdu2.redhat.com [10.10.62.51]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5F3kYiX020915 for ; Fri, 14 Jun 2013 23:46:34 -0400 Received: by fche.csb (Postfix, from userid 2569) id 83E765850F; Fri, 14 Jun 2013 23:46:33 -0400 (EDT) Date: Fri, 14 Jun 2013 23:46:33 -0400 From: "Frank Ch. Eigler" To: pcp developers Subject: WBEM/CIM<->PCP bridge prototype Message-ID: <20130615034633.GF31128@redhat.com> X-ASG-Orig-Subj: WBEM/CIM<->PCP bridge prototype Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.2i X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1371267995 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 Hi - Using the python PMAPI bindings, I hacked together a quick WBEM/CIM provider that bridges access to the PCP metrics. WBEM/CIM is a big topic, but of importance to some enterprise users as a remote sysadmin/monitoring framework. Now (well, after the prototype turns into a working piece of software) PCP can supply data to them without having to leave their tools. https://reviewboard-openlmi.rhcloud.com/r/458/ - FChE From nscott@redhat.com Sun Jun 16 20:50:33 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 3FABA7F37 for ; Sun, 16 Jun 2013 20:50:33 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id 1B79A8F8033 for ; Sun, 16 Jun 2013 18:50:33 -0700 (PDT) X-ASG-Debug-ID: 1371433826-04bdf02b8e39f1e0001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id vvdeD0hUoOin66eD for ; Sun, 16 Jun 2013 18:50:27 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5H1oQcm010772 for ; Sun, 16 Jun 2013 21:50:26 -0400 Date: Sun, 16 Jun 2013 21:50:26 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: PCP Message-ID: <494738881.1674715.1371433826469.JavaMail.root@redhat.com> Subject: pcp updates: python wrangling MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates: python wrangling Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pcp updates: python wrangling Thread-Index: 0qt/35mk7n+V3vDEtzKOONn6qCYDdA== X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1371433827 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134127 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... Changes committed to git://oss.sgi.com/pcp/pcp.git dev qa/.gitignore | 1 qa/642 | 9 ++-- qa/642.out.3 | 91 +++++++++++++++++++++++++++++++++++++++++++ qa/715 | 13 ++++-- qa/715.out | 53 ------------------------- qa/715.out.1 | 53 +++++++++++++++++++++++++ qa/715.out.2 | 53 +++++++++++++++++++++++++ src/pmcollectl/pmcollectl.py | 41 ++++++++++--------- src/python/pcp/pmsubsys.py | 34 ++++++++++++++-- 9 files changed, 267 insertions(+), 81 deletions(-) commit 2c8649b7527cdd44ba6b46995003fe2ea8525eae Author: Nathan Scott Date: Mon Jun 17 11:42:20 2013 +1000 Update existing pmdasimple tests to handle the new python option commit 834730d7bf28e317edf1b1056a06ba7d1453e9ca Author: Nathan Scott Date: Mon Jun 17 11:13:13 2013 +1000 Fix pmcollectl bug reporting disk throughput, needs to report in KB not MB commit 326ccafdf30f0f5a80f31cf0709ffc4280563217 Merge: 590cd10 88c003b Author: Nathan Scott Date: Sun Jun 16 08:04:40 2013 +1000 Merge branch 'scox/dev' of ../pcpfans into dev commit 88c003ba6bb389e7dd6109082eed270048186254 Author: Stan Cox Date: Sat Jun 15 11:16:24 2013 -0400 Allow for interrupts no longer being in their own metric list. * pmsubsys.py (init_interrupt_metrics): Explicitly set metric list. * pmcollectl.py (_interruptCollectPrint): Find interrupt metrics in metric list. commit efce125cbea7f29edcf35c6563c7d59e61cb3c80 Merge: 40232ce f0a8f82 Author: Stan Cox Date: Thu Jun 6 17:27:26 2013 -0400 Merge branch 'dev' into scox/dev From nscott@redhat.com Tue Jun 18 02:25:35 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 1F9467CBF for ; Tue, 18 Jun 2013 02:25:35 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id BE2DEAC005 for ; Tue, 18 Jun 2013 00:25:31 -0700 (PDT) X-ASG-Debug-ID: 1371540327-04bdf02b8e409ce0001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id et0RCz2CVdEGqrB2 for ; Tue, 18 Jun 2013 00:25:27 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5I7PRiP016364 for ; Tue, 18 Jun 2013 03:25:27 -0400 Date: Tue, 18 Jun 2013 03:25:27 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: PCP Message-ID: <405201805.2818136.1371540327083.JavaMail.root@redhat.com> Subject: pcp updates: python pmdas MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates: python pmdas Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pcp updates: python pmdas Thread-Index: pi+E785Rw/WdjDqWl/UqeJ30KvQByw== X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1371540327 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Barracuda-BRTS-Status: 1 X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134245 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... Changes committed to git://oss.sgi.com/pcp/pcp.git dev src/pmdas/simple/pmdasimple.python | 52 ++-- src/python/pcp/pmda.py | 67 +++--- src/python/pmda.c | 392 +++++++++++++++++++++++++++---------- 3 files changed, 361 insertions(+), 150 deletions(-) commit 4721f3dc46b768c70efc57319e7ef96ce976a71c Author: Nathan Scott Date: Tue Jun 18 17:20:18 2013 +1000 Functioning instance domains for the pcp.pmda python module This is the last (for now) piece of the PMDA python wrapping puzzle. The python variant of the simple PMDA now operates correctly for all of the different PDU variants. Yippee! Particularly problematic were the pmdaCache instance domains as there is a bit of a conflict between python insisting on maintaining type information, and the (void*) parameters we use in the C API so that PMDAs can store whatever they like. This is solved using ctypes, with the side-effect that only ctypes values can be used with pmdaCache indoms. Other issues resolved include: ensure the instance callback declaration in python PMDAs matches the C calling convention (must declare the passed-in indom serial), big improvements in the python stacktrace logging when exceptions thrown, and correct the argtypes declarations for a couple of the cache interface routines from libpcp_pmda (void** vs void*). commit 281c452b40c4f1cfcede70ad2e8c2687ce34aefc Author: Nathan Scott Date: Tue Jun 18 13:16:41 2013 +1000 Update the pmdasimple sample code to clarify the fetch callback Also removes an opportunity to use an uninitialised times() list, which results in an exception and associated badness. commit 83b1910748b3c78435bf86e5a37ce982c2889ac8 Author: Nathan Scott Date: Tue Jun 18 10:15:03 2013 +1000 Basic fetch callback methods are now working in python PMDA module Fixes up the way the tuple returned from the fetch callback is parsed back in the C code (before interfacing to libpcp_pmda), adds numerous additional checks and diagnostics to the python return values / error code, and removes some leftover debug code from earlier commits. commit 9fb416db53de36785edcd45600b386572359d721 Author: Nathan Scott Date: Mon Jun 17 17:43:06 2013 +1000 Further work on python pcp.pmda interface modules Metric namespace refresh now correctly iterates the names dictionary and populates the C namespace structures. The short and long help text PDU handling is now also done. From nscott@redhat.com Tue Jun 18 20:48:05 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id CC95329E09 for ; Tue, 18 Jun 2013 20:48:05 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay2.corp.sgi.com (Postfix) with ESMTP id C68EA304032 for ; Tue, 18 Jun 2013 18:48:02 -0700 (PDT) X-ASG-Debug-ID: 1371606481-04cbb0468f66c7a0001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id 3eS8DuJnEbB5hUyh for ; Tue, 18 Jun 2013 18:48:01 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5J1m1De008396 for ; Tue, 18 Jun 2013 21:48:01 -0400 Date: Tue, 18 Jun 2013 21:48:00 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: PCP Message-ID: <888925816.3804098.1371606480980.JavaMail.root@redhat.com> In-Reply-To: <1303886226.3803894.1371606452673.JavaMail.root@redhat.com> Subject: pcp updates: qa MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates: qa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pcp updates: qa Thread-Index: NvHWaHWvAA2vnKXBHecdOAalC1bT4Q== X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1371606481 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134316 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... Changes committed to git://oss.sgi.com/pcp/pcp.git dev CHANGELOG | 36 ++++++++++++++++++++++++++++++++++-- build/mac/install-pcp | 4 ++-- build/rpm/fedora.spec | 10 +++++++--- debian/changelog | 5 +++-- qa/628 | 13 +++++-------- qa/716 | 6 +++++- qa/717 | 2 +- qa/717.out | 28 +++++++++++++--------------- qa/718 | 4 ++-- qa/718.out | 10 ++++++---- src/pmdas/simple/pmdasimple.python | 2 +- src/python/pcp/pmda.py | 5 ++--- src/python/pmda.c | 23 +++++++++++++---------- 13 files changed, 94 insertions(+), 54 deletions(-) commit c7f2c501e17a2afa6f424deaea17afa65dabcc32 Author: Nathan Scott Date: Wed Jun 19 11:21:31 2013 +1000 Fix python pmdasimple to handle edge case of empty configuration Test 717 exposed an issue where python pmdasimple instance domain refresh could generate an exception - fix this, and update tests output to match expected result. commit 620e7acc305cfba8945501133d7c65a420ff0540 Author: Nathan Scott Date: Wed Jun 19 11:19:55 2013 +1000 Show the correct indom text output for simple "now" indom in qa/717 commit 58c00758c57ced70a72bcc6c75073667f3305eda Author: Nathan Scott Date: Wed Jun 19 10:50:48 2013 +1000 Fix Mac OS X install issue with symlinked paths commit 407a9dfd9bb1e9273709c3617baa57e4a3464c4b Author: Nathan Scott Date: Wed Jun 19 10:27:01 2013 +1000 Bump version details and update changelogs for pending 3.8.1 release commit 234da7c51bdad17f74f3c97388f41cf1f8ce1156 Author: Nathan Scott Date: Wed Jun 19 10:21:28 2013 +1000 Updates to qa tests following recent python PMDA changes commit c219d61a095314b9674bfdefc4d98ca561ab21fb Author: Nathan Scott Date: Wed Jun 19 10:20:35 2013 +1000 Corrections to pmstore support in pcp.pmda python wrapper Missing handling of correct python-exception handling from the C interface code, ensure correct (unsigned) type used for extracting the pmStore'd instance identifier. Removed unneeded pmns_refresh() when building the namespace file (unrelated cleanup). commit aaebd72ebc54985805b85d8b91aa0b664a620959 Author: Nathan Scott Date: Tue Jun 18 18:30:41 2013 +1000 Remove leftover pmDebug setting in pcp.pmda python code From dak-unpriv@franck.debian.org Wed Jun 19 02:23:25 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 760787F5D for ; Wed, 19 Jun 2013 02:23:25 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id 719208F804B for ; Wed, 19 Jun 2013 00:23:22 -0700 (PDT) X-ASG-Debug-ID: 1371626600-04cb6c2a473ddee0001-S8gJnT Received: from franck.debian.org (franck.debian.org [138.16.160.12]) by cuda.sgi.com with ESMTP id TdzHuddBEsaQ8gN3 (version=TLSv1 cipher=AES128-SHA bits=128 verify=NO) for ; Wed, 19 Jun 2013 00:23:21 -0700 (PDT) X-Barracuda-Envelope-From: dak-unpriv@franck.debian.org X-Barracuda-Apparent-Source-IP: 138.16.160.12 Received: from dak-unpriv by franck.debian.org with local (Exim 4.80) (envelope-from ) id 1UpCjg-0005ne-9u for pcp@oss.sgi.com; Wed, 19 Jun 2013 07:23:20 +0000 To: pcp@oss.sgi.com From: Debian FTP Masters Subject: Processing of pcp_3.8.1_i386.changes Date: Wed, 19 Jun 2013 07:23:20 +0000 X-ASG-Orig-Subj: Processing of pcp_3.8.1_i386.changes X-Debian: DAK X-DAK: DAK X-Debian-Package: pcp Message-Id: Sender: unprivileged ftp-master role account X-Barracuda-Connect: franck.debian.org[138.16.160.12] X-Barracuda-Start-Time: 1371626601 X-Barracuda-Encrypted: AES128-SHA X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134339 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- pcp_3.8.1_i386.changes uploaded successfully to localhost along with the files: pcp_3.8.1.dsc pcp_3.8.1.tar.gz pcp_3.8.1_i386.deb libpcp3-dev_3.8.1_i386.deb libpcp3_3.8.1_i386.deb libpcp-gui2-dev_3.8.1_i386.deb libpcp-gui2_3.8.1_i386.deb libpcp-mmv1-dev_3.8.1_i386.deb libpcp-mmv1_3.8.1_i386.deb libpcp-pmda3-dev_3.8.1_i386.deb libpcp-pmda3_3.8.1_i386.deb libpcp-trace2-dev_3.8.1_i386.deb libpcp-trace2_3.8.1_i386.deb libpcp-import1-dev_3.8.1_i386.deb libpcp-import1_3.8.1_i386.deb python-pcp_3.8.1_i386.deb libpcp-pmda-perl_3.8.1_i386.deb libpcp-import-perl_3.8.1_i386.deb libpcp-logsummary-perl_3.8.1_i386.deb libpcp-mmv-perl_3.8.1_i386.deb pcp-import-sar2pcp_3.8.1_all.deb pcp-import-mrtg2pcp_3.8.1_all.deb pcp-import-sheet2pcp_3.8.1_all.deb pcp-import-iostat2pcp_3.8.1_all.deb pcp-import-collectl2pcp_3.8.1_i386.deb pcp-testsuite_3.8.1_i386.deb Greetings, Your Debian queue daemon (running on host franck.debian.org) From envelope@ftp-master.debian.org Wed Jun 19 02:35:37 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id E1CC47F4E for ; Wed, 19 Jun 2013 02:35:36 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id 7B58EAC002 for ; Wed, 19 Jun 2013 00:35:33 -0700 (PDT) X-ASG-Debug-ID: 1371627332-04cbb0468e67dfa0001-S8gJnT Received: from franck.debian.org (franck.debian.org [138.16.160.12]) by cuda.sgi.com with ESMTP id QA6R6yCD70GXPIOp (version=TLSv1 cipher=AES128-SHA bits=128 verify=NO) for ; Wed, 19 Jun 2013 00:35:32 -0700 (PDT) X-Barracuda-Envelope-From: envelope@ftp-master.debian.org X-Barracuda-Apparent-Source-IP: 138.16.160.12 Received: from dak by franck.debian.org with local (Exim 4.80) (envelope-from ) id 1UpCvT-00009C-83; Wed, 19 Jun 2013 07:35:31 +0000 From: Debian FTP Masters To: PCP Development Team , Nathan Scott X-DAK: dak process-upload X-Debian: DAK X-Debian-Package: pcp Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Subject: pcp_3.8.1_i386.changes is NEW Message-Id: X-ASG-Orig-Subj: pcp_3.8.1_i386.changes is NEW Sender: Archive Administrator Date: Wed, 19 Jun 2013 07:35:31 +0000 X-Barracuda-Connect: franck.debian.org[138.16.160.12] X-Barracuda-Start-Time: 1371627332 X-Barracuda-Encrypted: AES128-SHA X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134339 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- binary:pcp-import-collectl2pcp is NEW. Your package contains new components which requires manual editing of the override file. It is ok otherwise, so please be patient. New packages are usually added to the override file about once a week. From pcp-announce-bounces@oss.sgi.com Wed Jun 19 02:54:10 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from oss.sgi.com (localhost [IPv6:::1]) by oss.sgi.com (Postfix) with ESMTP id AF4DC7F62; Wed, 19 Jun 2013 02:54:10 -0500 (CDT) X-Original-To: pcp-announce@oss.sgi.com Delivered-To: pcp-announce@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 62BBF7F61 for ; Wed, 19 Jun 2013 02:54:08 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id 4BD358F8033 for ; Wed, 19 Jun 2013 00:54:08 -0700 (PDT) X-ASG-Debug-ID: 1371628446-04cb6c2a423df950001-87ZIJf Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id HBjaBlFS7nvPSFFA for ; Wed, 19 Jun 2013 00:54:07 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5J7s6Sn001352; Wed, 19 Jun 2013 03:54:06 -0400 Date: Wed, 19 Jun 2013 03:54:06 -0400 (EDT) From: Nathan Scott To: pcp-announce@oss.sgi.com Message-ID: <220502070.3916837.1371628446660.JavaMail.root@redhat.com> In-Reply-To: <1770187462.3910310.1371627640626.JavaMail.root@redhat.com> MIME-Version: 1.0 X-ASG-Orig-Subj: pcp-3.8.1 release X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pcp-3.8.1 release Thread-Index: kQTKa+J+43CJA1QwRsCjduVCSRCYeA== X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1371628447 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134341 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... Cc: Marko Myllynen , Paul Evans Subject: [pcp-announce] pcp-3.8.1 release X-BeenThere: pcp-announce@oss.sgi.com X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Nathan Scott List-Id: pcp announcements List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pcp-announce-bounces@oss.sgi.com Sender: pcp-announce-bounces@oss.sgi.com Hi all, Its that time again - the next PCP update is primed and ready for your amusement. The full changelog is below, but special thanks to big contributions from Paul Evans (pmdagfs2), Marko Myllynen (log importing coding, testing and fixing) and Mark Goodwin (collectl2pcp). And all the other usual suspects. There was a late-breaking issue found in the new python PMDA support, on older versions of python (RHEL5 vintage - fails to build) - this will be addressed in the next update. pcp-3.8.1 (19 June 2013) - Add support for PMDAs written in python via pcp.pmda package. - Example implementation of pmdasimple using python. - Added new proc.{memory.vmswap,psinfo.threads} metrics. - New collectl2pcp utility and sub-package (deb/rpm) for converting historical data collected with collectl into the PCP archive format for replay and analysis with PCP tools. - Add missing help text for some Linux kernel hinv.map metrics - Added new hinv.map.lvname metric for reverse mapping logical device mapper names to physical device names. - Added new hinv.ninterface metric (pmdalinux and collectl2pcp) - Fixes to pmcollectl handling of PCP logs in archive mode. - Allow pmcollectl metrics to be sourced from a remote host. - Additional gfs2 metrics and tests, thanks to Paul Evans from the gfs2 development team at Red Hat. This makes use of the gfs2 kernel glock event tracing to track hot locks, and also provides a storable mechanism for enabling/disabling tracing on-the-fly. - Updated access control section of pmcd.1 with IPv6 details. - Improve archive integrity checking from libpcp_import, ensure monotonic increasing timestamps presented for single archive. - Improvements to the log import perl API allowing for batched updates (out-of-order), thanks to Marko Myllynen. - Removed a low limit in the libpcp_import auto-PMID generation scheme, now allowing millions of metrics instead of hundreds. - Promote pmlogger and pmlogextract into the default PATH, with backward-compatibility preserving symlinks in PCP_BINADM_DIR. - Support for IPv6 socket communication in libpcp_pmda for pmcd PMDA communication. - Support for IPv6 socket communication testing via dbpmda. - Update man pages to reflect IPv6 support in libpcp_pmda. - Other improvements to the socket-based PMDA mechanisms. - Fix a 64bit big-endian host issue in systemd.maxmem metric - Mac OS X packaging tweaks. Enjoy! -- Nathan _______________________________________________ pcp-announce mailing list pcp-announce@oss.sgi.com http://oss.sgi.com/mailman/listinfo/pcp-announce From debbugs@buxtehude.debian.org Wed Jun 19 03:09:16 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id F1D707F61 for ; Wed, 19 Jun 2013 03:09:15 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id E953B8F8035 for ; Wed, 19 Jun 2013 01:09:12 -0700 (PDT) X-ASG-Debug-ID: 1371629351-04cb6c2a413e06c0001-S8gJnT Received: from buxtehude.debian.org (buxtehude.debian.org [140.211.166.26]) by cuda.sgi.com with ESMTP id 1ygv2gRmAgNTTGr9 (version=TLSv1 cipher=AES128-SHA bits=128 verify=NO) for ; Wed, 19 Jun 2013 01:09:11 -0700 (PDT) X-Barracuda-Envelope-From: debbugs@buxtehude.debian.org X-Barracuda-Apparent-Source-IP: 140.211.166.26 Received: from debbugs by buxtehude.debian.org with local (Exim 4.80) (envelope-from ) id 1UpDS0-0004Cr-SL; Wed, 19 Jun 2013 08:09:08 +0000 X-Loop: owner@bugs.debian.org Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) Content-Type: text/plain; charset=utf-8 From: owner@bugs.debian.org (Debian Bug Tracking System) To: Anibal Monsalve Salazar CC: abou.almontacir@sfr.fr, pcp@oss.sgi.com, wnpp@debian.org Subject: Processed (with 2 errors): tagging as pending bugs that are closed by packages in NEW Message-ID: X-ASG-Orig-Subj: Processed (with 2 errors): tagging as pending bugs that are closed by packages in NEW References: <20130619080423.D31A7805BE20@elida.v7w.com> X-Debian-PR-Package: wnpp pcp X-Debian-PR-Source: pcp X-Debian-PR-Message: transcript X-Loop: owner@bugs.debian.org Date: Wed, 19 Jun 2013 08:09:08 +0000 Sender: Debian BTS X-Barracuda-Connect: buxtehude.debian.org[140.211.166.26] X-Barracuda-Start-Time: 1371629351 X-Barracuda-Encrypted: AES128-SHA X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134341 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Processing commands for control@bugs.debian.org: > # Wednesday 19 June 08:03:32 UTC 2013 > # Tagging as pending bugs that are closed by packages in NEW > # http://ftp-master.debian.org/new.html > # > # Source package in NEW: brltty > tags 680636 + pending Failed to alter tags of Bug 680636: Not altering archived bugs; see unarchi= ve. > # Source package in NEW: brltty > tags 705196 + pending Failed to alter tags of Bug 705196: Not altering archived bugs; see unarchi= ve. > # Source package in NEW: castle-game-engine > tags 706408 + pending Bug #706408 [wnpp] ITP: castle-game-engine -- 3D game engine for FreePascal= & Lazarus Added tag(s) pending. > # Source package in NEW: pc= p > tags 689552 + pending Bug #689552 [pcp] "restrict" is a keyword in C99 Added tag(s) pending. > End of message, stopping processing here. Please contact me if you need assistance. --=20 689552: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D689552 706408: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D706408 Debian Bug Tracking System Contact owner@bugs.debian.org with problems From nscott@redhat.com Wed Jun 19 18:11:30 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id D54A97CBF for ; Wed, 19 Jun 2013 18:11:30 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id B50288F804C for ; Wed, 19 Jun 2013 16:11:27 -0700 (PDT) X-ASG-Debug-ID: 1371683486-04bdf0233e6c6d40001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id SYCTTD1AAqoYYFgN for ; Wed, 19 Jun 2013 16:11:26 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5JNBQbg004454; Wed, 19 Jun 2013 19:11:26 -0400 Date: Wed, 19 Jun 2013 19:11:25 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Dave Brolley Cc: pcp@oss.sgi.com Message-ID: <698020944.4509484.1371683485976.JavaMail.root@redhat.com> In-Reply-To: <1052899081.4509035.1371683178214.JavaMail.root@redhat.com> Subject: Installing files/dirs as non-root:root user and group MIME-Version: 1.0 X-ASG-Orig-Subj: Installing files/dirs as non-root:root user and group Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: Installing files/dirs as non-root:root user and group Thread-Index: yQri0m7nPDIerSmjF1taWfi3NCbdsQ== X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1371683486 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.03 X-Barracuda-Spam-Status: No, SCORE=0.03 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH, THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134400 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain Hi Dave, nathans, do you recall an irc conversation in which we agreed to adjust the permissions of ${localstatedir}/pcp to: root pcp rwxrwxr-x ? (to allow pmcd to delete ${localstatedir}/pcp/pmcd.socket) nathans, gotta run now, but the thing is that I looked a couple of times, but couldn't find the right place to get that done in the rpm (at least the one used by ./Makepkgs). Any pointers would be appreciated * brolley|afk has left #pcp Yeah, you're blazing a trail here :) - don't think we install anything else not-as-root:root yet. The install.sh script has -o/-g (owner/group) options, and $PCP_USER and $PCP_GROUP are nowadays defined in the build ... I'd start with those and see if they work out (makefile changes, iow). If not, we'll need to find where that info is getting dropped/lost and tackle that. cheers. -- Nathan From nscott@redhat.com Thu Jun 20 02:35:14 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id C41B77F37 for ; Thu, 20 Jun 2013 02:35:14 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id B1B478F8033 for ; Thu, 20 Jun 2013 00:35:11 -0700 (PDT) X-ASG-Debug-ID: 1371713709-04cbb0468e6d78b0001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id wFLUKfQ1YOJlWsSD for ; Thu, 20 Jun 2013 00:35:10 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5K7Z90F026250 for ; Thu, 20 Jun 2013 03:35:09 -0400 Date: Thu, 20 Jun 2013 03:35:09 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: PCP Message-ID: <1196126219.4651388.1371713709228.JavaMail.root@redhat.com> In-Reply-To: <1866053778.4651280.1371713660420.JavaMail.root@redhat.com> Subject: pcp updates: older python, qa MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates: older python, qa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pcp updates: older python, qa Thread-Index: jKY7tBrvJhXPckzZpfYOkdtCZEgjtQ== X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1371713710 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134434 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... Changes committed to git://oss.sgi.com/pcp/pcp.git dev VERSION.pcp | 2 build/rpm/fedora.spec | 5 +- debian/changelog | 6 ++ qa/qa_hosts.master | 1 src/pmdas/simple/pmdasimple.python | 5 +- src/pmlogconf/filesystem/xfs-io-linux | 3 + src/python/pmda.c | 73 +++++++++++++++++++++++++++++----- 7 files changed, 83 insertions(+), 12 deletions(-) commit 574489705f07d20da1f9fdb80f72e04d131516b8 Author: Nathan Scott Date: Thu Jun 20 12:21:23 2013 +1000 Corrections to the old-school-py buffer extraction code commit 933f438c7d3b6635ec7e5dbf45a02f48948227d3 Author: Nathan Scott Date: Thu Jun 20 12:01:27 2013 +1000 Change pmdasimple python code to not use newer language features commit 3c861d325ee69fee896128726f5b10efa58021af Author: Nathan Scott Date: Thu Jun 20 11:46:44 2013 +1000 Fixes to the python pmda interface code to allow old python versions Workaround several issues from old python versions (RHEL5, so 2.4.3). There is no Py_ssize_t there, so conditionally dodge that bullet. The buffer interface was reworked in 2.6+ evidentally (or at least, back- ported there) so any use of PyBUF_SIMPLE and the PyObject_GetBuffer, PyObject_CheckBuffer and so on must also be guarded. Finally, PyArg_ParseTuple takes (const char *) in latest version, but was not const back in the day, so avoid that warning as well. commit 5242211ae0f58bb3467a06c800387180ab34666c Author: Nathan Scott Date: Thu Jun 20 10:34:53 2013 +1000 Extend default xfs logged stats with iops and buffers commit 0561ea0dd2136c5ac6f28bf462b87d5dd57a6ad8 Author: Nathan Scott Date: Thu Jun 20 10:34:07 2013 +1000 Add a new RHEL5 virtual machine into my test mix commit 866df6f9f81534a40b6c583c4a8f91060d5bd37a Author: Nathan Scott Date: Thu Jun 20 10:33:34 2013 +1000 Update version files for in-progress development From nscott@redhat.com Thu Jun 20 02:37:16 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 1B4737F37 for ; Thu, 20 Jun 2013 02:37:16 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id D47B18F8033 for ; Thu, 20 Jun 2013 00:37:15 -0700 (PDT) X-ASG-Debug-ID: 1371713833-04bdf02b8e4ba7f0001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id uatEevRwsE9LGOii for ; Thu, 20 Jun 2013 00:37:13 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5K7bDqv026875 for ; Thu, 20 Jun 2013 03:37:13 -0400 Date: Thu, 20 Jun 2013 03:37:13 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: PCP Message-ID: <18332924.4651860.1371713833797.JavaMail.root@redhat.com> In-Reply-To: <196231837.4651698.1371713805167.JavaMail.root@redhat.com> Subject: pcpweb updates: shiny new look MIME-Version: 1.0 X-ASG-Orig-Subj: pcpweb updates: shiny new look Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pcpweb updates: shiny new look Thread-Index: 27fqIWSHUpPolYJ0TsXeXZTQKSQNzQ== X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1371713833 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Barracuda-BRTS-Status: 1 X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134434 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... Changes committed to git://oss.sgi.com/pcp/pcpweb.git master contact.html | 152 ++++++++ contribute.html | 127 ------- dev/null |binary documentation.html | 88 ---- faq.html | 270 +++++++-------- features.html | 122 ++++-- glider.html | 126 ++++--- images/book.png |binary images/book.svg | 359 ++++++++++++++++++++ images/cloudstrip.jpg |binary images/menustrip.png |binary images/pcplogo.png |binary images/play.png |binary images/play.svg | 315 +++++++++++++++++ index.html | 153 ++++---- license.html | 53 -- mail.html | 103 +++-- manual.html | 311 ----------------- mingw-get-dist/glider-package-list.xml | 22 - mingw-get-dist/glider-pcp-gui-w32.xml | 47 -- mingw-get-dist/glider-pcp-w32.xml | 54 --- mingw-get-dist/glider-qt4-w32.xml | 170 --------- mingw-get-dist/package-list.xml | 10 news.css | 16 news.html | 86 +++- pcp-gui.html | 126 ++++--- pcp.css | 588 +++++++++++---------------------- pcpstyle.css | 266 ++++++++++++++ presentations.html | 88 +++- screenshots.html | 329 ++++++++---------- snaps.css | 7 source.html | 93 +++-- tools/manpages.sh | 79 ---- 33 files changed, 2107 insertions(+), 2053 deletions(-) commit 2e9e0ffc914e69c316a00fae9b1cc6b45e5cfe87 Author: Nathan Scott Date: Thu Jun 20 17:16:24 2013 +1000 Rename highlevel css to avoid caching effects on cutover commit f912d0ac7676790f3274f1cf8db6db592dbb70c5 Author: Nathan Scott Date: Thu Jun 20 16:36:44 2013 +1000 Redesigned, simplified formatting for all the web pages. Also updated numerous sections, particularly incorrect spots in the FAQ, features, and other pages. This format is designed to be simpler, work better with smaller screens, and generally have a more modern look about it. It's also been checked to render sensibly with internet explorer, which the old pages did not. Finally, it now promotes the books alot more, so guess we'd better get a move on and start updating 'em eh? ;) From pevans@redhat.com Thu Jun 20 13:44:54 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 750617F61 for ; Thu, 20 Jun 2013 13:44:54 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id 6752B30407A for ; Thu, 20 Jun 2013 11:44:54 -0700 (PDT) X-ASG-Debug-ID: 1371753890-04cb6c2a42460160001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id FcKTjz4BsZXf4RBM for ; Thu, 20 Jun 2013 11:44:50 -0700 (PDT) X-Barracuda-Envelope-From: pevans@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5KIinY5017298 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 20 Jun 2013 14:44:50 -0400 Received: from [10.36.5.57] (vpn1-5-57.ams2.redhat.com [10.36.5.57]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5KIim9i012176; Thu, 20 Jun 2013 14:44:49 -0400 Message-ID: <51C34DA0.9030406@redhat.com> Date: Thu, 20 Jun 2013 19:44:48 +0100 From: Paul Evans User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Nathan Scott CC: pcp@oss.sgi.com Subject: [pcp] pmdagfs2: documentation updates Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-ASG-Orig-Subj: [pcp] pmdagfs2: documentation updates Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1371753890 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 Hi, I have adding some documentation in the usual places for pmdagfs2, these include a man page, a readme file along with additional commenting in the qa test files. Any feedback on these would be greatly appreciated. These changes are available at: git://github.com/pauljevans/pcp.git dev Looking forward I plan on making some changes to the qa files to have better guarding for configurations that are not set up correctly (checking debugfs is mounted etc.) and moving towards providing a client application to bring together pmdagfs2 metrics for all nodes of a given cluster. Some additional metrics are on the cards too. Cheers, Paul From brolley@redhat.com Thu Jun 20 14:37:48 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 146B67F37 for ; Thu, 20 Jun 2013 14:37:48 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id EDF978F8033 for ; Thu, 20 Jun 2013 12:37:44 -0700 (PDT) X-ASG-Debug-ID: 1371757063-04cb6c2a474639a0001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id ln5athwPYqzBYn58 for ; Thu, 20 Jun 2013 12:37:44 -0700 (PDT) X-Barracuda-Envelope-From: brolley@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5KJbhGT005868 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 20 Jun 2013 15:37:43 -0400 Received: from [10.15.16.139] (dhcp-10-15-16-139.yyz.redhat.com [10.15.16.139]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5KJbgQR003014; Thu, 20 Jun 2013 15:37:43 -0400 Message-ID: <51C35A06.6050909@redhat.com> Date: Thu, 20 Jun 2013 15:37:42 -0400 From: Dave Brolley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Nathan Scott CC: pcp@oss.sgi.com Subject: Re: Installing files/dirs as non-root:root user and group References: <698020944.4509484.1371683485976.JavaMail.root@redhat.com> X-ASG-Orig-Subj: Re: Installing files/dirs as non-root:root user and group In-Reply-To: <698020944.4509484.1371683485976.JavaMail.root@redhat.com> Content-Type: multipart/mixed; boundary="------------030509090209010704030404" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1371757064 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 This is a multi-part message in MIME format. --------------030509090209010704030404 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hey Nathan, I was still unable to find a suitable place among the {GNU}makefiles, but making changes to src/pmcd/rc_pmcd seems to do the trick (when pmcd is started as a system daemon). Please have a look at the attached patch. Thanks Dave On 06/19/2013 07:11 PM, Nathan Scott wrote: > Hi Dave, > > nathans, do you recall an irc conversation in which we > agreed to adjust the permissions of ${localstatedir}/pcp to: > root pcp rwxrwxr-x ? > (to allow pmcd to delete ${localstatedir}/pcp/pmcd.socket) > nathans, gotta run now, but the thing is that I > looked a couple of times, but couldn't find the right place to > get that done in the rpm (at least the one used by ./Makepkgs). > Any pointers would be appreciated > * brolley|afk has left #pcp > > Yeah, you're blazing a trail here :) - don't think we install > anything else not-as-root:root yet. The install.sh script has > -o/-g (owner/group) options, and $PCP_USER and $PCP_GROUP are > nowadays defined in the build ... I'd start with those and see > if they work out (makefile changes, iow). If not, we'll need > to find where that info is getting dropped/lost and tackle that. > > cheers. > > -- > Nathan --------------030509090209010704030404 Content-Type: text/x-patch; name="PCP_RUN_DIR-perms.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="PCP_RUN_DIR-perms.patch" diff --git a/src/pmcd/rc_pmcd b/src/pmcd/rc_pmcd index e4adf96..f82bbc3 100644 --- a/src/pmcd/rc_pmcd +++ b/src/pmcd/rc_pmcd @@ -98,8 +98,10 @@ _reboot_setup() # if [ ! -d "$PCP_RUN_DIR" ] then - mkdir -p -m 755 "$PCP_RUN_DIR" + mkdir -p "$PCP_RUN_DIR" fi + chgrp $PCP_GROUP "$PCP_RUN_DIR" + chmod 777 "$PCP_RUN_DIR" # setup and clean up base directories and house-keeping for tracking # pmlogger instances ... needs to be done here because pmcd needs the @@ -275,6 +277,7 @@ _shutdown() then [ "$1" = verbose ] && echo "$prog: pmcd not running" rm -f $PCP_RUN_DIR/pmcd.pid + rm -f $PCP_RUN_DIR/pmcd.socket return 0 fi @@ -327,6 +330,7 @@ Warning: process ID in $PCP_RUN_DIR/pmcd.pid is $TOKILL. else pmsignal -s $SIG $TOKILL >/dev/null 2>&1 rm -f $PCP_RUN_DIR/pmcd.pid + rm -f $PCP_RUN_DIR/pmcd.socket fi while [ $delay -gt 0 ] do --------------030509090209010704030404-- From nscott@redhat.com Thu Jun 20 17:00:58 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 96C347F37 for ; Thu, 20 Jun 2013 17:00:58 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay3.corp.sgi.com (Postfix) with ESMTP id 22BCFAC005 for ; Thu, 20 Jun 2013 15:00:58 -0700 (PDT) X-ASG-Debug-ID: 1371765653-04cb6c2a4246bf80001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id VMackcvNX7qB3Y1Q for ; Thu, 20 Jun 2013 15:00:53 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5KM0p11009330; Thu, 20 Jun 2013 18:00:51 -0400 Date: Thu, 20 Jun 2013 18:00:51 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Dave Brolley Cc: pcp@oss.sgi.com Message-ID: <1097929496.5228235.1371765651634.JavaMail.root@redhat.com> In-Reply-To: <51C35A06.6050909@redhat.com> References: <698020944.4509484.1371683485976.JavaMail.root@redhat.com> <51C35A06.6050909@redhat.com> Subject: Re: Installing files/dirs as non-root:root user and group MIME-Version: 1.0 X-ASG-Orig-Subj: Re: Installing files/dirs as non-root:root user and group Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: Installing files/dirs as non-root:root user and group Thread-Index: Xw/5G7qgfrOBeCJWF3QYmOXR7qn0PA== X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1371765653 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.53 X-Barracuda-Spam-Status: No, SCORE=0.53 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH, BSF_SC1_TG070, THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134491 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... 0.50 BSF_SC1_TG070 Custom Rule TG070 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain Hi Dave, ----- Original Message ----- > Hey Nathan, > > I was still unable to find a suitable place among the {GNU}makefiles, Something like this (untested) ... $ diff --git a/GNUmakefile b/GNUmakefile index 8a58e9d..567ef24 100644 --- a/GNUmakefile +++ b/GNUmakefile @@ -80,6 +80,7 @@ endif ifeq "$(findstring $(PCP_TMP_DIR),/var/tmp /tmp)" "" $(INSTALL) -m 1777 -d $(PCP_TMP_DIR) endif + $(INSTALL) -m 775 -g $(PCP_GROUP) -d $(PCP_RUN_DIR) $(INSTALL) -m 755 -d $(PCP_SYSCONF_DIR) $(INSTALL) -m 755 -d $(PCP_BINADM_DIR) $(INSTALL) -m 755 -d $(PCP_SHARE_DIR)/lib > but making changes to src/pmcd/rc_pmcd seems to do the trick (when pmcd > is started as a system daemon). Please have a look at the attached patch. *nod* - I think we need that stuff too ... > diff --git a/src/pmcd/rc_pmcd b/src/pmcd/rc_pmcd > index e4adf96..f82bbc3 100644 > --- a/src/pmcd/rc_pmcd > +++ b/src/pmcd/rc_pmcd > @@ -98,8 +98,10 @@ _reboot_setup() > # > if [ ! -d "$PCP_RUN_DIR" ] > then > - mkdir -p -m 755 "$PCP_RUN_DIR" > + mkdir -p "$PCP_RUN_DIR" > fi > + chgrp $PCP_GROUP "$PCP_RUN_DIR" > + chmod 777 "$PCP_RUN_DIR" With the makefile fix, this should be able to move up within the "if" branch. The chmod looks fishy - needs to be "775" I think? (and I'd do that within the mkdir still via the -m option). > # setup and clean up base directories and house-keeping for tracking > # pmlogger instances ... needs to be done here because pmcd needs the > @@ -275,6 +277,7 @@ _shutdown() > then > [ "$1" = verbose ] && echo "$prog: pmcd not running" > rm -f $PCP_RUN_DIR/pmcd.pid > + rm -f $PCP_RUN_DIR/pmcd.socket These could be combined into a oneline rm invocation perhaps. cheers. -- Nathan From nscott@redhat.com Thu Jun 20 19:46:40 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 0B0FA7F37 for ; Thu, 20 Jun 2013 19:46:40 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id E9B6B8F8033 for ; Thu, 20 Jun 2013 17:46:36 -0700 (PDT) X-ASG-Debug-ID: 1371775592-04bdf0233f7245f0001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id cchw1u1xkuvlsrGK for ; Thu, 20 Jun 2013 17:46:32 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5L0kWt1002512; Thu, 20 Jun 2013 20:46:32 -0400 Date: Thu, 20 Jun 2013 20:46:32 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Paul Evans Cc: pcp@oss.sgi.com Message-ID: <1173446721.5256069.1371775592318.JavaMail.root@redhat.com> In-Reply-To: <51C34DA0.9030406@redhat.com> References: <51C34DA0.9030406@redhat.com> Subject: Re: [pcp] pmdagfs2: documentation updates MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] pmdagfs2: documentation updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pmdagfs2: documentation updates Thread-Index: obc+QfOal4yBUqo0y0EMMI47NOt65w== X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1371775592 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.03 X-Barracuda-Spam-Status: No, SCORE=0.03 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH, THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134501 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain Hey Paul, ----- Original Message ----- > Hi, > > I have adding some documentation in the usual places for pmdagfs2, these > include a man page, a readme file along with additional commenting in > the qa test files. Any feedback on these would be greatly appreciated. > > These changes are available at: git://github.com/pauljevans/pcp.git dev Awesome - all merged in, thanks. > Looking forward I plan on making some changes to the qa files to have > better guarding for configurations that are not set up correctly > (checking debugfs is mounted etc.) and moving towards providing a client > application to bring together pmdagfs2 metrics for all nodes of a given > cluster. Some additional metrics are on the cards too. Sounds good to me. -- Nathan From kenj@internode.on.net Thu Jun 20 22:37:23 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 21B317F37 for ; Thu, 20 Jun 2013 22:37:23 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id 0652D8F8033 for ; Thu, 20 Jun 2013 20:37:19 -0700 (PDT) X-ASG-Debug-ID: 1371785835-04cb6c2a4147d750001-S8gJnT Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id dgKDM2qk6dmsfIu4 for ; Thu, 20 Jun 2013 20:37:15 -0700 (PDT) X-Barracuda-Envelope-From: kenj@internode.on.net X-Barracuda-Apparent-Source-IP: 150.101.137.129 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AnMVAEXJw1EBnFRzPGdsb2JhbAANToM6iAa5EQMBAQEBOIMGTQQpBw0WGAMCAQIBMQ4ZBgIBAbIzkiWPZoNLA54HjiE Received: from unknown (HELO [10.96.65.92]) ([1.156.84.115]) by ipmail06.adl2.internode.on.net with ESMTP; 21 Jun 2013 13:07:14 +0930 Message-ID: <51C3CA65.6050708@internode.on.net> Date: Fri, 21 Jun 2013 13:37:09 +1000 From: Ken McDonell User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: pcp@oss.sgi.com Subject: pcp updates Content-Type: text/plain; charset=ISO-8859-1 X-ASG-Orig-Subj: pcp updates Content-Transfer-Encoding: 7bit X-Barracuda-Connect: ipmail06.adl2.internode.on.net[150.101.137.129] X-Barracuda-Start-Time: 1371785835 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134513 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/kenj/pcp.git dev qa/536 | 228 ++++----- qa/536.out | 228 ++++----- qa/566 | 114 ++++ qa/566.out | 114 ++++ qa/group | 8 qa/src/badlen-10.0 |binary qa/src/badlen-10.index |binary qa/src/badlen-10.meta |binary qa/src/badlen-11.0 |binary qa/src/badlen-11.index |binary qa/src/badlen-11.meta |binary qa/src/badti-1.0 |binary qa/src/badti-1.index |binary qa/src/badti-1.meta |binary qa/src/badti-2.0 |binary qa/src/badti-2.index |binary qa/src/badti-2.meta |binary qa/src/badti-3.0 |binary qa/src/badti-3.index |binary qa/src/badti-3.meta |binary qa/src/mkbadlen | 25 - qa/src/mkbadti | 107 ++++ src/pmdumplog/pmdumplog.c | 30 + src/pmlogcheck/GNUmakefile | 31 + src/pmlogcheck/RFC | 64 ++ src/pmlogcheck/TODO | 11 src/pmlogcheck/pmlogcheck.c | 1028 ++++++++++++++++++++++++++++++++++++++++++++ 27 files changed, 1749 insertions(+), 239 deletions(-) commit a5b98bb9a4099832472a08b2d52c9bf5f75d0743 Author: Ken McDonell Date: Fri Jun 21 13:34:46 2013 +1000 qa/536 -> qa/566 to avoid existing 536 Oops ... one of the problems with the qa "new" script having no global knowledge of other developers. commit aa955807473fb239625bb3bdf1bee9a669aadd06 Author: Ken McDonell Date: Mon May 27 20:02:26 2013 +1000 (new) pmlogcheck - initial commit Only partly working at this stage, this is an interim commit. The build does not descend into this directory yet. commit 78b461d2627856a0c5dc75df9e9bf1a2c72b8f9b Author: Ken McDonell Date: Mon May 27 20:01:10 2013 +1000 qa/536 - pmlogcheck Lots more dodgey archives. New mkbadti script. commit c7188367ea025b7c9bcf73ef9afd8448f4670b16 Author: Ken McDonell Date: Mon May 27 19:56:09 2013 +1000 pmdumplog - refine time window handling w/out -T and -S No real change in functionality here ... logic is just closer to "correct". From brolley@redhat.com Fri Jun 21 10:01:24 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id D99B17F37 for ; Fri, 21 Jun 2013 10:01:24 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id 7646FAC008 for ; Fri, 21 Jun 2013 08:01:24 -0700 (PDT) X-ASG-Debug-ID: 1371826880-04cbb0468f7422f0001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id 7fDttZl0k8ge1HLV for ; Fri, 21 Jun 2013 08:01:20 -0700 (PDT) X-Barracuda-Envelope-From: brolley@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5LF1Jao010046 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 21 Jun 2013 11:01:19 -0400 Received: from [10.15.16.139] (dhcp-10-15-16-139.yyz.redhat.com [10.15.16.139]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5LF1IK7015832; Fri, 21 Jun 2013 11:01:18 -0400 Message-ID: <51C46ABD.4080307@redhat.com> Date: Fri, 21 Jun 2013 11:01:17 -0400 From: Dave Brolley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Nathan Scott CC: pcp@oss.sgi.com Subject: Re: Installing files/dirs as non-root:root user and group References: <698020944.4509484.1371683485976.JavaMail.root@redhat.com> <51C35A06.6050909@redhat.com> <1097929496.5228235.1371765651634.JavaMail.root@redhat.com> X-ASG-Orig-Subj: Re: Installing files/dirs as non-root:root user and group In-Reply-To: <1097929496.5228235.1371765651634.JavaMail.root@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1371826880 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 Thanks Nathan, I'll make the suggested changes and do some testing over the weekend. Dave On 06/20/2013 06:00 PM, Nathan Scott wrote: > With the makefile fix, this should be able to move up within the "if" > branch. The chmod looks fishy - needs to be "775" I think? (and I'd do > that within the mkdir still via the -m option). I had 775 originally, but qa test 023 (probably among others) was still failing. It starts pmcd in the foreground as the user running the test (brolley in my case). This resulted in EACCESS when pmcd attempted to bind to the socket. The bind(3) man page told me that write access to the directory is required. Changing it to 777 fixed the problem. Dave From sales@asic-online.net Fri Jun 21 21:07:38 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: * X-Spam-Status: No, score=2.0 required=5.0 tests=HTML_IMAGE_ONLY_16, HTML_MESSAGE,T_REMOTE_IMAGE autolearn=no version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 7CD037F37 for ; Fri, 21 Jun 2013 21:07:38 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id 5BDF58F8037 for ; Fri, 21 Jun 2013 19:07:35 -0700 (PDT) X-ASG-Debug-ID: 1371866852-04cbb04691763d00001-S8gJnT Received: from sl-508-5.slc.westdc.net (206.130.123.151.static.westdc.net [206.130.123.151]) by cuda.sgi.com with ESMTP id 0oExfLSIgMKAen0v (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Fri, 21 Jun 2013 19:07:33 -0700 (PDT) X-Barracuda-Envelope-From: sales@asic-online.net X-Barracuda-Apparent-Source-IP: 206.130.123.151 Received: from dab-ell1-h-12-3.dab.02.net ([82.132.237.66]:13670 helo=neils-pc) by sl-508-5.slc.westdc.net with esmtpa (Exim 4.80.1) (envelope-from ) id 1UqDEi-0020e3-BR for pcp@oss.sgi.com; Fri, 21 Jun 2013 20:07:32 -0600 From: "Bitcoin Master" To: "pcp" Subject: Bitcoin Mining Message-ID: X-ASG-Orig-Subj: Bitcoin Mining Date: Sat, 22 Jun 2013 02:56:37 +0100 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_NextPart_000_0001_DFB3AE03.CEAAD141" X-Priority: 3 X-Mailer: Microsoft Office Outlook 12.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - sl-508-5.slc.westdc.net X-AntiAbuse: Original Domain - oss.sgi.com X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - asic-online.net X-Get-Message-Sender-Via: sl-508-5.slc.westdc.net: authenticated_id: sales@asic-online.net X-Source: X-Source-Args: X-Source-Dir: X-Barracuda-Connect: 206.130.123.151.static.westdc.net[206.130.123.151] X-Barracuda-Start-Time: 1371866853 X-Barracuda-Encrypted: AES256-SHA X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.63 X-Barracuda-Spam-Status: No, SCORE=0.63 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=HTML_IMAGE_ONLY_16, HTML_MESSAGE X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134602 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.63 HTML_IMAGE_ONLY_16 BODY: HTML: images with 1200-1600 bytes of words 0.00 HTML_MESSAGE BODY: HTML included in message This is a multi-part message in MIME format. ------=_NextPart_000_0001_DFB3AE03.CEAAD141 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Asic-technologies.com=0D=0A9.3-9.9 GHash/sec 6 Board (has 48 = chips) - 30 BTC - $3000 USD=0D=0A=0D=0AThis unit will make:=0D=0ACoins= per 24h at these conditions 0.2965 BTC=0D=0A=0D=0ARevenue per = day29.08 USD=0D=0A=0D=0AEach module board uses about 31 Watts = of power.=0D=0AMining board's supplied , Case, power supply = , On-board heat sink , USB connectors.=0D=0AReady assembled=0D=0AAll = the boards are linked together , With one main controller.=0D=0AEasy = to Install Software (Disk Provided)=0D=0ASimple Plug and play.=0D=0ACO= NTACT US USING PROMOCODE : EMAIL77 AND GET 15% off !!=0D=0AAsic-techno= logies.com ------=_NextPart_000_0001_DFB3AE03.CEAAD141 Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable =0D=0A=0D=0A=0D=0A=0D=0A=0D=0A
=0D=0A

Asic-technologie= s.com

=0D=0A

9.3-9.9 GHash/sec 6 Board (has 48 = chips) - 30 BTC - $3000 USD

=0D=0A

3D""

=0D=0A

This unit will make:

=0D=0A

=0D=0A= =0D=0A=0D=0A<= TR>=0D=0A=0D=0A=0D=0A=0D=0A=0D=0A= =0D=0A=0D=0A=0D=0A
Coins per 24h at these conditions 0.2= 965 BTC
Revenue per day29.08 = USD

=0D=0A

Each module board = uses about 31 Watts of power.

=0D=0A

Mining board's supplied = ;, Case, power supply , On-board heat sink , USB connectors.

=0D= =0A

Ready assembled
All the boards are linked together = , With one main controller.
Easy to Install Software (Disk = Provided)
Simple Plug and play.

=0D=0A

CONTACT US USING = PROMOCODE : EMAIL77 AND GET 15% off !!

=0D=0A

Asic-technologies.com

= ------=_NextPart_000_0001_DFB3AE03.CEAAD141-- From sales@used-asic-devices.co.uk Sat Jun 22 00:26:38 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: **** X-Spam-Status: No, score=4.4 required=5.0 tests=DATE_IN_PAST_03_06, HTML_IMAGE_ONLY_16,HTML_MESSAGE,T_REMOTE_IMAGE autolearn=no version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 341527F37 for ; Sat, 22 Jun 2013 00:26:38 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id 2223A8F8037 for ; Fri, 21 Jun 2013 22:26:34 -0700 (PDT) X-ASG-Debug-ID: 1371878788-04cb6c2a474cdc60001-S8gJnT Received: from csmtp4.one.com (csmtp4.one.com [195.47.247.103]) by cuda.sgi.com with ESMTP id xbGy2C26SYQxCouI (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Fri, 21 Jun 2013 22:26:29 -0700 (PDT) X-Barracuda-Envelope-From: sales@used-asic-devices.co.uk X-Barracuda-Apparent-Source-IP: 195.47.247.103 Received: from neils-pc (dab-ell1-h-12-6.dab.02.net [82.132.238.77]) by csmtp4.one.com (Postfix) with ESMTPA id C9F56C001F62E for ; Sat, 22 Jun 2013 05:26:27 +0000 (UTC) Received: from neils-pc (dab-ell1-h-12-6.dab.02.net [82.132.238.77]) by 0.0.0.0:2525 (trex/4.8.65); Sat, 22 Jun 2013 05:23:09 GMT From: "Bitcoin Master" To: "pcp" Subject: Bitcoin Mining Message-ID: <4ab3e929f8ab834d9ca8bc8f0deacb35@asic-technologies.com> X-ASG-Orig-Subj: Bitcoin Mining Date: Sat, 22 Jun 2013 02:18:27 +0100 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_NextPart_000_0001_647B3058.F8E18845" X-Priority: 3 X-Mailer: Microsoft Office Outlook 12.0 X-Barracuda-Connect: csmtp4.one.com[195.47.247.103] X-Barracuda-Start-Time: 1371878789 X-Barracuda-Encrypted: AES256-SHA X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 1.71 X-Barracuda-Spam-Status: No, SCORE=1.71 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=DATE_IN_PAST_03_06, DATE_IN_PAST_03_06_2, HTML_IMAGE_ONLY_16, HTML_MESSAGE X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134616 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 DATE_IN_PAST_03_06 Date: is 3 to 6 hours before Received: date 0.63 HTML_IMAGE_ONLY_16 BODY: HTML: images with 1200-1600 bytes of words 0.00 HTML_MESSAGE BODY: HTML included in message 1.08 DATE_IN_PAST_03_06_2 DATE_IN_PAST_03_06_2 This is a multi-part message in MIME format. ------=_NextPart_000_0001_647B3058.F8E18845 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Asic-technologies.com=0D=0A9.3-9.9 GHash/sec 6 Board (has 48 = chips) - 30 BTC - $3000 USD=0D=0A=0D=0AThis unit will make:=0D=0ACoins= per 24h at these conditions 0.2965 BTC=0D=0A=0D=0ARevenue per = day29.08 USD=0D=0A=0D=0AEach module board uses about 31 Watts = of power.=0D=0AMining board's supplied , Case, power supply = , On-board heat sink , USB connectors.=0D=0AReady assembled=0D=0AAll = the boards are linked together , With one main controller.=0D=0AEasy = to Install Software (Disk Provided)=0D=0ASimple Plug and play.=0D=0ACO= NTACT US USING PROMOCODE : EMAIL77 AND GET 15% off !!=0D=0AAsic-techno= logies.com ------=_NextPart_000_0001_647B3058.F8E18845 Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable =0D=0A=0D=0A=0D=0A=0D=0A=0D=0A
=0D=0A

Asic-technologie= s.com

=0D=0A

9.3-9.9 GHash/sec 6 Board (has 48 = chips) - 30 BTC - $3000 USD

=0D=0A

3D""

=0D=0A

This unit will make:

=0D=0A

=0D=0A= =0D=0A=0D=0A<= TR>=0D=0A=0D=0A=0D=0A=0D=0A=0D=0A= =0D=0A=0D=0A=0D=0A
Coins per 24h at these conditions 0.2= 965 BTC
Revenue per day29.08 = USD

=0D=0A

Each module board = uses about 31 Watts of power.

=0D=0A

Mining board's supplied = ;, Case, power supply , On-board heat sink , USB connectors.

=0D= =0A

Ready assembled
All the boards are linked together = , With one main controller.
Easy to Install Software (Disk = Provided)
Simple Plug and play.

=0D=0A

CONTACT US USING = PROMOCODE : EMAIL77 AND GET 15% off !!

=0D=0A

Asic-technologies.com

= ------=_NextPart_000_0001_647B3058.F8E18845-- From nscott@redhat.com Sun Jun 23 17:58:58 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 41F6A7F37 for ; Sun, 23 Jun 2013 17:58:58 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id 134128F8033 for ; Sun, 23 Jun 2013 15:58:55 -0700 (PDT) X-ASG-Debug-ID: 1372028330-04bdf02b8e5d24a0001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id n8ebM2lD1ADsoyGp for ; Sun, 23 Jun 2013 15:58:50 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5NMwodu031822; Sun, 23 Jun 2013 18:58:50 -0400 Date: Sun, 23 Jun 2013 18:58:49 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Dave Brolley Cc: pcp@oss.sgi.com Message-ID: <1471682311.6410189.1372028329559.JavaMail.root@redhat.com> In-Reply-To: <51C46ABD.4080307@redhat.com> References: <698020944.4509484.1371683485976.JavaMail.root@redhat.com> <51C35A06.6050909@redhat.com> <1097929496.5228235.1371765651634.JavaMail.root@redhat.com> <51C46ABD.4080307@redhat.com> Subject: Re: Installing files/dirs as non-root:root user and group MIME-Version: 1.0 X-ASG-Orig-Subj: Re: Installing files/dirs as non-root:root user and group Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: Installing files/dirs as non-root:root user and group Thread-Index: NGk9Y5iDkP6/EiwpR1C34KxbMqUNRA== X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1372028330 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.03 X-Barracuda-Spam-Status: No, SCORE=0.03 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH, THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134776 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain Hi Dave, ----- Original Message ----- > Thanks Nathan, > > I'll make the suggested changes and do some testing over the weekend. > > Dave > > On 06/20/2013 06:00 PM, Nathan Scott wrote: > > With the makefile fix, this should be able to move up within the "if" > > branch. The chmod looks fishy - needs to be "775" I think? (and I'd do > > that within the mkdir still via the -m option). > I had 775 originally, but qa test 023 (probably among others) was still > failing. It starts pmcd in the foreground as the user running the test > (brolley in my case). This resulted in EACCESS when pmcd attempted to > bind to the socket. The bind(3) man page told me that write access to > the directory is required. Changing it to 777 fixed the problem. > Ah - might be a case for the environment variable you mentioned adding in earlier posts; env vars can be handy in qa as older versions ignore them, unlike a command line arg, and newer versions happily proceed using socket file in some alternate, user-writable location. 777 would mean any malicious local user could remove the pmcd socket file from the rundir. cheers. -- Nathan From chandana@desilva.id.au Sun Jun 23 20:15:55 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id DC3977F37 for ; Sun, 23 Jun 2013 20:15:55 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id 9CDDF304043 for ; Sun, 23 Jun 2013 18:15:55 -0700 (PDT) X-ASG-Debug-ID: 1372036550-04bdf0233e800070001-S8gJnT Received: from mho-01-ewr.mailhop.org (mho-03-ewr.mailhop.org [204.13.248.66]) by cuda.sgi.com with ESMTP id wqdnRbDv4DEdnbJt (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Sun, 23 Jun 2013 18:15:50 -0700 (PDT) X-Barracuda-Envelope-From: chandana@desilva.id.au X-Barracuda-Apparent-Source-IP: 204.13.248.66 Received: from ec2-54-252-74-219.ap-southeast-2.compute.amazonaws.com ([54.252.74.219] helo=mail.desilva.id.au) by mho-01-ewr.mailhop.org with esmtpa (Exim 4.72) (envelope-from ) id 1UqvNl-000AsN-M8 for pcp@oss.sgi.com; Mon, 24 Jun 2013 01:15:49 +0000 Received: from [192.168.19.21] (ip-34.83.45.175.VOCUS.net.au [175.45.83.34]) by mail.desilva.id.au (Postfix) with ESMTPSA id EFA2423E95 for ; Mon, 24 Jun 2013 01:15:47 +0000 (UTC) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 54.252.74.219 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+kVW2X+tc6oSDTRO9TcB0M+yyxajwsZP8= Message-ID: <51C79DC2.8090606@desilva.id.au> Date: Mon, 24 Jun 2013 11:15:46 +1000 From: Chandana De Silva Reply-To: chandana@desilva.id.au User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: pcp@oss.sgi.com Subject: pmlogger_merge failing on Centos 6.4 Content-Type: multipart/mixed; boundary="------------020700060106020802010809" X-ASG-Orig-Subj: pmlogger_merge failing on Centos 6.4 X-Barracuda-Connect: mho-03-ewr.mailhop.org[204.13.248.66] X-Barracuda-Start-Time: 1372036550 X-Barracuda-Encrypted: AES256-SHA X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Barracuda-BRTS-Status: 1 X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=DOMAIN_4U2 X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134784 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 DOMAIN_4U2 URI: Domain name containing a "4u" variant This is a multi-part message in MIME format. --------------020700060106020802010809 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit All, The nightly cron job to merge logs is failing on a new Centos 6.4 box. I ran /usr/libexec/pcp/bin/pmlogger_daily with the -t option, but the trace (attached) is silent on why it is failing. PCP Version : pcp-3.8.0-1.el6.x86_64 uname -a -------- Linux monitor.toc 2.6.32-358.el6.x86_64 #1 SMP Fri Feb 22 00:31:26 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux cat /etc/redhat-release ------------------------- CentOS release 6.4 (Final) sudo cat /etc/cron.d/pmlogger ----------------------------- # # standard Performance Co-Pilot crontab entries for a PCP site # with one or more pmlogger instances running # # daily processing of archive logs 10 0 * * * root /usr/libexec/pcp/bin/pmlogger_daily # every 30 minutes, check pmlogger instances are running 25,55 * * * * root /usr/libexec/pcp/bin/pmlogger_check --------------020700060106020802010809 Content-Type: text/plain; charset=UTF-8; name="daily.20130624.08.52.trace" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="daily.20130624.08.52.trace" [control:1] host="#" primary="" socks="" dir="" args="" [control:2] host="#" primary="PCP" socks="archive" dir="logging" args="configuration/control" [control:3] host="#" primary="" socks="" dir="" args="" [control:4] host="#" primary="This" socks="file" dir="is" args="used by various of the PCP archive logging administrative" [control:5] host="#" primary="tools" socks="to" dir="perform" args="maintenance on the pmlogger instances running on" [control:6] host="#" primary="the" socks="local" dir="host." args="" [control:7] host="#" primary="" socks="" dir="" args="" [control:8] host="#" primary="This" socks="file" dir="contains" args="one line per host to be logged, fields are" [control:9] host="#" primary="Host" socks="name" dir="of" args="host to be logged" [control:10] host="#" primary="P(rimary)" socks="is" dir="this" args="the primary logger? y or n" [control:11] host="#" primary="S(ocks)" socks="should" dir="this" args="logger be launched with pmsocks? y or n" [control:12] host="#" primary="Directory" socks="full" dir="pathname" args="to directory where archive logs are" [control:13] host="#" primary="to" socks="be" dir="maintained" args="... note all scripts "cd" to here as" [control:14] host="#" primary="a" socks="first" dir="step" args="" [control:15] host="#" primary="Args" socks="optional" dir="additional" args="arguments to pmlogger and/or pmnewlog" [control:16] host="#" primary="" socks="" dir="" args="" [control:17] host="" primary="" socks="" dir="" args="" [control:18] host="#" primary="===" socks="VARIABLE" dir="ASSIGNMENTS" args="===" [control:19] host="#" primary="" socks="" dir="" args="" [control:20] host="#" primary="DO" socks="NOT" dir="REMOVE" args="OR EDIT THE FOLLOWING LINE" [control:21] host="$version=1.1" primary="" socks="" dir="" args="" [control:22] host="" primary="" socks="" dir="" args="" [control:23] host="#" primary="if" socks="pmsocks" dir="is" args="being used, edit the IP address for $SOCKS_SERVER and" [control:24] host="#" primary="uncomment" socks="the" dir="next" args="line" [control:25] host="#$SOCKS_SERVER=123.456.789.123" primary="" socks="" dir="" args="" [control:26] host="" primary="" socks="" dir="" args="" [control:27] host="#" primary="if" socks="remote" dir="loggers" args="are run over a WAN with potentially long delays," [control:28] host="#" primary="adjust" socks="the" dir="following" args="and uncomment" [control:29] host="$PMCD_CONNECT_TIMEOUT=20" primary="" socks="" dir="" args="" [control:30] host="$PMCD_REQUEST_TIMEOUT=15" primary="" socks="" dir="" args="" [control:31] host="" primary="" socks="" dir="" args="" [control:32] host="#" primary="===" socks="LOGGER" dir="CONTROL" args="SPECIFICATIONS ===" [control:33] host="#" primary="" socks="" dir="" args="" [control:34] host="#Host" primary="P?" socks="S?" dir="directory" args="args" [control:35] host="" primary="" socks="" dir="" args="" [control:36] host="#" primary="local" socks="primary" dir="logger" args="" [control:37] host="#monitor" primary="y" socks="n" dir="/var/log/pcp/pmlogger/monitor" args="-c config.default" [control:38] host="" primary="" socks="" dir="" args="" [control:39] host="#" primary="Note:" socks="if" dir="multiple" args="pmloggers for the same host (e.g. both primary and" [control:40] host="#" primary="non-primary" socks="loggers" dir="are" args="active), then they MUST use different" [control:41] host="#" primary="directories" socks="" dir="" args="" [control:42] host="" primary="" socks="" dir="" args="" [control:43] host="#" primary="local" socks="non-primary" dir="logger" args="" [control:44] host="#monitor" primary="n" socks="n" dir="/var/log/pcp/pmlogger/mysummary" args="-c config.Summary" [control:45] host="" primary="" socks="" dir="" args="" [control:46] host="#" primary="remote" socks="host" dir="" args="" [control:47] host="#remote" primary="n" socks="n" dir="/var/log/pcp/pmlogger/remote" args="-c ./config.remote" [control:48] host="corona-int.m4u.com.au" primary="n" socks="n" dir="/var/log/pcp/pmlogger/corona" args="-c ./config.dbmaster.detailed" Check pmlogger -h corona-int.m4u.com.au ... in /var/log/pcp/pmlogger/corona ... === daily maintenance of PCP archives for host corona-int.m4u.com.au === ... try /var/lib/pcp/tmp/pmlogger/26106: match=2 pmlogger process 26106 identified, OK Looking for pmlogger (process 26106) ... found pcp 26106 1 0 06:12 ? 00:00:09 pmlogger -m pmlogger_daily -l pmlogger.log -h corona-int.m4u.com.au -c /etc/pcp/pmlogger/./config.dbmaster.detailed 20130624.06.12 Getting logged host name from pmlogger (process 26106) ... done Terminating pmlogger (process 26106) ... SIGUSR1 ... SIGTERM ... done Launching new pmlogger in directory "/var/log/pcp/pmlogger/corona" as ... pmlogger -m pmlogger_daily -l pmlogger.log -h corona-int.m4u.com.au -c /etc/pcp/pmlogger/./config.dbmaster.detailed 20130624.08.52 Waiting for new pmlogger to start ... done New pmlogger status ... pmlogger [27327] on host monitor.toc is logging metrics from host corona-int.m4u.com.au PMCD host corona-int.m4u.com.au log started Mon Jun 24 08:54:20 2013 (times in local time) last log entry Mon Jun 24 08:54:20 2013 current time Mon Jun 24 08:52:58 2013 log volume 0 log size 2412 Rewriting input archives using /var/lib/pcp/config/pmlogrewrite Input archive 20130622.14.27 ... Log Label (Log Format Version 2) Performance metrics from host corona-int.m4u.com.au commencing Sat Jun 22 14:29:27.141 2013 ending Sat Jun 22 14:30:27.144 2013 Archive timezone: EST-10 PID for pmlogger: 6014 Input archive 20130622.14.27-00 ... Log Label (Log Format Version 2) Performance metrics from host corona-int.m4u.com.au commencing Sat Jun 22 14:28:42.462 2013 ending Sat Jun 22 14:29:22.459 2013 Archive timezone: EST-10 PID for pmlogger: 2308 Input archive 20130622.14.28 ... Log Label (Log Format Version 2) Performance metrics from host corona-int.m4u.com.au commencing Sat Jun 22 14:30:30.457 2013 ending Sat Jun 22 15:13:50.637 2013 Archive timezone: EST-10 PID for pmlogger: 10563 Input archive 20130622.15.12 ... Log Label (Log Format Version 2) Performance metrics from host corona-int.m4u.com.au commencing Sat Jun 22 15:14:07.111 2013 ending Sat Jun 22 15:17:27.112 2013 Archive timezone: EST-10 PID for pmlogger: 11011 Input archive 20130622.15.16 ... Log Label (Log Format Version 2) Performance metrics from host corona-int.m4u.com.au commencing Sat Jun 22 15:17:42.916 2013 ending Sun Jun 23 07:56:22.874 2013 Archive timezone: EST-10 PID for pmlogger: 11308 Input archives to be merged: 20130622.14.27 20130622.14.27-00 20130622.14.28 20130622.15.12 20130622.15.16 /usr/libexec/pcp/bin/pmlogger_merge: line 253: 27438 Killed $cmd pmlogger_merge: Directory: /var/log/pcp/pmlogger/corona pmlogger_merge: Failed: pmlogextract 20130622.14.27 20130622.14.27-00 20130622.14.28 20130622.15.12 20130622.15.16 20130622 pmlogger_merge: Trying to continue, although output archive may be corrupted. Output archive files: -rw-r--r-- 1 root root 0 Jun 24 08:55 20130622.meta -rw-r--r-- 1 root root 0 Jun 24 08:55 20130622.index -rw-r--r-- 1 root root 0 Jun 24 08:55 20130622.0 Merged output archive 20130622 ... pmdumplog: Cannot open archive "20130622": Empty archive log file pmlogger_daily: Warning: output archive (20130623) already exists [/etc/pcp/pmlogger/control:48] ... skip log merging, culling and compressing for host "corona-int.m4u.com.au" Skip culling and compression ... [control:49] host="" primary="" socks="" dir="" args="" [control:50] host="#" primary="thru" socks="the" dir="firewall" args="via socks" [control:51] host="#distant" primary="n" socks="y" dir="/var/log/pcp/pmlogger/distant" args="-c ./config.distant" --------------020700060106020802010809-- From nscott@redhat.com Sun Jun 23 21:15:19 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 117367F37 for ; Sun, 23 Jun 2013 21:15:19 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id 968F7AC001 for ; Sun, 23 Jun 2013 19:15:15 -0700 (PDT) X-ASG-Debug-ID: 1372040113-04cbb0468e7eaf10001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id 38ucH2ndpJkE7e84 for ; Sun, 23 Jun 2013 19:15:14 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5O2FBaf028373; Sun, 23 Jun 2013 22:15:11 -0400 Date: Sun, 23 Jun 2013 22:15:11 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: chandana@desilva.id.au Cc: pcp@oss.sgi.com Message-ID: <2106903857.6445515.1372040111175.JavaMail.root@redhat.com> In-Reply-To: <51C79DC2.8090606@desilva.id.au> References: <51C79DC2.8090606@desilva.id.au> Subject: Re: [pcp] pmlogger_merge failing on Centos 6.4 MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] pmlogger_merge failing on Centos 6.4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pmlogger_merge failing on Centos 6.4 Thread-Index: SywIFvEwkBv38ZESs5OWOyqVRph5aA== X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1372040113 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_MISMATCH_TO, DOMAIN_4U2, THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134788 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... 0.00 BSF_SC0_MISMATCH_TO Envelope rcpt doesn't match header 0.00 DOMAIN_4U2 URI: Domain name containing a "4u" variant Hi Chandana, ----- Original Message ----- > All, > > The nightly cron job to merge logs is failing on a new Centos 6.4 box. > I ran /usr/libexec/pcp/bin/pmlogger_daily with the -t option, but the > trace (attached) is silent on why it is failing. Hmmm, relevant bit of the trace is this ... Performance metrics from host corona-int.m4u.com.au commencing Sat Jun 22 15:17:42.916 2013 ending Sun Jun 23 07:56:22.874 2013 Archive timezone: EST-10 PID for pmlogger: 11308 Input archives to be merged: 20130622.14.27 20130622.14.27-00 20130622.14.28 20130622.15.12 20130622.15.16 /usr/libexec/pcp/bin/pmlogger_merge: line 253: 27438 Killed $cmd pmlogger_merge: Directory: /var/log/pcp/pmlogger/corona pmlogger_merge: Failed: pmlogextract 20130622.14.27 20130622.14.27-00 20130622.14.28 20130622.15.12 20130622.15.16 20130622 ... which is indeed lacking details as to why pmlogextract failed. If this machine is recording the mysql metrics, and you have the patch you sent me earlier today running on your mysql server, I suspect it may be the root cause. That patch changed the type and units of one of the mysql metrics, which pmlogextract wont be able to reconcile. You might get more detailed information from a manual pmlogger_merge on those archives (see the final "Failed" line above) - the -VV option can be used to ratchet up its verbosity. If it turns out this is from the pmdamysql change, you'll want to add a new pmlogrewrite(1) file to help yourself and others out - see example of /var/lib/pcp/config/pmlogrewrite/linux_proc_migrate.conf - IIRC, it will automatically fix this issue (on all affected servers) once that is in place. cheers. -- Nathan From kenj@internode.on.net Sun Jun 23 21:19:08 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 0FD7E7F37 for ; Sun, 23 Jun 2013 21:19:08 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay3.corp.sgi.com (Postfix) with ESMTP id 905DAAC001 for ; Sun, 23 Jun 2013 19:19:07 -0700 (PDT) X-ASG-Debug-ID: 1372040345-04cb6c2a4254e500001-S8gJnT Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id ccSPCgG887SZWi70 for ; Sun, 23 Jun 2013 19:19:05 -0700 (PDT) X-Barracuda-Envelope-From: kenj@internode.on.net X-Barracuda-Apparent-Source-IP: 150.101.137.141 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApUBAOmrx1F20bGI/2dsb2JhbAANTsBPgmuBFIMYAQEEOEARCyEWDwkDAgECAUUTCAEBrzGRQY9WFoNNA6Fhikg Received: from ppp118-209-177-136.lns20.mel6.internode.on.net (HELO [192.168.1.100]) ([118.209.177.136]) by ipmail04.adl6.internode.on.net with ESMTP; 24 Jun 2013 11:49:04 +0930 Message-ID: <51C7AC9C.5060500@internode.on.net> Date: Mon, 24 Jun 2013 12:19:08 +1000 From: Ken McDonell User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: pcp@oss.sgi.com Subject: Re: [pcp] pmlogger_merge failing on Centos 6.4 References: <51C79DC2.8090606@desilva.id.au> <2106903857.6445515.1372040111175.JavaMail.root@redhat.com> X-ASG-Orig-Subj: Re: [pcp] pmlogger_merge failing on Centos 6.4 In-Reply-To: <2106903857.6445515.1372040111175.JavaMail.root@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Barracuda-Connect: ipmail04.adl6.internode.on.net[150.101.137.141] X-Barracuda-Start-Time: 1372040345 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134790 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- On 24/06/13 12:15, Nathan Scott wrote: > /usr/libexec/pcp/bin/pmlogger_merge: line 253: 27438 Killed $cmd > pmlogger_merge: Directory: /var/log/pcp/pmlogger/corona > pmlogger_merge: Failed: pmlogextract 20130622.14.27 20130622.14.27-00 20130622.14.28 20130622.15.12 20130622.15.16 20130622 > > ... which is indeed lacking details as to why pmlogextract failed. We should fix this ... there is no excuse for binning the reason that pmlogextract failed ... I'll look into this. From chandana@desilva.id.au Sun Jun 23 22:58:32 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 2F09D7F37 for ; Sun, 23 Jun 2013 22:58:32 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay2.corp.sgi.com (Postfix) with ESMTP id 1C5B2304032 for ; Sun, 23 Jun 2013 20:58:28 -0700 (PDT) X-ASG-Debug-ID: 1372046303-04cbb046907efbe0001-S8gJnT Received: from mho-02-ewr.mailhop.org (mho-02-ewr.mailhop.org [204.13.248.72]) by cuda.sgi.com with ESMTP id ewHH9ojlTYdpQ8ES (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Sun, 23 Jun 2013 20:58:24 -0700 (PDT) X-Barracuda-Envelope-From: chandana@desilva.id.au X-Barracuda-Apparent-Source-IP: 204.13.248.72 Received: from ec2-54-252-74-219.ap-southeast-2.compute.amazonaws.com ([54.252.74.219] helo=mail.desilva.id.au) by mho-02-ewr.mailhop.org with esmtpa (Exim 4.72) (envelope-from ) id 1Uqxv5-000DMg-JR; Mon, 24 Jun 2013 03:58:23 +0000 Received: from [192.168.19.21] (ip-34.83.45.175.VOCUS.net.au [175.45.83.34]) by mail.desilva.id.au (Postfix) with ESMTPSA id 138A723E51; Mon, 24 Jun 2013 03:58:21 +0000 (UTC) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 54.252.74.219 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+US+N7WKnTSKrdEZhATNoW3uYdvEpLrlQ= Message-ID: <51C7C3DA.1000508@desilva.id.au> Date: Mon, 24 Jun 2013 13:58:18 +1000 From: Chandana De Silva Reply-To: chandana@desilva.id.au User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Nathan Scott CC: pcp@oss.sgi.com Subject: Re: [pcp] pmlogger_merge failing on Centos 6.4 References: <51C79DC2.8090606@desilva.id.au> <2106903857.6445515.1372040111175.JavaMail.root@redhat.com> X-ASG-Orig-Subj: Re: [pcp] pmlogger_merge failing on Centos 6.4 In-Reply-To: <2106903857.6445515.1372040111175.JavaMail.root@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Barracuda-Connect: mho-02-ewr.mailhop.org[204.13.248.72] X-Barracuda-Start-Time: 1372046304 X-Barracuda-Encrypted: AES256-SHA X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=DOMAIN_4U2 X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134796 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 DOMAIN_4U2 URI: Domain name containing a "4u" variant All, This looks like a memory problem. The pmlogger host has only 1 GB, and I now see OOM-Killer messages in syslog. I will give the host some more memory and see what happens. On 24/06/13 12:15, Nathan Scott wrote: > Hi Chandana, > > ----- Original Message ----- >> All, >> >> The nightly cron job to merge logs is failing on a new Centos 6.4 box. >> I ran /usr/libexec/pcp/bin/pmlogger_daily with the -t option, but the >> trace (attached) is silent on why it is failing. > Hmmm, relevant bit of the trace is this ... > > Performance metrics from host corona-int.m4u.com.au > commencing Sat Jun 22 15:17:42.916 2013 > ending Sun Jun 23 07:56:22.874 2013 > Archive timezone: EST-10 > PID for pmlogger: 11308 > Input archives to be merged: > 20130622.14.27 > 20130622.14.27-00 > 20130622.14.28 > 20130622.15.12 > 20130622.15.16 > /usr/libexec/pcp/bin/pmlogger_merge: line 253: 27438 Killed $cmd > pmlogger_merge: Directory: /var/log/pcp/pmlogger/corona > pmlogger_merge: Failed: pmlogextract 20130622.14.27 20130622.14.27-00 20130622.14.28 20130622.15.12 20130622.15.16 20130622 > > ... which is indeed lacking details as to why pmlogextract failed. > > If this machine is recording the mysql metrics, and you have the patch > you sent me earlier today running on your mysql server, I suspect it > may be the root cause. That patch changed the type and units of one of > the mysql metrics, which pmlogextract wont be able to reconcile. > > You might get more detailed information from a manual pmlogger_merge > on those archives (see the final "Failed" line above) - the -VV option > can be used to ratchet up its verbosity. > > If it turns out this is from the pmdamysql change, you'll want to add a > new pmlogrewrite(1) file to help yourself and others out - see example > of /var/lib/pcp/config/pmlogrewrite/linux_proc_migrate.conf - IIRC, it > will automatically fix this issue (on all affected servers) once that > is in place. > > cheers. > > -- > Nathan From chandana@desilva.id.au Sun Jun 23 23:11:10 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 58F9E7F37 for ; Sun, 23 Jun 2013 23:11:10 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id 37CD2304032 for ; Sun, 23 Jun 2013 21:11:07 -0700 (PDT) X-ASG-Debug-ID: 1372047062-04bdf0233e8081f0001-S8gJnT Received: from mho-01-ewr.mailhop.org (mho-03-ewr.mailhop.org [204.13.248.66]) by cuda.sgi.com with ESMTP id Vv4BZT9CdDf5eMHp (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Sun, 23 Jun 2013 21:11:02 -0700 (PDT) X-Barracuda-Envelope-From: chandana@desilva.id.au X-Barracuda-Apparent-Source-IP: 204.13.248.66 Received: from ec2-54-252-74-219.ap-southeast-2.compute.amazonaws.com ([54.252.74.219] helo=mail.desilva.id.au) by mho-01-ewr.mailhop.org with esmtpa (Exim 4.72) (envelope-from ) id 1Uqy7J-0002iB-Q9; Mon, 24 Jun 2013 04:11:02 +0000 Received: from [192.168.19.21] (ip-34.83.45.175.VOCUS.net.au [175.45.83.34]) by mail.desilva.id.au (Postfix) with ESMTPSA id 5EE7423E51; Mon, 24 Jun 2013 04:10:59 +0000 (UTC) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 54.252.74.219 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+EbCKG7QXZLYWPIOqTJAtThjskjR6uKYU= Message-ID: <51C7C6D1.5040105@desilva.id.au> Date: Mon, 24 Jun 2013 14:10:57 +1000 From: Chandana De Silva Reply-To: chandana@desilva.id.au User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: chandana@desilva.id.au CC: Nathan Scott , pcp@oss.sgi.com Subject: Re: [pcp] pmlogger_merge failing on Centos 6.4 References: <51C79DC2.8090606@desilva.id.au> <2106903857.6445515.1372040111175.JavaMail.root@redhat.com> <51C7C3DA.1000508@desilva.id.au> X-ASG-Orig-Subj: Re: [pcp] pmlogger_merge failing on Centos 6.4 In-Reply-To: <51C7C3DA.1000508@desilva.id.au> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Barracuda-Connect: mho-03-ewr.mailhop.org[204.13.248.66] X-Barracuda-Start-Time: 1372047062 X-Barracuda-Encrypted: AES256-SHA X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.50 X-Barracuda-Spam-Status: No, SCORE=0.50 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_MISMATCH_TO, BSF_SC0_SA_TO_FROM_ADDR_MATCH X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134796 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 BSF_SC0_MISMATCH_TO Envelope rcpt doesn't match header 0.50 BSF_SC0_SA_TO_FROM_ADDR_MATCH Sender Address Matches Recipient Address Worked with 4GB. I should mention that we are logging ~ 240 metrics at 20 second intervals. On 24/06/13 13:58, Chandana De Silva wrote: > All, > > This looks like a memory problem. The pmlogger host has only 1 GB, and > I now see OOM-Killer messages in syslog. > > I will give the host some more memory and see what happens. From kenj@internode.on.net Sun Jun 23 23:17:29 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id B0D9D7F37 for ; Sun, 23 Jun 2013 23:17:29 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id 7C51B304043 for ; Sun, 23 Jun 2013 21:17:29 -0700 (PDT) X-ASG-Debug-ID: 1372047447-04bdf0233e808600001-S8gJnT Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id AybLYw3OaG7T36wu for ; Sun, 23 Jun 2013 21:17:28 -0700 (PDT) X-Barracuda-Envelope-From: kenj@internode.on.net X-Barracuda-Apparent-Source-IP: 150.101.137.141 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvwCAB7Hx1F20bGI/2dsb2JhbAANTsBPgmIEBAGBFYMXAQEBBDhAEQsYCRYPCQMCAQIBRRMIAQGvMpFPj1YWg00DoWGKSA Received: from ppp118-209-177-136.lns20.mel6.internode.on.net (HELO [192.168.1.100]) ([118.209.177.136]) by ipmail04.adl6.internode.on.net with ESMTP; 24 Jun 2013 13:47:27 +0930 Message-ID: <51C7C85C.4020600@internode.on.net> Date: Mon, 24 Jun 2013 14:17:32 +1000 From: Ken McDonell User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: pcp@oss.sgi.com Subject: Re: [pcp] pmlogger_merge failing on Centos 6.4 References: <51C79DC2.8090606@desilva.id.au> <2106903857.6445515.1372040111175.JavaMail.root@redhat.com> <51C7C3DA.1000508@desilva.id.au> X-ASG-Orig-Subj: Re: [pcp] pmlogger_merge failing on Centos 6.4 In-Reply-To: <51C7C3DA.1000508@desilva.id.au> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Barracuda-Connect: ipmail04.adl6.internode.on.net[150.101.137.141] X-Barracuda-Start-Time: 1372047447 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134796 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- On 24/06/13 13:58, Chandana De Silva wrote: > All, > > This looks like a memory problem. The pmlogger host has only 1 GB, and I > now see OOM-Killer messages in syslog. Chandana ... I'll be in your office on Wed, if it can wait till then I'll sort out the problem with your real logs. From kenj@internode.on.net Sun Jun 23 23:19:10 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 539F47F37 for ; Sun, 23 Jun 2013 23:19:10 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id 414868F8037 for ; Sun, 23 Jun 2013 21:19:07 -0700 (PDT) X-ASG-Debug-ID: 1372047545-04cbb0468f7f08e0001-S8gJnT Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id Gv4AA8JbaREi1259 for ; Sun, 23 Jun 2013 21:19:05 -0700 (PDT) X-Barracuda-Envelope-From: kenj@internode.on.net X-Barracuda-Apparent-Source-IP: 150.101.137.141 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApUBABzIx1F20bGI/2dsb2JhbAANTsBPgmuBFYMXAQEBBDhAEQsYCRYPCQMCAQIBRRMIAQGvMpFPj1YWg00DoWGKSA Received: from ppp118-209-177-136.lns20.mel6.internode.on.net (HELO [192.168.1.100]) ([118.209.177.136]) by ipmail04.adl6.internode.on.net with ESMTP; 24 Jun 2013 13:49:04 +0930 Message-ID: <51C7C8BE.4080903@internode.on.net> Date: Mon, 24 Jun 2013 14:19:10 +1000 From: Ken McDonell User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: pcp@oss.sgi.com Subject: Re: [pcp] pmlogger_merge failing on Centos 6.4 References: <51C79DC2.8090606@desilva.id.au> <2106903857.6445515.1372040111175.JavaMail.root@redhat.com> <51C7C3DA.1000508@desilva.id.au> <51C7C6D1.5040105@desilva.id.au> X-ASG-Orig-Subj: Re: [pcp] pmlogger_merge failing on Centos 6.4 In-Reply-To: <51C7C6D1.5040105@desilva.id.au> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Barracuda-Connect: ipmail04.adl6.internode.on.net[150.101.137.141] X-Barracuda-Start-Time: 1372047545 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134798 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- On 24/06/13 14:10, Chandana De Silva wrote: > Worked with 4GB. > > I should mention that we are logging ~ 240 metrics at 20 second intervals. OK, I'll look at the memory footprint also on Wed ... this seems excessive, _unless_ the proc metrics are being logged also (big indom, changes every fetch, huge meta data file and we load that all into memory at the archive open time). From nscott@redhat.com Mon Jun 24 05:04:21 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 5A91B7F37 for ; Mon, 24 Jun 2013 05:04:21 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id 47FCA8F8033 for ; Mon, 24 Jun 2013 03:04:18 -0700 (PDT) X-ASG-Debug-ID: 1372068253-04cb6c2a475684b0001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id O1Db1HiRYMXmclwi for ; Mon, 24 Jun 2013 03:04:13 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5OA4DsG008469; Mon, 24 Jun 2013 06:04:13 -0400 Date: Mon, 24 Jun 2013 06:04:13 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Dave Brolley Cc: PCP Message-ID: <577035819.6633537.1372068253266.JavaMail.root@redhat.com> In-Reply-To: <51AD5434.9090200@redhat.com> References: <51AD5434.9090200@redhat.com> Subject: Re: [pcp] Unix Domain Sockets MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] Unix Domain Sockets Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: Unix Domain Sockets Thread-Index: vBhoxYh0coxUR+KLoVv6seuQTQWZXg== X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1372068253 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.03 X-Barracuda-Spam-Status: No, SCORE=0.03 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH, THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134820 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain Hey Dave, ----- Original Message ----- > Hi, > > I've been looking into the ins and outs of adding the capability of > listening on unix domain sockets to pmcd (and presumably pmproxy, and > perhaps other components) via extensions to ... As discussed (off-list I think? can't seem to find a reference now anyway) I took a pass over latest-and-greatest from the brolley/dev branch over in sourceware.org/pcpfans. Loo-king good! Here's every little persnickety note I made while reviewing ... QA - Some QA tests now getting up to 10 alternate output forms (maintenance of alternate competing version becoming a problem) - for the tests which are exercising access control on remote hosts, theres no reason (AFAICT) that we need to make sure the unix domain socket log lines are in the output (there's nothing being tested there) - thats not the case for IPv6 so while we did need to add the conditional output for that, IMO we don't need to add it in the case of unix sockets. - Thoughts? (so, I think we should filter out the unix-domain lines and stick with the existing .out files for most/all of these tests). auxconnect.c - __pmInitSocket - API change - OK, cos its an internal.h routine only? - need the SO_LINGER on unix domain sockets? if not, we could short-circuit the routine and have just the one #ifdef ... #if defined(SOCKADDR_UN) if (family == AF_UNIX) return fd; #endif ... and one less syscall. *shrug* - __pmPMCDLocalSocketDefault() - no need for the '= ""' in pmcd_socket, statics init'd to zero - snprintf needs to pass sizeof(pmcd_socket) - 1 to ensure null termination (two spots) - inconsistent comment style with surrounding code - __pmCreateUnixSocket() - inconsistent comment style with surrounding code auxserver.c - localSocket{Path,Fd} don't need to be conditional AFAICT (?) (simplifies other code later - less #ifdef sprawl, more readable). - OpenRequestSocket() - we make an immediate decision based on value *family but this is not guaranteed to be initialised -> see 3rd callsite in OpenRequestPorts() - Dave-style comments, inconsistent with surrounding code - __pmServerCloseRequestPorts() - new code doesn't need to be #ifdef'd - no need for assignment to "i" in new code? - second diagnostic should probably also report gid/egid given expected filesystem permissions on PCP_RUN_DIR? - make into a single call to __pmNotifyErr, double-equals isn't really the common convention - just use single-equals I reckon. - __pmServerAddNewClients - new code here doesn't need to be #ifdef'd - __pmServerDumpRequestPorts - __pmServerRequestPortString - new code in both doesn't need to be #ifdef'd check-statics - if we don't remove the conditional check on new statics above, build will fail in this script I think (wont be able to find global static variables that we're now adding). config.c - release number in comment is off-by-one now cos I snuck a release in last week connect.c - pmcd_socket can be declared unconditionally? check-statics will want that IIRC. - can avoid yet another global by merging new load_pmcd_local_socket() into load_pmcd_ports (rename to load_pmcd_socket_config or something along those lines?) - __pmConnectPMCD() - I *think* for the case where we set "sts = -2" in new code, we'll fall into a bad state in the first diagnostic after "if (sts == -1)" (which does the usual inet/ipv6 socket connections)? at very least, wont it print "... port= failed: ..."? (ie miss printing the port) secureconnect.c - some Dave-style comments - __pmSetSockOpt - there's no SO_PASSCRED on Win32/Win64 - sneak it into the existing #ifdef there for SO_EXCLUSIVEADDRUSE perhaps? spec.c - need a new QA test along the lines of test 720 which invokes the host parser with unix socket addresses with valgrind, checks and dumps 'em - doesn't feel right to have the parser logic have #ifdef conditional goo all over it like this - elsewhere in pmNewContext we should be dealing with lack of support (ie lower down) anyway, so we should not have to do it here too. I think. Right? Simplifies life here - no need for the additional parseProtocolSpec argument, just parse it & pass it on. - also, use PCP_ATTR_UNIXSOCK for unix: prefix, add in a PCP_ATTR_LOCAL, and return *attribute from parseProtocolSpec. Then, you wont need to do the check-to-see-if-value-non-null-then-strcmp-it dance back in the caller - just use the return code. You also wont need the new isLocal and isUnix variables in the caller, so code should become simpler. - a sprinkling of Dave-style comments pmcd.c - sockpath does not need to be conditional - so - just unconditionally accept the command line arg (-s) - then, either make __pmServerSetLocalSocket return an error code if not supported, or better still make __pmServerOpenRequestPorts report and fail later on. - that new __pmPMCDLocalSocketDefault call here feels wrong too - could this not be hidden away inside __pmServerSetLocalSocket, removing need for pmcd and other servers to have to deal with setting defaults? Use __pmProgname in there, if it needs different xxx.socket name for pmcd/ pmproxy/pmwebd? One less symbol/function in libpcp too then, and one less interface exposed by impl.h that we need to keep back-compatible. cheers. -- Nathan From brolley@redhat.com Mon Jun 24 10:07:36 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id C89B37F37 for ; Mon, 24 Jun 2013 10:07:36 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id B715E8F8050 for ; Mon, 24 Jun 2013 08:07:33 -0700 (PDT) X-ASG-Debug-ID: 1372086449-04cb6c2a4657e830001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id b2YEBA7G3RXQj3Gt for ; Mon, 24 Jun 2013 08:07:29 -0700 (PDT) X-Barracuda-Envelope-From: brolley@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5OF7SAb004854 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 24 Jun 2013 11:07:29 -0400 Received: from [10.15.16.139] (dhcp-10-15-16-139.yyz.redhat.com [10.15.16.139]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5OF7R15009639; Mon, 24 Jun 2013 11:07:28 -0400 Message-ID: <51C860AF.8060006@redhat.com> Date: Mon, 24 Jun 2013 11:07:27 -0400 From: Dave Brolley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Nathan Scott CC: PCP Subject: Re: [pcp] Unix Domain Sockets References: <51AD5434.9090200@redhat.com> <577035819.6633537.1372068253266.JavaMail.root@redhat.com> X-ASG-Orig-Subj: Re: [pcp] Unix Domain Sockets In-Reply-To: <577035819.6633537.1372068253266.JavaMail.root@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1372086449 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 Thanks for the review! I'll work through these today (my Monday, your Tuesday) and see if I can get the rework push by the end of the day. Dave On 06/24/2013 06:04 AM, Nathan Scott wrote: > As discussed (off-list I think? can't seem to find a reference now > anyway) I took a pass over latest-and-greatest from the brolley/dev > branch over in sourceware.org/pcpfans. Loo-king good! Here's every > little persnickety note I made while reviewing ... > From chandana@desilva.id.au Mon Jun 24 14:54:42 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 00A2D7F37 for ; Mon, 24 Jun 2013 14:54:42 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id C6793304059 for ; Mon, 24 Jun 2013 12:54:38 -0700 (PDT) X-ASG-Debug-ID: 1372103673-04bdf02b8e622820001-S8gJnT Received: from mho-02-ewr.mailhop.org (mho-02-ewr.mailhop.org [204.13.248.72]) by cuda.sgi.com with ESMTP id fW8repJc57u0RPGZ (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Mon, 24 Jun 2013 12:54:34 -0700 (PDT) X-Barracuda-Envelope-From: chandana@desilva.id.au X-Barracuda-Apparent-Source-IP: 204.13.248.72 Received: from ec2-54-252-74-219.ap-southeast-2.compute.amazonaws.com ([54.252.74.219] helo=mail.desilva.id.au) by mho-02-ewr.mailhop.org with esmtpa (Exim 4.72) (envelope-from ) id 1UrCqP-000HDZ-3x for pcp@oss.sgi.com; Mon, 24 Jun 2013 19:54:33 +0000 Received: from [192.168.1.57] (d110-33-183-119.sun801.vic.optusnet.com.au [110.33.183.119]) by mail.desilva.id.au (Postfix) with ESMTPSA id 3134D23ED5 for ; Mon, 24 Jun 2013 19:54:31 +0000 (UTC) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 54.252.74.219 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19WhRSWDz07+RDY1m9rAseTpqXIsW0v+Os= Message-ID: <51C8A3F6.2090103@desilva.id.au> Date: Tue, 25 Jun 2013 05:54:30 +1000 From: Chandana De Silva Reply-To: chandana@desilva.id.au User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: pcp@oss.sgi.com Subject: Re: [pcp] pmlogger_merge failing on Centos 6.4 References: X-ASG-Orig-Subj: Re: [pcp] pmlogger_merge failing on Centos 6.4 In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Barracuda-Connect: mho-02-ewr.mailhop.org[204.13.248.72] X-Barracuda-Start-Time: 1372103673 X-Barracuda-Encrypted: AES256-SHA X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134859 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- proc metrics are being logged. This is short term, while we are watching a situation Chandana On 25/06/13 03:00, pcp-request@oss.sgi.com wrote: > On 24/06/13 14:10, Chandana De Silva wrote: >> >Worked with 4GB. >> > >> >I should mention that we are logging ~ 240 metrics at 20 second intervals. > OK, I'll look at the memory footprint also on Wed ... this seems > excessive,_unless_ the proc metrics are being logged also (big indom, > changes every fetch, huge meta data file and we load that all into > memory at the archive open time). From nscott@redhat.com Mon Jun 24 17:53:38 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 3689E7F37 for ; Mon, 24 Jun 2013 17:53:38 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay2.corp.sgi.com (Postfix) with ESMTP id 16EA5304043 for ; Mon, 24 Jun 2013 15:53:35 -0700 (PDT) X-ASG-Debug-ID: 1372114410-04cbb04691838f50001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id JAq0ynboxWXFKK4W for ; Mon, 24 Jun 2013 15:53:30 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5OMrSlN016720; Mon, 24 Jun 2013 18:53:28 -0400 Date: Mon, 24 Jun 2013 18:53:27 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: chandana@desilva.id.au Cc: pcp@oss.sgi.com Message-ID: <953233383.7176405.1372114407876.JavaMail.root@redhat.com> In-Reply-To: <51C8A3F6.2090103@desilva.id.au> References: <51C8A3F6.2090103@desilva.id.au> Subject: Re: [pcp] pmlogger_merge failing on Centos 6.4 MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] pmlogger_merge failing on Centos 6.4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pmlogger_merge failing on Centos 6.4 Thread-Index: YX8bpyfXaMmXbcpv3SiaOb4gBuMZHQ== X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1372114410 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_MISMATCH_TO, THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134871 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... 0.00 BSF_SC0_MISMATCH_TO Envelope rcpt doesn't match header Hi, ----- Original Message ----- > proc metrics are being logged. > > This is short term, while we are watching a situation > > > ... this seems excessive, _unless_ > > the proc metrics are being logged also (big indom, > > changes every fetch, huge meta data file and we load > > that all into memory at the archive open time). > BTW, a longer-term solution here would be to use a cgroup for reducing the process indom and reigning in its huge variation. Requires some coding in cgroup_procs_fetch() in src/pmdas/linux_proc/cgroups.c though (commented block marked with TODO in there). cheers. -- Nathan From kenj@internode.on.net Tue Jun 25 06:54:21 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 3AB007F37 for ; Tue, 25 Jun 2013 06:54:21 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id AD356AC003 for ; Tue, 25 Jun 2013 04:54:20 -0700 (PDT) X-ASG-Debug-ID: 1372161254-04cbb0468e86c1b0001-S8gJnT Received: from ipmail06.adl6.internode.on.net (ipmail06.adl6.internode.on.net [150.101.137.145]) by cuda.sgi.com with ESMTP id jGh4WcBj1Bx6KOwK for ; Tue, 25 Jun 2013 04:54:15 -0700 (PDT) X-Barracuda-Envelope-From: kenj@internode.on.net X-Barracuda-Apparent-Source-IP: 150.101.137.145 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAMeDyVF20bGI/2dsb2JhbAANTcRUg1ABRT0WGAMCAQIBPwwNCAEBsEySRJMvA6wp Received: from ppp118-209-177-136.lns20.mel6.internode.on.net (HELO [192.168.1.100]) ([118.209.177.136]) by ipmail06.adl6.internode.on.net with ESMTP; 25 Jun 2013 21:24:14 +0930 Message-ID: <51C984EE.5010808@internode.on.net> Date: Tue, 25 Jun 2013 21:54:22 +1000 From: Ken McDonell User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: PCP Mailing List Subject: compilation warnings Content-Type: text/plain; charset=windows-1252 X-ASG-Orig-Subj: compilation warnings Content-Transfer-Encoding: 8bit X-Barracuda-Connect: ipmail06.adl6.internode.on.net[150.101.137.145] X-Barracuda-Start-Time: 1372161255 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134923 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- I'm seeing some new compilations warnings ... could those responsible for the associated recent code changes please take a look and see if these can be resolved? == dpkg-buildpackage: build contexts.c: In function ‘proc_ctx_revert’: contexts.c:136:9: warning: ignoring return value of ‘seteuid’, declared with attribute warn_unused_result [-Wunused-result] contexts.c:138:9: warning: ignoring return value of ‘setegid’, declared with attribute warn_unused_result [-Wunused-result] contexts.c: In function ‘proc_ctx_access’: contexts.c:119:9: warning: ignoring return value of ‘seteuid’, declared with attribute warn_unused_result [-Wunused-result] contexts.c:121:9: warning: ignoring return value of ‘setegid’, declared with attribute warn_unused_result [-Wunused-result] lock_time.c: In function ‘gfs2_refresh_lock_time’: lock_time.c:281:13: warning: ‘glockA.queue’ may be used uninitialized in this function [-Wmaybe-uninitialized] lock_time.c:189:30: note: ‘glockA.queue’ was declared here lock_time.c:281:13: warning: ‘glockA.dlm’ may be used uninitialized in this function [-Wmaybe-uninitialized] lock_time.c:189:30: note: ‘glockA.dlm’ was declared here lock_time.c:240:31: warning: ‘glockA.sirtvar’ may be used uninitialized in this function [-Wmaybe-uninitialized] lock_time.c:189:30: note: ‘glockA.sirtvar’ was declared here lock_time.c:240:31: warning: ‘glockA.sirt’ may be used uninitialized in this function [-Wmaybe-uninitialized] lock_time.c:189:30: note: ‘glockA.sirt’ was declared here lock_time.c:240:31: warning: ‘glockA.srttvarb’ may be used uninitialized in this function [-Wmaybe-uninitialized] lock_time.c:189:30: note: ‘glockA.srttvarb’ was declared here lock_time.c:240:31: warning: ‘glockA.srttb’ may be used uninitialized in this function [-Wmaybe-uninitialized] lock_time.c:189:30: note: ‘glockA.srttb’ was declared here lock_time.c:240:31: warning: ‘glockA.srttvar’ may be used uninitialized in this function [-Wmaybe-uninitialized] lock_time.c:189:30: note: ‘glockA.srttvar’ was declared here lock_time.c:240:31: warning: ‘glockA.srtt’ may be used uninitialized in this function [-Wmaybe-uninitialized] lock_time.c:189:30: note: ‘glockA.srtt’ was declared here lock_time.c:240:31: warning: ‘glockA.number’ may be used uninitialized in this function [-Wmaybe-uninitialized] lock_time.c:189:30: note: ‘glockA.number’ was declared here lock_time.c:240:31: warning: ‘glockA.lock_type’ may be used uninitialized in this function [-Wmaybe-uninitialized] lock_time.c:189:30: note: ‘glockA.lock_type’ was declared here From nscott@redhat.com Tue Jun 25 07:03:38 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 7BA837F37 for ; Tue, 25 Jun 2013 07:03:38 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id 0B5EFAC003 for ; Tue, 25 Jun 2013 05:03:34 -0700 (PDT) X-ASG-Debug-ID: 1372161813-04cbb0469186ce60001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id 0iPJEuBPBvD2loEV for ; Tue, 25 Jun 2013 05:03:33 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5PC3Uic011904; Tue, 25 Jun 2013 08:03:30 -0400 Date: Tue, 25 Jun 2013 08:03:29 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Ken McDonell , Paul Evans Cc: PCP Mailing List Message-ID: <1105771973.7535746.1372161809939.JavaMail.root@redhat.com> In-Reply-To: <51C984EE.5010808@internode.on.net> References: <51C984EE.5010808@internode.on.net> Subject: Re: [pcp] compilation warnings MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] compilation warnings Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: compilation warnings Thread-Index: fv58P9PGVEi+JUdtz4Aq1hMUFJElxA== X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1372161813 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134923 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... ----- Original Message ----- > I'm seeing some new compilations warnings ... could those responsible for= the > associated recent code changes please take a look and see if these can be > resolved? >=20 That'd be me for the first patch, and Paul for the latter I think. >=20 > =3D=3D dpkg-buildpackage: build > contexts.c: In function =E2=80=98proc_ctx_revert=E2=80=99: > contexts.c:136:9: warning: ignoring return value of =E2=80=98seteuid=E2= =80=99, declared with > attribute warn_unused_result [-Wunused-result] > contexts.c:138:9: warning: ignoring return value of =E2=80=98setegid=E2= =80=99, declared with > attribute warn_unused_result [-Wunused-result] > contexts.c: In function =E2=80=98proc_ctx_access=E2=80=99: > contexts.c:119:9: warning: ignoring return value of =E2=80=98seteuid=E2= =80=99, declared with > attribute warn_unused_result [-Wunused-result] > contexts.c:121:9: warning: ignoring return value of =E2=80=98setegid=E2= =80=99, declared with > attribute warn_unused_result [-Wunused-result] > lock_time.c: In function =E2=80=98gfs2_refresh_lock_time=E2=80=99: > lock_time.c:281:13: warning: =E2=80=98glockA.queue=E2=80=99 may be used u= ninitialized in this > function [-Wmaybe-uninitialized] > lock_time.c:189:30: note: =E2=80=98glockA.queue=E2=80=99 was declared her= e > lock_time.c:281:13: warning: =E2=80=98glockA.dlm=E2=80=99 may be used uni= nitialized in this > function [-Wmaybe-uninitialized] > lock_time.c:189:30: note: =E2=80=98glockA.dlm=E2=80=99 was declared here > lock_time.c:240:31: warning: =E2=80=98glockA.sirtvar=E2=80=99 may be used= uninitialized in > this function [-Wmaybe-uninitialized] > lock_time.c:189:30: note: =E2=80=98glockA.sirtvar=E2=80=99 was declared h= ere > lock_time.c:240:31: warning: =E2=80=98glockA.sirt=E2=80=99 may be used un= initialized in this > function [-Wmaybe-uninitialized] > lock_time.c:189:30: note: =E2=80=98glockA.sirt=E2=80=99 was declared here > lock_time.c:240:31: warning: =E2=80=98glockA.srttvarb=E2=80=99 may be use= d uninitialized in > this function [-Wmaybe-uninitialized] > lock_time.c:189:30: note: =E2=80=98glockA.srttvarb=E2=80=99 was declared = here > lock_time.c:240:31: warning: =E2=80=98glockA.srttb=E2=80=99 may be used u= ninitialized in this > function [-Wmaybe-uninitialized] > lock_time.c:189:30: note: =E2=80=98glockA.srttb=E2=80=99 was declared her= e > lock_time.c:240:31: warning: =E2=80=98glockA.srttvar=E2=80=99 may be used= uninitialized in > this function [-Wmaybe-uninitialized] > lock_time.c:189:30: note: =E2=80=98glockA.srttvar=E2=80=99 was declared h= ere > lock_time.c:240:31: warning: =E2=80=98glockA.srtt=E2=80=99 may be used un= initialized in this > function [-Wmaybe-uninitialized] > lock_time.c:189:30: note: =E2=80=98glockA.srtt=E2=80=99 was declared here > lock_time.c:240:31: warning: =E2=80=98glockA.number=E2=80=99 may be used = uninitialized in > this function [-Wmaybe-uninitialized] > lock_time.c:189:30: note: =E2=80=98glockA.number=E2=80=99 was declared he= re > lock_time.c:240:31: warning: =E2=80=98glockA.lock_type=E2=80=99 may be us= ed uninitialized in > this function [-Wmaybe-uninitialized] > lock_time.c:189:30: note: =E2=80=98glockA.lock_type=E2=80=99 was declared= here >=20 > _______________________________________________ > pcp mailing list > pcp@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/pcp >=20 From pevans@redhat.com Tue Jun 25 07:35:40 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 816027F37 for ; Tue, 25 Jun 2013 07:35:40 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id 611E38F8035 for ; Tue, 25 Jun 2013 05:35:37 -0700 (PDT) X-ASG-Debug-ID: 1372163736-04cbb0469086f9e0001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id el7lhUjyTyREpCFQ for ; Tue, 25 Jun 2013 05:35:36 -0700 (PDT) X-Barracuda-Envelope-From: pevans@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5PCZWR3008415 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 25 Jun 2013 08:35:32 -0400 Received: from [10.36.5.38] (vpn1-5-38.ams2.redhat.com [10.36.5.38]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5PCZUUx002393; Tue, 25 Jun 2013 08:35:31 -0400 Message-ID: <51C98E92.2040406@redhat.com> Date: Tue, 25 Jun 2013 13:35:30 +0100 From: Paul Evans User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Ken McDonell , Nathan Scott CC: PCP Mailing List Subject: Re: [pcp] compilation warnings References: <51C984EE.5010808@internode.on.net> X-ASG-Orig-Subj: Re: [pcp] compilation warnings In-Reply-To: <51C984EE.5010808@internode.on.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1372163736 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 Hi Ken, The -Wmaybe-uninitialized in lock_time.c are from me. Shall push a patch to the list now with the changes correcting these. In the cases mentioned glockA will always be initialised before reaching the function, however it will be cleaner to have no compilation warnings. On 06/25/2013 12:54 PM, Ken McDonell wrote: > I'm seeing some new compilations warnings ... could those responsible for the associated recent code changes please take a look and see if these can be resolved? > > > == dpkg-buildpackage: build > contexts.c: In function ‘proc_ctx_revert’: > contexts.c:136:9: warning: ignoring return value of ‘seteuid’, declared with attribute warn_unused_result [-Wunused-result] > contexts.c:138:9: warning: ignoring return value of ‘setegid’, declared with attribute warn_unused_result [-Wunused-result] > contexts.c: In function ‘proc_ctx_access’: > contexts.c:119:9: warning: ignoring return value of ‘seteuid’, declared with attribute warn_unused_result [-Wunused-result] > contexts.c:121:9: warning: ignoring return value of ‘setegid’, declared with attribute warn_unused_result [-Wunused-result] > lock_time.c: In function ‘gfs2_refresh_lock_time’: > lock_time.c:281:13: warning: ‘glockA.queue’ may be used uninitialized in this function [-Wmaybe-uninitialized] > lock_time.c:189:30: note: ‘glockA.queue’ was declared here > lock_time.c:281:13: warning: ‘glockA.dlm’ may be used uninitialized in this function [-Wmaybe-uninitialized] > lock_time.c:189:30: note: ‘glockA.dlm’ was declared here > lock_time.c:240:31: warning: ‘glockA.sirtvar’ may be used uninitialized in this function [-Wmaybe-uninitialized] > lock_time.c:189:30: note: ‘glockA.sirtvar’ was declared here > lock_time.c:240:31: warning: ‘glockA.sirt’ may be used uninitialized in this function [-Wmaybe-uninitialized] > lock_time.c:189:30: note: ‘glockA.sirt’ was declared here > lock_time.c:240:31: warning: ‘glockA.srttvarb’ may be used uninitialized in this function [-Wmaybe-uninitialized] > lock_time.c:189:30: note: ‘glockA.srttvarb’ was declared here > lock_time.c:240:31: warning: ‘glockA.srttb’ may be used uninitialized in this function [-Wmaybe-uninitialized] > lock_time.c:189:30: note: ‘glockA.srttb’ was declared here > lock_time.c:240:31: warning: ‘glockA.srttvar’ may be used uninitialized in this function [-Wmaybe-uninitialized] > lock_time.c:189:30: note: ‘glockA.srttvar’ was declared here > lock_time.c:240:31: warning: ‘glockA.srtt’ may be used uninitialized in this function [-Wmaybe-uninitialized] > lock_time.c:189:30: note: ‘glockA.srtt’ was declared here > lock_time.c:240:31: warning: ‘glockA.number’ may be used uninitialized in this function [-Wmaybe-uninitialized] > lock_time.c:189:30: note: ‘glockA.number’ was declared here > lock_time.c:240:31: warning: ‘glockA.lock_type’ may be used uninitialized in this function [-Wmaybe-uninitialized] > lock_time.c:189:30: note: ‘glockA.lock_type’ was declared here > > _______________________________________________ > pcp mailing list > pcp@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/pcp Cheers, Paul From pevans@redhat.com Tue Jun 25 08:04:34 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id BDA3A7F37 for ; Tue, 25 Jun 2013 08:04:34 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay2.corp.sgi.com (Postfix) with ESMTP id AC57630405F for ; Tue, 25 Jun 2013 06:04:31 -0700 (PDT) X-ASG-Debug-ID: 1372165470-04cbb0468e871d20001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id yZd5j4vFrkFHPCEW for ; Tue, 25 Jun 2013 06:04:31 -0700 (PDT) X-Barracuda-Envelope-From: pevans@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5PD4PTJ015217 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 25 Jun 2013 09:04:26 -0400 Received: from [10.36.5.38] (vpn1-5-38.ams2.redhat.com [10.36.5.38]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5PD4Nup009317; Tue, 25 Jun 2013 09:04:24 -0400 Message-ID: <51C99557.9080703@redhat.com> Date: Tue, 25 Jun 2013 14:04:23 +0100 From: Paul Evans User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Nathan Scott , Ken McDonell CC: PCP Mailing List Subject: pmdagfs2: gcc -Wmaybe-uninitialized compilation warnings fix Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-ASG-Orig-Subj: pmdagfs2: gcc -Wmaybe-uninitialized compilation warnings fix Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1372165470 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 Hi, I have pushed a fix to correct the gcc -Wmaybe-uninitialized as discovered by Ken the pmdagfs2 code. Made changes in lock_time.c to ensure that glockA and glockB are correctly initialized before having glock values from the GFS2 filesystem assigned to them from the hash-map. This fix is available at: git://github.com/pauljevans/pcp.git dev Cheers, Paul. From nscott@redhat.com Tue Jun 25 08:07:43 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id A982C7F37 for ; Tue, 25 Jun 2013 08:07:43 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id 7B5E58F8037 for ; Tue, 25 Jun 2013 06:07:40 -0700 (PDT) X-ASG-Debug-ID: 1372165657-04bdf0233c88edc0001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id AC3qAal5MNWFVLZ5 for ; Tue, 25 Jun 2013 06:07:38 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5PD7bG9025912 for ; Tue, 25 Jun 2013 09:07:37 -0400 Date: Tue, 25 Jun 2013 09:07:37 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1740209320.7575733.1372165657385.JavaMail.root@redhat.com> In-Reply-To: <1569718901.7565281.1372165326241.JavaMail.root@redhat.com> Subject: pcp updates: misc fixes MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates: misc fixes Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pcp updates: misc fixes Thread-Index: zoOuPx++tC/0ZEQDlRoRua2hGeqAKQ== X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1372165658 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Barracuda-BRTS-Status: 1 X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134927 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... Changes committed to git://oss.sgi.com/pcp/pcp.git dev build/rpm/fedora.spec | 3 build/rpm/pcp.spec.in | 3 man/man1/pmcd.1 | 14 ++ man/man1/pmclient.1 | 2 man/man1/pmdagfs2.1 | 79 +++++++++++++++ qa/654 | 4 qa/655 | 6 + src/include/builddefs.in | 2 src/libpcp/src/internal.h | 1 src/libpcp/src/secureconnect.c | 29 +++-- src/libpcp/src/secureserver.c | 4 src/pmcd/src/config.c | 9 - src/pmcd/src/pmcd.c | 10 +- src/pmdas/gfs2/GNUmakefile | 2 src/pmdas/gfs2/README | 108 +++++++++++++++++++++ src/pmdas/gluster/GNUmakefile | 37 +++++++ src/pmdas/gluster/Install | 28 +++++ src/pmdas/gluster/Remove | 25 +++++ src/pmdas/gluster/pmdagluster.python | 175 +++++++++++++++++++++++++++++++++++ src/pmdas/linux/help | 12 +- src/pmdas/linux_proc/contexts.c | 28 ++++- src/pmdas/mysql/pmdamysql.pl | 4 src/pmns/stdpmid.pcp | 1 23 files changed, 540 insertions(+), 46 deletions(-) commit 9d4e31984bcd859623bb46db670e9cef2949f545 Author: Nathan Scott Date: Tue Jun 25 22:43:45 2013 +1000 Ensure seteuid/setegid return code/errno is checked and errors recorded commit 8a831a484376fcb830ad9608c3e51ee2049e8b03 Author: Nathan Scott Date: Tue Jun 25 22:35:28 2013 +1000 Work-in-progress commit for the initial gluster PMDA code Not yet complete, nor tested (so not enabled in the build), but need to get it out there to begin code-sharing. This initial version will use XML output from the gluster command line tool, suggested by the gluster development folk. commit 863a11c20e75464ca9d40ae1cd75790badc5b1dd Author: Nathan Scott Date: Tue Jun 25 22:32:21 2013 +1000 Reserve a domain number for the gluster filesystem PMDA commit 97c513d10dc43a1eda1c9ced63edc45e7d1e92eb Author: Nathan Scott Date: Tue Jun 25 22:31:55 2013 +1000 Remove experimental tag on pmcd identity ACLs once more for QA testing commit 8ed1b01184524561b28a679cc7500ebaa906f468 Author: Nathan Scott Date: Tue Jun 25 22:31:03 2013 +1000 Do not make assumptions in PMDA script naming in domain# checker commit f00da99eb911117eb622c5509da76ee6dc3c0c93 Author: Nathan Scott Date: Tue Jun 25 22:29:52 2013 +1000 Remove an unused header macro from libpcp internal header commit 5ecf60b8a2931e55de615dfbca8bc146a70e0d4f Author: Nathan Scott Date: Tue Jun 25 22:29:05 2013 +1000 Add option to pmcd allowing manual configuration override commit 7ad8aefe577b52fbfb184bbc3138300eb90fcac9 Author: Nathan Scott Date: Tue Jun 25 22:16:34 2013 +1000 Fixes and improved diagnostics in SASL callbacks/protocol code Fix password attribute lookup logic, increase diagnostics there. Diagnostics now report SASL callback identifiers in hex for ease of matching up to header files. commit 1d57f5b86b4e99816dad4fd5aaa1607c4f11e3c7 Author: Nathan Scott Date: Tue Jun 25 08:52:02 2013 +1000 Builds for older versions of python have a python-ctypes rpm dependency commit eca418c50f36c5d955c07c9e756173c3b151b64f Author: Nathan Scott Date: Tue Jun 25 07:40:09 2013 +1000 Fix couple of typos in Linux kernel PMDA help text commit bd1a73c200550dbf7af5b177edaf6ee4c1ec908d Author: Chandana De Silva Date: Mon Jun 24 08:43:27 2013 +1000 Correct units and type for mysql (active) connection count metric commit 29b57a6bb49613656bfe80b28a2810ad9718a2c3 Author: Nathan Scott Date: Fri Jun 21 11:27:01 2013 +1000 Fix repeated occurrence of "the" on pmclient man page commit c8a3c39234e86eb3891add015cc22e8ff2f30b5e Author: Paul Evans Date: Thu Jun 20 19:39:27 2013 +0100 pmdagfs2: Addition of documentation and manpage entry Created a manpage entry for the GFS2 PMDA, following the standard template that is used by other PMDA's. The usual sections are included on how to install, remove etc. with the addition of a section mentioning the requirement for a clustered setup for certain metrics to be able to provide metric data. Updated the commenting in qa/654 to explain better the expected setup for the test to be run and to make clear that the test does not query metrics which require a clustered environment. Added extra information about for qa/655 with regards to a test setup and provided information along with a link to fabbione's cbox (cluster in a box), providing an easy route to setting up the required test environment though a virtualised two node cluster using KVM. Cbox is available at https://github.com/fabbione/cbox. Created README to give an overview of the PMDA, it's requirements, how to install, remove along with some basic troubleshooting ideas. Have also touched upon how to go about using pmstore with regards to the configurable metrics. Slight tweak in GNUmakefile to guard against the deletion of the README file when issuing "make clean". From fche@redhat.com Tue Jun 25 09:31:40 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: * X-Spam-Status: No, score=1.7 required=5.0 tests=FUZZY_CREDIT autolearn=no version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id F40357F37 for ; Tue, 25 Jun 2013 09:31:39 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id C566F8F8049 for ; Tue, 25 Jun 2013 07:31:36 -0700 (PDT) X-ASG-Debug-ID: 1372170695-04bdf0233f896710001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id LSCVnETdr5ujpY83 for ; Tue, 25 Jun 2013 07:31:36 -0700 (PDT) X-Barracuda-Envelope-From: fche@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5PEVZPD001192 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 25 Jun 2013 10:31:35 -0400 Received: from fche.csb (vpn-62-51.rdu2.redhat.com [10.10.62.51]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5PEVZRc032495; Tue, 25 Jun 2013 10:31:35 -0400 Received: by fche.csb (Postfix, from userid 2569) id B743D58151; Tue, 25 Jun 2013 10:31:34 -0400 (EDT) To: Nathan Scott Cc: Dave Brolley , pcp@oss.sgi.com Subject: Re: Unix Domain Sockets References: <51AD5434.9090200@redhat.com> <577035819.6633537.1372068253266.JavaMail.root@redhat.com> X-ASG-Orig-Subj: Re: Unix Domain Sockets From: fche@redhat.com (Frank Ch. Eigler) Date: Tue, 25 Jun 2013 10:31:34 -0400 In-Reply-To: <577035819.6633537.1372068253266.JavaMail.root@redhat.com> (Nathan Scott's message of "Mon, 24 Jun 2013 06:04:13 -0400 (EDT)") Message-ID: User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1372170695 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 Nathan Scott writes: > [...] > secureconnect.c > - some Dave-style comments > - __pmSetSockOpt - there's no SO_PASSCRED on Win32/Win64 - sneak it into > the existing #ifdef there for SO_EXCLUSIVEADDRUSE perhaps? > [...] Is there a reason to use SO_PASSCRED vice SO_PEERCRED? The latter seems simpler. - FChE From fche@redhat.com Tue Jun 25 09:35:50 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 36C7D7F37 for ; Tue, 25 Jun 2013 09:35:50 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id D37A6AC008 for ; Tue, 25 Jun 2013 07:35:46 -0700 (PDT) X-ASG-Debug-ID: 1372170946-04bdf0233c896c50001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id aqpxo86HovnOwwtS for ; Tue, 25 Jun 2013 07:35:46 -0700 (PDT) X-Barracuda-Envelope-From: fche@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5PEZg0A007242 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 25 Jun 2013 10:35:43 -0400 Received: from fche.csb (vpn-62-51.rdu2.redhat.com [10.10.62.51]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5PEZgol002082; Tue, 25 Jun 2013 10:35:42 -0400 Received: by fche.csb (Postfix, from userid 2569) id 8BE7658151; Tue, 25 Jun 2013 10:35:41 -0400 (EDT) To: Ken McDonell Cc: pcp@oss.sgi.com Subject: Re: pmlogger_merge failing on Centos 6.4 References: <51C79DC2.8090606@desilva.id.au> <2106903857.6445515.1372040111175.JavaMail.root@redhat.com> <51C7C3DA.1000508@desilva.id.au> <51C7C6D1.5040105@desilva.id.au> <51C7C8BE.4080903@internode.on.net> X-ASG-Orig-Subj: Re: pmlogger_merge failing on Centos 6.4 From: fche@redhat.com (Frank Ch. Eigler) Date: Tue, 25 Jun 2013 10:35:41 -0400 In-Reply-To: <51C7C8BE.4080903@internode.on.net> (Ken McDonell's message of "Mon, 24 Jun 2013 14:19:10 +1000") Message-ID: User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1372170946 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 Ken McDonell writes: > [...] >> I should mention that we are logging ~ 240 metrics at 20 second intervals. > > OK, I'll look at the memory footprint also on Wed ... this seems > excessive, _unless_ the proc metrics are being logged also (big indom, > changes every fetch, huge meta data file and we load that all into > memory at the archive open time). The changing metadata alone is occupying on the order of gigabytes? Or are we loading into memory the whole archives too? - FChE From brolley@redhat.com Tue Jun 25 15:28:28 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id E8A247F37 for ; Tue, 25 Jun 2013 15:28:28 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id ACCFC304032 for ; Tue, 25 Jun 2013 13:28:28 -0700 (PDT) X-ASG-Debug-ID: 1372192103-04bdf0233c8ad010001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id pSc2YkSHY6ZBNTQd for ; Tue, 25 Jun 2013 13:28:24 -0700 (PDT) X-Barracuda-Envelope-From: brolley@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5PKSNlN009772 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 25 Jun 2013 16:28:23 -0400 Received: from [10.10.56.148] (vpn-56-148.rdu2.redhat.com [10.10.56.148]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5PKSMYF032180; Tue, 25 Jun 2013 16:28:22 -0400 Message-ID: <51C9FD66.1040500@redhat.com> Date: Tue, 25 Jun 2013 16:28:22 -0400 From: Dave Brolley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Nathan Scott CC: PCP Subject: Re: [pcp] Unix Domain Sockets References: <51AD5434.9090200@redhat.com> <577035819.6633537.1372068253266.JavaMail.root@redhat.com> X-ASG-Orig-Subj: Re: [pcp] Unix Domain Sockets In-Reply-To: <577035819.6633537.1372068253266.JavaMail.root@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1372192103 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 Code changes for this review have been pushed to the brolley/dev branch of the pcpfans repository. qa testing is underway. Comments below ... On 06/24/2013 06:04 AM, Nathan Scott wrote: > QA > - Some QA tests now getting up to 10 alternate output forms > (maintenance of alternate competing version becoming a problem) > - for the tests which are exercising access control on remote > hosts, theres no reason (AFAICT) that we need to make sure > the unix domain socket log lines are in the output (there's > nothing being tested there) > - thats not the case for IPv6 so while we did need to add the > conditional output for that, IMO we don't need to add it in > the case of unix sockets. > - Thoughts? (so, I think we should filter out the unix-domain > lines and stick with the existing .out files for most/all of > these tests). I do agree that the management of possible outputs is be coming cumbersome, especially when the closure of multiple configuration elements is at play. There are no specific tests for the use of unix domain sockets (yet), so the unix domain line in the pmcd request ports table is now filtered in the existing tests, as suggested. > auxconnect.c > - __pmInitSocket > - API change - OK, cos its an internal.h routine only? Hope that's ok. > - need the SO_LINGER on unix domain sockets? if not, we could > short-circuit the routine and have just the one #ifdef ... > #if defined(SOCKADDR_UN) > if (family == AF_UNIX) > return fd; > #endif > ... and one less syscall. *shrug* My understanding of SO_LINGER doesn't make it more or less applicable to a unix domain socket as opposed to a tcp one. As a compromise, I changed the code to set the SO_LINGER option first allowing your suggested short-circuit of the rest of the function. > - __pmPMCDLocalSocketDefault() > - no need for the '= ""' in pmcd_socket, statics init'd to zero ok > - snprintf needs to pass sizeof(pmcd_socket) - 1 to ensure null > termination (two spots) Not according to my reading of the man page. It says that at most 'size' bytes will be written which includes the terminating nul and that the terminating nul is always written unless 'size' is zero. These are the reasons why I always use snprintf() as opposed to strncpy() which only writes the terminating nul if there is room. > - inconsistent comment style with surrounding code > > - __pmCreateUnixSocket() > - inconsistent comment style with surrounding code ok > auxserver.c > - localSocket{Path,Fd} don't need to be conditional AFAICT (?) > (simplifies other code later - less #ifdef sprawl, more readable). OK. I didn't know what the policy was for unused code, in the sense that these statics will never be modified and the tests involving them will always go the same way on platforms on which unix domain sockets are not supported. Some projects might prefer that these objects and the associated code not exist in those builds. I actually prefer it the way you want, so consider this done. > - OpenRequestSocket() > - we make an immediate decision based on value *family but this > is not guaranteed to be initialised -> see 3rd callsite in > OpenRequestPorts() Good catch! *family is now initialized to AF_UNSPEC at the 3rd call site making it now initialized at all call sites. I've added a (non-Dave-style) comment to this effect in the function header comment. > - Dave-style comments, inconsistent with surrounding code > > - __pmServerCloseRequestPorts() > - new code doesn't need to be #ifdef'd > - no need for assignment to "i" in new code? ok > - second diagnostic should probably also report gid/egid given > expected filesystem permissions on PCP_RUN_DIR? Actually the second diagnostics was something I added in order to help me debug the problem of not being unable to unlink the socket path in the first place. I had intended it to be temporary. If you think it would be useful, then yes, the additional info should also be reported. > - make into a single call to __pmNotifyErr, double-equals isn't > really the common convention - just use single-equals I reckon. > > - __pmServerAddNewClients > - new code here doesn't need to be #ifdef'd > > - __pmServerDumpRequestPorts > - __pmServerRequestPortString > - new code in both doesn't need to be #ifdef'd OK. Done > check-statics > - if we don't remove the conditional check on new statics above, build > will fail in this script I think (wont be able to find global static > variables that we're now adding). Well, I had them prefixed with '?' which makes them optional, but that's a non-issue now. > config.c > - release number in comment is off-by-one now cos I snuck a release in > last week ok > connect.c > - pmcd_socket can be declared unconditionally? check-statics will want > that IIRC. > - can avoid yet another global by merging new load_pmcd_local_socket() > into load_pmcd_ports (rename to load_pmcd_socket_config or something > along those lines?) Actually, it turns out that these are all unnecessary remnants from a time before __pmPMCDLocalSocketDefault(). They have been removed. > - __pmConnectPMCD() > - I *think* for the case where we set "sts = -2" in new code, we'll > fall into a bad state in the first diagnostic after "if (sts == -1)" > (which does the usual inet/ipv6 socket connections)? at very least, > wont it print "... port= failed: ..."? (ie miss printing the port) This all looks ok to me. -2 is intended to indicate "no more connection attempts" after failing to connect to the unix domain socket (i.e. unix:[//path] was specified). In this case, we want to bypass the normal tcp connection attempt(s) and go straight to the diagnostic in question. Not printing the port(s) is intentional, since unix domain sockets do not have ports. > secureconnect.c > - some Dave-style comments > - __pmSetSockOpt - there's no SO_PASSCRED on Win32/Win64 - sneak it into > the existing #ifdef there for SO_EXCLUSIVEADDRUSE perhaps? OK > spec.c > - need a new QA test along the lines of test 720 which invokes the host > parser with unix socket addresses with valgrind, checks and dumps 'em Coming soon to a test suite near you. > - doesn't feel right to have the parser logic have #ifdef conditional goo > all over it like this - elsewhere in pmNewContext we should be dealing > with lack of support (ie lower down) anyway, so we should not have to > do it here too. I think. Right? Simplifies life here - no need for > the additional parseProtocolSpec argument, just parse it & pass it on. > - also, use PCP_ATTR_UNIXSOCK for unix: prefix, add in a PCP_ATTR_LOCAL, > and return *attribute from parseProtocolSpec. Then, you wont need to > do the check-to-see-if-value-non-null-then-strcmp-it dance back in the > caller - just use the return code. You also wont need the new isLocal > and isUnix variables in the caller, so code should become simpler. > - a sprinkling of Dave-style comments Much better, thanks. I had thought that PCP_ATTR_PROTOCOL was for all of the prefixes. > pmcd.c > - sockpath does not need to be conditional > - so - just unconditionally accept the command line arg (-s) > - then, either make __pmServerSetLocalSocket return an error code if not > supported, or better still make __pmServerOpenRequestPorts report and > fail later on. > - that new __pmPMCDLocalSocketDefault call here feels wrong too - could > this not be hidden away inside __pmServerSetLocalSocket, removing need > for pmcd and other servers to have to deal with setting defaults? Use > __pmProgname in there, if it needs different xxx.socket name for pmcd/ > pmproxy/pmwebd? One less symbol/function in libpcp too then, and one > less interface exposed by impl.h that we need to keep back-compatible. Done, done, done and ..... done Thanks again for the review, Dave From nscott@redhat.com Tue Jun 25 19:45:51 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: * X-Spam-Status: No, score=1.7 required=5.0 tests=FUZZY_CREDIT autolearn=no version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id E98CD7F37 for ; Tue, 25 Jun 2013 19:45:51 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id C9B17304043 for ; Tue, 25 Jun 2013 17:45:48 -0700 (PDT) X-ASG-Debug-ID: 1372207544-04bdf02b8e693830001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id D2SmBeaxHDO8lLBu for ; Tue, 25 Jun 2013 17:45:44 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5Q0jhRn020389; Tue, 25 Jun 2013 20:45:43 -0400 Date: Tue, 25 Jun 2013 20:45:43 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: "Frank Ch. Eigler" , Dave Brolley Cc: pcp@oss.sgi.com Message-ID: <1974351745.8041270.1372207543662.JavaMail.root@redhat.com> In-Reply-To: References: <51AD5434.9090200@redhat.com> <577035819.6633537.1372068253266.JavaMail.root@redhat.com> Subject: Re: Unix Domain Sockets MIME-Version: 1.0 X-ASG-Orig-Subj: Re: Unix Domain Sockets Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: Unix Domain Sockets Thread-Index: TXCZvFWRQHUAxjIIon97o2V1FAqBpw== X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1372207544 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.55 X-Barracuda-Spam-Status: No, SCORE=0.55 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH, FUZZY_CREDIT, FUZZY_CREDIT_2, THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134973 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... 0.00 FUZZY_CREDIT BODY: Attempt to obfuscate words in spam 0.52 FUZZY_CREDIT_2 Attempt to obfuscate words in spam 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain ----- Original Message ----- > Nathan Scott writes: > > > [...] > > secureconnect.c > > - some Dave-style comments > > - __pmSetSockOpt - there's no SO_PASSCRED on Win32/Win64 - sneak it into > > the existing #ifdef there for SO_EXCLUSIVEADDRUSE perhaps? > > [...] > > Is there a reason to use SO_PASSCRED vice SO_PEERCRED? The latter seems > simpler. > No good reason - I've simply never come across it before! (its not mentioned on the unix(7) man page). It sure does look a cleaner API. BTW Dave, looks like these things will need "proper" configure tests after all - there is no SO_PASSCRED on Mac OS X, but there does seem to be a "LOCAL_PEERCRED"... "The effective credentials (i.e., the user ID and group list) of a peer on a SOCK_STREAM socket may be obtained using the LOCAL_PEERCRED socket option. This may be used by a server to obtain and verify the creden- tials of its client, and vice versa by the client to verify the credentials of the server. These will arrive in the form of a filled in struct xucred (defined in sys/ucred.h)." So, uses a differently named structure too (with different fields). Fun! I guess a platform-independent struct type will be needed bit like was done for the socklen_t type (__pmSockLen). cheers. -- Nathan From nscott@redhat.com Tue Jun 25 20:23:28 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 79FA57F37 for ; Tue, 25 Jun 2013 20:23:28 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id 5A3078F8049 for ; Tue, 25 Jun 2013 18:23:25 -0700 (PDT) X-ASG-Debug-ID: 1372209800-04cbb0468f8a0410001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id sOZfFBp1I7oCOX58 for ; Tue, 25 Jun 2013 18:23:20 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5Q1NJZb026519; Tue, 25 Jun 2013 21:23:19 -0400 Date: Tue, 25 Jun 2013 21:23:19 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Dave Brolley Cc: PCP Message-ID: <268641663.8046690.1372209799880.JavaMail.root@redhat.com> In-Reply-To: <51C9FD66.1040500@redhat.com> References: <51AD5434.9090200@redhat.com> <577035819.6633537.1372068253266.JavaMail.root@redhat.com> <51C9FD66.1040500@redhat.com> Subject: Re: [pcp] Unix Domain Sockets MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] Unix Domain Sockets Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: Unix Domain Sockets Thread-Index: meR0tFEdzJUBSwfeC4Jz5mDXRrvp5w== X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1372209800 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.03 X-Barracuda-Spam-Status: No, SCORE=0.03 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH, THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.134977 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain ----- Original Message ----- > Code changes for this review have been pushed to the brolley/dev branch > of the pcpfans repository. qa testing is underway. Good stuff. > > - API change - OK, cos its an internal.h routine only? > Hope that's ok. *nod*, fine by me. > My understanding of SO_LINGER doesn't make it more or less applicable to > a unix domain socket as opposed to a tcp one. As a compromise, I changed > the code to set the SO_LINGER option first allowing your suggested > short-circuit of the rest of the function. Either way seems fine, if we need it we need it. > Not according to my reading of the man page. It says that at most 'size' Ah, but you didn't check this secret "man" page: ;) http://msdn.microsoft.com/en-us/library/2ts7cx93%28v=vs.110%29.aspx (which is the snprintf we end up in on Win32) > > - localSocket{Path,Fd} don't need to be conditional AFAICT (?) > > (simplifies other code later - less #ifdef sprawl, more readable). > OK. I didn't know what the policy was for unused code, in the sense that > these statics will never be modified and the tests involving them will > always go the same way on platforms on which unix domain sockets are not > supported. Some projects might prefer that these objects and the > associated code not exist in those builds. I actually prefer it the way > you want, so consider this done. When in doubt I tend to apply the kernel rule of thumb, where fewer ifdefs is usually best. > making it now initialized at all call sites. I've added a > (non-Dave-style) comment to this effect ... Hah! > > - second diagnostic should probably also report gid/egid given > > expected filesystem permissions on PCP_RUN_DIR? > Actually the second diagnostics was something I added in order to help > me debug the problem of not being unable to unlink the socket path in > the first place. I had intended it to be temporary. If you think it > would be useful, then yes, the additional info should also be reported. Your call, I could go either way. Kenj (aka Mr Diagnostics ;) will be suggesting you keeping it I suspect - since you needed it once, likely someone else will need it again someday. > Well, I had them prefixed with '?' which makes them optional, but that's > a non-issue now. Ah, didn't know that - thanks for the tip. cheers. -- Nathan From nscott@redhat.com Wed Jun 26 05:17:48 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 582667F37 for ; Wed, 26 Jun 2013 05:17:48 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id 46ACF8F804C for ; Wed, 26 Jun 2013 03:17:48 -0700 (PDT) X-ASG-Debug-ID: 1372241863-04cbb0468f8bcbf0001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id KnmBvrqopC58IdJE for ; Wed, 26 Jun 2013 03:17:43 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5QAHh4e006700 for ; Wed, 26 Jun 2013 06:17:43 -0400 Date: Wed, 26 Jun 2013 06:17:43 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1364493047.8255046.1372241863303.JavaMail.root@redhat.com> In-Reply-To: <1264517846.8253154.1372241776133.JavaMail.root@redhat.com> Subject: pcp updates: qa, gcc warnings fixes MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates: qa, gcc warnings fixes Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pcp updates: qa, gcc warnings fixes Thread-Index: 3URFFW+KRveP9aeuaB0yYDDkIWaxJg== X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1372241863 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.135008 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... Changes committed to git://oss.sgi.com/pcp/pcp.git dev qa/547 | 35 ++ qa/547.out | 17 qa/550 | 49 ++ qa/550.out | 7 qa/551 | 71 ++++ qa/551.out | 8 qa/722 | 9 qa/722.out | 21 - qa/GNUmakefile | 2 qa/group | 11 qa/secure/.gitignore | 3 qa/secure/GNUmakefile | 25 + qa/secure/crash-cred | 15 qa/secure/crash-fetch | 16 qa/secure/crash-instancereq | 18 + qa/secure/crash-namereq-child | 19 + qa/secure/crash-namereq-traverse | 19 + qa/secure/crash-pmns-names | 16 qa/secure/crash-profile | 22 + qa/secure/crash-profile-instances | 22 + qa/secure/hang-pmcd | 26 + qa/secure/leak-fetch | 19 + qa/secure/leak-getpdu | 18 + qa/secure/pcppdu.python | 650 ++++++++++++++++++++++++++++++++++++++ qa/secure/query-proc | 27 + src/pmdas/gfs2/lock_time.c | 3 26 files changed, 1129 insertions(+), 19 deletions(-) commit eaeaae3ff0d7525af50efbb4c683abcf7a77aac6 Author: Nathan Scott Date: Wed Jun 26 20:15:24 2013 +1000 Add in automated checkers for all the past security flaws Had permission to merge these tests many months ago, but no time nor pressing need to merge back given the other testing that was done (esp valgrind-based pducrash and so on). It is handy to do now though to sync up with other QA folks here as well as ensure ongoing coverage in dev branches. commit acc4adecad045b450d128a21dd2b48a46c358c8f Author: Nathan Scott Date: Wed Jun 26 17:18:22 2013 +1000 Fix qa/722 in terms of checking install pmatop, and filtered .out commit 7baee5b1473bde018cd6c16f1f99eb596644d0d6 Author: Nathan Scott Date: Wed Jun 26 14:43:41 2013 +1000 Updates to the pcpqa sanity group for faster smoke tests commit 9e90d5fa456f0ab433a4a625d76cf3f569c3f743 Merge: 9d4e319 73ec5e0 Author: Nathan Scott Date: Tue Jun 25 23:08:12 2013 +1000 Merge branch 'dev' of git://github.com/pauljevans/pcp into dev commit 73ec5e046563b9eeed5dc16cbbf959168bc06202 Author: Paul Evans Date: Tue Jun 25 13:57:38 2013 +0100 pmdagfs2: gcc -Wmaybe-uninitialized compilation warnings fix Made changes in lock_time.c to ensure that glockA and glockB are initialized as zero prior to having values from the hash-map containing glocks for the given GFS2 filesystem assigned to them. This silences the gcc warnings of potential uninitialized variables in the glock comparison function during compilation of code. From minnus@buffalo.edu Wed Jun 26 14:17:05 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 727817F54 for ; Wed, 26 Jun 2013 14:17:05 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id 1CEF5AC003 for ; Wed, 26 Jun 2013 12:17:01 -0700 (PDT) X-ASG-Debug-ID: 1372274217-04bdf0233c8fdf30001-S8gJnT Received: from localmailB.acsu.buffalo.edu (localmailb.acsu.buffalo.edu [128.205.5.200]) by cuda.sgi.com with ESMTP id ymzstH4UIbMAWllw for ; Wed, 26 Jun 2013 12:16:57 -0700 (PDT) X-Barracuda-Envelope-From: minnus@buffalo.edu X-Barracuda-Apparent-Source-IP: 128.205.5.200 Received: from localmailB.acsu.buffalo.edu (localhost [127.0.0.1]) by localhost (Postfix) with SMTP id D7F2255D for ; Wed, 26 Jun 2013 15:16:56 -0400 (EDT) Received: from localmailB.acsu.buffalo.edu (localhost [127.0.0.1]) by localmailB.acsu.buffalo.edu (Postfix) with ESMTP id 3C7DD539 for ; Wed, 26 Jun 2013 15:16:55 -0400 (EDT) Received: from smtp3.acsu.buffalo.edu (smtp3.acsu.buffalo.edu [128.205.5.226]) by localmailB.acsu.buffalo.edu (Prefixe) with ESMTP id 0DB6FFB for ; Wed, 26 Jun 2013 15:16:54 -0400 (EDT) Received: from gilmour.ccr.buffalo.edu (gilmour.ccr.buffalo.edu [128.205.40.13]) (Authenticated sender: minnus@buffalo.edu) by smtp3.acsu.buffalo.edu (Postfix) with ESMTPSA id EC35B556C3 for ; Wed, 26 Jun 2013 15:16:54 -0400 (EDT) Message-ID: <51CB3E26.5060502@buffalo.edu> Date: Wed, 26 Jun 2013 15:16:54 -0400 From: Martins Innus User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: PCP Subject: new pmdas and some questions Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-ASG-Orig-Subj: new pmdas and some questions Content-Transfer-Encoding: 7bit X-PM-EL-Spam-Prob: : 8% X-Barracuda-Connect: localmailb.acsu.buffalo.edu[128.205.5.200] X-Barracuda-Start-Time: 1372274217 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.135044 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Hello, We are in the process of writing a few pmdas and assuming all goes well would make them publicly available. I have a few questions on the best way of going about this. We have written and are currently testing pmdas for the Panasas file system ( https://www.panasas.com/ ) and for NVML ( https://developer.nvidia.com/nvidia-management-library-nvml ). Can we reserve PMID's for these so we don't conflict with anything else? When complete, would we host these ourselves for download or is there interest in incorporating them into pcp? I ask because for instance we use the Infiniband PMDA which is not distributed by default with PCP anymore. Is the expectation that niche pmdas like this would live outside the main tree? They both require 3rd party APIs in order to build/test/run. Thanks Martins From kenj@internode.on.net Wed Jun 26 16:09:59 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 7D4187F58 for ; Wed, 26 Jun 2013 16:09:59 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id 6E28A8F8033 for ; Wed, 26 Jun 2013 14:09:55 -0700 (PDT) X-ASG-Debug-ID: 1372280990-04cbb046918ea070001-S8gJnT Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id UQ9NFyGfgbbbTxWp for ; Wed, 26 Jun 2013 14:09:51 -0700 (PDT) X-Barracuda-Envelope-From: kenj@internode.on.net X-Barracuda-Apparent-Source-IP: 150.101.137.141 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAEZYy1F20bGI/2dsb2JhbAANToM6v0yBGoMXAQEBAwE4RgsLGAklDwJGEwgBAYgEEqdKki0Ej1IWg00Dk3OYOg Received: from ppp118-209-177-136.lns20.mel6.internode.on.net (HELO [192.168.1.101]) ([118.209.177.136]) by ipmail04.adl6.internode.on.net with ESMTP; 27 Jun 2013 06:39:40 +0930 Message-ID: <51CB5894.70604@internode.on.net> Date: Thu, 27 Jun 2013 07:09:40 +1000 From: Ken McDonell User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: pcp@oss.sgi.com Subject: Re: [pcp] new pmdas and some questions References: <51CB3E26.5060502@buffalo.edu> X-ASG-Orig-Subj: Re: [pcp] new pmdas and some questions In-Reply-To: <51CB3E26.5060502@buffalo.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Barracuda-Connect: ipmail04.adl6.internode.on.net[150.101.137.141] X-Barracuda-Start-Time: 1372280990 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.135052 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- On 27/06/13 05:16, Martins Innus wrote: > Hello, > > We are in the process of writing a few pmdas and assuming all goes > well would make them publicly available. ... That would be both welcome and encouraged. > I have a few questions on the > best way of going about this. We have written and are currently testing > pmdas for the Panasas file system ( https://www.panasas.com/ ) and for > NVML ( https://developer.nvidia.com/nvidia-management-library-nvml ). > Can we reserve PMID's for these so we don't conflict with anything else? Best to get the PMDA domain number assigned (which gives you a range of PMIDs and instance domain IDs to be managed as you see fit within your PMDA). I have tentatively assigned PANASAS 118 NVML 119 in my tree ... pending your confirmation these will flow up stream to the official PCP tree in due course. > When complete, would we host these ourselves for download or is > there interest in incorporating them into pcp? I ask because for > instance we use the Infiniband PMDA which is not distributed by default > with PCP anymore. Is the expectation that niche pmdas like this would > live outside the main tree? They both require 3rd party APIs in order > to build/test/run. This is a per-PMDA decision. In the tree means you can leverage the existing packaging framework and QA infrastructure, and you're more likely to receive code review feedback. We can accommodate conditional builds for PMDAs based on the presence of 3rd party artifacts where such a dependency exists. But some PMDAs are not of general interest and remain outside the tree. Independent of that decision, I would strongly encourage you to solicit feedback from the list at the point where you map the available metrics on to the PCP namespace (PMNS) and decide on the metric and instance domain choices ... this is historically the place where most PMDA implementation mistakes are made. After this the PMDA APIs have been very stable for a long time and there is plenty of example code to use as a template. Good luck. From nscott@redhat.com Wed Jun 26 17:33:13 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 486E07F5E for ; Wed, 26 Jun 2013 17:33:13 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id 1D17A8F8037 for ; Wed, 26 Jun 2013 15:33:09 -0700 (PDT) X-ASG-Debug-ID: 1372285987-04bdf0233f909f70001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id agwrJ8CAjviEOhYk for ; Wed, 26 Jun 2013 15:33:07 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5QMWxgq014214; Wed, 26 Jun 2013 18:32:59 -0400 Date: Wed, 26 Jun 2013 18:32:59 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Ken McDonell , Martins Innus Cc: pcp@oss.sgi.com Message-ID: <1931283170.8723707.1372285979276.JavaMail.root@redhat.com> In-Reply-To: <51CB5894.70604@internode.on.net> References: <51CB3E26.5060502@buffalo.edu> <51CB5894.70604@internode.on.net> Subject: Re: [pcp] new pmdas and some questions MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] new pmdas and some questions Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: new pmdas and some questions Thread-Index: TYwV67Uayl8xFT2TqGXN0jLBZG4iVQ== X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1372285987 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.135058 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... Hi guys, ----- Original Message ----- > On 27/06/13 05:16, Martins Innus wrote: > > Hello, > > > > We are in the process of writing a few pmdas and assuming all goes > > well would make them publicly available. ... > > That would be both welcome and encouraged. > > > I have a few questions on the > > best way of going about this. We have written and are currently testing > > pmdas for the Panasas file system ( https://www.panasas.com/ ) and for > > NVML ( https://developer.nvidia.com/nvidia-management-library-nvml ). > > Can we reserve PMID's for these so we don't conflict with anything else? > > Best to get the PMDA domain number assigned (which gives you a range of > PMIDs and instance domain IDs to be managed as you see fit within your > PMDA). > > I have tentatively assigned > PANASAS 118 > NVML 119 > in my tree ... pending your confirmation these will flow up stream to > the official PCP tree in due course. Gluster has slipped in at 118 earlier this week, so please shuffle these assignments down by one. > > When complete, would we host these ourselves for download or is > > there interest in incorporating them into pcp? I ask because for > > instance we use the Infiniband PMDA which is not distributed by default > > with PCP anymore. Is the expectation that niche pmdas like this would > > live outside the main tree? They both require 3rd party APIs in order > > to build/test/run. > > This is a per-PMDA decision. > > In the tree means you can leverage the existing packaging framework and > QA infrastructure, and you're more likely to receive code review > feedback. We can accommodate conditional builds for PMDAs based on the > presence of 3rd party artifacts where such a dependency exists. > Martins, see point 2 here as well: http://oss.sgi.com/pipermail/pcp/2013-April/003139.html In hind-sight, general feeling is that splitting the Infiniband PMDA out on its own was a mistake, and its likely it will be brought back into the main tree at some point soon. Just mirroring Kens words, if the PMDA is to be released under a license that is compatible, and it is a generally-useful PMDA (as these two are), I would definitely recommend merging it into the main PCP git tree. cheers. -- Nathan From nscott@redhat.com Wed Jun 26 18:27:14 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 7B5497F60 for ; Wed, 26 Jun 2013 18:27:14 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id 5E3FF8F8035 for ; Wed, 26 Jun 2013 16:27:14 -0700 (PDT) X-ASG-Debug-ID: 1372289230-04cb6c2a42654400001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id ZtLGDGUF37GuoQ7x for ; Wed, 26 Jun 2013 16:27:10 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5QNR9ld022874 for ; Wed, 26 Jun 2013 19:27:09 -0400 Date: Wed, 26 Jun 2013 19:27:09 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: PCP Message-ID: <723004313.8736624.1372289229866.JavaMail.root@redhat.com> Subject: pcp updates: qa, webapi MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates: qa, webapi Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pcp updates: qa, webapi Thread-Index: pLx8OI37hrL4zBCgpsMTSGU9qwaB2g== X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1372289230 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.135062 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... Changes committed to git://oss.sgi.com/pcp/pcp.git dev man/man3/pmwebapi.3 | 7 + qa/552 | 29 ++++ qa/552.out | 5 qa/group | 1 src/libpcp/src/context.c | 3 src/pmdas/systemd/systemd.c | 2 src/pmwebapi/TODO | 6 - src/pmwebapi/jsdemos/blinkenlights/blinkenlights.js | 20 ++- src/pmwebapi/jsdemos/blinkenlights/index.html | 18 ++- src/pmwebapi/pmwebapi.c | 120 ++++++++++++++++++-- 10 files changed, 190 insertions(+), 21 deletions(-) commit d69b9694d4b8cb7a10907e7a1da2ca5ea702ff1e Merge: 98dfd5d afe1d0f Author: Nathan Scott Date: Thu Jun 27 09:24:54 2013 +1000 Merge branch 'fche/dev' of ../pcpfans into dev commit 98dfd5de3e471d1090a3f9eb8c15915f7ffacd00 Author: Nathan Scott Date: Thu Jun 27 08:58:57 2013 +1000 Resolve issue where tools can get sigsegv from command line Looks like a long-standing issue with allowing an invalid (empty) host list to be propogated too far in pmNewContext, which eventually looks inside the null pmHostSpec pointer. commit afe1d0f8e98e1e0354a896e63781ef5220c40dd0 Author: Frank Ch. Eigler Date: Sun Jun 23 17:54:28 2013 -0400 pmwebapi blinkenlights: support more general hostspecs. Add timestamp. commit 86d7e9e7a534dc1a0c493b062bc6e79353abe519 Author: Frank Ch. Eigler Date: Sun Jun 23 17:47:34 2013 -0400 pmwebapi: support more general pcp hostname specs, and HTTP Basic authentication When a web client uses a hostspec string to create a new context, and if that string includes PCP_ATTR_USERNAME/PASSWORD information, make the new webcontext require use of matching HTTP Basic authentication for it. Renamed the /pmapi/context?hostname= key to ?hostspec= to emphasize the generality. (The hostname= one is supported for backward compatibility.) commit 8a2d4dc37976c1323a98cb1dde48a91edf959507 Author: Frank Ch. Eigler Date: Sat Jun 22 09:42:05 2013 -0400 systemd pmda: correct .maxmem metric to PM_SPACE_BYTE From kenj@internode.on.net Wed Jun 26 20:43:30 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 93E107F66 for ; Wed, 26 Jun 2013 20:43:30 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay3.corp.sgi.com (Postfix) with ESMTP id 2161EAC004 for ; Wed, 26 Jun 2013 18:43:29 -0700 (PDT) X-ASG-Debug-ID: 1372297407-04cb6c2a4265ae80001-S8gJnT Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id vn6EQLLkE6XyxjAV for ; Wed, 26 Jun 2013 18:43:28 -0700 (PDT) X-Barracuda-Envelope-From: kenj@internode.on.net X-Barracuda-Apparent-Source-IP: 150.101.137.141 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApQBAL6Xy1F20bGI/2dsb2JhbAANTocKuRGCaoEbgxcBAQEEIxVAARALGAICBRYLAgIJAwIBAgFFBg0BBwEBr35zkTSBJo4vB4JPgRQDrC0 Received: from ppp118-209-177-136.lns20.mel6.internode.on.net (HELO [192.168.1.101]) ([118.209.177.136]) by ipmail04.adl6.internode.on.net with ESMTP; 27 Jun 2013 11:13:26 +0930 Message-ID: <51CB98BE.4000001@internode.on.net> Date: Thu, 27 Jun 2013 11:43:26 +1000 From: Ken McDonell User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Nathan Scott CC: Martins Innus , pcp@oss.sgi.com Subject: Re: [pcp] new pmdas and some questions References: <51CB3E26.5060502@buffalo.edu> <51CB5894.70604@internode.on.net> <1931283170.8723707.1372285979276.JavaMail.root@redhat.com> X-ASG-Orig-Subj: Re: [pcp] new pmdas and some questions In-Reply-To: <1931283170.8723707.1372285979276.JavaMail.root@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Barracuda-Connect: ipmail04.adl6.internode.on.net[150.101.137.141] X-Barracuda-Start-Time: 1372297407 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.135070 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- On 27/06/13 08:32, Nathan Scott wrote: > Hi guys, > ... >> I have tentatively assigned >> PANASAS 118 >> NVML 119 >> in my tree ... pending your confirmation these will flow up stream to >> the official PCP tree in due course. > > Gluster has slipped in at 118 earlier this week, so please shuffle these > assignments down by one. I've modified my change to be +1 for these domains. From minnus@buffalo.edu Thu Jun 27 08:59:14 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id BF54A7F3F for ; Thu, 27 Jun 2013 08:59:14 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay2.corp.sgi.com (Postfix) with ESMTP id ABA1330405F for ; Thu, 27 Jun 2013 06:59:11 -0700 (PDT) X-ASG-Debug-ID: 1372341547-04cbb0468f91dc70001-S8gJnT Received: from localmailA.acsu.buffalo.edu (localmaila.acsu.buffalo.edu [128.205.5.196]) by cuda.sgi.com with ESMTP id ncwMeNHFDEddoWnJ for ; Thu, 27 Jun 2013 06:59:07 -0700 (PDT) X-Barracuda-Envelope-From: minnus@buffalo.edu X-Barracuda-Apparent-Source-IP: 128.205.5.196 Received: from localmailA.acsu.buffalo.edu (localhost [127.0.0.1]) by localhost (Postfix) with SMTP id C0754AB31; Thu, 27 Jun 2013 09:59:06 -0400 (EDT) Received: from localmailA.acsu.buffalo.edu (localhost [127.0.0.1]) by localmailA.acsu.buffalo.edu (Postfix) with ESMTP id 9ACB9AB1B; Thu, 27 Jun 2013 09:59:03 -0400 (EDT) Received: from smtp1.acsu.buffalo.edu (smtp1.acsu.buffalo.edu [128.205.5.253]) by localmailA.acsu.buffalo.edu (Prefixe) with ESMTP id 72DFDAB37; Thu, 27 Jun 2013 09:59:03 -0400 (EDT) Received: from [128.205.28.161] (slash.eng.buffalo.edu [128.205.28.161]) (Authenticated sender: minnus@buffalo.edu) by smtp1.acsu.buffalo.edu (Postfix) with ESMTPSA id 6397756911; Thu, 27 Jun 2013 09:59:03 -0400 (EDT) Message-ID: <51CC4527.5000305@buffalo.edu> Date: Thu, 27 Jun 2013 09:59:03 -0400 From: Martins Innus User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Ken McDonell CC: pcp@oss.sgi.com Subject: Re: [pcp] new pmdas and some questions References: <51CB3E26.5060502@buffalo.edu> <51CB5894.70604@internode.on.net> X-ASG-Orig-Subj: Re: [pcp] new pmdas and some questions In-Reply-To: <51CB5894.70604@internode.on.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-PM-EL-Spam-Prob: : 8% X-Barracuda-Connect: localmaila.acsu.buffalo.edu[128.205.5.196] X-Barracuda-Start-Time: 1372341547 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.135120 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- On 6/26/2013 5:09 PM, Ken McDonell wrote: > On 27/06/13 05:16, Martins Innus wrote: >> Hello, >> >> We are in the process of writing a few pmdas and assuming all goes >> well would make them publicly available. ... > > That would be both welcome and encouraged. Great, we will plan on it. > > > I have a few questions on the >> best way of going about this. We have written and are currently testing >> pmdas for the Panasas file system ( https://www.panasas.com/ ) and for >> NVML ( https://developer.nvidia.com/nvidia-management-library-nvml ). >> Can we reserve PMID's for these so we don't conflict with anything else? > > Best to get the PMDA domain number assigned (which gives you a range > of PMIDs and instance domain IDs to be managed as you see fit within your > PMDA). > > I have tentatively assigned > PANASAS 118 > NVML 119 > in my tree ... pending your confirmation these will flow up stream to > the official PCP tree in due course. Thanks, I've used the +1 values as noted by Nathan. > >> When complete, would we host these ourselves for download or is >> there interest in incorporating them into pcp? I ask because for >> instance we use the Infiniband PMDA which is not distributed by default >> with PCP anymore. Is the expectation that niche pmdas like this would >> live outside the main tree? They both require 3rd party APIs in order >> to build/test/run. > > This is a per-PMDA decision. > > In the tree means you can leverage the existing packaging framework > and QA infrastructure, and you're more likely to receive code review > feedback. We can accommodate conditional builds for PMDAs based on > the presence of 3rd party artifacts where such a dependency exists. > > But some PMDAs are not of general interest and remain outside the tree. > > Independent of that decision, I would strongly encourage you to > solicit feedback from the list at the point where you map the > available metrics on to the PCP namespace (PMNS) and decide on the > metric and instance domain choices ... this is historically the place > where most PMDA implementation mistakes are made. After this the PMDA > APIs have been very stable for a long time and there is plenty of > example code to use as a template. > OK, Thanks for your help. We will post as we progress. Martins From wwwrun@oss.sgi.com Thu Jun 27 19:18:01 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=HTML_MESSAGE,NO_RELAYS autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: by oss.sgi.com (Postfix, from userid 30) id EDE687F51; Thu, 27 Jun 2013 19:18:01 -0500 (CDT) From: bugzilla-daemon@oss.sgi.com To: pcp@oss.sgi.com Subject: [Bug 978] New: pmlogrewrite does not cull indom when no metric uses the indom Date: Fri, 28 Jun 2013 00:18:01 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: pcp X-Bugzilla-Component: pcp X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: kenj@internode.on.net X-Bugzilla-Status: NEW X-Bugzilla-Priority: P5 X-Bugzilla-Assigned-To: pcp@kenj.com.au X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc classification Message-ID: Content-Type: multipart/alternative; boundary="1372378681.1aEc2.5086"; charset="us-ascii" X-Bugzilla-URL: http://oss.sgi.com/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 --1372378681.1aEc2.5086 Date: Thu, 27 Jun 2013 19:18:01 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" http://oss.sgi.com/bugzilla/show_bug.cgi?id=978 Bug ID: 978 Summary: pmlogrewrite does not cull indom when no metric uses the indom Product: pcp Version: unspecified Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 Component: pcp Assignee: pcp@kenj.com.au Reporter: kenj@internode.on.net CC: pcp@oss.sgi.com Classification: Unclassified Various config file changes like metric foo { delete } or metric foo { indom -> 123.456 } have the effect of reducing the number of references to an indom in the archive ... if the number of references goes to zero, the indom should be culled from the metadata file. This is not happening. To understand why this is a problem, consider an archive with proc.* metrics included by mistake ... this produces a huge metadata file that cannot be shrunk by pmlogrewrite, even if the proc.* metrics are all deleted. -- You are receiving this mail because: You are on the CC list for the bug. --1372378681.1aEc2.5086 Date: Thu, 27 Jun 2013 19:18:01 -0500 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"
Bug ID 978
Summary pmlogrewrite does not cull indom when no metric uses the indom
Product pcp
Version unspecified
Hardware All
OS Linux
Status NEW
Severity normal
Priority P5
Component pcp
Assignee pcp@kenj.com.au
Reporter kenj@internode.on.net
CC pcp@oss.sgi.com
Classification Unclassified 

Various config file changes like
metric foo { delete }
or
metric foo { indom -> 123.456 }
have the effect of reducing the number of references to an indom in the archive
... if the number of references goes to zero, the indom should be culled from
the metadata file.  This is not happening.

To understand why this is a problem, consider an archive with proc.* metrics
included by mistake ... this produces a huge metadata file that cannot be
shrunk by pmlogrewrite, even if the proc.* metrics are all deleted.

You are receiving this mail because:
  • You are on the CC list for the bug.
--1372378681.1aEc2.5086-- From nscott@redhat.com Thu Jun 27 22:49:37 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id B95E17F3F for ; Thu, 27 Jun 2013 22:49:37 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id 498FAAC002 for ; Thu, 27 Jun 2013 20:49:33 -0700 (PDT) X-ASG-Debug-ID: 1372391371-04cbb0469093b790001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id 1Ln5K0AoPPRFM3J0 for ; Thu, 27 Jun 2013 20:49:31 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5S3nVFC011483 for ; Thu, 27 Jun 2013 23:49:31 -0400 Date: Thu, 27 Jun 2013 23:49:31 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: PCP Message-ID: <1942804724.9528832.1372391371173.JavaMail.root@redhat.com> In-Reply-To: <1715044262.9523595.1372389213645.JavaMail.root@redhat.com> Subject: Prepare to be assimilated^Wanalysed; resistance is futile MIME-Version: 1.0 X-ASG-Orig-Subj: Prepare to be assimilated^Wanalysed; resistance is futile Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: Prepare to be assimilated^Wanalysed; resistance is futile Thread-Index: Kjws7m4Pzx23Uz4ULiG8C+xfNEUwPQ== X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1372391371 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.22 X-Barracuda-Spam-Status: No, SCORE=0.22 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=PR0N_SUBJECT, THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.135175 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... 0.20 PR0N_SUBJECT Subject has letters around special characters (pr0n) Hi all, Just wanted to draw your attention to a recent large commit landing in the dev branch. This commit takes several steps toward complete automation of pmie and pmlogger for a local host setup. The approach taken uses the existing support for pmieconf in the pmie_check.sh script. Previously, we installed a default pmie configuration file however, which overrides this because no pmieconf magic string is found in that config (IOW, even though the logic is there from when this was done on IRIX, it wasn't being enabled anymore). As back then, a subset of the rules become activated by default, and they log to syslog by default. This concept has been added to pmlogger_check.sh too now - it invokes pmlogconf in the situation where the specified config file does not exist (the old config.default is also removed from the rpms/debs/...), or if it is annotated as a pmlogconf managed config. For Linux hosts, crontab entries are automatically installed for daily log rotation and checking (both pmlogger & pmie). Stan is undertaking an investigation into the sets of metrics that tools like Linux-sar and collectl currently log, with an eye to updating the default pmlogconf-generated set of logged metrics. So, other remaining work here - we should start to move away from storing config. pmlogger scripts in the tree (and installed below /etc/pcp/pmlogger) and move toward pmlogconf for all logging needs, so that things become automated (e.g. ./Install a new agent => automatically start logging metrics deemed important). Likewise for pmie and pmieconf. There has also been some concern that having automatically- modified/updated configuration files below /etc will cause heartache for some sysadmins. These files are arranged such that they identify sections which can be auto-transmoglified, and other sections which contain secret sysadmin business ... but even that may not be enough to sway the purists. Discuss please - offer alternatives, patches, discussion, ideas, etc, etc, and lets come up with something great. Please review carefully, its a fairly big step. In addition, Frank has some great ideas about using Avahi to allow pmcd to announce itself on a network, such that the next assimilation step of automating setup of centralised pmie/logger machines for a local network can also be performed! Just some Red Hat internal chatter on that so far, but lets widen the discussion to that kind of idea too, as its all closely related. Perhaps Frank could give an overview, else I'll summarise early next week when I have a free minute - its pretty cool stuff though, I'm really keen to see it in action! cheers. ps: I currently have a clean QA run with these changes, so I'm also keen to hear of any fallout in that department - thanks! -- Nathan commit 9cdfde093a6a2db48c049055267d2c92cdc62541 Author: Nathan Scott Date: Thu Jun 27 19:24:24 2013 +1000 Generate the default pmlogger and pmie configuration files This implements a number of changes around generating default configuration files using pmieconf and pmlogconf, as we move toward more automated enabling of monitoring/logging. Firstly, the existing pmieconf-integration-in-pmie_check is revisted, and some minor sh code cleanups made, refactoring some code a little particularly around pmieconf invocation, and removing some dated assumptions (eg around pmieconf not being installed, older pmie versions, etc). Next, pmlogger_check is given the same treatment, by adding support for running pmlogconf here, for configuration files that are either missing or begin with #pmlogconf magic. We then move on to enabling a local (primary) logger and a local pmie process by default, with the default generated configuration files (we no longer ship config.default files). Finally, crontab entries for checking, restarting and daily general care-and-feeding of pmie and pmlogger are installed somewhere cron automagically finds 'em (Linux only, else in the same location as before). Bwahahah ... self-awareness is imminent (cancel that - wait till you hear Frank's Avahi plan, hive-mind is imminent!) From nscott@redhat.com Thu Jun 27 22:49:55 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 53F3A7F3F for ; Thu, 27 Jun 2013 22:49:55 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay3.corp.sgi.com (Postfix) with ESMTP id C8868AC005 for ; Thu, 27 Jun 2013 20:49:54 -0700 (PDT) X-ASG-Debug-ID: 1372391391-04cb6c2a466a0550001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id CcHe1qmBVsZ4mIou for ; Thu, 27 Jun 2013 20:49:51 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5S3npkd029082 for ; Thu, 27 Jun 2013 23:49:51 -0400 Date: Thu, 27 Jun 2013 23:49:51 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: PCP Message-ID: <247465090.9528975.1372391391375.JavaMail.root@redhat.com> In-Reply-To: <776009432.9522490.1372388984553.JavaMail.root@redhat.com> Subject: pcp updates: default logging, default inferring, qa MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates: default logging, default inferring, qa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: pcp updates: default logging, default inferring, qa Thread-Index: y44rAOjA8VJ54yDNCku7yA1s3RDMpg== X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1372391391 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.135175 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... Changes committed to git://oss.sgi.com/pcp/pcp.git dev build/rpm/fedora.spec | 6 build/rpm/pcp.spec.in | 6 man/man1/GNUmakefile | 2 man/man1/pmie.1 | 3 man/man1/pmlogger_check.1 | 547 +++++++++++++ man/man1/pmlogger_daily.1 | 554 ------------- qa/547 | 7 qa/547.out | 32 qa/550 | 19 qa/550.out | 12 qa/551 | 21 qa/551.out | 4 qa/660 | 9 qa/660.out.4 | 4 qa/660.out.46 | 4 qa/GNUmakefile.install | 2 qa/check | 2 qa/common | 8 qa/secure/GNUmakefile | 3 qa/secure/GNUmakefile.install | 20 src/GNUmakefile | 22 src/pmcd_wait/.gitignore | 1 src/pmcd_wait/GNUmakefile | 31 src/pmcd_wait/pmcd_wait.c | 194 ++++ src/pmcdctl/.gitignore | 1 src/pmcdctl/GNUmakefile | 31 src/pmcdctl/pmcd_wait.c | 194 ---- src/pmdas/linux/devmapper.c | 4 src/pmie/.gitignore | 4 src/pmie/GNUmakefile | 41 - src/pmie/control | 6 src/pmie/crontab | 6 src/pmie/crontab.in | 8 src/pmie/pmie_check.sh | 202 ++-- src/pmie/src/pmie.c | 4 src/pmie/stomp | 11 src/pmie/stomp.install | 11 src/pmlogctl/.gitignore | 5 src/pmlogctl/GNUmakefile | 111 -- src/pmlogctl/GNUmakefile.install | 61 - src/pmlogctl/GNUmakefile.install.in | 114 +- src/pmlogctl/config.base | 124 --- src/pmlogctl/config.sar | 197 ---- src/pmlogctl/control | 60 - src/pmlogctl/crontab.IN | 8 src/pmlogctl/crontab.in | 16 src/pmlogctl/pmlogger.config | 13 src/pmlogctl/pmlogger_check.sh | 999 +++--------------------- src/pmlogctl/pmlogger_daily.sh | 855 -------------------- src/pmlogctl/pmlogger_merge.sh | 270 ------ src/pmlogctl/pmnewlog.sh | 636 --------------- src/pmlogger/.gitignore | 5 src/pmlogger/GNUmakefile | 67 - src/pmlogger/GNUmakefile.install.in | 114 +- src/pmlogger/callback.c | 784 ------------------- src/pmlogger/check.c | 164 ---- src/pmlogger/control | 50 + src/pmlogger/crontab.in | 8 src/pmlogger/dopdu.c | 1470 ------------------------------------ src/pmlogger/error.c | 35 src/pmlogger/events.c | 112 -- src/pmlogger/fetch.c | 189 ---- src/pmlogger/gram.y | 542 ------------- src/pmlogger/lex.l | 125 --- src/pmlogger/logger.h | 180 ---- src/pmlogger/pmlogger.c | 1186 ----------------------------- src/pmlogger/pmlogger.config | 13 src/pmlogger/pmlogger_check.sh | 806 +++++++++++++++++++ src/pmlogger/pmlogger_daily.sh | 855 ++++++++++++++++++++ src/pmlogger/pmlogger_merge.sh | 270 ++++++ src/pmlogger/pmnewlog.sh | 636 +++++++++++++++ src/pmlogger/ports.c | 515 ------------ src/pmlogger/preamble.c | 201 ---- src/pmlogger/rewrite.c | 47 - src/pmlogger/src/.gitignore | 2 src/pmlogger/src/GNUmakefile | 54 + src/pmlogger/src/callback.c | 784 +++++++++++++++++++ src/pmlogger/src/check.c | 164 ++++ src/pmlogger/src/dopdu.c | 1470 ++++++++++++++++++++++++++++++++++++ src/pmlogger/src/error.c | 35 src/pmlogger/src/events.c | 112 ++ src/pmlogger/src/fetch.c | 189 ++++ src/pmlogger/src/gram.y | 542 +++++++++++++ src/pmlogger/src/lex.l | 125 +++ src/pmlogger/src/logger.h | 180 ++++ src/pmlogger/src/pmlogger.c | 1186 +++++++++++++++++++++++++++++ src/pmlogger/src/ports.c | 515 ++++++++++++ src/pmlogger/src/preamble.c | 201 ++++ src/pmlogger/src/rewrite.c | 47 + src/pmlogger/src/util.c | 72 + src/pmlogger/util.c | 72 - 91 files changed, 9678 insertions(+), 9951 deletions(-) commit 64cc7eb9e1488caa47183d6f31afe39ad1427b1b Author: Nathan Scott Date: Fri Jun 28 12:37:37 2013 +1000 Remove a pre-pmlogconf Makefile leftover from an old config-munger commit c640dbbac7ccbbf9399e2583af83405fe93ae0fb Author: Nathan Scott Date: Fri Jun 28 12:15:48 2013 +1000 Take more care using readlink(2) in device mapping metric The newly added hinv.map.lvname metric has an instance domain which is populated with /dev/mapper links. The code reading these links was unaware (as was I) of the quirks of readlink resulting in occassional failure of pcp/qa test 540. commit c30a8ebcda957ec5290b91a202d2fd83ce2916d3 Author: Nathan Scott Date: Fri Jun 28 11:27:28 2013 +1000 Add a quiet mode to check script so it produces regular output commit 846167567181063f08e83ea62f8986bf069a0dc1 Author: Nathan Scott Date: Fri Jun 28 11:25:05 2013 +1000 Need to chdir into secure subdir for qa using pcppdu module therein Affects the last batch of new tests which weren't able to find this common helper module. Also, make sure its built correctly and ready for use by the time check is invoked. commit d6051aee0166b5959a55a317431cf58074583e1a Author: Nathan Scott Date: Fri Jun 28 08:53:31 2013 +1000 Fix test 660 after recent changes to pmwebd sources This test exercises a couple of error handling paths that have recently been changed from returning ESRCH to EINVAL, meaning the html response body changed. Fixed via filtering to check a negative code followed by a message is reported. By goodluck, this should now work on non-Linux platforms too (where the ESRCH errno value wont be the same as on Linux). commit dc40d78ce184a06d89d976452b98e0964499b393 Author: Nathan Scott Date: Thu Jun 27 20:06:22 2013 +1000 Resolve source layout inconsistency between pmlogger/pmie/pmcd For some strange reason a number of pmlogger scripts has been put in a different location (pmlogctl) to the pmcd and pmie code which has scripts in top level then source in a "src" directory. This commit makes pmlogger toe the line, keeping everything the same for ease of locating the various helper scripts/sources. commit 9cdfde093a6a2db48c049055267d2c92cdc62541 Author: Nathan Scott Date: Thu Jun 27 19:24:24 2013 +1000 Generate the default pmlogger and pmie configuration files This implements a number of changes around generating default configuration files using pmieconf and pmlogconf, as we move toward more automated enabling of monitoring/logging. Firstly, the existing pmieconf-integration-in-pmie_check is revisted, and some minor sh code cleanups made, refactoring some code a little particularly around pmieconf invocation, and removing some dated assumptions (eg around pmieconf not being installed, older pmie versions, etc). Next, pmlogger_check is given the same treatment, by adding support for running pmlogconf here, for configuration files that are either missing or begin with #pmlogconf magic. We then move on to enabling a local (primary) logger and a local pmie process by default, with the default generated configuration files (we no longer ship config.default files). Finally, crontab entries for checking, restarting and daily general care-and-feeding of pmie and pmlogger are installed somewhere cron automagically finds 'em (Linux only, else in the same location as before). Bwahahah ... self-awareness is imminent (cancel that - wait till you hear Frank's Avahi plan, hive-mind is imminent!) From fche@redhat.com Sun Jun 30 10:18:29 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 190017F4E for ; Sun, 30 Jun 2013 10:18:29 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id ED1EF304059 for ; Sun, 30 Jun 2013 08:18:28 -0700 (PDT) X-ASG-Debug-ID: 1372605504-04cb6c2a46707e70001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id b7UoCWxDunKla5sL for ; Sun, 30 Jun 2013 08:18:25 -0700 (PDT) X-Barracuda-Envelope-From: fche@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5UFIOPc029178 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 30 Jun 2013 11:18:24 -0400 Received: from fche.csb (vpn-57-228.rdu2.redhat.com [10.10.57.228]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5UFIMPY020090; Sun, 30 Jun 2013 11:18:23 -0400 Received: by fche.csb (Postfix, from userid 2569) id 5F73D58183; Sun, 30 Jun 2013 11:18:22 -0400 (EDT) To: Nathan Scott Cc: PCP Subject: Re: Prepare to be assimilated^Wanalysed; resistance is futile References: <1715044262.9523595.1372389213645.JavaMail.root@redhat.com> <1942804724.9528832.1372391371173.JavaMail.root@redhat.com> X-ASG-Orig-Subj: Re: Prepare to be assimilated^Wanalysed; resistance is futile From: fche@redhat.com (Frank Ch. Eigler) Date: Sun, 30 Jun 2013 11:18:22 -0400 In-Reply-To: <1942804724.9528832.1372391371173.JavaMail.root@redhat.com> (Nathan Scott's message of "Thu, 27 Jun 2013 23:49:31 -0400 (EDT)") Message-ID: User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1372605504 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 nathans wrote: > [...] > For Linux hosts, crontab entries are automatically installed > for daily log rotation and checking (both pmlogger & pmie). Would you considering pushing a random snapshot of dev into fedora rawhide, so people can experiment with it easier? (We do this with systemtap, semiautomagically pushing updates weekly.) > [...] There has also been some concern that having automatically- > modified/updated configuration files below /etc will cause heartache > for some sysadmins. [...] Discuss please - offer alternatives, > patches, discussion, ideas, etc, etc, and lets come up with > something great. If it were not too much work, I'd rather see generated files distinct from hand-made files. Perhaps pmlogger et al. could run pmcpp on its configuration file (and let the generated one be #include'd), or search a directory and consume the union of the files there. > [...] Frank has some [...] ideas about using Avahi to allow pmcd to > announce itself on a network, such that the next assimilation step > of automating setup of centralised pmie/logger machines for a local > network can also be performed! [...] The idea is small: - to have running pmcd's announce themselves on the local net via DNS-SD = avahi = zeroconf - to have pmlogger or pmlogconf or whatnot tool monitor the DNS-SD announcements, and create/shutdown new pmlogger instances for them. Basically, auto-configured network-wide logging on designated central hosts. - FChE From kenj@internode.on.net Sun Jun 30 14:58:26 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id C1E0429DF8 for ; Sun, 30 Jun 2013 14:58:26 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id 4F4A4AC001 for ; Sun, 30 Jun 2013 12:58:23 -0700 (PDT) X-ASG-Debug-ID: 1372622300-04cbb0468f9afa90001-S8gJnT Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id NIktKYXtLlc706Uq for ; Sun, 30 Jun 2013 12:58:21 -0700 (PDT) X-Barracuda-Envelope-From: kenj@internode.on.net X-Barracuda-Apparent-Source-IP: 150.101.137.141 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApkBADSL0FF20bGI/2dsb2JhbAANTcACLYJqgRSDFwEBAQMBOC0TBgsLGAkWDwkDAgECAUUTCAEBiAWpRpE6j2UWg1EDrDA Received: from ppp118-209-177-136.lns20.mel6.internode.on.net (HELO [192.168.1.100]) ([118.209.177.136]) by ipmail04.adl6.internode.on.net with ESMTP; 01 Jul 2013 05:28:19 +0930 Message-ID: <51D08DEE.6030209@internode.on.net> Date: Mon, 01 Jul 2013 05:58:38 +1000 From: Ken McDonell User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: pcp@oss.sgi.com Subject: Re: [pcp] Prepare to be assimilated^Wanalysed; resistance is futile References: <1715044262.9523595.1372389213645.JavaMail.root@redhat.com> <1942804724.9528832.1372391371173.JavaMail.root@redhat.com> X-ASG-Orig-Subj: Re: [pcp] Prepare to be assimilated^Wanalysed; resistance is futile In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Barracuda-Connect: ipmail04.adl6.internode.on.net[150.101.137.141] X-Barracuda-Start-Time: 1372622301 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.20 X-Barracuda-Spam-Status: No, SCORE=0.20 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=PR0N_SUBJECT X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.135431 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.20 PR0N_SUBJECT Subject has letters around special characters (pr0n) On 01/07/13 01:18, Frank Ch. Eigler wrote: >... > If it were not too much work, I'd rather see generated files distinct > from hand-made files. Perhaps pmlogger et al. could run pmcpp on its > configuration file (and let the generated one be #include'd), or > search a directory and consume the union of the files there. This would appear to pass the "not too much work" pre-condition. The only issues that I can see are ... 1. pmlogger config file syntax does not include a version header (unlike some of the other config files we define and use), so we'd need to invent one going forward, or add some keyword glue at the start of the file 2. pmlogger config files use sh-like commenting, so comment lines beginning with # are not going to work all that well with pmcpp (or any other cpp look alike) ... we'll probably need some sed | pmcpp | sed logic to make this transparent If we do 2., then 1. may not be required ... always preprocess and existing config files are unchanged. > The idea is small: > > - to have running pmcd's announce themselves on the > local net via DNS-SD = avahi = zeroconf > - to have pmlogger or pmlogconf or whatnot tool monitor the DNS-SD > announcements, and create/shutdown new pmlogger instances for them. > > Basically, auto-configured network-wide logging on designated central hosts. This is a great idea. I have one immediate application where this would be most useful in load balanced cloud-land where the servers comes and go as load dictates. From nscott@redhat.com Sun Jun 30 17:11:21 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 1D42D29DF8 for ; Sun, 30 Jun 2013 17:11:21 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay2.corp.sgi.com (Postfix) with ESMTP id 0D088304051 for ; Sun, 30 Jun 2013 15:11:17 -0700 (PDT) X-ASG-Debug-ID: 1372630276-04cbb046919b36a0001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id TFw1X4vWBXu8PSOY for ; Sun, 30 Jun 2013 15:11:16 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5UMBD8k027358; Sun, 30 Jun 2013 18:11:13 -0400 Date: Sun, 30 Jun 2013 18:11:13 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Ken McDonell , "Frank Ch. Eigler" Cc: pcp@oss.sgi.com Message-ID: <406338386.10303545.1372630273147.JavaMail.root@redhat.com> In-Reply-To: <51D08DEE.6030209@internode.on.net> References: <1715044262.9523595.1372389213645.JavaMail.root@redhat.com> <1942804724.9528832.1372391371173.JavaMail.root@redhat.com> <51D08DEE.6030209@internode.on.net> Subject: Re: [pcp] Prepare to be assimilated^Wanalysed; resistance is futile MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] Prepare to be assimilated^Wanalysed; resistance is futile Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: Prepare to be assimilated^Wanalysed; resistance is futile Thread-Index: wdxNNDjHqZYMgl2zwqIBM5/XsiVc3w== X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1372630276 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.22 X-Barracuda-Spam-Status: No, SCORE=0.22 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=PR0N_SUBJECT, THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.135439 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... 0.20 PR0N_SUBJECT Subject has letters around special characters (pr0n) ----- Original Message ----- > On 01/07/13 01:18, Frank Ch. Eigler wrote: > >... > > If it were not too much work, I'd rather see generated files distinct > > from hand-made files. Perhaps pmlogger et al. could run pmcpp on its > > configuration file (and let the generated one be #include'd), or > > search a directory and consume the union of the files there. > > This would appear to pass the "not too much work" pre-condition. The > only issues that I can see are ... > 1. pmlogger config file syntax does not include a version header (unlike > some of the other config files we define and use), so we'd need to > invent one going forward, or add some keyword glue at the start of the file > 2. pmlogger config files use sh-like commenting, so comment lines > beginning with # are not going to work all that well with pmcpp (or any > other cpp look alike) ... we'll probably need some sed | pmcpp | sed > logic to make this transparent Another issue that just occurred to me... 3. The [access] section needs to appear at the end of the final file. > If we do 2., then 1. may not be required ... always preprocess and > existing config files are unchanged. > > > The idea is small: But the implications are huge! :) > > - to have running pmcd's announce themselves on the > > local net via DNS-SD = avahi = zeroconf > > - to have pmlogger or pmlogconf or whatnot tool monitor the DNS-SD > > announcements, and create/shutdown new pmlogger instances for them. (and likewise for pmie) The "... or ... or ..." bit warrants some further discussion - I'll send some follow-up mail a little later with my thoughts/opinions there. > > Basically, auto-configured network-wide logging on designated central > > hosts. > > This is a great idea. *nod*, vigorously. > I have one immediate application where this would be most useful in load > balanced cloud-land where the servers comes and go as load dictates. This could have saved plenty of effort in previous deployments I've been involved with - removes lots of otherwise manual administrator effort to configure things. Even for puppet-driven sites, there's still effort to manage initial setup correctly, then maintain that puppet config state going forward. cheers. -- Nathan From kenj@internode.on.net Sun Jun 30 23:27:31 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id DF6397F4E for ; Sun, 30 Jun 2013 23:27:30 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id 7D1A9AC003 for ; Sun, 30 Jun 2013 21:27:27 -0700 (PDT) X-ASG-Debug-ID: 1372652844-04cbb0468e9bc880001-S8gJnT Received: from ipmail05.adl6.internode.on.net (ipmail05.adl6.internode.on.net [150.101.137.143]) by cuda.sgi.com with ESMTP id SECyL7hcW7MKwxBh for ; Sun, 30 Jun 2013 21:27:25 -0700 (PDT) X-Barracuda-Envelope-From: kenj@internode.on.net X-Barracuda-Apparent-Source-IP: 150.101.137.143 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AisAACQE0VGvLVMil2dsb2JhbAANTcQ1DgEBAQEBCBYHgx5APRYYAwIBAgFLDQgBAbFWkT+TTAOsMA Received: from ip-34.83.45.175.vocus.net.au (HELO [192.168.19.17]) ([175.45.83.34]) by ipmail05.adl6.internode.on.net with ESMTP; 01 Jul 2013 13:57:06 +0930 Message-ID: <51D10517.2010901@internode.on.net> Date: Mon, 01 Jul 2013 14:27:03 +1000 From: Ken McDonell User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: PCP Mailing List Subject: old style log dredging PMDA Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-ASG-Orig-Subj: old style log dredging PMDA Content-Transfer-Encoding: 7bit X-Barracuda-Connect: ipmail05.adl6.internode.on.net[150.101.137.143] X-Barracuda-Start-Time: 1372652844 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.135463 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Once upon a time we had (Mark wrote I think) a pmda that camped on the end of a log file basically doing a tail piped into a grep selection to accumulate counts of different sorts of log lines. It also handled log rotation. Does anyone else remember this, or am I dreamin' again? If it did exist at one time, anyone know where to find it now? From nscott@redhat.com Sun Jun 30 23:34:48 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 610EB7F4E for ; Sun, 30 Jun 2013 23:34:48 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id 353E58F8037 for ; Sun, 30 Jun 2013 21:34:48 -0700 (PDT) X-ASG-Debug-ID: 1372653283-04bdf0233e9d1d40001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id REpPy0nMHPSOnrtw for ; Sun, 30 Jun 2013 21:34:43 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r614Yei6017622; Mon, 1 Jul 2013 00:34:40 -0400 Date: Mon, 1 Jul 2013 00:34:40 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Ken McDonell Cc: PCP Mailing List Message-ID: <1659227349.10352600.1372653280697.JavaMail.root@redhat.com> In-Reply-To: <51D10517.2010901@internode.on.net> References: <51D10517.2010901@internode.on.net> Subject: Re: [pcp] old style log dredging PMDA MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] old style log dredging PMDA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: old style log dredging PMDA Thread-Index: gQuEqUXc5Gem/6ZNYvgt6CBJ4Gb/Wg== X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1372653283 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.02 X-Barracuda-Spam-Status: No, SCORE=0.02 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.135463 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... ----- Original Message ----- > Once upon a time we had (Mark wrote I think) a pmda that camped on the > end of a log file basically doing a tail piped into a grep selection to > accumulate counts of different sorts of log lines. > > It also handled log rotation. > > Does anyone else remember this, or am I dreamin' again? > This is probably it... ../../pmns/stdpmid:#define LOGTAIL 67 > If it did exist at one time, anyone know where to find it now? No idea what happened to it. Not sure how much overlap there is with pmdaweblog, perhaps it morphed into the latter? cheers. -- Nathan From mgoodwin@redhat.com Sun Jun 30 23:35:17 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 550097F4E for ; Sun, 30 Jun 2013 23:35:17 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id 38AFA8F8037 for ; Sun, 30 Jun 2013 21:35:17 -0700 (PDT) X-ASG-Debug-ID: 1372653316-04bdf02b8e7ab420001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id hfetBDSWLwoXvImN for ; Sun, 30 Jun 2013 21:35:16 -0700 (PDT) X-Barracuda-Envelope-From: mgoodwin@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r614ZGTT007605 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 1 Jul 2013 00:35:16 -0400 Received: from fletch.usersys.redhat.com (vpn1-48-104.bne.redhat.com [10.64.48.104]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r614ZECX013625 for ; Mon, 1 Jul 2013 00:35:15 -0400 Message-ID: <51D10702.5090602@redhat.com> Date: Mon, 01 Jul 2013 14:35:14 +1000 From: Mark Goodwin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20130206 Thunderbird/14.0 MIME-Version: 1.0 To: pcp@oss.sgi.com Subject: Re: [pcp] old style log dredging PMDA References: <51D10517.2010901@internode.on.net> X-ASG-Orig-Subj: Re: [pcp] old style log dredging PMDA In-Reply-To: <51D10517.2010901@internode.on.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1372653316 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 On 07/01/2013 02:27 PM, Ken McDonell wrote: > Once upon a time we had (Mark wrote I think) a pmda that camped on the end of a > log file basically doing a tail piped into a grep selection to accumulate counts > of different sorts of log lines. > > It also handled log rotation. > > Does anyone else remember this, or am I dreamin' again? > > If it did exist at one time, anyone know where to find it now? yes, it was called 'logtail' but the only remnant seems to be a slot in stdpmid for LOGTAIL. I think I must have neglected to open-source it at one point :( Maybe someone still at SGI could release it? Jeff Hanson? Regards -- Mark From nscott@redhat.com Sun Jun 30 23:47:00 2013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.3.1 X-Original-To: pcp@oss.sgi.com Delivered-To: pcp@oss.sgi.com Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id E9B1E7F4E for ; Sun, 30 Jun 2013 23:47:00 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay2.corp.sgi.com (Postfix) with ESMTP id CCF1D304043 for ; Sun, 30 Jun 2013 21:46:57 -0700 (PDT) X-ASG-Debug-ID: 1372654016-04cbb046909bd570001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id NotuQBkZvCRzmY2o for ; Sun, 30 Jun 2013 21:46:56 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r614kt6e019567; Mon, 1 Jul 2013 00:46:55 -0400 Date: Mon, 1 Jul 2013 00:46:55 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Mark Goodwin Cc: pcp@oss.sgi.com Message-ID: <1081637805.10353416.1372654015840.JavaMail.root@redhat.com> In-Reply-To: <51D10702.5090602@redhat.com> References: <51D10517.2010901@internode.on.net> <51D10702.5090602@redhat.com> Subject: Re: [pcp] old style log dredging PMDA MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] old style log dredging PMDA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF17 (Linux)/8.0.3_GA_5664) Thread-Topic: old style log dredging PMDA Thread-Index: PmHipBv8m8ObM9490zg/dUHMksG1Dw== X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1372654016 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.03 X-Barracuda-Spam-Status: No, SCORE=0.03 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH, THREAD_INDEX, THREAD_TOPIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.135463 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 THREAD_INDEX thread-index: AcO7Y8iR61tzADqsRmmc5wNiFHEOig== 0.01 THREAD_TOPIC Thread-Topic: ...(Japanese Subject)... 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain ----- Original Message ----- > On 07/01/2013 02:27 PM, Ken McDonell wrote: > > Once upon a time we had (Mark wrote I think) a pmda that camped on the end > > of a > > log file basically doing a tail piped into a grep selection to accumulate > > counts > > of different sorts of log lines. > ... > Maybe someone still at SGI could release it? Jeff Hanson? It would possibly be better to use the Perl PMDA API (which supports log tailing correctly also) to re-implement this...? See pmdanamed.pl or pmdazimbra.pl for examples and $pmda->add_tail(). cheers. -- Nathan