From mailman-bounces@oss.sgi.com Wed Aug 1 05:01:42 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,BAYES_00, J_CHICKENPOX_25 autolearn=no version=3.4.0-r929098 Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q71A16al011513 for ; Wed, 1 Aug 2012 05:01:06 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Subject: oss.sgi.com mailing list memberships reminder From: mailman-owner@oss.sgi.com To: pcp@oss.sgi.com X-No-Archive: yes Message-ID: Date: Wed, 01 Aug 2012 05:00:31 -0500 Precedence: bulk X-BeenThere: mailman@oss.sgi.com X-Mailman-Version: 2.1.11 List-Id: Mailman mail X-List-Administrivia: yes Sender: mailman-bounces@oss.sgi.com Errors-To: mailman-bounces@oss.sgi.com This is a reminder, sent out once a month, about your oss.sgi.com mailing list memberships. It includes your subscription info and how to use it to change it or unsubscribe from a list. You can visit the URLs to change your membership status or configuration, including unsubscribing, setting digest-style delivery or disabling delivery altogether (e.g., for a vacation), and so on. In addition to the URL interfaces, you can also use email to make such changes. For more info, send a message to the '-request' address of the list (for example, mailman-request@oss.sgi.com) containing just the word 'help' in the message body, and an email message will be sent to you with instructions. If you have questions, problems, comments, etc, send them to mailman-owner@oss.sgi.com. Thanks! Passwords for pcp@oss.sgi.com: List Password // URL ---- -------- pcp-announce@oss.sgi.com xE+IBctR http://oss.sgi.com/mailman/options/pcp-announce/pcp%40oss.sgi.com From mgoodwin@redhat.com Thu Aug 2 01:00:04 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q726041e121193 for ; Thu, 2 Aug 2012 01:00:04 -0500 X-ASG-Debug-ID: 1343887201-04bdf02d18245310001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id ioelxrpmNBa24APi for ; Wed, 01 Aug 2012 23:00:02 -0700 (PDT) X-Barracuda-Envelope-From: mgoodwin@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q725xtQ2006914 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 2 Aug 2012 01:59:55 -0400 Received: from fletch.usersys.redhat.com (vpn1-50-47.bne.redhat.com [10.64.50.47]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q725xrbj001556; Thu, 2 Aug 2012 01:59:54 -0400 Message-ID: <501A1758.4040708@redhat.com> Date: Thu, 02 Aug 2012 15:59:52 +1000 From: Mark Goodwin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: pcp CC: Nathan Scott Subject: pcp updates Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-ASG-Orig-Subj: pcp updates Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1343887202 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com Changes committed to git://oss.sgi.com/markgw/pcp/pcp.git proc_pmda (note: 'proc_pmda' branch, and also pulled from Ken's proc_pmda branch prior to the changes listed below). This fixes up the remaining cgroup issues and completes the migration/split from the Linux PMDA to the proc PMDA, including the pmlogrewrite config to migrate archives. commit 7009ca620edf2ccbf430857762f61817ca68200d Author: Mark Goodwin Date: Thu Aug 2 15:51:21 2012 +1000 pmlogrewrite config for migrating archives containing proc and cgroup metrics that were captured prior to splitting off the proc PMDA from the Linux PMDA. For details, see comments in linux_proc_migrate.conf modified: src/pmdas/linux_proc/GNUmakefile new file: src/pmdas/linux_proc/linux_proc_migrate.conf modified: src/pmlogrewrite/GNUmakefile commit 5fc95183ec8e400c302ccab6045e68431421a672 Author: Mark Goodwin Date: Thu Aug 2 15:16:30 2012 +1000 Finish the cgroups migration from the Linux PMDA. Fix refresh_filesys() to correctly walk the mount table, add refresh_cpu_indom() for cgroup.groups.cpuacct.[.]usage_percpu and cgroup.groups.cpuacct.usage_percpu and correctly initialize the instance domains under the control of the pmdaCache API. The proc indom itself still uses it's own indexing for efficiency reasons and because it never needs to be persistent anyway. modified: src/pmdas/linux_proc/cgroups.c modified: src/pmdas/linux_proc/filesys.c modified: src/pmdas/linux_proc/filesys.h modified: src/pmdas/linux_proc/pmda.c From kenj@internode.on.net Thu Aug 2 07:12:30 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,J_CHICKENPOX_66 autolearn=no version=3.4.0-r929098 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q72CCUSR174359 for ; Thu, 2 Aug 2012 07:12:30 -0500 X-ASG-Debug-ID: 1343909548-04cbb06db026e6c0001-S8gJnT Received: from ipmail06.adl6.internode.on.net (ipmail06.adl6.internode.on.net [150.101.137.145]) by cuda.sgi.com with ESMTP id EtpqvfbxqpJRPXN7 for ; Thu, 02 Aug 2012 05:12:28 -0700 (PDT) X-Barracuda-Envelope-From: kenj@internode.on.net X-Barracuda-Apparent-Source-IP: 150.101.137.145 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtUZAE1uGlA6q5/5PGdsb2JhbAANOIV7hDqubwEBAQE3glQBAQEEI1YQCw0BCgICJgICQxQGsUhukx2BIZAagRIDm0SNAQ Received: from unknown (HELO [10.230.238.121]) ([58.171.159.249]) by ipmail06.adl6.internode.on.net with ESMTP; 02 Aug 2012 21:42:15 +0930 Message-ID: <1343909531.2747.0.camel@bozo-laptop.localdomain> Subject: Re: [pcp] pcp updates From: Ken McDonell X-ASG-Orig-Subj: Re: [pcp] pcp updates To: Mark Goodwin Cc: pcp Date: Thu, 02 Aug 2012 22:12:11 +1000 In-Reply-To: <501A1758.4040708@redhat.com> References: <501A1758.4040708@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-Barracuda-Connect: ipmail06.adl6.internode.on.net[150.101.137.145] X-Barracuda-Start-Time: 1343909548 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.104464 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- On Thu, 2012-08-02 at 15:59 +1000, Mark Goodwin wrote: > Changes committed to git://oss.sgi.com/markgw/pcp/pcp.git proc_pmda > (note: 'proc_pmda' branch, and also pulled from Ken's proc_pmda > branch prior to the changes listed below). > > This fixes up the remaining cgroup issues and completes the > migration/split from the Linux PMDA to the proc PMDA, > including the pmlogrewrite config to migrate archives. Mark, I'm still not seeing any cgroup.groups metrics in my (modified) QA/361. From mgoodwin@redhat.com Thu Aug 2 18:51:27 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q72NpR6J257168 for ; Thu, 2 Aug 2012 18:51:27 -0500 X-ASG-Debug-ID: 1343951486-04cb6c193f296c60001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id P6ySiz2DbDDBEXyA for ; Thu, 02 Aug 2012 16:51:27 -0700 (PDT) X-Barracuda-Envelope-From: mgoodwin@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q72NpQii010582 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 2 Aug 2012 19:51:26 -0400 Received: from fletch.usersys.redhat.com (vpn1-50-55.bne.redhat.com [10.64.50.55]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q72NpN0R024004 for ; Thu, 2 Aug 2012 19:51:24 -0400 Message-ID: <501B127A.30808@redhat.com> Date: Fri, 03 Aug 2012 09:51:22 +1000 From: Mark Goodwin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: pcp Subject: pcp updates Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-ASG-Orig-Subj: pcp updates Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1343951486 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com Changes committed to git://oss.sgi.com/markgw/pcp/pcp.git proc_pmda (note: 'proc_pmda' branch) commit dfb33e68026cf26f5f174f0e757a68752fbe1348 Author: Mark Goodwin Date: Fri Aug 3 09:43:19 2012 +1000 Correctly scan for cgroup mounts in /proc/mounts. Scan for cgroup mounts based on the mount type field (3rd field) in /proc/mounts rather than the device (1st field). cgroup mounts have no associated underlying device, so it can be arbitrary. modified: src/pmdas/linux_proc/filesys.c From mgoodwin@redhat.com Thu Aug 2 18:57:42 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,J_CHICKENPOX_66 autolearn=no version=3.4.0-r929098 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q72Nvg6Y257999 for ; Thu, 2 Aug 2012 18:57:42 -0500 X-ASG-Debug-ID: 1343951861-04cbb06db12c1430001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id URQ0Xfumu9Kv4Wyg for ; Thu, 02 Aug 2012 16:57:41 -0700 (PDT) X-Barracuda-Envelope-From: mgoodwin@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q72Nva38010525 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 2 Aug 2012 19:57:37 -0400 Received: from fletch.usersys.redhat.com (vpn1-50-55.bne.redhat.com [10.64.50.55]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q72NvXPf003292; Thu, 2 Aug 2012 19:57:34 -0400 Message-ID: <501B13ED.1050605@redhat.com> Date: Fri, 03 Aug 2012 09:57:33 +1000 From: Mark Goodwin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: Ken McDonell CC: pcp Subject: Re: [pcp] pcp updates References: <501A1758.4040708@redhat.com> <1343909531.2747.0.camel@bozo-laptop.localdomain> X-ASG-Orig-Subj: Re: [pcp] pcp updates In-Reply-To: <1343909531.2747.0.camel@bozo-laptop.localdomain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1343951861 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com On 08/02/2012 10:12 PM, Ken McDonell wrote: > On Thu, 2012-08-02 at 15:59 +1000, Mark Goodwin wrote: >> Changes committed to git://oss.sgi.com/markgw/pcp/pcp.git proc_pmda >> (note: 'proc_pmda' branch, and also pulled from Ken's proc_pmda >> branch prior to the changes listed below). >> >> This fixes up the remaining cgroup issues and completes the >> migration/split from the Linux PMDA to the proc PMDA, >> including the pmlogrewrite config to migrate archives. > > Mark, I'm still not seeing any cgroup.groups metrics in my (modified) > QA/361. > oops, sorry I was scanning /proc/mounts for "cgroup" in the wrong field. dfb33e68026cf26f5f174f0e757a68752fbe1348 in my proc_pmda branch fixes it. note that qa/361 will always fail on fedora systems because several essential services (e.g. systemd) use cgroup mounts for various things, so the 'clean slate" check always fails. I assume you've already worked around that, but I'll try and find some time this evening to look at it too. Thanks -- Mark From ndsco1@student.monash.edu Sun Aug 5 19:14:59 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q760EwUV029427 for ; Sun, 5 Aug 2012 19:14:59 -0500 X-ASG-Debug-ID: 1344212094-04cb6c3c713bc00001-S8gJnT Received: from kenny.its.monash.edu.au (kenny.its.monash.edu.au [130.194.13.164]) by cuda.sgi.com with ESMTP id SADROLLPqxi4VLxA for ; Sun, 05 Aug 2012 17:14:56 -0700 (PDT) X-Barracuda-Envelope-From: ndsco1@student.monash.edu X-Barracuda-Apparent-Source-IP: 130.194.13.164 Received: from cleese.its.monash.edu.au ([130.194.13.85]) by kenny.its.monash.edu.au (Sun Java System Messaging Server 6.2-4.03 (built Sep 22 2005)) with ESMTP id <0M8B00GI34OUNL60@kenny.its.monash.edu.au> for pcp@oss.sgi.com; Mon, 06 Aug 2012 10:14:54 +1000 (EST) Received: from cleese.its.monash.edu.au (localhost.localdomain [127.0.0.1]) by localhost (Postfix) with SMTP id 33646766360 for ; Mon, 06 Aug 2012 10:14:54 +1000 (EST) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by cleese.its.monash.edu.au (Postfix) with ESMTPS id ABBDB76632C for ; Mon, 06 Aug 2012 10:14:53 +1000 (EST) Received: by mail-pb0-f54.google.com with SMTP id rp2so310381pbb.41 for ; Sun, 05 Aug 2012 17:14:53 -0700 (PDT) Received: by 10.66.75.98 with SMTP id b2mr14330294paw.60.1344212093210; Sun, 05 Aug 2012 17:14:53 -0700 (PDT) Received: by 10.68.44.135 with HTTP; Sun, 05 Aug 2012 17:14:53 -0700 (PDT) Date: Mon, 06 Aug 2012 10:14:53 +1000 From: Nathan Scott Subject: pcp-gui updates Sender: ndsco1@student.monash.edu X-ASG-Orig-Subj: pcp-gui updates To: pcp Message-id: MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type:x-gm-message-state; bh=r7Wbo7nLYpluYH3HC7c1qmxi4fFgHfyeDCEhDwrC6QU=; b=H+7ODiAMNdXQbZFsN0ZIY98m4Fy9LfuAUqWjXNhuPjBUeG6JTBqIkzs9U3Q5wh23Rz wv89iQDHJgmkXRt55RMlcU5lFa9MD/kTyZzumiW6AqhgOABtj485hf4EEO5GFwnk2fUz AIG+6031MYkeHuiNssdvzAqanzH3MeeowpMqyNXDi0RrlXRcfDS+vuhpr5rFFunGuxvq A9N3hGuEPmYm3utwv2ndNN3xUIJBJstLv2ZG3CQccmllAh97umthUzxAf/02ne1alpd8 ag33kRHdAaBoX82fEeFSa3s5OzfhRGytPSZrVIcBGisSbhoo20MZ6SWBXIAMWGWZ/aeE Y5ug== X-Google-Sender-Auth: 5yrqy6Ak0vAFuWQ15Cg3P7jbHUU X-Gm-Message-State: ALoCoQnIrt3Hm4RU8uHmVzn0+ShyovRAsP4u7Pq+idKjpkl5Ghsa4lv2WIOnGUa9i0vmdtg03v/x X-Barracuda-Connect: kenny.its.monash.edu.au[130.194.13.164] X-Barracuda-Start-Time: 1344212095 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.104800 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp-gui.git dev VERSION | 2 +- aclocal.m4 | 12 ++++++++++-- configure.in | 1 + debian/changelog | 6 ++++++ doc/CHANGES | 4 ++++ m4/package_pcpdev.m4 | 7 +++++++ qa/src/qmc_desc/qmc_desc.cpp | 22 +++------------------- qa/src/qmc_indom/qmc_indom.cpp | 2 +- src/chart/chart.cpp | 27 ++++++++++++++++++++------- src/chart/chart.h | 10 +++++++--- src/include/version.h.in | 4 ++++ 11 files changed, 64 insertions(+), 33 deletions(-) commit d31702f0577487599043a31172657df962bb2f6d Author: Nathan Scott Date: Sun Aug 5 18:41:29 2012 +1000 Fix compilation warnings in qa test sources. commit 3a85d85b492219090598807131e36ea16519d248 Author: Nathan Scott Date: Sun Aug 5 16:04:44 2012 +1000 Add configure support for event type macro, and initial chart compat check. commit bd7375a8f42bba80c8f9de56275a1b3ef5062b97 Author: Nathan Scott Date: Sun Aug 5 16:04:14 2012 +1000 Change version in dev branch for upcoming pcp-gui changes. From ndsco1@student.monash.edu Sun Aug 5 19:30:38 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q760UcDb031408 for ; Sun, 5 Aug 2012 19:30:38 -0500 X-ASG-Debug-ID: 1344213036-04cb6c3c713c6b0001-S8gJnT Received: from kenny.its.monash.edu.au (kenny.its.monash.edu.au [130.194.13.164]) by cuda.sgi.com with ESMTP id 86j5gfy2PZ2Oow0B for ; Sun, 05 Aug 2012 17:30:37 -0700 (PDT) X-Barracuda-Envelope-From: ndsco1@student.monash.edu X-Barracuda-Apparent-Source-IP: 130.194.13.164 Received: from idle.its.monash.edu.au ([130.194.13.84]) by kenny.its.monash.edu.au (Sun Java System Messaging Server 6.2-4.03 (built Sep 22 2005)) with ESMTP id <0M8B00GXQ5F0NL60@kenny.its.monash.edu.au> for pcp@oss.sgi.com; Mon, 06 Aug 2012 10:30:36 +1000 (EST) Received: from idle.its.monash.edu.au (localhost.localdomain [127.0.0.1]) by localhost (Postfix) with SMTP id 82889100E0 for ; Mon, 06 Aug 2012 10:30:36 +1000 (EST) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by idle.its.monash.edu.au (Postfix) with ESMTPS id 0CBE510151 for ; Mon, 06 Aug 2012 10:30:35 +1000 (EST) Received: by pbbrp2 with SMTP id rp2so327550pbb.41 for ; Sun, 05 Aug 2012 17:30:33 -0700 (PDT) Received: by 10.68.194.169 with SMTP id hx9mr14800640pbc.8.1344213032939; Sun, 05 Aug 2012 17:30:32 -0700 (PDT) Received: by 10.68.44.135 with HTTP; Sun, 05 Aug 2012 17:30:32 -0700 (PDT) Date: Mon, 06 Aug 2012 10:30:32 +1000 From: Nathan Scott Subject: PCP QA packaging Sender: ndsco1@student.monash.edu X-ASG-Orig-Subj: PCP QA packaging To: Ken McDonell Cc: pcp Message-id: MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:x-gm-message-state; bh=7OOLbA2oRhYcAeT7ZyfRRweePBIqNzxZ1VG6iEISiCI=; b=iiic/Wq14gbs40sGbXsGPKOHRNJwQIgUzWtygwj2+S8qAjW7c8qWyPQJlgPOuCH+fV HQZfVofqVsqz324vgs6KP/GIMKYYklG+EDVyUu3pXrvP7XJQNRteFvK9MY1qfFgpoOX3 pgSdUk2urmT53Kl/IeiiISZQWRCdWdWPOMgh35t3hxzrngajMOBXveo9y+tpsg/wv9To ei+ZNmq1r2tTdcsANCUtu0Z71U7bmT12go59r+char6UrBmlqDni8XQifIg3VoYiGEys jbNnI9HiNu4fVqfftm2YRbziJP+Yx0020LbAglPjn8z4Q+iOjShC2VW0W1AqC6Vry0xh +8zQ== X-Google-Sender-Auth: t9-gsiTAdSXhFvgOeRZNUkncN0k X-Gm-Message-State: ALoCoQkTyd/LEPxyjezA0Fv9HXDkLBmKQXvzjKIkkvGg3YFGLzVqiofqbxnE/y2Sk9NFQKutWSt+ X-Barracuda-Connect: kenny.its.monash.edu.au[130.194.13.164] X-Barracuda-Start-Time: 1344213036 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.104802 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Hi Ken, Noticed you begun packaging work for the pcpqa tree about a month ago, adding initial support for Debian packages. I'd like to extend that to the other platforms too. However, I'm wondering whether we should bring pcpqa back into the main pcp tree at this point though, as this will allow us to make use of the build infrastructure from there, instead of having to continue to duplicate packaging scripts, etc. [ If noone disagrees, I'll look into importing the tree in such a way that the change history can be maintained. ] We should also consider the pcp-gui/qa tests which exercise pmchart, pmdumptext and friends - that build could also produce packages for automated testing. cheers. -- Nathan From kenj@internode.on.net Wed Aug 8 05:27:54 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,J_CHICKENPOX_44, J_CHICKENPOX_54 autolearn=no version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q78ARrS2242941 for ; Wed, 8 Aug 2012 05:27:54 -0500 X-ASG-Debug-ID: 1344421670-04bdf0345411d380001-S8gJnT Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id EtvPEax3hvVHEOsv for ; Wed, 08 Aug 2012 03:27:51 -0700 (PDT) X-Barracuda-Envelope-From: kenj@internode.on.net X-Barracuda-Apparent-Source-IP: 150.101.137.141 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApIBADA+IlB20a5b/2dsb2JhbAANOIYBtysEgQEGAiYCUx+vBG6TJYEhiXGDRIIKgRIDqEk Received: from ppp118-209-174-91.lns20.mel6.internode.on.net (HELO [192.168.1.101]) ([118.209.174.91]) by ipmail04.adl6.internode.on.net with ESMTP; 08 Aug 2012 19:57:49 +0930 Message-ID: <1344421668.18761.0.camel@bozo-laptop.localdomain> Subject: pcpqa updates From: Ken McDonell X-ASG-Orig-Subj: pcpqa updates To: pcp@oss.sgi.com Date: Wed, 08 Aug 2012 20:27:48 +1000 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-Barracuda-Connect: ipmail04.adl6.internode.on.net[150.101.137.141] X-Barracuda-Start-Time: 1344421671 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.105034 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcpqa.git 019 | 59 +++++-- 022 | 51 +++++- 022.irix.0 | 2 022.irix.1 | 2 022.linux | 2 022.linux.1 | 2 022.linux.2 | 2 044 | 45 ++++- 074 | 46 +++++ 096 | 47 ++++- 111 | 49 +++++- 114 | 52 +++++- 262 | 92 ++++++++--- 262.linux.nosocks | 24 +++ 308 | 51 +++++- 361 | 42 +++-- 361.out.2 | 82 +++++----- 375.darwin.2 | 187 +++++++++++++++++++++++ 390 | 49 +++++- 430 | 1 512 | 3 520 | 31 +++ 520.out | 6 580 | 41 ++++- Makepkgs | 4 debian/rules | 18 ++ group | 41 +++-- src-oss/.gitignore | 1 src-oss/GNUmakefile | 2 src-oss/slow_pdu.c | 412 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 30 files changed, 1268 insertions(+), 178 deletions(-) commit 2d09451ed94910e96dea788512eb8e46195da2f8 Author: Ken McDonell Date: Wed Aug 8 20:22:50 2012 +1000 assorted - linux -> linux+proc PMDA split These changes allow all QA test to work on Linux in each of the following configurations: - classical proc metrics in the linux PMDA - proc PMDA split from linux PMDA, and proc PMDA installed - proc PMDA split from linux PMDA, and proc PMDA _not_ installed commit 4d917f155847ef1799a6454a98df16be5bff1148 Author: Ken McDonell Date: Wed Aug 8 20:13:48 2012 +1000 packaging - another interim checkin Packaging is _not_ working yet. commit e3fbf0bafd28fbc45f99940bfaa087729d0afc02 Author: Ken McDonell Date: Wed Aug 8 20:12:28 2012 +1000 512 - need to handle $PIECFLAGS now commit cd9c04795f2dbcd0b83cbcaf8a749d637d8f3f3f Author: Ken McDonell Date: Wed Aug 8 20:02:44 2012 +1000 520 (new) - simulate behaviour of slow client Checking behaviour when incoming PDU is slowed down and broken up. commit 619b8add9f761dba419d645c40dca68ab42029e6 Author: Ken McDonell Date: Wed Aug 8 19:57:42 2012 +1000 430 - fix handling of comment lines in /etc/hosts lines like this #myhost myhost were confusing the script. commit 1d5b3d523c53824316a161229c298d64d3156919 Merge: f6bd860 0473868 Author: Ken McDonell Date: Wed Aug 8 17:16:07 2012 +1000 Merge branch 'master' of git://oss.sgi.com/pcp/pcpqa Conflicts: group commit f6bd86060920b8df380d3e1ad0c1ad78dac4464c Author: Ken McDonell Date: Wed Aug 8 17:14:23 2012 +1000 group - review pmda.proc group assignments From wwwrun@oss.sgi.com Wed Aug 8 05:29:39 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,BAYES_00, J_CHICKENPOX_35 autolearn=no version=3.4.0-r929098 Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q78ATdUe243265 for ; Wed, 8 Aug 2012 05:29:39 -0500 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id q78ATdfe243264; Wed, 8 Aug 2012 05:29:39 -0500 Date: Wed, 8 Aug 2012 05:29:39 -0500 From: bugzilla-daemon@oss.sgi.com To: pcp@oss.sgi.com Subject: [Bug 927] New: pcpqa - chk.setup added option to skip sanity tests X-Bugzilla-Reason: CC X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: pcp X-Bugzilla-Component: pcp X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: tdohnale@redhat.com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: mort@sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=927 Summary: pcpqa - chk.setup added option to skip sanity tests Product: pcp Version: unspecified Platform: All OS/Version: Linux Status: NEW Severity: enhancement Priority: P3 Component: pcp AssignedTo: mort@sgi.com ReportedBy: tdohnale@redhat.com CC: pcp@oss.sgi.com Estimated Hours: 0.5 Classification: Unclassified Created an attachment (id=306) --> (http://oss.sgi.com/bugzilla/attachment.cgi?id=306) patch for chk.setup file Hi, I am working on automating pcpqa testsuite (viz bug 918) but I had trouble with script chk.setup, where in final phase there are sanity questions and they need to be answered. That is why I have made a patch, which adds options -f and -h to the script chk.setup, where -f force to skip sanity questions and -h writes brief usage message. Suggestions are welcomed! -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. From wwwrun@oss.sgi.com Wed Aug 8 19:25:11 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,BAYES_00, J_CHICKENPOX_35 autolearn=no version=3.4.0-r929098 Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q790PBhY091496 for ; Wed, 8 Aug 2012 19:25:11 -0500 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id q790PBnt091495; Wed, 8 Aug 2012 19:25:11 -0500 Date: Wed, 8 Aug 2012 19:25:11 -0500 Message-Id: <201208090025.q790PBnt091495@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: pcp@oss.sgi.com Subject: [Bug 927] pcpqa - chk.setup added option to skip sanity tests X-Bugzilla-Reason: CC X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: pcp X-Bugzilla-Component: pcp X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: nathans@debian.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: mort@sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: CC In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=927 Nathan Scott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nathans@debian.org --- Comment #1 from Nathan Scott 2012-08-08 19:25:09 CST --- Hi Tomas, If you run "yes | ./chk.setup" I think you wont need that change? That approach seems to work for me anyway. cheers. -- Nathan -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. From ndsco1@student.monash.edu Wed Aug 8 21:31:02 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q792V1Md109557 for ; Wed, 8 Aug 2012 21:31:02 -0500 X-ASG-Debug-ID: 1344479459-04bdf03454160f70001-S8gJnT Received: from kenny.its.monash.edu.au (kenny.its.monash.edu.au [130.194.13.164]) by cuda.sgi.com with ESMTP id pkXRvNw5fM6ceTDD for ; Wed, 08 Aug 2012 19:31:00 -0700 (PDT) X-Barracuda-Envelope-From: ndsco1@student.monash.edu X-Barracuda-Apparent-Source-IP: 130.194.13.164 Received: from chapman.its.monash.edu.au ([130.194.13.89]) by kenny.its.monash.edu.au (Sun Java System Messaging Server 6.2-4.03 (built Sep 22 2005)) with ESMTP id <0M8G00GDUUZMDF00@kenny.its.monash.edu.au> for pcp@oss.sgi.com; Thu, 09 Aug 2012 12:30:58 +1000 (EST) Received: from chapman.its.monash.edu.au (localhost.localdomain [127.0.0.1]) by localhost (Postfix) with SMTP id 6F66F7E61FB for ; Thu, 09 Aug 2012 12:30:58 +1000 (EST) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by chapman.its.monash.edu.au (Postfix) with ESMTPS id E413A7E6153 for ; Thu, 09 Aug 2012 12:30:57 +1000 (EST) Received: by mail-pb0-f54.google.com with SMTP id rp2so79270pbb.41 for ; Wed, 08 Aug 2012 19:30:57 -0700 (PDT) Received: by 10.68.217.40 with SMTP id ov8mr120193pbc.131.1344479457423; Wed, 08 Aug 2012 19:30:57 -0700 (PDT) Received: by 10.68.44.135 with HTTP; Wed, 08 Aug 2012 19:30:57 -0700 (PDT) Date: Thu, 09 Aug 2012 12:30:57 +1000 From: Nathan Scott Subject: pcp updates Sender: ndsco1@student.monash.edu X-ASG-Orig-Subj: pcp updates To: pcp Message-id: MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type:x-gm-message-state; bh=pyouIrhn4hKCLeIyIVdVZYvesgLHV/h9JYNl2cAdG+c=; b=Dl3tAjMV/aKF50i3qcTGsOMHlky/K0VXeuSijZzA8u6xbLV2agr6zg2H2qQIImA0x9 88B4wxqrpUxZdNLhNYO2fo92B5slz2ehXeOfEgSsjw7oKf0kdMlve3335sAuF7+XzHA3 sJWxWjL9nxxOb2H66Nd5ksQtuNUjbbjSuivQDCDMKLnTvbjtxXJwgio8MKAmbAKuc4gD cdgMDm+wiSKh+92Iji2jjKyIxsS2UIscAvhWpOxvKzGG7hpjQuZvniomu5ArcBsarH3a OpUcu50y1aCAIxry+FbJtNT0Vy4B5mTFv/mewMahJFgxQRYohOjZPZgY7sQXdSO7r3EC 5fCA== X-Google-Sender-Auth: _6TR4M8obQirIi7owPod0_bp7hE X-Gm-Message-State: ALoCoQk6vHNCFRNsvmlioJCjTvEWsnG5EUIYMaK4G5HAmF+sblfxlBJnWzcHzuDezf5PuEq+o/U/ X-Barracuda-Connect: kenny.its.monash.edu.au[130.194.13.164] X-Barracuda-Start-Time: 1344479459 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.105098 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp.git dev src/pmdas/bash/event.c | 6 ++---- src/pmdas/bash/event.h | 2 ++ 2 files changed, 4 insertions(+), 4 deletions(-) commit dfcb28c585aac143d133610e7802820b519a5a19 Author: Nathan Scott Date: Thu Aug 9 12:25:54 2012 +1000 Fix pmdabash build on Mac OS X, really this time. From mgoodwin@redhat.com Wed Aug 8 22:02:03 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q79323sL113183 for ; Wed, 8 Aug 2012 22:02:03 -0500 X-ASG-Debug-ID: 1344481322-04cb6c3c731441d0001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id 75Tnr1HV0liRnzbw for ; Wed, 08 Aug 2012 20:02:02 -0700 (PDT) X-Barracuda-Envelope-From: mgoodwin@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q79321e1030371 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 8 Aug 2012 23:02:01 -0400 Received: from fletch.usersys.redhat.com (vpn1-50-145.bne.redhat.com [10.64.50.145]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q793202p021596 for ; Wed, 8 Aug 2012 23:02:01 -0400 Message-ID: <50232827.1050208@redhat.com> Date: Thu, 09 Aug 2012 13:01:59 +1000 From: Mark Goodwin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: pcp Subject: pcp updates Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-ASG-Orig-Subj: pcp updates Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1344481322 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com Changes committed to git://oss.sgi.com/markgw/pcp/pcp.git dev (note: 'dev' branch since my proc_pmda branch has been merged to dev now) commit d773da935c9b78f08baf2f4dfb25751dae0aa97b Author: Mark Goodwin Date: Thu Aug 9 12:57:38 2012 +1000 For the proc PMDA, don't build or install help.{dat,pag} since these are built from 'help' when ./Install is run. modified: src/pmdas/linux_proc/GNUmakefile From wwwrun@oss.sgi.com Thu Aug 9 03:32:48 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,BAYES_00, J_CHICKENPOX_35 autolearn=no version=3.4.0-r929098 Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q798Wmed141348 for ; Thu, 9 Aug 2012 03:32:48 -0500 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id q798Wmhv141347; Thu, 9 Aug 2012 03:32:48 -0500 Date: Thu, 9 Aug 2012 03:32:48 -0500 Message-Id: <201208090832.q798Wmhv141347@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: pcp@oss.sgi.com Subject: [Bug 927] pcpqa - chk.setup added option to skip sanity tests X-Bugzilla-Reason: CC X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: pcp X-Bugzilla-Component: pcp X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: tdohnale@redhat.com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: mort@sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=927 --- Comment #2 from Tomas Dohnalek 2012-08-09 03:32:47 CST --- Oh, thanks. Your approach is more straightforward, I will use it. Thanks Tomas -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. From wwwrun@oss.sgi.com Thu Aug 9 19:22:53 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=ALL_TRUSTED,BAYES_00, J_CHICKENPOX_35,J_CHICKENPOX_63 autolearn=no version=3.4.0-r929098 Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7A0MrHJ244009 for ; Thu, 9 Aug 2012 19:22:53 -0500 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id q7A0MrkP244008; Thu, 9 Aug 2012 19:22:53 -0500 Date: Thu, 9 Aug 2012 19:22:53 -0500 Message-Id: <201208100022.q7A0MrkP244008@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: pcp@oss.sgi.com Subject: [Bug 927] pcpqa - chk.setup added option to skip sanity tests X-Bugzilla-Reason: CC X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: pcp X-Bugzilla-Component: pcp X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: nathans@debian.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: mort@sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status Resolution Remaining Hours In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=927 Nathan Scott changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED Remaining Hours|0.5 |0.0 --- Comment #3 from Nathan Scott 2012-08-09 19:22:51 CST --- OK, thanks Tomas, I'll close the bug out then. Might be worth noting that I'm looking into producing RPMs of the pcp and pcp-gui qa testsuites - these will arrive in the not-too-distant future (probably pcp-3.6.6 and pcp-gui-1.5.7). cheers. -- Nathan -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. From nscott@redhat.com Fri Aug 10 01:31:12 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7A6VC7f024256 for ; Fri, 10 Aug 2012 01:31:12 -0500 X-ASG-Debug-ID: 1344580267-04bdf034571bae00001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id jh3GPRFtWgl8b8BF for ; Thu, 09 Aug 2012 23:31:08 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7A6V6Ol011315 for ; Fri, 10 Aug 2012 02:31:06 -0400 Date: Fri, 10 Aug 2012 02:31:06 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1299723618.10092749.1344580266713.JavaMail.root@redhat.com> Subject: pcp updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.50.184] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1344580268 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.105210 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp.git dev build/rpm/.gitignore | 2 ++ src/pmdas/bash/event.c | 2 +- src/pmdas/bash/event.h | 1 + src/pmdas/bash/pmda.c | 7 +++++-- 4 files changed, 9 insertions(+), 3 deletions(-) commit 857ac96f60676c74fb869fb9737d47decc8af12c Merge: 649b2d8 89af63b Author: Nathan Scott Date: Fri Aug 10 16:28:45 2012 +1000 Merge branch 'dev' of ssh://verge/source/git/pcp into dev commit 649b2d80df4732e5734046217eba9b9aec66ead1 Author: Nathan Scott Date: Fri Aug 10 16:25:45 2012 +1000 Add generated files from rpm build into gitignore commit 89af63bedbf2d2acfb1def8259f823676a3ff1c7 Author: Nathan Scott Date: Fri Aug 10 13:19:21 2012 +1000 Complete the final event timestamp capture for pmdabash. From kenj@internode.on.net Sun Aug 12 21:12:33 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,J_CHICKENPOX_35 autolearn=no version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7D2CWuO197303 for ; Sun, 12 Aug 2012 21:12:32 -0500 X-ASG-Debug-ID: 1344823948-04bdf0345535c810001-S8gJnT Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id YzNRMCG9r65MbM8s; Sun, 12 Aug 2012 19:12:29 -0700 (PDT) X-Barracuda-Envelope-From: kenj@internode.on.net X-Barracuda-Apparent-Source-IP: 150.101.137.141 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAFlhKFB20a5b/2dsb2JhbAANN4YBtyABAQQjVhALGgImAgJXGatYbpIOgSGNBoIKgRIDlUuTAQ Received: from ppp118-209-174-91.lns20.mel6.internode.on.net (HELO [192.168.1.100]) ([118.209.174.91]) by ipmail04.adl6.internode.on.net with ESMTP; 13 Aug 2012 11:42:27 +0930 Message-ID: <1344824184.7251.67.camel@bozo.localdomain> Subject: Re: [pcp] [Bug 927] New: pcpqa - chk.setup added option to skip sanity tests From: Ken McDonell X-ASG-Orig-Subj: Re: [pcp] [Bug 927] New: pcpqa - chk.setup added option to skip sanity tests To: bugzilla-daemon@oss.sgi.com Cc: pcp@oss.sgi.com Date: Mon, 13 Aug 2012 12:16:24 +1000 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-Barracuda-Connect: ipmail04.adl6.internode.on.net[150.101.137.141] X-Barracuda-Start-Time: 1344823949 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_MISMATCH_TO X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.105480 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 BSF_SC0_MISMATCH_TO Envelope rcpt doesn't match header Tomas and Nathan, Could I suggest that we start a thread at pcp@oss.sgi.com to discuss how packaging and automated QA should work? We have Tomas, Nathan and I following various lines of attack, and I think consensus is not hard, and would probably minimize wasted effort. From nscott@redhat.com Mon Aug 13 00:02:01 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,J_CHICKENPOX_53 autolearn=no version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7D5203U216651 for ; Mon, 13 Aug 2012 00:02:00 -0500 X-ASG-Debug-ID: 1344834118-04bdf03454363ed0001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id kPQAdnfQQ2YsL9Q0 for ; Sun, 12 Aug 2012 22:01:58 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7D51vZK015302 for ; Mon, 13 Aug 2012 01:01:58 -0400 Date: Mon, 13 Aug 2012 01:01:57 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1630269602.14479461.1344834117843.JavaMail.root@redhat.com> In-Reply-To: <1575084309.14389258.1344830494284.JavaMail.root@redhat.com> Subject: Installable packages for pcp and pcp-gui QA tests MIME-Version: 1.0 X-ASG-Orig-Subj: Installable packages for pcp and pcp-gui QA tests Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.50.150] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1344834118 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.10 X-Barracuda-Spam-Status: No, SCORE=0.10 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA085 X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.105492 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.10 BSF_SC0_SA085 Custom Rule SA085 Hi all, I have been looking a bit into producing installable (RPM, DEB and sources for starters) packages for the PCP tests. The goals are: - simplify use in automated testing scenarios (esp. with many hosts and with non-pcp-developers testing); - better identify the PCP tree that the tests are expected to work with; - reuse existing packaging scripts/makefiles/configure goo wherever possible rather than creating new variants; - ensure developers know where new tests should reside (so IMO, having the tests separate to the source package and git tree is suboptimal). There are several issues around potential changes to the location of the tests themselves to aid this effort, and its not clear on an ideal solution. In discussing this, I propose that we ignore the historical baggage around some of the (original) tests not being available outside SGI, from IRIX/closed-PCP land, and we just focus on the ideal long-term solution for open source PCP. The current situation is: - A pcpqa.git tree exists containing all of the core PCP QA tests. On the surface it has loose association with any PCP release, and there's a mechanism allowing it to work for different PCP versions. However, I've found several of the tests to have *deep* knowledge of internals of PCP, and they can break in non-intuitive ways when the planets are not aligned. - Ken did some initial work on the pcpqa tree a couple of months back & it can now be made produces a .deb package. - The pcp-gui.git tree has pmchart, libqmc and pmdumptext tests. There is no packaging done for these yet. This situation is largely for historical reasons; originally pcpqa was part of the pcp source tree (in pcp/qa, as it is in the pcp-gui tree) and thats how I'd prefer to see it end up once again. I'm proposing the following: - Merge pcpqa back into the core pcp tree, in the qa subdir (where it historically lived). - Produce an additional package from each Makepkgs (or distro spec files) which can install the test scripts, binaries, archives, etc into a suitable location and also create a pcpqa user automatically if none exists. If that's generally accepted as a step forward, then there seem to be three options for merging pcpqa back to pcp/qa and producing extra packages from the build: - use a git submodule https://git.wiki.kernel.org/index.php/GitSubmoduleTutorial - use a git subtree merge http://nuclearsquid.com/writings/subtree-merging-and-you/ - ditch the history, just copy everything over and commit, resetting the clock on all qa tests. I vastly favour the second option for simplicity - I'd like to end up with one pcp tree again at the end, and have the same model for both pcp and pcp-gui. The submodule approach seemed good at first, but theres extra commands for all devs to use which makes it seem just a bit too fiddly for me. If there's noone who perceives value in keeping the history we have (I'm not overly fussed) option 3 is quickest. :-) As an example of other projects doing similar things - refer to samba4, puppet, and mysql which all produce a -testsuite package as part of their regular Debian distro builds. In Fedora, there's systemtap as well doing similar things, and others. Thoughts? Thanks for reading this far! cheers. -- Nathan From kenj@internode.on.net Mon Aug 13 01:32:59 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,J_CHICKENPOX_53 autolearn=no version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7D6WxrR225698 for ; Mon, 13 Aug 2012 01:32:59 -0500 X-ASG-Debug-ID: 1344839576-04cb6c3c7033c190001-S8gJnT Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id WrfUyh5RCWkeXqWl for ; Sun, 12 Aug 2012 23:32:57 -0700 (PDT) X-Barracuda-Envelope-From: kenj@internode.on.net X-Barracuda-Apparent-Source-IP: 150.101.137.141 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAI2eKFBukNqx/2dsb2JhbAANNoYBtx4BAQEEI1YQCw0FBgICJgICSQ4Gq3dukiqBIY8QgRIDm0mNAw Received: from unknown (HELO [10.247.43.184]) ([110.144.218.177]) by ipmail04.adl6.internode.on.net with ESMTP; 13 Aug 2012 16:02:54 +0930 Message-ID: <1344839571.4440.15.camel@bozo-laptop.localdomain> Subject: Re: [pcp] Installable packages for pcp and pcp-gui QA tests From: Ken McDonell X-ASG-Orig-Subj: Re: [pcp] Installable packages for pcp and pcp-gui QA tests To: Nathan Scott Cc: pcp@oss.sgi.com Date: Mon, 13 Aug 2012 16:32:51 +1000 In-Reply-To: <1630269602.14479461.1344834117843.JavaMail.root@redhat.com> References: <1630269602.14479461.1344834117843.JavaMail.root@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-Barracuda-Connect: ipmail04.adl6.internode.on.net[150.101.137.141] X-Barracuda-Start-Time: 1344839576 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.105498 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Thanks for kicking this off Nathan. On Mon, 2012-08-13 at 01:01 -0400, Nathan Scott wrote: > Hi all, > > ... > The current situation is: > - A pcpqa.git tree exists containing all of the core PCP QA > tests. On the surface it has loose association with any > PCP release, and there's a mechanism allowing it to work > for different PCP versions. However, I've found several > of the tests to have *deep* knowledge of internals of PCP, > and they can break in non-intuitive ways when the planets > are not aligned. I think this is an example of a brain failure on my part, not a reason for merging the trees. I should have done a better job of isolating the PCP version dependencies in the test artefacts that you tripped up on. These are a very small minority of the total number of test artefacts. Because PCP follows a fundamentally a client-server architecture it is absolutely critical that the QA components are _not_ exposed to version dependencies but rather accommodate version differences so that cross-version inter-operation can be tested, e.g. new clients with old pmcd and vice versa. If merging the trees encourages (even implicitly) the creation of a version of the QA packages that _only_ work with the same version of the PCP packages then that would be a bad thing(tm) ... if QA continues to be multi-version aware, then that would be a good thing(tm). > - Ken did some initial work on the pcpqa tree a couple of > months back & it can now be made produces a .deb package. I stopped work on this when I could not decide what the QA package should contain: a) compiled binaries and scripts, or b) source and scripts. a) means you need one package for each QA platform of interest. Since some of the tests require a toolchain (not may I agree), b) seems simpler, means only one package for all platforms, and using tar to package this would be simpler as we'd avoid all of the uglier parts of the packaging "gooiness". > ... > I vastly favour the second option for simplicity - I'd like > to end up with one pcp tree again at the end, and have the > same model for both pcp and pcp-gui. Other than my issue above, I don't really mind. I think it is highly desirable to preserve the git history. The one other "big" issue to be discussed is _what_ does unattended QA really mean? I think I'd vote for a scheme where we had tests in the QA suite that were _not_ run as part of the unattended run, so that we could avoid the more difficult of the QA setup issues (like a working X server, a close Cisco router, ...) ... and this would make much of Tomas' issues with the setup checks just go away. From nscott@redhat.com Mon Aug 13 02:30:54 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7D7UscQ232229 for ; Mon, 13 Aug 2012 02:30:54 -0500 X-ASG-Debug-ID: 1344843050-04bdf0345436b0b0001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id FS5YkC6sgoYWL2ce for ; Mon, 13 Aug 2012 00:30:50 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7D7UkUM019099; Mon, 13 Aug 2012 03:30:46 -0400 Date: Mon, 13 Aug 2012 03:30:46 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Ken McDonell Cc: pcp@oss.sgi.com Message-ID: <806124905.14747325.1344843046124.JavaMail.root@redhat.com> In-Reply-To: <1344839571.4440.15.camel@bozo-laptop.localdomain> Subject: Re: [pcp] Installable packages for pcp and pcp-gui QA tests MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] Installable packages for pcp and pcp-gui QA tests Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.50.150] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1344843050 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.105502 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Hi Ken, > > for different PCP versions. However, I've found several > > of the tests to have *deep* knowledge of internals of PCP, > > and they can break in non-intuitive ways when the planets > > are not aligned. > > Because PCP follows a fundamentally a client-server architecture it > is absolutely critical that the QA components are _not_ exposed to > version > dependencies but rather accommodate version differences so that > cross-version inter-operation can be tested, e.g. new clients with > old pmcd and vice versa. Right. We're definitely on the same page there. This always was the case (even before, when pcp and pcpqa were one and the same tree), and I'm 100% agreeing this must remain the case. But there's another problem - while the remote interactions must allow for different versions to be tested together, I don't think it makes sense to run pcpqa binaries built for one libpcp to run with newer or older libpcp variants. That's what bit me, and what I'd like to prevent from happening. For example, line 67 in this test source file: http://oss.sgi.com/cgi-bin/gitweb.cgi?p=pcp/pcpqa.git;a=blob;f=src-oss/descreqX2.c;h=ed8fb2b8c758c75a550f149fe788408b1f6f3b98;hb=HEAD makes use of (IMO) a valid (for a test) piece of knowledge about the offset of a field within an internal libpcp data structure. That is not exposed via the PMAPI, but should be tested. Changes within the (internal) context structure prevent a libpcp-3.6.5 (for example) to work with a pcp-testsuite-2.0.0 (once that exists). So, I really want the QA binaries from a build to match with libpcp (and libpcp_pmda.so, and the rest, of course), and I would like the native package manager for each platform to ensure that. I think it is too much to expect the test authors to be able to get the version checks right manually for the descreqX2.c case above (in fact it may not be possible, for that case). > If merging the trees encourages (even implicitly) the creation of a > version of the QA packages that _only_ work with the same version of > the > PCP packages then that would be a bad thing(tm) ... if QA continues > to > be multi-version aware, then that would be a good thing(tm). Yep, agreed and agreed. > > - Ken did some initial work on the pcpqa tree a couple of > > months back & it can now be made produces a .deb package. > > I stopped work on this when I could not decide what the QA package > should contain: > a) compiled binaries and scripts, or > b) source and scripts. > > a) means you need one package for each QA platform of interest. Yes, a/ is my plan. And its greatly simplified when the qa package comes into existance at the same time as the pcp package its built for. With b/ I'd be very concerned about relying on "make" to get descreqX2.c compiled correctly every time. > > Since some of the tests require a toolchain (not may I agree), b) > seems > simpler, means only one package for all platforms, and using tar to > package this would be simpler as we'd avoid all of the uglier parts > of the packaging "gooiness". Not really agreeing there - tar is not going to work for managing new versions of the tests. Example above again (descreqX2.c) for "why". > > ... > > I vastly favour the second option for simplicity - I'd like > > to end up with one pcp tree again at the end, and have the > > same model for both pcp and pcp-gui. > > Other than my issue above, I don't really mind. I think it is highly > desirable to preserve the git history. OK. > The one other "big" issue to be discussed is _what_ does unattended > QA > really mean? I think I'd vote for a scheme where we had tests in the > QA > suite that were _not_ run as part of the unattended run, so that we > could avoid the more difficult of the QA setup issues (like a working > X > server, a close Cisco router, ...) ... and this would make much of > Tomas' issues with the setup checks just go away. Yes, I think that's fine. For me now I'm most concerned with getting the right pcp qa binaries on the right platforms, with the right versions of libpcp[_pmda] (locally), where the matrix of test platforms is already very large and growing. cheers. -- Nathan From nscott@redhat.com Wed Aug 15 00:32:13 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7F5WC8K081241 for ; Wed, 15 Aug 2012 00:32:13 -0500 X-ASG-Debug-ID: 1345008730-04bdf034564a07d0001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id rD32K0UZ72OTEZ9h for ; Tue, 14 Aug 2012 22:32:10 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7F5WAJs027784 for ; Wed, 15 Aug 2012 01:32:10 -0400 Date: Wed, 15 Aug 2012 01:32:10 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1597138545.21226826.1345008730069.JavaMail.root@redhat.com> Subject: pcp-gui updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp-gui updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.50.135] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1345008730 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.105686 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp-gui.git dev .gitignore | 6 +++++- GNUmakefile | 4 ++-- build/.gitignore | 2 ++ build/rpm/.gitignore | 1 + build/rpm/pcp-gui.spec.in | 35 +++++++++++++++++++++++++++-------- build/tar/.gitignore | 2 ++ debian/pcp-gui-testsuite.dirs | 15 +++++++++++++++ debian/rules | 19 +++++++++---------- doc/CHANGES | 1 + man/.gitignore | 5 +++++ qa/GNUmakefile | 18 +++++++++++++++--- qa/archives/GNUmakefile | 29 +++++++++++++++++++---------- qa/interact/GNUmakefile | 12 +++++++++--- qa/src/GNUmakefile | 21 ++++++++++++++------- qa/src/dynamic/GNUmakefile | 18 +++++++++++++----- qa/src/qmc_context/GNUmakefile | 9 ++++++--- qa/src/qmc_desc/GNUmakefile | 9 ++++++--- qa/src/qmc_desc/qmc_desc.cpp | 24 ++++-------------------- qa/src/qmc_dynamic/GNUmakefile | 9 ++++++--- qa/src/qmc_format/GNUmakefile | 9 ++++++--- qa/src/qmc_group/GNUmakefile | 9 ++++++--- qa/src/qmc_hosts/GNUmakefile | 9 ++++++--- qa/src/qmc_indom/GNUmakefile | 9 ++++++--- qa/src/qmc_indom/qmc_indom.cpp | 12 ++---------- qa/src/qmc_metric/GNUmakefile | 9 ++++++--- qa/src/qmc_source/GNUmakefile | 9 ++++++--- qa/views/GNUmakefile | 12 +++++++++--- src/query/GNUmakefile | 5 +---- src/time/GNUmakefile | 8 ++------ 29 files changed, 211 insertions(+), 119 deletions(-) commit 1c737e85ff4cb4707ea59a0b307123a20964c8b7 Author: Nathan Scott Date: Wed Aug 15 15:28:11 2012 +1000 Build installable pcp-gui-testsuite packages for QA Update makefiles in pcp-gui/qa subtrees to install the QA scripts and binaries onto a target system in a known place. This covers both rpm and deb builds. Also updated several .gitignore files while at it and removed some ancient, no-longer-needed rpm spec file snippets. commit c23d36fa5e634212b08d17c5ff0d118959728002 Author: Nathan Scott Date: Wed Aug 15 13:58:15 2012 +1000 Descend into qa SUBDIR as part of regular building. This allows the test scripts and sources to become part of the source tarballs, and will allow binary packaging of the testsuite in upcoming commits. commit f7b36d47a6d15a05226b7d367d9043c9b4f7732c Author: Nathan Scott Date: Wed Aug 15 13:56:20 2012 +1000 Cleanup test sources a bit - further pmid_build use. commit aaf2ddf537cb0fb22a708eae40a90ac515b54a9d Author: Nathan Scott Date: Wed Aug 15 13:54:26 2012 +1000 Slight simplification in time/query makefile install targets commit d31702f0577487599043a31172657df962bb2f6d Author: Nathan Scott Date: Sun Aug 5 18:41:29 2012 +1000 Fix compilation warnings in qa test sources. From nscott@redhat.com Wed Aug 15 02:27:48 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7F7Rm3h092947 for ; Wed, 15 Aug 2012 02:27:48 -0500 X-ASG-Debug-ID: 1345015666-04cbb050ce47bb40001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id EqBepL2ZbBU6J2sT for ; Wed, 15 Aug 2012 00:27:46 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7F7Rk0l014788 for ; Wed, 15 Aug 2012 03:27:46 -0400 Date: Wed, 15 Aug 2012 03:27:46 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <181496776.21330192.1345015666058.JavaMail.root@redhat.com> Subject: pcp-gui updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp-gui updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.50.135] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1345015666 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.105694 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp-gui.git dev debian/pcp-gui-testsuite.dirs | 30 +++++++++++++++--------------- debian/rules | 2 +- qa/026 | 6 ++++-- qa/GNUmakefile | 7 +++++-- qa/GNUmakefile.install | 19 +++++++++++++++++++ qa/archives/.gitignore | 8 ++++++++ qa/archives/GNUmakefile | 25 ++++++------------------- qa/archives/GNUmakefile.install | 38 ++++++++++++++++++++++++++++++++++++++ qa/common.check | 19 +++++++++++++++++++ qa/common.filter | 6 +++++- qa/common.sh | 14 +------------- qa/interact/GNUmakefile | 5 +++-- qa/interact/GNUmakefile.install | 1 + qa/src/GNUmakefile | 5 ++++- qa/src/GNUmakefile.install | 1 + qa/src/qmc_context/GNUmakefile | 2 +- qa/src/qmc_desc/GNUmakefile | 2 +- qa/src/qmc_dynamic/GNUmakefile | 2 +- qa/src/qmc_format/GNUmakefile | 2 +- qa/src/qmc_group/GNUmakefile | 2 +- qa/src/qmc_hosts/GNUmakefile | 2 +- qa/src/qmc_indom/GNUmakefile | 2 +- qa/src/qmc_metric/GNUmakefile | 2 +- qa/src/qmc_source/GNUmakefile | 2 +- qa/views/GNUmakefile | 5 +++-- qa/views/GNUmakefile.install | 1 + 26 files changed, 143 insertions(+), 67 deletions(-) commit 2b42b317689966d290b39b71ab0912d7d38710f4 Author: Nathan Scott Date: Wed Aug 15 17:26:03 2012 +1000 Remove assumption about directory structure, allowing packaged QA scripts to work commit bf93b4934327d17cc689bddb7f4d3801f860e8d1 Author: Nathan Scott Date: Wed Aug 15 17:24:45 2012 +1000 Add back in the pmdumptext filter for QA commit 23c315900d35de7e6eb8a4f0eeb3507ba4bce54c Author: Nathan Scott Date: Wed Aug 15 17:24:12 2012 +1000 Use getpmcdhosts from pcp QA install in 026 commit f1bbdc5ea3ee03c1dded9f304c361ab4db7ac24a Author: Nathan Scott Date: Wed Aug 15 17:23:33 2012 +1000 Couple minor tweaks to the Debian packaging for QA commit 70ff5e3eccb0a944e102089011476154ff294a64 Author: Nathan Scott Date: Wed Aug 15 17:22:12 2012 +1000 Rework the installed pcp-gui QA makefiles Need to allow things like archive building on the QA target machine, but having to allow QA applications to build is a bit much. So install some minimalist makefiles using the GNUmakefile.install idiom. From nscott@redhat.com Wed Aug 15 02:55:03 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7F7t3w4096100 for ; Wed, 15 Aug 2012 02:55:03 -0500 X-ASG-Debug-ID: 1345017301-04cb6c3c73486d70001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id fvdOYkB1Rni1Apbz for ; Wed, 15 Aug 2012 00:55:01 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7F7t1vV009858 for ; Wed, 15 Aug 2012 03:55:01 -0400 Date: Wed, 15 Aug 2012 03:55:01 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <136414073.21370121.1345017301216.JavaMail.root@redhat.com> Subject: pcp-gui updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp-gui updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.50.135] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1345017301 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.105696 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp-gui.git dev qa/006.out | 66 ++++++++++++++++++++++++++++++++++++--------------------- qa/008.out | 14 ++++++------ qa/009 | 4 +++ qa/023 | 4 +++ qa/GNUmakefile | 2 - 5 files changed, 58 insertions(+), 32 deletions(-) commit f08331dc14d3ddda29cbc1e68492c97b6f5c639d Author: Nathan Scott Date: Wed Aug 15 17:53:52 2012 +1000 Allow 009 and 023 to work in the absence of proc metrics commit ee574d8d7ffa4e1ab2b0aac2c13dfcded4743ab4 Author: Nathan Scott Date: Wed Aug 15 17:53:36 2012 +1000 Remake 006 and 008 output after pmchart diagnostic changes commit 3d65e96cfceff5b51b73062a596939bb989c8d2a Author: Nathan Scott Date: Wed Aug 15 17:41:26 2012 +1000 Ensure all common scripts are picked up in QA packages. From nscott@redhat.com Thu Aug 16 05:23:11 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7GANBHB100815 for ; Thu, 16 Aug 2012 05:23:11 -0500 X-ASG-Debug-ID: 1345112589-04cbb050ce54b180001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id MkTBMNe59jhVCWbO for ; Thu, 16 Aug 2012 03:23:09 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7GAN5IL025827; Thu, 16 Aug 2012 06:23:05 -0400 Date: Thu, 16 Aug 2012 06:23:05 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Ken McDonell Cc: pcp@oss.sgi.com Message-ID: <668585777.24333305.1345112585438.JavaMail.root@redhat.com> In-Reply-To: <806124905.14747325.1344843046124.JavaMail.root@redhat.com> Subject: Re: [pcp] Installable packages for pcp and pcp-gui QA tests MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] Installable packages for pcp and pcp-gui QA tests Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.50.212] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1345112589 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.105802 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Hi Ken, ----- Original Message ----- > > > for different PCP versions. However, I've found several > > > of the tests to have *deep* knowledge of internals of PCP, > > > and they can break in non-intuitive ways when the planets > > > are not aligned. > > > > Because PCP follows a fundamentally a client-server architecture it > > is absolutely critical that the QA components are _not_ exposed to > > version > > dependencies but rather accommodate version differences so that > > cross-version inter-operation can be tested, e.g. new clients with > > old pmcd and vice versa. > > Right. We're definitely on the same page there. This always was the > case (even before, when pcp and pcpqa were one and the same tree), > and I'm 100% agreeing this must remain the case. > > But there's another problem ... So, I'm plowing ahead with setting up these package builds. I merged in the pcp-gui packaging changes earlier today, which now produces a pcp-gui-testsuite packages (deb/rpm). All seemed to go fairly well, and actually there's at least one genuine failure in there (027) which we've missed thanks to pcp-gui being a bit forgotten about of late. Since its you and I who do most of the pcpqa work at the moment anyway I think we can go ahead with a merge, keeping in mind version issues. It is still possible to run in-tree QA of course and for different PCP versions locally if need be. To that end, I'll begin merging pcpqa back into pcp/qa in the main PCP tree shortly, in order to keep the packaging moving forward. I think we'll still have some fine-tuning to do around whether sources need to be in the binary package (rpmlint will complain at least), and once we have something concrete we can make further informed decisions. If it all turns out to be a horrible nightmare (?!), we can always undo it. cheers. -- Nathan From nscott@redhat.com Thu Aug 16 07:02:02 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7GC21jx114499 for ; Thu, 16 Aug 2012 07:02:02 -0500 X-ASG-Debug-ID: 1345118516-04bdf034575aed60001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id vvO7SZOsKVLoERwS for ; Thu, 16 Aug 2012 05:01:59 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7GC1u0h010983 for ; Thu, 16 Aug 2012 08:01:56 -0400 Date: Thu, 16 Aug 2012 08:01:56 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1395102063.24527593.1345118516783.JavaMail.root@redhat.com> In-Reply-To: <286080257.24457720.1345116280543.JavaMail.root@redhat.com> Subject: pcp updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.50.212] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1345118519 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.105808 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- [this change actually merges the pcpqa tree - incl full git history - back into pcp/qa in the dev branch - I've omitted all that history from the diffstat & changelog reported here though] Changes committed to git://oss.sgi.com/pcp/pcp.git dev GNUmakefile | 4 build/rpm/.gitignore | 2 build/rpm/pcp.spec.in | 48 +++++- debian/GNUmakefile | 12 + debian/control | 8 + debian/libpcp3-dev.dirs | 2 debian/pcp-testsuite.dirs | 2 debian/rules | 7 qa/.gitignore | 1 qa/033 | 2 qa/555 | 2 qa/581 | 1 qa/COPYING | 348 -------------------------------------------- qa/GNUmakefile | 49 ++---- qa/Makepkgs | 163 -------------------- qa/group | 1 qa/mk.localconfig | 5 qa/mk.qa_hosts | 4 qa/pmdas/GNUmakefile | 9 - qa/pmdas/bigun/GNUmakefile | 11 - qa/pmdas/broken/GNUmakefile | 12 - qa/qa_hosts.master | 20 -- qa/src-oss/GNUmakefile | 14 + src/libpcp/src/p_text.c | 5 24 files changed, 141 insertions(+), 591 deletions(-) commit 04fa0f3d2c20d5f67e862790db6e26f538db898f Merge: 49d5fa0 34400b3 Author: Nathan Scott Date: Thu Aug 16 11:08:28 2012 +0000 Merge branch 'dev' of git://oss.sgi.com/pcp/pcp into dev commit 34400b38552b4a3297ba5afdff80407d7ecf09cf Author: Nathan Scott Date: Thu Aug 16 16:02:44 2012 +1000 Ensure the __pmDecodeText ident parameter is always set There was one obscure code path where the ident pointer would not be set, if the type from the PDU was not valid, so ensure its always initialised. Situation handled in a similar way to the way __pmEncodeText deals with an unexpected type field (i.e. treat it as an indom). Resolves Red Hat bugzilla bug #841306. commit 62370f3780eb3f14e722b395656f6a45f3672cba Merge: fe51067 857ac96 Author: Nathan Scott Date: Thu Aug 16 09:44:05 2012 +1000 Merge branch 'dev' of ssh://oss.sgi.com/oss/git/pcp/pcp into dev commit 49d5fa0f6128454b7603e44cbea6e9f09963afb4 Author: Nathan Scott Date: Wed Aug 15 21:43:12 2012 +0000 Minor cleanup after pcpqa merge commit ebeee04d45d78876072278771421d85f21b00e82 Author: Nathan Scott Date: Wed Aug 15 10:52:14 2012 +1000 No longer need dup COPYING file in qa commit 7fc1a173e5f4bc1c0c4f27200bec840979f94bc4 Author: Nathan Scott Date: Wed Aug 15 10:44:46 2012 +1000 Cleanup the qa makefile a little - remove unused check Remove the /usr/gnu/bin PATH addition. This can never have worked, since it first tests for the /usr/gnu/bin directory but then adds /usr/gun/bin. Guns don't kill people, Gnus kill people. commit 91c753c0ca9003d95ad3e939fca2f3fe08492ace Author: Nathan Scott Date: Wed Aug 15 09:29:05 2012 +1000 Make realpath binary detection robust in its absence commit 490561759e3eff8bba74a0da347f5583cebeb608 Author: Nathan Scott Date: Wed Aug 15 09:05:58 2012 +1000 Additional filter required for RHEL6 virtual net bridge in test 581 commit fb1b94e1a558af05b82f0d79bdfac1efeefb5039 Author: Nathan Scott Date: Wed Aug 15 09:05:25 2012 +1000 Update 555 to work with the RHEL6 rsyslog pid filename convention commit 16bf9ce579134bbbf688ef3af7f235d32741bd81 Author: Nathan Scott Date: Tue Aug 14 20:17:33 2012 +1000 Packaging updates for PCP QA - pcp-testsuite rpm sub-package Creates an additional sub-package for PCP containing tests, binaries, and archives suitable for QA from non-git installs. This new RPM creates the pcpqa user and group as well. Other tweaks include: - Allow mk.qa_hosts to proceed in a localhost-only mode - Produce a list of outfiles as part of the build, so we know what to install (tricky to detect in case someone has also done a local git tree qa run) - Remove dup'd pcpqa Makepkgs script, now shares pcp one. commit c7d0bf754645fcfdb5fb15179aa286b8229210c4 Author: Nathan Scott Date: Tue Aug 14 13:10:17 2012 +1000 Initial support for building qa packages for pcp-testsuite This folds Ken's initial work on the .deb package format into the grand-unified-theory of packaging for core PCP. commit 857ac96f60676c74fb869fb9737d47decc8af12c Merge: 649b2d8 89af63b Author: Nathan Scott Date: Fri Aug 10 16:28:45 2012 +1000 Merge branch 'dev' of ssh://verge/source/git/pcp into dev commit 649b2d80df4732e5734046217eba9b9aec66ead1 Author: Nathan Scott Date: Fri Aug 10 16:25:45 2012 +1000 Add generated files from rpm build into gitignore From nscott@redhat.com Thu Aug 16 07:02:10 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7GC2ANW114520 for ; Thu, 16 Aug 2012 07:02:10 -0500 X-ASG-Debug-ID: 1345118528-04cb6c3c71571d40001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id Wc6rdbAzpe8DXop2 for ; Thu, 16 Aug 2012 05:02:08 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7GC28lY011007 for ; Thu, 16 Aug 2012 08:02:08 -0400 Date: Thu, 16 Aug 2012 08:02:08 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1866144667.24527629.1345118528444.JavaMail.root@redhat.com> In-Reply-To: <79238204.24400162.1345114484902.JavaMail.root@redhat.com> Subject: pcp updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.50.212] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1345118528 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.105808 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp.git master CHANGELOG | 40 ++++++++-- build/rpm/pcp.spec.in | 4 - debian/changelog | 6 + man/man1/pmcd.1 | 4 - src/libpcp/src/logutil.c | 10 +- src/libpcp/src/p_creds.c | 18 +++- src/libpcp/src/p_desc.c | 12 +++ src/libpcp/src/p_error.c | 25 ++++-- src/libpcp/src/p_fetch.c | 23 ++++- src/libpcp/src/p_instance.c | 57 +++++++++++--- src/libpcp/src/p_lcontrol.c | 51 ++++++++++-- src/libpcp/src/p_lrequest.c | 6 + src/libpcp/src/p_lstatus.c | 5 + src/libpcp/src/p_pmns.c | 115 ++++++++++++++++++++++------ src/libpcp/src/p_profile.c | 65 ++++++++++++---- src/libpcp/src/p_result.c | 167 +++++++++++++++++++++++++++++++----------- src/libpcp/src/p_text.c | 17 ++++ src/libpcp/src/pdu.c | 38 +++++++++ src/libpcp/src/pmns.c | 7 + src/libpcp_trace/src/p_ack.c | 6 + src/libpcp_trace/src/p_data.c | 23 ++++- src/pmcd/src/dofetch.c | 6 + src/pmcd/src/dopdus.c | 34 +++----- src/pmdas/trace/src/trace.c | 6 - 24 files changed, 577 insertions(+), 168 deletions(-) commit fe51067ae869a4d59f350ac319b09edcb77ac8e6 Author: Nathan Scott Date: Tue Aug 14 11:42:49 2012 +1000 Update changelogs for pcp 3.6.5 release. commit 3d5e11bf6a3680c048be9d524a82f35370eb0ad4 Author: Nathan Scott Date: Mon Aug 13 11:28:46 2012 +1000 Correct buffer unpinning logic in a PMNS traversal error path This triggers an assertion failure in pminfo. Redhat bugzilla bug #847314, reported by Florian Weimer of the Redhat Security team. commit d08105f0f36c24e3f6d1e28e6d2289001e03f589 Author: Nathan Scott Date: Mon Aug 13 11:28:46 2012 +1000 Fix a recent regression in log record decoding The routines for decoding log records stored in PCP archives share some code with the live host PDU decoding logic. They make use of __pmDecodeResult, in particular. So, before this change (and with the result decoding fixes), they no longer function because the buffer they pass in for decoding does not have a proper PDU header. Previously this was not a problem, but now the decode routine looks at the PDU header to determine the size of the buffer being decoded. The fix is straight-forward - simply ensure those header fields are initialised appropriately. commit 9ba85dca940de976176ce196fd5e3c4170936354 Author: Ken McDonell Date: Mon Aug 13 11:28:46 2012 +1000 Resolve event-driven programming flaw in pmcd Fix an issue where a misbehaving client could prevent pmcd from responding to other legitimate requests. Now uses a dead-hand timer to ensure a client does not feed tiny pieces of PDUs into pmcd, preventing service to genuine clients. Original report and fixes reviewed by Florian Weimer of the Red Hat Security team. Red Hat bugzilla bug #841706. Security advisory CVE-2012-3421. commit 68fb968b4ee635bb301dc9ab64e633b0d66d27b4 Author: Ken McDonell Date: Mon Aug 13 11:28:46 2012 +1000 Fix in-band signalling in __pmGetPDU resulting in memory leak The return value of __pmGetPDU is both an error code and the value of the type field of the PDU. A negative type value is treated as an error by HandleClientInput, and the PDU is never unpinned, even though it was pinned by __pmGetPDU because there was no error. This leads to a memory leak and eventual pmcd crash. Original report and fixes reviewed by Florian Weimer of the Red Hat Security team. Red Hat bugzilla bug #841319. Security advisory CVE-2012-3420. commit eeb31d44e274ddab4409d7afb3d1da0153eb2fb1 Author: Nathan Scott Date: Mon Aug 13 11:28:46 2012 +1000 Minor cleanup in the result PDU decoding routine Remove unused variables, needlessly initialised variables, and a spurious long-forgotten call to __pmLastVersionIPC where the result is never used. commit 49c679c44425915a8d6aa4af5f90b35384843c12 Author: Nathan Scott Date: Mon Aug 13 11:28:46 2012 +1000 Resolve multiple issues in PCP result PDU decoding routine The value of numpmid was not validated against the overall PDU size. Processing a crafted PDU could read past the end of the PDU, crashing the process or disclosing information. The embedded numval counts are not checked, either, with similar results. In the valfmt != PM_VAL_INSITU case, the extracted pointer may point outside the area which holds such values. This can result in crashes or information disclosure. The length field inside the value is not validated against the PDU size. Values could be made to overlap with each other or with other parts of the PDU, which is also a problem. pmcd uses __pmDecodeResult, but only after store authorization, so the function is only exposed to localhost in the default configuration. Original report and fixes reviewed by Florian Weimer of the Red Hat Security team. Red Hat bugzilla bug #841159. Security advisory CVE-2012-3418. commit a7dc844d3586ea79887655a97c4252a79751fdae Author: Ken McDonell Date: Mon Aug 13 11:28:45 2012 +1000 Fix memory leak in pmcd DoFetch error path Original report and fixes reviewed by Florian Weimer of the Red Hat Security team. Red Hat bugzilla bug #841298. Security advisory CVE-2012-3420. commit 9673dc36b2acf29cf2b99ad5bf9d814feb833c39 Author: Nathan Scott Date: Mon Aug 13 11:28:45 2012 +1000 Harden the error PDU decoding Ensure the PDU length field matches size of the receiving struct. commit b9f41448621b01988f72bd41d4764a5570e606ba Author: Nathan Scott Date: Mon Aug 13 11:28:45 2012 +1000 Add missing PDU length checks in __pmDecodeLogControl routine __pmDecodeLogControl did not check the c_numpmid and v_numval fields against the size of the PDU. Due to the way the sizes passed to malloc are calculated, heap objects could be allocated which are too small, leading to a heap-based buffer overflow. Original report and fixes reviewed by Florian Weimer of the Red Hat Security team. Red Hat bugzilla bug #841290. Security advisory CVE-2012-3418. commit 5b97cdc78c83e308a88462ba77ca392258577efb Author: Nathan Scott Date: Mon Aug 13 11:28:45 2012 +1000 Harden the trace data PDU decoding Ensure the PDU length field matches size of the receiving struct. Also validate tag length field, and rearrange the tag string mem allocation to match intended use (correct buffer pinning model). commit 44b80ccf43dbccd7db5cbea0011c98f9046ec1e9 Author: Nathan Scott Date: Mon Aug 13 11:28:45 2012 +1000 Harden the trace ack PDU decoding Ensure the PDU length field matches size of the receiving struct. commit 5b06d263c942f30a34da3f29679472f41593bf9e Author: Nathan Scott Date: Mon Aug 13 11:28:44 2012 +1000 Harden the log status PDU decoding Ensure the PDU length field matches size of the receiving struct. commit b5e249172429e0305404b4bbd942a2efee2b95d4 Author: Nathan Scott Date: Mon Aug 13 11:28:44 2012 +1000 Harden the log request PDU decoding Ensure the PDU length field matches size of the receiving struct. commit 9f4e392c97ce42744ec73f82268ce6c815fdca0e Author: Nathan Scott Date: Mon Aug 13 11:28:44 2012 +1000 Fix heap overflow in __pmDecodeText routine __pmDecodeText does not check the buflen field against the PDU length, leading to a read overflow. Furthermore, buflen is not validated prior to a malloc call. Original report and fixes reviewed by Florian Weimer of the Red Hat Security team. Red Hat bugzilla bug #841249. Security advisory CVE-2012-3418. commit b33b3fe43b89ab2cdd488f6ecb0f876530fa953e Author: Nathan Scott Date: Mon Aug 13 11:28:44 2012 +1000 Harden the text request PDU decoding Ensure the PDU length field matches size of the receiving struct. commit f190942b552aa80d59bbe718866aa00b8e3fd5cc Author: Nathan Scott Date: Mon Aug 13 11:28:44 2012 +1000 Fix heap buffer overflow in __pmDecodeInstanceReq routine __pmDecodeInstanceReq does not check the namelen field against the PDU length, leading to a read overflow. Furthermore, namelen is not validated prior to a malloc call. Original report and fixes reviewed by Florian Weimer of the Red Hat Security Team. Red Hat bugzilla bug #841240. Security advisory CVE-2012-3418. commit babd6c5c527f87ec838c13a1b4eba612af6ea27c Author: Nathan Scott Date: Mon Aug 13 11:28:43 2012 +1000 Add field validation to PCP instance PDU decoding __pmDecodeInstance does not check the numinst and namelen values against the length of the PDU. As a result, an application which decodes crafted PDU_INSTANCE packets can crash. Original report and fixes reviewed by Florian Weimer of the Red Hat Security team. Red Hat bugzilla bug #841284. Security advisory CVE-2012-3418. commit bfb3ab8c6b3d75b1a6580feee76a7d0925a3633c Author: Nathan Scott Date: Mon Aug 13 11:28:43 2012 +1000 Fix buffer overflow in __pmDecodeNameReq routine DecodeNameReq does not check the namelen field against the PDU size. This can lead to a crash. Original report and fixes reviewed by Florian Weimer of the Red Hat Security team. Red Hat bugzilla bug #841180. Security advisory CVE-2012-3418. commit b441980d53be1835b25f0cd6bcc0062da82032dd Author: Nathan Scott Date: Mon Aug 13 11:28:43 2012 +1000 Add missing check againt PDU size in __pmDecodeIDList routine __pmDecodeIDList did not check that the incoming PDU actually contains room for numids elements. This could result in a client crash (read buffer overflow, not exploitable for code execution) should a server send too few IDs. Original report and fixes reviewed by Florian Weimer of the Red Hat Security team. Red Hat bugzilla bug #841112. Security advisory CVE-2012-3418. commit f0eaefe046b1061797f45b0c20bb2ac371b504a5 Author: Nathan Scott Date: Mon Aug 13 11:28:43 2012 +1000 Resolve buffer overflows in __pmDecodeNameList routine __pmDecodeNameList fetches the number of bytes to allocate for storing the incoming name strings from the PDU. The function does not check if the strings provided later actually fit into the buffer, leading to a heap-based buffer overflow. In addition, __pmDecodeNameList does not properly check the length of the status and names arrays against the PDU length, and does not guard against integer overflow when calculating the malloc argument. This leads to another heap-based buffer overflow. Original report and fixes reviewed by Florian Weimer of the Red Hat Security team. Red Hat bugzilla bug #840920. Security advisory CVE-2012-3418. commit 7eb479b91ef12bf89a15b078af2107c8c4746a4a Author: Nathan Scott Date: Mon Aug 13 11:28:43 2012 +1000 Add missing namelen checks in __pmDecodeFetch routine pmcd crashes when processing a crafted PDU_FETCH request because of a missing length check in __pmDecodeFetch. Code execution through this bug appears unlikely because the loop which runs past the end of the PDU only performs byte swapping (on little-endian architectures). Original report and fixes reviewed by Florian Weimer of the Red Hat Security team. Red Hat bugzilla bug #841183. Security advisory CVE-2012-3418. commit e4faa1f0ba29151340920d975fc7639adf8371d5 Author: Nathan Scott Date: Mon Aug 13 11:28:43 2012 +1000 Add missing PDU length checks in __pmDecodeProfile routine __pmDecodeProfile did not check whether the PDU actually contains room for profile_len elements of type __pmInDomProfile, or instances_len elemeents of type int. This leads to a read buffer overflow and crash in pmcd. On 32-bit architectures, the malloc size calculations can overflow, leading to a heap-based buffer overflow when the code writes past the end of the allocated buffer. Original report and fixes reviewed by Florian Weimer of the Red Hat Security team. Red Hat bugzilla bug #841126. Security advisory CVE-2012-3418. commit 46961420c503e0d1218e0c8b465ca9d2d06cbd36 Author: Nathan Scott Date: Mon Aug 13 11:28:43 2012 +1000 Harden the descriptor PDU decoding Ensure the PDU length field matches size of the receiving struct. Covers both descriptor and descriptor request PDU decoding. commit cced6012b4b93bfb640a9678589ced5416743910 Author: Nathan Scott Date: Mon Aug 13 11:28:42 2012 +1000 Fix crash in __pmDecodeCreds handling corrupt PDUs Resolve problem decoding the credentials PDU where the numcreds field exceeds the number of elements actually contained in the PDU. On 32-bit architectures, the size passed to malloc can be too small, leading to a heap-based buffer overflow. On 64-bit architectures, the multiplication is performed with 64 bits, so no overflow occurs, and the crash happens because __pmDecodeCreds reads beyond the end of an allocated buffer. Original report and patch review by Florian Weimer with the Red Hat Security Team. Red Hat bugzilla bug #840822. Security advisory CVE-2012-3418. From pcp-announce-bounces@oss.sgi.com Thu Aug 16 07:06:15 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_00,SUBJ_URGENT autolearn=no version=3.4.0-r929098 Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7GC6CJx115170; Thu, 16 Aug 2012 07:06:12 -0500 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7GC69mK115158 for ; Thu, 16 Aug 2012 07:06:09 -0500 X-ASG-Debug-ID: 1345118767-04cbb050cf561910001-87ZIJf Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id trG06nFIzFvyO3g9 for ; Thu, 16 Aug 2012 05:06:07 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7GC677C011759; Thu, 16 Aug 2012 08:06:07 -0400 Date: Thu, 16 Aug 2012 08:06:07 -0400 (EDT) From: Nathan Scott To: pcp-announce@oss.sgi.com Message-ID: <310460389.24537644.1345118767169.JavaMail.root@redhat.com> In-Reply-To: <1143824060.23566208.1345075402002.JavaMail.root@redhat.com> MIME-Version: 1.0 X-ASG-Orig-Subj: [URGENT] pcp-3.6.5 release available X-Originating-IP: [10.64.50.212] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1345118767 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.105808 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Cc: Florian Weimer Subject: [pcp-announce] [URGENT] pcp-3.6.5 release available X-BeenThere: pcp-announce@oss.sgi.com X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Nathan Scott List-Id: pcp announcements List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: pcp-announce-bounces@oss.sgi.com Errors-To: pcp-announce-bounces@oss.sgi.com Hi all, The pcp-3.6.5 release has been freshly tagged and is available from oss.sgi.com in the usual locations (see Sources and Downloads links on the PCP project page - http://oss.sgi.com/projects/pcp/). This release concludes a security review by the Red Hat Security Team, and includes fixes for several vulnerabilities discovered. The issues affect *all* releases of PCP that you might have installed, so we urge you to upgrade immediately. Details of the bugs are included in the changelog below, but suffice to say the results of a compromise would be severe. Upgrading immediately is an excellent option. If you have any questions or concerns about any of these changes, the most direct line to myself and the other PCP developers is via IRC on the freenode.net #pcp channel - feel free to make contact (privately if you prefer). In addition, several other pending bug fixes and improvements have been included in this release. Of particular interest to Perl PMDA authors might be the hash-based instance domain handling (uses the pmdaCache(3) routines). pcp-3.6.5 (16 August 2012) - Fixes for security advisory CVE-2012-3418 o Add field validation to PCP instance PDU (Red Hat #841240) o Fix __pmDecodeInstanceReq heap buffer overflow (Red Hat #841284) o Fix __pmDecodeText heap overflow (Red Hat #841249) o Multiple issues in result PDU decoding (Red Hat #841159) o Fix __pmDecodeNameReq buffer overflow (Red Hat #841180) o Add length checks to __pmDecodeLogControl (Red Hat #841290) o Add size check to __pmDecodeIDList (Red Hat #841112) o Fix __pmDecodeNameList buffer overflow (Red Hat #840920) o Add missing __pmDecodeFetch namelen checks (Red Hat #841183) o Add length checks to __pmDecodeProfile (Red Hat #841126) o Add length checks to __pmDecodeCreds (Red Hat #840822) - Workaround for security advisory CVE-2012-3419 o Split the Linux kernel and proc PMDAs to prevent information leakage in default installs - esp. /proc/pid/maps exposure, but other proc metrics as well - and no longer export process metrics by default (Red Hat #841702) - Fixes for security advisory CVE-2012-3420 o Memory leak in pmcd DoFetch error path (Red Hat #841298) o Memory leak in __pmGetPDU in-band signalling (Red Hat #841319) - Fixes for security advisory CVE-2012-3421 o Resolve event-driven programming flaw in pmcd (Red Hat #841706) - Correct buffer unpinning logic in a PMNS traversal error path o Red Hat bugzilla bug #847314. *** - All of the above issues were identified by Florian Weimer of the *** Red Hat Security Team, who also assisted extensively in fixing *** and testing; a huge thank you to Florian from all PCP developers *** and users! - Add modern gcc/glibc security protection mechanisms where available. Thanks to the Frank Eigler. - Harden all boundary checking in the remaining PDU decoders. - Resolve an issue with configure script checking for the init(1) process on Fedora 17 (and other systems using systemd). Thanks to Lukas Berk. - pmdaelasticsearch only reports on nodes in the cluster now, and not other client nodes. Thanks to Nigel Donaldson. - Added interfaces to PCP::PMDA Perl module to allow PMDAs to use a hash instance domain (instead of int/string array). These make use of the pmdaCacheOp(3) interfaces - the hash keys are the (external) PCP instance names, and the value associated with each key is an opaque reference. - Added an interface to allow PMDAs to register event queues with existing clients (pmdaEventNewActiveQueue). - Initial version of the (experimental) bash tracing PMDA. cheers. -- Nathan _______________________________________________ pcp-announce mailing list pcp-announce@oss.sgi.com http://oss.sgi.com/mailman/listinfo/pcp-announce From nscott@redhat.com Thu Aug 16 20:38:09 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,J_CHICKENPOX_55 autolearn=no version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7H1c8YS227032 for ; Thu, 16 Aug 2012 20:38:08 -0500 X-ASG-Debug-ID: 1345167486-04cb6c3c735a4040001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id n5TssJ7mcLYFQCOl for ; Thu, 16 Aug 2012 18:38:07 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7H1c6HD001992 for ; Thu, 16 Aug 2012 21:38:06 -0400 Date: Thu, 16 Aug 2012 21:38:06 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1074559895.26302007.1345167486353.JavaMail.root@redhat.com> In-Reply-To: <2071863983.26294105.1345167048144.JavaMail.root@redhat.com> Subject: Setting up testing of pcp and pcp-gui packages MIME-Version: 1.0 X-ASG-Orig-Subj: Setting up testing of pcp and pcp-gui packages Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [66.187.239.14] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - GC12 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1345167486 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.105862 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Hi guys, Wanted to send out my current recipe for working with installed PCP packages, that recently arrived in the "dev" branches of the pcp and pcp-gui git trees. For both trees, a ./Makepkgs at the top level now produces one additional package - pcp-testsuite and pcp-gui-testsuite. These install the test scripts, binaries, sources, pcp archives + any other life-support they need into the root. Several of the pcpqa tests wish to do something (usually remote somethings, so mainly this is for the non-local group tests) as a well-know non-root user, specifically named "pcpqa". So the pcp rpm creates this user, and sets her home directory to be the same as the install point for the tests. In addition those tests want to be able to change to sudo over to root to start/stop pmcd, and install agents, etc. The rpm does not setup the sudo access, not sure thats a good idea. So, once the packages are installed: # echo "pcpqa ALL=(ALL) NOPASSWD" > /etc/sudoers.d/pcpqa # chmod 440 /etc/sudoers.d/pcpqa # chown -R pcpqa.pcpqa /var/lib/pcp{,-gui}/testsuite (be good if the rpm install could do the above..?) # su -u pcpqa $ cd /var/lib/pcp/testsuite (if not there already) $ make setup (this can take awhile - generates archives, etc) $ ./check -l -g local Same sort of procedure for pcp-gui, with one extra step. Since this runs some X applications, need to ensure pcpqa has access to your local X server. Simplest way I found was to run "xhost +local:" - it Works For Me (tm) on RHEL6, anyway. Then just: $ cd /var/lib/pcp-gui/testsuite $ make setup $ ./check -l -g local cheers. -- Nathan From ndsco1@student.monash.edu Fri Aug 17 00:59:29 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,J_CHICKENPOX_63 autolearn=no version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7H5xTr0258328 for ; Fri, 17 Aug 2012 00:59:29 -0500 X-ASG-Debug-ID: 1345183165-04bdf034545f0810001-S8gJnT Received: from stan.its.monash.edu.au (stan.its.monash.edu.au [130.194.13.165]) by cuda.sgi.com with ESMTP id Nfp9iTKhuA0SBoFg for ; Thu, 16 Aug 2012 22:59:26 -0700 (PDT) X-Barracuda-Envelope-From: ndsco1@student.monash.edu X-Barracuda-Apparent-Source-IP: 130.194.13.165 Received: from palin.its.monash.edu.au ([130.194.13.83]) by stan.its.monash.edu.au (Sun Java System Messaging Server 6.2-4.03 (built Sep 22 2005)) with ESMTP id <0M8V00F86XZ0BR70@stan.its.monash.edu.au> for pcp@oss.sgi.com; Fri, 17 Aug 2012 15:59:24 +1000 (EST) Received: from palin.its.monash.edu.au (localhost.localdomain [127.0.0.1]) by localhost (Postfix) with SMTP id 78098546C79 for ; Fri, 17 Aug 2012 15:59:23 +1000 (EST) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by palin.its.monash.edu.au (Postfix) with ESMTPS id DE07D546C6A for ; Fri, 17 Aug 2012 15:59:22 +1000 (EST) Received: by pbbrp2 with SMTP id rp2so2669859pbb.41 for ; Thu, 16 Aug 2012 22:59:19 -0700 (PDT) Received: by 10.68.194.229 with SMTP id hz5mr6496889pbc.86.1345183159595; Thu, 16 Aug 2012 22:59:19 -0700 (PDT) Received: by 10.68.216.196 with HTTP; Thu, 16 Aug 2012 22:59:19 -0700 (PDT) Date: Fri, 17 Aug 2012 15:59:19 +1000 From: Nathan Scott Subject: Re: [pcp] python bindings In-reply-to: <5016FBE3.3030405@redhat.com> X-ASG-Orig-Subj: Re: [pcp] python bindings Sender: ndsco1@student.monash.edu To: Stan Cox Cc: pcp@oss.sgi.com Message-id: MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :x-gm-message-state; bh=nJTip9w2aD36wbtKhoYVfJdwsBgHrcfU4WkEkOBq+xc=; b=DXAP71TJ07rsBjCDvD3dXSFO6Br/AuAXwchqequF5qmG1mrEWB0m9n/qibIrmvxO+u f/LsFI/4h5x0i6zXmfEJGH/RqT5XcjPN0UFMqKJWnxYwlySKKQoEqYQTIxhwJO0KZQiE FRPAzGXMicU3cFHZ9QIuYnGQnaoqvIFn46hAbAok4bV0rvqc6CJUt7ULiXPi4D1bN10Y jNiKzXEfs+fV5pIrZQuyaT5cTkzn3XRRgVAPsXlPTC3a8GXgpKLObCZlEXkBbG3DfeEA 9GvEG2kbO+gcgpRaFDd0K0WpBUkzow/JAbH4hGA0terpUImsFXapoWRTBUgsPUdXmE1T CXfw== X-Google-Sender-Auth: QE-MnXhlvrbLKEMkD4heVO3lsds X-Gm-Message-State: ALoCoQmbxMmTsv+W7aF0qW00j6h/Vv7Kp7lkBNBL0q9S25zsE31fHwfGUg3gL8HdrtivCvh7Rxfe References: <4FD9086A.1050805@redhat.com> <5016FBE3.3030405@redhat.com> X-Barracuda-Connect: stan.its.monash.edu.au[130.194.13.165] X-Barracuda-Start-Time: 1345183166 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.105880 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Hi Stan, Apologies for taking so long to get back to this... (had to dig through my old mailbox just to find it!). On 31 July 2012 07:25, Stan Cox wrote: > The python bindings: > 1) Now include Nathan Scott's cleanups for current headers for pcp.py > 2) Uses Nathan Scott's suggestion to check pmDesc.sem for the metric type > for pm-collectl.py Cool, thanks - looks good. > 3) pm-collectl.py now supports -sd -sc -sj -sn -sD -sC -sJ -sN --verbose > 4) GNUmakefile uses setup.py for building and installing > > > 1) Does it seem reasonable to include python upstream? Nobody else seems to have a strong opinion, and I think there's some good advantages (esp. related to ensuring it stays up to date with new macros/functions/features, as well as getting it out to developers). > 2) If yes are there any "to do" items folks think are required before > pushing? Looks good. I've done another review - and a few more suggestions follow, but no need to wait on merging for these (its in dev branch now, we should shoot for 3.6.6, possiblly late next week, preferably with the below things discussed and updated where need be). src/python/p*.py - I fixed a few comments up a little, please double check for me - I was unsure about pmNumberStr being marked as a NOOP, does the suffix addition happen automatically in python? If so, perhaps we don't need any entry point here at all? - should we be using the reentrant versions of pmTypeStr, pmAtomStr, pmNumberStr? (i.e. the _r suffixed versions). I suspect we should, no? - still makes reference to being "pre-alpha" - is it worth moving that to a different state? - there's references to "127.0.0.1" in a couple of places ... hmmmm. In libpcp, theres a couple of references to "localhost" - can we use that instead? (its at least not an IPv4 address then). setup and test scripts: - setup script - says Pcp is gplv3, which differs to rest of PCP (refer to top-level COPYING). We either need to make these match up (2), or we need an additional COPYING file for the python module). - setup script also has a url pointer to ftp://oss.sgi... download area - it might be better to point that at http://oss.sgi.com/projects/pcp/ now? - test_pcp.py - awesome, can we automate the running of this? a new test in qa/XXX (next free number) that checks for the Pcp module in the system root (not in the source tree) and runs this if found (use _notrun if not). src/python/GNUmakefile - I made a couple of minor changes here, be worth checking 'em for me :) - looks like the makefile will need further tweaks around Franks prefix work? comments there certainly suggest so. Sounds like Franks close on that. - need to consider platforms that have no python installed - the build will likely fail there now, and thats going to need (hopefully trivial) fixing. - usually the toolchain used in the build is abstracted by macros that can be overridden (e.g. via configure) - we should introduce a $(PYTHON) like $(AWK) and $(SED) and friends, if we need to invoke it directly (appears we do). might be able to use this macro to help with the above point too. cheers. -- Nathan From nscott@redhat.com Fri Aug 17 01:06:14 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,J_CHICKENPOX_63 autolearn=no version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7H66DcY259075 for ; Fri, 17 Aug 2012 01:06:14 -0500 X-ASG-Debug-ID: 1345183571-04cb6c3c735aed60001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id HyLk4AFdjlDwiFm0 for ; Thu, 16 Aug 2012 23:06:11 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7H66BEr014422; Fri, 17 Aug 2012 02:06:11 -0400 Date: Fri, 17 Aug 2012 02:06:11 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Stan Cox Cc: pcp@oss.sgi.com Message-ID: <2048506109.26652396.1345183571160.JavaMail.root@redhat.com> Subject: Re: python bindings MIME-Version: 1.0 X-ASG-Orig-Subj: Re: python bindings Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [66.187.239.14] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - GC12 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1345183571 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.01 X-Barracuda-Spam-Status: No, SCORE=0.01 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.105880 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain Hi Stan, Apologies for taking so long to get back to you on this... On 31 July 2012 07:25, Stan Cox wrote: > The python bindings: > 1) Now include Nathan Scott's cleanups for current headers for pcp.py > 2) Uses Nathan Scott's suggestion to check pmDesc.sem for the metric type > for pm-collectl.py Cool, thanks - looks good. > 3) pm-collectl.py now supports -sd -sc -sj -sn -sD -sC -sJ -sN --verbose > 4) GNUmakefile uses setup.py for building and installing > > > 1) Does it seem reasonable to include python upstream? Nobody else seems to have a strong opinion, and I think there's some good advantages (esp. related to ensuring it stays up to date with new macros/functions/features, as well as getting it out to developers). > 2) If yes are there any "to do" items folks think are required before > pushing? Looks good. I've done another review - and a few more suggestions follow, but no need to wait on merging for these (its in dev branch now, we should shoot for 3.6.6, possiblly late next week, preferably with the below things discussed and updated where need be). src/python/p*.py - I fixed a few comments up a little, please double check for me - I was unsure about pmNumberStr being marked as a NOOP, does the suffix addition happen automatically in python? If so, perhaps we don't need any entry point here at all? - should we be using the reentrant versions of pmTypeStr, pmAtomStr, pmNumberStr? (i.e. the _r suffixed versions). I suspect we should, no? - still makes reference to being "pre-alpha" - is it worth moving that to a different state? - there's references to "127.0.0.1" in a couple of places ... hmmmm. In libpcp, theres a couple of references to "localhost" - can we use that instead? (its at least not an IPv4 address then). setup and test scripts: - setup script - says Pcp is gplv3, which differs to rest of PCP (refer to top-level COPYING). We either need to make these match up (2), or we need an additional COPYING file for the python module). - setup script also has a url pointer to ftp://oss.sgi... download area - it might be better to point that at http://oss.sgi.com/projects/pcp/ now? - test_pcp.py - awesome, can we automate the running of this? a new test in qa/XXX (next free number) that checks for the Pcp module in the system root (not in the source tree) and runs this if found (use _notrun if not), perhaps? src/python/GNUmakefile - I made a couple of minor changes here, be worth checking 'em for me :) - looks like the makefile will need further tweaks around Franks prefix work? comments there certainly suggest so. Sounds like Franks close on that. - need to consider platforms that have no python installed - the build will likely fail there now, and thats going to need (hopefully trivial) fixing. - usually the toolchain used in the build is abstracted by macros that can be overridden (e.g. via configure) - we should introduce a $(PYTHON) like $(AWK) and $(SED) and friends, if we need to invoke it directly (appears we do). might be able to use this macro to help with the above point too. cheers. -- Nathan From nscott@redhat.com Fri Aug 17 01:07:24 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7H67OqT259153 for ; Fri, 17 Aug 2012 01:07:24 -0500 X-ASG-Debug-ID: 1345183641-04cbb050cc59ba60001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id Cm2zhIGaCniqFetC for ; Thu, 16 Aug 2012 23:07:21 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7H67Kpf029642; Fri, 17 Aug 2012 02:07:20 -0400 Date: Fri, 17 Aug 2012 02:07:20 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Cc: Stan Cox Message-ID: <1054989240.26652735.1345183640761.JavaMail.root@redhat.com> Subject: pcp updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [66.187.239.14] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - GC12 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1345183641 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.105880 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- [Merged branch 'scox/python' of git://sourceware.org/git/pcpfans into dev, excluded from diffstat and changelog here for brevity] Changes committed to git://oss.sgi.com/pcp/pcp.git dev src/python/GNUmakefile | 17 +++++++---------- src/python/pcp.py | 2 +- src/python/pcpi.py | 6 +++--- src/python/pmapi.c | 1 - 4 files changed, 11 insertions(+), 15 deletions(-) commit 911eaa09665a60056a629fddd1a74b6cdcd579cf Author: Nathan Scott Date: Fri Aug 17 16:00:14 2012 +1000 Remove duplicate definition of PM_EVENT_FLAG_POINT in python pmapi wrapper commit 2c30d74e8fb208b1f35c82f021e7a4b8f14a44f8 Author: Nathan Scott Date: Fri Aug 17 15:29:19 2012 +1000 Tweaks to python Makefile to allow initial merging This adds python sources into a LSRCFILES, which means the Makepkgs build will be able to proceed (and they'll appear in the source tarball now too). The install target is renamed install_python (along the lines of install_perl) so that this can be made optional (and not default until packaging issues sorted out) as will need to happen for platforms that don't have python installed by default (MacOSX? Solaris? Win32 for sure). commit 337a97c30cc6d24aed4e78b91558acb53b21115f Author: Nathan Scott Date: Fri Aug 17 15:25:51 2012 +1000 Fix a couple of typos in python source file comments. From nscott@redhat.com Sat Aug 18 02:39:04 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7I7d4Jk178818 for ; Sat, 18 Aug 2012 02:39:04 -0500 X-ASG-Debug-ID: 1345275542-04cb6c3c70607ed0001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id IeU0TQyoUnYmnBtK for ; Sat, 18 Aug 2012 00:39:02 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7I7d1Ni023390 for ; Sat, 18 Aug 2012 03:39:02 -0400 Date: Sat, 18 Aug 2012 03:39:01 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1764973554.29682860.1345275541695.JavaMail.root@redhat.com> In-Reply-To: <498652153.29672648.1345274937187.JavaMail.root@redhat.com> Subject: pcp-gui updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp-gui updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.50.233] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1345275542 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.105982 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp-gui.git dev src/chart/GNUmakefile | 8 src/chart/chart.cpp | 1604 ++++++++++++++++++--------------------------- src/chart/chart.h | 251 ++++--- src/chart/chartdialog.cpp | 6 src/chart/curve.cpp | 42 - src/chart/curve.h | 33 src/chart/gadget.h | 4 src/chart/groupcontrol.cpp | 4 src/chart/pmchart.pro.in | 12 src/chart/sampling.cpp | 378 ++++++++++ src/chart/sampling.h | 155 +++- src/chart/tracing.cpp | 111 ++- src/chart/tracing.h | 70 + src/chart/view.cpp | 7 14 files changed, 1509 insertions(+), 1176 deletions(-) commit b54eef750792ec385b8ab102e2a21cfca0f46aff Author: Nathan Scott Date: Sat Aug 18 17:15:01 2012 +1000 Split the ChartItem into sampling and tracing components Refactoring to allow for sampling charts (fixed size arrays of values) to co-exist with tracing charts (which will have variable sized sets of begin/end/point observations and not fixed (sample) timestamps, but rather timestamps of when an event occurred. The base classes of Chart and ChartItem are now agnostic to which style of chart they will be displaying. Tons of work to do still to get trace charts working well, but we're out of the blocks. commit 7518697d69cd701a25e05e55574bfb2b5b0487a6 Author: Nathan Scott Date: Sat Aug 18 15:31:24 2012 +1000 Sort out ctor call convention for ChartItem base class commit ad00fe48af79cf1fdd8679b5ea51eebb75d11d38 Author: Nathan Scott Date: Sat Aug 18 11:53:09 2012 +1000 Rename Plot to Item, extract from Chart class, prepare for trace/sample split commit fcb393745ffba50e392b5cf1bfadc37272b3c64e Author: Nathan Scott Date: Sat Aug 18 09:12:48 2012 +1000 Introduce an event style chart, and correctly manage scale memory commit 25a6b979040e92d002fd891fdef9b279e1a59799 Author: Nathan Scott Date: Fri Aug 17 17:07:55 2012 +1000 Rename couple of chart methods to match plans. commit 3dc4634ac7d038e5d5c9c19bfe5de9f6e05dccdc Author: Nathan Scott Date: Fri Aug 17 16:56:09 2012 +1000 Refactor y-axis scale engine code for event tracing commit 6812afbb558695da6ae7bafda24bf0e913f4839a Author: Nathan Scott Date: Fri Aug 17 10:19:17 2012 +1000 Merge placeholder class for event trace Y-axis scaling commit e07e22870a683dd2b95816321ab1bd5316eabc3b Author: Nathan Scott Date: Fri Aug 17 10:06:27 2012 +1000 Rename the ValueScaleEngine class to SamplingScaleEngine and move it. commit ee341f3826b9935362adc92890b2332e998b4975 Author: Nathan Scott Date: Fri Aug 17 09:57:53 2012 +1000 Rename Curve class (and files) to SamplingCurve. From nscott@redhat.com Sat Aug 18 02:39:49 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7I7dn6m178971 for ; Sat, 18 Aug 2012 02:39:49 -0500 X-ASG-Debug-ID: 1345275588-04cbb050cd5ef590001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id XvbhQOdoMM25XCzz for ; Sat, 18 Aug 2012 00:39:48 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7I7dmtg023406 for ; Sat, 18 Aug 2012 03:39:48 -0400 Date: Sat, 18 Aug 2012 03:39:47 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <475538307.29682899.1345275587972.JavaMail.root@redhat.com> Subject: pcp-gui updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp-gui updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.50.233] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1345275588 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.105982 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp-gui.git dev .gitignore | 13 ----- debian/GNUmakefile | 14 +++++ debian/rules | 2 qa/.gitignore | 14 +++++ qa/006.out | 126 ++++++++++++++++++++++------------------------------- qa/GNUmakefile | 2 6 files changed, 83 insertions(+), 88 deletions(-) commit 3f6e7e998cb2f3a26327299f56145b7e03451f1e Author: Nathan Scott Date: Sat Aug 18 17:38:31 2012 +1000 Add couple of debian packaging tweaks for QA commit ed21469608467fc31047fe2239957770ede02d7b Author: Nathan Scott Date: Sat Aug 18 17:36:28 2012 +1000 Update test 006 output to match refactored pmchart code commit dad282955316fbc5c3ba12cb556b4d31d396c5b0 Author: Nathan Scott Date: Sat Aug 18 17:36:05 2012 +1000 Descend down to SUBDIRS when setup make target invoked in qa commit 5efd497be7b1ba7cee4415c9168cca27d1f2dc88 Author: Nathan Scott Date: Sat Aug 18 17:35:31 2012 +1000 Add .bad and .full files to git filter commit b0812db77dc086e5d6b51f3800cb141296b924cd Author: Nathan Scott Date: Sat Aug 18 17:32:09 2012 +1000 Update gitignore files for cleaner QA From nscott@redhat.com Sun Aug 19 05:04:58 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7JA4vCG095419 for ; Sun, 19 Aug 2012 05:04:58 -0500 X-ASG-Debug-ID: 1345370696-04cbb050cf640890001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id Eq3jHz1C3hcgCni0 for ; Sun, 19 Aug 2012 03:04:56 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7JA4pCQ015882; Sun, 19 Aug 2012 06:04:51 -0400 Date: Sun, 19 Aug 2012 06:04:51 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Ken McDonell Cc: pcp@oss.sgi.com Message-ID: <1002888989.30875873.1345370691909.JavaMail.root@redhat.com> In-Reply-To: <176731254.30866621.1345369917804.JavaMail.root@redhat.com> Subject: Recording event trace metrics MIME-Version: 1.0 X-ASG-Orig-Subj: Recording event trace metrics Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.50.233] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1345370696 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106088 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Hi Ken, Looking inside a PCP archive containing event trace data, I came across a quirk. It looks like pmlogger is storing a result structure on every sample, even when no records were returned. For example ... [28 bytes] 12:35:36.516 112.0.4 (bash.xtrace.records): No values returned! [28 bytes] 12:35:38.516 112.0.4 (bash.xtrace.records): No values returned! [28 bytes] 12:35:40.516 112.0.4 (bash.xtrace.records): No values returned! [28 bytes] 12:35:42.516 112.0.4 (bash.xtrace.records): No values returned! [28 bytes] 12:35:44.516 112.0.4 (bash.xtrace.records): No values returned! [28 bytes] 12:35:46.516 112.0.4 (bash.xtrace.records): No values returned! ... Which looks like a pmResult struct with timestamp, numpmid set to one, and a valueset with no values? This seems a bit suboptimal for event traces (probably a fairly common case), whereas the behaviour is fine for the traditionally sampled non-event-trace style metrics. Would a sensible approach be to flatten (possibly into nothing) the result structure before each write in pmlogger? Would you expect any oddness with the temporal index with that approach? (if so, would an occasional mark record make sense - I imagine this introduces some unusual corner cases for pmlogger now - such as archives with no data at all!). Any other potential gotchas you can foresee here? cheers. -- Nathan From nscott@redhat.com Mon Aug 20 06:05:16 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7KB5Fig220053 for ; Mon, 20 Aug 2012 06:05:16 -0500 X-ASG-Debug-ID: 1345460709-04bdf034546f3170001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id i0lY5KzpxSOgoTbT for ; Mon, 20 Aug 2012 04:05:11 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7KB59Y0003022 for ; Mon, 20 Aug 2012 07:05:09 -0400 Date: Mon, 20 Aug 2012 07:05:08 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <365064418.32608946.1345460708982.JavaMail.root@redhat.com> Subject: pcp-gui updates (qwt6 porting) MIME-Version: 1.0 X-ASG-Orig-Subj: pcp-gui updates (qwt6 porting) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.50.229] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1345460711 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106188 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp-gui.git qwt6 src/chart/chart.cpp | 34 src/chart/chart.h | 5 src/chart/exportdialog.cpp | 1 src/chart/sampling.cpp | 20 src/chart/sampling.h | 4 src/chart/timeaxis.cpp | 15 src/time/pmtimearch.ui | 16 src/time/showboundsdialog.ui | 22 src/libqwt/libqwt.pro.in | 83 + [src/libqwt/* ...] 181 files changed, 26414 insertions(+), 19314 deletions(-) commit 6b8df44d4517a8397500a8ad36b7b6a94e49bb76 Author: Nathan Scott Date: Mon Aug 20 10:52:18 2012 +0000 Rework QWT5/6 differences in the pmtime application. These appear to be much more superficial than in the rest of Qwt (pmtime uses the wheel and slider widgets from Qwt) and initial testing suggests this part of the port is all completed. commit 3fcf0ccf8d2830cc44df2d53322b8f1bea0a92df Author: Nathan Scott Date: Mon Aug 20 10:27:30 2012 +0000 Rework QWT5/6 differences in pmchart, to reach initial link Started working through the many differences as we head to Qwt6. In particular; QwtPicker changes, some older types removed (direct mapping to Qt classes), QwtPlotPrintFilter is gone, and so on. One largish area to sort out still is how missing data is handled - we were using NaN values and a custom PlotCurve draw routine, this is changed a fair bit and needs further work. commit 794d2be3667bf6162c6bef33ac4b2a34720f7c10 Author: Nathan Scott Date: Mon Aug 20 10:07:36 2012 +0000 Reimplement couple of missing tweaks made to 5.x Qwt series for pmchart commit 2fc32b84ad20418710f1b6ad3556e5f85b995ab4 Author: Nathan Scott Date: Mon Aug 20 10:03:09 2012 +0000 Merge unmodified Qwt 6.0.2 sources From nscott@redhat.com Mon Aug 20 07:36:38 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7KCacXK227205 for ; Mon, 20 Aug 2012 07:36:38 -0500 X-ASG-Debug-ID: 1345466197-04cb6c3c726848d0001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id 5pxhn9LFrHRhtsVE for ; Mon, 20 Aug 2012 05:36:37 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7KCaaco029377; Mon, 20 Aug 2012 08:36:36 -0400 Date: Mon, 20 Aug 2012 08:36:36 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Stan Cox Cc: pcp@oss.sgi.com Message-ID: <264712361.32855780.1345466196836.JavaMail.root@redhat.com> In-Reply-To: <2048506109.26652396.1345183571160.JavaMail.root@redhat.com> Subject: Re: python bindings MIME-Version: 1.0 X-ASG-Orig-Subj: Re: python bindings Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.64.50.229] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1345466197 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.01 X-Barracuda-Spam-Status: No, SCORE=0.01 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106194 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain Hi Stan, ----- Original Message ----- > From: "Nathan Scott" > To: "Stan Cox" > Cc: pcp@oss.sgi.com > Sent: Friday, August 17, 2012 4:06:11 PM > Subject: Re: python bindings >=20 > ... > setup and test scripts: Just came across another issuee here - the setup script appears to be making use of the pcp headers and libraries from the root. This will have to (somehow? not clear from looking at it - maybe that "ext_modules" Extension macro allows this?) make use of the libraries and headers from the build if we're to have the python code live within pcp. At build time, there may not be a local root install of pcp, in which case the build will fail atm. I came across this while I was helping someone with a fairly old (patched) pcp build, which *did* have pcp in the root, but that really old version was missing some macros... pmapi.c: In function =E2=80=98initpmapi=E2=80=99: pmapi.c:169:46: error: =E2=80=98PM_TYPE_EVENT=E2=80=99 undeclared (first us= e in this function) pmapi.c:169:46: note: each undeclared identifier is reported only once for = each function it appears in pmapi.c:197:52: error: =E2=80=98PM_EVENT_FLAG_POINT=E2=80=99 undeclared (fi= rst use in this function) pmapi.c:198:52: error: =E2=80=98PM_EVENT_FLAG_START=E2=80=99 undeclared (fi= rst use in this function) pmapi.c:199:52: error: =E2=80=98PM_EVENT_FLAG_END=E2=80=99 undeclared (firs= t use in this function) pmapi.c:200:52: error: =E2=80=98PM_EVENT_FLAG_ID=E2=80=99 undeclared (first= use in this function) pmapi.c:201:52: error: =E2=80=98PM_EVENT_FLAG_PARENT=E2=80=99 undeclared (f= irst use in this function) pmapi.c:202:52: error: =E2=80=98PM_EVENT_FLAG_MISSED=E2=80=99 undeclared (f= irst use in this function) pmapi.c:332:22: error: =E2=80=98PM_ERR_TYPE=E2=80=99 undeclared (first use = in this function) pmapi.c:334:22: error: =E2=80=98PM_ERR_THREAD=E2=80=99 undeclared (first us= e in this function) pmapi.c:340:22: error: =E2=80=98PM_ERR_FAULT=E2=80=99 undeclared (first use= in this function) error: command 'gcc' failed with exit status 1 make[3]: *** [s-setup] Error 1 make[2]: *** [default_pcp] Error 2 make[1]: *** [default_pcp] Error 2 make: *** [built] Error 2 cheers. -- Nathan From nscott@redhat.com Mon Aug 20 07:46:03 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7KCk3pc227764 for ; Mon, 20 Aug 2012 07:46:03 -0500 X-ASG-Debug-ID: 1345466762-04cbb050cf682640001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id 6Ymcce5paB9HPwl6 for ; Mon, 20 Aug 2012 05:46:02 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7KCk2ek031360; Mon, 20 Aug 2012 08:46:02 -0400 Date: Mon, 20 Aug 2012 08:46:02 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Stan Cox Cc: pcp@oss.sgi.com Message-ID: <831102567.32877498.1345466762077.JavaMail.root@redhat.com> In-Reply-To: <264712361.32855780.1345466196836.JavaMail.root@redhat.com> Subject: Re: [pcp] python bindings MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] python bindings Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.50.229] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1345466762 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.01 X-Barracuda-Spam-Status: No, SCORE=0.01 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106194 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain ----- Original Message ----- > From: "Nathan Scott" > To: "Stan Cox" > Cc: pcp@oss.sgi.com > ... > Just came across another issuee here - the setup script appears > to be making use of the pcp headers and libraries from the root. Oh, if its any consolation I made the same assumptions with the QA build/packaging changes last week, which now suffers the same problem. I'll be looking into that tomorrow, in case you come across it. cheers. -- Nathan From nscott@redhat.com Mon Aug 20 22:52:07 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,J_CHICKENPOX_73 autolearn=no version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7L3q7EC031555 for ; Mon, 20 Aug 2012 22:52:07 -0500 X-ASG-Debug-ID: 1345521123-04cb6c3c726b4d70001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id CyLDfYoeZGAEkYdF for ; Mon, 20 Aug 2012 20:52:03 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7L3q2So008828 for ; Mon, 20 Aug 2012 23:52:02 -0400 Date: Mon, 20 Aug 2012 23:52:02 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1572361178.35021906.1345521122639.JavaMail.root@redhat.com> Subject: pcp updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.50.220] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1345521123 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106256 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp.git dev GNUmakefile | 12 - INSTALL | 4 Makepkgs | 26 +- VERSION.pcp | 2 build/rpm/pcp.spec.in | 4 configure | 447 ++++++++++++---------------------------- configure.in | 421 ++++++++----------------------------- debian/changelog | 7 debian/rules | 4 install-sh | 7 qa/308 | 2 qa/GNUmakefile | 54 +--- qa/GNUmakefile.install | 79 +++++++ qa/GNUmakefile.installed | 158 +++++++------- qa/check | 4 qa/chk.setup | 22 - qa/common.check | 2 qa/common.rc | 16 - qa/pmdas/broken/broken_Install | 2 qa/pmdas/broken/broken_Remove | 2 qa/src-oss/GNUmakefile | 4 qa/src-oss/grind-tools | 2 qa/src-oss/ipcs_clear | 2 qa/src-oss/make.dodgey | 2 qa/src-oss/mkeventrec | 2 qa/src-oss/mkproc | 2 qa/src-oss/mkrewrite | 2 qa/src-oss/mksample_expr | 2 qa/src-oss/mktzchange | 6 qa/src-oss/pmcdgone.c | 10 src/cpan/LogImport/GNUmakefile | 5 src/cpan/LogSummary/GNUmakefile | 4 src/cpan/MMV/GNUmakefile | 4 src/cpan/PMDA/GNUmakefile | 5 src/include/builddefs.in | 41 ++- src/libpcp/src/logutil.c | 6 src/newhelp/newhelp.c | 27 +- src/pmdas/txmon/Install | 24 -- src/python/.gitignore | 2 src/python/GNUmakefile | 11 src/python/pcp.py | 112 ++++++---- src/python/pcpi.py | 24 +- src/python/pm-collectl.py | 20 - src/python/pmapi.c | 23 +- src/python/setup.py | 24 +- src/python/test_pcp.py | 20 - 46 files changed, 694 insertions(+), 967 deletions(-) commit 91156fa360b706bd11d55a57662acb1c36f4e13b Author: Nathan Scott Date: Tue Aug 21 13:50:26 2012 +1000 Return code of fwrite is not in bytes, fix previous fix commit 31b1f97b6f23b18186937dad72a806a2f80c300b Author: Nathan Scott Date: Tue Aug 21 13:37:54 2012 +1000 Fix couple of compilation warnings around ignoring fwrite return code commit 03d72d7b156af57202c73e06c1788acefcb8ea28 Author: Nathan Scott Date: Tue Aug 21 13:11:23 2012 +1000 Bump version in the dev branch in preparation for upcoming pcp release commit 801f059fb50de8f3193042f85b9dae6597e98f46 Author: Nathan Scott Date: Tue Aug 21 12:57:11 2012 +1000 Add installed qa makefile to LSRCFILES, rename to match convention (pmdas,pcp-gui) commit 4060dd9aab1f338357b63fa227b6cbbcc4643ca0 Merge: 2ab4d01 9e7d386 Author: Nathan Scott Date: Tue Aug 21 12:46:19 2012 +1000 Merge branch 'fche/prefix-3.6.6' of git://sourceware.org/git/pcpfans into dev Conflicts: qa/GNUmakefile commit 2ab4d0126968584d4ed0c1f5cc074127f404dceb Merge: 493e583 9e06618 Author: Nathan Scott Date: Tue Aug 21 12:42:45 2012 +1000 Merge branch 'scox/python' of git://sourceware.org/git/pcpfans into dev commit 9e7d386f0c828373996d9e43269624a4812931d5 Author: Frank Ch. Eigler Date: Mon Aug 20 15:22:06 2012 -0400 txmon Install: don't loop endlessly If a user (or a misbehaving pcpqa invocation) failed to give a name, exit instead of looping infinitely. commit cf94b39213cace70baad81a98db84291afe8399f Author: Frank Ch. Eigler Date: Mon Aug 20 12:51:58 2012 -0400 ipcpqa common.rc: fix typo in $PCP_DIR sudo un-suppression commit d4d62b2b27 introduced a shell syntax typo, whoops. commit 040729da285d5c14325d4075512d37689645995d Author: Frank Ch. Eigler Date: Mon Aug 20 10:42:08 2012 -0400 pcpqa: add $PCP_DIR prefix to many mentions of /etc/pcp.* commit 9c6da14d08094a0407075fcf6bf855ec2f611227 Author: Frank Ch. Eigler Date: Mon Aug 20 10:04:24 2012 -0400 pcpqa src-oss: Use install-tree pcp headers and libraries * qa/src-oss/GNUmakefile (LLDLIBS, TRACELIB): Add $(LDFLAGS), which has the required -L$(PCP_LIB_DIR) ditty. commit d4d62b2b27802c08a448446c01c707efa909595e Author: Frank Ch. Eigler Date: Mon Aug 20 10:02:15 2012 -0400 pcpqa common.rc: Don't suppress sudo unless $PCP_DIR is our own The pcpqa testsuite needs to do sudo-root kinds of operations periodically, but defeats its own capabilities if it detects $PCP_DIR set. However, this is too much. There may be root/system-wide pcp installations at some $PCP_DIR location. So add a heuristic that we keep sudo for set $PCP_DIR *unless* $PCP_DIR is owned by the invoking user. commit 493e583ecb98725809d295702e20ac5749509960 Author: Nathan Scott Date: Mon Aug 20 08:59:29 2012 +1000 Ensure fully setup for QA by end of "make setup" commit 8cd36b22f2d5ec7deec76a6f7667a2479228bd46 Author: Frank Ch. Eigler Date: Fri Aug 17 23:15:39 2012 -0400 pcpqa makefile: build qa_outfiles list via "ls -1" rather than "git ls-files" commit 9e06618320c79647dd60e461f9724f5e1ac710cd Author: Stan Cox Date: Fri Aug 17 21:32:35 2012 -0400 Change to gplv2. Call reentrant pcp entries where available. * pcp.py (pmErrStr, pmUnitsStr, pmIDStr, pmInDomStr, pmTypeStr, pmAtomStr): Use reentrant _r entries commit 4d70a1cc37b2caf023fbd6fe099c6ab31146028a Author: Frank Ch. Eigler Date: Fri Aug 17 13:01:00 2012 -0400 pcpqa prefix: split qa/GNUmakefile into build-tree and install-tree sub-clones commit 46a6772e2aab0d58553a4d4ec11b5b86be747913 Author: Frank Ch. Eigler Date: Fri Aug 17 11:52:59 2012 -0400 python: .gitignore some build leftovers commit 744eaaa49f0c1bdb8448f06cdf172b30cc86765f Author: Frank Ch. Eigler Date: Fri Aug 17 11:29:25 2012 -0400 prefix: support python module builds * configure.in (with-python-prefix): New option. * src/python/GNUmakefile (setup.py build): set -I/-L for pmapi module to the local build tree. (setup.py install): Respect python-prefix if specified. commit 6c5829276787e2b8f4103064988117c025535a65 Author: Frank Ch. Eigler Date: Thu Aug 16 11:29:27 2012 -0400 configury: make default CFLAGS include -O2 * src/include/builddefs.in (CFLAGS): Add -O2, since that is normal. commit 1ecde2ebf36a0299e332dcaf4feec942534ac30a Author: Frank Ch. Eigler Date: Thu Aug 16 11:38:49 2012 -0400 debian configury: don't need to run autoconf before configure commit b42323b036ea42e30be998f35b8ba9d64994473f Author: Frank Ch. Eigler Date: Thu Aug 16 11:10:12 2012 -0400 INSTALL docs: note that running autoconf by hand is no longer necessary commit af6b17ae23c091f3b60c4ea6129a907cd9330de1 Author: Frank Ch. Eigler Date: Thu Aug 2 16:22:48 2012 -0400 perl MakeMaker: adapt to pre-2005 versions Once in July 2005, what must have been a sunny delightful day, with daisies swinging in the wind and birds chirping happily, willows swooning with the winds, and hippos gaily tromping around in the mud, Michael G Schwern changed ExtUtils::MakeMaker to take INSTALL_BASE instead of INSTALLBASE as the PREFIX-like parameter. Because some platforms (RHEL5, caugh, caugh) still have the pre-2005 version, let's be kind and allow them to enjoy pcp --prefix goodness too. * src/include/builddefs.in (MAKEMAKER_OPTIONS): Set INSTALLBASE *and* INSTALL_BASE to $(PERL_INSTALL_BASE). Just in case one misses the pastoral world of early-summer 2005. commit 91baa9aa26cbfa475e8a11e07548203bb265fb44 Author: Frank Ch. Eigler Date: Wed Jul 25 20:55:42 2012 -0400 configure.in: AC_PREREQ autoconf 2.60 or above This is to preclude regeneration of ./configure using a too-old autoconf that mistreats e.g. the AC_COMPILE_IFELSE construct. I'd like to exclude rhel4's 2.59, but it's not clear at what point the combination of AC_ARG_ENABLE / AC_COMPILE_IFELSE as used here has started working properly, so the actually required version number may be closer to the current 2.69. commit 70f4e401e4ac9f45f60c247ea875c5cf2f016569 Author: Frank Ch. Eigler Date: Wed Jul 25 18:15:17 2012 -0400 Makepkgs: abort if ./configure fails commit 799cc5e733d54071c796b5c0f65e58b4b8329400 Author: Frank Ch. Eigler Date: Wed May 2 10:01:32 2012 -0400 PR921, --prefix support for pcp configury Light changes in the top-level configure.in & GNUmakefile to allow PCP (including perl modules) to be installed into a directory other than /usr. Documentation / packaging scripts updated to note standard autoconf build instructions: ./configure [--prefix=PATH] ... make make install The default prefix is /usr/local. commit d61c2da8cb713b6f0cfcbfe7c7d79276ee05973b Author: Frank Ch. Eigler Date: Tue May 1 16:09:06 2012 -0400 install-sh: fix typo, to make chmod failure quite quiet commit e822e5bb36db78e02bad848b0e247556af6a9ec0 Author: Frank Ch. Eigler Date: Fri Jul 13 16:18:22 2012 -0400 install-sh: don't attempt chown at all unless invoked as root From nscott@redhat.com Tue Aug 21 02:09:35 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7L79Z9e049533 for ; Tue, 21 Aug 2012 02:09:35 -0500 X-ASG-Debug-ID: 1345532973-04bdf034567344e0001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id zoOA3PFE0k1Iw5OJ for ; Tue, 21 Aug 2012 00:09:33 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7L79X6C031117 for ; Tue, 21 Aug 2012 03:09:33 -0400 Date: Tue, 21 Aug 2012 03:09:32 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <427083654.35284153.1345532972988.JavaMail.root@redhat.com> In-Reply-To: <1840978666.35282655.1345532940834.JavaMail.root@redhat.com> Subject: pcp updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.50.220] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1345532973 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106268 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp.git dev [mega-diffstat excluded for sake of brevity and clarity] commit 01c2a2f422a28187499e1c0af97bfd7c017c6280 Author: Nathan Scott Date: Tue Aug 21 16:33:16 2012 +1000 Further janitorial work on the PCP QA suite. In particular: - update the build with new pconf/cisco subdir makefiles - update other subdir makefiles with GNUmakefile.install variants which do the right thing for the installed pcp testsuite builds. - switch back to the original qa/src naming convention to match up with pcp-gui (and back the way nature intended), seems like noone is around anymore who needs it back the other way still. - remove unused _getversions shell code from mk.localconfig - remove unused PCP_EOE_NOSHIP macro, an IRIX leftover from yester-year commit 3572f02180be0d59ff5f678fdffc1eafe0c0b908 Author: Nathan Scott Date: Tue Aug 21 14:33:28 2012 +1000 Revert "Replace cisco and pconf directories" This reverts commit e12cd6111edaa0ff6d4a3e3a5c4081c0d12820bd. After discussing with Ken, revert using checked-in tarball files for qa/cisco.tar and qa/pconf.tar - go back to subdirs and I'll create come makefiles. commit 084302a1b58663d945e2211a192880fd33b7994d Author: Nathan Scott Date: Tue Aug 21 14:32:07 2012 +1000 Revert "Add missing tarballs." This reverts commit 5135fa5644080ee3de9ed8b5fba72bfe36698273. After discussing with Ken, revert using checked-in tarball files for qa/cisco.tar and qa/pconf.tar - go back to subdirs and I'll create come makefiles. commit 0b3413554aa80620f44b426b6ff61c080b098310 Author: Nathan Scott Date: Tue Aug 21 14:25:04 2012 +1000 Fix ignored fwrite return code compiler warning in qa tests. From nscott@redhat.com Tue Aug 21 05:02:04 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7LA230H065057 for ; Tue, 21 Aug 2012 05:02:04 -0500 X-ASG-Debug-ID: 1345543322-04cb6c3c716c8f10001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id UR6k5jJD9nrwPPHz for ; Tue, 21 Aug 2012 03:02:02 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7LA21gU028677 for ; Tue, 21 Aug 2012 06:02:02 -0400 Date: Tue, 21 Aug 2012 06:02:01 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1189472773.35750527.1345543321735.JavaMail.root@redhat.com> Subject: pcp updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.50.220] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1345543322 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106280 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp.git dev qa/mk.localconfig | 2 qa/pconf/memory/GNUmakefile | 2 qa/pmdas/GNUmakefile | 1 qa/pmdas/bigun/GNUmakefile | 33 +++-------- qa/pmdas/bigun/GNUmakefile.install | 43 ++++++++++++++ qa/pmdas/broken/GNUmakefile | 44 +++++---------- qa/pmdas/broken/GNUmakefile.install | 104 ++++++++++++++++++++++++++++++++++++ qa/src/GNUmakefile | 27 ++------- 8 files changed, 182 insertions(+), 74 deletions(-) commit 3e16423d2e03a0b545b6ddd54f8b43fe3f6d213a Author: Nathan Scott Date: Tue Aug 21 20:01:10 2012 +1000 Ensure QA PMDAs built during the build do not assume PCP is installed commit 1cddad64039b1c0d418968272db3d7779ad70b2b Author: Nathan Scott Date: Tue Aug 21 19:29:42 2012 +1000 When building qa in-tree, use the -I/-L options for local headers/libs commit 99197b1dd16c8fb4f4155a005cf50fcdcb5eb555 Author: Nathan Scott Date: Tue Aug 21 19:29:14 2012 +1000 Fix long-missed parameterisation of sudo in mk.localconfig commit 80a95d6c88f211c6501e2bbcf20fe6b15f8c7f34 Author: Nathan Scott Date: Tue Aug 21 17:08:15 2012 +1000 Small qa makefile tweaks for subdirs and installed makefiles From nscott@redhat.com Tue Aug 21 08:11:26 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7LDBPr4083420 for ; Tue, 21 Aug 2012 08:11:26 -0500 X-ASG-Debug-ID: 1345554684-04cbb050ce6cf510001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id VjEblDjlKufNLD2o for ; Tue, 21 Aug 2012 06:11:25 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7LDBOE4028296 for ; Tue, 21 Aug 2012 09:11:24 -0400 Date: Tue, 21 Aug 2012 09:11:24 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <889599296.36284702.1345554684164.JavaMail.root@redhat.com> Subject: pcp updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.50.220] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1345554684 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106292 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp.git dev Makepkgs | 7 ++--- debian/libpcp-pmda3-dev.install | 24 +++++++++++++++++ debian/libpcp3-dev.install | 37 +++++++++++++++++++++++++-- debian/rules | 6 ++-- qa/008 | 11 ++------ qa/008.out.smash | 54 ++++++++++++++++++++++++++++++++++++++++ qa/022 | 7 ++--- qa/022.irix.0 | 2 - qa/022.irix.1 | 2 - qa/022.linux | 2 - qa/022.linux.1 | 2 - qa/022.linux.2 | 2 - qa/371 | 14 +++------- qa/372 | 14 +++------- qa/373 | 14 +++------- qa/pmdas/bigun/GNUmakefile | 1 qa/src/mirage-2.0 |binary src/python/GNUmakefile | 4 ++ 18 files changed, 151 insertions(+), 52 deletions(-) commit 403451f8ebc7c7fcac39c01acefa5c5c374ac3ed Author: Nathan Scott Date: Tue Aug 21 23:09:48 2012 +1000 Add sysconfdir(/etc) and localstatedir(/var) to Makepkgs configure set commit 1104363a403de041bc37e38607b16fd12e69a97f Author: Nathan Scott Date: Tue Aug 21 23:06:17 2012 +1000 Add other configure options needed for Debian builds beyond --prefix commit 0a150ab67f0b512bde16c48c171f7bebde090d94 Author: Nathan Scott Date: Tue Aug 21 23:05:28 2012 +1000 Ensure devel man pages packaged into the right bins for debian commit 72928f8f2b661c728867ab0e11acc0d9da55c770 Author: Nathan Scott Date: Tue Aug 21 23:01:33 2012 +1000 Ensure make clean handles python build products commit 502f69cbb6349909844e58904cefbad77eefbc30 Author: Nathan Scott Date: Tue Aug 21 23:00:47 2012 +1000 Cleanup 008 notrun handling, add new QA machine commit c4d496f45b9f5dd0ae4a761fc3c67c93abdfceb9 Author: Nathan Scott Date: Tue Aug 21 22:58:52 2012 +1000 Update notrun messages for missing perl modules for clarity commit bf54fb2ac74354e3d0306edc9b73de6cdefdaf2d Author: Nathan Scott Date: Tue Aug 21 21:21:04 2012 +1000 Tighten up notrun checks on installed perl modules for QA testing commit c4d066ab41411035b2c629a229d66e2194efa31d Author: Nathan Scott Date: Tue Aug 21 21:20:05 2012 +1000 Fix mirage archive use of outdated paths commit 399fd033b8984719d30827b29da2417b14b116ba Author: Nathan Scott Date: Tue Aug 21 20:52:18 2012 +1000 Fix proc filters in test 022, incorrect for latest proc PMDA. commit 83cb8088d681ae13c16f678726f35a382862d9df Author: Nathan Scott Date: Tue Aug 21 20:38:59 2012 +1000 Remove duplicate macro from QA bigun PMDA makefile From nscott@redhat.com Wed Aug 22 00:50:42 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7M5og0X023702 for ; Wed, 22 Aug 2012 00:50:42 -0500 X-ASG-Debug-ID: 1345614687-04cbb050cd705810001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id HHoBIIBwO3bgxWy6 for ; Tue, 21 Aug 2012 22:51:27 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7M5pQ1O013450 for ; Wed, 22 Aug 2012 01:51:26 -0400 Date: Wed, 22 Aug 2012 01:51:26 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <745497241.38700338.1345614686552.JavaMail.root@redhat.com> Subject: pcp-gui updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp-gui updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.51.20] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1345614687 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106360 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp-gui.git dev qa/016 | 4 +++- qa/016.out | 36 +++++++++++++++++++++--------------- qa/023 | 2 +- qa/024 | 16 ++++++++++++++-- qa/026 | 6 +++--- qa/src/GNUmakefile.install | 2 +- qa/src/dynamic/GNUmakefile | 5 +++-- qa/src/qmc_context/GNUmakefile | 1 + qa/src/qmc_desc/GNUmakefile | 1 + qa/src/qmc_dynamic/GNUmakefile | 1 + qa/src/qmc_format/GNUmakefile | 1 + qa/src/qmc_group/GNUmakefile | 1 + qa/src/qmc_group/qmc_group.cpp | 6 ------ qa/src/qmc_hosts/GNUmakefile | 1 + qa/src/qmc_indom/GNUmakefile | 1 + qa/src/qmc_metric/GNUmakefile | 1 + qa/src/qmc_source/GNUmakefile | 1 + src/GNUmakefile | 4 ++-- src/chart/view.cpp | 4 +++- src/libqmc/qmc_metric.cpp | 37 +++++++++++++++++++++++++------------ src/time/main.cpp | 6 ++++-- 21 files changed, 89 insertions(+), 48 deletions(-) commit d19c171ee99020f0eac75ab351471cb2ff0b8ca3 Author: Nathan Scott Date: Wed Aug 22 15:35:39 2012 +1000 Remove accidentally introduced dup "clean" target in src makefile commit 49850798bccce945ba950fa7fdbe2c7d168f4955 Author: Nathan Scott Date: Wed Aug 22 15:31:53 2012 +1000 Use the right -G option for Qt-based pmdumptext, -g is pmtime mode This resolves an issue uncovered by pcp-gui-testsuite QA test 023. commit 62b14d0119983e89d59e36bce0c3479704c5811a Author: Nathan Scott Date: Wed Aug 22 15:25:14 2012 +1000 Ensure string names are dupd on some Qmc error paths where required This resolves an issue uncovered by pcp-gui-testsuite QA test 017. commit ac996c8919aa5df559435864e275f0ea606f7c4f Author: Nathan Scott Date: Wed Aug 22 15:24:26 2012 +1000 Use correct installed makefile name for pmdadynamic test agent commit b8a73300513b937cc72d543bcb35ade128bfe892 Author: Nathan Scott Date: Wed Aug 22 14:43:58 2012 +1000 Update couple of comments in test cases commit db649d1764d7ff76b62510d8e7275a66f51009c6 Author: Nathan Scott Date: Wed Aug 22 14:39:09 2012 +1000 Test 016 fail - was not finding the oview-short archive commit 5d46f0ea7a8dad6c11758a34441aa1be66820031 Author: Nathan Scott Date: Wed Aug 22 14:33:37 2012 +1000 Install Qt test sources alongside binaries commit 95bbb19cdc6dd1d3e785de82e0ac60e6bcc97f11 Author: Nathan Scott Date: Wed Aug 22 14:29:40 2012 +1000 Minor fix for test 006 race condition, pmchart may exit before last pmtime write commit e30a4f674c8dbbfc9e646aa7b9115a40701876b1 Author: Nathan Scott Date: Wed Aug 22 14:25:55 2012 +1000 Add missing else clause from previous commit commit 394a4c94eb3e88327d5fd43b89f5a11846e74623 Author: Nathan Scott Date: Wed Aug 22 14:22:55 2012 +1000 Test 024 found an incompatibility with old SGI pmchart configs commit 9c578cc8f1aa0df746ed916d9dbf585315fc030b Author: Nathan Scott Date: Wed Aug 22 14:21:54 2012 +1000 Obtain prefered X server from PCP QA config commit 1922b22143414d89535306057ea9ad0ec49591dd Author: Nathan Scott Date: Wed Aug 22 14:21:09 2012 +1000 Correct path to common file in test 026 From nscott@redhat.com Wed Aug 22 03:23:39 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7M8NceN026281 for ; Wed, 22 Aug 2012 03:23:39 -0500 X-ASG-Debug-ID: 1345623862-04cb6c3c707139c0001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id J7mGx5QYGeXEivTF for ; Wed, 22 Aug 2012 01:24:23 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7M8OM8i007073 for ; Wed, 22 Aug 2012 04:24:22 -0400 Date: Wed, 22 Aug 2012 04:24:22 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <28887984.38991140.1345623862643.JavaMail.root@redhat.com> In-Reply-To: <288277672.38986861.1345623816944.JavaMail.root@redhat.com> Subject: pcp-gui updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp-gui updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.51.20] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1345623863 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106370 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp-gui.git dev qa/018.out | 6 qa/019 | 31 +- qa/019.out | 7 qa/020 | 28 +- qa/020.out | 7 qa/026 | 11 qa/GNUmakefile | 2 qa/GNUmakefile.install | 2 qa/common.check | 39 --- qa/common.filter | 60 +++- qa/pmdas/GNUmakefile | 25 ++ qa/pmdas/GNUmakefile.install | 26 ++ qa/pmdas/dynamic/.gitignore | 1 qa/pmdas/dynamic/GNUmakefile | 33 ++ qa/pmdas/dynamic/GNUmakefile.install | 38 +++ qa/pmdas/dynamic/Install | 33 ++ qa/pmdas/dynamic/Remove | 14 + qa/pmdas/dynamic/domain.h | 1 qa/pmdas/dynamic/dynamic.c | 415 ++++++++++++++++++++++++++++++++++ qa/pmdas/dynamic/help | 25 ++ qa/pmdas/dynamic/pmns | 18 + qa/pmdas/dynamic/root | 5 qa/src/GNUmakefile | 2 qa/src/dynamic/GNUmakefile | 17 - qa/src/dynamic/GNUmakefile.install | 38 --- qa/src/dynamic/Install | 33 -- qa/src/dynamic/Remove | 14 - qa/src/dynamic/domain.h | 1 qa/src/dynamic/dynamic.c | 423 ----------------------------------- qa/src/dynamic/help | 25 -- qa/src/dynamic/pmns | 18 - src/libqmc/qmc_source.cpp | 1 src/libqmc/qmc_source.h | 2 33 files changed, 730 insertions(+), 671 deletions(-) commit 90136f29def192a000e9e089e73d5f8ce42f381f Author: Nathan Scott Date: Wed Aug 22 18:21:56 2012 +1000 Clean up notrun handling in test 026 commit 0aeec0af6a97ab6f71d79c21f3f45af54024a4ad Author: Nathan Scott Date: Wed Aug 22 18:16:27 2012 +1000 Updates to pcp-gui QA to get the dynamic PMDA tests going Involves bringing the dynamic PMDA a bit more uptodate, running the build and installation more like the "bigun" PMDA in PCP QA, and then removing the old install calls. 019 still fails (020 is good), needs code investigation at this point though (libqmc). commit b34bfa5ced4aa40c44cd2ce9f9533611eb47cf3b Author: Nathan Scott Date: Wed Aug 22 16:55:56 2012 +1000 Changes to reach a stable QA test 018 These changes involve updated filters for PCP start/stop scripts, and class field initialisation for the timezone field in QmcSource class. From nscott@redhat.com Wed Aug 22 20:28:36 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7N1SaEZ098321 for ; Wed, 22 Aug 2012 20:28:36 -0500 X-ASG-Debug-ID: 1345685360-04cbb050ce74bff0001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id FEuPh6XSVpbLnzmd for ; Wed, 22 Aug 2012 18:29:21 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7N1TKBT009177 for ; Wed, 22 Aug 2012 21:29:20 -0400 Date: Wed, 22 Aug 2012 21:29:20 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1538901681.41727619.1345685360490.JavaMail.root@redhat.com> Subject: pcp updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.176.205] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - GC12 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1345685361 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106438 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- committed to git://oss.sgi.com/pcp/pcp.git dev qa/GNUmakefile | 17 +++++++++++---- qa/GNUmakefile.install | 7 ++---- qa/mk.localconfig | 46 ++++++++++--------------------------------- qa/mk.pcpversion | 15 ++++++++++++++ qa/pmdas/bigun/GNUmakefile | 2 - qa/pmdas/broken/GNUmakefile | 2 - qa/pmdas/dynamic/GNUmakefile | 12 +++++------ qa/src/GNUlocaldefs | 3 -- qa/src/GNUmakefile | 11 +++------- qa/src/GNUmakefile.install | 4 +++ 10 files changed, 57 insertions(+), 62 deletions(-) commit 031d8eef5c4ccabaf4c4e96e07849bd419e49199 Merge: 7a35396 c52210e Author: Nathan Scott Date: Thu Aug 23 11:27:01 2012 +1000 Merge branch 'dev' of ssh://oss.sgi.com/oss/git/pcp/pcp into dev commit 7a353967d66a1a2a968a6434dc47050c7fd9642a Author: Nathan Scott Date: Thu Aug 23 10:53:18 2012 +1000 Update the QA suite so that no files from the root are used Reworked the mk.localconfig script and the makefile rules around it, as it was the main offender. commit c52210e40e39ca20cfa50dab5294c5d81f49fdc4 Author: Nathan Scott Date: Thu Aug 23 08:36:49 2012 +1000 Update macros in dynamic PMDA makefile From mgoodwin@redhat.com Wed Aug 22 21:49:03 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7N2n2GT110507 for ; Wed, 22 Aug 2012 21:49:02 -0500 X-ASG-Debug-ID: 1345690187-04cbb050cc7502e0001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id dXloF1y6tj7TMLWq for ; Wed, 22 Aug 2012 19:49:48 -0700 (PDT) X-Barracuda-Envelope-From: mgoodwin@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7N2nlAC023850 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 22 Aug 2012 22:49:47 -0400 Received: from fletch.usersys.redhat.com (dhcp-176-236.mel.redhat.com [10.64.176.236]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7N2nkW4002643 for ; Wed, 22 Aug 2012 22:49:47 -0400 Message-ID: <50359A49.30703@redhat.com> Date: Thu, 23 Aug 2012 12:49:45 +1000 From: Mark Goodwin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: pcp Subject: pcp updates Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-ASG-Orig-Subj: pcp updates Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1345690188 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com Changes committed to git://oss.sgi.com/pcp/pcp.git dev commit de09017b4c8a4d781793309d724e4504bb00498a Merge: 4a3de61 49208e5 Author: Mark Goodwin Date: Thu Aug 23 12:47:13 2012 +1000 Merge branch 'dev' of git://oss.sgi.com/pcp/pcp into dev commit 4a3de61acc0d00fd6b748dc5a40a98b3d0555c89 Author: Mark Goodwin Date: Thu Aug 23 12:45:17 2012 +1000 Fix QA build to not use libraries from the build root since they're not installed in a distro build (e.g. Fedora spec driven build). modified: qa/pmdas/bigun/GNUmakefile modified: qa/pmdas/broken/GNUmakefile modified: qa/pmdas/dynamic/GNUmakefile modified: qa/src/GNUlocaldefs From mgoodwin@redhat.com Wed Aug 22 23:41:34 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7N4fYmA128852 for ; Wed, 22 Aug 2012 23:41:34 -0500 X-ASG-Debug-ID: 1345696940-04bdf034577d5fb0001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id 3QMY4AD320KlYmEa for ; Wed, 22 Aug 2012 21:42:20 -0700 (PDT) X-Barracuda-Envelope-From: mgoodwin@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7N4gKHU016387 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 23 Aug 2012 00:42:20 -0400 Received: from fletch.usersys.redhat.com (dhcp-176-236.mel.redhat.com [10.64.176.236]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7N4gIcU004928 for ; Thu, 23 Aug 2012 00:42:19 -0400 Message-ID: <5035B4A9.5040209@redhat.com> Date: Thu, 23 Aug 2012 14:42:17 +1000 From: Mark Goodwin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: pcp Subject: pcp updates Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-ASG-Orig-Subj: pcp updates Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1345696940 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com Changes committed to git://oss.sgi.com/pcp/pcp.git dev commit e42d60296a6a5519b1d03b1ab58b711ea2eeca83 Author: Mark Goodwin Date: Thu Aug 23 14:31:54 2012 +1000 Bring the current spec used to build on Fedora and RHEL back under source control since we'll be unifying this with other RPM based distros (e.g. OpenSuSE, etc). To build for Fedora, this should be updated and committed, and then copied over for fedpkg to chew on. new file: build/rpm/fedora.spec commit f529a1249c7130586461546e7fe2fecd524cc191 Author: Mark Goodwin Date: Thu Aug 23 12:52:36 2012 +1000 Add more LDFLAGS for other libraries built in qa. modified: qa/src/GNUmakefile From mgoodwin@redhat.com Thu Aug 23 00:24:14 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7N5O3CW140745 for ; Thu, 23 Aug 2012 00:24:06 -0500 X-ASG-Debug-ID: 1345699489-04bdf034547d8470001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id Ipem4sXf4KSXOrk3 for ; Wed, 22 Aug 2012 22:24:49 -0700 (PDT) X-Barracuda-Envelope-From: mgoodwin@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7N5OnSv020902 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 23 Aug 2012 01:24:49 -0400 Received: from fletch.usersys.redhat.com (dhcp-176-236.mel.redhat.com [10.64.176.236]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7N5Olip031992 for ; Thu, 23 Aug 2012 01:24:48 -0400 Message-ID: <5035BE9F.5010802@redhat.com> Date: Thu, 23 Aug 2012 15:24:47 +1000 From: Mark Goodwin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: pcp Subject: pcp-gui updates Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-ASG-Orig-Subj: pcp-gui updates Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1345699489 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com Changes committed to git://oss.sgi.com/pcp/pcp-gui.git dev commit 59909912f69876793e8685305cecd3974339d482 Author: Mark Goodwin Date: Thu Aug 23 15:08:13 2012 +1000 Move the fedora spec for pcp-gui under source control. This currently needs an update for the latest version of pcp-gui. new file: build/rpm/fedora.spec From nscott@redhat.com Thu Aug 23 01:32:15 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7N6WE3R155312 for ; Thu, 23 Aug 2012 01:32:15 -0500 X-ASG-Debug-ID: 1345703580-04bdf0655b596f0001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id NpHniiydI7VSAdP3 for ; Wed, 22 Aug 2012 23:33:00 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7N6X0Nj016732 for ; Thu, 23 Aug 2012 02:33:00 -0400 Date: Thu, 23 Aug 2012 02:33:00 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <316932083.42177910.1345703580183.JavaMail.root@redhat.com> Subject: pcp-gui updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp-gui updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.176.205] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - GC12 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1345703580 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106458 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp-gui.git dev build/GNUmakefile | 4 ++-- build/rpm/fedora.spec | 39 ++++++++++++++++++++++++++++++++------- build/tar/GNUmakefile | 2 +- 3 files changed, 35 insertions(+), 10 deletions(-) commit 706e462b05af0a5935e4ede82b3c30b0cd18ed5c Author: Nathan Scott Date: Thu Aug 23 16:31:31 2012 +1000 Update generated src/bin tarball names to include release number commit 897a0869872a2e4003aeefc7a66eee0c84c0b414 Author: Nathan Scott Date: Thu Aug 23 15:56:22 2012 +1000 Add testsuite sub-package to pcp-gui fedora specfile From nscott@redhat.com Thu Aug 23 05:30:25 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7NAUPR6207669 for ; Thu, 23 Aug 2012 05:30:25 -0500 X-ASG-Debug-ID: 1345717870-04cb6c3c7376f250001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id EVEV9kM9GTkRBdjk for ; Thu, 23 Aug 2012 03:31:10 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7NAV9lF015675 for ; Thu, 23 Aug 2012 06:31:09 -0400 Date: Thu, 23 Aug 2012 06:31:09 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <797120307.42829979.1345717869835.JavaMail.root@redhat.com> Subject: pcp updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.51.62] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1345717870 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106474 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp.git dev build/rpm/fedora.spec | 7 ++++--- build/rpm/pcp.spec.in | 2 +- debian/control | 2 +- qa/054 | 8 +++++++- qa/077 | 6 ++---- qa/115 | 7 ++++--- qa/340 | 7 +++++-- qa/347 | 3 +++ qa/453 | 3 +++ qa/GNUmakefile | 4 ++-- qa/GNUmakefile.install | 4 ++-- qa/common | 31 ++----------------------------- 12 files changed, 36 insertions(+), 48 deletions(-) commit 962c741b34c470608565b76c01495e4992f3fa05 Author: Nathan Scott Date: Thu Aug 23 20:29:59 2012 +1000 Improve some tests notrun handling when perl modules missing commit 82b3b65eb16931d48208903301171c570fcd367c Author: Nathan Scott Date: Thu Aug 23 20:29:27 2012 +1000 Improve some tests notrun handling when getpmcdhosts finds none commit 72da3bb9fcf320f3ff05c24da36511bc573e6cda Author: Nathan Scott Date: Thu Aug 23 20:28:34 2012 +1000 Add pcp-testsuite package dependency on valgrind commit ba9586f2c98409fa4d36775c0dae4c88dc4b0573 Author: Nathan Scott Date: Thu Aug 23 16:36:06 2012 +1000 Ensure the path to testsuite is consistent thru spec file commit 1e5191266ae58ac3de888fea3c742a1fea1c245f Author: Nathan Scott Date: Thu Aug 23 15:13:56 2012 +1000 Install common script with execute bit set, simplify use of make setup From nscott@redhat.com Thu Aug 23 05:56:05 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7NAu306213160 for ; Thu, 23 Aug 2012 05:56:05 -0500 X-ASG-Debug-ID: 1345719408-04bdf0655b686d0001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id gzaotJkMsoRAUCOt for ; Thu, 23 Aug 2012 03:56:49 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7NAumrK020337 for ; Thu, 23 Aug 2012 06:56:48 -0400 Date: Thu, 23 Aug 2012 06:56:48 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1324061567.42892768.1345719408881.JavaMail.root@redhat.com> In-Reply-To: <721525907.42880333.1345719062753.JavaMail.root@redhat.com> Subject: New dependencies for the PCP RPM packages MIME-Version: 1.0 X-ASG-Orig-Subj: New dependencies for the PCP RPM packages Content-Type: multipart/mixed; boundary="----=_Part_42892766_226563857.1345719408880" X-Originating-IP: [10.64.51.62] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1345719409 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106476 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- ------=_Part_42892766_226563857.1345719408880 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi all, Mark and I discussed putting an explicit dependency on the perl-PCP-PMDA package on the (core) pcp package. See the attached patch, for example. Something similar will also be done for the new python sub-package (if it turns not to not be simpler to just include that in the pcp rpm). This will remove one class of entirely-avoidable dependency issue (for the >20 perl PMDAs in pcp) - since perl & python are always installed on modern Linux distros, we couldn't foresee any issues. Anyone have any thoughts/concerns? thanks! -- Nathan ------=_Part_42892766_226563857.1345719408880 Content-Type: text/x-patch; name=pcp-spec.patch Content-Disposition: attachment; filename=pcp-spec.patch Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2J1aWxkL3JwbS9mZWRvcmEuc3BlYyBiL2J1aWxkL3JwbS9mZWRvcmEuc3Bl YwppbmRleCBjZGQzZjU0Li4wYmE5NTQ5IDEwMDY0NAotLS0gYS9idWlsZC9ycG0vZmVkb3JhLnNw ZWMKKysrIGIvYnVpbGQvcnBtL2ZlZG9yYS5zcGVjCkBAIC0xNCw4ICsxNCw4IEBAIEJ1aWxkUmVx dWlyZXM6IHByb2NwcyBhdXRvY29uZiBiaXNvbiBmbGV4IG5jdXJzZXMtZGV2ZWwgcmVhZGxpbmUt ZGV2ZWwKIEJ1aWxkUmVxdWlyZXM6IHBlcmwoRXh0VXRpbHM6Ok1ha2VNYWtlcikKIEJ1aWxkUmVx dWlyZXM6IGluaXRzY3JpcHRzIHB5dGhvbi1kZXZlbCBtYW4tZGIgaG9zdG5hbWUKICAKLVJlcXVp cmVzOiBiYXNoIGdhd2sgc2VkIGdyZXAgZmlsZXV0aWxzIGZpbmR1dGlscyBpbml0c2NyaXB0cyBw eXRob24KLVJlcXVpcmVzOiBwY3AtbGlicyA9ICV7dmVyc2lvbn0KK1JlcXVpcmVzOiBiYXNoIGdh d2sgc2VkIGdyZXAgZmlsZXV0aWxzIGZpbmR1dGlscyBpbml0c2NyaXB0cyBwZXJsIHB5dGhvbgor UmVxdWlyZXM6IHBjcC1saWJzID0gJXt2ZXJzaW9ufSBwZXJsLVBDUC1QTURBID0gJXt2ZXJzaW9u fQogCiAlZGVmaW5lIF9wbWRhc2RpciAle19sb2NhbHN0YXRlZGlyfS9saWIvcGNwL3BtZGFzCiAl ZGVmaW5lIF90ZXN0c2RpciAle19sb2NhbHN0YXRlZGlyfS9saWIvcGNwL3Rlc3RzdWl0ZQpAQCAt NzYsNyArNzYsNyBAQCBMaWNlbnNlOiBHUEx2MgogR3JvdXA6IEFwcGxpY2F0aW9ucy9TeXN0ZW0K IFN1bW1hcnk6IFBlcmZvcm1hbmNlIENvLVBpbG90IChQQ1ApIFBlcmwgYmluZGluZ3MgYW5kIGRv Y3VtZW50YXRpb24KIFVSTDogaHR0cDovL29zcy5zZ2kuY29tL3Byb2plY3RzL3BjcC8KLVJlcXVp cmVzOiBwY3AgPj0gJXt2ZXJzaW9ufQorUmVxdWlyZXM6IHBjcC1saWJzID0gJXt2ZXJzaW9ufQog CiAlZGVzY3JpcHRpb24gLW4gcGVybC1QQ1AtUE1EQQogVGhlIFBDUDo6UE1EQSBQZXJsIG1vZHVs ZSBjb250YWlucyB0aGUgbGFuZ3VhZ2UgYmluZGluZ3MgZm9yCmRpZmYgLS1naXQgYS9idWlsZC9y cG0vcGNwLnNwZWMuaW4gYi9idWlsZC9ycG0vcGNwLnNwZWMuaW4KaW5kZXggMzQ5ZjdmMy4uYWJk ODYxOSAxMDA2NDQKLS0tIGEvYnVpbGQvcnBtL3BjcC5zcGVjLmluCisrKyBiL2J1aWxkL3JwbS9w Y3Auc3BlYy5pbgpAQCAtMjEsMTQgKzIxLDE0IEBAIEJ1aWxkUmVxdWlyZXM6IGluaXRzY3JpcHRz CiBDb25mbGljdHM6IHBjcC1wcm8gPCAyLjIKIAogIyBTdHVmZiB1c2VkIGluZGlyZWN0bHkgZS5n LiBieSBzaGVsbCBzY3JpcHRzIHdlIGluc3RhbGwKLVJlcXVpcmVzOiBiYXNoIGdhd2sgc2VkIGdy ZXAgY29yZXV0aWxzIGZpbmR1dGlscworUmVxdWlyZXM6IGJhc2ggZ2F3ayBzZWQgZ3JlcCBjb3Jl dXRpbHMgZmluZHV0aWxzIHBlcmwgcHl0aG9uCiAlaWYgIiV7X3ZlbmRvcn0iID09ICJzdXNlIgog UmVxdWlyZXM6IHN5c2NvbmZpZwogJWVsc2UKIFJlcXVpcmVzOiBpbml0c2NyaXB0cwogJWVuZGlm CiAKLVJlcXVpcmVzOiBwY3AtbGlicyA9IEBwYWNrYWdlX3ZlcnNpb25ACitSZXF1aXJlczogcGNw LWxpYnMgPSBAcGFja2FnZV92ZXJzaW9uQCBwZXJsLVBDUC1QTURBID0gQHBhY2thZ2VfdmVyc2lv bkAKIAogJWRlc2NyaXB0aW9uCiBQZXJmb3JtYW5jZSBDby1QaWxvdCAoUENQKSBwcm92aWRlcyBh IGZyYW1ld29yayBhbmQgc2VydmljZXMgdG8gc3VwcG9ydApAQCAtODksNyArODksNyBAQCBMaWNl bnNlOiBHUEx2MgogR3JvdXA6IEFwcGxpY2F0aW9ucy9TeXN0ZW0KIFN1bW1hcnk6IFBlcmZvcm1h bmNlIENvLVBpbG90IChQQ1ApIFBlcmwgYmluZGluZ3MgYW5kIGRvY3VtZW50YXRpb24KIFVSTDog aHR0cDovL29zcy5zZ2kuY29tL3Byb2plY3RzL3BjcC8KLVJlcXVpcmVzOiBwY3AgPj0gQHBhY2th Z2VfdmVyc2lvbkAKK1JlcXVpcmVzOiBwY3AtbGlicyA9IEBwYWNrYWdlX3ZlcnNpb25ACiAKICVk ZXNjcmlwdGlvbiAtbiBwZXJsLVBDUC1QTURBCiBUaGUgUENQOjpQTURBIFBlcmwgbW9kdWxlIGNv bnRhaW5zIHRoZSBsYW5ndWFnZSBiaW5kaW5ncyBmb3IK ------=_Part_42892766_226563857.1345719408880-- From jhanson@sgi.com Thu Aug 23 06:24:05 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7NBO45m219408 for ; Thu, 23 Aug 2012 06:24:05 -0500 Received: from xmail.sgi.com (pv-excas1-dc21-nlb.corp.sgi.com [137.38.102.126]) by relay2.corp.sgi.com (Postfix) with ESMTP id BFBD8304053; Thu, 23 Aug 2012 04:24:48 -0700 (PDT) Received: from carenath.corp.sgi.com (134.15.95.84) by xmail.sgi.com (137.38.102.30) with Microsoft SMTP Server (TLS) id 14.1.339.1; Thu, 23 Aug 2012 06:24:48 -0500 Message-ID: <503612FF.70206@sgi.com> Date: Thu, 23 Aug 2012 07:24:47 -0400 From: Jeff Hanson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.6esrpre) Gecko/20120714 Thunderbird/10.0.6 MIME-Version: 1.0 To: Nathan Scott CC: Subject: Re: [pcp] New dependencies for the PCP RPM packages References: <1324061567.42892768.1345719408881.JavaMail.root@redhat.com> In-Reply-To: <1324061567.42892768.1345719408881.JavaMail.root@redhat.com> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [134.15.95.84] On 08/23/2012 06:56 AM, Nathan Scott wrote: > Hi all, > > Mark and I discussed putting an explicit dependency on the > perl-PCP-PMDA package on the (core) pcp package. See the > attached patch, for example. Something similar will also > be done for the new python sub-package (if it turns not to > not be simpler to just include that in the pcp rpm). > > This will remove one class of entirely-avoidable dependency > issue (for the >20 perl PMDAs in pcp) - since perl & python > are always installed on modern Linux distros, we couldn't > foresee any issues. > > Anyone have any thoughts/concerns? In SGI's ICE products we try to keep the compute node image small especially when the OS is a tmpfs filesystem (and hence all in memory). The list that drives the smallest image has pcp and python but not perl. Adding in (I just reviewed for sles) all that would be needed would increase the image size by something like 20MB. This is not a significant increase. I believe most customers have much more robust environments so requiring perl and python is not an issue. -- ----------------------------------------------------------------------- Jeff Hanson - jhanson@sgi.com - Field Technical Analyst You can choose a ready guide in some celestial voice. If you choose not to decide, you still have made a choice. You can choose from phantom fears and kindness that can kill; I will choose a path that's clear I will choose freewill. - Lee/Lifeson/Peart From nscott@redhat.com Thu Aug 23 16:32:51 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,J_CHICKENPOX_54 autolearn=no version=3.4.0-r929098 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7NLWpTU074867 for ; Thu, 23 Aug 2012 16:32:51 -0500 X-ASG-Debug-ID: 1345757614-04cbb050cd79cca0001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id mfJkUHRvQxJIS2X0 for ; Thu, 23 Aug 2012 14:33:34 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7NLXXOC025998 for ; Thu, 23 Aug 2012 17:33:33 -0400 Date: Thu, 23 Aug 2012 17:33:33 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1087821767.266467.1345757613705.JavaMail.root@redhat.com> Subject: pcp updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.51.62] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1345757614 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106518 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp.git dev src/pmcd/pmdaproc.sh | 28 +++++++++++++++++----------- src/python/.gitignore | 2 ++ 2 files changed, 19 insertions(+), 11 deletions(-) commit ce42a5a050354f842e88bfa2cea8a7009095ddff Merge: 68ddd17 f2e6927 Author: Ken McDonell Date: Fri Aug 24 06:59:17 2012 +1000 Merge branch 'dev' of git://oss.sgi.com/pcp/pcp into dev commit f2e6927a8c5343fb0ee056c3e74d7b4c9a652d4a Author: Nathan Scott Date: Thu Aug 23 21:00:37 2012 +1000 Add to the python gitignore set commit 68ddd177ceb6a01692c5d4b20d57f566a63374f8 Merge: 936801d d773da9 Author: Ken McDonell Date: Fri Aug 10 08:58:53 2012 +1000 Merge branch 'dev' of git://oss.sgi.com/pcp/pcp into dev commit 936801de31e5e38c6c1757d8a778e9e2d70443db Author: Ken McDonell Date: Tue Aug 7 21:26:26 2012 +1000 pmdaproc.sh - better post-install checks As part of the linux -> linux+proc PMDA split, discovered that using pminfo to probe metrics is not as robust as it needs to be when metric instance values are long and "odd" (like the proc PMDA) ... switch to using pmprobe. From nscott@redhat.com Thu Aug 23 18:10:57 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,J_CHICKENPOX_54, URIBL_BLACK autolearn=no version=3.4.0-r929098 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7NNAuet094232 for ; Thu, 23 Aug 2012 18:10:57 -0500 X-ASG-Debug-ID: 1345763498-04cbb050ce7a29a0001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id Q6GJYVx1A4wTmYEB for ; Thu, 23 Aug 2012 16:11:39 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7NNBcMc008418 for ; Thu, 23 Aug 2012 19:11:38 -0400 Date: Thu, 23 Aug 2012 19:11:38 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1057422225.301956.1345763498599.JavaMail.root@redhat.com> Subject: pcp updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.51.62] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1345763499 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106523 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp.git dev build/rpm/fedora.spec | 6 build/rpm/pcp.spec.in | 6 configure | 44 + configure.in | 4 debian/rules | 8 dev/null |binary src/GNUmakefile | 10 src/cpan/.gitignore | 3 src/cpan/GNUmakefile | 49 - src/cpan/LogImport/.gitignore | 8 src/cpan/LogImport/Changes | 5 src/cpan/LogImport/GNUmakefile | 71 - src/cpan/LogImport/LogImport.pm | 122 --- src/cpan/LogImport/LogImport.xs | 118 --- src/cpan/LogImport/MANIFEST | 7 src/cpan/LogImport/Makefile.PL | 49 - src/cpan/LogImport/typemap | 24 src/cpan/LogSummary/.gitignore | 6 src/cpan/LogSummary/Changes | 8 src/cpan/LogSummary/GNUmakefile | 62 - src/cpan/LogSummary/LogSummary.pm | 117 --- src/cpan/LogSummary/MANIFEST | 20 src/cpan/LogSummary/Makefile.PL | 9 src/cpan/LogSummary/README | 32 src/cpan/LogSummary/exceldemo.pl | 89 -- src/cpan/LogSummary/extract.pl | 18 src/cpan/LogSummary/t/GNUmakefile | 12 src/cpan/LogSummary/t/app/GNUmakefile | 13 src/cpan/LogSummary/t/db/GNUmakefile | 13 src/cpan/LogSummary/t/test.t | 41 - src/cpan/MMV/.gitignore | 11 src/cpan/MMV/Changes | 12 src/cpan/MMV/GNUmakefile | 67 - src/cpan/MMV/MANIFEST | 9 src/cpan/MMV/MMV.pm | 120 --- src/cpan/MMV/MMV.xs | 379 ---------- src/cpan/MMV/Makefile.PL | 49 - src/cpan/MMV/server.pl | 101 -- src/cpan/MMV/test.pl | 25 src/cpan/MMV/typemap | 10 src/cpan/PMDA/.gitignore | 11 src/cpan/PMDA/Changes | 95 -- src/cpan/PMDA/GNUmakefile | 67 - src/cpan/PMDA/MANIFEST | 11 src/cpan/PMDA/Makefile.PL | 49 - src/cpan/PMDA/PMDA.pm | 168 ---- src/cpan/PMDA/PMDA.xs | 1170 ------------------------------- src/cpan/PMDA/cvalue.c | 155 ---- src/cpan/PMDA/local.c | 423 ----------- src/cpan/PMDA/local.h | 80 -- src/cpan/PMDA/test.pl | 93 -- src/cpan/PMDA/typemap | 27 src/include/builddefs.in | 3 src/perl/.gitignore | 3 src/perl/GNUmakefile | 49 + src/perl/LogImport/.gitignore | 8 src/perl/LogImport/Changes | 5 src/perl/LogImport/GNUmakefile | 71 + src/perl/LogImport/LogImport.pm | 122 +++ src/perl/LogImport/LogImport.xs | 118 +++ src/perl/LogImport/MANIFEST | 7 src/perl/LogImport/Makefile.PL | 49 + src/perl/LogImport/typemap | 24 src/perl/LogSummary/.gitignore | 6 src/perl/LogSummary/Changes | 8 src/perl/LogSummary/GNUmakefile | 62 + src/perl/LogSummary/LogSummary.pm | 117 +++ src/perl/LogSummary/MANIFEST | 20 src/perl/LogSummary/Makefile.PL | 9 src/perl/LogSummary/README | 32 src/perl/LogSummary/exceldemo.pl | 89 ++ src/perl/LogSummary/extract.pl | 18 src/perl/LogSummary/t/GNUmakefile | 12 src/perl/LogSummary/t/app/20081125.0 |binary src/perl/LogSummary/t/app/20081125.index |binary src/perl/LogSummary/t/app/20081125.meta |binary src/perl/LogSummary/t/app/20081126.0 |binary src/perl/LogSummary/t/app/20081126.index |binary src/perl/LogSummary/t/app/20081126.meta |binary src/perl/LogSummary/t/app/GNUmakefile | 13 src/perl/LogSummary/t/db/20081125.0 |binary src/perl/LogSummary/t/db/20081125.index |binary src/perl/LogSummary/t/db/20081125.meta |binary src/perl/LogSummary/t/db/20081126.0 |binary src/perl/LogSummary/t/db/20081126.index |binary src/perl/LogSummary/t/db/20081126.meta |binary src/perl/LogSummary/t/db/GNUmakefile | 13 src/perl/LogSummary/t/test.t | 41 + src/perl/MMV/.gitignore | 11 src/perl/MMV/Changes | 12 src/perl/MMV/GNUmakefile | 67 + src/perl/MMV/MANIFEST | 9 src/perl/MMV/MMV.pm | 120 +++ src/perl/MMV/MMV.xs | 379 ++++++++++ src/perl/MMV/Makefile.PL | 49 + src/perl/MMV/server.pl | 101 ++ src/perl/MMV/test.pl | 25 src/perl/MMV/typemap | 10 src/perl/PMDA/.gitignore | 11 src/perl/PMDA/Changes | 95 ++ src/perl/PMDA/GNUmakefile | 67 + src/perl/PMDA/MANIFEST | 11 src/perl/PMDA/Makefile.PL | 49 + src/perl/PMDA/PMDA.pm | 168 ++++ src/perl/PMDA/PMDA.xs | 1170 +++++++++++++++++++++++++++++++ src/perl/PMDA/cvalue.c | 155 ++++ src/perl/PMDA/local.c | 423 +++++++++++ src/perl/PMDA/local.h | 80 ++ src/perl/PMDA/test.pl | 93 ++ src/perl/PMDA/typemap | 27 src/pmcd/pmdaproc.sh | 28 src/python/GNUmakefile | 4 112 files changed, 4114 insertions(+), 4055 deletions(-) commit 3dc340fa4848349fcb8bc5724438e10f7671b1c0 Merge: 17fff72 597e800 Author: Nathan Scott Date: Fri Aug 24 09:00:02 2012 +1000 Merge branch 'fche/dev' of git://sourceware.org/git/pcpfans into dev commit 597e80054f90ef90c2a6bfb5c7dad51c7b37fa6e Merge: 800a67b ce42a5a Author: Frank Ch. Eigler Date: Thu Aug 23 18:59:26 2012 -0400 Merge remote-tracking branch 'pcp/dev' into fche/dev * pcp/dev: Add to the python gitignore set Improve some tests notrun handling when perl modules missing Improve some tests notrun handling when getpmcdhosts finds none Add pcp-testsuite package dependency on valgrind pmdaproc.sh - better post-install checks commit 17fff72a2a2bcfc300b7997c173278b9a49e5ce0 Author: Nathan Scott Date: Fri Aug 24 08:58:56 2012 +1000 Explicit rpm dependency on perl and perl-PCP-PMDA for pcp which has perl PMDAs commit 863b73546c34e6f343372e85b96d13a5f6c3e78b Author: Nathan Scott Date: Fri Aug 24 08:58:00 2012 +1000 Build file changes to support renamed src/perl path commit 800a67be165130a802970c4195dad2afb109ae3e Author: Frank Ch. Eigler Date: Thu Aug 23 18:39:17 2012 -0400 test commit 502fb9f0a199d2933af590b8292055024feb080b Author: Nathan Scott Date: Fri Aug 24 08:29:01 2012 +1000 Rename src/cpan to src/perl for clarity commit 87a051bea621686c6cab570b7968f469c514e96c Author: Frank Ch. Eigler Date: Thu Aug 23 18:17:59 2012 -0400 python: configury improvements * configure.in: Check for python presence on build system. * include/builddefs.in (PYTHON): Define. * src/GNUmakefile (SUBDIRS): Add python only conditionally. * src/python/GNUmakefile (SETUP_PY_INSTALL_OPTIONS): Prefix $$DIST_ROOT. commit ce42a5a050354f842e88bfa2cea8a7009095ddff Merge: 68ddd17 f2e6927 Author: Ken McDonell Date: Fri Aug 24 06:59:17 2012 +1000 Merge branch 'dev' of git://oss.sgi.com/pcp/pcp into dev commit 68ddd177ceb6a01692c5d4b20d57f566a63374f8 Merge: 936801d d773da9 Author: Ken McDonell Date: Fri Aug 10 08:58:53 2012 +1000 Merge branch 'dev' of git://oss.sgi.com/pcp/pcp into dev commit 936801de31e5e38c6c1757d8a778e9e2d70443db Author: Ken McDonell Date: Tue Aug 7 21:26:26 2012 +1000 pmdaproc.sh - better post-install checks As part of the linux -> linux+proc PMDA split, discovered that using pminfo to probe metrics is not as robust as it needs to be when metric instance values are long and "odd" (like the proc PMDA) ... switch to using pmprobe. From nscott@redhat.com Thu Aug 23 18:33:49 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7NNXmOd098760 for ; Thu, 23 Aug 2012 18:33:49 -0500 X-ASG-Debug-ID: 1345764874-04cb6c3c737a54b0001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id wAmn8BBz7GW1ryKV; Thu, 23 Aug 2012 16:34:34 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7NNYX1n011099; Thu, 23 Aug 2012 19:34:34 -0400 Date: Thu, 23 Aug 2012 19:34:33 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Jeff Hanson Cc: pcp@oss.sgi.com Message-ID: <695803463.303549.1345764873886.JavaMail.root@redhat.com> In-Reply-To: <503612FF.70206@sgi.com> Subject: Re: [pcp] New dependencies for the PCP RPM packages MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] New dependencies for the PCP RPM packages Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.51.62] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1345764874 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.50 X-Barracuda-Spam-Status: No, SCORE=0.50 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC5_MJ3078 X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106523 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_SC5_MJ3078 Custom Rule MJ3078 OK, thanks Jeff. OOC, do you guys still ship a pcp-pro RPM package? (reviewing some of the RPM dependencies I came across that one yesterday - made me curious). cheers. -- Nathan From jhanson@sgi.com Thu Aug 23 19:18:12 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7O0ICML108066 for ; Thu, 23 Aug 2012 19:18:12 -0500 Received: from xmail.sgi.com (pv-excas1-dc21-nlb.corp.sgi.com [137.38.102.126]) by relay2.corp.sgi.com (Postfix) with ESMTP id 73E16304043; Thu, 23 Aug 2012 17:18:56 -0700 (PDT) Received: from carenath.corp.sgi.com (134.15.95.84) by xmail.sgi.com (137.38.102.30) with Microsoft SMTP Server (TLS) id 14.1.339.1; Thu, 23 Aug 2012 19:18:56 -0500 Message-ID: <5036C86F.80006@sgi.com> Date: Thu, 23 Aug 2012 20:18:55 -0400 From: Jeff Hanson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.6esrpre) Gecko/20120714 Thunderbird/10.0.6 MIME-Version: 1.0 To: Nathan Scott CC: Subject: Re: [pcp] New dependencies for the PCP RPM packages References: <695803463.303549.1345764873886.JavaMail.root@redhat.com> In-Reply-To: <695803463.303549.1345764873886.JavaMail.root@redhat.com> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [134.15.95.84] On 08/23/2012 07:34 PM, Nathan Scott wrote: > OK, thanks Jeff. OOC, do you guys still ship a pcp-pro > RPM package? (reviewing some of the RPM dependencies I > came across that one yesterday - made me curious). It's changed names to pcp-sgi. Would you like any information about that? -- ----------------------------------------------------------------------- Jeff Hanson - jhanson@sgi.com - Field Technical Analyst You can choose a ready guide in some celestial voice. If you choose not to decide, you still have made a choice. You can choose from phantom fears and kindness that can kill; I will choose a path that's clear I will choose freewill. - Lee/Lifeson/Peart From nscott@redhat.com Thu Aug 23 19:26:08 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,URIBL_BLACK autolearn=no version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7O0Q7wl109601 for ; Thu, 23 Aug 2012 19:26:08 -0500 X-ASG-Debug-ID: 1345768013-04cb6c3c727a8ae0001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id KCQvNH6IOZbeUyP6; Thu, 23 Aug 2012 17:26:54 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7O0QrqW017682; Thu, 23 Aug 2012 20:26:53 -0400 Date: Thu, 23 Aug 2012 20:26:53 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Jeff Hanson Cc: pcp@oss.sgi.com Message-ID: <1878886043.307579.1345768013652.JavaMail.root@redhat.com> In-Reply-To: <5036C86F.80006@sgi.com> Subject: Re: [pcp] New dependencies for the PCP RPM packages MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] New dependencies for the PCP RPM packages Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.51.62] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1345768013 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106527 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- ----- Original Message ----- > On 08/23/2012 07:34 PM, Nathan Scott wrote: > > OK, thanks Jeff. OOC, do you guys still ship a pcp-pro > > RPM package? (reviewing some of the RPM dependencies I > > came across that one yesterday - made me curious). > > It's changed names to pcp-sgi. Would you like any information about > that? Hmm, we have a "Conflicts: pcp-pro < 2.2" line in the build/rpm/pcp.spec.in ... been there for quite a while. Should we remove that? Replace it? Or, do you not use that generated specfile for the PCP build from SGI anymore? thanks. -- Nathan From jhanson@sgi.com Thu Aug 23 19:57:20 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,URIBL_BLACK autolearn=no version=3.4.0-r929098 Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7O0vIni115904 for ; Thu, 23 Aug 2012 19:57:19 -0500 Received: from xmail.sgi.com (pv-excas3-dc21-nlb.corp.sgi.com [137.38.102.207]) by relay2.corp.sgi.com (Postfix) with ESMTP id E661A304043; Thu, 23 Aug 2012 17:58:05 -0700 (PDT) Received: from carenath.corp.sgi.com (134.15.95.84) by xmail.sgi.com (137.38.102.30) with Microsoft SMTP Server (TLS) id 14.1.339.1; Thu, 23 Aug 2012 19:58:00 -0500 Message-ID: <5036D182.8060305@sgi.com> Date: Thu, 23 Aug 2012 20:57:38 -0400 From: Jeff Hanson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.6esrpre) Gecko/20120714 Thunderbird/10.0.6 MIME-Version: 1.0 To: Nathan Scott CC: Subject: Re: [pcp] New dependencies for the PCP RPM packages References: <1878886043.307579.1345768013652.JavaMail.root@redhat.com> In-Reply-To: <1878886043.307579.1345768013652.JavaMail.root@redhat.com> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [134.15.95.84] On 08/23/2012 08:26 PM, Nathan Scott wrote: > > ----- Original Message ----- >> On 08/23/2012 07:34 PM, Nathan Scott wrote: >>> OK, thanks Jeff. OOC, do you guys still ship a pcp-pro >>> RPM package? (reviewing some of the RPM dependencies I >>> came across that one yesterday - made me curious). >> >> It's changed names to pcp-sgi. Would you like any information about >> that? > > Hmm, we have a "Conflicts: pcp-pro < 2.2" line in > the build/rpm/pcp.spec.in ... been there for quite > a while. Should we remove that? Replace it? Or, > do you not use that generated specfile for the PCP > build from SGI anymore? We still have it in the pcp spec file. So I'm wrong that pcp-sgi is the follow on to pcp-pro. So nevermind. We don't ship pcp-pro. -- ----------------------------------------------------------------------- Jeff Hanson - jhanson@sgi.com - Field Technical Analyst You can choose a ready guide in some celestial voice. If you choose not to decide, you still have made a choice. You can choose from phantom fears and kindness that can kill; I will choose a path that's clear I will choose freewill. - Lee/Lifeson/Peart From mgoodwin@redhat.com Thu Aug 23 20:33:36 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,URIBL_BLACK autolearn=no version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7O1XZP7123455 for ; Thu, 23 Aug 2012 20:33:36 -0500 X-ASG-Debug-ID: 1345772061-04bdf0044920a70001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id 4bSwCjwx6I1KW8XI for ; Thu, 23 Aug 2012 18:34:22 -0700 (PDT) X-Barracuda-Envelope-From: mgoodwin@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7O1YL9b031883 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 23 Aug 2012 21:34:21 -0400 Received: from fletch.usersys.redhat.com (vpn1-51-35.bne.redhat.com [10.64.51.35]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7O1YKI8020990 for ; Thu, 23 Aug 2012 21:34:21 -0400 Message-ID: <5036DA1B.8010707@redhat.com> Date: Fri, 24 Aug 2012 11:34:19 +1000 From: Mark Goodwin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: pcp@oss.sgi.com Subject: Re: [pcp] New dependencies for the PCP RPM packages References: <1878886043.307579.1345768013652.JavaMail.root@redhat.com> <5036D182.8060305@sgi.com> X-ASG-Orig-Subj: Re: [pcp] New dependencies for the PCP RPM packages In-Reply-To: <5036D182.8060305@sgi.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1345772062 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com On 08/24/2012 10:57 AM, Jeff Hanson wrote: > On 08/23/2012 08:26 PM, Nathan Scott wrote: >> >> ----- Original Message ----- >>> On 08/23/2012 07:34 PM, Nathan Scott wrote: >>>> OK, thanks Jeff. OOC, do you guys still ship a pcp-pro >>>> RPM package? (reviewing some of the RPM dependencies I >>>> came across that one yesterday - made me curious). >>> >>> It's changed names to pcp-sgi. Would you like any information about >>> that? >> >> Hmm, we have a "Conflicts: pcp-pro < 2.2" line in >> the build/rpm/pcp.spec.in ... been there for quite >> a while. Should we remove that? Replace it? Or, >> do you not use that generated specfile for the PCP >> build from SGI anymore? > > We still have it in the pcp spec file. So I'm wrong that pcp-sgi > is the follow on to pcp-pro. So nevermind. We don't ship pcp-pro. > IIRC, pcp-sgi both obsoletes and updates pcp-pro, something like that. Don't ask me why though :) I think that dependency has been lost in the midst of nostalgia and we should just delete it if SGI no longer ships pcp-pro specifically. Regards -- Mark From nscott@redhat.com Thu Aug 23 21:39:29 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,URIBL_BLACK autolearn=no version=3.4.0-r929098 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7O2dQDt137266 for ; Thu, 23 Aug 2012 21:39:27 -0500 X-ASG-Debug-ID: 1345776009-04cbb050cc7af5b0001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id UCA028oAei9OOzGP for ; Thu, 23 Aug 2012 19:40:09 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7O2e9vj008040 for ; Thu, 23 Aug 2012 22:40:09 -0400 Date: Thu, 23 Aug 2012 22:40:09 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <39990944.326539.1345776009374.JavaMail.root@redhat.com> Subject: pcp updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.51.62] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1345776009 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106535 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp.git dev .gitignore | 3 GNUmakefile | 7 build/rpm/fedora.spec | 36 + build/rpm/pcp.spec.in | 38 + src/GNUmakefile | 15 src/include/builddefs.in | 2 src/pmcollectl/GNUmakefile | 28 + src/pmcollectl/pmcollectl.py | 966 ++++++++++++++++++++++++++++++++++++++++++ src/python/.gitignore | 1 src/python/GNUmakefile | 49 +- src/python/pm-collectl.py | 975 ------------------------------------------- src/python/setup.py | 3 12 files changed, 1091 insertions(+), 1032 deletions(-) commit a93aa22091507cbabfb696cee397e0cb750ef237 Author: Nathan Scott Date: Fri Aug 24 12:38:56 2012 +1000 Add a missed runtime pcp dependency in fedora spec commit b3c5ad2e9d80618c949a12d1c3bc16129fcce85b Author: Nathan Scott Date: Fri Aug 24 12:35:52 2012 +1000 Make python sources a first-class citizen in pcp Several changes around python packaging; end result is a new python-pcp RPM package and the first PCP client tool in core pcp written in python (pmcollectl). This builds on Franks GNUmakefile/setup.py fix to make use of DIST_ROOT. It works in a similar way to the perl packages - build produces a file via the setup.py --record option listing all the files in the package. A little post-processing is required too, for rpm, as it also adds byte-compiled python files (pyo), also. Additionally, fix up the Group: tags for all of the perl (and now python) packages to be more appropriate. And finally, I moved pm-collectl.py into the top-level src/pmcollect SUBDIR in pcp (renamed for consistency), and install it to PCP_BIN_DIR as pmcollect - i.e. drop the .py suffix, which seems to be "the done thing" by most other RPM packages with python code in /usr/bin. commit 9eabd739d1c145b832e05f07891c834d9b78d1d8 Author: Nathan Scott Date: Fri Aug 24 09:36:33 2012 +1000 Make use of the python that configure discovered From jhanson@sgi.com Thu Aug 23 22:09:52 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,URIBL_BLACK autolearn=no version=3.4.0-r929098 Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7O39qqB143092 for ; Thu, 23 Aug 2012 22:09:52 -0500 Received: from xmail.sgi.com (pv-excas3-dc21-nlb.corp.sgi.com [137.38.102.207]) by relay2.corp.sgi.com (Postfix) with ESMTP id D9DDE304053; Thu, 23 Aug 2012 20:10:36 -0700 (PDT) Received: from carenath.corp.sgi.com (134.15.95.84) by xmail.sgi.com (137.38.102.30) with Microsoft SMTP Server (TLS) id 14.1.339.1; Thu, 23 Aug 2012 22:10:29 -0500 Message-ID: <5036F0A4.8000207@sgi.com> Date: Thu, 23 Aug 2012 23:10:28 -0400 From: Jeff Hanson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.6esrpre) Gecko/20120714 Thunderbird/10.0.6 MIME-Version: 1.0 To: Mark Goodwin CC: Subject: Re: [pcp] New dependencies for the PCP RPM packages References: <1878886043.307579.1345768013652.JavaMail.root@redhat.com> <5036D182.8060305@sgi.com> <5036DA1B.8010707@redhat.com> In-Reply-To: <5036DA1B.8010707@redhat.com> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [134.15.95.84] On 08/23/2012 09:34 PM, Mark Goodwin wrote: > On 08/24/2012 10:57 AM, Jeff Hanson wrote: >> On 08/23/2012 08:26 PM, Nathan Scott wrote: >>> >>> ----- Original Message ----- >>>> On 08/23/2012 07:34 PM, Nathan Scott wrote: >>>>> OK, thanks Jeff. OOC, do you guys still ship a pcp-pro >>>>> RPM package? (reviewing some of the RPM dependencies I >>>>> came across that one yesterday - made me curious). >>>> >>>> It's changed names to pcp-sgi. Would you like any information about >>>> that? >>> >>> Hmm, we have a "Conflicts: pcp-pro < 2.2" line in >>> the build/rpm/pcp.spec.in ... been there for quite >>> a while. Should we remove that? Replace it? Or, >>> do you not use that generated specfile for the PCP >>> build from SGI anymore? >> >> We still have it in the pcp spec file. So I'm wrong that pcp-sgi >> is the follow on to pcp-pro. So nevermind. We don't ship pcp-pro. >> > > > IIRC, pcp-sgi both obsoletes and updates pcp-pro, something like > that. Don't ask me why though :) I think that dependency has been lost > in the midst of nostalgia and we should just delete it if SGI no > longer ships pcp-pro specifically. You should delete it. The spec.in for pcp-sgi says this about pcp-pro # # All that was in pcp-ace, pcp-ise and pcp-pro is now in pcp-sgi Obsoletes: pcp-pro -- ----------------------------------------------------------------------- Jeff Hanson - jhanson@sgi.com - Field Technical Analyst You can choose a ready guide in some celestial voice. If you choose not to decide, you still have made a choice. You can choose from phantom fears and kindness that can kill; I will choose a path that's clear I will choose freewill. - Lee/Lifeson/Peart From nscott@redhat.com Thu Aug 23 22:39:09 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,J_CHICKENPOX_33 autolearn=no version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7O3d8vc149340 for ; Thu, 23 Aug 2012 22:39:09 -0500 X-ASG-Debug-ID: 1345779591-04bdf0044827a50001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id 1KeDJdcuVu4GYHE6 for ; Thu, 23 Aug 2012 20:39:51 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7O3dp1W014479; Thu, 23 Aug 2012 23:39:51 -0400 Date: Thu, 23 Aug 2012 23:39:51 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Dave Brolley Cc: pcp@oss.sgi.com Message-ID: <663173141.337439.1345779591322.JavaMail.root@redhat.com> Subject: NSS/NSPR review notes MIME-Version: 1.0 X-ASG-Orig-Subj: NSS/NSPR review notes Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.51.62] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1345779591 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.01 X-Barracuda-Spam-Status: No, SCORE=0.01 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106539 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain Hi Dave, I've managed to lose your last mail on this topic, so these notes are just free-form as I read through the code in your current pcpfans nss branch. Overall its looking like its progressing along nicely. I'd like to start getting some of the "wrapper" style changes (API level) merged soonish (pcp-3.6.7), as they stand alone and can go in anytime. This might help to break up the work into smaller chunks, rather than us having a single whopping big commit arrive down the track. I'll start trying to help out on that next week. == NSS/NSPR notes - configure.in: explicit require on fedora/redhat... hmmm? this would mean cannot monitor a RHEL server from, say, a Mac OS X pmchart? are their known issues with the other platforms that require this check? - LogImport/Makefile.PL ... this change seems unnecessary? (logimport is all about archives, not live monitoring) Ohhh... this is part of a bigger linkage issue: Will all out-of-tree pcp client tools will have unresolved NSS symbols on the next pcp upgrade? ... that would be bad. Isn't there a way to link one shared library with another? Ideally, there is and we'd link libpcp that way. Otherwise this is going to be very intrusive for the punters. - pmio.h -> impl.h &| platform_defs.h? (prefer no new header) - auxconnect.c -> hmm, this seems to create a second file descriptor table? I was expecting this code to all be over in ipc.c in libpcp, and augmenting the existing table there rather than dup'ing it. Means we're doubling up on memory allocation calls, PM_LOCK/ PM_UNLOCK calls, etc for every socket we create? -> checking back on Kens mail, yeah - he said the same thing... was there a reason this approach didn't pan out? | What I had in mind was something along these lines: | | * change the __pmIPC structure as follows: | * change socket to be flags and define bit field flags to | encode the channel's type (socket or otherwise for | Windows), clear text or encrypted (for your use), etc. | * add an int fd field for the clear text case | * add whatever extra "stuff" you need to make encrypted | I/O work - __pmSelectRead? not __pmSelect? (shrug, just stood out) - linux/pmda.c - ugh! in hind-sight, surprising we've not come across this before. Might be something we should be doing better in PCP (I'll have a look, see if this becomes a big change, if not will rename domain definitions to be more unique - PCP_LINUX_DOMAIN, for example) Will talk more next week - I'm away for the weekend shortly, and wont be checking mail for a coupla days. cheers. -- Nathan From nscott@redhat.com Sun Aug 26 22:34:03 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7R3Y2TS237203 for ; Sun, 26 Aug 2012 22:34:03 -0500 X-ASG-Debug-ID: 1346038491-04bdf00446d0400001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id WkkWyQRcuUYXAslp for ; Sun, 26 Aug 2012 20:34:52 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7R3YpXf011101 for ; Sun, 26 Aug 2012 23:34:51 -0400 Date: Sun, 26 Aug 2012 23:34:51 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <493878107.1210513.1346038491834.JavaMail.root@redhat.com> Subject: pcp updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.51.81] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1346038492 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106778 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp.git dev debian/changelog | 3 ++- debian/control | 30 ++++++++++++++++++++++++------ debian/rules | 21 +++++++++++++++------ qa/009.out | 12 ++++++------ qa/118 | 2 +- qa/118.work | 28 ---------------------------- qa/GNUmakefile | 4 ++-- qa/GNUmakefile.install | 12 +----------- qa/common | 1 + qa/disk-work | 28 ++++++++++++++++++++++++++++ qa/pmdas/broken/GNUmakefile | 18 +++--------------- qa/pmdas/broken/GNUmakefile.install | 10 +--------- qa/pmdas/dynamic/dynamic.c | 7 +++---- qa/src/ipc.c | 4 ++-- qa/src/pmprintf.c | 2 +- src/libpcp/src/check-statics | 3 +-- src/pmlogger/pmlogger.c | 3 ++- src/python/GNUmakefile | 2 -- 18 files changed, 93 insertions(+), 97 deletions(-) commit 0cccabdd10746290cc224c6f2c06df55ecde99f8 Author: Nathan Scott Date: Mon Aug 27 13:31:52 2012 +1000 Found for deb builds that prefix setting is needed even for /usr installs commit 5eca8d0aa881a82551b585be3bfc83d8a521b0c2 Author: Nathan Scott Date: Mon Aug 27 13:31:13 2012 +1000 Resolve python packaging issues on deb builds commit 1a71bee96cfd0c8d7adba30df859d301b5a26c7c Author: Nathan Scott Date: Mon Aug 27 13:30:35 2012 +1000 Fix harmless shell error warning message from earlier commit commit 5947834478a5323d8b4390876a5358380315d278 Author: Nathan Scott Date: Mon Aug 27 11:38:52 2012 +1000 Add explicit pcp-python and perl-PCP-PMDA dependencies for debs commit 8677efcd42ce1e66a22caedeef51546a50e24494 Author: Nathan Scott Date: Mon Aug 27 11:36:50 2012 +1000 Initial version of the pcp-python module deb packaging commit d09a2a70a83cec72fc73bdc91fb99494d54345f5 Author: Nathan Scott Date: Mon Aug 27 11:36:13 2012 +1000 Mark common qa script as runnable as well commit da3f03ae474e71a25f51308c3d930e1a542cb4f6 Author: Nathan Scott Date: Mon Aug 27 11:35:49 2012 +1000 Simplify broken (test) pmda installation commit ae53a3566c6c319a3714d5691289fd00328b37eb Author: Nathan Scott Date: Mon Aug 27 11:35:12 2012 +1000 Fix some typos in QA test diagnostic messages; lintian found commit e37e421822ed32260218e7c7acc1b2e35bcd7bb4 Author: Nathan Scott Date: Mon Aug 27 11:34:30 2012 +1000 Rename 118 workload script, complicating build/installs. commit 9a97df4cefb93bddfde7b044b484b9f8de3cc1d5 Author: Nathan Scott Date: Mon Aug 27 10:52:52 2012 +1000 Fix potential buffer overflow in pmlogger host name handling Resolves a string copy issue where the host name is assumed to be less than or equal to MAXHOSTLEN. If a hosts file entry has a longer name, for example, this overrun is triggered. This is not an exploitable overflow, happily. Uncovered by pcp-gui-testsuite test case 025. commit 1b683eafb549db0d23dae43d2abfcfea87ecd738 Author: Nathan Scott Date: Mon Aug 27 10:48:17 2012 +1000 Working toward 3.6.6 - resolve some macosx build issues From nscott@redhat.com Mon Aug 27 01:50:14 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7R6oDnY008632 for ; Mon, 27 Aug 2012 01:50:13 -0500 X-ASG-Debug-ID: 1346050260-04bdf00447d8fb0001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id J0Si0KH5lsz0y2NJ for ; Sun, 26 Aug 2012 23:51:00 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7R6oxJ5026398 for ; Mon, 27 Aug 2012 02:50:59 -0400 Date: Mon, 27 Aug 2012 02:50:59 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <353802446.1260483.1346050259878.JavaMail.root@redhat.com> Subject: pcp updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.51.81] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1346050260 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106792 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp.git dev qa/GNUmakefile | 2 src/include/builddefs.in | 86 +++++++ src/libpcp/src/check-statics | 2 src/perl/LogImport/Makefile.PL | 2 src/perl/MMV/Makefile.PL | 2 src/perl/PMDA/Makefile.PL | 2 src/pmdas/bash/.gitignore | 2 src/pmdas/bash/GNUmakefile | 27 +- src/pmdas/bash/bash.c | 454 +++++++++++++++++++++++++++++++++++++++++ src/pmdas/bash/pmda.c | 454 ----------------------------------------- src/python/GNUmakefile | 16 - 11 files changed, 554 insertions(+), 495 deletions(-) commit 0654bdba5c4a5bbd021c6287184a17e489a16814 Author: Nathan Scott Date: Mon Aug 27 16:29:23 2012 +1000 Build porting work for a working pmdabash install on Mac OS X commit 26255e65cb41b01fad8cc45def37627c1113397e Author: Nathan Scott Date: Mon Aug 27 16:25:20 2012 +1000 Move python platform-specific pain into the central home-of-pain - builddefs commit 1a0703d6729fda683e1dffbb7a4892d014329ec3 Author: Nathan Scott Date: Mon Aug 27 16:24:08 2012 +1000 Somehow /usr/local/lib crept in for darwin perl builds, undo, badness commit 49b45921a01fb2819c2294a463ff50b9fe7179c7 Author: Nathan Scott Date: Mon Aug 27 16:23:12 2012 +1000 Platforms with a single package for pcp will not pcp testsuite contents commit 6b31ae5e60b14d7f4824e75f50c39f39a9d6f71a Author: Nathan Scott Date: Mon Aug 27 16:07:28 2012 +1000 Further tweakery to avoid this shell warning commit 14f0c231fe4254a840e493e05bb930c74f1452ff Author: Nathan Scott Date: Mon Aug 27 15:37:16 2012 +1000 Revert "Found for deb builds that prefix setting is needed even for /usr installs" This reverts commit 0cccabdd10746290cc224c6f2c06df55ecde99f8. From mgoodwin@redhat.com Mon Aug 27 04:50:27 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7R9oQgb033920 for ; Mon, 27 Aug 2012 04:50:26 -0500 X-ASG-Debug-ID: 1346061076-04cbb050cf869910001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id 7FUmQykP86UC9WLw for ; Mon, 27 Aug 2012 02:51:16 -0700 (PDT) X-Barracuda-Envelope-From: mgoodwin@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7R9pGSe031328 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 27 Aug 2012 05:51:16 -0400 Received: from fletch.usersys.redhat.com (vpn1-51-104.bne.redhat.com [10.64.51.104]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7R9pEW6024624 for ; Mon, 27 Aug 2012 05:51:15 -0400 Message-ID: <503B4312.6020406@redhat.com> Date: Mon, 27 Aug 2012 19:51:14 +1000 From: Mark Goodwin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: pcp Subject: pcp updates Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-ASG-Orig-Subj: pcp updates Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1346061076 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com Changes committed to git://oss.sgi.com/pcp/pcp.git dev commit 9d704ecc0dd5a6c5a01c4d6acb65eedf618f64b6 Author: Mark Goodwin Date: Mon Aug 27 19:46:46 2012 +1000 Fix wrong macro in python-pcp dependency and bump latest changelog date. modified: build/rpm/fedora.spec diff --git a/build/rpm/fedora.spec b/build/rpm/fedora.spec index ae83227..6ee0b27 100644 --- a/build/rpm/fedora.spec +++ b/build/rpm/fedora.spec @@ -189,7 +189,7 @@ License: GPLv2 Group: Development/Libraries Summary: Performance Co-Pilot (PCP) Python bindings and documentation URL: http://oss.sgi.com/projects/pcp/ -Requires: pcp-libs = @package_version@ +Requires: pcp-libs = %{version} %description -n python-pcp The python PCP module contains the language bindings for @@ -385,7 +385,7 @@ fi %defattr(-,root,root) %changelog -* Thu Aug 23 2012 Mark Goodwin - 3.6.6-1 +* Mon Aug 27 2012 Mark Goodwin - 3.6.6-1 - interim builds: Update to latest PCP sources, see installed CHANGELOG for details. From brolley@redhat.com Mon Aug 27 13:25:44 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,J_CHICKENPOX_33 autolearn=no version=3.4.0-r929098 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7RIPidc228929 for ; Mon, 27 Aug 2012 13:25:44 -0500 X-ASG-Debug-ID: 1346091994-04cbb025cd01150001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id yijrm9aCZaxHVN5p for ; Mon, 27 Aug 2012 11:26:34 -0700 (PDT) X-Barracuda-Envelope-From: brolley@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7RIQXlq023695 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 27 Aug 2012 14:26:34 -0400 Received: from [10.15.16.135] (dhcp-10-15-16-135.yyz.redhat.com [10.15.16.135]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7RIQXjq004903 for ; Mon, 27 Aug 2012 14:26:33 -0400 Message-ID: <503BBBD9.5070801@redhat.com> Date: Mon, 27 Aug 2012 14:26:33 -0400 From: Dave Brolley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: pcp@oss.sgi.com Subject: Re: NSS/NSPR review notes References: <663173141.337439.1345779591322.JavaMail.root@redhat.com> X-ASG-Orig-Subj: Re: NSS/NSPR review notes In-Reply-To: <663173141.337439.1345779591322.JavaMail.root@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1346091994 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com Thanks for the review Nathan. Your comments are spot on. Some responses below. Dave On 08/23/2012 11:39 PM, Nathan Scott wrote: > Hi Dave, > > I've managed to lose your last mail on this topic, so these > notes are just free-form as I read through the code in your > current pcpfans nss branch. > > Overall its looking like its progressing along nicely. I'd > like to start getting some of the "wrapper" style changes > (API level) merged soonish (pcp-3.6.7), as they stand alone > and can go in anytime. This might help to break up the work > into smaller chunks, rather than us having a single whopping > big commit arrive down the track. I'll start trying to help > out on that next week. Thanks. Yes. I feel like this branch is getting old and crusty. I would like to run the entire testsuite against the current dev branch and then with my changes for NSS/NSPR enabled and disabled, all with the same results before we push it. > > > == NSS/NSPR notes > > - configure.in: explicit require on fedora/redhat... hmmm? > this would mean cannot monitor a RHEL server from, say, a > Mac OS X pmchart? are their known issues with the other > platforms that require this check? Any requirement placed on RHEL or Fedora is purely temporary. I'm just not expert enough to know whether the particular test framework that used (stolen from systemtap) is portable. Any assistance is appreciated! > > - LogImport/Makefile.PL ... this change seems unnecessary? > (logimport is all about archives, not live monitoring) > > Ohhh... this is part of a bigger linkage issue: > Will all out-of-tree pcp client tools will have unresolved > NSS symbols on the next pcp upgrade? ... that would be bad. > Isn't there a way to link one shared library with another? > Ideally, there is and we'd link libpcp that way. Otherwise > this is going to be very intrusive for the punters. Agreed and, once again, not intended. Also, once again, any assistance is appreciated. > > - pmio.h -> impl.h &| platform_defs.h? (prefer no new header) OK. I'll get rid of pmio.h > > - auxconnect.c > -> hmm, this seems to create a second file descriptor > table? I was expecting this code to all be over > in ipc.c in libpcp, and augmenting the existing > table there rather than dup'ing it. Means we're > doubling up on memory allocation calls, PM_LOCK/ > PM_UNLOCK calls, etc for every socket we create? > -> checking back on Kens mail, yeah - he said the > same thing... was there a reason this approach > didn't pan out? > > | What I had in mind was something along these lines: > | > | * change the __pmIPC structure as follows: > | * change socket to be flags and define bit field flags to > | encode the channel's type (socket or otherwise for > | Windows), clear text or encrypted (for your use), etc. > | * add an int fd field for the clear text case > | * add whatever extra "stuff" you need to make encrypted > | I/O work Oh well, I had asked whether he was thinking about putting it in the IPC table or a separate table and his response was along the lines of what you've outlined above. I decided not to play with such a vital table right away. Now that the basic work is done, it does seem like it would be easy to integrate. > - __pmSelectRead? not __pmSelect? (shrug, just stood out) Yeah. I noticed that nowhere in pcp does both at once and the abstraction worked out pretty easily if one or the other was assumed. A general implementation could still be done if you like. > > - linux/pmda.c - ugh! in hind-sight, surprising we've not > come across this before. Might be something we should be > doing better in PCP (I'll have a look, see if this becomes > a big change, if not will rename domain definitions to be > more unique - PCP_LINUX_DOMAIN, for example) Seems like a NSS/NSPR namespace violation to me, but yes.....ugh! > > > Will talk more next week - I'm away for the weekend shortly, > and wont be checking mail for a coupla days. OK. Hope you had a great weekend! Dave > > cheers. > > -- > Nathan > From mgoodwin@redhat.com Mon Aug 27 19:36:40 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7S0aeHi009956 for ; Mon, 27 Aug 2012 19:36:40 -0500 X-ASG-Debug-ID: 1346114250-04cb6c0e0f16750001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id LqCq07lN3YvPyeCx for ; Mon, 27 Aug 2012 17:37:31 -0700 (PDT) X-Barracuda-Envelope-From: mgoodwin@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7S0bU54001853 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 27 Aug 2012 20:37:30 -0400 Received: from fletch.usersys.redhat.com (vpn1-51-122.bne.redhat.com [10.64.51.122]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7S0bSxb005700 for ; Mon, 27 Aug 2012 20:37:29 -0400 Message-ID: <503C12C8.1060402@redhat.com> Date: Tue, 28 Aug 2012 10:37:28 +1000 From: Mark Goodwin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: pcp Subject: pcp updates Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-ASG-Orig-Subj: pcp updates Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1346114251 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com Changes committed to git://oss.sgi.com/pcp/pcp.git dev Tweak the fedora spec for epel 5 and 6 builds. Python syntax errors are still an issue however, see the details in https://bugzilla.redhat.com/show_bug.cgi?id=852234 commit 7bcf2f9e30d4f7e39981b90afc8009f382bffa1f Author: Mark Goodwin Date: Tue Aug 28 10:31:48 2012 +1000 Tweak BuildRequires man and hostname for epel{5,6} modified: build/rpm/fedora.spec From nscott@redhat.com Mon Aug 27 21:38:15 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7S2cEmm024701 for ; Mon, 27 Aug 2012 21:38:14 -0500 X-ASG-Debug-ID: 1346121543-04bdf05ee8184d0001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id 2Nc4vrC6gbPDiLEX for ; Mon, 27 Aug 2012 19:39:04 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7S2d3tG001374 for ; Mon, 27 Aug 2012 22:39:03 -0400 Date: Mon, 27 Aug 2012 22:39:03 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <467524311.1792332.1346121543689.JavaMail.root@redhat.com> In-Reply-To: <857664698.1792211.1346121466372.JavaMail.root@redhat.com> Subject: pcp updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.51.113] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1346121543 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106870 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp.git dev man/man1/GNUmakefile | 8 - man/man1/pmcollectl.1 | 326 +++++++++++++++++++++++++++++++++++++++++++ src/pmcollectl/pmcollectl.py | 13 - 3 files changed, 336 insertions(+), 11 deletions(-) commit 4ccb5533da214d4f62d71ec594cbd3b969f5e00f Author: Nathan Scott Date: Tue Aug 28 12:36:19 2012 +1000 Add a man page describing the pmcollectl options From nscott@redhat.com Mon Aug 27 21:47:11 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7S2lBil025794 for ; Mon, 27 Aug 2012 21:47:11 -0500 X-ASG-Debug-ID: 1346122081-04cbb025ce17290001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id m2nklJZ1SBFHOf3V for ; Mon, 27 Aug 2012 19:48:01 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7S2m0JD007313; Mon, 27 Aug 2012 22:48:00 -0400 Date: Mon, 27 Aug 2012 22:48:00 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Stan Cox Cc: pcp@oss.sgi.com Message-ID: <1980141057.1795836.1346122080956.JavaMail.root@redhat.com> In-Reply-To: <1622392315.1795702.1346122077717.JavaMail.root@redhat.com> Subject: pmcollectl command line options MIME-Version: 1.0 X-ASG-Orig-Subj: pmcollectl command line options Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.51.113] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1346122081 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.01 X-Barracuda-Spam-Status: No, SCORE=0.01 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106870 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain Hi Stan, I added a man page for pmcollectl today, be great if you could check it out and fix the many mistakes I've no doubt made. I also noticed a note in the man page re the original tool being called "collect", and "collectl" being a Linux-specific version. You might want to consider the name "pmcollect". Or not. :) I used the collectl man page as a starting point (licenses are all nicely compatible, and copyrights intact), and found several options that could be easily implemented by a relatively skilled python wrangler. live: --align (same as -A option to PCP tools - see pmParseTimeWindow) --daemon (seems to set a time interval of 10sec - probably worth keeping for generating archive mode) --flush (looks equivalent to sending SIGUSR1 to the pmlogger co- process) --runtime (same as -T option to PCP tools - see pmParseTimeWindow) playback: --from (same as -S option to PCP tools - see pmParseTimeWindow) --thru (same as -T option to PCP tools - see pmParseTimeWindow) I've left these options in the man page, but commented out in case you/someone else is keen to hack on 'em further. Oh, I also found a missing synonym for -c (easily added, done), and also -s (not so sure how best to tackle that, so left a comment about --subsys). cheers. -- Nathan From mgoodwin@redhat.com Tue Aug 28 02:31:33 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7S7VXVN060964 for ; Tue, 28 Aug 2012 02:31:33 -0500 X-ASG-Debug-ID: 1346139143-04cb6c0e1129950001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id bWIXcpSu6SIocYBq for ; Tue, 28 Aug 2012 00:32:24 -0700 (PDT) X-Barracuda-Envelope-From: mgoodwin@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7S7WNHD019191 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 28 Aug 2012 03:32:23 -0400 Received: from fletch.usersys.redhat.com (vpn1-51-122.bne.redhat.com [10.64.51.122]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7S7WLH8020040 for ; Tue, 28 Aug 2012 03:32:22 -0400 Message-ID: <503C7404.2020203@redhat.com> Date: Tue, 28 Aug 2012 17:32:20 +1000 From: Mark Goodwin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: pcp Subject: pcp updates Content-Type: text/plain; charset=UTF-8; format=flowed X-ASG-Orig-Subj: pcp updates Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1346139144 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com Changes committed to git://oss.sgi.com/pcp/pcp.git dev commit 54a9f939205eb028b58e961a25d9dc65c67a452d Author: Mark Goodwin Date: Tue Aug 28 17:25:51 2012 +1000 Minor back-porting for python2.4 on epel5 builds. Longer term, we really need "BuildRequires: python2.7-devel and Requires: python2.7" for epel5, i.e. push python2.7 into epel5 modified: src/python/pcp.py From nscott@redhat.com Tue Aug 28 05:27:38 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7SARcT3081599 for ; Tue, 28 Aug 2012 05:27:38 -0500 X-ASG-Debug-ID: 1346149707-04cb6c0e1134350001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id 6GI4ZBkBCmdDbuYG for ; Tue, 28 Aug 2012 03:28:27 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7SASQTl024943 for ; Tue, 28 Aug 2012 06:28:27 -0400 Date: Tue, 28 Aug 2012 06:28:26 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <486679351.2023346.1346149706948.JavaMail.root@redhat.com> Subject: pcp-gui updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp-gui updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.51.113] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1346149707 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106902 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp-gui.git dev build/rpm/fedora.spec | 7 + build/rpm/pcp-gui.spec.in | 7 + qa/016.out | 18 +++- qa/017 | 12 +-- qa/017.out | 30 ++++---- qa/019 | 2 qa/020 | 2 qa/src/qmc_context/qmc_context.cpp | 94 ++++++++++++++++--------- qa/src/qmc_group/qmc_group.cpp | 34 ++++----- src/libqmc/qmc_context.cpp | 122 ++++++++++++++------------------- src/libqmc/qmc_context.h | 36 ++++----- src/libqmc/qmc_desc.cpp | 2 src/libqmc/qmc_group.cpp | 4 - src/libqmc/qmc_indom.cpp | 8 -- src/libqmc/qmc_metric.cpp | 135 +++++++++++++++++-------------------- src/libqmc/qmc_metric.h | 32 ++++++-- 16 files changed, 276 insertions(+), 269 deletions(-) commit 9ef7db5c594945de4bd269016e1ea46bfaf36d4e Author: Nathan Scott Date: Tue Aug 28 20:25:16 2012 +1000 Use a hash for the desc cache rather than a list We will shortly be using this for event parameter metric descriptor caching as well, a linearly increasing lookup cost clearly will cause pain (pmevent has wisely used a hash lookup from the get go). This required removal of lookups-by-index of course, and a cached pmid is held directly in QmcMetric now. Some initial preparatory work for event record decoding is also escaping here - refactoring from real/string to real/string/records, some tests updated to know about an event type of metric. commit 0df13bb2cf21098e9c9035ec93d6b570eaaa927b Author: Nathan Scott Date: Tue Aug 28 14:20:57 2012 +1000 Replace the name/pmid qlist with a qhash commit bade8cb4ea3d4b38c8b58b6a604ac8dabe8334b8 Author: Nathan Scott Date: Tue Aug 28 13:49:33 2012 +1000 Use the Qt assert mechanism as it integrates with qmake builds better commit e6a7a08f7b861881d7563a572e361d71ee4ef605 Author: Nathan Scott Date: Tue Aug 28 13:48:26 2012 +1000 Improve layout of context class fields commit eeab72606602ede625cfb9f25b7143b28f97a2da Author: Nathan Scott Date: Tue Aug 28 13:47:33 2012 +1000 Tutorials need to end up in -doc package, not -gui runtime commit f4c1a26599bf10da3e12040afab227e4fb887664 Author: Nathan Scott Date: Tue Aug 28 13:46:00 2012 +1000 Ensure install of dynamic PMDA succeeds, not relying on earlier installation From pcp-announce-bounces@oss.sgi.com Tue Aug 28 05:42:39 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7SAfoR9083142; Tue, 28 Aug 2012 05:41:50 -0500 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7SAfhpo083125 for ; Tue, 28 Aug 2012 05:41:45 -0500 X-ASG-Debug-ID: 1346150552-04bdf05ee935930001-87ZIJf Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id aX8c4fCbxS5d1cBl for ; Tue, 28 Aug 2012 03:42:32 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7SAgWr4032520 for ; Tue, 28 Aug 2012 06:42:32 -0400 Date: Tue, 28 Aug 2012 06:42:32 -0400 (EDT) From: Nathan Scott To: pcp-announce@oss.sgi.com Message-ID: <410540015.2031250.1346150552329.JavaMail.root@redhat.com> In-Reply-To: <1501739705.2026507.1346150039841.JavaMail.root@redhat.com> MIME-Version: 1.0 X-ASG-Orig-Subj: pcp-3.6.6 released X-Originating-IP: [10.64.51.113] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1346150552 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106902 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Subject: [pcp-announce] pcp-3.6.6 released X-BeenThere: pcp-announce@oss.sgi.com X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Nathan Scott List-Id: pcp announcements List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: pcp-announce-bounces@oss.sgi.com Errors-To: pcp-announce-bounces@oss.sgi.com Hi all, A new PCP release has been tagged in the PCP git tree, and binary builds have been uploaded to oss.sgi.com for general consumption. There's one known issue with the new python pmcollectl(1) utility not working with the python-2.4 in RHEL5 (its known good with more recent versions, like python-2.7 in RHEL6). We'll address that in the next release. pcp-3.6.6 (28 August 2012) - Added the python PMAPI bindings and an initial python client in pmcollectl. Separate, new package exists for python libs for those platforms that split out packages (rpm, deb). - Added a pcp-testsuite package for those platforms that might want this (rpm, deb again, mainly) - Re-introduced the pcp/qa subdirectory in pcp and deprecated the external pcpqa git tree. - Fix potential buffer overflow in pmlogger host name handling. - Reworked the configure --prefix handling to be more like the rest of the open source world. - Ensure the __pmDecodeText ident parameter is always set Resolves Red Hat bugzilla bug #841306. Enjoy! -- Nathan _______________________________________________ pcp-announce mailing list pcp-announce@oss.sgi.com http://oss.sgi.com/mailman/listinfo/pcp-announce From nscott@redhat.com Wed Aug 29 00:14:31 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7T5EVfG210658 for ; Wed, 29 Aug 2012 00:14:31 -0500 X-ASG-Debug-ID: 1346217320-04cbb025cf698a0001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id b1ZHGjY8A2K2YBjf for ; Tue, 28 Aug 2012 22:15:20 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7T5FJgZ026621; Wed, 29 Aug 2012 01:15:19 -0400 Date: Wed, 29 Aug 2012 01:15:19 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Dave Brolley Cc: pcp@oss.sgi.com Message-ID: <289008570.2441917.1346217319343.JavaMail.root@redhat.com> In-Reply-To: <503BBBD9.5070801@redhat.com> Subject: Re: [pcp] NSS/NSPR review notes MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] NSS/NSPR review notes Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.51.113] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1346217320 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.01 X-Barracuda-Spam-Status: No, SCORE=0.01 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106975 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain Hey Dave, Firstly, forgot to mention last time - you might find this work will be aided by the wireshark PCP dissector (the credentials exchange, especially). Not sure if that is in any released version of wireshark yet, but it was merged into the wireshark source tree earlier in the year. ----- Original Message ----- > On 08/23/2012 11:39 PM, Nathan Scott wrote: > > ... > > big commit arrive down the track. I'll start trying to help > > out on that next week. > Thanks. Yes. I feel like this branch is getting old and crusty. I > would > like to run the entire testsuite against the current dev branch and > then > with my changes for NSS/NSPR enabled and disabled, all with the same > results before we push it. *nod* - good plan re doing that testing. Since there's a bit of rework required around the ipc table, I was thinking of pulling out just the api-wrapper type changes (so, a no-op change) and testing/merging those (by hand, probably, not git merge on the nss branch, which is starting to look a bit like its done a few rounds with Mike Tyson). Then I think it would be worth resetting the clock, and pick out the remaining pieces one at a time, and re-commit those that will stay with us long-term. I'd be happy to go through and extract the API wrapping bits, if you don't mind this approach? (I would imagine a new branch would be worthwhile for the next iteration after that, perhaps a brolley/nss2, cos it will likely be a merge nightmare after the wrapper api extraction). Hmm, that is all sounding a bit hairy - lets discuss by phone tomorrow? > > == NSS/NSPR notes > > > > - configure.in: explicit require on fedora/redhat... hmmm? > > this would mean cannot monitor a RHEL server from, say, a > > Mac OS X pmchart? are their known issues with the other > > platforms that require this check? > Any requirement placed on RHEL or Fedora is purely temporary. I'm > just > not expert enough to know whether the particular test framework that > used (stolen from systemtap) is portable. Any assistance is > appreciated! The configure.in snippet from systemtap for NSS looks a fair bit simpler than what's currently in this branch ... go with that I'd say (no mention of fedora/rhel in systemtap master branch). > > - LogImport/Makefile.PL ... this change seems unnecessary? > > (logimport is all about archives, not live monitoring) > > > > Ohhh... this is part of a bigger linkage issue: > > Will all out-of-tree pcp client tools will have unresolved > > NSS symbols on the next pcp upgrade? ... that would be bad. > > Isn't there a way to link one shared library with another? > > Ideally, there is and we'd link libpcp that way. Otherwise > > this is going to be very intrusive for the punters. > Agreed and, once again, not intended. Also, once again, any > assistance is appreciated. We'll need to ponder/investigate this further. Worst case scenario we can dlopen the nss library from within libpcp and access it that way, but I have a vague memory of better linkage options than that. [ /me returns from pondering ... oh, its easily done - we already do it in fact, for -lpthread -lm and -ldl. We need to extend LLDLIBS in libpcp/src/GNUmakefile with a $(LIB_FOR_NSS) - which configure is going to fill in for us, ultimately. gcc magic then does the rest. ] > you've outlined above. I decided not to play with such a vital table > right away. Fair enough. > Now that the basic work is done, it does seem like it > would be easy to integrate. OK, good stuff. > > - __pmSelectRead? not __pmSelect? (shrug, just stood out) > Yeah. I noticed that nowhere in pcp does both at once and the > abstraction worked out pretty easily if one or the other was assumed. > A general implementation could still be done if you like. Was more just the name that caught my eye - everything else was more of a direct translation, whereas this one acquired a "Read" suffix seemingly out of the blue. > > - linux/pmda.c - ugh! in hind-sight, surprising we've not > > come across this before. Might be something we should be > > doing better in PCP (I'll have a look, see if this becomes > > a big change, if not will rename domain definitions to be > > more unique - PCP_LINUX_DOMAIN, for example) > Seems like a NSS/NSPR namespace violation to me, but yes.....ugh! Yeah, could argue it both ways - I tried out changing some of the domain numbers over to PMDA_LINUX, PMDA_PMCD ... with no ill effect, keen to hear from some of the other old-timer PCP folk as to whether they can think of potential issues there though? (anyone? Max/Mark/ Ken...?) Perhaps PMD_LINUX would make more sense, since its not so much an Agent thing, as a Domain thing? cheers. -- Nathan From nscott@redhat.com Wed Aug 29 03:11:17 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7T8BH4v233187 for ; Wed, 29 Aug 2012 03:11:17 -0500 X-ASG-Debug-ID: 1346227928-04bdf05eeb7de50001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id LEjEG1VzjA3ygXSP for ; Wed, 29 Aug 2012 01:12:08 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7T8C7RN006439 for ; Wed, 29 Aug 2012 04:12:08 -0400 Date: Wed, 29 Aug 2012 04:12:07 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1330181158.2477832.1346227927781.JavaMail.root@redhat.com> In-Reply-To: <527000871.2477734.1346227901069.JavaMail.root@redhat.com> Subject: pcp-gui updates MIME-Version: 1.0 X-ASG-Orig-Subj: pcp-gui updates Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.51.113] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1346227928 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.106987 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Changes committed to git://oss.sgi.com/pcp/pcp-gui.git dev qa/016.out | 8 +-- qa/017 | 13 ++++- qa/017.out | 20 ++++----- src/libqmc/qmc_context.cpp | 87 +++++++++++++++++++++++++++++++++------ src/libqmc/qmc_context.h | 15 +++++- src/libqmc/qmc_metric.cpp | 98 ++++++++++++++++++++++++++++++++++++++++++++- src/libqmc/qmc_metric.h | 40 ++++++++++++++++-- 7 files changed, 239 insertions(+), 42 deletions(-) commit 4914a3eecc61a0f65b7cc9335ce85c036d50794a Author: Nathan Scott Date: Wed Aug 29 18:10:33 2012 +1000 Add support for event tracing into the libqmc library This commit adds support to the QtMetricsClass (qmc) library to assist client tools decoding event metrics. Makes use of similar ideas that were added to pmevent; namely, a name and descriptor cache (lookup by pmid, & associated with each context), mechanisms for dealing with the missed events and event flags derived metric additions, and of course calls to libpcp interfaces to perform the event record decoding. QA tests 016 and 017 updated to cater for changes to diagnostics, but also improved the filtering on pmid replacements (extending work started by someone else, some other time, in a galaxy far far away). From nscott@redhat.com Thu Aug 30 02:25:26 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7U7PQ1T153612 for ; Thu, 30 Aug 2012 02:25:26 -0500 X-ASG-Debug-ID: 1346311578-04bdf05ee9beac0001-S8gJnT Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by cuda.sgi.com with ESMTP id SAZVroQYCJA8Jaoy for ; Thu, 30 Aug 2012 00:26:18 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.24 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7U7QHJu024833; Thu, 30 Aug 2012 03:26:17 -0400 Date: Thu, 30 Aug 2012 03:26:17 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Dave Brolley Cc: pcp@oss.sgi.com Message-ID: <21006055.2971170.1346311577682.JavaMail.root@redhat.com> In-Reply-To: <289008570.2441917.1346217319343.JavaMail.root@redhat.com> Subject: Re: [pcp] NSS/NSPR review notes MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] NSS/NSPR review notes Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.51.113] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx3-phx2.redhat.com[209.132.183.24] X-Barracuda-Start-Time: 1346311578 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.01 X-Barracuda-Spam-Status: No, SCORE=0.01 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.107081 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain Hi Dave, ----- Original Message ----- > ----- Original Message ----- > > On 08/23/2012 11:39 PM, Nathan Scott wrote: > > > ... > *nod* - good plan re doing that testing. Since there's a bit of > rework required around the ipc table, I was thinking of pulling > out just the api-wrapper type changes (so, a no-op change) and > testing/merging those (by hand, probably, not git merge on the > nss branch, which is starting to look a bit like its done a few > rounds with Mike Tyson). OK, wow, what a marathon. Glad we went this way though, a few more lurking issues did fall out... __pmFcntlGetFlags() has accidentally replaced two different fcntl() calls with just the one. Subtle, but F_GETFL != F_GETFD (the final letter differs - FL is file status flags, FD file descriptor flags). Huh, I've never noticed that - but they definitely map to different codes in fcntl.h. I've created new separate interfaces to help to clarify this. Likewise for the SetFlags() variant. __pmAuxConnectPMCDPort() had an error path (__pmCreateSocket fail) that introduced a "HostEntBuffer" memleak. Likewise in the perl wrapper module (local_reconnector, I think). Naming convention for fields in impl.h structures appears to be all lower case with underscores ... made a note there re __pmFdSet. Found memleaks on all of the calls to __pmSockAddrInToString. I also renamed the "mysocklen_t" (old school) type to __pmSockLen which matches the new type names better. Finally, I left a note in the (now empty, ready for you) section for NSS code - I think it'll be better to go with fewer #ifdefs; so instead of... __pmFunction() { #ifdef NSS ... #else ... #endif ... (usually 1 or 0 lines here) ... } to have two totally distinct implementations (so, one #ifdef only, not one in each function). Running it through the QA tests now. Hmm - was looking good while I was writing this, but then 062 just failed (__pmAccAddClient related? "host 29: __pmAccAddClient returns denyOpsResult 0x0 (expected 0xdfffffff)" style messages). Will finish off the run and get the full results & a merge tree up on oss, and try catch you in the morning to discuss. cheers. -- Nathan From nscott@redhat.com Thu Aug 30 02:43:53 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7U7hrVX156171 for ; Thu, 30 Aug 2012 02:43:53 -0500 X-ASG-Debug-ID: 1346312685-04cbb025ccb3270001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id UBkTOWkwNcsxzrRv for ; Thu, 30 Aug 2012 00:44:45 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7U7iiUN021702; Thu, 30 Aug 2012 03:44:44 -0400 Date: Thu, 30 Aug 2012 03:44:44 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Dave Brolley Cc: pcp@oss.sgi.com Message-ID: <3473703.2977657.1346312684904.JavaMail.root@redhat.com> Subject: pcp updates (nssmerge branch) MIME-Version: 1.0 X-ASG-Orig-Subj: pcp updates (nssmerge branch) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.51.113] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1346312685 X-Barracuda-URL: http://192.48.176.25:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.01 X-Barracuda-Spam-Status: No, SCORE=0.01 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.107081 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain Hi Dave, Could you take a look through this (new, temporary) branch please? Test 062 seems to be the only failure so far (up to 163 - so ~26% through now). cheers. Changes committed to git://oss.sgi.com/pcp/pcp.git nssmerge src/include/pcp/impl.h | 90 +++++++ src/include/pcp/platform_header.h.in | 9 src/libpcp/src/access.c | 76 +++--- src/libpcp/src/auxconnect.c | 397 ++++++++++++++++++++++++++++------- src/libpcp/src/connect.c | 19 - src/libpcp/src/context.c | 4 src/libpcp/src/pdu.c | 17 - src/libpcp_gui/src/timeclient.c | 21 - src/libpcp_pmcd/src/client.c | 25 -- src/libpcp_pmda/src/open.c | 31 +- src/libpcp_trace/src/trace.c | 4 src/perl/PMDA/local.c | 46 ++-- src/pmcd/src/agent.c | 11 src/pmcd/src/client.c | 17 - src/pmcd/src/client.h | 5 src/pmcd/src/config.c | 22 + src/pmcd/src/dofetch.c | 17 - src/pmcd/src/dostore.c | 19 - src/pmcd/src/pmcd.c | 79 +++--- src/pmdas/cisco/telnet.c | 2 src/pmdas/trace/src/client.c | 2 src/pmdas/trace/src/comms.c | 15 - src/pmlogger/ports.c | 55 ++-- src/pmproxy/client.c | 58 ++--- src/pmproxy/pmproxy.c | 54 ++-- src/pmproxy/pmproxy.h | 4 src/telnet-probe/telnet-probe.c | 4 27 files changed, 732 insertions(+), 371 deletions(-) commit 99e66aa615ecbfd8f683fc99edd6f8b4e90644fb Author: Dave Brolley Date: Thu Aug 30 17:35:18 2012 +1000 Propogate use of the abstracted socket interface for NSS to callers commit d3355a3084d7ce55065dae57d59114f5e8d9b986 Author: Dave Brolley Date: Thu Aug 30 17:34:20 2012 +1000 Core socket interface abstractions to support NSS (later) From brolley@redhat.com Thu Aug 30 13:48:41 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7UImeDK258516 for ; Thu, 30 Aug 2012 13:48:40 -0500 X-ASG-Debug-ID: 1346352573-04cb6c0e10e3960001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id eVmOI8x23GYB4uKb for ; Thu, 30 Aug 2012 11:49:33 -0700 (PDT) X-Barracuda-Envelope-From: brolley@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7UInWHc022788 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 30 Aug 2012 14:49:32 -0400 Received: from [10.11.10.16] (vpn-10-16.rdu.redhat.com [10.11.10.16]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7UInV5V017469 for ; Thu, 30 Aug 2012 14:49:32 -0400 Message-ID: <503FB5BB.6060002@redhat.com> Date: Thu, 30 Aug 2012 14:49:31 -0400 From: Dave Brolley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: pcp@oss.sgi.com Subject: Re: [pcp] NSS/NSPR review notes References: <21006055.2971170.1346311577682.JavaMail.root@redhat.com> X-ASG-Orig-Subj: Re: [pcp] NSS/NSPR review notes In-Reply-To: <21006055.2971170.1346311577682.JavaMail.root@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1346352573 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com Hi Nathan, Wow, thanks for the merge and for the good catches while doing it! I have had a look and don't see anything missing. I look forward to the full test results. Is it difficult to setup/run the test suite? I probably should be able to do it myself as we progress. Dave On 08/30/2012 03:26 AM, Nathan Scott wrote: > Hi Dave, > > ----- Original Message ----- >> ----- Original Message ----- >>> On 08/23/2012 11:39 PM, Nathan Scott wrote: >>>> ... >> *nod* - good plan re doing that testing. Since there's a bit of >> rework required around the ipc table, I was thinking of pulling >> out just the api-wrapper type changes (so, a no-op change) and >> testing/merging those (by hand, probably, not git merge on the >> nss branch, which is starting to look a bit like its done a few >> rounds with Mike Tyson). > OK, wow, what a marathon. Glad we went this way though, a few more > lurking issues did fall out... > > __pmFcntlGetFlags() has accidentally replaced two different fcntl() > calls with just the one. Subtle, but F_GETFL != F_GETFD (the final > letter differs - FL is file status flags, FD file descriptor flags). > Huh, I've never noticed that - but they definitely map to different > codes in fcntl.h. I've created new separate interfaces to help to > clarify this. Likewise for the SetFlags() variant. > > __pmAuxConnectPMCDPort() had an error path (__pmCreateSocket fail) > that introduced a "HostEntBuffer" memleak. Likewise in the perl > wrapper module (local_reconnector, I think). > > Naming convention for fields in impl.h structures appears to be all > lower case with underscores ... made a note there re __pmFdSet. > > Found memleaks on all of the calls to __pmSockAddrInToString. > > > I also renamed the "mysocklen_t" (old school) type to __pmSockLen > which matches the new type names better. > > Finally, I left a note in the (now empty, ready for you) section > for NSS code - I think it'll be better to go with fewer #ifdefs; > so instead of... > > __pmFunction() > { > #ifdef NSS > ... > #else > ... > #endif > ... (usually 1 or 0 lines here) ... > } > > to have two totally distinct implementations (so, one #ifdef only, > not one in each function). > > Running it through the QA tests now. Hmm - was looking good while I > was writing this, but then 062 just failed (__pmAccAddClient related? > "host 29: __pmAccAddClient returns denyOpsResult 0x0 (expected 0xdfffffff)" > style messages). Will finish off the run and get the full results & > a merge tree up on oss, and try catch you in the morning to discuss. > > cheers. > > -- > Nathan From nscott@redhat.com Thu Aug 30 17:58:04 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7UMw4kA037401 for ; Thu, 30 Aug 2012 17:58:04 -0500 X-ASG-Debug-ID: 1346367536-04cb6c0e11f0230001-S8gJnT Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by cuda.sgi.com with ESMTP id ADZipJ9HgEKfJFnk for ; Thu, 30 Aug 2012 15:58:56 -0700 (PDT) X-Barracuda-Envelope-From: nscott@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.25 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7UMwuPH011809; Thu, 30 Aug 2012 18:58:56 -0400 Date: Thu, 30 Aug 2012 18:58:56 -0400 (EDT) From: Nathan Scott Reply-To: Nathan Scott To: Dave Brolley Cc: pcp@oss.sgi.com Message-ID: <297138888.3558459.1346367536349.JavaMail.root@redhat.com> In-Reply-To: <503FB5BB.6060002@redhat.com> Subject: Re: [pcp] NSS/NSPR review notes MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [pcp] NSS/NSPR review notes Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.51.114] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Linux)/7.2.0_GA_2669) X-Barracuda-Connect: mx4-phx2.redhat.com[209.132.183.25] X-Barracuda-Start-Time: 1346367536 X-Barracuda-URL: http://192.48.176.15:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.01 X-Barracuda-Spam-Status: No, SCORE=0.01 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.7 tests=BSF_SC0_SA_TO_FROM_DOMAIN_MATCH X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.107143 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 BSF_SC0_SA_TO_FROM_DOMAIN_MATCH Sender Domain Matches Recipient Domain ----- Original Message ----- > Hi Nathan, > > Wow, thanks for the merge and for the good catches while doing it! No problem. Again - struck me that good progress auditing all call sites and plugging in the NSS variants being made; alot of work went in there, glad someone else did it all. :) There were no other new QA failures (theres a handful of existing failures I'm still working my way through). I'm also not setup for remote tests yet (see below) which is important for this checking - hence I put it all in a new "nssmerge" branch for now, so we can work from that starting point, which is almost ready to merge. > I have had a look and don't see anything missing. I look forward to > the full test results. Is it difficult to setup/run the test suite? Yes and no. It depends. Its straight forward to initially setup now - you can either do a full package build (./Makepkgs) and install the pcp-testsuite rpm, or run the tests in the $(TOPDIR)/qa directory directly. Tricky parts come in when tests fail (initially), finding out whats gone wrong in setup process, or whether its a genuine test failure. I sent some mail a week or so back about the initial steps - there's ongoing refinements to make it simpler still, so those are already out-of-date a little. You can now type "./common" as a first step (previously I suggested "make setup", but that has a chicken-and-egg situation with getting the QA agents running locally - pmdasample, etc) before attempting to create some PCP archives. Once thats done, you're setup and ready - then its just a matter of running the "./check" driver script, which will run through all the tests and provides feedback on each one. Thats the easy version. You and I are going to quickly need to go beyond that though, into full-blooded QA mode, where we have remote systems involved for doing protocol up/down rev, remote 32/64 bit host checking, etc. This is more involved, and requires hostnames to be added to the qa_hosts files (via qa_hosts.master). But, get the first phase up and running reliably first before the attempt on remote tests is made (bound to be some fallout there). cheers. -- Nathan From brolley@redhat.com Fri Aug 31 15:05:19 2012 X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q7VK5I3e223249 for ; Fri, 31 Aug 2012 15:05:19 -0500 X-ASG-Debug-ID: 1346443572-04bdf05eeb154e70001-S8gJnT Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id 4T0bofKmeDwBFUQD for ; Fri, 31 Aug 2012 13:06:13 -0700 (PDT) X-Barracuda-Envelope-From: brolley@redhat.com X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-ASG-Whitelist: Client Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7VK6CWk018726 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 31 Aug 2012 16:06:12 -0400 Received: from [10.11.10.220] (vpn-10-220.rdu.redhat.com [10.11.10.220]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7VK6Bqu008873 for ; Fri, 31 Aug 2012 16:06:12 -0400 Message-ID: <50411933.4040208@redhat.com> Date: Fri, 31 Aug 2012 16:06:11 -0400 From: Dave Brolley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 MIME-Version: 1.0 To: pcp@oss.sgi.com Subject: Re: [pcp] NSS/NSPR review notes References: <297138888.3558459.1346367536349.JavaMail.root@redhat.com> X-ASG-Orig-Subj: Re: [pcp] NSS/NSPR review notes In-Reply-To: <297138888.3558459.1346367536349.JavaMail.root@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1346443573 X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com On 08/30/2012 06:58 PM, Nathan Scott wrote: > There were no other new QA failures (theres a handful of existing > failures I'm still working my way through). I'm also not setup for > remote tests yet (see below) which is important for this checking - > hence I put it all in a new "nssmerge" branch for now, so we can work > from that starting point, which is almost ready to merge. I found a couple of problems with the way __pmAccAddClient was being called from the qa code (was being passed a pointer to 'struct in_addr', but now expects __pmIPAddr). I have managed to build the branch and get the tests started. Not done yet, but no failure in 062. One nit with the test setup: ./common expected that pmcd would already be running. Not hard to do, but perhaps it should just start it if one is not running. I'll send you my results when they're done and push the code to the nssmerge branch the at that time, if I am able. If not, I can send you a patch. Just a reminder that Monday is a holiday here in Canada (and in the U.S. as well). Have a great weekend! Dave