From mailman-bounces@oss.sgi.com Mon Mar 1 05:04:07 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, FH_DATE_PAST_20XX,J_CHICKENPOX_25 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o21B0gHN164867 for ; Mon, 1 Mar 2010 05:00:42 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Subject: oss.sgi.com mailing list memberships reminder From: mailman-owner@oss.sgi.com To: pcp@oss.sgi.com X-No-Archive: yes Message-ID: Date: Mon, 01 Mar 2010 05:00:29 -0600 Precedence: bulk X-BeenThere: mailman@oss.sgi.com X-Mailman-Version: 2.1.11 List-Id: Mailman mail X-List-Administrivia: yes Sender: mailman-bounces@oss.sgi.com Errors-To: mailman-bounces@oss.sgi.com This is a reminder, sent out once a month, about your oss.sgi.com mailing list memberships. It includes your subscription info and how to use it to change it or unsubscribe from a list. You can visit the URLs to change your membership status or configuration, including unsubscribing, setting digest-style delivery or disabling delivery altogether (e.g., for a vacation), and so on. In addition to the URL interfaces, you can also use email to make such changes. For more info, send a message to the '-request' address of the list (for example, mailman-request@oss.sgi.com) containing just the word 'help' in the message body, and an email message will be sent to you with instructions. If you have questions, problems, comments, etc, send them to mailman-owner@oss.sgi.com. Thanks! Passwords for pcp@oss.sgi.com: List Password // URL ---- -------- pcp-announce@oss.sgi.com xE+IBctR http://oss.sgi.com/mailman/options/pcp-announce/pcp%40oss.sgi.com From mort@sgi.com Tue Mar 2 08:22:57 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o22EMuJO254091 for ; Tue, 2 Mar 2010 08:22:57 -0600 Received: from attica.americas.sgi.com (attica.americas.sgi.com [128.162.236.44]) by relay1.corp.sgi.com (Postfix) with ESMTP id 671B68F80D7 for ; Tue, 2 Mar 2010 06:24:21 -0800 (PST) Received: by attica.americas.sgi.com (Postfix, from userid 44682) id 273DFA5F9201; Tue, 2 Mar 2010 08:24:21 -0600 (CST) Date: Tue, 2 Mar 2010 08:24:20 -0600 From: Martin Hicks To: pcp@oss.sgi.com Subject: pcp updates Message-ID: <20100302142420.GE14670@alcatraz.americas.sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.17 (2007-11-01) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean This cleans out a bunch of the SGI-specific build stuff that we no longer use since moving to pcp-3.0 and building directly from upstream SRPMS. We could probably also drop the "default_pcp" nomenclature also in favour of the "default" target for makefiles, but I didn't go that far this time... mh The following changes since commit 908a60613bace6160ee148284c05f64f2fd4d928: Martin Hicks (1): Fix mem.numa.util.NFS_Unstable metric are available in the git repository at: git://oss.sgi.com/mort/pcp.git sgi-purge Martin Hicks (2): Clean out SGI-isms from various build related files One more bit of SGI-ism in the specfile removed GNUmakefile | 28 +-------- Makepkgs | 163 +++++++++++++++++++----------------------------- build/rpm/pcp.spec.in | 35 +--------- src/include/buildrules | 2 +- 4 files changed, 69 insertions(+), 159 deletions(-) From nathans@aconex.com Sat Mar 6 00:46:37 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o266kaRe063798 for ; Sat, 6 Mar 2010 00:46:37 -0600 X-ASG-Debug-ID: 1267858084-04dc01a30000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 8FEC813FEDF6 for ; Fri, 5 Mar 2010 22:48:04 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id Q8aedhj5QOU9uCKu for ; Fri, 05 Mar 2010 22:48:04 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id E14BC3225AA for ; Sat, 6 Mar 2010 17:48:02 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id 2PBxstNSqV6xhgUO for ; Sat, 06 Mar 2010 17:48:02 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id A5B81A500A6 for ; Sat, 6 Mar 2010 17:45:22 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id A8209488442 for ; Sat, 6 Mar 2010 17:48:02 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tMzsgVDPSKu8 for ; Sat, 6 Mar 2010 17:47:58 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 8C3A1488441 for ; Sat, 6 Mar 2010 17:47:58 +1100 (EST) Date: Sat, 6 Mar 2010 17:47:58 +1100 (EST) From: Nathan Scott To: pcp@oss.sgi.com Message-ID: <2020371113.1032031267858078408.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcp-gui updates Subject: pcp-gui updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [211.28.150.226] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - SAF3 (Mac)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1267858085 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.24136 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Changes committed to git://oss.sgi.com/pcp/pcp-gui.git src/chart/infodialog.h | 2 +- src/chart/namespace.cpp | 9 +++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) commit ebd15b382642aa0e8d09943aae51d71ec4da162b Author: Ken McDonell Date: Thu Mar 4 08:20:55 2010 +1100 Knock off a compiler warning. commit 611a0a3a5c1b78c99be48ff75d2cf53e071afed6 Author: Ken McDonell Date: Thu Mar 4 08:20:44 2010 +1100 Fix up handling of metric names containing no dot-separators. From nathans@aconex.com Mon Mar 8 03:12:33 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o289CXN7020991 for ; Mon, 8 Mar 2010 03:12:33 -0600 X-ASG-Debug-ID: 1268039642-0de3029c0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id AE592222D8B for ; Mon, 8 Mar 2010 01:14:02 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id nWr3tQfXx939p8w4 for ; Mon, 08 Mar 2010 01:14:02 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 7A2B2335838 for ; Mon, 8 Mar 2010 20:14:00 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id XP5SyZAw9SEItle5 for ; Mon, 08 Mar 2010 20:14:00 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 3820FA501BD for ; Mon, 8 Mar 2010 20:11:19 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 6619C4884BA for ; Mon, 8 Mar 2010 20:14:00 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MNpisCBnOUNY for ; Mon, 8 Mar 2010 20:13:55 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 9BE744884C6 for ; Mon, 8 Mar 2010 20:13:55 +1100 (EST) Date: Mon, 8 Mar 2010 20:13:55 +1100 (EST) From: Nathan Scott To: pcp Message-ID: <513827904.1047821268039635529.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: Changes to pcp-gui branches Subject: Changes to pcp-gui branches MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [211.28.150.226] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - SAF3 (Mac)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1268039643 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.24327 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Hi all, Just a quick note to say I switched the pcp-gui git tree to a model that follows the pcp git tree now wrt branches. We now have a master and dev branch, which are for the stable releases, just like with pcp. There's a third branch currently, which has some of the more experimental code (including pmview), called "revamp" - some day this will become stable, but thats a long way off. Default branch for a git clone/pull on this tree is master, which is the last stable release - basically, same as pcp. Hopefully this clears up some confusion. cheers. -- Nathan From pcp-announce-bounces@oss.sgi.com Wed Mar 10 13:34:08 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=ALL_TRUSTED,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2AJGu29079779 for ; Wed, 10 Mar 2010 13:16:56 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit From: pcp-announce-request@oss.sgi.com To: pcp@oss.sgi.com Subject: confirm 8fe0ead4f5ccc2abbc720a94feef09a684aff095 Reply-To: pcp-announce-request@oss.sgi.com Message-ID: Date: Wed, 10 Mar 2010 13:16:55 -0600 Precedence: bulk X-BeenThere: pcp-announce@oss.sgi.com X-Mailman-Version: 2.1.11 List-Id: pcp announcements X-List-Administrivia: yes Sender: pcp-announce-bounces@oss.sgi.com Errors-To: pcp-announce-bounces@oss.sgi.com Mailing list removal confirmation notice for mailing list pcp-announce We have received a request for the removal of your email address, "pcp@oss.sgi.com" from the pcp-announce@oss.sgi.com mailing list. To confirm that you want to be removed from this mailing list, simply reply to this message, keeping the Subject: header intact. Or visit this web page: http://oss.sgi.com/mailman/confirm/pcp-announce/8fe0ead4f5ccc2abbc720a94feef09a684aff095 Or include the following line -- and only the following line -- in a message to pcp-announce-request@oss.sgi.com: confirm 8fe0ead4f5ccc2abbc720a94feef09a684aff095 Note that simply sending a `reply' to this message should work from most mail readers, since that usually leaves the Subject: line in the right form (additional "Re:" text in the Subject: is okay). If you do not wish to be removed from this list, please simply disregard this message. If you think you are being maliciously removed from the list, or have any other questions, send them to pcp-announce-owner@oss.sgi.com. From wwwrun@oss.sgi.com Thu Mar 11 10:27:48 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2BGRmuP167475 for ; Thu, 11 Mar 2010 10:27:48 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id o2BGRmuJ167474; Thu, 11 Mar 2010 10:27:48 -0600 Date: Thu, 11 Mar 2010 10:27:48 -0600 From: bugzilla-daemon@oss.sgi.com To: pcp@oss.sgi.com Subject: [Bug 866] New: hinv.map.scsi uses /proc/scsi/scsi which is deprecated X-Bugzilla-Reason: CC X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: pcp X-Bugzilla-Component: pcp X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mort@sgi.com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: mort@sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=866 Summary: hinv.map.scsi uses /proc/scsi/scsi which is deprecated Product: pcp Version: unspecified Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: P3 Component: pcp AssignedTo: mort@sgi.com ReportedBy: mort@sgi.com CC: pcp@oss.sgi.com Estimated Hours: 0.0 Classification: Unclassified This should be converted to use the information found in /sys on Linux -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. From wwwrun@oss.sgi.com Thu Mar 11 10:31:20 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2BGVK5I167747 for ; Thu, 11 Mar 2010 10:31:20 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id o2BGVKnw167746; Thu, 11 Mar 2010 10:31:20 -0600 Date: Thu, 11 Mar 2010 10:31:20 -0600 From: bugzilla-daemon@oss.sgi.com To: pcp@oss.sgi.com Subject: [Bug 867] New: Use syslog for logging rather than stderr redirection X-Bugzilla-Reason: CC X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: pcp X-Bugzilla-Component: pcp X-Bugzilla-Keywords: X-Bugzilla-Severity: major X-Bugzilla-Who: mort@sgi.com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P5 X-Bugzilla-Assigned-To: mort@sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=867 Summary: Use syslog for logging rather than stderr redirection Product: pcp Version: unspecified Platform: All OS/Version: Linux Status: NEW Severity: major Priority: P5 Component: pcp AssignedTo: mort@sgi.com ReportedBy: mort@sgi.com CC: pcp@oss.sgi.com Estimated Hours: 0.0 Classification: Unclassified This comment is generally for the daemon processes, but would require major rework of the current logging in the PCP libraries in order to continue to allow applications to log to stderr or a specified logfile. It is very desirable for daemon processes (pmlogger, pmie, pmcd, pmdas) to log via syslog. This would allow for remote syslog logging, advanced filtering for error conditions, and centralized log rotation. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. From wwwrun@oss.sgi.com Thu Mar 11 10:34:45 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, FH_DATE_PAST_20XX,J_CHICKENPOX_72,J_CHICKENPOX_73 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2BGYj6A167995 for ; Thu, 11 Mar 2010 10:34:45 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id o2BGYj2S167994; Thu, 11 Mar 2010 10:34:45 -0600 Date: Thu, 11 Mar 2010 10:34:45 -0600 From: bugzilla-daemon@oss.sgi.com To: pcp@oss.sgi.com Subject: [Bug 868] New: add extended TCP and IP stats to linux PMDA X-Bugzilla-Reason: CC X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: pcp X-Bugzilla-Component: pcp X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mort@sgi.com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P5 X-Bugzilla-Assigned-To: mort@sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=868 Summary: add extended TCP and IP stats to linux PMDA Product: pcp Version: unspecified Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: P5 Component: pcp AssignedTo: mort@sgi.com ReportedBy: mort@sgi.com CC: pcp@oss.sgi.com Estimated Hours: 0.0 Classification: Unclassified We have the basic statistics in network.tcp and network.ip, but there are additional "extended" statistics in 'netstat -s' that would be interesting. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. From wwwrun@oss.sgi.com Thu Mar 11 10:48:48 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2BGmm23169331 for ; Thu, 11 Mar 2010 10:48:48 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id o2BGmm7K169330; Thu, 11 Mar 2010 10:48:48 -0600 Date: Thu, 11 Mar 2010 10:48:48 -0600 From: bugzilla-daemon@oss.sgi.com To: pcp@oss.sgi.com Subject: [Bug 869] New: Add details on ipc facilities to linux PMDA X-Bugzilla-Reason: CC X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: pcp X-Bugzilla-Component: pcp X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mort@sgi.com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P5 X-Bugzilla-Assigned-To: mort@sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=869 Summary: Add details on ipc facilities to linux PMDA Product: pcp Version: unspecified Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: P5 Component: pcp AssignedTo: mort@sgi.com ReportedBy: mort@sgi.com CC: pcp@oss.sgi.com Estimated Hours: 0.0 Classification: Unclassified We provide a summary of the global statistics related to IPC facilities in the ipc.* namespace, but we don't provide any details about the individual semaphores, shm and message queues that are in use in the system. This can be seen via "ipcs -s". I'm not sure what the backing source of the information is. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. From wwwrun@oss.sgi.com Thu Mar 11 10:51:37 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2BGpbrO169510 for ; Thu, 11 Mar 2010 10:51:37 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id o2BGpbrT169509; Thu, 11 Mar 2010 10:51:37 -0600 Date: Thu, 11 Mar 2010 10:51:37 -0600 From: bugzilla-daemon@oss.sgi.com To: pcp@oss.sgi.com Subject: [Bug 870] New: IB: does not deal with LID reassignment X-Bugzilla-Reason: CC X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: pcp X-Bugzilla-Component: pcp X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mort@sgi.com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P5 X-Bugzilla-Assigned-To: mort@sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=870 Summary: IB: does not deal with LID reassignment Product: pcp Version: unspecified Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: P5 Component: pcp AssignedTo: mort@sgi.com ReportedBy: mort@sgi.com CC: pcp@oss.sgi.com Estimated Hours: 0.0 Classification: Unclassified I'm not 100% sure this is still a problem. Makc rewrote the PMDA a while ago, and this may deal better with LID reassignment, or maybe we no longer care if the LID is changed. Needs to be investigated. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. From wwwrun@oss.sgi.com Thu Mar 11 11:56:05 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2BHu5m1174239 for ; Thu, 11 Mar 2010 11:56:05 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id o2BHu5IE174238; Thu, 11 Mar 2010 11:56:05 -0600 Date: Thu, 11 Mar 2010 11:56:05 -0600 From: bugzilla-daemon@oss.sgi.com To: pcp@oss.sgi.com Subject: [Bug 871] New: poor error checking in __pmDecodeProfile X-Bugzilla-Reason: CC X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: pcp X-Bugzilla-Component: pcp X-Bugzilla-Keywords: X-Bugzilla-Severity: major X-Bugzilla-Who: mort@sgi.com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: mort@sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=871 Summary: poor error checking in __pmDecodeProfile Product: pcp Version: unspecified Platform: All OS/Version: Linux Status: NEW Severity: major Priority: P2 Component: pcp AssignedTo: mort@sgi.com ReportedBy: mort@sgi.com CC: daw@sgi.com, pcp@oss.sgi.com Estimated Hours: 0.0 Classification: Unclassified A fairly old bug from SGI, reported by Greg Banks. I just did some quick verification and the below still seems to be true: Seen while poring over PCP source to try to explain memory leaks reported by valgrind. There are some minor problems with the way __pmDecodeProfile decodes incoming PDUs. Memory is allocated at three different places in the code, and linked together into a data structure. 1. At each point, failure to allocate memory is handled by returning -errno without cleaning up any memory allocated earlier. 2. Two of the allocations use a scaling factor which comes from the PDU without any bounds checking at all. 3. For one of the allocations, a zero scaling factor appears to be a legal value. The code then relies on malloc(0) != NULL which is a platform-dependent assumption (although it appears to be true for both glibc and Irix libc). -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. From mort@sgi.com Thu Mar 11 11:59:04 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2BHx4dC174474 for ; Thu, 11 Mar 2010 11:59:04 -0600 Received: from attica.americas.sgi.com (attica.americas.sgi.com [128.162.236.44]) by relay1.corp.sgi.com (Postfix) with ESMTP id 9A2DC8F8073 for ; Thu, 11 Mar 2010 10:00:34 -0800 (PST) Received: by attica.americas.sgi.com (Postfix, from userid 44682) id 639A4A5F9B51; Thu, 11 Mar 2010 12:00:34 -0600 (CST) Date: Thu, 11 Mar 2010 12:00:34 -0600 From: Martin Hicks To: pcp@oss.sgi.com Subject: PCP bugs from SGI Message-ID: <20100311180034.GH17944@alcatraz.americas.sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.17 (2007-11-01) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Hi, I finally went through the PCP queue at SGI and cleaned out a pile of old bugs. I found a number that were potentially interesting projects for some aspiring PCP developer, so I pushed these into bugzilla. There were also some bugs related to core functionality in PCP that was questionable in regards to error checking. I opened one in particular: http://oss.sgi.com/bugzilla/show_bug.cgi?id=871 mh From wwwrun@oss.sgi.com Fri Mar 12 03:09:33 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2C99X9u238301 for ; Fri, 12 Mar 2010 03:09:33 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id o2C99WNf238299; Fri, 12 Mar 2010 03:09:32 -0600 Date: Fri, 12 Mar 2010 03:09:32 -0600 From: bugzilla-daemon@oss.sgi.com To: pcp@oss.sgi.com Subject: [Bug 872] New: Compilation fails X-Bugzilla-Reason: CC X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: pcp X-Bugzilla-Component: pcp-gui X-Bugzilla-Keywords: X-Bugzilla-Severity: trivial X-Bugzilla-Who: freelance@hackbox.fr X-Bugzilla-Status: NEW X-Bugzilla-Priority: P5 X-Bugzilla-Assigned-To: nathans@debian.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=872 Summary: Compilation fails Product: pcp Version: unspecified Platform: All OS/Version: Linux Status: NEW Severity: trivial Priority: P5 Component: pcp-gui AssignedTo: nathans@debian.org ReportedBy: freelance@hackbox.fr CC: pcp@oss.sgi.com Estimated Hours: 0.0 Classification: Unclassified In src/include/version.h line 33: --- #define HAVE_PM_PATH_SEPARATOR 0 #if HAVE_PM_PATH_SEPARATOR == 0 static inline void __pmPathSeparator(void) { return '/'; } #endif --- The returned type is not correct, the compilation fails at this point. It happens with the tarball available on the official website and the sources cloned from the git repository. I propose the following instead: --- #define HAVE_PM_PATH_SEPARATOR 0 #if HAVE_PM_PATH_SEPARATOR == 0 static inline char __pmPathSeparator(void) { return '/'; } #endif --- Best regards -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. From kenj@internode.on.net Fri Mar 12 15:32:05 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2CLW4Hh025478 for ; Fri, 12 Mar 2010 15:32:05 -0600 X-ASG-Debug-ID: 1268429615-6876034b0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id CB05A237939 for ; Fri, 12 Mar 2010 13:33:36 -0800 (PST) Received: from mail.internode.on.net (bld-mail12.adl6.internode.on.net [150.101.137.97]) by cuda.sgi.com with ESMTP id 0xzBoO9rCJK6ZVDI for ; Fri, 12 Mar 2010 13:33:36 -0800 (PST) Received: from [192.168.1.100] (unverified [118.209.108.17]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 16869481-1927428 for multiple; Sat, 13 Mar 2010 08:03:31 +1030 (CDT) X-ASG-Orig-Subj: Re: [pcp] PCP bugs from SGI Subject: Re: [pcp] PCP bugs from SGI From: Ken McDonell Reply-To: kenj@internode.on.net To: Martin Hicks Cc: pcp@oss.sgi.com, Greg Banks In-Reply-To: <20100311180034.GH17944@alcatraz.americas.sgi.com> References: <20100311180034.GH17944@alcatraz.americas.sgi.com> Content-Type: multipart/mixed; boundary="=-hX1dobptb22OQNx5vS5x" Date: Sat, 13 Mar 2010 08:33:29 +1100 Message-ID: <1268429609.2642.690.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 X-Barracuda-Connect: bld-mail12.adl6.internode.on.net[150.101.137.97] X-Barracuda-Start-Time: 1268429617 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.52 X-Barracuda-Spam-Status: No, SCORE=-1.52 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.24699 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean --=-hX1dobptb22OQNx5vS5x Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit OK, this was sloppy coding on my part, but it has probability of occurrence that close to, or less than, the chance that I'll live to 100 years old. Because I'm retired and have nothing better to do (sigh), the attached patch addresses the issue ... if someone else would care to review it and it looks acceptable, I'll gladly commit it into my oss tree. ps as if you'd need to ask, PCP QA passes with this patch applied. On Thu, 2010-03-11 at 12:00 -0600, Martin Hicks wrote: > Hi, > > I finally went through the PCP queue at SGI and cleaned out a pile of > old bugs. I found a number that were potentially interesting projects > for some aspiring PCP developer, so I pushed these into bugzilla. > > There were also some bugs related to core functionality in PCP that was > questionable in regards to error checking. I opened one in particular: > > http://oss.sgi.com/bugzilla/show_bug.cgi?id=871 > > > mh > > _______________________________________________ > pcp mailing list > pcp@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/pcp --=-hX1dobptb22OQNx5vS5x Content-Disposition: attachment; filename="patch.libpcp" Content-Type: text/x-patch; name="patch.libpcp"; charset="UTF-8" Content-Transfer-Encoding: 7bit diff --git a/src/libpcp/src/p_profile.c b/src/libpcp/src/p_profile.c index bb39ee7..fed0fde 100644 --- a/src/libpcp/src/p_profile.c +++ b/src/libpcp/src/p_profile.c @@ -103,11 +103,12 @@ __pmSendProfile(int fd, int mode, int ctxnum, __pmProfile *instprof) int __pmDecodeProfile(__pmPDU *pdubuf, int mode, int *ctxnum, __pmProfile **result) { - __pmProfile *instprof; + __pmProfile *instprof = NULL; __pmInDomProfile *prof, *p_end; profile_t *pduProfile; instprof_t *pduInstProf; __pmPDU *p; + int sts = 0; if (mode == PDU_ASCII) return PM_ERR_NOASCII; @@ -120,13 +121,16 @@ __pmDecodeProfile(__pmPDU *pdubuf, int mode, int *ctxnum, __pmProfile **result) if ((instprof = (__pmProfile *)malloc(sizeof(__pmProfile))) == NULL) return -errno; instprof->state = ntohl(pduProfile->g_state); + instprof->profile = NULL; instprof->profile_len = ntohl(pduProfile->numprof); p += sizeof(profile_t) / sizeof(__pmPDU); if (instprof->profile_len > 0) { if ((instprof->profile = (__pmInDomProfile *)malloc( - instprof->profile_len * sizeof(__pmInDomProfile))) == NULL) - return -errno; + instprof->profile_len * sizeof(__pmInDomProfile))) == NULL) { + sts = -errno; + goto fail; + } /* Next the profiles (if any) all together */ for (prof = instprof->profile, p_end = prof + instprof->profile_len; @@ -135,6 +139,7 @@ __pmDecodeProfile(__pmPDU *pdubuf, int mode, int *ctxnum, __pmProfile **result) pduInstProf = (instprof_t *)p; prof->indom = __ntohpmInDom(pduInstProf->indom); prof->state = ntohl(pduInstProf->state); + prof->instances = NULL; prof->instances_len = ntohl(pduInstProf->numinst); p += sizeof(instprof_t) / sizeof(__pmPDU); } @@ -145,11 +150,17 @@ __pmDecodeProfile(__pmPDU *pdubuf, int mode, int *ctxnum, __pmProfile **result) prof++) { int j; - prof->instances = (int *)malloc(prof->instances_len * sizeof(int)); - if (prof->instances == NULL) - return -errno; - for (j = 0; j < prof->instances_len; j++, p++) - prof->instances[j] = ntohl(*p); + if (prof->instances_len > 0) { + prof->instances = (int *)malloc(prof->instances_len * sizeof(int)); + if (prof->instances == NULL) { + sts = -errno; + goto fail; + } + for (j = 0; j < prof->instances_len; j++, p++) + prof->instances[j] = ntohl(*p); + } + else + prof->instances = NULL; } } else @@ -157,4 +168,19 @@ __pmDecodeProfile(__pmPDU *pdubuf, int mode, int *ctxnum, __pmProfile **result) *result = instprof; return 0; + +fail: + if (instprof != NULL) { + if (instprof->profile != NULL) { + for (prof = instprof->profile, p_end = prof+instprof->profile_len; + prof < p_end; + prof++) { + if (prof->instances != NULL) + free(prof->instances); + } + free(instprof->profile); + } + free(instprof); + } + return sts; } --=-hX1dobptb22OQNx5vS5x-- From wwwrun@oss.sgi.com Fri Mar 12 18:36:26 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2D0aPof040595 for ; Fri, 12 Mar 2010 18:36:25 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id o2D0aPIO040594; Fri, 12 Mar 2010 18:36:25 -0600 Date: Fri, 12 Mar 2010 18:36:25 -0600 Message-Id: <201003130036.o2D0aPIO040594@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: pcp@oss.sgi.com Subject: [Bug 872] Compilation fails X-Bugzilla-Reason: CC X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: pcp X-Bugzilla-Component: pcp-gui X-Bugzilla-Keywords: X-Bugzilla-Severity: trivial X-Bugzilla-Who: nathans@debian.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P5 X-Bugzilla-Assigned-To: nathans@debian.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=872 --- Comment #1 from Nathan Scott 2010-03-12 18:36:23 CST --- Thanks David - yep, pretty clearly not right. Will get that fixed up shortly. FWIW, looks like you're building with a fairly old version of libpcp there? (certainly well before pcp-3.0 I guess - that'd be the reason I've never hit this one myself). cheers. -- Nathan -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. From nathans@aconex.com Fri Mar 12 18:43:45 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2D0hiEb041202 for ; Fri, 12 Mar 2010 18:43:45 -0600 X-ASG-Debug-ID: 1268441117-4e0b02ac0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 820F61425198 for ; Fri, 12 Mar 2010 16:45:17 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id 3GBxuEHTmEEw321A for ; Fri, 12 Mar 2010 16:45:17 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id B2C0036C3F1 for ; Sat, 13 Mar 2010 11:45:14 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id nD8qH8rVn8pAnZ5H for ; Sat, 13 Mar 2010 11:45:14 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id E7C1DA50280 for ; Sat, 13 Mar 2010 11:42:30 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 9C0A4488488 for ; Sat, 13 Mar 2010 11:45:14 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GrJhp2X1FaG9 for ; Sat, 13 Mar 2010 11:45:10 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id ACAEF488484 for ; Sat, 13 Mar 2010 11:45:10 +1100 (EST) Date: Sat, 13 Mar 2010 11:45:10 +1100 (EST) From: Nathan Scott To: pcp@oss.sgi.com Message-ID: <205748139.1194201268441110188.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcp-gui updates Subject: pcp-gui updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [211.28.150.226] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - SAF3 (Mac)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1268441118 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.24710 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Changes committed to git://oss.sgi.com/pcp/pcp-gui.git src/include/version.h.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit f6f91ff630a0eed4539441b9b9cc64ffe90db7bf Author: Nathan Scott Date: Sat Mar 13 11:43:03 2010 +1100 Correct __pmPathSeparator stub for back-compat libpcp builds. This stub was returning void when it shoulda matched the libpcp definition which returns an integer. Thanks to David Ribeiro for reporting the issue. From wwwrun@oss.sgi.com Fri Mar 12 18:45:34 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, FH_DATE_PAST_20XX,J_CHICKENPOX_63 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2D0jYGl041391 for ; Fri, 12 Mar 2010 18:45:34 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id o2D0jXZY041390; Fri, 12 Mar 2010 18:45:33 -0600 Date: Fri, 12 Mar 2010 18:45:33 -0600 Message-Id: <201003130045.o2D0jXZY041390@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: pcp@oss.sgi.com Subject: [Bug 872] Compilation fails X-Bugzilla-Reason: CC X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: pcp X-Bugzilla-Component: pcp-gui X-Bugzilla-Keywords: X-Bugzilla-Severity: trivial X-Bugzilla-Who: nathans@debian.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P5 X-Bugzilla-Assigned-To: nathans@debian.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status Resolution In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=872 Nathan Scott changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Nathan Scott 2010-03-12 18:45:32 CST --- Fix in the pcp-gui git tree now (dev branch), will go out with the next release. In the meantime, simple workaround would be to upgrade pcp, building with the newer libpcp and pcp headers will avoid this broken code path. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. From nathans@aconex.com Fri Mar 12 18:51:29 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2D0pTkf041935 for ; Fri, 12 Mar 2010 18:51:29 -0600 X-ASG-Debug-ID: 1268441582-54e402730000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 50EBA1424FEB for ; Fri, 12 Mar 2010 16:53:02 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id G1fExe4iphAZ2tEC for ; Fri, 12 Mar 2010 16:53:02 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 78A6536C5F3; Sat, 13 Mar 2010 11:53:01 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id bLZSBdh1GHhCAj9c; Sat, 13 Mar 2010 11:53:01 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id A9162A50280; Sat, 13 Mar 2010 11:50:17 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 5B540488488; Sat, 13 Mar 2010 11:53:01 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TCAg6MzhIKR9; Sat, 13 Mar 2010 11:52:56 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 9CF8D488484; Sat, 13 Mar 2010 11:52:56 +1100 (EST) Date: Sat, 13 Mar 2010 11:52:56 +1100 (EST) From: Nathan Scott To: kenj@internode.on.net Cc: Greg Banks , pcp@oss.sgi.com, Martin Hicks Message-ID: <1762449926.1194231268441576454.JavaMail.root@mail-au.aconex.com> In-Reply-To: <1268429609.2642.690.camel@bozo.localdomain> X-ASG-Orig-Subj: Re: [pcp] PCP bugs from SGI Subject: Re: [pcp] PCP bugs from SGI MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [211.28.150.226] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - SAF3 (Mac)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1268441583 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.24710 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ----- "Ken McDonell" wrote: > OK, this was sloppy coding on my part, but it has probability of > occurrence that close to, or less than, the chance that I'll live to > 100 > years old. > > Because I'm retired and have nothing better to do (sigh), the > attached > patch addresses the issue ... if someone else would care to review it > and it looks acceptable, I'll gladly commit it into my oss tree. Looking good. The memory allocation based on the ntohl(pduProfile->numprof), or instprof->profile_len, value looks like it could still use some kind of ceiling sanity test? (as per Gregs bug) That teardown (and setup) kinda sucks in that its a number of small allocations, which need to be undone from wherever-we-got-up-to on failure. Guess we are too late to change this to one big contiguous malloc now though (are we? I didn't follow the code all the way up) cheers. -- Nathan From mort@bork.org Sat Mar 13 10:17:47 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2DGHlfj105889 for ; Sat, 13 Mar 2010 10:17:47 -0600 X-ASG-Debug-ID: 1268497160-12f203dd0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from darwin.bork.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 3C89A23C204 for ; Sat, 13 Mar 2010 08:19:20 -0800 (PST) Received: from darwin.bork.org (darwin.bork.org [65.49.60.145]) by cuda.sgi.com with ESMTP id e4aypBdRsjBpCNRE for ; Sat, 13 Mar 2010 08:19:20 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by darwin.bork.org (Postfix) with ESMTP id F210E193C2; Sat, 13 Mar 2010 11:15:12 -0500 (EST) Received: from darwin.bork.org ([127.0.0.1]) by localhost (darwin.bork.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id yIjWFzJMRTrO; Sat, 13 Mar 2010 11:15:12 -0500 (EST) Received: from socrates.bork.org (localhost [127.0.0.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "socrates.bork.org", Issuer "Bork Consulting CA" (not verified)) by darwin.bork.org (Postfix) with ESMTPS id 2557B192C4; Sat, 13 Mar 2010 11:15:12 -0500 (EST) Received: by socrates.bork.org (Postfix, from userid 1000) id 0A6D0CBB05; Sat, 13 Mar 2010 11:11:35 -0500 (EST) Date: Sat, 13 Mar 2010 11:11:34 -0500 From: Martin Hicks To: Nathan Scott Cc: kenj@internode.on.net, Greg Banks , pcp@oss.sgi.com X-ASG-Orig-Subj: Re: [pcp] PCP bugs from SGI Subject: Re: [pcp] PCP bugs from SGI Message-ID: <20100313161134.GA3247@socrates.bork.org> References: <1268429609.2642.690.camel@bozo.localdomain> <1762449926.1194231268441576454.JavaMail.root@mail-au.aconex.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1762449926.1194231268441576454.JavaMail.root@mail-au.aconex.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-Barracuda-Connect: darwin.bork.org[65.49.60.145] X-Barracuda-Start-Time: 1268497161 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.24752 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Sat, Mar 13, 2010 at 11:52:56AM +1100, Nathan Scott wrote: > > ----- "Ken McDonell" wrote: > > > OK, this was sloppy coding on my part, but it has probability of > > occurrence that close to, or less than, the chance that I'll live to > > 100 > > years old. > > > > Because I'm retired and have nothing better to do (sigh), the > > attached > > patch addresses the issue ... if someone else would care to review it > > and it looks acceptable, I'll gladly commit it into my oss tree. > > Looking good. > > The memory allocation based on the ntohl(pduProfile->numprof), or > instprof->profile_len, value looks like it could still use some > kind of ceiling sanity test? (as per Gregs bug) Yeah, it was that comment that struck me as the more important point. Letting an arbitrary network-connected client allocate arbitrary amounts of memory as root on the pmcd machine seems pretty terrible. mh From greg.n.banks@gmail.com Mon Mar 15 04:40:52 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2F9eqIk035635 for ; Mon, 15 Mar 2010 04:40:52 -0500 X-ASG-Debug-ID: 1268646147-7f1a01290000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail-gw0-f53.google.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id B57D92491C3 for ; Mon, 15 Mar 2010 02:42:27 -0700 (PDT) Received: from mail-gw0-f53.google.com (mail-gw0-f53.google.com [74.125.83.53]) by cuda.sgi.com with ESMTP id 5F5ButRFV2hWFZdj for ; Mon, 15 Mar 2010 02:42:27 -0700 (PDT) Received: by gwj19 with SMTP id 19so1652374gwj.26 for ; Mon, 15 Mar 2010 02:42:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=L3EnHQNeXtHBIXIxYJvIL3bAyQVU+c1/viWIjk/VFtI=; b=rGWnWX3jJS0IqBMMqcXEJJkINCFXEUh781VRjlzlzaJngxoY15P5mixDfqmT/rQ/in 3CZ+LR9KAaGNCZZYECx6nuu0xh4C3A82Dqu8C58X0i1QQyw2dQXwpAWP7e0ODGrfwq4J GkRXo72dqM3wwYY6AvDSKAmuOC+focup3HS1w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=Bde3jQHD0tdESB9EgfoSoZuVUMqcwm/mFzJEbYL9STMINMtlXEPbDByh+Jix2BkGZt R16K/2noYiabvMnZt94GUQZUVKg51YEM5IRvDmS+t/yi68ZgXdy07xKQn9v/v8rougqF f1UR+K5hoaXtKTlCyAcnIRDDKRhGVHsceBDUY= MIME-Version: 1.0 Sender: greg.n.banks@gmail.com Received: by 10.101.108.6 with SMTP id k6mr3360453anm.162.1268646146745; Mon, 15 Mar 2010 02:42:26 -0700 (PDT) In-Reply-To: <20100313161134.GA3247@socrates.bork.org> References: <1268429609.2642.690.camel@bozo.localdomain> <1762449926.1194231268441576454.JavaMail.root@mail-au.aconex.com> <20100313161134.GA3247@socrates.bork.org> Date: Mon, 15 Mar 2010 20:42:26 +1100 X-Google-Sender-Auth: bc2a08024c0eba2c Message-ID: X-ASG-Orig-Subj: Re: [pcp] PCP bugs from SGI Subject: Re: [pcp] PCP bugs from SGI From: Greg Banks To: Martin Hicks Cc: Nathan Scott , kenj@internode.on.net, pcp@oss.sgi.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Barracuda-Connect: mail-gw0-f53.google.com[74.125.83.53] X-Barracuda-Start-Time: 1268646147 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=DKIM_SIGNED, DKIM_VERIFIED X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.24911 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- -0.00 DKIM_VERIFIED Domain Keys Identified Mail: signature passes verification 0.00 DKIM_SIGNED Domain Keys Identified Mail: message has a signature X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Sun, Mar 14, 2010 at 3:11 AM, Martin Hicks wrote: > > On Sat, Mar 13, 2010 at 11:52:56AM +1100, Nathan Scott wrote: >> >> ----- "Ken McDonell" wrote: >> >> > OK, this was sloppy coding on my part, but it has probability of >> > occurrence that close to, or less than, the chance that I'll live to >> > 100 >> > years old. >> > >> > Because I'm retired and have nothing better to do (sigh), the >> > attached >> > patch addresses the issue ... if someone else would care to review it >> > and it looks acceptable, I'll gladly commit it into my oss tree. >> >> Looking good. Patch looks good to me too. >> >> The memory allocation based on the ntohl(pduProfile->numprof), or >> instprof->profile_len, value looks like it could still use some >> kind of ceiling sanity test? =A0(as per Gregs bug) > > Yeah, it was that comment that struck me as the more important point. > Letting an arbitrary network-connected client allocate arbitrary amounts > of memory as root on the pmcd machine seems pretty terrible. What they said. While memory is plentiful today, so are malicious people. --=20 Greg. From mort@bork.org Mon Mar 15 07:58:08 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2FCw82E049184 for ; Mon, 15 Mar 2010 07:58:08 -0500 X-ASG-Debug-ID: 1268657983-54a403e10000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from darwin.bork.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 1552424992C for ; Mon, 15 Mar 2010 05:59:43 -0700 (PDT) Received: from darwin.bork.org (darwin.bork.org [65.49.60.145]) by cuda.sgi.com with ESMTP id V9iZfmd71wYPv0BH for ; Mon, 15 Mar 2010 05:59:43 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by darwin.bork.org (Postfix) with ESMTP id 600CE1929A; Mon, 15 Mar 2010 08:55:32 -0400 (EDT) Received: from darwin.bork.org ([127.0.0.1]) by localhost (darwin.bork.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Sgnvh8B94Ykl; Mon, 15 Mar 2010 08:55:32 -0400 (EDT) Received: from laplace.bork.org (laplace.bork.org [IPv6:2001:470:1f11:499:21a:a0ff:feec:57ab]) by darwin.bork.org (Postfix) with ESMTP id DEB8219252; Mon, 15 Mar 2010 08:55:31 -0400 (EDT) Received: by laplace.bork.org (Postfix, from userid 1000) id 3F1FB5346F; Mon, 15 Mar 2010 08:59:42 -0400 (EDT) Date: Mon, 15 Mar 2010 08:59:41 -0400 From: Martin Hicks To: Martin Hicks Cc: pcp@oss.sgi.com X-ASG-Orig-Subj: Re: [pcp] PCP bugs from SGI Subject: Re: [pcp] PCP bugs from SGI Message-ID: <20100315125941.GG3469@laplace.bork.org> References: <20100311180034.GH17944@alcatraz.americas.sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100311180034.GH17944@alcatraz.americas.sgi.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-Barracuda-Connect: darwin.bork.org[65.49.60.145] X-Barracuda-Start-Time: 1268657984 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.24923 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Thu, Mar 11, 2010 at 12:00:34PM -0600, Martin Hicks wrote: > > Hi, > > I finally went through the PCP queue at SGI and cleaned out a pile of > old bugs. I found a number that were potentially interesting projects > for some aspiring PCP developer, so I pushed these into bugzilla. > > There were also some bugs related to core functionality in PCP that was > questionable in regards to error checking. I opened one in particular: > Here is the fix for another such PV that was inside SGI, related to AddBadHost(): mort@laplace:~/src/pcp$ git show HEAD commit a5c4f1f1197a5b7238a9eb3f3fccad1ea1d7a390 Author: Martin Hicks Date: Thu Mar 11 11:45:03 2010 -0500 Use realloc in AddBadHost Otherwise existing client info will be lost during the malloc. diff --git a/src/pmcd/src/pmcd.c b/src/pmcd/src/pmcd.c index 00c7976..5f1d32c 100644 --- a/src/pmcd/src/pmcd.c +++ b/src/pmcd/src/pmcd.c @@ -1166,7 +1166,7 @@ AddBadHost(struct in_addr *hostId) if (nBadHosts == szBadHosts) { szBadHosts += 8; need = szBadHosts * (int)sizeof(badHost[0]); - if ((badHost = (struct in_addr *)malloc(need)) == NULL) { + if ((badHost = (struct in_addr *)realloc(badHost, need)) == NULL) { __pmNoMem("pmcd.AddBadHost", need, PM_FATAL_ERR); } } mort@laplace:~/src/pcp$ git show HEAD commit a5c4f1f1197a5b7238a9eb3f3fccad1ea1d7a390 Author: Martin Hicks Date: Thu Mar 11 11:45:03 2010 -0500 Use realloc in AddBadHost Otherwise existing client info will be lost during the malloc. diff --git a/src/pmcd/src/pmcd.c b/src/pmcd/src/pmcd.c index 00c7976..5f1d32c 100644 --- a/src/pmcd/src/pmcd.c +++ b/src/pmcd/src/pmcd.c @@ -1166,7 +1166,7 @@ AddBadHost(struct in_addr *hostId) if (nBadHosts == szBadHosts) { szBadHosts += 8; need = szBadHosts * (int)sizeof(badHost[0]); - if ((badHost = (struct in_addr *)malloc(need)) == NULL) { + if ((badHost = (struct in_addr *)realloc(badHost, need)) == NULL) { __pmNoMem("pmcd.AddBadHost", need, PM_FATAL_ERR); } } From mort@bork.org Mon Mar 15 08:02:43 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2FD2hWR049521 for ; Mon, 15 Mar 2010 08:02:43 -0500 X-ASG-Debug-ID: 1268658258-702a012e0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from darwin.bork.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 1DDAE19D5E7F for ; Mon, 15 Mar 2010 06:04:18 -0700 (PDT) Received: from darwin.bork.org (darwin.bork.org [65.49.60.145]) by cuda.sgi.com with ESMTP id sZK3Cl9e9iHhBLyE for ; Mon, 15 Mar 2010 06:04:18 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by darwin.bork.org (Postfix) with ESMTP id 4AEA9193C2; Mon, 15 Mar 2010 09:00:07 -0400 (EDT) Received: from darwin.bork.org ([127.0.0.1]) by localhost (darwin.bork.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qCgoQYynxvNF; Mon, 15 Mar 2010 09:00:07 -0400 (EDT) Received: from laplace.bork.org (laplace.bork.org [IPv6:2001:470:1f11:499:21a:a0ff:feec:57ab]) by darwin.bork.org (Postfix) with ESMTP id 1210319299; Mon, 15 Mar 2010 09:00:06 -0400 (EDT) Received: by laplace.bork.org (Postfix, from userid 1000) id 084B35346F; Mon, 15 Mar 2010 09:04:18 -0400 (EDT) Date: Mon, 15 Mar 2010 09:04:18 -0400 From: Martin Hicks To: jeffpc@josefsipek.net, pcp X-ASG-Orig-Subj: postfix pmda fixup Subject: postfix pmda fixup Message-ID: <20100315130417.GH3469@laplace.bork.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) X-Barracuda-Connect: darwin.bork.org[65.49.60.145] X-Barracuda-Start-Time: 1268658259 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.24923 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Reported on IRC by Jeff. Any complaints? -- Martin Hicks || mort@bork.org || PGP/GnuPG: 0x4C7F2BEE mort@laplace:~/src/pcp$ git show HEAD commit a010a02c2592466ff97f954b644e47a007702a59 Author: Martin Hicks Date: Mon Mar 15 09:01:31 2010 -0400 Fix a label in postfix pmda The label was simply wrong. Must have been a cut & paste error or something. Reported-by: Josef 'Jeff' Sipek Signed-off-by: Martin Hicks diff --git a/src/pmdas/postfix/pmdapostfix.pl b/src/pmdas/postfix/pmdapostfix.pl index 6953fc8..d64bea4 100644 --- a/src/pmdas/postfix/pmdapostfix.pl +++ b/src/pmdas/postfix/pmdapostfix.pl @@ -100,7 +100,7 @@ my @postfix_queues_dom = ( 0 => 'total', 6 => '80-160 mins', 7 => '160-320 mins', 8 => '320-640 mins', - 9 => '640-1280 mins', + 9 => '640-1280 mins', 10=> '1280+ mins', ); From nathans@aconex.com Tue Mar 16 04:58:46 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2G9wkSN149908 for ; Tue, 16 Mar 2010 04:58:46 -0500 X-ASG-Debug-ID: 1268733620-3b2800210000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 01E1E24D6F9 for ; Tue, 16 Mar 2010 03:00:20 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id wlcWJgLJOHDdOY7h for ; Tue, 16 Mar 2010 03:00:20 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 835DA380EEF for ; Tue, 16 Mar 2010 21:00:05 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id HhXubKMEcGPEpB2O for ; Tue, 16 Mar 2010 21:00:05 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id A6EF9A503C5 for ; Tue, 16 Mar 2010 20:57:17 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 020614884D0 for ; Tue, 16 Mar 2010 21:00:03 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hMV3jPjc4IhV for ; Tue, 16 Mar 2010 20:59:59 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 052624884CC for ; Tue, 16 Mar 2010 20:59:59 +1100 (EST) Date: Tue, 16 Mar 2010 20:59:58 +1100 (EST) From: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1628493198.1277661268733598929.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcp updates Subject: pcp updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [211.28.150.226] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - SAF3 (Mac)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1268733622 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.25005 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Changes committed to git://oss.sgi.com/nathans/pcp.git src/dbpmda/src/dbpmda.c | 2 +- src/libpcp/src/config.c | 2 +- src/pmcd/src/pmcd.c | 8 ++++---- src/pmdas/postfix/pmdapostfix.pl | 2 +- src/pmdas/windows/hypnotoad.h | 7 ++++--- src/pmdas/windows/instance.c | 22 ++++++++++++++++++---- src/pmdas/windows/open.c | 12 +++++++++--- src/pmdas/windows/pmda.c | 4 ++-- src/pmlogsummary/pmlogsummary.c | 2 +- 9 files changed, 41 insertions(+), 20 deletions(-) commit b7c3f0e780d6a494e41ee70f42419b5de30a6db9 Author: Nathan Scott Date: Tue Mar 16 20:58:32 2010 +1100 Add indom save and restore logic into Windows PMDA, bit us with sqlserver indom. commit 37ed3826bef512a97729e2cef7c64462da46c206 Author: Nathan Scott Date: Tue Mar 16 20:53:49 2010 +1100 Fix logic error in Win32 version of absolute path test. commit 34f953347ad05853ea7dfdd687a6b5a654b4c87d Author: Nathan Scott Date: Tue Mar 16 20:53:26 2010 +1100 Fix repeated usage message typo - postive vs positive. commit 0a2babf8879e2977e97461c3db8fee887eab8221 Author: Josef 'Jeff' Sipek Date: Tue Mar 16 20:51:57 2010 +1100 Fix a spurious typo that somehow crept into Postfix PMDA. From kenj@internode.on.net Tue Mar 16 17:52:11 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2GMqBsv213415 for ; Tue, 16 Mar 2010 17:52:11 -0500 X-ASG-Debug-ID: 1268780025-37e103780000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5176319EE8A1 for ; Tue, 16 Mar 2010 15:53:45 -0700 (PDT) Received: from mail.internode.on.net (bld-mail15.adl6.internode.on.net [150.101.137.100]) by cuda.sgi.com with ESMTP id wHB2xiL65k4H5CvC for ; Tue, 16 Mar 2010 15:53:45 -0700 (PDT) Received: from [192.168.1.100] (unverified [118.209.108.17]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 5671548-1927428 for multiple; Wed, 17 Mar 2010 09:23:44 +1030 (CDT) X-ASG-Orig-Subj: Re: [pcp] PCP bugs from SGI Subject: Re: [pcp] PCP bugs from SGI From: Ken McDonell Reply-To: kenj@internode.on.net To: Greg Banks Cc: Martin Hicks , Nathan Scott , pcp@oss.sgi.com In-Reply-To: References: <1268429609.2642.690.camel@bozo.localdomain> <1762449926.1194231268441576454.JavaMail.root@mail-au.aconex.com> <20100313161134.GA3247@socrates.bork.org> Content-Type: text/plain; charset="UTF-8" Date: Wed, 17 Mar 2010 09:53:35 +1100 Message-ID: <1268780015.15387.37.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail15.adl6.internode.on.net[150.101.137.100] X-Barracuda-Start-Time: 1268780027 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.25055 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Mon, 2010-03-15 at 20:42 +1100, Greg Banks wrote: ... > Patch looks good to me too. > > >> > >> The memory allocation based on the ntohl(pduProfile->numprof), or > >> instprof->profile_len, value looks like it could still use some > >> kind of ceiling sanity test? (as per Gregs bug) > > > > Yeah, it was that comment that struck me as the more important point. > > Letting an arbitrary network-connected client allocate arbitrary amounts > > of memory as root on the pmcd machine seems pretty terrible. > > What they said. While memory is plentiful today, so are malicious people. > Can we have a short discussion on these possible limits? I'll buy limiting profile_len to 1024 (of the possible 2^31 instance domains) because as of Mar 2010 there are fewer than 100 different instance domains in the open source version of PCP. But instances_len occurs with every instance domain in the profile, and the largest instance domain is likely to be for "proc" metrics so does anyone want to put a limit on this? And I've checked, at least pmtop enumerates the proc indom and adds it to the profile, pmlogger could end up with a long list of explicit instances to be logged, pminfo will do the same as pmtop for any indom that is non-enumerable (all right, the IRIX proc PMDA is probably the only place this was ever used aside from the sample PMDA). Other uses are probably more benign as the size of the instance domain in the profile is driven by configuration files or interactive user input, so legitimate long lists are less likely. So when I enforce a limit, clients will see PM_ERR_IPC if the profile is too large ... so anyone want to guess at a safe value for instances_len? If profile_len is limited to 1024 as above then for all practical purposes the largest profile would be 4*1024*N bytes if instances_len was constrained to be no larger than N. From nathans@aconex.com Tue Mar 16 21:45:28 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2H2jSjY233674 for ; Tue, 16 Mar 2010 21:45:28 -0500 X-ASG-Debug-ID: 1268794022-5bdc03b90000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 7A3CC251F11 for ; Tue, 16 Mar 2010 19:47:02 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id sYhdoiUguDmCtHrH for ; Tue, 16 Mar 2010 19:47:02 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 64BF765CECA for ; Wed, 17 Mar 2010 13:47:01 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id zhLrp2sVsw0J4LT9 for ; Wed, 17 Mar 2010 13:47:01 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 515EBA50280 for ; Wed, 17 Mar 2010 13:44:15 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 3A3204884CE for ; Wed, 17 Mar 2010 13:47:01 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5UudPCh72F20 for ; Wed, 17 Mar 2010 13:46:57 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 231774884CC for ; Wed, 17 Mar 2010 13:46:57 +1100 (EST) Date: Wed, 17 Mar 2010 13:46:57 +1100 (EST) From: Nathan Scott To: pcp Message-ID: <1990789702.1294001268794017033.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcp updates Subject: pcp updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - FF3.0 (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1268794024 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.25069 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Changes committed to git://oss.sgi.com/nathans/pcp.git src/pmdas/windows/fetch.c | 13 +++++++++++-- src/pmdas/windows/hypnotoad.h | 4 ++-- src/pmdas/windows/instance.c | 15 +++++++++------ src/pmdas/windows/open.c | 7 +++++++ src/pmdas/windows/pmda.c | 18 +++++++++--------- 5 files changed, 38 insertions(+), 19 deletions(-) commit b049d53f3a3d890ba80a51ee04558167e0c43324 Author: Nathan Scott Date: Wed Mar 17 13:45:53 2010 +1100 Improvements to the indom caching for Windows PMDA. We were flushing out the instance domains too frequently in some cases, and not at all in the case where a fetch request causes the instance domain to be updated. From nathans@aconex.com Sun Mar 21 19:49:05 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2M0n4Ts204726 for ; Sun, 21 Mar 2010 19:49:05 -0500 X-ASG-Debug-ID: 1269219035-2c9f01440000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id EC611265DF9 for ; Sun, 21 Mar 2010 17:50:36 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id gjJcFVVJQksITZKk for ; Sun, 21 Mar 2010 17:50:36 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 23C9E3A70B1 for ; Mon, 22 Mar 2010 11:50:32 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id ZxyDZ8i2i9eY1ufg for ; Mon, 22 Mar 2010 11:50:32 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 70C5EA5010C for ; Mon, 22 Mar 2010 11:47:43 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 056324884FE for ; Mon, 22 Mar 2010 11:50:32 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wHZm4KVv04VR for ; Mon, 22 Mar 2010 11:50:28 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id F350C4884FB for ; Mon, 22 Mar 2010 11:50:27 +1100 (EST) Date: Mon, 22 Mar 2010 11:50:27 +1100 (EST) From: Nathan Scott To: pcp Message-ID: <172631019.13421269219027936.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcp updates Subject: pcp updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [220.239.217.12] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - SAF3 (Mac)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1269219043 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.25502 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Changes committed to git://oss.sgi.com/nathans/pcp.git src/pmdas/mmv/mmv.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) commit 8d3a87671b6faca0f43e876f979c8049469b232f Author: Nathan Scott Date: Mon Mar 22 11:45:31 2010 +1100 Differentiate between PM_ERR_INST and PM_ERR_PMID in pmdammv. The return code from the fetch callback was being unilaterally set to PM_ERR_PMID in pmdammv, if its just an instance missing we can now tell (and thats less of an issue). Parfait writes such mmv(4) files, sometimes; checking with Cowan whether that is expected behaviour there or not (not ideal obviously but it may be unavoidable). From wwwrun@oss.sgi.com Sun Mar 21 23:03:34 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2M43Y8J215315 for ; Sun, 21 Mar 2010 23:03:34 -0500 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id o2M43YMb215314; Sun, 21 Mar 2010 23:03:34 -0500 Date: Sun, 21 Mar 2010 23:03:34 -0500 Message-Id: <201003220403.o2M43YMb215314@oss.sgi.com> From: bugzilla-daemon@oss.sgi.com To: pcp@oss.sgi.com Subject: [Bug 869] Add details on ipc facilities to linux PMDA X-Bugzilla-Reason: CC X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: pcp X-Bugzilla-Component: pcp X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: nathans@debian.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P5 X-Bugzilla-Assigned-To: mort@sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: CC In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=869 Nathan Scott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nathans@debian.org --- Comment #1 from Nathan Scott 2010-03-21 23:03:33 CST --- > This can be seen via "ipcs -s". > I'm not sure what the backing source of the information is. Its extracted from the kernel using the semctl(2), shmctl(2) and msgctl(2) syscalls, using the IPC_STAT and IPC_INFO command arguments. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. From daw@sgi.com Tue Mar 23 11:24:50 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2NGOoAL135867 for ; Tue, 23 Mar 2010 11:24:50 -0500 Received: from zion.americas.sgi.com (zion.americas.sgi.com [128.162.236.17]) by relay2.corp.sgi.com (Postfix) with ESMTP id 21880304043 for ; Tue, 23 Mar 2010 09:26:29 -0700 (PDT) Received: (from daw@localhost) by zion.americas.sgi.com (8.12.9/ASC-news-1.4) id o2NGQSO134414995 for pcp@oss.sgi.com; Tue, 23 Mar 2010 11:26:28 -0500 (CDT) Message-Id: <201003231626.o2NGQSO134414995@zion.americas.sgi.com> Subject: build problem To: pcp@oss.sgi.com Date: Tue, 23 Mar 2010 11:26:28 -0500 (CDT) From: David Wright X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Hello, Grabbed pcp-gui 1.4.6 and tried to build getting this> Its on sles11 x86. What am I missing. thanks, Dave /usr/lib/qt3/bin/qmake && /usr/bin/gmake -f Makefile g++ -c -pipe -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -DUSE_LIB64_PATHES -fno-strict-aliasing -Wall -W -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -DUSE_LIB64_PATHES -fno-strict-aliasing -DQT_NO_DEBUG -DQT_SHARED -DQT_TABLET_SUPPORT -DQT_THREAD_SUPPORT -I/usr/lib/qt3/mkspecs/default -I. -I/usr/include -I/usr/lib/qt3/include -o qmc_context.o qmc_context.cpp In file included from qmc_context.h:15, from qmc_context.cpp:11: ./qmc_indom.h: In member function b ./qmc_indom.h:62: error: b ./qmc_indom.h: In member function b ./qmc_indom.h:67: error: b ./qmc_indom.h: In member function b ./qmc_indom.h:70: error: no match for b ./qmc_indom.h: In member function b ./qmc_indom.h:73: error: no match for b From nathans@aconex.com Tue Mar 23 16:27:36 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2NLRZGh157151 for ; Tue, 23 Mar 2010 16:27:36 -0500 X-ASG-Debug-ID: 1269379753-2f7b01510000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id AD277145A84F for ; Tue, 23 Mar 2010 14:29:14 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id i9v6XxMAtzUpDSo9 for ; Tue, 23 Mar 2010 14:29:14 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id C9EA53BD881; Wed, 24 Mar 2010 08:29:12 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id paNbNSonETe0yvzT; Wed, 24 Mar 2010 08:29:12 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 23C36A50280; Wed, 24 Mar 2010 08:26:23 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id A70DD488506; Wed, 24 Mar 2010 08:29:12 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AlEDR96JN7CZ; Wed, 24 Mar 2010 08:29:07 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id E529D48802D; Wed, 24 Mar 2010 08:29:07 +1100 (EST) Date: Wed, 24 Mar 2010 08:29:07 +1100 (EST) From: Nathan Scott To: David Wright Cc: pcp@oss.sgi.com Message-ID: <609099490.80401269379747740.JavaMail.root@mail-au.aconex.com> In-Reply-To: <201003231626.o2NGQSO134414995@zion.americas.sgi.com> X-ASG-Orig-Subj: Re: [pcp] build problem Subject: Re: [pcp] build problem MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [220.239.217.12] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - SAF3 (Mac)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1269379756 X-Barracuda-Bayes: INNOCENT GLOBAL 0.1278 1.0000 -1.2286 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.23 X-Barracuda-Spam-Status: No, SCORE=-1.23 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.25664 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ----- "David Wright" wrote: > Hello, > > Grabbed pcp-gui 1.4.6 and tried to build getting this> Its on sles11 > x86. What am I missing. > thanks, Dave > > /usr/lib/qt3/bin/qmake && /usr/bin/gmake -f Makefile Looks like you're building with Qt3 - Qt4.3 or later is required. I need to tweak the configure script to fail early in this case. cheers. -- Nathan From nathans@aconex.com Tue Mar 23 17:46:43 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX, URIBL_BLACK autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2NMkg4r162359 for ; Tue, 23 Mar 2010 17:46:43 -0500 X-ASG-Debug-ID: 1269384502-2ee703660000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 02689145ABE8 for ; Tue, 23 Mar 2010 15:48:22 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id 2BBBRZNxxbeSvJq7 for ; Tue, 23 Mar 2010 15:48:22 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 451E53C3432 for ; Wed, 24 Mar 2010 09:48:21 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id lWtzWDoeJ90crdgN for ; Wed, 24 Mar 2010 09:48:21 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 8E4AFA50280 for ; Wed, 24 Mar 2010 09:45:31 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 2891A48850C for ; Wed, 24 Mar 2010 09:48:21 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kQHzRXHmCdFb for ; Wed, 24 Mar 2010 09:48:17 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 491A848850A for ; Wed, 24 Mar 2010 09:48:17 +1100 (EST) Date: Wed, 24 Mar 2010 09:48:17 +1100 (EST) From: Nathan Scott To: pcp Message-ID: <1131630322.84541269384497180.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcp-gui updates Subject: pcp-gui updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [220.239.217.12] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - SAF3 (Mac)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1269384503 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0187 1.0000 -1.8994 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.90 X-Barracuda-Spam-Status: No, SCORE=-1.90 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.25670 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Changes committed to git://oss.sgi.com/nathans/pcp-gui.git aclocal.m4 | 29 +++++++++++++++++++++++++++-- configure.in | 20 +++++++------------- m4/package_qtdev.m4 | 25 +++++++++++++++++++++++++ 3 files changed, 59 insertions(+), 15 deletions(-) commit 618efceffddc14ff575273741e572d8f2df6bdbe Author: Nathan Scott Date: Wed Mar 24 09:47:02 2010 +1100 Add a configure check on the installed Qt version. From wwwrun@oss.sgi.com Wed Mar 24 09:22:54 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2OEMsEf257101 for ; Wed, 24 Mar 2010 09:22:54 -0500 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id o2OEMsCK257100; Wed, 24 Mar 2010 09:22:54 -0500 Date: Wed, 24 Mar 2010 09:22:54 -0500 From: bugzilla-daemon@oss.sgi.com To: pcp@oss.sgi.com Subject: [Bug 875] New: Modify cache_clean and create mmaped X-Bugzilla-Reason: CC X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: pcp X-Bugzilla-Component: pcp X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: daw@sgi.com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P5 X-Bugzilla-Assigned-To: mort@sgi.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=875 Summary: Modify cache_clean and create mmaped Product: pcp Version: unspecified Platform: All OS/Version: Linux Status: NEW Severity: enhancement Priority: P5 Component: pcp AssignedTo: mort@sgi.com ReportedBy: daw@sgi.com CC: pcp@oss.sgi.com Estimated Hours: 0.0 Classification: Unclassified Now that the sles11sp1 kernel has shmem in it, and PCP is now tracking it, I'd like to see it taken out of cache_clean and Mapped so it can be in a memory utilization chart without being counted 3 times. I had cache_clean added years ago which is cached-writeback-dirty. shmem is also counted in Mapped. I know one can get derived metrics but these would be common and maybe changes or another memory view that breaks out cached and other in more detail. Changes to pmda.c I want a mem util chart where the new meminfo Shmem is broken out. -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. From cboac@sgi.com Wed Mar 24 11:48:47 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: *** X-Spam-Status: No, score=3.6 required=5.0 tests=BAYES_00,FH_DATE_PAST_20XX, HTML_MESSAGE autolearn=no version=3.3.0-rupdated Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2OGmkAH010479 for ; Wed, 24 Mar 2010 11:48:47 -0500 Received: from [128.162.233.12] (lnx-cboac.americas.sgi.com [128.162.233.12]) by relay1.corp.sgi.com (Postfix) with ESMTP id D880C8F8039 for ; Wed, 24 Mar 2010 09:50:25 -0700 (PDT) Message-ID: <4BAA42D1.4020507@sgi.com> Date: Wed, 24 Mar 2010 11:50:25 -0500 From: Corneliu Boac User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100228 SUSE/3.0.3-1.1.1 Thunderbird/3.0.3 MIME-Version: 1.0 To: pcp@oss.sgi.com Subject: How should we approach the loading of the IB pmda as a LOCAL context DSO? Content-Type: multipart/alternative; boundary="------------000005090603070602060003" X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean This is a multi-part message in MIME format. --------------000005090603070602060003 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hello PCP group: I have ran into a PCP bug: the cluster pmda failed to load the ib pmda dso. How should we approach the loading of the IB pmda as a LOCAL context DSO? Should we just permanently add it to the dsotab like in the following patch, or should we rethink the dsotab and allow it to grow dynamically via a new API? =========================================================================== diff -uprBw pcp-3.1.1.sgi.orig/src/libpcp/src/GNUmakefile pcp-3.1.1.sgi/src/libpcp/src/GNUmakefile --- pcp-3.1.1.sgi.orig/src/libpcp/src/GNUmakefile 2010-02-25 15:07:18.000000000 -0600 +++ pcp-3.1.1.sgi/src/libpcp/src/GNUmakefile 2010-03-24 09:47:08.000000000 -0500 @@ -91,11 +91,8 @@ else kernel_pmda_dso = $(TARGET_OS) endif -ifeq ($(HAVE_IBDEV),1) +# the pmdacluster needs the ib entry into the dsotab (even if HAVE_IBDEV is not defined by default) infiniband_pmda_dso = ib -else -infiniband_pmda_dso = -endif dsotbl.h: $(TOPDIR)/src/pmns/stdpmid echo '/* This file is automatically generated by build' > $@ =========================================================================== After I apply this patch the libpcp/src/dsotbl.h looks like this: --------------------------------------------------------------------------- /* This file is automatically generated by build * * It contains list of DSO, supported by the CONTEXT_LOCAL */ static __pmDSO dsotab[] = { #define LINUX_DSO 60 { 60, "linux/pmda_linux.so", "linux_init" }, #define IB_DSO 91 { 91, "ib/pmda_ib.so", "ib_init" }, #define MMV_DSO 70 { 70, "mmv/pmda_mmv.so", "mmv_init" }, #define SAMPLE_DSO 30 { 30, "sample/pmda_sample.so", "sample_init" }, }; static int numdso = (sizeof(dsotab)/sizeof(dsotab[0])); --------------------------------------------------------------------------- Thank you, Cornel -- Corneliu Boac - Software Engineer Silicon Graphics International 2750 Blue Water Road Eagan, MN 55121 Phone: (651)683-7900 E-mail: cboac@sgi.com --------------000005090603070602060003 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit 
Hello PCP group:

I have ran into a PCP bug: the cluster pmda failed to load the ib pmda dso.
How should we approach the loading of the IB pmda as a LOCAL context DSO?
Should we just permanently add it to the dsotab like in the following patch,
or should we rethink the dsotab and allow it to grow dynamically via a new API?

===========================================================================
diff -uprBw pcp-3.1.1.sgi.orig/src/libpcp/src/GNUmakefile pcp-3.1.1.sgi/src/libpcp/src/GNUmakefile
--- pcp-3.1.1.sgi.orig/src/libpcp/src/GNUmakefile	2010-02-25 15:07:18.000000000 -0600
+++ pcp-3.1.1.sgi/src/libpcp/src/GNUmakefile	2010-03-24 09:47:08.000000000 -0500
@@ -91,11 +91,8 @@ else
 kernel_pmda_dso	= $(TARGET_OS)
 endif
 
-ifeq ($(HAVE_IBDEV),1)
+# the pmdacluster needs the ib entry into the dsotab (even if HAVE_IBDEV is not defined by default)
 infiniband_pmda_dso = ib
-else
-infiniband_pmda_dso =
-endif
 
 dsotbl.h:	$(TOPDIR)/src/pmns/stdpmid 
 	echo '/* This file is automatically generated by build' > $@
===========================================================================



After I apply this patch the libpcp/src/dsotbl.h looks like this:
---------------------------------------------------------------------------
/* This file is automatically generated by build
 *
 * It contains list of DSO, supported by the CONTEXT_LOCAL
 */
static __pmDSO dsotab[] = {
#define  LINUX_DSO 60
	{ 60, "linux/pmda_linux.so", "linux_init" },
#define  IB_DSO 91
	{ 91, "ib/pmda_ib.so", "ib_init" },
#define  MMV_DSO 70
	{ 70, "mmv/pmda_mmv.so", "mmv_init" },
#define  SAMPLE_DSO 30
	{ 30, "sample/pmda_sample.so", "sample_init" },
};
static int	numdso = (sizeof(dsotab)/sizeof(dsotab[0]));
---------------------------------------------------------------------------


Thank you,
Cornel
-- 
Corneliu Boac - Software Engineer
Silicon Graphics International
2750 Blue Water Road
Eagan, MN 55121
Phone: (651)683-7900
E-mail: cboac@sgi.com
--------------000005090603070602060003-- From kenj@internode.on.net Wed Mar 24 15:15:58 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2OKFv2K028910 for ; Wed, 24 Mar 2010 15:15:58 -0500 X-ASG-Debug-ID: 1269461856-3f7f023c0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id EDA8B1460B86 for ; Wed, 24 Mar 2010 13:17:37 -0700 (PDT) Received: from mail.internode.on.net (bld-mail14.adl6.internode.on.net [150.101.137.99]) by cuda.sgi.com with ESMTP id lrDqqpGyDoBTHUBg for ; Wed, 24 Mar 2010 13:17:37 -0700 (PDT) Received: from [192.168.1.100] (unverified [118.209.40.21]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 18444065-1927428 for multiple; Thu, 25 Mar 2010 06:47:34 +1030 (CDT) X-ASG-Orig-Subj: Re: [pcp] How should we approach the loading of the IB pmda as a LOCAL context DSO? Subject: Re: [pcp] How should we approach the loading of the IB pmda as a LOCAL context DSO? From: Ken McDonell Reply-To: kenj@internode.on.net To: Corneliu Boac Cc: pcp@oss.sgi.com In-Reply-To: <4BAA42D1.4020507@sgi.com> References: <4BAA42D1.4020507@sgi.com> Content-Type: text/plain; charset="UTF-8" Date: Thu, 25 Mar 2010 07:17:27 +1100 Message-ID: <1269461847.16867.25.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail14.adl6.internode.on.net[150.101.137.99] X-Barracuda-Start-Time: 1269461858 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.25749 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean OK, there are several points here ... 1. this looks like an unintended fallout from moving the IB and cluster PMDAs out of the main PCP build ... HAVE_IBDEV never gets set in the PCP tree, nor indeed in the pcp-pmda-infinband tree. 2. I don't understand the "cluster pmda failed to load the ib pmda dso" part ... there should not be any nested dependency like this in the pmdas ... it is possible the cluster pmda cannot fetch the ib metrics if they appear in the cluster pmda's config file, but that is not likely to be related to anything involving PM_CONTEXT_LOCAL ... Mark, please jump in here if I've got this wrong. 3. PM_CONTEXT_LOCAL is a complete hack. It was "invented" before the first release of PCP when one of the hurdles I needed to clear was a demonstrable proof to Akmal Khan (my boss at the time) that using PCP would not impose a horrific penalty in comparison to sar and/or vmstat ... to do this we needed to take the context switches and TCP/IP stack out of the picture, so the client app did not talk to pmcd. So PM_CONTEXT_LOCAL was invented to support only the IRIX PMDA ... support for the sample PMDA was added later to help QA, but you don't want to start the sample PMDA in production every time a new PM_CONTEXT_LOCAL context is started, so the global "don't do it unless this magic environment variable is set" hack was added on top and we end up with tests for $PCP_LITE_SAMPLE (old style) and $PMDA_LOCAL_SAMPLE (new style) and $PMDA_LOCAL_PROC (IRIX only) and $PMDA_LOCAL_IB and ... . Everything that exists today in this area is built on this dodgey foundation. Now I'd prefer to see PM_CONTEXT_LOCAL die. I think Nathan has some real world cases where it is useful to be able to collect performance data on a specific host without needing infrastructure and sys admin cycles to ensure pmcd keeps running. So if we are to keep PM_CONTEXT_LOCAL, then I support Corneliu's suggestion that we should define new API support to add entries to dsotbl[] at run-time ... but how would this work with something like pminfo, where the metrics are arbitrary and the PCP client does not really know _which_ PMDAs need to be loaded into the local context? I think we need some design by argument here. On Wed, 2010-03-24 at 11:50 -0500, Corneliu Boac wrote: > Hello PCP group: > > I have ran into a PCP bug: the cluster pmda failed to load the ib pmda dso. > How should we approach the loading of the IB pmda as a LOCAL context DSO? > Should we just permanently add it to the dsotab like in the following patch, > or should we rethink the dsotab and allow it to grow dynamically via a new API? > =========================================================================== > diff -uprBw pcp-3.1.1.sgi.orig/src/libpcp/src/GNUmakefile pcp-3.1.1.sgi/src/libpcp/src/GNUmakefile > --- pcp-3.1.1.sgi.orig/src/libpcp/src/GNUmakefile 2010-02-25 15:07:18.000000000 -0600 > +++ pcp-3.1.1.sgi/src/libpcp/src/GNUmakefile 2010-03-24 09:47:08.000000000 -0500 > @@ -91,11 +91,8 @@ else > kernel_pmda_dso = $(TARGET_OS) > endif > > -ifeq ($(HAVE_IBDEV),1) > +# the pmdacluster needs the ib entry into the dsotab (even if HAVE_IBDEV is not defined by default) > infiniband_pmda_dso = ib > -else > -infiniband_pmda_dso = > -endif > > dsotbl.h: $(TOPDIR)/src/pmns/stdpmid > echo '/* This file is automatically generated by build' > $@ > =========================================================================== > > > After I apply this patch the libpcp/src/dsotbl.h looks like this: > --------------------------------------------------------------------------- > /* This file is automatically generated by build > * > * It contains list of DSO, supported by the CONTEXT_LOCAL > */ > static __pmDSO dsotab[] = { > #define LINUX_DSO 60 > { 60, "linux/pmda_linux.so", "linux_init" }, > #define IB_DSO 91 > { 91, "ib/pmda_ib.so", "ib_init" }, > #define MMV_DSO 70 > { 70, "mmv/pmda_mmv.so", "mmv_init" }, > #define SAMPLE_DSO 30 > { 30, "sample/pmda_sample.so", "sample_init" }, > }; > static int numdso = (sizeof(dsotab)/sizeof(dsotab[0])); > --------------------------------------------------------------------------- > > > Thank you, > Cornel > -- > Corneliu Boac - Software Engineer > Silicon Graphics International > 2750 Blue Water Road > Eagan, MN 55121 > Phone: (651)683-7900 > E-mail: cboac@sgi.com > > _______________________________________________ > pcp mailing list > pcp@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/pcp > From mort@bork.org Wed Mar 24 16:37:16 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX,J_CHICKENPOX_62 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2OLbFlX035056 for ; Wed, 24 Mar 2010 16:37:16 -0500 X-ASG-Debug-ID: 1269466736-263a02d80000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from darwin.bork.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 90FC3274117 for ; Wed, 24 Mar 2010 14:38:56 -0700 (PDT) Received: from darwin.bork.org (darwin.bork.org [65.49.60.145]) by cuda.sgi.com with ESMTP id j4rAibw329P6flPO for ; Wed, 24 Mar 2010 14:38:56 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by darwin.bork.org (Postfix) with ESMTP id 2D13619326; Wed, 24 Mar 2010 17:34:26 -0400 (EDT) Received: from darwin.bork.org ([127.0.0.1]) by localhost (darwin.bork.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3KJipAe4VDW9; Wed, 24 Mar 2010 17:34:26 -0400 (EDT) Received: from socrates.bork.org (localhost [127.0.0.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "socrates.bork.org", Issuer "Bork Consulting CA" (not verified)) by darwin.bork.org (Postfix) with ESMTPS id D50D819232; Wed, 24 Mar 2010 17:34:25 -0400 (EDT) Received: by socrates.bork.org (Postfix, from userid 1000) id C586ECBB22; Wed, 24 Mar 2010 17:38:54 -0400 (EDT) Date: Wed, 24 Mar 2010 17:38:54 -0400 From: Martin Hicks To: Ken McDonell Cc: Corneliu Boac , pcp@oss.sgi.com X-ASG-Orig-Subj: Re: [pcp] How should we approach the loading of the IB pmda as a LOCAL context DSO? Subject: Re: [pcp] How should we approach the loading of the IB pmda as a LOCAL context DSO? Message-ID: <20100324213853.GG3247@socrates.bork.org> References: <4BAA42D1.4020507@sgi.com> <1269461847.16867.25.camel@bozo.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1269461847.16867.25.camel@bozo.localdomain> User-Agent: Mutt/1.5.20 (2009-06-14) X-Barracuda-Connect: darwin.bork.org[65.49.60.145] X-Barracuda-Start-Time: 1269466737 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.25754 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Thu, Mar 25, 2010 at 07:17:27AM +1100, Ken McDonell wrote: > OK, there are several points here ... > > 1. this looks like an unintended fallout from moving the IB and cluster > PMDAs out of the main PCP build ... HAVE_IBDEV never gets set in the PCP > tree, nor indeed in the pcp-pmda-infinband tree. Correct. I failed to test this properly. > 2. I don't understand the "cluster pmda failed to load the ib pmda dso" > part ... there should not be any nested dependency like this in the > pmdas ... it is possible the cluster pmda cannot fetch the ib metrics if > they appear in the cluster pmda's config file, but that is not likely to > be related to anything involving PM_CONTEXT_LOCAL ... Mark, please jump > in here if I've got this wrong. The cluster PMDA client (pmclusterd) uses PM_CONTEXT_LOCAL to load the linux and ib .so's in order to collect and push the metrics to the server PMDA without running the full PMCD process. Unfortunately, the support needs to be in libpcp.so in order for LOCAL contexts to work. > > 3. PM_CONTEXT_LOCAL is a complete hack. It was "invented" before the I knew that it was a hack. Thanks for the history lesson... > Now I'd prefer to see PM_CONTEXT_LOCAL die. > > I think Nathan has some real world cases where it is useful to be able > to collect performance data on a specific host without needing > infrastructure and sys admin cycles to ensure pmcd keeps running. > > So if we are to keep PM_CONTEXT_LOCAL, then I support Corneliu's > suggestion that we should define new API support to add entries to > dsotbl[] at run-time ... but how would this work with something like > pminfo, where the metrics are arbitrary and the PCP client does not > really know _which_ PMDAs need to be loaded into the local context? > > I think we need some design by argument here. I pushed Cornel to make this post as a way to introduce himself to the community. I know this isn't exactly a gentle introduction into the world of PCP :) I honestly hadn't thought much further than a case like the cluster PMDA that (ab)uses the LOCAL context in order to collect metrics from pre-definied PMDAs.. Maybe LOCAL is a hack and we should not try to design for the general case PMAPI application (like pminfo). Can we just limit it to a special case, where the PMAPI client is smart enough to know in advance which PMDAs it needs to load via the yet-to-be-designed dsotbl[] API? mh > > On Wed, 2010-03-24 at 11:50 -0500, Corneliu Boac wrote: > > Hello PCP group: > > > > I have ran into a PCP bug: the cluster pmda failed to load the ib pmda dso. > > How should we approach the loading of the IB pmda as a LOCAL context DSO? > > Should we just permanently add it to the dsotab like in the following patch, > > or should we rethink the dsotab and allow it to grow dynamically via a new API? > > =========================================================================== > > diff -uprBw pcp-3.1.1.sgi.orig/src/libpcp/src/GNUmakefile pcp-3.1.1.sgi/src/libpcp/src/GNUmakefile > > --- pcp-3.1.1.sgi.orig/src/libpcp/src/GNUmakefile 2010-02-25 15:07:18.000000000 -0600 > > +++ pcp-3.1.1.sgi/src/libpcp/src/GNUmakefile 2010-03-24 09:47:08.000000000 -0500 > > @@ -91,11 +91,8 @@ else > > kernel_pmda_dso = $(TARGET_OS) > > endif > > > > -ifeq ($(HAVE_IBDEV),1) > > +# the pmdacluster needs the ib entry into the dsotab (even if HAVE_IBDEV is not defined by default) > > infiniband_pmda_dso = ib > > -else > > -infiniband_pmda_dso = > > -endif > > > > dsotbl.h: $(TOPDIR)/src/pmns/stdpmid > > echo '/* This file is automatically generated by build' > $@ > > =========================================================================== > > > > > > After I apply this patch the libpcp/src/dsotbl.h looks like this: > > --------------------------------------------------------------------------- > > /* This file is automatically generated by build > > * > > * It contains list of DSO, supported by the CONTEXT_LOCAL > > */ > > static __pmDSO dsotab[] = { > > #define LINUX_DSO 60 > > { 60, "linux/pmda_linux.so", "linux_init" }, > > #define IB_DSO 91 > > { 91, "ib/pmda_ib.so", "ib_init" }, > > #define MMV_DSO 70 > > { 70, "mmv/pmda_mmv.so", "mmv_init" }, > > #define SAMPLE_DSO 30 > > { 30, "sample/pmda_sample.so", "sample_init" }, > > }; > > static int numdso = (sizeof(dsotab)/sizeof(dsotab[0])); > > --------------------------------------------------------------------------- > > > > > > Thank you, > > Cornel > > -- > > Corneliu Boac - Software Engineer > > Silicon Graphics International > > 2750 Blue Water Road > > Eagan, MN 55121 > > Phone: (651)683-7900 > > E-mail: cboac@sgi.com > > > > _______________________________________________ > > pcp mailing list > > pcp@oss.sgi.com > > http://oss.sgi.com/mailman/listinfo/pcp > > > > > _______________________________________________ > pcp mailing list > pcp@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/pcp From makc@iinet.net.au Thu Mar 25 19:50:15 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2Q0oEmh175701 for ; Thu, 25 Mar 2010 19:50:15 -0500 X-ASG-Debug-ID: 1269564711-070b02350000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from outbound.icp-qv1-irony-out5.iinet.net.au (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 21E48146935A for ; Thu, 25 Mar 2010 17:51:51 -0700 (PDT) Received: from outbound.icp-qv1-irony-out5.iinet.net.au (outbound.icp-qv1-irony-out5.iinet.net.au [203.59.1.105]) by cuda.sgi.com with ESMTP id XOkrMqV9vEYXPxTt for ; Thu, 25 Mar 2010 17:51:51 -0700 (PDT) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEANOhq0vL2Rwk/2dsb2JhbACbKnO+M4R9BA X-IronPort-AV: E=Sophos;i="4.51,310,1267372800"; d="scan'208";a="120397814" Received: from unknown (HELO alma.crabbed.net) ([203.217.28.36]) by outbound.icp-qv1-irony-out5.iinet.net.au with ESMTP; 26 Mar 2010 08:51:47 +0800 Received: by alma.crabbed.net (Postfix, from userid 501) id 63864E4D5A; Fri, 26 Mar 2010 11:51:46 +1100 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19372.1314.39706.68697@iinet.net.au> Date: Fri, 26 Mar 2010 11:51:46 +1100 From: Max Matveev To: pcp@oss.sgi.com X-ASG-Orig-Subj: PMID domain number for new pmda Subject: PMID domain number for new pmda X-Mailer: VM 7.17 under 21.4 (patch 19) "Constant Variable" XEmacs Lucid X-Barracuda-Connect: outbound.icp-qv1-irony-out5.iinet.net.au[203.59.1.105] X-Barracuda-Start-Time: 1269564717 X-Barracuda-Bayes: INNOCENT GLOBAL 0.1881 1.0000 -0.8913 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -0.89 X-Barracuda-Spam-Status: No, SCORE=-0.89 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.25854 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean We're developing IPMI pmda internally which may or may not ever see the light of the open-source world. I'd like to use an officially assigned domain number to avoid archive problems in the future. What's the protocol for getting a domain for not-yet-ready pmdas? Martin, IIRC SGI has had plans to write IPMI pmda in the past. Do you know if something has happen in this area? max From nathans@aconex.com Thu Mar 25 22:45:24 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2Q3jN84187475 for ; Thu, 25 Mar 2010 22:45:24 -0500 X-ASG-Debug-ID: 1269575224-40af00780000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 25FA91469A18 for ; Thu, 25 Mar 2010 20:47:04 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id DAI9xfnfQTRkhkBD for ; Thu, 25 Mar 2010 20:47:04 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id D09E73D81BA; Fri, 26 Mar 2010 14:47:01 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id 3dRsold0VvZ5iBaN; Fri, 26 Mar 2010 14:47:01 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id D9F0DA50110; Fri, 26 Mar 2010 14:44:10 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id B1C7E48850D; Fri, 26 Mar 2010 14:47:01 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f8R5ZsZi7ZPL; Fri, 26 Mar 2010 14:46:57 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 059A4488523; Fri, 26 Mar 2010 14:46:57 +1100 (EST) Date: Fri, 26 Mar 2010 14:46:56 +1100 (EST) From: Nathan Scott To: Max Matveev Cc: pcp@oss.sgi.com Message-ID: <1724963650.166991269575216829.JavaMail.root@mail-au.aconex.com> In-Reply-To: <19372.1314.39706.68697@iinet.net.au> X-ASG-Orig-Subj: Re: [pcp] PMID domain number for new pmda Subject: Re: [pcp] PMID domain number for new pmda MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - FF3.0 (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1269575226 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0001 1.0000 -2.0201 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.25864 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ----- "Max Matveev" wrote: > We're developing IPMI pmda internally which may or may not ever see > the light of the open-source world. I'd like to use an officially > assigned domain number to avoid archive problems in the future. > What's the protocol for getting a domain for not-yet-ready pmdas? Send a patch, marking it reserved (with IPMI keyword). I looked at doing an IPMI PMDA awhile back, are you planning on using the openipmi library? (is this on Linux?) I got side-tracked though, but if you send code I'll happily review & we might use it here too. > Martin, IIRC SGI has had plans to write IPMI pmda in the past. Do you > know if something has happen in this area? cheers. -- Nathan From kenj@internode.on.net Fri Mar 26 04:28:55 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=AWL,BAYES_00, DATE_IN_PAST_06_12,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2Q9StM0219559 for ; Fri, 26 Mar 2010 04:28:55 -0500 X-ASG-Debug-ID: 1269595835-25f100860000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id B5CEE27A142 for ; Fri, 26 Mar 2010 02:30:36 -0700 (PDT) Received: from mail.internode.on.net (bld-mail17.adl2.internode.on.net [150.101.137.102]) by cuda.sgi.com with ESMTP id 4RLSnMYfPv1dEAW3 for ; Fri, 26 Mar 2010 02:30:36 -0700 (PDT) Received: from [192.168.1.100] (unverified [118.209.40.21]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 18289715-1927428 for multiple; Fri, 26 Mar 2010 20:00:33 +1030 (CDT) X-ASG-Orig-Subj: Re: [pcp] PMID domain number for new pmda Subject: Re: [pcp] PMID domain number for new pmda From: Ken McDonell Reply-To: kenj@internode.on.net To: Max Matveev Cc: pcp@oss.sgi.com In-Reply-To: <19372.1314.39706.68697@iinet.net.au> References: <19372.1314.39706.68697@iinet.net.au> Content-Type: text/plain; charset="UTF-8" Date: Fri, 26 Mar 2010 13:43:27 +1100 Message-ID: <1269571407.31800.3.camel@bozo-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail17.adl2.internode.on.net[150.101.137.102] X-Barracuda-Start-Time: 1269595837 X-Barracuda-Bayes: INNOCENT GLOBAL 0.3441 1.0000 -0.1738 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: 0.94 X-Barracuda-Spam-Status: No, SCORE=0.94 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=DATE_IN_PAST_06_12, DATE_IN_PAST_06_12_2 X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.25884 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 DATE_IN_PAST_06_12 Date: is 6 to 12 hours before Received: date 1.10 DATE_IN_PAST_06_12_2 DATE_IN_PAST_06_12_2 X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean I think the number of PMDA developers is still sufficiently small ... 8^)> ... so we don't need a heavy protocol, and I'd suggest submitting a patch to the list and it shall be so. On Fri, 2010-03-26 at 11:51 +1100, Max Matveev wrote: > We're developing IPMI pmda internally which may or may not ever see > the light of the open-source world. I'd like to use an officially > assigned domain number to avoid archive problems in the future. What's > the protocol for getting a domain for not-yet-ready pmdas? > > Martin, IIRC SGI has had plans to write IPMI pmda in the past. Do you > know if something has happen in this area? > > max > > _______________________________________________ > pcp mailing list > pcp@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/pcp From mort@bork.org Fri Mar 26 07:30:29 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2QCUScc235036 for ; Fri, 26 Mar 2010 07:30:29 -0500 X-ASG-Debug-ID: 1269606730-334801440000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from darwin.bork.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 16BC915303D8 for ; Fri, 26 Mar 2010 05:32:10 -0700 (PDT) Received: from darwin.bork.org (darwin.bork.org [65.49.60.145]) by cuda.sgi.com with ESMTP id PmT6CMMBGmjJ9S2C for ; Fri, 26 Mar 2010 05:32:10 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by darwin.bork.org (Postfix) with ESMTP id C27F8192C8; Fri, 26 Mar 2010 08:27:37 -0400 (EDT) Received: from darwin.bork.org ([127.0.0.1]) by localhost (darwin.bork.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id cgXnuSILyJxF; Fri, 26 Mar 2010 08:27:37 -0400 (EDT) Received: from laplace.bork.org (laplace.bork.org [IPv6:2001:470:1f11:499:21a:a0ff:feec:57ab]) by darwin.bork.org (Postfix) with ESMTP id 6968D192B3; Fri, 26 Mar 2010 08:27:37 -0400 (EDT) Received: by laplace.bork.org (Postfix, from userid 1000) id 0D8E254554; Fri, 26 Mar 2010 08:32:08 -0400 (EDT) Date: Fri, 26 Mar 2010 08:32:08 -0400 From: Martin Hicks To: Ken McDonell Cc: Max Matveev , pcp@oss.sgi.com X-ASG-Orig-Subj: Re: [pcp] PMID domain number for new pmda Subject: Re: [pcp] PMID domain number for new pmda Message-ID: <20100326123208.GD3225@laplace.bork.org> References: <19372.1314.39706.68697@iinet.net.au> <1269571407.31800.3.camel@bozo-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1269571407.31800.3.camel@bozo-laptop> User-Agent: Mutt/1.5.20 (2009-06-14) X-Barracuda-Connect: darwin.bork.org[65.49.60.145] X-Barracuda-Start-Time: 1269606731 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.25893 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Fri, Mar 26, 2010 at 01:43:27PM +1100, Ken McDonell wrote: > I think the number of PMDA developers is still sufficiently small ... > 8^)> ... so we don't need a heavy protocol, and I'd suggest submitting a > patch to the list and it shall be so. Agreed. I've done exactly this in the past. > > On Fri, 2010-03-26 at 11:51 +1100, Max Matveev wrote: > > We're developing IPMI pmda internally which may or may not ever see > > the light of the open-source world. I'd like to use an officially > > assigned domain number to avoid archive problems in the future. What's > > the protocol for getting a domain for not-yet-ready pmdas? > > > > Martin, IIRC SGI has had plans to write IPMI pmda in the past. Do you > > know if something has happen in this area? IPMI in terms of collecting SDR data from remote (or local) hosts? No, we never made our collection mechanism more generic. We're still using our sdr pmda, which just reads data from a file that is updated by another sgi-specific collector daemon. mh -- Martin Hicks || mort@bork.org || PGP/GnuPG: 0x4C7F2BEE From nathans@aconex.com Fri Mar 26 16:22:05 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2QLM5DF015516 for ; Fri, 26 Mar 2010 16:22:05 -0500 X-ASG-Debug-ID: 1269638625-36bf02420000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id DFC111B41C43 for ; Fri, 26 Mar 2010 14:23:45 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id yS9mPOYi6xxOvRoF for ; Fri, 26 Mar 2010 14:23:45 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 3F3AF3DFB17; Sat, 27 Mar 2010 08:23:43 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id uFeS8OlwCjqWpMek; Sat, 27 Mar 2010 08:23:43 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id EA026A50110; Sat, 27 Mar 2010 08:20:51 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 218F748851D; Sat, 27 Mar 2010 08:23:43 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DgQtuI7clDhv; Sat, 27 Mar 2010 08:23:39 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 19C92488518; Sat, 27 Mar 2010 08:23:39 +1100 (EST) Date: Sat, 27 Mar 2010 08:23:38 +1100 (EST) From: nathans@aconex.com Sender: nscott@aconex.com To: kenj@internode.on.net Cc: pcp@oss.sgi.com, Corneliu Boac Message-ID: <214612989.179271269638617963.JavaMail.root@mail-au.aconex.com> In-Reply-To: <1254906689.178971269637761035.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: Re: [pcp] How should we approach the loading of the IB pmda as a LOCAL context DSO? Subject: Re: [pcp] How should we approach the loading of the IB pmda as a LOCAL context DSO? MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [220.237.111.48] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - SAF3 (Mac)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1269638627 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.25927 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Status: Clean ----- "Ken McDonell" wrote: > OK, there are several points here ... > ... > 2. I don't understand the "cluster pmda failed to load the ib pmda > dso" The code in question appears to be here: http://oss.sgi.com/cgi-bin/gitweb.cgi?p=pcp/pcp-pmda-cluster.git;a=blob;f=src/pmclusterd.c;h=c1b0a1d8c7bf60bd686b870255c983df13605216;hb=HEAD around lines 440 - 460 or so. > 3. PM_CONTEXT_LOCAL is a complete hack. It was "invented" before the > first release of PCP when one of the hurdles I needed to clear was a > demonstrable proof to Akmal Khan (my boss at the time) that using PCP > would not impose a horrific penalty in comparison to sar and/or > vmstat ... to do this we needed to take the context switches and > TCP/IP > stack out of the picture, so the client app did not talk to pmcd. So > PM_CONTEXT_LOCAL was invented to support only the IRIX PMDA ... > support > for the sample PMDA was added later to help QA, but you don't want to > start the sample PMDA in production every time a new PM_CONTEXT_LOCAL > context is started, so the global "don't do it unless this magic > environment variable is set" hack was added on top and we end up with > tests for $PCP_LITE_SAMPLE (old style) and $PMDA_LOCAL_SAMPLE (new > style) and $PMDA_LOCAL_PROC (IRIX only) and $PMDA_LOCAL_IB and ... . > Everything that exists today in this area is built on this dodgey > foundation. > > Now I'd prefer to see PM_CONTEXT_LOCAL die. IMO, the local context concept is sound, just the implementation is lacking. There are certainly some situations where it has advantages over pmcd, if all the needed metrics are from known dso PMDAs (e.g. the pmstat class of tool). > I think Nathan has some real world cases where it is useful to be > able > to collect performance data on a specific host without needing > infrastructure and sys admin cycles to ensure pmcd keeps running. Yeah - no need to have the network up (attractive when implementing local-focussed tools like top, vmstat, etc - as an option anyway - pmstat should ideally fallback to local context if no pmcd connection is possible), and as you mentioned - no need to install a system service (root permissions) to try out pcp, the (revised) tutorial could potentially make use of this, or an online pcp demo. Mark mentioned another case specific to the cluster/infiniband PMDA to me the other day, related to scheduling issues (and certainly I remember the pain we had in production on Windows with pmdawindows as a daemon wrt fetch timeouts, which we no longer see wit the dll PMDA). Marks on holiday though, so may be awhile till we hear from him on this. > So if we are to keep PM_CONTEXT_LOCAL, then I support Corneliu's > suggestion that we should define new API support to add entries to > dsotbl[] at run-time ... but how would this work with something like > pminfo, where the metrics are arbitrary and the PCP client does not > really know _which_ PMDAs need to be loaded into the local context? I'd like to see this API cleaned up. We have the unused argument to pmNewContext which could be used to give, perhaps, a comma separated list of dso PMDAs... (pretty sure we audited this a year or two back and checked all callers were passing NULL in this argument atm, if it helps). cheers. -- Nathan From kenj@internode.on.net Fri Mar 26 20:01:01 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2R110Dg029234 for ; Fri, 26 Mar 2010 20:01:01 -0500 X-ASG-Debug-ID: 1269651761-46ba02cf0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id E83FA146FC6E for ; Fri, 26 Mar 2010 18:02:41 -0700 (PDT) Received: from mail.internode.on.net (bld-mail18.adl2.internode.on.net [150.101.137.103]) by cuda.sgi.com with ESMTP id anLSiM8ZnmDXMIxr for ; Fri, 26 Mar 2010 18:02:41 -0700 (PDT) Received: from [192.168.1.100] (unverified [118.209.40.21]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 18489188-1927428 for multiple; Sat, 27 Mar 2010 11:32:35 +1030 (CDT) X-ASG-Orig-Subj: Re: [pcp] How should we approach the loading of the IB pmda as a LOCAL context DSO? Subject: Re: [pcp] How should we approach the loading of the IB pmda as a LOCAL context DSO? From: Ken McDonell Reply-To: kenj@internode.on.net To: nathans@aconex.com Cc: pcp@oss.sgi.com, Corneliu Boac In-Reply-To: <214612989.179271269638617963.JavaMail.root@mail-au.aconex.com> References: <214612989.179271269638617963.JavaMail.root@mail-au.aconex.com> Content-Type: text/plain; charset="UTF-8" Date: Sat, 27 Mar 2010 12:02:26 +1100 Message-ID: <1269651746.2625.26.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail18.adl2.internode.on.net[150.101.137.103] X-Barracuda-Start-Time: 1269651763 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0007 1.0000 -2.0167 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.25940 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Sat, 2010-03-27 at 08:23 +1100, nathans@aconex.com wrote: > ----- "Ken McDonell" wrote: > ... > > So if we are to keep PM_CONTEXT_LOCAL, then I support Corneliu's > > suggestion that we should define new API support to add entries to > > dsotbl[] at run-time ... but how would this work with something like > > pminfo, where the metrics are arbitrary and the PCP client does not > > really know _which_ PMDAs need to be loaded into the local context? > > I'd like to see this API cleaned up. We have the unused argument to > pmNewContext which could be used to give, perhaps, a comma separated > list of dso PMDAs... (pretty sure we audited this a year or two back > and checked all callers were passing NULL in this argument atm, if it > helps). Don't you just hate it when the mail arrives after you've written the code? I don't think overloading the name argument to pmNewContext for the type == PM_CONTEXT_LOCAL case is going to work ... 1. In general there may be more than one DSO PMDA that a client would like to use via a local context 2. For each DSO PMDA, you need to specify - a domain number - a path (albeit relative) to the DSO - the name of the initialization routine to call after dlopen() 3. So 1. and 2. mean you'd need a syntax like sts = pmNewContext(PM_CONTEXT_LOCAL, "104|foo/pmdafoo.so| init_foo,903|/home/me/secret/place/blah.so|blah_pmda_init") which is getting a little ugly! 4. Independent of how this is done, we need to preserve the existing behaviour (including the weird environment variables). 5. Any client using additional DSO PMDAs already needs to know a lot about them, specifically their domain number, path to the DSO and initialization routine name, so we're probably talking about a very small set of targeted clients, like the cluster PMDA, standalone foostat, etc. The solution I've coded uses a new routine to register additional DSO PMDAs for use with PM_CONTEXT_LOCAL. The example above would become: if ((sts = __pmAddLocalPMDA(104, "foo/pmdafoo.so", "init_foo")) < 0) { // exercise for reader } if ((sts = __pmAddLocalPMDA(903, "/home/me/secret/place/blah.so", "blah_pmda_init")) < 0) { // exercise for reader } ... sts = pmNewContext(PM_CONTEXT_NULL, NULL); Before starting to QA this, we probably need consensus on the general approach. The only down-side I can see of the new libpcp routine is that it is hard to properly control making this change and the corresponding change the cluster PMDA (which triggered all of this) ... since they are in different packages. I have looked at the versions DSO hooks provided by gcc via -Wl,--version-script=mylib.map (as suggested much earlier by Nathan in another context) but unfortunately this does not come close to the weak symbols and run-time symbol interrogation that the IRIX toolchain supported which would have allowed the cluster PMDA to start even if the symbol __pmAddLocalPMDA was undefined and to _discover_ if __pmAddLocalPMDA was indeed defined before trying to call it. The gcc approach addresses some other versioning issues but not this particular one unfortunately. From nathans@aconex.com Sun Mar 28 18:51:58 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2SNpvDt014008 for ; Sun, 28 Mar 2010 18:51:57 -0500 X-ASG-Debug-ID: 1269820420-5cf200950000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 7BF8C1472C1E for ; Sun, 28 Mar 2010 16:53:40 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id z6MNnjw8kAHQONJ8 for ; Sun, 28 Mar 2010 16:53:40 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 710633E75F0; Mon, 29 Mar 2010 10:53:38 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id Zwxi0tGEXw6jpbuI; Mon, 29 Mar 2010 10:53:38 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 095C2A5011B; Mon, 29 Mar 2010 10:50:46 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 64DC548853E; Mon, 29 Mar 2010 10:53:38 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fP8pfKRqCciH; Mon, 29 Mar 2010 10:53:34 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 44BE448853F; Mon, 29 Mar 2010 10:53:34 +1100 (EST) Date: Mon, 29 Mar 2010 10:53:34 +1100 (EST) From: nathans@aconex.com Sender: nscott@aconex.com To: kenj@internode.on.net Cc: pcp@oss.sgi.com, Corneliu Boac Message-ID: <2103314471.197991269820414135.JavaMail.root@mail-au.aconex.com> In-Reply-To: <934944929.195941269818695751.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: Re: [pcp] How should we approach the loading of the IB pmda as a LOCAL context DSO? Subject: Re: [pcp] How should we approach the loading of the IB pmda as a LOCAL context DSO? MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - FF3.0 (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1269820421 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0208 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=NO_REAL_NAME X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.26110 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 NO_REAL_NAME From: does not include a real name X-Virus-Status: Clean ----- "Ken McDonell" wrote: > On Sat, 2010-03-27 at 08:23 +1100, nathans@aconex.com wrote: > > ----- "Ken McDonell" wrote: > > > ... > Don't you just hate it when the mail arrives after you've written the > code? Sorry 'bout that. > I don't think overloading the name argument to pmNewContext for the > type PM_CONTEXT_LOCAL case is going to work ... OK - *nod*, no worries, just wanted to put it out there in case it helped. > The solution I've coded uses a new routine to register additional DSO > PMDAs for use with PM_CONTEXT_LOCAL. The example above would become: > > if ((sts = __pmAddLocalPMDA(104, "foo/pmdafoo.so", "init_foo")) < 0) > { > // exercise for reader > } > if ((sts = __pmAddLocalPMDA(903, "/home/me/secret/place/blah.so", > "blah_pmda_init")) < 0) { > // exercise for reader > } > ... > sts = pmNewContext(PM_CONTEXT_NULL, NULL); > Seems better than overloading new context as an API (assume you meant PM_CONTEXT_LOCAL at the end there?). A few other considerations: - hard coding the domain numbers doesn't really make for readable code, wonder if we should install stdpmid as a header? or perhaps figure out the domain number from stdpmid on the fly and remove that 1st argument? - .so is platform specific (dylib on mac, dll on win) ... it would be a good idea to hide that aspect (platform differences) from the caller. - should there be a way to remove entries from the table too? Or at least start from a clean slate? > The only down-side I can see of the new libpcp routine is that it is > hard to properly control making this change and the corresponding > change > the cluster PMDA (which triggered all of this) ... since they are in > different packages. > Sounded earlier like the current cluster PMDA source (in oss tree, not released by SGI from that tree yet, I guess?) is completely broken, so simply adding a configure-and-fail check there would be a good start. Guess we could bump the libpcp shared library soname too (ouch). cheers. -- Nathan From kenj@internode.on.net Sun Mar 28 21:41:17 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX,J_CHICKENPOX_42,J_CHICKENPOX_45 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2T2fGtD024315 for ; Sun, 28 Mar 2010 21:41:17 -0500 X-ASG-Debug-ID: 1269830578-1c7b02f10000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 06EA31473134 for ; Sun, 28 Mar 2010 19:42:59 -0700 (PDT) Received: from mail.internode.on.net (bld-mail12.adl6.internode.on.net [150.101.137.97]) by cuda.sgi.com with ESMTP id vOKObNhewtd2cu2Y for ; Sun, 28 Mar 2010 19:42:59 -0700 (PDT) Received: from [172.29.250.169] (unverified [203.206.165.193]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 18706243-1927428 for multiple; Mon, 29 Mar 2010 13:12:54 +1030 (CDT) X-ASG-Orig-Subj: Re: [pcp] How should we approach the loading of the IB pmda as a LOCAL context DSO? Subject: Re: [pcp] How should we approach the loading of the IB pmda as a LOCAL context DSO? From: Ken McDonell Reply-To: kenj@internode.on.net To: nathans@aconex.com Cc: pcp@oss.sgi.com, Corneliu Boac In-Reply-To: <2103314471.197991269820414135.JavaMail.root@mail-au.aconex.com> References: <2103314471.197991269820414135.JavaMail.root@mail-au.aconex.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 29 Mar 2010 13:42:53 +1100 Message-ID: <1269830573.2314.26.camel@bozo-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail12.adl6.internode.on.net[150.101.137.97] X-Barracuda-Start-Time: 1269830581 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0001 1.0000 -2.0206 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.26122 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Mon, 2010-03-29 at 10:53 +1100, nathans@aconex.com wrote: ... > > ... > > sts = pmNewContext(PM_CONTEXT_NULL, NULL); > > > > Seems better than overloading new context as an API (assume you meant > PM_CONTEXT_LOCAL at the end there?). A few other considerations: Yes, PM_CONTEXT_LOCAL was the intent before the fat fingers got in the way. > - hard coding the domain numbers doesn't really make for readable code, > wonder if we should install stdpmid as a header? or perhaps figure out > the domain number from stdpmid on the fly and remove that 1st argument? If the PMDA is not one of the "standard ones" or has been renamed for some reason (I found a good reason to do that in the QA test when calling sample_init() twice for the _same_ DSO produces something less than desirable results), then I don't see how you could deduce the domain number from the name of the DSO ... and unless the PMDA is using the newer-than-new dynamic metrics services, the metrics for the PMDA have to already be in the PMNS (or a local PMNS via the -n option) ... so knowledge about the domain number needs to be pretty pervasive already. Using stdpmid with #include is one possible solution, but the symbols #defined therein are likely to cause serious clashes when you compile the client application ... perhaps we need stdpmid.h to be built from stdpmid by prefixing each name with PMDA_ ... but this would mean writing into /usr/include (or the Windows equivalent) each time stdpmid is rebuilt (which happens after software installation, not during a PCP build). Since this is such a low frequency usage, I'd probably opt for the simpler #define PMDA_BLAH 903 #define PMDA_FOO 104 in the source code that calls __pmAddLocalPMDA(). > - .so is platform specific (dylib on mac, dll on win) ... it would be > a good idea to hide that aspect (platform differences) from the caller. Would not be hard to have the code check for the existence of name, name.so, name.dylib, name.dll, ... and use the first found file ... would this work? > - should there be a way to remove entries from the table too? Or at > least start from a clean slate? Yeah, I toyed with that but laziness won out ... I can revisit the issue, but rather than a 3 or 4 more routines, I'd probably go the ioctl() path and change to __pmLocalPMDA() with an additional first argument being an opcode for one of ... - ADD - DEL (match domain number _or_ dso name) - CLEAR (remove all entries) Should I do this? > > The only down-side I can see of the new libpcp routine is that it is > > hard to properly control making this change and the corresponding > > change > > the cluster PMDA (which triggered all of this) ... since they are in > > different packages. > > > > Sounded earlier like the current cluster PMDA source (in oss tree, not > released by SGI from that tree yet, I guess?) is completely broken, so > simply adding a configure-and-fail check there would be a good start. > Guess we could bump the libpcp shared library soname too (ouch). I'd suggest not bumping the soname version this for this particular change, it just ain't worth the pain of many for the gain of so very few. ... 8^)> From nathans@aconex.com Sun Mar 28 22:02:12 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.7 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX, J_CHICKENPOX_42,J_CHICKENPOX_45 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2T32CXg025954 for ; Sun, 28 Mar 2010 22:02:12 -0500 X-ASG-Debug-ID: 1269831834-061701060000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 7EAB927FFB5 for ; Sun, 28 Mar 2010 20:03:54 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id LygmZD8mA4XT2B18 for ; Sun, 28 Mar 2010 20:03:54 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 70C743E809C; Mon, 29 Mar 2010 14:03:52 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id 089zy9BGOGBzYMzt; Mon, 29 Mar 2010 14:03:52 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 0208BA5011B; Mon, 29 Mar 2010 14:01:00 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 605A1488538; Mon, 29 Mar 2010 14:03:52 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UguN9iEIFne6; Mon, 29 Mar 2010 14:03:48 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 0FEDE48852D; Mon, 29 Mar 2010 14:03:48 +1100 (EST) Date: Mon, 29 Mar 2010 14:03:47 +1100 (EST) From: Nathan Scott To: kenj@internode.on.net Cc: pcp@oss.sgi.com, Corneliu Boac Message-ID: <663253322.207671269831827818.JavaMail.root@mail-au.aconex.com> In-Reply-To: <1269830573.2314.26.camel@bozo-laptop> X-ASG-Orig-Subj: Re: [pcp] How should we approach the loading of the IB pmda as a LOCAL context DSO? Subject: Re: [pcp] How should we approach the loading of the IB pmda as a LOCAL context DSO? MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - FF3.0 (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1269831836 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0058 1.0000 -1.9830 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.98 X-Barracuda-Spam-Status: No, SCORE=-1.98 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.26123 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ----- "Ken McDonell" wrote: > On Mon, 2010-03-29 at 10:53 +1100, nathans@aconex.com wrote: > ... > > Since this is such a low frequency usage, I'd probably opt for the > simpler > > #define PMDA_BLAH 903 > #define PMDA_FOO 104 > > in the source code that calls __pmAddLocalPMDA(). > Yep, OK, sounds fine. > > - .so is platform specific (dylib on mac, dll on win) ... it would > be > > a good idea to hide that aspect (platform differences) from the > caller. > > Would not be hard to have the code check for the existence of name, > name.so, name.dylib, name.dll, ... and use the first found file ... > would this work? Just testing the one $DSO_SUFFIX for the local platform would do I think (falling back to auto-appending suffix if the requested file not found), also, prepending $PCP_PMDAS_DIR? - I think that was the original intention from your example before which had a relative path IIRC? > > - should there be a way to remove entries from the table too? Or > at > > least start from a clean slate? > > Yeah, I toyed with that but laziness won out ... I can revisit the > issue, but rather than a 3 or 4 more routines, I'd probably go the > ioctl() path and change to __pmLocalPMDA() with an additional first > argument being an opcode for one of ... > - ADD > - DEL (match domain number _or_ dso name) > - CLEAR (remove all entries) > > Should I do this? Yeah, I think that would be good. > > > > Sounded earlier like the current cluster PMDA source (in oss tree, > not > > released by SGI from that tree yet, I guess?) is completely broken, > so > > simply adding a configure-and-fail check there would be a good > start. > > Guess we could bump the libpcp shared library soname too (ouch). > > I'd suggest not bumping the soname version this for this particular > change, it just ain't worth the pain of many for the gain of so very > few. ... 8^)> Yep, vigorous nodding here! cheers. -- Nathan From makc@iinet.net.au Sun Mar 28 22:24:25 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2T3OOl6027796 for ; Sun, 28 Mar 2010 22:24:25 -0500 X-ASG-Debug-ID: 1269833165-36c0020a0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from outbound.icp-qv1-irony-out4.iinet.net.au (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 014CD1473216 for ; Sun, 28 Mar 2010 20:26:06 -0700 (PDT) Received: from outbound.icp-qv1-irony-out4.iinet.net.au (outbound.icp-qv1-irony-out4.iinet.net.au [203.59.1.104]) by cuda.sgi.com with ESMTP id Hnl5DxnNbFcmjmlB for ; Sun, 28 Mar 2010 20:26:06 -0700 (PDT) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAGq6r0vL2Rwk/2dsb2JhbACbKnG+G4UBBA X-IronPort-AV: E=Sophos;i="4.51,326,1267372800"; d="scan'208";a="527857981" Received: from unknown (HELO alma.crabbed.net) ([203.217.28.36]) by outbound.icp-qv1-irony-out4.iinet.net.au with ESMTP; 29 Mar 2010 11:26:02 +0800 Received: by alma.crabbed.net (Postfix, from userid 501) id 6F049E6372; Mon, 29 Mar 2010 14:26:02 +1100 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19376.7626.386396.542948@iinet.net.au> Date: Mon, 29 Mar 2010 14:26:02 +1100 From: Max Matveev To: Nathan Scott Cc: pcp@oss.sgi.com X-ASG-Orig-Subj: Re: [pcp] PMID domain number for new pmda Subject: Re: [pcp] PMID domain number for new pmda In-Reply-To: <1724963650.166991269575216829.JavaMail.root@mail-au.aconex.com> References: <19372.1314.39706.68697@iinet.net.au> <1724963650.166991269575216829.JavaMail.root@mail-au.aconex.com> X-Mailer: VM 7.17 under 21.4 (patch 19) "Constant Variable" XEmacs Lucid X-Barracuda-Connect: outbound.icp-qv1-irony-out4.iinet.net.au[203.59.1.104] X-Barracuda-Start-Time: 1269833168 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.26124 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Fri, 26 Mar 2010 14:46:56 +1100 (EST), Nathan Scott wrote: nathans> ----- "Max Matveev" wrote: >> We're developing IPMI pmda internally which may or may not ever see >> the light of the open-source world. I'd like to use an officially >> assigned domain number to avoid archive problems in the future. >> What's the protocol for getting a domain for not-yet-ready pmdas? nathans> Send a patch, marking it reserved (with IPMI keyword). The following changes since commit ebcf83e8d8a9c7bb8789c57f7d1a35172e8d704b: Nathan Scott (1): Bump version for recent bug fixes (3.1.2). are available in the git repository at: git://oss.sgi.com/makc/pcp ipmi Max Matveev (1): Reserve domain for IPMI pmda src/pmns/stdpmid.pcp | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) nathans> I looked at doing an IPMI PMDA awhile back, are you planning on using nathans> the openipmi library? (is this on Linux?) It is on linux but it's using freeipmi - I'm not sure why, it wasn't my decision. max From cboac@sgi.com Mon Mar 29 10:26:22 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: ** X-Spam-Status: No, score=2.2 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX, J_CHICKENPOX_42,J_CHICKENPOX_45 autolearn=no version=3.3.0-rupdated Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2TFQL9S099067 for ; Mon, 29 Mar 2010 10:26:22 -0500 Received: from [128.162.233.12] (lnx-cboac.americas.sgi.com [128.162.233.12]) by relay2.corp.sgi.com (Postfix) with ESMTP id 23A8430406B; Mon, 29 Mar 2010 08:28:02 -0700 (PDT) Message-ID: <4BB0C702.6020404@sgi.com> Date: Mon, 29 Mar 2010 10:28:02 -0500 From: Corneliu Boac User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100228 SUSE/3.0.3-1.1.1 Thunderbird/3.0.3 MIME-Version: 1.0 To: Nathan Scott CC: kenj@internode.on.net, pcp@oss.sgi.com Subject: Re: [pcp] How should we approach the loading of the IB pmda as a LOCAL context DSO? References: <663253322.207671269831827818.JavaMail.root@mail-au.aconex.com> In-Reply-To: <663253322.207671269831827818.JavaMail.root@mail-au.aconex.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean I like the proposed solution. This will address the pmclusterd issue. Thank you everybody. Please let me know if I can help with anything. Best regards, Cornel. On 03/28/2010 10:03 PM, Nathan Scott wrote: > ----- "Ken McDonell" wrote: > > >> On Mon, 2010-03-29 at 10:53 +1100, nathans@aconex.com wrote: >> ... >> >> Since this is such a low frequency usage, I'd probably opt for the >> simpler >> >> #define PMDA_BLAH 903 >> #define PMDA_FOO 104 >> >> in the source code that calls __pmAddLocalPMDA(). >> >> > Yep, OK, sounds fine. > > >>> - .so is platform specific (dylib on mac, dll on win) ... it would >>> >> be >> >>> a good idea to hide that aspect (platform differences) from the >>> >> caller. >> >> Would not be hard to have the code check for the existence of name, >> name.so, name.dylib, name.dll, ... and use the first found file ... >> would this work? >> > Just testing the one $DSO_SUFFIX for the local platform would do I think > (falling back to auto-appending suffix if the requested file not found), > also, prepending $PCP_PMDAS_DIR? - I think that was the original intention > from your example before which had a relative path IIRC? > > >>> - should there be a way to remove entries from the table too? Or >>> >> at >> >>> least start from a clean slate? >>> >> Yeah, I toyed with that but laziness won out ... I can revisit the >> issue, but rather than a 3 or 4 more routines, I'd probably go the >> ioctl() path and change to __pmLocalPMDA() with an additional first >> argument being an opcode for one of ... >> - ADD >> - DEL (match domain number _or_ dso name) >> - CLEAR (remove all entries) >> >> Should I do this? >> > Yeah, I think that would be good. > > >>> Sounded earlier like the current cluster PMDA source (in oss tree, >>> >> not >> >>> released by SGI from that tree yet, I guess?) is completely broken, >>> >> so >> >>> simply adding a configure-and-fail check there would be a good >>> >> start. >> >>> Guess we could bump the libpcp shared library soname too (ouch). >>> >> I'd suggest not bumping the soname version this for this particular >> change, it just ain't worth the pain of many for the gain of so very >> few. ... 8^)> >> > Yep, vigorous nodding here! > > cheers. > > From nathans@aconex.com Mon Mar 29 19:57:44 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o2U0vhJ1138953 for ; Mon, 29 Mar 2010 19:57:44 -0500 X-ASG-Debug-ID: 1269910766-7cc503d20000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 64B971478684 for ; Mon, 29 Mar 2010 17:59:27 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id qSLYAsuaOf6RgREN for ; Mon, 29 Mar 2010 17:59:27 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 12C4589BECA for ; Tue, 30 Mar 2010 11:59:24 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id Tzh6A9aLaz0APRJe for ; Tue, 30 Mar 2010 11:59:24 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 04D21A5028B for ; Tue, 30 Mar 2010 11:56:31 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id E32D0488536 for ; Tue, 30 Mar 2010 11:59:23 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4m8r6EiPs-05 for ; Tue, 30 Mar 2010 11:59:19 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id E4D2448852E for ; Tue, 30 Mar 2010 11:59:19 +1100 (EST) Date: Tue, 30 Mar 2010 11:59:19 +1100 (EST) From: Nathan Scott To: pcp Message-ID: <1314992818.237101269910759712.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcp updates Subject: pcp updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - FF3.0 (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1269910768 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0005 1.0000 -2.0175 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.26207 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Changes committed to git://oss.sgi.com/nathans/pcp.git man/man3/pmconvscale.3 | 2 +- src/include/pmapi.h | 2 +- src/libpcp/src/units.c | 2 +- src/pmdas/mmv/mmv.c | 5 ++--- src/pmstat/pmstat.c | 25 ++++++++++++++++--------- 5 files changed, 21 insertions(+), 15 deletions(-) commit 5f7cdd9f12510a2511f621cfb2ef8eb09f4f98c1 Author: Nathan Scott Date: Tue Mar 30 11:56:36 2010 +1100 If pmstat fails to connect to local pmcd switch to local context Makes pmstat a bit more user friendly in the presence of no local pmcd process. Since pmstat only uses kernel metrics, using local context is a simple and safe alternative. The existing -L option remains, of course, to force local context mode. commit 0e1c89be299cd9ecaf3e7a15e06b566937c425f2 Author: Nathan Scott Date: Tue Mar 30 11:53:06 2010 +1100 Keep in-memory copy of monitored MMV PID for process exit detection We dont want to use the mmap value (from the data file) as this can be overwritten by a subsequent restart of the monitored application and hence we're not comparing to the original monitored PID. commit ceaf57f62210ddaee7265cb16245df9bfcacef5f Author: Nathan Scott Date: Tue Mar 30 11:50:50 2010 +1100 Mark as const the final (output units) pmConvScale argument Its a bit confusing otherwise, as the input units is a const. The requested output units is also constant, so mark it thus.