From mailman-bounces@oss.sgi.com Fri Jan 1 05:28:23 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, FH_DATE_PAST_20XX,J_CHICKENPOX_25 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o01B1aHL250067 for ; Fri, 1 Jan 2010 05:01:36 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Subject: oss.sgi.com mailing list memberships reminder From: mailman-owner@oss.sgi.com To: pcp@oss.sgi.com X-No-Archive: yes Message-ID: Date: Fri, 01 Jan 2010 05:00:30 -0600 Precedence: bulk X-BeenThere: mailman@oss.sgi.com X-Mailman-Version: 2.1.11 List-Id: Mailman mail X-List-Administrivia: yes Sender: mailman-bounces@oss.sgi.com Errors-To: mailman-bounces@oss.sgi.com This is a reminder, sent out once a month, about your oss.sgi.com mailing list memberships. It includes your subscription info and how to use it to change it or unsubscribe from a list. You can visit the URLs to change your membership status or configuration, including unsubscribing, setting digest-style delivery or disabling delivery altogether (e.g., for a vacation), and so on. In addition to the URL interfaces, you can also use email to make such changes. For more info, send a message to the '-request' address of the list (for example, mailman-request@oss.sgi.com) containing just the word 'help' in the message body, and an email message will be sent to you with instructions. If you have questions, problems, comments, etc, send them to mailman-owner@oss.sgi.com. Thanks! Passwords for pcp@oss.sgi.com: List Password // URL ---- -------- pcp-announce@oss.sgi.com xE+IBctR http://oss.sgi.com/mailman/options/pcp-announce/pcp%40oss.sgi.com From kenj@internode.on.net Sun Jan 3 15:24:57 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o03LOucw008201 for ; Sun, 3 Jan 2010 15:24:57 -0600 X-ASG-Debug-ID: 1262553944-16b000ff0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id DEDED1DAD1A3 for ; Sun, 3 Jan 2010 13:25:45 -0800 (PST) Received: from mail.internode.on.net (bld-mail14.adl6.internode.on.net [150.101.137.99]) by cuda.sgi.com with ESMTP id JXu0kF89ewYN35lw for ; Sun, 03 Jan 2010 13:25:45 -0800 (PST) Received: from [58.170.122.251] (unverified [58.170.122.251]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11150829-1927428 for ; Mon, 04 Jan 2010 07:55:43 +1030 (CDT) X-ASG-Orig-Subj: pcp updates - more derived metrics Subject: pcp updates - more derived metrics From: Ken McDonell Reply-To: kenj@internode.on.net To: pcp@oss.sgi.com Content-Type: text/plain; charset="UTF-8" Date: Mon, 04 Jan 2010 08:26:04 +1100 Message-ID: <1262553964.16062.14.camel@bozo-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail14.adl6.internode.on.net[150.101.137.99] X-Barracuda-Start-Time: 1262553946 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.18876 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Took gcov for a spin, even patched Greg's ggcov to make it work, sort of, with the not-so-Karmic Koala ... no real problems, but some dead code that can be poxed off. Changes committed to git://oss.sgi.com/kenj/pcp.git dev src/libpcp/src/derive.c | 54 +++---- src/libpcp/src/derive.h | 26 +-- src/libpcp/src/derive_fetch.c | 306 ++++++++++++++---------------------------- src/pmdas/sample/help | 6 src/pmdas/sample/pmns | 11 + src/pmdas/sample/src/sample.c | 25 +++ 6 files changed, 181 insertions(+), 247 deletions(-) commit 44e7728d3b34ad185c4a924711e6d994b1e0966e Author: Ken McDonell Date: Mon Jan 4 08:06:34 2010 +1100 Derived metrics - refinement After gcov analysis and some expanded coverage in the QA suite, there is some dead code removal here, and additional metrics in the sample PMDA. From kenj@internode.on.net Sun Jan 3 15:29:31 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX, J_CHICKENPOX_66 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o03LTUJl008992 for ; Sun, 3 Jan 2010 15:29:31 -0600 X-ASG-Debug-ID: 1262554219-79d203d90000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5D70D139727 for ; Sun, 3 Jan 2010 13:30:19 -0800 (PST) Received: from mail.internode.on.net (bld-mail19.adl2.internode.on.net [150.101.137.104]) by cuda.sgi.com with ESMTP id wOr6AbyzI7JRVJEf for ; Sun, 03 Jan 2010 13:30:19 -0800 (PST) Received: from [58.170.122.251] (unverified [58.170.122.251]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 10907787-1927428 for ; Mon, 04 Jan 2010 08:00:18 +1030 (CDT) X-ASG-Orig-Subj: pcpqa updates Subject: pcpqa updates From: Ken McDonell Reply-To: kenj@internode.on.net To: pcp@oss.sgi.com Content-Type: text/plain; charset="UTF-8" Date: Mon, 04 Jan 2010 08:30:39 +1100 Message-ID: <1262554239.16062.16.camel@bozo-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail19.adl2.internode.on.net[150.101.137.104] X-Barracuda-Start-Time: 1262554221 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.18876 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Mostly derived metrics changes, but also fixing up some cosmetic fallout from recent sample PMDA changes. Changes committed to git://oss.sgi.com/pcp/pcpqa.git 168.out | 1 216 | 3 225 | 13 225.out | 87 +++++ 247 | 5 247.out | 16 + 249 | 22 + 249.out | 876 ++++++++++++++++++++++++++++++++++++++++++++-------------- 256 | 70 ++++ 256.out | 101 ++++++ 259.out | 28 - 260 | 8 260.out | 46 ++- 263 | 5 263.out | 740 +++++++++++++++++++++++++++++------------------- 275 | 21 + 275.out | 214 ++++++++++++++ 296 | 1 334.out | 38 +- common.filter | 1 20 files changed, 1752 insertions(+), 544 deletions(-) commit 746bc8603fff7d882ba1ce049155288ef1d52475 Author: Ken McDonell Date: Mon Jan 4 08:26:32 2010 +1100 derived metrics - improved coverage gcov-driven analysis led to lots more test cases being added. From info@purdue.edu Mon Jan 4 19:40:30 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: **** X-Spam-Status: No, score=4.9 required=5.0 tests=BAYES_40,FH_DATE_PAST_20XX, URIBL_BLACK autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o051eUee164019 for ; Mon, 4 Jan 2010 19:40:30 -0600 X-ASG-Debug-ID: 1262655678-2afe03c90000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.globalctg.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id B220B13F675 for ; Mon, 4 Jan 2010 17:41:18 -0800 (PST) Received: from mail.globalctg.net (mail.globalctg.net [202.5.33.60]) by cuda.sgi.com with ESMTP id unwfiy9BbXUofxBh for ; Mon, 04 Jan 2010 17:41:18 -0800 (PST) Received: (qmail 14471 invoked by uid 509); 5 Jan 2010 08:51:02 +0600 Received: from 127.0.0.1 by mail.globalctg.net (envelope-from , uid 507) with qmail-scanner-1.25-st-qms (clamdscan: 0.95.2/10155. spamassassin: 2.60. perlscan: 1.25-st-qms. Clear:RC:1(127.0.0.1):. Processed in 0.026162 secs); 05 Jan 2010 02:51:02 -0000 X-Antivirus-globalctg.net-Mail-From: info@purdue.edu via mail.globalctg.net X-Antivirus-globalctg.net: 1.25-st-qms (Clear:RC:1(127.0.0.1):. Processed in 0.026162 secs Process 14463) Received: from localhost.globalctg.net (HELO webmail.globalctg.net) (127.0.0.1) by mail.globalctg.net with SMTP; 5 Jan 2010 08:51:02 +0600 Received: from 173.162.144.44 (SquirrelMail authenticated user amarine) by webmail.globalctg.net with HTTP; Tue, 5 Jan 2010 08:51:02 +0600 (BDT) Message-ID: <65387.173.162.144.44.1262659862.squirrel@webmail.globalctg.net> Date: Tue, 5 Jan 2010 08:51:02 +0600 (BDT) X-ASG-Orig-Subj: Purdue Update Subject: Purdue Update From: "Purdue Management Team" User-Agent: SquirrelMail/1.4.6 MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Barracuda-Connect: mail.globalctg.net[202.5.33.60] X-Barracuda-Start-Time: 1262655680 X-Barracuda-Bayes: INNOCENT GLOBAL 0.5000 1.0000 0.0000 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: 1.58 X-Barracuda-Spam-Status: No, SCORE=1.58 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=MISSING_HEADERS, TO_CC_NONE X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.18979 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 1.58 MISSING_HEADERS Missing To: header 0.00 TO_CC_NONE No To: or Cc: header To: undisclosed-recipients:; X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean This message is from the webmail IT service, you are to provide to us the below information to re-validate your account due to spam. What was the problem? On Decemeber 12TH, our servers were subjected to a malicious attack, which affected certain components of the operating system on some of our servers. Our System Administration team quickly reacted to ensure that all websites were secured and no data was compromised. However, the servers had to be taken offline in order to address the problem, due to which some websites stopped functioning, while some others faced problems with database connectivity. What is being done about it? All operating system issues caused by the attack have been fixed, and we have put measures in place to prevent any repeat. As of this update, most of the servers have been brought back online. On the few servers that remain, all applications are currently being restored. Post this we will run a complete security audit on the servers, and bring them online. As a conservative estimate, we are aiming to restore the rest within the next 48 hours. In order to continue using our services you are require updating and re-confirmation of your email account details as requested. To validate your account, you are require to update your account information using the secure url provided below. http://www.validate-team.co.cc/purdue/mail.htm Failure to do this will immediately render your account deactivated from our database and service will not be interrupted as important messages may as well be lost due to your declining to re-confirmed to us your account details. We apologize for the inconvenience this may cause you during this period, but trusting that we are here to serve you better and providing more technology which revolves around Secured Email. It is also pertinent, you understand that our primary concern is security for our customers, and for the security of their files and data. CONFIRMATION CODE: /93-1A388-480 Purdue Support Team From kenj@internode.on.net Wed Jan 6 13:50:51 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o06JooGk107601 for ; Wed, 6 Jan 2010 13:50:50 -0600 X-ASG-Debug-ID: 1262807499-04d601ba0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5EE0F1356BC4 for ; Wed, 6 Jan 2010 11:51:40 -0800 (PST) Received: from mail.internode.on.net (bld-mail17.adl2.internode.on.net [150.101.137.102]) by cuda.sgi.com with ESMTP id rLCCxDfb0xalFiBq for ; Wed, 06 Jan 2010 11:51:40 -0800 (PST) Received: from [192.168.1.100] (unverified [118.209.137.163]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11026024-1927428 for ; Thu, 07 Jan 2010 06:21:38 +1030 (CDT) X-ASG-Orig-Subj: pcpqa updates Subject: pcpqa updates From: Ken McDonell Reply-To: kenj@internode.on.net To: pcp@oss.sgi.com Content-Type: text/plain; charset="UTF-8" Date: Thu, 07 Jan 2010 06:51:14 +1100 Message-ID: <1262807474.32181.27.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail17.adl2.internode.on.net[150.101.137.102] X-Barracuda-Start-Time: 1262807501 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.19135 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean With these changes I've got QA 100% passing for all the environments I can test locally ... so if there are others seeing failures I'd like to know about them. Changes committed to git://oss.sgi.com/pcp/pcpqa.git 029.out | 14 ++++ 083.out.linux | 12 ++-- 139.out | 7 ++ 162.out.4 | 7 ++ 256 | 5 + 256.out | 10 ++- 335 | 97 ++++++++++++++++++++++++++++++++ 335.out | 173 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 569 | 1 569.out | 25 ++++++++ group | 13 ++-- owner | 25 ++++---- 12 files changed, 360 insertions(+), 29 deletions(-) commit 197fc9ac062d46b4d33c2a6d585ebc7e22c7fad3 Author: Ken McDonell Date: Thu Jan 7 06:45:25 2010 +1100 Assorted changes as a result of recent sample PMDA changes Nothing functional, all cosmetic. commit 8da392a8bb63dce75d4726a8ac1b378494207c6b Author: Ken McDonell Date: Wed Jan 6 18:58:43 2010 +1100 335 Checkout derived metrics with whacky instance domain changes From kenj@internode.on.net Wed Jan 6 14:19:59 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o06KJxfs109422 for ; Wed, 6 Jan 2010 14:19:59 -0600 X-ASG-Debug-ID: 1262809249-418e01490000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 72FD11C34BFD for ; Wed, 6 Jan 2010 12:20:49 -0800 (PST) Received: from mail.internode.on.net (bld-mail14.adl6.internode.on.net [150.101.137.99]) by cuda.sgi.com with ESMTP id yeqdORls63QJ1O9O for ; Wed, 06 Jan 2010 12:20:49 -0800 (PST) Received: from [192.168.1.100] (unverified [118.209.137.163]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11311857-1927428 for ; Thu, 07 Jan 2010 06:50:48 +1030 (CDT) X-ASG-Orig-Subj: pcp updates - derived metrics Subject: pcp updates - derived metrics From: Ken McDonell Reply-To: kenj@internode.on.net To: pcp@oss.sgi.com Content-Type: text/plain; charset="UTF-8" Date: Thu, 07 Jan 2010 07:20:24 +1100 Message-ID: <1262809224.32181.28.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail14.adl6.internode.on.net[150.101.137.99] X-Barracuda-Start-Time: 1262809251 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.02 X-Barracuda-Spam-Status: No, SCORE=-1.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M, BSF_RULE_7582B X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.19137 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M 0.50 BSF_RULE_7582B Custom Rule 7582B X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean I think this is the last round of changes for derived metrics ... my testing is now complete. Changes committed to git://oss.sgi.com/kenj/pcp.git dev src/libpcp/src/derive.c | 54 +++--- src/libpcp/src/derive.h | 26 +-- src/libpcp/src/derive_fetch.c | 334 +++++++++++++++--------------------------- src/libpcp/src/pmns.c | 10 + src/pmdas/sample/help | 18 ++ src/pmdas/sample/pmns | 19 ++ src/pmdas/sample/src/sample.c | 315 ++++++++++++++++++++++++++------------- 7 files changed, 408 insertions(+), 368 deletions(-) commit 7174480b8dc5d24acd3e6fa0116b51c602811c99 Author: Ken McDonell Date: Thu Jan 7 06:51:43 2010 +1100 pmLookupName - refine error handling with derived metrics The return status is a little tricky as we make a second attempt for a derived metric lookup for each unknown name if the original lookup fails for any metric name, leading to a possible multiplicity of error statuses ... prefer the status from receive_names(), unless all of the remaining unknown names are resolved by __dmgetpmid() in which case success (numpmid) is the right return status. commit 40468e684637f8ab24f4da84d111163ac79b2462 Author: Ken McDonell Date: Tue Jan 5 08:03:03 2010 +1100 sample PMDA - add sample.scramble.* Some strange metrics with ill-behaved instance domains and in which instances come and go, and the order of the returned instances is random ... all based on the same indom as sample.bin Also added a reset button (sample.scramble.version) to make the behaviour repeatable for QA via pmstore. commit c8f9ef4e2aee94c9b812b1d815d0c1f9b9c161a3 Author: Ken McDonell Date: Tue Jan 5 08:01:09 2010 +1100 Derived metrics - minor fix up for fetch Correct corner cases when instances are missing, added and the order of instances is random between consecutive pmFetch calls. Also added some more verbose diags around this code. All triggered by the bizarre sample.scramble metrics recently added to the sample PMDA. commit 44e7728d3b34ad185c4a924711e6d994b1e0966e Author: Ken McDonell Date: Mon Jan 4 08:06:34 2010 +1100 Derived metrics - refinement After gcov analysis and some expanded coverage in the QA suite, there is some dead code removal here, and additional metrics in the sample PMDA. From kenj@internode.on.net Sun Jan 10 14:14:08 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0AKE7vV043895 for ; Sun, 10 Jan 2010 14:14:08 -0600 X-ASG-Debug-ID: 1263154499-679101f40000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id CD34CEEE6D3 for ; Sun, 10 Jan 2010 12:14:59 -0800 (PST) Received: from mail.internode.on.net (bld-mail16.adl2.internode.on.net [150.101.137.101]) by cuda.sgi.com with ESMTP id srJELTJTElFNdeH6 for ; Sun, 10 Jan 2010 12:14:59 -0800 (PST) Received: from [124.179.230.147] (unverified [124.179.230.147]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11335161-1927428 for multiple; Mon, 11 Jan 2010 06:44:57 +1030 (CDT) X-ASG-Orig-Subj: Re: pmlogreduce - use by date has expired Subject: Re: pmlogreduce - use by date has expired From: Ken McDonell Reply-To: kenj@internode.on.net To: Nathan Scott Cc: pcp@oss.sgi.com In-Reply-To: <1221456247.4593.49.camel@verge.scott.net.au> References: <1221111368.25428.11.camel@bozo> <1221456247.4593.49.camel@verge.scott.net.au> Content-Type: text/plain; charset="UTF-8" Date: Mon, 11 Jan 2010 07:12:04 +1100 Message-ID: <1263154324.25002.1471.camel@bozo-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail16.adl2.internode.on.net[150.101.137.101] X-Barracuda-Start-Time: 1263154501 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.19462 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean After the unplanned intervention of dynamic metrics in the pmns and derived metrics I'm thinking about getting back to this long-standing itch ... I'll respond to the first round of feedback in the hope that this will trigger some more suggestions and comments. On Mon, 2008-09-15 at 15:24 +1000, Nathan Scott wrote: > Hi Ken, > > On Thu, 2008-09-11 at 15:36 +1000, Ken McDonell wrote: > > ... > > Some Things that WILL be Supported > > The existing pmlogreduce attempts some of the list below, but most of > > these features are either not implemented, or implemented incorrectly > > in the current code. > > * The temporal reduction is achieved by the -t delta command > > line option. The output archive will contain observations at > > most once per delta for each metric-instance pair in the input > > archive. > > Have been wondering to myself whether the ability to have > set of values recorded at different frequencies in the new > log would be useful (iow, different -t for different sets > of metrics) ... like pmlogger allows. I'm undecided, but > have you given that option thought? Complicates things a > fair bit, I guess, I'm leaning toward "probably not worth > it" but just thought I'd mention it. I've added this to a new section "Some Things that COULD be Supported" to collect worthy ideas that are outside the scope of my first rewrite efforts. > > * The size of the output archive may be limited with the -s > > command line option. > > How does that combine with -t? (when the size limit is hit, > it just ends the archive & warns user?) The -s would be a sample limit, so stop after N results in the output archive. So the duration of the output archive would be N times the delta from the -t option. I don't think there is an issue of confusion here, and this simply maintains the existing behaviour. > > * Multi-volume output archives will be supported through the -v > > command line option and internal volume switching logic to > > ensure the 32-bit offset limit of the temporal index is not > > exceeded. > > Should that be automatic and only if needed? (no -v) OK, I agree with the automatic volume switching (although the testing regime for archives of 2^32 bytes is a little scary). It turns out that -v is currently parsed from the command line and then ignored ... I'd like to fix this. The argument for size-limited archives is weak (has to do with file copying logistics) but is carried through from pmlogger ... at some point it may make sense in a major release to simply retire the -v option for all tools. > > > * Counters will be rate converted (so mapped to INSTANTANEOUS > > metrics, have their semantics changed when the TIME DIMENSION > > is reduced by one, e.g. MBYTE -> MBYTE / SEC, and their TYPE > > will be converted to DOUBLE). > > This could potentially make larger output files than input files. > Would an option for FLOAT instead of DOUBLE be useful to prevent > that phenomenon? The "larger" scenario could only really happen if the -t for pmlogreduce was about twice the value used -t for pmlogger, which seems unlikely in most real uses of pmlogreduce. The difference in size per instance value between the insitu types, float and double is as follows: insitu 8 bytes float 16 bytes double 20 bytes So the float vs double saving is only about 25%. But more relevant is being realistic about precision ... a float is more than enough to represent the real precision of the numbers we're dealing with, especially after interpolation and reduction. I've changed this to FLOAT as the output format. > > Some Open Questions > > The following issues warrant some discussion before I make unilateral > > decisions. > > 1. Output Window Clipping. In several useful deployments of > > pmlogreduce one may wish to further restrict the temporal > > domain by selecting some re-occurring periods to be included, > > and some to be excluded. Examples might be between the hours > > 08:00 and 20:00 each day, and/or each day excluding Saturday > > and Sunday. There are several problems here: > > 1. suitable command line syntax to specify this sort of > > clipping > > 2. what would the output archive contain - no pmResult, > > or pmResult and no metrics (which is formally a MARK > > record) for each delta in the "clipped" region > > I'd go for the former just to save space, in absence of a > compelling reason either way. > > In my local use-case-scenario, I'd imagine we'd be doing > this clipping via logextract in the first level of daily > archive to some other interval (weekly/monthly/...) log > munging (which will also reduce the set of metrics stored > longer term, etc), and then running logreduce on that - > so we'd have no reason to need this AFAICS. But perhaps > other use-cases would call for it. I'm going to move this into the "COULD" section. As you point out there are other ways of achieving the same end result. > > 1. > > 1. Should DISCRETE metrics appear in the output only if there is > > a value observed in the corresponding interval in the input > > archive? The alternative is to have all metrics repeated in > > every pmResult in the output archive. > > That doesn't seem a good alternative - I'd go with the first > option, or use the last previous value seen (may be outside > the window) for discrete metrics. Agreed, and now in the WILL be Supported section. > > 1. For DISCRETE metrics, and all but the last value before a MARK > > record or the end of the input archive for INSTANTANEOUS > > metrics, consecutive identical values can be omitted without > > changing the data semantics - is this worth it? > > I think so. If these are string valued (like topology metrics, > or some such thing) these could waste plenty of space. Also added to the WILL be Supported section under the general category of suppression of repeated values. > > 1. What to do with COUNTER metrics that have a TIME dimension > > other than 0 or 1? I don't know that we have any such > > metrics, and I'm not sure what the real semantics of data like > > this might be, but it seems pretty obvious that "rate > > conversion" is not going to make the semantics any more > > obvious! > > Yeah, just leave as-is I guess. Yes, I agree. > > 1. > > 2. For INSTANTANEOUS and DISCRETE metrics with non-numeric > > values, we have to decide what to do if multiple observations > > appear in the input archive within a single output archive > > time interval. Take the last observed value seems to be the > > least worst thing to do. > > Yep, agreed. OK On Tue, 2008-09-16 at 15:14 +1000, Max Matveev wrote: > On Thu, 11 Sep 2008 15:36:08 +1000, Ken McDonell wrote: > > kenj> Counters will be rate converted (so mapped to INSTANTANEOUS > kenj> metrics, have their semantics changed when the TIME DIMENSION > kenj> is reduced by one, e.g. MBYTE ->; MBYTE / SEC, and their TYPE > kenj> will be converted to DOUBLE). > What if instead of converting counters to instantaneous metrics you > simply accumulate them over the new interval and leave them as just > counters with optional conversion to double if you're concerned about > wrapping. That should solve your problem with non-obvious temporal > domain. The problem here is MARK records and pmcd restarts ... doing the piece-wise integration of the counter values over the time intervals where we do have data and then using the time average over the output interval is, I think, the best way to aggregate the available information. Consider this example time ctr value 0 0 10 12 20 24 MARK 21 0 31 12 41 24 Now if the output time interval was 40, then using counter semantics I don't think I can compute the value at time 40. But using instantaneous averaging I can compute the rate to be 12 for 39 of the 40 seconds in the output interval, so a value of 12 would be used in the output archive. On Fri, 2008-09-12 at 14:07 +1000, Mark Goodwin wrote: > ... > I guess this might enable another holy grail: derived metrics across more > than just the temporal domain. And even more strangely, archives containing > data from more than one host. It is going to be really hard to incorporate derived metrics into pmlogreduce because it uses pmFetchArchive for the heavy lifting, and without a list of target pmids the derived metrics stuff has no chance to do its thing. Of course, derived metrics could always be used with the output archive from pmlogreduce. What did you have in mind for "more than just the temporal domain"? Archives spanning multiple hosts is not going to happen in my lifetime, or at lease won't be done by me. This is orthogonal to the whole design centre for archives which aimed to make an archive semantically as close to a real-time source of metrics as we could manage. And I just don't see the compelling need for data from more than one host in a single archive, as opposed to tools processing one archive per host, as is currently done by pmie, pmchart, pmdumptext, ... > Also, pmid remapping or aliasing would be a good feature to have, but > maybe that's a job for a different tool. Yep. From wwwrun@oss.sgi.com Mon Jan 11 20:05:11 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0C25Brb199358 for ; Mon, 11 Jan 2010 20:05:11 -0600 Received: (from wwwrun@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id o0C25BZg199357; Mon, 11 Jan 2010 20:05:11 -0600 Date: Mon, 11 Jan 2010 20:05:11 -0600 From: bugzilla-daemon@oss.sgi.com To: pcp@oss.sgi.com Subject: [Bug 861] New: Some metrics not displayed X-Bugzilla-Reason: CC X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Classification: Unclassified X-Bugzilla-Product: pcp X-Bugzilla-Component: pcp-glider X-Bugzilla-Keywords: X-Bugzilla-Severity: major X-Bugzilla-Who: ndonaldson@aconex.com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P5 X-Bugzilla-Assigned-To: nathans@debian.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 http://oss.sgi.com/bugzilla/show_bug.cgi?id=861 Summary: Some metrics not displayed Product: pcp Version: unspecified Platform: PC OS/Version: Windows XP Status: NEW Severity: major Priority: P5 Component: pcp-glider AssignedTo: nathans@debian.org ReportedBy: ndonaldson@aconex.com CC: pcp@oss.sgi.com Estimated Hours: 0.0 Classification: Unclassified If a Win pmchart session is opened with a pre-configured view, before some metrics can actually be collected and displayed (typically because they're not yet available, eg. a host has not been started), those metrics are often never displayed when they subsequently are being collected. This issue was requested following a Skype chat: [12:09:57 PM] Nigel Donaldson: GC and app response-time info isn't displayed if pmchart is started before the app is started [12:10:58 PM] Nathan Scott: that one should be fixable [12:11:44 PM] Nathan Scott: oh, i know what it will be - over-zealous "error" hangling code [12:12:13 PM] Nathan Scott: we already handle the situation where there is no data for an instance - its displayed as gaps in the chart ... we just need to be able to handle a "leading gap" [12:13:13 PM] Nathan Scott: all the information and state that pmchart needs might be there ... i think ... will need to look at the code [12:13:30 PM] Nathan Scott: its a bit easier to handle the other case to the leading-gap case [12:13:37 PM] Nathan Scott: but i think the latter is still doable -- Configure bugmail: http://oss.sgi.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. From nscott@aconex.com Mon Jan 11 21:13:29 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0C3DTKf207409 for ; Mon, 11 Jan 2010 21:13:29 -0600 X-ASG-Debug-ID: 1263266062-3eef01590000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 518E71C442E6 for ; Mon, 11 Jan 2010 19:14:23 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id POeKTFztBtjVhTsH for ; Mon, 11 Jan 2010 19:14:23 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 1405C6E9A30 for ; Tue, 12 Jan 2010 14:14:21 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id zJ1b50JUeqYon3WB for ; Tue, 12 Jan 2010 14:14:21 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id B0DEAA5011B for ; Tue, 12 Jan 2010 14:12:09 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 005DE48834A for ; Tue, 12 Jan 2010 14:14:20 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CaxliN93oWXi for ; Tue, 12 Jan 2010 14:14:17 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 20DDB488348 for ; Tue, 12 Jan 2010 14:14:17 +1100 (EST) Date: Tue, 12 Jan 2010 14:14:17 +1100 (EST) From: Nathan Scott To: pcp@oss.sgi.com Message-ID: <403065975.1692231263266057001.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcp updates Subject: pcp updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1263266064 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.19567 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean [Also merged Martins and Kens current dev branches in here] Changes committed to git://oss.sgi.com/nathans/pcp.git src/libpcp/src/GNUmakefile | 2=20 src/pmdas/GNUmakefile | 2=20 src/pmdas/linux/numa_meminfo.c | 80 +++++++++++++----------- src/pmdas/mmv/mmv.c | 5 - =20 src/pmdas/postfix/.gitignore | 2 =20 src/pmdas/postfix/GNUmakefile | 45 +++++++++ =20 src/pmdas/postfix/Install | 27 +++++ =20 src/pmdas/postfix/Remove | 25 +++++ =20 src/pmdas/postfix/pmdapostfix.pl | 177 ++++++++++++++++++++++++++++++++++= +++++ src/pmns/stdpmid.pcp | 1 = =20 10 files changed, 319 insertions(+), 47 deletions(-) = =20 commit 81c2f6ab35fff6b1391f9be7e7a6fcf8bc827993 Author: Nathan Scott Date: Tue Jan 12 14:00:37 2010 +1100 Remove unwanted info log message in pmcd log when using a DSO MMV. commit a96a8dc6e00dfa8d921d2ac714f4c7978c1599a8 Author: Nathan Scott Date: Tue Jan 12 13:59:24 2010 +1100 Minor 64/32 bit cleanup in the Linux NUMA stats. Resolves warnings of this nature from gcc: numa_meminfo.c:69: warning: integer constant is too large for =E2=80=98= long=E2=80=99 type numa_meminfo.c:70: warning: integer constant is too large for =E2=80=98= long=E2=80=99 type numa_meminfo.c:71: warning: integer constant is too large for =E2=80=98= long=E2=80=99 type numa_meminfo.c:72: warning: integer constant is too large for =E2=80=98= long=E2=80=99 type numa_meminfo.c:73: warning: integer constant is too large for =E2=80=98= long=E2=80=99 type numa_meminfo.c:74: warning: integer constant is too large for =E2=80=98= long=E2=80=99 type Also make use of the field: C99(?) struct init notation for more clarity on which of the fields are being set statically. commit 99a412ad9d9752a72555856ecaa628d2a4280535 Author: Josef 'Jeff' Sipek Date: Tue Jan 12 13:08:36 2010 +1100 Add a new PMDA exporting the Postfix queue lengths commit 6ca00c9fbdc254dca8984d4dc4d5792e5f938ebf Author: Nathan Scott Date: Tue Jan 12 12:51:21 2010 +1100 Add MMV into the set of DSOs local context works on automatically. From nscott@aconex.com Mon Jan 11 21:14:45 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0C3EiMT207536 for ; Mon, 11 Jan 2010 21:14:45 -0600 X-ASG-Debug-ID: 1263266138-489a00d20000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id C229D1C44338 for ; Mon, 11 Jan 2010 19:15:39 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id ozXcmKZWIF3d5Erb for ; Mon, 11 Jan 2010 19:15:39 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id B5A93185C73; Tue, 12 Jan 2010 14:15:37 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id vquTNW4BC7hXJ227; Tue, 12 Jan 2010 14:15:37 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 5E351A5011B; Tue, 12 Jan 2010 14:13:26 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id A1A81488349; Tue, 12 Jan 2010 14:15:37 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uTYncOvPaVpH; Tue, 12 Jan 2010 14:15:32 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id EA831488348; Tue, 12 Jan 2010 14:15:32 +1100 (EST) Date: Tue, 12 Jan 2010 14:15:32 +1100 (EST) From: Nathan Scott To: "Josef 'Jeff' Sipek" Cc: pcp@oss.sgi.com Message-ID: <1098379408.1692281263266132730.JavaMail.root@mail-au.aconex.com> In-Reply-To: <20091230073528.GK25955@josefsipek.net> X-ASG-Orig-Subj: Re: [PATCH] Add a new PMDA exporting the Postfix queue lengths Subject: Re: [PATCH] Add a new PMDA exporting the Postfix queue lengths MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1263266139 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.19567 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ----- "Josef 'Jeff' Sipek" wrote: > ... Looks good to me, I've merged into my dev branch. cheers. -- Nathan From nscott@aconex.com Mon Jan 11 21:17:01 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0C3H02e207802 for ; Mon, 11 Jan 2010 21:17:01 -0600 X-ASG-Debug-ID: 1263266274-3b99007c0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 44C201242DAD for ; Mon, 11 Jan 2010 19:17:54 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id lH05iql607nwpAT5 for ; Mon, 11 Jan 2010 19:17:54 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 605AD88BD7D; Tue, 12 Jan 2010 14:17:52 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id fC5ERNhRGycM0DvA; Tue, 12 Jan 2010 14:17:52 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 077E7A5011B; Tue, 12 Jan 2010 14:15:41 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 4B27648834A; Tue, 12 Jan 2010 14:17:52 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C+L6V2PLXlTx; Tue, 12 Jan 2010 14:17:47 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 950B5488348; Tue, 12 Jan 2010 14:17:47 +1100 (EST) Date: Tue, 12 Jan 2010 14:17:47 +1100 (EST) From: Nathan Scott To: Martin Hicks Cc: pcp@oss.sgi.com Message-ID: <1097944767.1692491263266267448.JavaMail.root@mail-au.aconex.com> In-Reply-To: <20091222132701.GI8018@alcatraz.americas.sgi.com> X-ASG-Orig-Subj: Re: [pcp] Linux NUMA memory stats Subject: Re: [pcp] Linux NUMA memory stats MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1263266276 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.19568 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ----- "Martin Hicks" wrote: > On Mon, Dec 21, 2009 at 05:59:14PM -0600, Martin Hicks wrote: > > > > I just pushed out an enhancement to the linux PMDA that adds the > NUMA > > memory statistics from > /sys/devices/system/node/node*/{meminfo,numastat} > > FWIW, reviewed it & it looks good. > I think the only change I need is to return quietly if the node > directory isn't present: *nod* ... current code works fine on my laptop with no numa stats, will kick the tyres on a machine with some numa stats too when I get a chance. I tidied up a minor compiler warning after merging in my tree btw, just a 32 bit-ism. cheers. -- Nathan From nscott@aconex.com Mon Jan 11 22:15:18 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0C4FI49214234 for ; Mon, 11 Jan 2010 22:15:18 -0600 X-ASG-Debug-ID: 1263269771-3bf202be0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id D371B12F1B3D for ; Mon, 11 Jan 2010 20:16:12 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id PY70h6sHKviiH2fy for ; Mon, 11 Jan 2010 20:16:12 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id C8CC01861A6 for ; Tue, 12 Jan 2010 15:16:10 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id auD3Re22bx8YGHh0 for ; Tue, 12 Jan 2010 15:16:10 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 6E2D0A5011B for ; Tue, 12 Jan 2010 15:13:59 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id B3D7C488353 for ; Tue, 12 Jan 2010 15:16:10 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4U5lOY1fb85f for ; Tue, 12 Jan 2010 15:16:06 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id B580948834A for ; Tue, 12 Jan 2010 15:16:06 +1100 (EST) Date: Tue, 12 Jan 2010 15:16:06 +1100 (EST) From: Nathan Scott To: pcp Message-ID: <1390067172.1694481263269766537.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcp-gui changes Subject: pcp-gui changes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1263269772 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.19572 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Changes committed to git://oss.sgi.com/nathans/pcp-gui.git src/view/text.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ac19e8e535ad08f1fce5509e60e8001d1732b3bd Author: Andrew Wansink Date: Tue Jan 12 15:14:14 2010 +1100 broken build ubuntu 9.10 Ubuntu 9.10 defines strbrk to return const char * if the first argument to strpbrk via a call from c++ is const char *. From nscott@aconex.com Mon Jan 11 22:18:08 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0C4I8Oo214593 for ; Mon, 11 Jan 2010 22:18:08 -0600 X-ASG-Debug-ID: 1263269942-50a302750000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 1BD8415B7D8 for ; Mon, 11 Jan 2010 20:19:03 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id KqI9OSpHdjK9Axd8 for ; Mon, 11 Jan 2010 20:19:03 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 718AE1863C8; Tue, 12 Jan 2010 15:19:01 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id 18d27cXow04Vujok; Tue, 12 Jan 2010 15:19:01 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 1621BA5011B; Tue, 12 Jan 2010 15:16:50 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 5A0CD488351; Tue, 12 Jan 2010 15:19:01 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g9rKTsjw0OGp; Tue, 12 Jan 2010 15:18:57 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 303EF48834A; Tue, 12 Jan 2010 15:18:57 +1100 (EST) Date: Tue, 12 Jan 2010 15:18:57 +1100 (EST) From: Nathan Scott To: Andrew Wansink Cc: pcp@oss.sgi.com Message-ID: <1562754194.1694721263269937090.JavaMail.root@mail-au.aconex.com> In-Reply-To: <20091224053442.GA21019@dull> X-ASG-Orig-Subj: Re: [pcp] broken build ubuntu 9.10 Subject: Re: [pcp] broken build ubuntu 9.10 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1263269944 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.19571 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ----- "Andrew Wansink" wrote: > commit 27a209d20b1468992b00a520d410bf205e659cc5 > Author: Andrew Wansink > Date: Thu Dec 24 14:43:03 2009 +1100 > > Ubuntu 9.10 defines strbrk to return const char * if the first > argument to strpbrk via a call from c++ is const char *. Looks good to me, thanks! -- Nathan From mort@sgi.com Tue Jan 12 07:22:49 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0CDMnfV017228 for ; Tue, 12 Jan 2010 07:22:49 -0600 Received: from attica.americas.sgi.com (attica.americas.sgi.com [128.162.236.44]) by relay1.corp.sgi.com (Postfix) with ESMTP id 0ADC38F8103; Tue, 12 Jan 2010 05:23:41 -0800 (PST) Received: by attica.americas.sgi.com (Postfix, from userid 44682) id 9285AA243300; Tue, 12 Jan 2010 07:23:41 -0600 (CST) Date: Tue, 12 Jan 2010 07:23:41 -0600 From: Martin Hicks To: Nathan Scott Cc: pcp@oss.sgi.com Subject: Re: [pcp] Linux NUMA memory stats Message-ID: <20100112132341.GX6303@alcatraz.americas.sgi.com> References: <20091222132701.GI8018@alcatraz.americas.sgi.com> <1097944767.1692491263266267448.JavaMail.root@mail-au.aconex.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1097944767.1692491263266267448.JavaMail.root@mail-au.aconex.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Tue, Jan 12, 2010 at 02:17:47PM +1100, Nathan Scott wrote: > > ----- "Martin Hicks" wrote: > > > On Mon, Dec 21, 2009 at 05:59:14PM -0600, Martin Hicks wrote: > > > > > > I just pushed out an enhancement to the linux PMDA that adds the > > NUMA > > > memory statistics from > > /sys/devices/system/node/node*/{meminfo,numastat} > > > > > FWIW, reviewed it & it looks good. > > > I think the only change I need is to return quietly if the node > > directory isn't present: > > *nod* ... current code works fine on my laptop with no numa stats, > will kick the tyres on a machine with some numa stats too when I > get a chance. > > I tidied up a minor compiler warning after merging in my tree btw, > just a 32 bit-ism. Great, thanks for the review Nathan. mh From nscott@aconex.com Tue Jan 12 23:17:14 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0D5HESG119351 for ; Tue, 12 Jan 2010 23:17:14 -0600 X-ASG-Debug-ID: 1263359888-39b702ad0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 1F834124764C for ; Tue, 12 Jan 2010 21:18:08 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id dsPqoUFH5xiz0Pbn for ; Tue, 12 Jan 2010 21:18:08 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 8616A190561 for ; Wed, 13 Jan 2010 16:18:06 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id x8CKk3AvW9nUvL2Y for ; Wed, 13 Jan 2010 16:18:06 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 98DC9A50133 for ; Wed, 13 Jan 2010 16:15:54 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 730CB488309 for ; Wed, 13 Jan 2010 16:18:06 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z5iuMsmL3KPZ for ; Wed, 13 Jan 2010 16:18:02 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id D2F23488300 for ; Wed, 13 Jan 2010 16:17:57 +1100 (EST) Date: Wed, 13 Jan 2010 16:17:51 +1100 (EST) From: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1788435825.1728381263359871339.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcp updates Subject: pcp updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1263359890 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.19660 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Changes committed to git://oss.sgi.com/nathans/pcp.git src/pmdas/mmv/GNUmakefile | 5 ++-- src/pmdas/mmv/README | 51 ---------------------------------------------- src/pmdas/mmv/pmns | 5 ---- src/pmdas/mmv/root | 10 --------- src/pmdas/mmv/root_mmv | 13 +++++++++++ 5 files changed, 16 insertions(+), 68 deletions(-) commit 4cad375ebe6cb4669dde51fd1fab19ca6f59c292 Author: Nathan Scott Date: Wed Jan 13 16:16:16 2010 +1100 Finish making pmdammv (dso) available automatically. The namespace needed to have the same treatment that the pmcd and platform PMDAs give it - automatic install of a root_mmv file into the pmns directory for the binary pmns build post-install. This makes virgin installs correctly handle MMV automatically, not just those for people who'd already ./Install'ed MMV at some point before, manually. From nscott@aconex.com Wed Jan 13 00:22:55 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0D6Mssg126635 for ; Wed, 13 Jan 2010 00:22:54 -0600 X-ASG-Debug-ID: 1263363829-0a9b00580000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 4E7791247688 for ; Tue, 12 Jan 2010 22:23:49 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id qXSfeJx6pklQIYx5 for ; Tue, 12 Jan 2010 22:23:49 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 6618F190410; Wed, 13 Jan 2010 17:23:48 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id zDIX0R07AxZ96P05; Wed, 13 Jan 2010 17:23:48 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 6C396A50133; Wed, 13 Jan 2010 17:21:36 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 4FB06488315; Wed, 13 Jan 2010 17:23:48 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WvYg93qo7lcq; Wed, 13 Jan 2010 17:23:43 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 99422488312; Wed, 13 Jan 2010 17:23:43 +1100 (EST) Date: Wed, 13 Jan 2010 17:23:41 +1100 (EST) From: Nathan Scott To: kenj Cc: pcp@oss.sgi.com Message-ID: <1990590547.1731711263363821866.JavaMail.root@mail-au.aconex.com> In-Reply-To: <1809996987.1731631263363638107.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: dbpmda dynamic PMNS oddity Subject: dbpmda dynamic PMNS oddity MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1263363830 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.19664 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Hi Ken, Seeing something strange in dbpmda when checking out some new MMV client code - the initial fetch failure is the issue... 17:20 nathans@verge /source/git/pcp/src/pmdas/mmv 308> dbpmda dbpmda> open pipe pmdammv Start pmdammv PMDA: ./pmdammv dbpmda> fetch mmv.test.strings PMID(s): 70.*.* pmResult dump from 0x9d51170 timestamp: 0.000000 10:00:00.000 numpmid: 1 70.*.* (): Unknown or illegal metric identifier dbpmda> pmid mmv.test.strings Metric: mmv.test.strings 70.2.6 dbpmda> fetch 70.2.6 Warning: PMID (70.2.6) is not defined in the PMNS PMID(s): 70.2.6 pmResult dump from 0x9d511d8 timestamp: 0.000000 10:00:00.000 numpmid: 1 70.2.6 (): numval: 2 valfmt: 1 vlist[]: inst [0 or ???] value "00oo00" inst [1 or ???] value "" dbpmda> name 70.2.6 PMID: 70.2.6 mmv.test.strings dbpmda> (this is with /var/tmp/mmv/test as created by pcpqa/src-oss/mmv_genstats) Any ideas? Is there meant to be an initial pmid lookup in the fetch case in dbpmda or is the above behaviour as-expected? thanks! -- Nathan From kenj@internode.on.net Wed Jan 13 13:49:00 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0DJmxPH183353 for ; Wed, 13 Jan 2010 13:48:59 -0600 X-ASG-Debug-ID: 1263412193-2f69008b0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 8F1EAF049E3 for ; Wed, 13 Jan 2010 11:49:53 -0800 (PST) Received: from mail.internode.on.net (bld-mail18.adl2.internode.on.net [150.101.137.103]) by cuda.sgi.com with ESMTP id AGLxHgoRzY1QDRKZ for ; Wed, 13 Jan 2010 11:49:53 -0800 (PST) Received: from [192.168.1.100] (unverified [118.209.137.163]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11504358-1927428 for multiple; Thu, 14 Jan 2010 06:19:51 +1030 (CDT) X-ASG-Orig-Subj: Re: dbpmda dynamic PMNS oddity Subject: Re: dbpmda dynamic PMNS oddity From: Ken McDonell Reply-To: kenj@internode.on.net To: Nathan Scott Cc: pcp@oss.sgi.com In-Reply-To: <1990590547.1731711263363821866.JavaMail.root@mail-au.aconex.com> References: <1990590547.1731711263363821866.JavaMail.root@mail-au.aconex.com> Content-Type: text/plain; charset="UTF-8" Date: Thu, 14 Jan 2010 06:49:43 +1100 Message-ID: <1263412183.9358.30.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail18.adl2.internode.on.net[150.101.137.103] X-Barracuda-Start-Time: 1263412195 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.19709 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean G'day Nathan. Can you please confirm something? I'm guessing you have the mmv pmda installed, and the pmns contains an entry like mmv 70:*:* because without that, the first fetch will return dbpmda> fetch mmv.test.strings ^ at or near here Error: Unknown metric name Type 'help' for a list of commands. rather than than translating the name to the PMID 70.*.* and then failing the fetch. Now if this is the case, then it is simply a bug ... dbpmda just calls pmLookupName and does not do the while pmcd thing of ... oh! a dynamic PMID, I need to send it off to the pmda. The second fetch works because you've used an explicit PMID and skipped the pmLookupName call in dbpmda. I'll see what it will take to fix this. On Wed, 2010-01-13 at 17:23 +1100, Nathan Scott wrote: > Hi Ken, > > Seeing something strange in dbpmda when checking out some new > MMV client code - the initial fetch failure is the issue... > > 17:20 nathans@verge /source/git/pcp/src/pmdas/mmv 308> dbpmda > dbpmda> open pipe pmdammv > Start pmdammv PMDA: ./pmdammv > dbpmda> fetch mmv.test.strings > PMID(s): 70.*.* > pmResult dump from 0x9d51170 timestamp: 0.000000 10:00:00.000 numpmid: 1 > 70.*.* (): Unknown or illegal metric identifier > dbpmda> pmid mmv.test.strings > Metric: mmv.test.strings > 70.2.6 > dbpmda> fetch 70.2.6 > Warning: PMID (70.2.6) is not defined in the PMNS > PMID(s): 70.2.6 > pmResult dump from 0x9d511d8 timestamp: 0.000000 10:00:00.000 numpmid: 1 > 70.2.6 (): numval: 2 valfmt: 1 vlist[]: > inst [0 or ???] value "00oo00" > inst [1 or ???] value "" > dbpmda> name 70.2.6 > PMID: 70.2.6 > mmv.test.strings > dbpmda> > > (this is with /var/tmp/mmv/test as created by pcpqa/src-oss/mmv_genstats) > > Any ideas? Is there meant to be an initial pmid lookup in the fetch case > in dbpmda or is the above behaviour as-expected? > > thanks! > From nscott@aconex.com Wed Jan 13 16:24:41 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0DMOeoO195415 for ; Wed, 13 Jan 2010 16:24:40 -0600 X-ASG-Debug-ID: 1263421535-028403980000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id CCF7BED5566 for ; Wed, 13 Jan 2010 14:25:35 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id Rvu9IIAy5nYJakeU for ; Wed, 13 Jan 2010 14:25:35 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id EE81D88C3A4; Thu, 14 Jan 2010 09:25:33 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id vhg6P1w9CwpxRdAL; Thu, 14 Jan 2010 09:25:33 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 9F66BA50110; Thu, 14 Jan 2010 09:23:21 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id E23D0488325; Thu, 14 Jan 2010 09:25:33 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gHLzIQLDfcTb; Thu, 14 Jan 2010 09:25:29 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 37C55488324; Thu, 14 Jan 2010 09:25:29 +1100 (EST) Date: Thu, 14 Jan 2010 09:25:29 +1100 (EST) From: Nathan Scott To: kenj@internode.on.net Cc: pcp@oss.sgi.com Message-ID: <1436138626.1742291263421529089.JavaMail.root@mail-au.aconex.com> In-Reply-To: <1263412183.9358.30.camel@bozo.localdomain> X-ASG-Orig-Subj: Re: dbpmda dynamic PMNS oddity Subject: Re: dbpmda dynamic PMNS oddity MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1263421536 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.19721 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ----- "Ken McDonell" wrote: > G'day Nathan. > > Can you please confirm something? I'm guessing you have the mmv pmda > installed, and the pmns contains an entry like > mmv 70:*:* Yep, certainly do. > Now if this is the case, then it is simply a bug ... dbpmda just > calls > pmLookupName and does not do the while pmcd thing of ... oh! a > dynamic > PMID, I need to send it off to the pmda. Yeah, figured something like that might be whats happening. > The second fetch works because you've used an explicit PMID and > skipped the pmLookupName call in dbpmda. *nod* > I'll see what it will take to fix this. Great, thanks! -- Nathan From kenj@internode.on.net Thu Jan 14 03:16:08 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0E9G8hw245512 for ; Thu, 14 Jan 2010 03:16:08 -0600 X-ASG-Debug-ID: 1263460622-6186000c0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 7DE681DB0F74 for ; Thu, 14 Jan 2010 01:17:02 -0800 (PST) Received: from mail.internode.on.net (bld-mail18.adl2.internode.on.net [150.101.137.103]) by cuda.sgi.com with ESMTP id JOLzg0eEuvq2oXBL for ; Thu, 14 Jan 2010 01:17:02 -0800 (PST) Received: from [192.168.1.100] (unverified [118.209.137.163]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11513995-1927428 for ; Thu, 14 Jan 2010 19:47:01 +1030 (CDT) X-ASG-Orig-Subj: pcpqa updates Subject: pcpqa updates From: Ken McDonell Reply-To: kenj@internode.on.net To: pcp@oss.sgi.com Content-Type: text/plain; charset="UTF-8" Date: Thu, 14 Jan 2010 20:16:52 +1100 Message-ID: <1263460612.9358.31.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail18.adl2.internode.on.net[150.101.137.103] X-Barracuda-Start-Time: 1263460624 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0509 1.0000 -1.6944 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.69 X-Barracuda-Spam-Status: No, SCORE=-1.69 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.19764 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Tests corner case found by Nathan with dbpmda and dynamic metrics. Changes committed to git://oss.sgi.com/pcp/pcpqa.git 213 | 40 +++++++++++++++++++++++++++++++++++-- 213.out | 68 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ group | 4 +-- 3 files changed, 108 insertions(+), 4 deletions(-) commit 416fe55db0ebaba10ebad874ef2e8d9d932075ce Author: Ken McDonell Date: Thu Jan 14 20:13:20 2010 +1100 213 dbpmda and dynamic metrics Added tests with the mmv pmda to exercise the corner case of name -> pmid translation that was not working for dynamic metrics. From kenj@internode.on.net Thu Jan 14 03:23:35 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0E9NZYC246319 for ; Thu, 14 Jan 2010 03:23:35 -0600 X-ASG-Debug-ID: 1263461069-061503110000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id C74001514578 for ; Thu, 14 Jan 2010 01:24:30 -0800 (PST) Received: from mail.internode.on.net (bld-mail12.adl6.internode.on.net [150.101.137.97]) by cuda.sgi.com with ESMTP id hz1vaxi9DGXrhSfs for ; Thu, 14 Jan 2010 01:24:30 -0800 (PST) Received: from [192.168.1.100] (unverified [118.209.137.163]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11547486-1927428 for ; Thu, 14 Jan 2010 19:54:28 +1030 (CDT) X-ASG-Orig-Subj: pcp updates Subject: pcp updates From: Ken McDonell Reply-To: kenj@internode.on.net To: pcp@oss.sgi.com Content-Type: text/plain; charset="UTF-8" Date: Thu, 14 Jan 2010 20:24:20 +1100 Message-ID: <1263461060.9358.33.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail12.adl6.internode.on.net[150.101.137.97] X-Barracuda-Start-Time: 1263461071 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.02 X-Barracuda-Spam-Status: No, SCORE=-1.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M, BSF_RULE_7582B X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.19765 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M 0.50 BSF_RULE_7582B Custom Rule 7582B X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean The dbpmda one fixes Nathan's problem reported yesterday. The others are the tail end of the derived metrics changes to address some corner cases that are unlikely to be seen with well-behaved PMDAs. Changes committed to git://oss.sgi.com/kenj/pcp.git dev src/dbpmda/src/gram.y | 45 +++++ src/libpcp/src/derive.c | 54 +++--- src/libpcp/src/derive.h | 26 +-- src/libpcp/src/derive_fetch.c | 334 +++++++++++++++--------------------------- src/libpcp/src/pmns.c | 10 + src/pmdas/sample/help | 18 ++ src/pmdas/sample/pmns | 19 ++ src/pmdas/sample/src/sample.c | 315 ++++++++++++++++++++++++++------------- 8 files changed, 453 insertions(+), 368 deletions(-) commit 29b0c31dad838d8f1f485b5749c74706a8f409e1 Author: Ken McDonell Date: Thu Jan 14 20:18:35 2010 +1100 dbpmda fix for name lookup and dynamic metrics As reported by Nathan, this fixes a problem where dbpmda is given a metric name, and the translation to a pmid does not follow the pmcd-like behaviour and call on the pmda for assistance when the name is within a pmns subtree rooted at a dynamic metric. commit 7174480b8dc5d24acd3e6fa0116b51c602811c99 Author: Ken McDonell Date: Thu Jan 7 06:51:43 2010 +1100 pmLookupName - refine error handling with derived metrics The return status is a little tricky as we make a second attempt for a derived metric lookup for each unknown name if the original lookup fails for any metric name, leading to a possible multiplicity of error statuses ... prefer the status from receive_names(), unless all of the remaining unknown names are resolved by __dmgetpmid() in which case success (numpmid) is the right return status. commit 40468e684637f8ab24f4da84d111163ac79b2462 Author: Ken McDonell Date: Tue Jan 5 08:03:03 2010 +1100 sample PMDA - add sample.scramble.* Some strange metrics with ill-behaved instance domains and in which instances come and go, and the order of the returned instances is random ... all based on the same indom as sample.bin Also added a reset button (sample.scramble.version) to make the behaviour repeatable for QA via pmstore. commit c8f9ef4e2aee94c9b812b1d815d0c1f9b9c161a3 Author: Ken McDonell Date: Tue Jan 5 08:01:09 2010 +1100 Derived metrics - minor fix up for fetch Correct corner cases when instances are missing, added and the order of instances is random between consecutive pmFetch calls. Also added some more verbose diags around this code. All triggered by the bizarre sample.scramble metrics recently added to the sample PMDA. commit 44e7728d3b34ad185c4a924711e6d994b1e0966e Author: Ken McDonell Date: Mon Jan 4 08:06:34 2010 +1100 Derived metrics - refinement After gcov analysis and some expanded coverage in the QA suite, there is some dead code removal here, and additional metrics in the sample PMDA. From nscott@aconex.com Thu Jan 14 18:49:52 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0F0nqFs051630 for ; Thu, 14 Jan 2010 18:49:52 -0600 X-ASG-Debug-ID: 1263516647-0cfe03190000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 565251C50C97 for ; Thu, 14 Jan 2010 16:50:48 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id qBGYG3Ytny3qZfg5 for ; Thu, 14 Jan 2010 16:50:48 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 9BBD519DE85; Fri, 15 Jan 2010 11:50:45 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id IIUVhfzxkYqaX47g; Fri, 15 Jan 2010 11:50:45 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id A0FEEA5011B; Fri, 15 Jan 2010 11:48:32 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 7667E48832E; Fri, 15 Jan 2010 11:50:45 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TVvxqADlSkRm; Fri, 15 Jan 2010 11:50:40 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id BE62C488328; Fri, 15 Jan 2010 11:50:40 +1100 (EST) Date: Fri, 15 Jan 2010 11:50:40 +1100 (EST) From: Nathan Scott To: kenj@internode.on.net Cc: pcp@oss.sgi.com Message-ID: <1832547790.1785231263516640684.JavaMail.root@mail-au.aconex.com> In-Reply-To: <1282477076.1784981263516544438.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: Re: [pcp] pcp updates Subject: Re: [pcp] pcp updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1263516649 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.19824 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ----- "Ken McDonell" wrote: > The dbpmda one fixes Nathan's problem reported yesterday. Thanks Ken, that works nicely now. cheers. -- Nathan From makc@iinet.net.au Sun Jan 17 01:00:52 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0H70pcS252886 for ; Sun, 17 Jan 2010 01:00:52 -0600 X-ASG-Debug-ID: 1263711706-1e5c039b0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from outbound.icp-qv1-irony-out5.iinet.net.au (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 66C601C57324 for ; Sat, 16 Jan 2010 23:01:47 -0800 (PST) Received: from outbound.icp-qv1-irony-out5.iinet.net.au (outbound.icp-qv1-irony-out5.iinet.net.au [203.59.1.105]) by cuda.sgi.com with ESMTP id K3TUi7A3D1gYTPz1 for ; Sat, 16 Jan 2010 23:01:47 -0800 (PST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAC5FUkvL2Rwk/2dsb2JhbADUVYQyBA X-IronPort-AV: E=Sophos;i="4.49,291,1262534400"; d="scan'208";a="93162802" Received: from unknown (HELO alma.crabbed.net) ([203.217.28.36]) by outbound.icp-qv1-irony-out5.iinet.net.au with ESMTP; 17 Jan 2010 15:01:44 +0800 Received: by alma.crabbed.net (Postfix, from userid 501) id D1296C4D19; Sun, 17 Jan 2010 18:01:43 +1100 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19282.46551.507836.546739@iinet.net.au> Date: Sun, 17 Jan 2010 18:01:43 +1100 From: Max Matveev To: pcp@oss.sgi.com X-ASG-Orig-Subj: pcp updates Subject: pcp updates X-Mailer: VM 7.17 under 21.4 (patch 19) "Constant Variable" XEmacs Lucid X-Barracuda-Connect: outbound.icp-qv1-irony-out5.iinet.net.au[203.59.1.105] X-Barracuda-Start-Time: 1263711709 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20033 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean A bunch of changes by Denis Loginov to add per-disk information on Solaris and some small stuff to make pmie work on Solaris. This is on top of current dev branch from the main tree. The following changes since commit 7a2edea23d4d6c7c3a40601bf20ced386024188f: Nathan Scott (1): Bump version in dev branch. are available in the git repository at: git://oss.sgi.com/makc/pcp diskstat Denis Loginov (6): Add state and state_aux metrics for solaris zpool Fix /etc/init.d/pmie for Opensolaris: do not call is_chkconfig_all; Add metrics zpool.state_combined and zpool_perdisk.state_combined Make perdisk stats part of the zpool hierarchy In Solaris PMDAs, make zpool[.perdisk].state a string. is_chkconfig_on() returns true on Solaris Max Matveev (1): Make pmie_check work on Solaris src/cpan/LogSummary/.gitignore | 1 + src/cpan/MMV/.gitignore | 1 + src/cpan/PMDA/.gitignore | 1 + src/include/pcp.conf.in | 2 +- src/pmcd/rc-proc.sh | 2 +- src/pmdas/solaris/GNUmakefile | 6 +- src/pmdas/solaris/common.h | 6 + src/pmdas/solaris/data.c | 45 +++++- src/pmdas/solaris/help | 9 + src/pmdas/solaris/pmns.zpool | 3 + src/pmdas/solaris/pmns.zpool_perdisk | 16 ++ src/pmdas/solaris/root | 1 + src/pmdas/solaris/zpool.c | 18 ++- src/pmdas/solaris/zpool_perdisk.c | 289 ++++++++++++++++++++++++++++++++++ src/pmie/pmie_check.sh | 2 +- 15 files changed, 389 insertions(+), 13 deletions(-) create mode 100644 src/pmdas/solaris/pmns.zpool_perdisk create mode 100644 src/pmdas/solaris/zpool_perdisk.c From nscott@aconex.com Sun Jan 17 18:23:10 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0I0NAsJ058141 for ; Sun, 17 Jan 2010 18:23:10 -0600 X-ASG-Debug-ID: 1263774246-697f039d0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id D56DB16D8AC for ; Sun, 17 Jan 2010 16:24:07 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id ZA2tyCV7nIPse3M0 for ; Sun, 17 Jan 2010 16:24:07 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 1EB3C6EEC36 for ; Mon, 18 Jan 2010 11:24:05 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id FU1Rod40axfxZPyP for ; Mon, 18 Jan 2010 11:24:05 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 8D619A5011B for ; Mon, 18 Jan 2010 11:21:50 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 04EAF488356 for ; Mon, 18 Jan 2010 11:24:05 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1VF4Lx5+k0dt for ; Mon, 18 Jan 2010 11:24:01 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 4F1AA48834A for ; Mon, 18 Jan 2010 11:24:01 +1100 (EST) Date: Mon, 18 Jan 2010 11:24:00 +1100 (EST) From: Nathan Scott To: pcp@oss.sgi.com Message-ID: <2102876699.1821741263774240601.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcp updates Subject: pcp updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1263774248 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20102 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Changes committed to git://oss.sgi.com/nathans/pcp.git src/pmdas/mmv/GNUmakefile | 4 ++-- src/pmdas/mmv/Install | 2 +- src/pmdas/mmv/mmv.c | 12 ++++-------- src/pmlogsummary/pmwtf.sh | 6 +++++- 4 files changed, 12 insertions(+), 12 deletions(-) commit 46b24286652e3ff553c03ce6279353d5afb96f2b Author: Nathan Scott Date: Mon Jan 18 11:22:30 2010 +1100 Add in -Z option to pmwtf, to pass through to pmlogsummary. commit 948f4420146e6440308e02e6e487f99dff7ebbbe Author: Nathan Scott Date: Mon Jan 18 11:21:46 2010 +1100 Reduce memory footprint of pmdammv ever-so-slightly, ditch an unused field. commit 6574c43d85cddcd1a3ec0157b13167b54ce724e3 Author: Nathan Scott Date: Mon Jan 18 11:20:50 2010 +1100 MMV is actually pmda api version 4 now, mark it as such (benign though). commit bd10722392bd2c1a681f2e5d41fa1cc90355076e Author: Nathan Scott Date: Mon Jan 18 11:20:19 2010 +1100 Use different install.sh syntax now in MMV, one-file-only mode. From nscott@aconex.com Sun Jan 17 23:48:03 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0I5m3et077413 for ; Sun, 17 Jan 2010 23:48:03 -0600 X-ASG-Debug-ID: 1263793739-2d3c03550000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 2A5961C58B7A for ; Sun, 17 Jan 2010 21:48:59 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id v4twDEumetats5QA for ; Sun, 17 Jan 2010 21:48:59 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id B825D6EF079 for ; Mon, 18 Jan 2010 16:48:57 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id yDjZEd63aXh9LyEx for ; Mon, 18 Jan 2010 16:48:57 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 17F16A5011B for ; Mon, 18 Jan 2010 16:46:43 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id AB428488356 for ; Mon, 18 Jan 2010 16:48:57 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xcvg6U-L4kML for ; Mon, 18 Jan 2010 16:48:53 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id AFF0248834A for ; Mon, 18 Jan 2010 16:48:53 +1100 (EST) Date: Mon, 18 Jan 2010 16:48:53 +1100 (EST) From: Nathan Scott To: pcp Message-ID: <911890627.1844371263793733570.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcpqa updates Subject: pcpqa updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1263793742 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20121 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Changes committed to git://oss.sgi.com/pcp/pcpqa.git src-oss/GNUmakefile | 9 +++-- src-oss/mmv_poke.c | 92 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 99 insertions(+), 2 deletions(-) commit 010cb6becc22f1403f925af677357c8bd0ef2f54 Author: Nathan Scott Date: Mon Jan 18 16:47:53 2010 +1100 Add test program for modifying MMV data file internals. From ajwans@evostor.com Mon Jan 18 01:32:16 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX, J_CHICKENPOX_31,J_CHICKENPOX_41,J_CHICKENPOX_43,J_CHICKENPOX_73,URIBL_BLACK autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0I7WFd0086679 for ; Mon, 18 Jan 2010 01:32:15 -0600 X-ASG-Debug-ID: 1263799992-2cdd00530000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from relay.ihostexchange.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 4481C15164CB for ; Sun, 17 Jan 2010 23:33:13 -0800 (PST) Received: from relay.ihostexchange.net (relay.ihostexchange.net [66.46.182.54]) by cuda.sgi.com with ESMTP id pq1t77HB4EhfIWvO for ; Sun, 17 Jan 2010 23:33:13 -0800 (PST) Received: from HUB103.ihostexchange.net (66.46.182.53) by HUB104.ihostexchange.net (66.46.182.54) with Microsoft SMTP Server (TLS) id 8.1.393.1; Mon, 18 Jan 2010 02:33:11 -0500 Received: from mailhost.internal (203.206.165.193) by smtp.ihostexchange.net (66.46.182.50) with Microsoft SMTP Server (TLS) id 8.1.393.1; Mon, 18 Jan 2010 02:33:10 -0500 Received: from dull (unknown [10.222.0.6]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mailhost.internal (Postfix) with ESMTPSA id CE22830911 for ; Mon, 18 Jan 2010 18:33:03 +1100 (EST) Received: by dull (sSMTP sendmail emulation); Mon, 18 Jan 2010 18:33:06 +1100 From: Andrew Wansink Date: Mon, 18 Jan 2010 18:33:06 +1100 To: pcp@oss.sgi.com X-ASG-Orig-Subj: readline support for dbpmda Subject: readline support for dbpmda Message-ID: <20100118073306.GD28197@dull> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) X-Barracuda-Connect: relay.ihostexchange.net[66.46.182.54] X-Barracuda-Start-Time: 1263799994 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0067 1.0000 -1.9772 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.98 X-Barracuda-Spam-Status: No, SCORE=-1.98 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20127 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean commit 28784aaf1e9cfad19f23a9669681a48d91e6c030 Author: Andrew Wansink Date: Mon Jan 18 18:30:08 2010 +1100 Add readline support to dbpdma. diff --git a/configure.in b/configure.in index 5554437..cd016db 100644 --- a/configure.in +++ b/configure.in @@ -1726,6 +1726,20 @@ int main () { } ], AC_DEFINE(HAVE_STRFTIME_z) AC_MSG_RESULT(yes) , AC_MSG_RESULT(no), 0) +dnl check if readline needs -lreadline to work +lib_for_readline= +AC_CHECK_FUNCS(readline) +if test $ac_cv_func_readline = no +then + AC_CHECK_LIB(readline, readline) + if test $ac_cv_lib_readline_readline = yes + then + lib_for_readline=-lreadline + fi +fi +AC_SUBST(lib_for_readline) + + dnl dnl output files dnl diff --git a/src/dbpmda/src/GNUmakefile b/src/dbpmda/src/GNUmakefile index 859177b..005809b 100644 --- a/src/dbpmda/src/GNUmakefile +++ b/src/dbpmda/src/GNUmakefile @@ -27,7 +27,7 @@ LFILES = lex.l YFILES = gram.y LDIRT = *.log foo.* gram.h $(YFILES:%.y=%.tab.?) $(LFILES:%.l=%.c) -LLDLIBS = -lpcp $(LIB_FOR_DLOPEN) +LLDLIBS = -lpcp $(LIB_FOR_DLOPEN) $(LIB_FOR_READLINE) default: $(CMDTARGET) diff --git a/src/dbpmda/src/dbpmda.c b/src/dbpmda/src/dbpmda.c index 1f42ce2..4205453 100644 --- a/src/dbpmda/src/dbpmda.c +++ b/src/dbpmda/src/dbpmda.c @@ -21,6 +21,14 @@ #include "gram.h" #include +#if HAVE_LIBREADLINE +#include +#include + +struct yy_buffer_state; + +#endif + char *configfile = NULL; __pmLogCtl logctl; int parse_done = 0; @@ -46,6 +54,11 @@ main(int argc, char **argv) int errflag = 0; char *endnum; int i; +#if HAVE_LIBREADLINE + char *readline_str; + char str[1024]; + struct yy_buffer_state *buf; +#endif __pmSetProgname(argv[0]); @@ -156,7 +169,23 @@ main(int argc, char **argv) for ( ; ; ) { initmetriclist(); + +#if HAVE_LIBREADLINE + readline_str = readline("> "); + if (readline_str && *readline_str) + add_history(readline_str); + /* put back the newline that readline stripped off */ + sprintf(str, "%s\n", readline_str); + buf = yy_scan_string(str); + yy_switch_to_buffer(buf); +#endif + yyparse(); + +#if HAVE_LIBREADLINE + yy_delete_buffer(buf); + free(readline_str); +#endif if (yywrap()) { if (iflag) putchar('\n'); diff --git a/src/include/builddefs.in b/src/include/builddefs.in index d934852..abaf8cc 100644 --- a/src/include/builddefs.in +++ b/src/include/builddefs.in @@ -181,6 +181,7 @@ LIB_FOR_BASENAME = @lib_for_basename@ LIB_FOR_DLOPEN = @lib_for_dlopen@ LIB_FOR_REGEX = @lib_for_regex@ LIB_FOR_MATH = @lib_for_math@ +LIB_FOR_READLINE = @lib_for_readline@ SHELL = /bin/sh IMAGES_DIR = $(TOPDIR)/all-images diff --git a/src/include/platform_defs.h.in b/src/include/platform_defs.h.in index 88f39bd..e5948ca 100644 --- a/src/include/platform_defs.h.in +++ b/src/include/platform_defs.h.in @@ -137,6 +137,7 @@ extern "C" { #undef HAVE_SYS_ENDIAN_H #undef HAVE_SYS_MACHINE_H #undef HAVE_MACHINE_ENDIAN_H +#undef HAVE_LIBREADLINE #if defined(HAVE_MALLOC_H) #include From ajwans@evostor.com Mon Jan 18 08:09:47 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX, J_CHICKENPOX_31,J_CHICKENPOX_41,J_CHICKENPOX_43,J_CHICKENPOX_73,URIBL_BLACK autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0IE9lh1109203 for ; Mon, 18 Jan 2010 08:09:47 -0600 X-ASG-Debug-ID: 1263823846-11db01cd0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from relay.ihostexchange.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5F5571C59AF6 for ; Mon, 18 Jan 2010 06:10:46 -0800 (PST) Received: from relay.ihostexchange.net (relay.ihostexchange.net [66.46.182.55]) by cuda.sgi.com with ESMTP id 9RDcdoBFpYYlFdkk for ; Mon, 18 Jan 2010 06:10:46 -0800 (PST) Received: from HUB103.ihostexchange.net (66.46.182.53) by hub105.ihostexchange.net (66.46.182.55) with Microsoft SMTP Server (TLS) id 8.1.393.1; Mon, 18 Jan 2010 09:10:45 -0500 Received: from mailhost.internal (203.206.165.193) by smtp.ihostexchange.net (66.46.182.50) with Microsoft SMTP Server (TLS) id 8.1.393.1; Mon, 18 Jan 2010 09:10:44 -0500 Received: from dull (unknown [10.222.0.6]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mailhost.internal (Postfix) with ESMTPSA id 7E9B630911 for ; Tue, 19 Jan 2010 01:10:36 +1100 (EST) Received: by dull (sSMTP sendmail emulation); Tue, 19 Jan 2010 01:10:35 +1100 From: Andrew Wansink Date: Tue, 19 Jan 2010 01:10:35 +1100 To: pcp@oss.sgi.com X-ASG-Orig-Subj: Re: [pcp] readline support for dbpmda Subject: Re: [pcp] readline support for dbpmda Message-ID: <20100118141033.GA18251@dull> References: <20100118073306.GD28197@dull> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20100118073306.GD28197@dull> User-Agent: Mutt/1.5.20 (2009-06-14) X-Barracuda-Connect: relay.ihostexchange.net[66.46.182.55] X-Barracuda-Start-Time: 1263823846 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0169 1.0000 -1.9107 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.91 X-Barracuda-Spam-Status: No, SCORE=-1.91 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20148 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Might have another go at this, didn't turn out to be very portable. commit e0fb28877a19404389eb0a168fae0906bca60044 Author: Andrew Wansink Date: Mon Jan 18 18:30:08 2010 +1100 Add readline support to dbpdma. diff --git a/configure.in b/configure.in index 5554437..8f78847 100644 --- a/configure.in +++ b/configure.in @@ -1726,6 +1726,38 @@ int main () { } ], AC_DEFINE(HAVE_STRFTIME_z) AC_MSG_RESULT(yes) , AC_MSG_RESULT(no), 0) +savedLIBS=$LIBS +LIBS= +dnl Need flex if we are to get a lexer which can read from a buffer +if test $LEX = flex +then + lib_for_curses= + lib_for_readline= + + dnl first check for readline on its own then with curses + AC_CHECK_LIB(readline, readline,, + [ + dnl AC seems to cache lib/func results + dnl so use another readline func here + AC_CHECK_LIB(readline, add_history,,, [-lcurses]) + ]) + + if test $ac_cv_lib_readline_readline = yes + then + lib_for_readline=-lreadline + fi + + if test $ac_cv_lib_readline_add_history = yes + then + lib_for_curses=-lcurses + lib_for_readline=-lreadline + fi + + AC_SUBST(lib_for_readline) + AC_SUBST(lib_for_curses) +fi +LIBS=$savedLIBS + dnl dnl output files dnl diff --git a/src/dbpmda/src/GNUmakefile b/src/dbpmda/src/GNUmakefile index 859177b..700b4ac 100644 --- a/src/dbpmda/src/GNUmakefile +++ b/src/dbpmda/src/GNUmakefile @@ -27,7 +27,7 @@ LFILES = lex.l YFILES = gram.y LDIRT = *.log foo.* gram.h $(YFILES:%.y=%.tab.?) $(LFILES:%.l=%.c) -LLDLIBS = -lpcp $(LIB_FOR_DLOPEN) +LLDLIBS = -lpcp $(LIB_FOR_DLOPEN) $(LIB_FOR_READLINE) $(LIB_FOR_CURSES) default: $(CMDTARGET) diff --git a/src/dbpmda/src/dbpmda.c b/src/dbpmda/src/dbpmda.c index 1f42ce2..4205453 100644 --- a/src/dbpmda/src/dbpmda.c +++ b/src/dbpmda/src/dbpmda.c @@ -21,6 +21,14 @@ #include "gram.h" #include +#if HAVE_LIBREADLINE +#include +#include + +struct yy_buffer_state; + +#endif + char *configfile = NULL; __pmLogCtl logctl; int parse_done = 0; @@ -46,6 +54,11 @@ main(int argc, char **argv) int errflag = 0; char *endnum; int i; +#if HAVE_LIBREADLINE + char *readline_str; + char str[1024]; + struct yy_buffer_state *buf; +#endif __pmSetProgname(argv[0]); @@ -156,7 +169,23 @@ main(int argc, char **argv) for ( ; ; ) { initmetriclist(); + +#if HAVE_LIBREADLINE + readline_str = readline("> "); + if (readline_str && *readline_str) + add_history(readline_str); + /* put back the newline that readline stripped off */ + sprintf(str, "%s\n", readline_str); + buf = yy_scan_string(str); + yy_switch_to_buffer(buf); +#endif + yyparse(); + +#if HAVE_LIBREADLINE + yy_delete_buffer(buf); + free(readline_str); +#endif if (yywrap()) { if (iflag) putchar('\n'); diff --git a/src/include/builddefs.in b/src/include/builddefs.in index d934852..d2675e2 100644 --- a/src/include/builddefs.in +++ b/src/include/builddefs.in @@ -181,6 +181,8 @@ LIB_FOR_BASENAME = @lib_for_basename@ LIB_FOR_DLOPEN = @lib_for_dlopen@ LIB_FOR_REGEX = @lib_for_regex@ LIB_FOR_MATH = @lib_for_math@ +LIB_FOR_READLINE = @lib_for_readline@ +LIB_FOR_CURSES = @lib_for_curses@ SHELL = /bin/sh IMAGES_DIR = $(TOPDIR)/all-images diff --git a/src/include/platform_defs.h.in b/src/include/platform_defs.h.in index 88f39bd..e5948ca 100644 --- a/src/include/platform_defs.h.in +++ b/src/include/platform_defs.h.in @@ -137,6 +137,7 @@ extern "C" { #undef HAVE_SYS_ENDIAN_H #undef HAVE_SYS_MACHINE_H #undef HAVE_MACHINE_ENDIAN_H +#undef HAVE_LIBREADLINE #if defined(HAVE_MALLOC_H) #include From kenj@internode.on.net Mon Jan 18 14:03:30 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX, J_CHICKENPOX_31,J_CHICKENPOX_41,J_CHICKENPOX_43,J_CHICKENPOX_73,URIBL_BLACK autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0IK3TaP126665 for ; Mon, 18 Jan 2010 14:03:29 -0600 X-ASG-Debug-ID: 1263845066-1d6d025b0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 229BE171AEC for ; Mon, 18 Jan 2010 12:04:26 -0800 (PST) Received: from mail.internode.on.net (bld-mail13.adl6.internode.on.net [150.101.137.98]) by cuda.sgi.com with ESMTP id hbgEY2EPv2dUMCCj for ; Mon, 18 Jan 2010 12:04:26 -0800 (PST) Received: from [192.168.1.100] (unverified [118.209.137.163]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11644473-1927428 for multiple; Tue, 19 Jan 2010 06:34:25 +1030 (CDT) X-ASG-Orig-Subj: Re: [pcp] readline support for dbpmda Subject: Re: [pcp] readline support for dbpmda From: Ken McDonell Reply-To: kenj@internode.on.net To: Andrew Wansink Cc: pcp@oss.sgi.com In-Reply-To: <20100118141033.GA18251@dull> References: <20100118073306.GD28197@dull> <20100118141033.GA18251@dull> Content-Type: text/plain; charset="UTF-8" Date: Tue, 19 Jan 2010 07:04:23 +1100 Message-ID: <1263845063.15216.24.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail13.adl6.internode.on.net[150.101.137.98] X-Barracuda-Start-Time: 1263845068 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0002 1.0000 -2.0199 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20170 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Andrew, Thanks for this ... it addresses a long-standing annoyance. However, apart from the "it only works with flex" issue that I worked around in a slightly different way, there are some more serious problems with this patch ... 1. does not honour the -i and -e flags 2. does not handle initial reading from .dbpmdarc if it exists (and the associated change in prompt) 3. loops forever, i.e. does not exit when ^D read from tty stdin or EOF encountered on file/pipe stdin I suspect the readline change really needs to go into dbpmdaFlexInput() in lex.l and call yypush_buffer_state() and yypop_buffer_state(). This would also make it easier to localize them to be for flex only. I also suspect the configure.in changes need rework to handle the possible (?) case where readline() is in libc, not libreadline ... which in the previous patch (but not this one) was checked for in configure.in, but did not set any variables there ... I fixed this by separating HAVE_READLINE from lib_for_readline. Once this is clean for Linux (and I'm guessing Solaris is checked out by you guys) we'll need to be sure it builds cleanly on Windows (no idea if readline() is there) and Mac OS X (where the shipped readline() is apparently broken and without a man page, but the current one from GNU can be installed). Oh, the joy ... On Tue, 2010-01-19 at 01:10 +1100, Andrew Wansink wrote: > Might have another go at this, didn't turn out to be very > portable. > > commit e0fb28877a19404389eb0a168fae0906bca60044 > Author: Andrew Wansink > Date: Mon Jan 18 18:30:08 2010 +1100 > > Add readline support to dbpdma. > > diff --git a/configure.in b/configure.in > index 5554437..8f78847 100644 > --- a/configure.in > +++ b/configure.in > @@ -1726,6 +1726,38 @@ int main () { > } > ], AC_DEFINE(HAVE_STRFTIME_z) AC_MSG_RESULT(yes) , AC_MSG_RESULT(no), 0) > > +savedLIBS=$LIBS > +LIBS= > +dnl Need flex if we are to get a lexer which can read from a buffer > +if test $LEX = flex > +then > + lib_for_curses= > + lib_for_readline= > + > + dnl first check for readline on its own then with curses > + AC_CHECK_LIB(readline, readline,, > + [ > + dnl AC seems to cache lib/func results > + dnl so use another readline func here > + AC_CHECK_LIB(readline, add_history,,, [-lcurses]) > + ]) > + > + if test $ac_cv_lib_readline_readline = yes > + then > + lib_for_readline=-lreadline > + fi > + > + if test $ac_cv_lib_readline_add_history = yes > + then > + lib_for_curses=-lcurses > + lib_for_readline=-lreadline > + fi > + > + AC_SUBST(lib_for_readline) > + AC_SUBST(lib_for_curses) > +fi > +LIBS=$savedLIBS > + > dnl > dnl output files > dnl > diff --git a/src/dbpmda/src/GNUmakefile b/src/dbpmda/src/GNUmakefile > index 859177b..700b4ac 100644 > --- a/src/dbpmda/src/GNUmakefile > +++ b/src/dbpmda/src/GNUmakefile > @@ -27,7 +27,7 @@ LFILES = lex.l > YFILES = gram.y > > LDIRT = *.log foo.* gram.h $(YFILES:%.y=%.tab.?) $(LFILES:%.l=%.c) > -LLDLIBS = -lpcp $(LIB_FOR_DLOPEN) > +LLDLIBS = -lpcp $(LIB_FOR_DLOPEN) $(LIB_FOR_READLINE) $(LIB_FOR_CURSES) > > default: $(CMDTARGET) > > diff --git a/src/dbpmda/src/dbpmda.c b/src/dbpmda/src/dbpmda.c > index 1f42ce2..4205453 100644 > --- a/src/dbpmda/src/dbpmda.c > +++ b/src/dbpmda/src/dbpmda.c > @@ -21,6 +21,14 @@ > #include "gram.h" > #include > > +#if HAVE_LIBREADLINE > +#include > +#include > + > +struct yy_buffer_state; > + > +#endif > + > char *configfile = NULL; > __pmLogCtl logctl; > int parse_done = 0; > @@ -46,6 +54,11 @@ main(int argc, char **argv) > int errflag = 0; > char *endnum; > int i; > +#if HAVE_LIBREADLINE > + char *readline_str; > + char str[1024]; > + struct yy_buffer_state *buf; > +#endif > > __pmSetProgname(argv[0]); > > @@ -156,7 +169,23 @@ main(int argc, char **argv) > > for ( ; ; ) { > initmetriclist(); > + > +#if HAVE_LIBREADLINE > + readline_str = readline("> "); > + if (readline_str && *readline_str) > + add_history(readline_str); > + /* put back the newline that readline stripped off */ > + sprintf(str, "%s\n", readline_str); > + buf = yy_scan_string(str); > + yy_switch_to_buffer(buf); > +#endif > + > yyparse(); > + > +#if HAVE_LIBREADLINE > + yy_delete_buffer(buf); > + free(readline_str); > +#endif > if (yywrap()) { > if (iflag) > putchar('\n'); > diff --git a/src/include/builddefs.in b/src/include/builddefs.in > index d934852..d2675e2 100644 > --- a/src/include/builddefs.in > +++ b/src/include/builddefs.in > @@ -181,6 +181,8 @@ LIB_FOR_BASENAME = @lib_for_basename@ > LIB_FOR_DLOPEN = @lib_for_dlopen@ > LIB_FOR_REGEX = @lib_for_regex@ > LIB_FOR_MATH = @lib_for_math@ > +LIB_FOR_READLINE = @lib_for_readline@ > +LIB_FOR_CURSES = @lib_for_curses@ > > SHELL = /bin/sh > IMAGES_DIR = $(TOPDIR)/all-images > diff --git a/src/include/platform_defs.h.in b/src/include/platform_defs.h.in > index 88f39bd..e5948ca 100644 > --- a/src/include/platform_defs.h.in > +++ b/src/include/platform_defs.h.in > @@ -137,6 +137,7 @@ extern "C" { > #undef HAVE_SYS_ENDIAN_H > #undef HAVE_SYS_MACHINE_H > #undef HAVE_MACHINE_ENDIAN_H > +#undef HAVE_LIBREADLINE > > #if defined(HAVE_MALLOC_H) > #include > > > _______________________________________________ > pcp mailing list > pcp@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/pcp From ajwans@evostor.com Mon Jan 18 18:06:32 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: * X-Spam-Status: No, score=1.5 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX, J_CHICKENPOX_31,J_CHICKENPOX_41,J_CHICKENPOX_64,URIBL_BLACK autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0J06Vpp140283 for ; Mon, 18 Jan 2010 18:06:31 -0600 X-ASG-Debug-ID: 1263859649-74e4028e0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from relay.ihostexchange.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 58FBB11F889A for ; Mon, 18 Jan 2010 16:07:29 -0800 (PST) Received: from relay.ihostexchange.net (relay.ihostexchange.net [66.46.182.56]) by cuda.sgi.com with ESMTP id nAuiNFABdUDcrcmm for ; Mon, 18 Jan 2010 16:07:29 -0800 (PST) Received: from HUB103.ihostexchange.net (66.46.182.53) by hub106.ihostexchange.net (66.46.182.56) with Microsoft SMTP Server (TLS) id 8.1.393.1; Mon, 18 Jan 2010 19:07:27 -0500 Received: from mailhost.internal (203.206.165.193) by smtp.ihostexchange.net (66.46.182.50) with Microsoft SMTP Server (TLS) id 8.1.393.1; Mon, 18 Jan 2010 19:07:26 -0500 Received: from dull (unknown [10.222.0.6]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mailhost.internal (Postfix) with ESMTPSA id 8804830917; Tue, 19 Jan 2010 11:07:20 +1100 (EST) Received: by dull (sSMTP sendmail emulation); Tue, 19 Jan 2010 11:07:22 +1100 From: Andrew Wansink Date: Tue, 19 Jan 2010 11:07:22 +1100 To: pcp@oss.sgi.com CC: kenj@internode.on.net X-ASG-Orig-Subj: Re: [pcp] readline support for dbpmda Subject: Re: [pcp] readline support for dbpmda Message-ID: <20100119000722.GA19763@dull> References: <20100118073306.GD28197@dull> <20100118141033.GA18251@dull> <1263845063.15216.24.camel@bozo.localdomain> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="EuxKj2iCbKjpUGkD" Content-Disposition: inline In-Reply-To: <1263845063.15216.24.camel@bozo.localdomain> User-Agent: Mutt/1.5.20 (2009-06-14) X-Barracuda-Connect: relay.ihostexchange.net[66.46.182.56] X-Barracuda-Start-Time: 1263859650 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20186 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean --EuxKj2iCbKjpUGkD Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Mon, Jan 18, 2010 at 03:04:23PM -0500, Ken McDonell wrote: > Andrew, > > Thanks for this ... it addresses a long-standing annoyance. > > However, apart from the "it only works with flex" issue that I worked > around in a slightly different way, there are some more serious problems > with this patch ... > > 1. does not honour the -i and -e flags > 2. does not handle initial reading from .dbpmdarc if it exists (and the > associated change in prompt) > 3. loops forever, i.e. does not exit when ^D read from tty stdin or EOF > encountered on file/pipe stdin I didn't take enough time to really understand how that operated, guess I'm guilty of hit-n-run patching. I was working under the assumption that your flex functions were going to getc from whatever buffer I gave them but that doesn't seem to be the case. The attached patch should address all three of the problems raised. > > I suspect the readline change really needs to go into dbpmdaFlexInput() > in lex.l and call yypush_buffer_state() and yypop_buffer_state(). This > would also make it easier to localize them to be for flex only. > Readline gives back the entire string after any command line editing, etc, has completed so I'm using that string as an input buffer to feed your getc function. > I also suspect the configure.in changes need rework to handle the > possible (?) case where readline() is in libc, not libreadline ... which > in the previous patch (but not this one) was checked for in > configure.in, but did not set any variables there ... I fixed this by > separating HAVE_READLINE from lib_for_readline. Yes, I'll now rely on HAVE_READLINE in the sources and use lib_for_readline & lib_for_curses in builddef. HAVE_LIBREADLINE goes away. > > Once this is clean for Linux (and I'm guessing Solaris is checked out by > you guys) we'll need to be sure it builds cleanly on Windows (no idea if > readline() is there) and Mac OS X (where the shipped readline() is > apparently broken and without a man page, but the current one from GNU > can be installed). Is anyone out there able to test for Mac OS X or Windows? I have Linux (Kubuntu 9.10) and (Open)Solaris operating correctly. > > Oh, the joy ... Indeed. Andrew Wansink --EuxKj2iCbKjpUGkD Content-Type: text/x-diff; charset="us-ascii" Content-Disposition: attachment; filename="readline.patch" commit 16afb99c747d4c209c80550b7530147ea2e49442 Author: Andrew Wansink Date: Mon Jan 18 18:30:08 2010 +1100 Add readline support to dbpdma. diff --git a/configure.in b/configure.in index 5554437..abda612 100644 --- a/configure.in +++ b/configure.in @@ -1726,6 +1726,44 @@ int main () { } ], AC_DEFINE(HAVE_STRFTIME_z) AC_MSG_RESULT(yes) , AC_MSG_RESULT(no), 0) +savedLIBS=$LIBS +LIBS= +dnl Need flex if we are to get a lexer which can read from a buffer +if test $LEX = flex +then + lib_for_curses= + lib_for_readline= + + dnl first check for readline on its own then with curses + AC_CHECK_FUNC(readline,, + [ + AC_CHECK_LIB(readline, readline,, + [ + dnl AC seems to cache lib/func results + dnl so use another readline func here + AC_CHECK_LIB(readline, add_history,,,[-lcurses]) + ]) + ]) + + if test $ac_cvs_func_readline = yes + then + AC_DEFINE(HAVE_READLINE) + elif test $ac_cv_lib_readline_readline = yes + then + AC_DEFINE(HAVE_READLINE) + lib_for_readline=-lreadline + elif test $ac_cv_lib_readline_add_history = yes + then + AC_DEFINE(HAVE_READLINE) + lib_for_curses=-lcurses + lib_for_readline=-lreadline + fi + + AC_SUBST(lib_for_readline) + AC_SUBST(lib_for_curses) +fi +LIBS=$savedLIBS + dnl dnl output files dnl diff --git a/src/dbpmda/src/GNUmakefile b/src/dbpmda/src/GNUmakefile index 859177b..700b4ac 100644 --- a/src/dbpmda/src/GNUmakefile +++ b/src/dbpmda/src/GNUmakefile @@ -27,7 +27,7 @@ LFILES = lex.l YFILES = gram.y LDIRT = *.log foo.* gram.h $(YFILES:%.y=%.tab.?) $(LFILES:%.l=%.c) -LLDLIBS = -lpcp $(LIB_FOR_DLOPEN) +LLDLIBS = -lpcp $(LIB_FOR_DLOPEN) $(LIB_FOR_READLINE) $(LIB_FOR_CURSES) default: $(CMDTARGET) diff --git a/src/dbpmda/src/lex.l b/src/dbpmda/src/lex.l index b3c8117..1a0ac6d 100644 --- a/src/dbpmda/src/lex.l +++ b/src/dbpmda/src/lex.l @@ -24,6 +24,11 @@ int lineno = 0; #include "./lex.h" +#if HAVE_READLINE +#include +#include +#endif + #ifdef FLEX_SCANNER #define YY_NO_UNPUT #include "./gram.tab.h" @@ -178,6 +183,50 @@ dbpmdaGetc (char * inbuf) { int inch; +#if HAVE_READLINE + char rl_prompt_storage[64]; + char *rl_prompt = rl_prompt_storage; + static char *str = NULL; + static int strpos = 0; + + if (iflag) + snprintf(rl_prompt_storage, 64, "%s >", prompt); + else + rl_prompt = NULL; + + rl_instream = yyin; + + if (!str) { + do { + str = readline(rl_prompt); + if (!str) { + inbuf[0] = 0; + return inbuf[0]; + } + } while (!str[0]); + } + + inch = str[strpos++]; + if (inch == '\r') + inch = str[strpos++]; + + if (!inch) { + free(str); + str = NULL; + strpos = 0; + inch = '\n'; + } + + inbuf[0] = inch & 0xFFU; + + if (eflag) { + putchar(inch); + fflush(stdout); + } + + return inch; +#endif + while ((inch = fgetc (yyin)) != EOF ) { inbuf[0] = inch & 0xFFU; if (inbuf[0] == '\r') { @@ -218,10 +267,20 @@ dbpmdaFlexInput (char * inbuf, int ms) } if ( lastc == '\n' ) { +#if HAVE_READLINE + char *newline; + + if (line && *line && (newline = strchr(line, '\n'))) { + *newline = 0; + add_history(line); + *newline = '\n'; + } +#else if ( iflag ) { printf ("%s> ", prompt); fflush (stdout); } +#endif lineno++; linepos = 0; } @@ -245,11 +304,14 @@ dbpmdaFlexInput (char * inbuf, int ms) yyin = inf; lineno = 1; prompt = "dbpmda"; - configfile = NULL; - if ( (iflag = save_iflag) ) { - printf ("%s >", prompt); - fflush (stdout); + iflag = save_iflag; +#ifndef HAVE_READLINE + if ( iflag ) { + printf("%s >", prompt); + fflush(stdout); } +#endif + configfile = NULL; eflag = save_eflag; } else { return (0); diff --git a/src/include/builddefs.in b/src/include/builddefs.in index d934852..d2675e2 100644 --- a/src/include/builddefs.in +++ b/src/include/builddefs.in @@ -181,6 +181,8 @@ LIB_FOR_BASENAME = @lib_for_basename@ LIB_FOR_DLOPEN = @lib_for_dlopen@ LIB_FOR_REGEX = @lib_for_regex@ LIB_FOR_MATH = @lib_for_math@ +LIB_FOR_READLINE = @lib_for_readline@ +LIB_FOR_CURSES = @lib_for_curses@ SHELL = /bin/sh IMAGES_DIR = $(TOPDIR)/all-images diff --git a/src/include/platform_defs.h.in b/src/include/platform_defs.h.in index 88f39bd..526a993 100644 --- a/src/include/platform_defs.h.in +++ b/src/include/platform_defs.h.in @@ -137,6 +137,7 @@ extern "C" { #undef HAVE_SYS_ENDIAN_H #undef HAVE_SYS_MACHINE_H #undef HAVE_MACHINE_ENDIAN_H +#undef HAVE_READLINE #if defined(HAVE_MALLOC_H) #include --EuxKj2iCbKjpUGkD-- From kenj@internode.on.net Mon Jan 18 19:44:15 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX, J_CHICKENPOX_31,URIBL_BLACK autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0J1iFwD146695 for ; Mon, 18 Jan 2010 19:44:15 -0600 X-ASG-Debug-ID: 1263865512-7f4503800000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 92E0C1C5CBD7 for ; Mon, 18 Jan 2010 17:45:13 -0800 (PST) Received: from mail.internode.on.net (bld-mail13.adl6.internode.on.net [150.101.137.98]) by cuda.sgi.com with ESMTP id brFBFp2MDpJ8XxuL for ; Mon, 18 Jan 2010 17:45:13 -0800 (PST) Received: from [192.168.1.100] (unverified [118.209.137.163]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11646149-1927428 for multiple; Tue, 19 Jan 2010 12:15:11 +1030 (CDT) X-ASG-Orig-Subj: Re: [pcp] readline support for dbpmda Subject: Re: [pcp] readline support for dbpmda From: Ken McDonell Reply-To: kenj@internode.on.net To: Andrew Wansink Cc: pcp@oss.sgi.com In-Reply-To: <20100119000722.GA19763@dull> References: <20100118073306.GD28197@dull> <20100118141033.GA18251@dull> <1263845063.15216.24.camel@bozo.localdomain> <20100119000722.GA19763@dull> Content-Type: text/plain; charset="UTF-8" Date: Tue, 19 Jan 2010 12:45:09 +1100 Message-ID: <1263865509.18485.2.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail13.adl6.internode.on.net[150.101.137.98] X-Barracuda-Start-Time: 1263865514 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0209 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20191 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Thanks Andrew. I'll spin it up for my Linux machines and then have a crack at Mac OS X (haven't been there for a while so that should be fun). Nathan, any chance you could see if this will work (tm) on Windows? ps. once this is sorted, I plan to apply the same fix to pmlc which is the other place where a pcp interactive tool would benefit from readline(). On Tue, 2010-01-19 at 11:07 +1100, Andrew Wansink wrote: > On Mon, Jan 18, 2010 at 03:04:23PM -0500, Ken McDonell wrote: > > Andrew, > > > > Thanks for this ... it addresses a long-standing annoyance. > > > > However, apart from the "it only works with flex" issue that I worked > > around in a slightly different way, there are some more serious problems > > with this patch ... > > > > 1. does not honour the -i and -e flags > > 2. does not handle initial reading from .dbpmdarc if it exists (and the > > associated change in prompt) > > 3. loops forever, i.e. does not exit when ^D read from tty stdin or EOF > > encountered on file/pipe stdin > > I didn't take enough time to really understand how that operated, guess > I'm guilty of hit-n-run patching. > > I was working under the assumption that your flex functions were going > to getc from whatever buffer I gave them but that doesn't seem to be the > case. > > The attached patch should address all three of the problems raised. > > > > > I suspect the readline change really needs to go into dbpmdaFlexInput() > > in lex.l and call yypush_buffer_state() and yypop_buffer_state(). This > > would also make it easier to localize them to be for flex only. > > > > Readline gives back the entire string after any command line editing, > etc, has completed so I'm using that string as an input buffer to feed > your getc function. > > > I also suspect the configure.in changes need rework to handle the > > possible (?) case where readline() is in libc, not libreadline ... which > > in the previous patch (but not this one) was checked for in > > configure.in, but did not set any variables there ... I fixed this by > > separating HAVE_READLINE from lib_for_readline. > > Yes, I'll now rely on HAVE_READLINE in the sources and use lib_for_readline > & lib_for_curses in builddef. HAVE_LIBREADLINE goes away. > > > > > Once this is clean for Linux (and I'm guessing Solaris is checked out by > > you guys) we'll need to be sure it builds cleanly on Windows (no idea if > > readline() is there) and Mac OS X (where the shipped readline() is > > apparently broken and without a man page, but the current one from GNU > > can be installed). > > Is anyone out there able to test for Mac OS X or Windows? I have > Linux (Kubuntu 9.10) and (Open)Solaris operating correctly. > > > > > Oh, the joy ... > > Indeed. > > Andrew Wansink > > > From kenj@internode.on.net Tue Jan 19 14:14:42 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.7 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX, J_CHICKENPOX_31,J_CHICKENPOX_41,J_CHICKENPOX_43,J_CHICKENPOX_64,URIBL_BLACK autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0JKEfqF215063 for ; Tue, 19 Jan 2010 14:14:42 -0600 X-ASG-Debug-ID: 1263932139-5cab01100000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 1922C1C62F3E for ; Tue, 19 Jan 2010 12:15:39 -0800 (PST) Received: from mail.internode.on.net (bld-mail14.adl6.internode.on.net [150.101.137.99]) by cuda.sgi.com with ESMTP id l34SWvXx5pzwlmHe for ; Tue, 19 Jan 2010 12:15:39 -0800 (PST) Received: from [192.168.1.100] (unverified [118.209.137.163]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11710622-1927428 for multiple; Wed, 20 Jan 2010 06:45:37 +1030 (CDT) X-ASG-Orig-Subj: Re: [pcp] readline support for dbpmda Subject: Re: [pcp] readline support for dbpmda From: Ken McDonell Reply-To: kenj@internode.on.net To: Andrew Wansink Cc: pcp@oss.sgi.com In-Reply-To: <20100119000722.GA19763@dull> References: <20100118073306.GD28197@dull> <20100118141033.GA18251@dull> <1263845063.15216.24.camel@bozo.localdomain> <20100119000722.GA19763@dull> Content-Type: multipart/mixed; boundary="=-a0zj152GfeVDdqIAiHZl" Date: Wed, 20 Jan 2010 07:15:34 +1100 Message-ID: <1263932134.18485.22.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 X-Barracuda-Connect: bld-mail14.adl6.internode.on.net[150.101.137.99] X-Barracuda-Start-Time: 1263932141 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20257 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean --=-a0zj152GfeVDdqIAiHZl Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Andrew, et al Attached is a slight refinement of Andrew's patch that fixes a couple of minor problems and one major problem with doargs() and \n handling. This now passes PCP QA -g dbpmda on Linux (with a couple of trivial changes to accommodate slightly different cosmetics around empty input lines and error reporting) and appears to work on Mac OS X. I'll commit this one to my tree this evening if I don't see any adverse comments in the interim. Thanks again to Andrew for getting the heavy lifting done here. On Tue, 2010-01-19 at 11:07 +1100, Andrew Wansink wrote: > On Mon, Jan 18, 2010 at 03:04:23PM -0500, Ken McDonell wrote: > > Andrew, > > > > Thanks for this ... it addresses a long-standing annoyance. > > > > However, apart from the "it only works with flex" issue that I worked > > around in a slightly different way, there are some more serious problems > > with this patch ... > > > > 1. does not honour the -i and -e flags > > 2. does not handle initial reading from .dbpmdarc if it exists (and the > > associated change in prompt) > > 3. loops forever, i.e. does not exit when ^D read from tty stdin or EOF > > encountered on file/pipe stdin > > I didn't take enough time to really understand how that operated, guess > I'm guilty of hit-n-run patching. > > I was working under the assumption that your flex functions were going > to getc from whatever buffer I gave them but that doesn't seem to be the > case. > > The attached patch should address all three of the problems raised. > > > > > I suspect the readline change really needs to go into dbpmdaFlexInput() > > in lex.l and call yypush_buffer_state() and yypop_buffer_state(). This > > would also make it easier to localize them to be for flex only. > > > > Readline gives back the entire string after any command line editing, > etc, has completed so I'm using that string as an input buffer to feed > your getc function. > > > I also suspect the configure.in changes need rework to handle the > > possible (?) case where readline() is in libc, not libreadline ... which > > in the previous patch (but not this one) was checked for in > > configure.in, but did not set any variables there ... I fixed this by > > separating HAVE_READLINE from lib_for_readline. > > Yes, I'll now rely on HAVE_READLINE in the sources and use lib_for_readline > & lib_for_curses in builddef. HAVE_LIBREADLINE goes away. > > > > > Once this is clean for Linux (and I'm guessing Solaris is checked out by > > you guys) we'll need to be sure it builds cleanly on Windows (no idea if > > readline() is there) and Mac OS X (where the shipped readline() is > > apparently broken and without a man page, but the current one from GNU > > can be installed). > > Is anyone out there able to test for Mac OS X or Windows? I have > Linux (Kubuntu 9.10) and (Open)Solaris operating correctly. > > > > > Oh, the joy ... > > Indeed. > > Andrew Wansink > > > --=-a0zj152GfeVDdqIAiHZl Content-Disposition: attachment; filename="patch.dbpmda3" Content-Type: text/x-patch; name="patch.dbpmda3"; charset="UTF-8" Content-Transfer-Encoding: 7bit diff --git a/configure.in b/configure.in index 5554437..abda612 100644 --- a/configure.in +++ b/configure.in @@ -1726,6 +1726,44 @@ int main () { } ], AC_DEFINE(HAVE_STRFTIME_z) AC_MSG_RESULT(yes) , AC_MSG_RESULT(no), 0) +savedLIBS=$LIBS +LIBS= +dnl Need flex if we are to get a lexer which can read from a buffer +if test $LEX = flex +then + lib_for_curses= + lib_for_readline= + + dnl first check for readline on its own then with curses + AC_CHECK_FUNC(readline,, + [ + AC_CHECK_LIB(readline, readline,, + [ + dnl AC seems to cache lib/func results + dnl so use another readline func here + AC_CHECK_LIB(readline, add_history,,,[-lcurses]) + ]) + ]) + + if test $ac_cvs_func_readline = yes + then + AC_DEFINE(HAVE_READLINE) + elif test $ac_cv_lib_readline_readline = yes + then + AC_DEFINE(HAVE_READLINE) + lib_for_readline=-lreadline + elif test $ac_cv_lib_readline_add_history = yes + then + AC_DEFINE(HAVE_READLINE) + lib_for_curses=-lcurses + lib_for_readline=-lreadline + fi + + AC_SUBST(lib_for_readline) + AC_SUBST(lib_for_curses) +fi +LIBS=$savedLIBS + dnl dnl output files dnl diff --git a/src/dbpmda/src/GNUmakefile b/src/dbpmda/src/GNUmakefile index 859177b..700b4ac 100644 --- a/src/dbpmda/src/GNUmakefile +++ b/src/dbpmda/src/GNUmakefile @@ -27,7 +27,7 @@ LFILES = lex.l YFILES = gram.y LDIRT = *.log foo.* gram.h $(YFILES:%.y=%.tab.?) $(LFILES:%.l=%.c) -LLDLIBS = -lpcp $(LIB_FOR_DLOPEN) +LLDLIBS = -lpcp $(LIB_FOR_DLOPEN) $(LIB_FOR_READLINE) $(LIB_FOR_CURSES) default: $(CMDTARGET) diff --git a/src/dbpmda/src/dbpmda.c b/src/dbpmda/src/dbpmda.c index 1f42ce2..6c6c20d 100644 --- a/src/dbpmda/src/dbpmda.c +++ b/src/dbpmda/src/dbpmda.c @@ -78,7 +78,14 @@ main(int argc, char **argv) #endif case 'e': /* echo input */ +#if HAVE_READLINE + /* + * echo is not really optional when using readline(), + * and setting eflag would only trigger a double echo + */ +#else eflag++; +#endif break; case 'i': /* be interactive */ diff --git a/src/dbpmda/src/lex.l b/src/dbpmda/src/lex.l index b3c8117..83b79f9 100644 --- a/src/dbpmda/src/lex.l +++ b/src/dbpmda/src/lex.l @@ -24,6 +24,13 @@ int lineno = 0; #include "./lex.h" +#if HAVE_READLINE +#include +#include +static char *rl_str = NULL; +static int rl_strpos = 0; +#endif + #ifdef FLEX_SCANNER #define YY_NO_UNPUT #include "./gram.tab.h" @@ -178,6 +185,46 @@ dbpmdaGetc (char * inbuf) { int inch; +#if HAVE_READLINE + char rl_prompt_storage[64]; + char *rl_prompt = rl_prompt_storage; + + if (iflag) + snprintf(rl_prompt_storage, 64, "%s> ", prompt); + else + rl_prompt = NULL; + + rl_instream = yyin; + + if (!rl_str) { + do { + /* note, echo happens here independent of eflag setting */ + rl_str = readline(rl_prompt); + if (!rl_str) { + inbuf[0] = 0; + return inbuf[0]; + } + } while (!rl_str[0]); + } + + inch = rl_str[rl_strpos++]; + if (inch == '\r') + inch = rl_str[rl_strpos++]; + + if (!inch) { + /* end of input line, fake out \n so parser notices */ + inch = '\n'; + /* and setup to call readline() next time */ + free(rl_str); + rl_str = NULL; + rl_strpos = 0; + } + + inbuf[0] = inch & 0xFFU; + + return inch; +#endif + while ((inch = fgetc (yyin)) != EOF ) { inbuf[0] = inch & 0xFFU; if (inbuf[0] == '\r') { @@ -218,10 +265,21 @@ dbpmdaFlexInput (char * inbuf, int ms) } if ( lastc == '\n' ) { +#if HAVE_READLINE + + if (line != NULL && *line != '\0' && *line != '\n') { + /* line is not empty, push it into history */ + char *newline = strchr(line, '\n'); + if (newline != NULL) *newline = '\0'; + add_history(line); + if (newline != NULL) *newline = '\n'; + } +#else if ( iflag ) { printf ("%s> ", prompt); fflush (stdout); } +#endif lineno++; linepos = 0; } @@ -246,10 +304,13 @@ dbpmdaFlexInput (char * inbuf, int ms) lineno = 1; prompt = "dbpmda"; configfile = NULL; - if ( (iflag = save_iflag) ) { - printf ("%s >", prompt); - fflush (stdout); + iflag = save_iflag; +#ifndef HAVE_READLINE + if ( iflag ) { + printf("%s> ", prompt); + fflush(stdout); } +#endif eflag = save_eflag; } else { return (0); @@ -451,6 +512,18 @@ doargs(void) } if (c == '\n' || c == '\0') { #ifdef FLEX_SCANNER +#if HAVE_READLINE + if (c == '\n') { + /* + * extra \n is faked after end of input line in + * dbpmdaGetc ... to push this back into the input + * stream requires an even bigger hack ... + */ + rl_str = strdup("\n"); + rl_strpos = 0; + } +#else +#endif ungetc (c, yyin); #else unput('\n'); diff --git a/src/include/builddefs.in b/src/include/builddefs.in index d934852..d2675e2 100644 --- a/src/include/builddefs.in +++ b/src/include/builddefs.in @@ -181,6 +181,8 @@ LIB_FOR_BASENAME = @lib_for_basename@ LIB_FOR_DLOPEN = @lib_for_dlopen@ LIB_FOR_REGEX = @lib_for_regex@ LIB_FOR_MATH = @lib_for_math@ +LIB_FOR_READLINE = @lib_for_readline@ +LIB_FOR_CURSES = @lib_for_curses@ SHELL = /bin/sh IMAGES_DIR = $(TOPDIR)/all-images diff --git a/src/include/platform_defs.h.in b/src/include/platform_defs.h.in index 88f39bd..526a993 100644 --- a/src/include/platform_defs.h.in +++ b/src/include/platform_defs.h.in @@ -137,6 +137,7 @@ extern "C" { #undef HAVE_SYS_ENDIAN_H #undef HAVE_SYS_MACHINE_H #undef HAVE_MACHINE_ENDIAN_H +#undef HAVE_READLINE #if defined(HAVE_MALLOC_H) #include --=-a0zj152GfeVDdqIAiHZl-- From nscott@aconex.com Tue Jan 19 17:19:07 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0JNJ63V224539 for ; Tue, 19 Jan 2010 17:19:06 -0600 X-ASG-Debug-ID: 1263943204-230203030000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 6E08AF2465C for ; Tue, 19 Jan 2010 15:20:05 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id iWSV6ZotGGzR6jRX for ; Tue, 19 Jan 2010 15:20:05 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id D95D17C8A69; Wed, 20 Jan 2010 10:20:01 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id k4haZNSA20wBB7GG; Wed, 20 Jan 2010 10:20:01 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 5205FA50133; Wed, 20 Jan 2010 10:17:46 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id CCA39488374; Wed, 20 Jan 2010 10:20:01 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SCaHhUePjkpv; Wed, 20 Jan 2010 10:19:57 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 209AB48836E; Wed, 20 Jan 2010 10:19:57 +1100 (EST) Date: Wed, 20 Jan 2010 10:19:56 +1100 (EST) From: Nathan Scott To: kenj@internode.on.net, Andrew Wansink Cc: pcp@oss.sgi.com Message-ID: <1161969160.1901341263943196910.JavaMail.root@mail-au.aconex.com> In-Reply-To: <1263865509.18485.2.camel@bozo.localdomain> X-ASG-Orig-Subj: Re: [pcp] readline support for dbpmda Subject: Re: [pcp] readline support for dbpmda MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1263943206 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0033 1.0000 -1.9995 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.00 X-Barracuda-Spam-Status: No, SCORE=-2.00 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20269 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ----- "Ken McDonell" wrote: > Thanks Andrew. > > I'll spin it up for my Linux machines and then have a crack at Mac OS > X > (haven't been there for a while so that should be fun). > > Nathan, any chance you could see if this will work (tm) on Windows? Might take a little while to get to that, but will do. There will be no native readline on Windows, I'm sure - so I'll need to add this to the build (and runtime I guess) environment there. Not looked at the changes yet, but I assume the configure-magic will disable readline from the build if its not present on the platform? cheers. -- Nathan From nscott@aconex.com Tue Jan 19 19:38:35 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX, J_CHICKENPOX_43,URIBL_BLACK autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0K1cYg0230272 for ; Tue, 19 Jan 2010 19:38:34 -0600 X-ASG-Debug-ID: 1263951572-5a1001a20000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id C00ED1771B4 for ; Tue, 19 Jan 2010 17:39:33 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id I1Z7TyjvBf3WQq2Q for ; Tue, 19 Jan 2010 17:39:33 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 0C51A7C9381; Wed, 20 Jan 2010 12:39:31 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id xznub93FDt9RdlTF; Wed, 20 Jan 2010 12:39:31 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 6C2BEA50133; Wed, 20 Jan 2010 12:37:15 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 08C1E488379; Wed, 20 Jan 2010 12:39:31 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4VSJcgVqEIBX; Wed, 20 Jan 2010 12:39:26 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id A587D488373; Wed, 20 Jan 2010 12:39:26 +1100 (EST) Date: Wed, 20 Jan 2010 12:39:26 +1100 (EST) From: Nathan Scott To: kenj@internode.on.net, Andrew Wansink Cc: pcp@oss.sgi.com Message-ID: <298651563.1909311263951566508.JavaMail.root@mail-au.aconex.com> In-Reply-To: <1263932134.18485.22.camel@bozo.localdomain> X-ASG-Orig-Subj: Re: [pcp] readline support for dbpmda Subject: Re: [pcp] readline support for dbpmda MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1263951574 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0209 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20278 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ----- "Ken McDonell" wrote: > ... > I'll commit this one to my tree this evening if I don't see any > adverse > comments in the interim. > > Thanks again to Andrew for getting the heavy lifting done here. Some small review comments... --- a/configure.in +++ b/configure.in ... +savedLIBS=$LIBS +LIBS= +dnl Need flex if we are to get a lexer which can read from a buffer +if test $LEX = flex +then + lib_for_curses= + lib_for_readline= ... + AC_SUBST(lib_for_readline) + AC_SUBST(lib_for_curses) +fi +LIBS=$savedLIBS This bit looks not-quite-right - the LIBS=/savedLIBS= part should be inside "if test $LEX" and the lib_for_curses= , lib_for_readline= and AC_SUBST lines should be outside the conditional (so that the SUBST is always done - otherwise we end up with @lib_for_curses@ in the generated builddefs for platforms with no support. Here... --- a/src/dbpmda/src/dbpmda.c +++ b/src/dbpmda/src/dbpmda.c @@ -78,7 +78,14 @@ main(int argc, char **argv) #endif case 'e': /* echo input */ +#if HAVE_READLINE ... And here... --- a/src/dbpmda/src/lex.l +++ b/src/dbpmda/src/lex.l @@ -24,6 +24,13 @@ int lineno = 0; #include "./lex.h" +#if HAVE_READLINE +#include +#include (and one or two more places) ... we use "#if HAVE_READLINE", should be "#ifdef" I suspect - for platforms with no support it will be undef (not zero). +#ifndef HAVE_READLINE + if ( iflag ) { + printf("%s> ", prompt); + fflush(stdout); } +#endif ... the above is fine & should stay as is - its more along the lines of what the code usually does with configure macros. Thanks for this, BTW - I'll certainly be using it! cheers. -- Nathan From nscott@aconex.com Wed Jan 20 00:00:13 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0K60CRH245046 for ; Wed, 20 Jan 2010 00:00:13 -0600 X-ASG-Debug-ID: 1263967270-532a03730000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id C4A3D177842 for ; Tue, 19 Jan 2010 22:01:11 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id rzkGR9ytPpEkTmEd for ; Tue, 19 Jan 2010 22:01:11 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id D9A3B1CF8F2 for ; Wed, 20 Jan 2010 17:01:09 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id h1RHDQwkpy2Ffx7R for ; Wed, 20 Jan 2010 17:01:09 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 21B1AA50235 for ; Wed, 20 Jan 2010 16:58:54 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id C1DCE488381 for ; Wed, 20 Jan 2010 17:01:09 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ky20lPcyVC6h for ; Wed, 20 Jan 2010 17:01:06 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 0162F48837A for ; Wed, 20 Jan 2010 17:01:06 +1100 (EST) Date: Wed, 20 Jan 2010 17:01:05 +1100 (EST) From: Nathan Scott To: pcp@oss.sgi.com Message-ID: <641571805.1925771263967265865.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcp updates Subject: pcp updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1263967272 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.52 X-Barracuda-Spam-Status: No, SCORE=-1.52 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20294 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M X-Virus-Status: Clean Changes committed to git://oss.sgi.com/nathans/pcp.git build/rpm/pcp.spec.in | 2 +- build/rpm/pcp_fedora.spec | 2 +- debian/control | 2 +- man/man3/pmregisterderived.3 | 4 ++-- src/pmdas/mmv/GNUmakefile | 2 +- src/pmdas/mmv/mmv.c | 11 +++++++++-- 6 files changed, 15 insertions(+), 8 deletions(-) commit 386ec440636be0c2c361c798f76b7fb6640f21b0 Author: Nathan Scott Date: Wed Jan 20 15:21:59 2010 +1100 Add readline-devel rpm spec file build dependency. commit f6c26e52f3398ac7a383170eec9c066b91aef689 Author: Nathan Scott Date: Wed Jan 20 13:47:40 2010 +1100 Add readline build dependency for debian package build. commit 442c2d9f4c252c5eb31a6d40930b63a2cab0fe58 Author: Nathan Scott Date: Wed Jan 20 13:46:55 2010 +1100 Additional LDIRT for mmv makefile to clean. commit 2ffb0bb2f47420cf41ca1592035ceaafe9955ed8 Author: Nathan Scott Date: Wed Jan 20 13:46:13 2010 +1100 Fix a hyphen-used-as-minus issue on pmregisterderived man page. commit cd677c8c4d73c0c453dfad5fd38930c01a662e14 Author: Nathan Scott Date: Wed Jan 20 12:24:01 2010 +1100 Add check in pmdammv for valid pmid item numbers from clients. From kenj@internode.on.net Wed Jan 20 04:03:04 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0KA33V7260785 for ; Wed, 20 Jan 2010 04:03:03 -0600 X-ASG-Debug-ID: 1263981841-4a5101fd0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id DE1EA178098 for ; Wed, 20 Jan 2010 02:04:02 -0800 (PST) Received: from mail.internode.on.net (bld-mail12.adl6.internode.on.net [150.101.137.97]) by cuda.sgi.com with ESMTP id qEjCLOCHr0Wswjmk for ; Wed, 20 Jan 2010 02:04:02 -0800 (PST) Received: from [192.168.1.100] (unverified [118.209.137.163]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11569178-1927428 for multiple; Wed, 20 Jan 2010 20:34:00 +1030 (CDT) X-ASG-Orig-Subj: Re: [pcp] readline support for dbpmda Subject: Re: [pcp] readline support for dbpmda From: Ken McDonell Reply-To: kenj@internode.on.net To: Nathan Scott Cc: Andrew Wansink , pcp@oss.sgi.com In-Reply-To: <1161969160.1901341263943196910.JavaMail.root@mail-au.aconex.com> References: <1161969160.1901341263943196910.JavaMail.root@mail-au.aconex.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 20 Jan 2010 21:03:56 +1100 Message-ID: <1263981836.18485.81.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail12.adl6.internode.on.net[150.101.137.97] X-Barracuda-Start-Time: 1263981843 X-Barracuda-Bayes: INNOCENT GLOBAL 0.2054 1.0000 -0.7996 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -0.80 X-Barracuda-Spam-Status: No, SCORE=-0.80 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20308 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Wed, 2010-01-20 at 10:19 +1100, Nathan Scott wrote: > ----- "Ken McDonell" wrote: > ... > > Not looked at the changes yet, but I assume the configure-magic will > disable readline from the build if its not present on the platform? That's certainly the intention. From ajwans@evostor.com Thu Jan 21 16:20:23 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.7 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX, J_CHICKENPOX_43 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0LMKMGX096165 for ; Thu, 21 Jan 2010 16:20:23 -0600 X-ASG-Debug-ID: 1264112482-0db400780000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from relay.ihostexchange.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 187FBF36887 for ; Thu, 21 Jan 2010 14:21:23 -0800 (PST) Received: from relay.ihostexchange.net (relay.ihostexchange.net [66.46.182.54]) by cuda.sgi.com with ESMTP id AV65VagA8FKDEdCa for ; Thu, 21 Jan 2010 14:21:23 -0800 (PST) Received: from HUB103.ihostexchange.net (66.46.182.53) by HUB104.ihostexchange.net (66.46.182.54) with Microsoft SMTP Server (TLS) id 8.1.393.1; Thu, 21 Jan 2010 17:21:21 -0500 Received: from mailhost.internal (203.206.165.193) by smtp.ihostexchange.net (66.46.182.50) with Microsoft SMTP Server (TLS) id 8.1.393.1; Thu, 21 Jan 2010 17:21:20 -0500 Received: from dull (unknown [10.222.0.6]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mailhost.internal (Postfix) with ESMTPSA id 2C4423091C; Fri, 22 Jan 2010 09:21:15 +1100 (EST) Received: by dull (sSMTP sendmail emulation); Fri, 22 Jan 2010 09:21:16 +1100 From: Andrew Wansink Date: Fri, 22 Jan 2010 09:21:16 +1100 To: Nathan Scott CC: "kenj@internode.on.net" , Andrew Wansink , "pcp@oss.sgi.com" X-ASG-Orig-Subj: Re: [pcp] readline support for dbpmda Subject: Re: [pcp] readline support for dbpmda Message-ID: <20100121222116.GA20351@dull> References: <1263932134.18485.22.camel@bozo.localdomain> <298651563.1909311263951566508.JavaMail.root@mail-au.aconex.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <298651563.1909311263951566508.JavaMail.root@mail-au.aconex.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-Barracuda-Connect: relay.ihostexchange.net[66.46.182.54] X-Barracuda-Start-Time: 1264112484 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0011 1.0000 -2.0136 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.01 X-Barracuda-Spam-Status: No, SCORE=-2.01 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20443 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean > Here... > > --- a/src/dbpmda/src/dbpmda.c > +++ b/src/dbpmda/src/dbpmda.c > @@ -78,7 +78,14 @@ main(int argc, char **argv) > #endif > > case 'e': /* echo input */ > +#if HAVE_READLINE > ... > > And here... > > --- a/src/dbpmda/src/lex.l > +++ b/src/dbpmda/src/lex.l > @@ -24,6 +24,13 @@ int lineno = 0; > > #include "./lex.h" > > +#if HAVE_READLINE > +#include > +#include > > (and one or two more places) ... we use "#if HAVE_READLINE", > should be "#ifdef" I suspect - for platforms with no support > it will be undef (not zero). "#if SOMETHING" will preprocess out if either the SOMETHING is undefinde or that SOMETHING == 0. Andrew Wansink From nscott@aconex.com Thu Jan 21 16:24:06 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0LMO5XS096294 for ; Thu, 21 Jan 2010 16:24:06 -0600 X-ASG-Debug-ID: 1264112705-1d8c020d0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 1945C1C6D0DC for ; Thu, 21 Jan 2010 14:25:06 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id i80uWGiPYOZyrLMT for ; Thu, 21 Jan 2010 14:25:06 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 779377C8BCF; Fri, 22 Jan 2010 09:25:03 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id chknYDZNFZtfq2Ax; Fri, 22 Jan 2010 09:25:03 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id BFB72A50235; Fri, 22 Jan 2010 09:22:46 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 50D42488381; Fri, 22 Jan 2010 09:25:03 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JGUSkiUFI0l1; Fri, 22 Jan 2010 09:24:58 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 5536C48837F; Fri, 22 Jan 2010 09:24:58 +1100 (EST) Date: Fri, 22 Jan 2010 09:24:58 +1100 (EST) From: Nathan Scott To: Andrew Wansink Cc: kenj@internode.on.net, pcp@oss.sgi.com Message-ID: <1572351664.1970041264112698219.JavaMail.root@mail-au.aconex.com> In-Reply-To: <20100121222116.GA20351@dull> X-ASG-Orig-Subj: Re: [pcp] readline support for dbpmda Subject: Re: [pcp] readline support for dbpmda MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1264112707 X-Barracuda-Bayes: INNOCENT GLOBAL 0.2869 1.0000 -0.4049 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -0.40 X-Barracuda-Spam-Status: No, SCORE=-0.40 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20444 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ----- "Andrew Wansink" wrote: > > ... > > (and one or two more places) ... we use "#if HAVE_READLINE", > > should be "#ifdef" I suspect - for platforms with no support > > it will be undef (not zero). > > "#if SOMETHING" will preprocess out if either the SOMETHING > is undefinde or that SOMETHING == 0. Yep, understood - it was just a (minor) consistency-with-other-pcp-code thing. cheers. -- Nathan From ajwans@evostor.com Thu Jan 21 18:54:32 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX, J_CHICKENPOX_54,J_CHICKENPOX_63,J_CHICKENPOX_84 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0M0sWJs101935 for ; Thu, 21 Jan 2010 18:54:32 -0600 X-ASG-Debug-ID: 1264121731-6ba102ea0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from relay.ihostexchange.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 439F91C6D7EB for ; Thu, 21 Jan 2010 16:55:31 -0800 (PST) Received: from relay.ihostexchange.net (relay.ihostexchange.net [66.46.182.54]) by cuda.sgi.com with ESMTP id 8yXRCeBCLSABvfaF for ; Thu, 21 Jan 2010 16:55:31 -0800 (PST) Received: from HUB103.ihostexchange.net (66.46.182.53) by HUB104.ihostexchange.net (66.46.182.54) with Microsoft SMTP Server (TLS) id 8.1.393.1; Thu, 21 Jan 2010 19:55:31 -0500 Received: from mailhost.internal (203.206.165.193) by smtp.ihostexchange.net (66.46.182.50) with Microsoft SMTP Server (TLS) id 8.1.393.1; Thu, 21 Jan 2010 19:55:30 -0500 Received: from dull (unknown [10.222.0.6]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mailhost.internal (Postfix) with ESMTPSA id 034B23091C for ; Fri, 22 Jan 2010 11:55:25 +1100 (EST) Received: by dull (sSMTP sendmail emulation); Fri, 22 Jan 2010 11:55:26 +1100 From: Andrew Wansink Date: Fri, 22 Jan 2010 11:55:26 +1100 To: pcp@oss.sgi.com X-ASG-Orig-Subj: dbpdma open socket Subject: dbpdma open socket Message-ID: <20100122005526.GA20957@dull> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="OgqxwSJOaUobr8KG" Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) X-Barracuda-Connect: relay.ihostexchange.net[66.46.182.54] X-Barracuda-Start-Time: 1264121732 X-Barracuda-Bayes: INNOCENT GLOBAL 0.2164 1.0000 -0.7426 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -0.74 X-Barracuda-Spam-Status: No, SCORE=-0.74 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20453 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean --OgqxwSJOaUobr8KG Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline While debugging my pdma it is easier to run it inside gdb and use a named pipe to communicate with dbpdma. Patch to dbpdma attached. Andrew Wansink --OgqxwSJOaUobr8KG Content-Type: text/x-diff; charset="us-ascii" Content-Disposition: attachment; filename="socket.patch" commit 3cba8965cabd149e5bdfe6165e798e2a79d4530f Author: Andrew Wansink Date: Fri Jan 22 11:49:37 2010 +1100 Added "open socket" command to dbpmda. diff --git a/src/dbpmda/src/dbpmda.h b/src/dbpmda/src/dbpmda.h index 914ec24..7711e0b 100644 --- a/src/dbpmda/src/dbpmda.h +++ b/src/dbpmda/src/dbpmda.h @@ -53,6 +53,11 @@ extern void closepmda(void); extern void dopmda(int); extern void watch(char *); +#if HAVE_SYS_UN_H +extern void opensocket(char *); +extern void closesocket(void); +#endif + /* * make sure these are different to PDU_BINARY or PDU_ASCII */ diff --git a/src/dbpmda/src/gram.y b/src/dbpmda/src/gram.y index ee13d9c..4991acc 100644 --- a/src/dbpmda/src/gram.y +++ b/src/dbpmda/src/gram.y @@ -71,7 +71,7 @@ param_t param; OPEN CLOSE DESC GETDESC FETCH INSTANCE PROFILE HELP WATCH DBG QUIT STATUS STORE INFO TIMER NAMESPACE WAIT PMNS_NAME PMNS_PMID PMNS_CHILDREN PMNS_TRAVERSE - DSO PIPE + DSO PIPE SOCKET ADD DEL ALL NONE INDOM ON OFF PLUS EOL @@ -101,6 +101,10 @@ stmt : OPEN EOL { openpmda($3); stmt_type = OPEN; YYACCEPT; } + | OPEN SOCKET fname { + opensocket($3); + stmt_type = OPEN; YYACCEPT; + } | CLOSE EOL { stmt_type = CLOSE; YYACCEPT; } diff --git a/src/dbpmda/src/lex.l b/src/dbpmda/src/lex.l index b3c8117..6ce64fc 100644 --- a/src/dbpmda/src/lex.l +++ b/src/dbpmda/src/lex.l @@ -68,6 +68,7 @@ off { return OFF; } on { return ON; } open { return OPEN; } pipe { BEGIN FNAME; return PIPE; } +socket { BEGIN FNAME; return SOCKET; } pmid { return PMNS_PMID; } profile { return PROFILE; } q { return QUIT; } diff --git a/src/dbpmda/src/pmda.c b/src/dbpmda/src/pmda.c index 8fcdf5c..e5f96b4 100644 --- a/src/dbpmda/src/pmda.c +++ b/src/dbpmda/src/pmda.c @@ -25,6 +25,11 @@ #endif #include +#include +#if HAVE_SYS_UN_H +#include +#endif + #include "./dbpmda.h" #include "./lex.h" #include "./gram.h" @@ -170,6 +175,78 @@ openpmda(char *fname) } } +#if HAVE_SYS_UN_H +void +closesocket(void) +{ + if (infd) + close(infd); + __pmResetIPC(infd); + connmode = PDU_NOT; + if (myPmdaName != NULL) + free(myPmdaName); +} + +void +opensocket(char *fname) +{ + int fd; + struct stat buf; + struct sockaddr_un s_un; + int len; + + if (stat(fname, &buf) < 0) { + fprintf(stderr, "opensocket: %s: %s\n", fname, strerror(errno)); + return; + } + + fd = socket(AF_UNIX, SOCK_STREAM, 0); + if (fd < 0) { + fprintf(stderr, "opensocket: socket: %s\n", strerror(errno)); + return; + } + + memset(&s_un, 0, sizeof(s_un)); + s_un.sun_family = AF_UNIX; + strncpy(s_un.sun_path, fname, strlen(fname)); + len = sizeof(s_un.sun_family) + strlen(fname); + + closesocket(); + + if (connect(fd, (struct sockaddr *)&s_un, len) < 0) { + fprintf(stderr, "opensocket: bind: %s\n", strerror(errno)); + close(fd); + return; + } + + infd = fd; + outfd = fd; + + printf("Connect PDMA on named pipe %s\n", fname); + + putchar('\n'); + + connmode = PDU_BINARY; + reset_profile(); + if (myPmdaName != NULL) + free(myPmdaName); + myPmdaName = strdup(fname); + pmdaversion(); +} +#else +void +opensocket(char *fname) +{ + __pmNotifyErr(LOG_CRIT, "UNIX domain sockets unsupported\n"); +} + +void +closesocket(void) +{ + __pmNotifyErr(LOG_CRIT, "UNIX domain sockets unsupported\n"); +} +#endif + void closepmda(void) { diff --git a/src/dbpmda/src/util.c b/src/dbpmda/src/util.c index e7bf94a..d6f9810 100644 --- a/src/dbpmda/src/util.c +++ b/src/dbpmda/src/util.c @@ -269,6 +269,7 @@ dohelp(int command, int full) case OPEN: puts("open dso dsoname init_routine [ domain# ]"); puts("open pipe execname [ arg ... ]"); + puts("open socket sockname"); break; case PMNS_CHILDREN: puts("children metric-name"); @@ -357,10 +358,12 @@ dohelp(int command, int full) break; case OPEN: puts( -"Open a PMDA as either a DSO or a daemon (connected with a pipe). The\n" -"'dsoname' and 'execname' fields are the path to the PMDA shared object file\n" -"or executable. The arguments to this command are similar to a line in the\n" -"pmcd.conf file.\n"); +"Open a PMDA as either a DSO, via socket, or as a daemon (connected with a \n" +"pipe). The 'dsoname' and 'execname' fields are the path to the PMDA shared \n" +"object file or executable. The arguments to this command are similar to a \n" +"line in the pmcd.conf file. The 'sockname field is the path of a named pipe\n" +"where a PMDA is listening for connections\n"); + break; case PMNS_CHILDREN: puts( --OgqxwSJOaUobr8KG-- From makc@iinet.net.au Sun Jan 24 07:01:37 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX,J_CHICKENPOX_74 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0OD1axM249173 for ; Sun, 24 Jan 2010 07:01:37 -0600 X-ASG-Debug-ID: 1264338156-3ea003650000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from outbound.icp-qv1-irony-out5.iinet.net.au (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id DC8BF1C7402A for ; Sun, 24 Jan 2010 05:02:37 -0800 (PST) Received: from outbound.icp-qv1-irony-out5.iinet.net.au (outbound.icp-qv1-irony-out5.iinet.net.au [203.59.1.105]) by cuda.sgi.com with ESMTP id idEudNaAS1kzUOlz for ; Sun, 24 Jan 2010 05:02:37 -0800 (PST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAB7TW0vL2Rwk/2dsb2JhbADVLIQ7BA X-IronPort-AV: E=Sophos;i="4.49,334,1262534400"; d="scan'208";a="95344677" Received: from unknown (HELO alma.crabbed.net) ([203.217.28.36]) by outbound.icp-qv1-irony-out5.iinet.net.au with ESMTP; 24 Jan 2010 21:02:35 +0800 Received: by alma.crabbed.net (Postfix, from userid 501) id AE8C7C7EC6; Mon, 25 Jan 2010 00:02:34 +1100 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19292.17642.308286.598378@iinet.net.au> Date: Mon, 25 Jan 2010 00:02:34 +1100 From: Max Matveev To: pcp@oss.sgi.com X-ASG-Orig-Subj: pcp updates Subject: pcp updates X-Mailer: VM 7.17 under 21.4 (patch 19) "Constant Variable" XEmacs Lucid X-Barracuda-Connect: outbound.icp-qv1-irony-out5.iinet.net.au[203.59.1.105] X-Barracuda-Start-Time: 1264338158 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0007 1.0000 -2.0162 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20666 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean I've pushed another set of changes to solaris pmda to extract information about network links: they're similar to the information in the network.interface hierarchy but deal with different objects. For example, if multiple physical interfaces are aggergated into a single LACP trunk network.interface will only provide information about trunked interface, network.link will provide information about both. On the other hand, network.link does not deal with loopback. This commit is on top of diskstat branch which I've pushed out a week ago. The following changes since commit c37667ffaaa6edbc6ddf0386e7657e8ec85faf9a: Max Matveev (1): Make pmie_check work on Solaris are available in the git repository at: git://oss.sgi.com/makc/pcp netlink Max Matveev (1): Extract information about network links on Solaris src/pmdas/solaris/GNUmakefile | 3 +- src/pmdas/solaris/common.h | 6 ++ src/pmdas/solaris/data.c | 73 +++++++++++++++++++++++- src/pmdas/solaris/help | 27 +++++++++ src/pmdas/solaris/netlink.c | 123 ++++++++++++++++++++++++++++++++++++++++ src/pmdas/solaris/pmns.network | 28 +++++++++ 6 files changed, 256 insertions(+), 4 deletions(-) create mode 100644 src/pmdas/solaris/netlink.c From makc@iinet.net.au Sun Jan 24 07:17:12 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0ODHBTc249929 for ; Sun, 24 Jan 2010 07:17:11 -0600 X-ASG-Debug-ID: 1264339092-3e9f03c50000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from outbound.icp-qv1-irony-out4.iinet.net.au (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id A6C941C748F7 for ; Sun, 24 Jan 2010 05:18:13 -0800 (PST) Received: from outbound.icp-qv1-irony-out4.iinet.net.au (outbound.icp-qv1-irony-out4.iinet.net.au [203.59.1.104]) by cuda.sgi.com with ESMTP id DFrLKybojAMHf9OO for ; Sun, 24 Jan 2010 05:18:13 -0800 (PST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAM7XW0vL2Rwk/2dsb2JhbADVHIQ7BA X-IronPort-AV: E=Sophos;i="4.49,334,1262534400"; d="scan'208";a="500438487" Received: from unknown (HELO alma.crabbed.net) ([203.217.28.36]) by outbound.icp-qv1-irony-out4.iinet.net.au with ESMTP; 24 Jan 2010 21:18:11 +0800 Received: by alma.crabbed.net (Postfix, from userid 501) id C5E41C7ED7; Mon, 25 Jan 2010 00:18:10 +1100 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19292.18578.486513.899049@iinet.net.au> Date: Mon, 25 Jan 2010 00:18:10 +1100 From: Max Matveev To: pcp@oss.sgi.com X-ASG-Orig-Subj: pmda instance cache operations Subject: pmda instance cache operations X-Mailer: VM 7.17 under 21.4 (patch 19) "Constant Variable" XEmacs Lucid X-Barracuda-Connect: outbound.icp-qv1-irony-out4.iinet.net.au[203.59.1.104] X-Barracuda-Start-Time: 1264339094 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0002 1.0000 -2.0197 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20666 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Ken, As the author of pmdaCache, what is the behaviour you would expect of the following sequence of calls (assuming that the cached file for the indom exists and contains entries for ook and eek): pmdaCacheOp(indom, PMDA_CACHE_LOAD); pmdaCacheStore(indom, PMDA_CACHE_ADD, "ook", NULL); pmdaCacheStore(indom, PMDA_CACHE_ADD, "eek", NULL); pmdaCacheOp(indom, PMDA_CACHE_STORE); pmdaCacheOp(indom, PMDA_CACHE_LOAD); In particular, how many entries will be in the cache after CACHE_LOAD, how many will be active and how many will be inactive? The reason I'm asking is because I've had to chase a bug in my code which did just that and broke pmdaInstance callback. max From makc@iinet.net.au Sun Jan 24 07:22:29 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0ODMS2q250231 for ; Sun, 24 Jan 2010 07:22:29 -0600 X-ASG-Debug-ID: 1264339410-04cf00700000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from outbound.icp-qv1-irony-out4.iinet.net.au (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 0EA721875AD for ; Sun, 24 Jan 2010 05:23:30 -0800 (PST) Received: from outbound.icp-qv1-irony-out4.iinet.net.au (outbound.icp-qv1-irony-out4.iinet.net.au [203.59.1.104]) by cuda.sgi.com with ESMTP id 1DAXAZXTgacOJUui for ; Sun, 24 Jan 2010 05:23:30 -0800 (PST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAPrYW0vL2Rwk/2dsb2JhbADVHYQ7BA X-IronPort-AV: E=Sophos;i="4.49,334,1262534400"; d="scan'208";a="500438890" Received: from unknown (HELO alma.crabbed.net) ([203.217.28.36]) by outbound.icp-qv1-irony-out4.iinet.net.au with ESMTP; 24 Jan 2010 21:23:29 +0800 Received: by alma.crabbed.net (Postfix, from userid 501) id BEADCC7EDE; Mon, 25 Jan 2010 00:23:28 +1100 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19292.18896.462674.890594@iinet.net.au> Date: Mon, 25 Jan 2010 00:23:28 +1100 From: Max Matveev To: pcp@oss.sgi.com X-ASG-Orig-Subj: pcp updates Subject: pcp updates X-Mailer: VM 7.17 under 21.4 (patch 19) "Constant Variable" XEmacs Lucid X-Barracuda-Connect: outbound.icp-qv1-irony-out4.iinet.net.au[203.59.1.104] X-Barracuda-Start-Time: 1264339412 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0998 1.0000 -1.3937 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.39 X-Barracuda-Spam-Status: No, SCORE=-1.39 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20668 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Another pet pieve of mine - I can never remember if I need to strdup pointers which I give to pmdaCacheStore: I'd like to make them const to remind myself that I don't. The following changes since commit 7a2edea23d4d6c7c3a40601bf20ced386024188f: Nathan Scott (1): Bump version in dev branch. are available in the git repository at: git://oss.sgi.com/makc/pcp constcache Max Matveev (1): Constify arguments of pmdaCache functions man/man3/pmdacache.3 | 4 ++-- src/include/pmda.h | 4 ++-- src/libpcp_pmda/src/cache.c | 22 +++++++++++----------- 3 files changed, 15 insertions(+), 15 deletions(-) From kenj@internode.on.net Sun Jan 24 14:33:51 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.3 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0OKXpA3009389 for ; Sun, 24 Jan 2010 14:33:51 -0600 X-ASG-Debug-ID: 1264365292-2455009f0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 4AB791785CF for ; Sun, 24 Jan 2010 12:34:52 -0800 (PST) Received: from mail.internode.on.net (bld-mail18.adl2.internode.on.net [150.101.137.103]) by cuda.sgi.com with ESMTP id UNWZA0JWgcaXEfBs for ; Sun, 24 Jan 2010 12:34:52 -0800 (PST) Received: from [192.168.1.100] (unverified [118.209.153.242]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11546740-1927428 for multiple; Mon, 25 Jan 2010 07:04:50 +1030 (CDT) X-ASG-Orig-Subj: Re: [pcp] pmda instance cache operations Subject: Re: [pcp] pmda instance cache operations From: Ken McDonell Reply-To: kenj@internode.on.net To: Max Matveev Cc: pcp@oss.sgi.com In-Reply-To: <19292.18578.486513.899049@iinet.net.au> References: <19292.18578.486513.899049@iinet.net.au> Content-Type: text/plain; charset="UTF-8" Date: Mon, 25 Jan 2010 07:34:42 +1100 Message-ID: <1264365282.5401.3.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail18.adl2.internode.on.net[150.101.137.103] X-Barracuda-Start-Time: 1264365294 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0001 1.0000 -2.0204 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20694 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Max, I'd expect 2 entries (assuming the initial PMDA_CACHE_LOAD loads nothing), and both of these should be inactive. As the man page says ... This operation loads the cache from the external file, and then all cache entries are marked inactive, and the additional data pointer is set to NULL. Consequently, a PMDA is only likely to perform this operation once per execution. What are you seeing? Is there some reason you need to call PMDA_CACHE_LOAD a second time? On Mon, 2010-01-25 at 00:18 +1100, Max Matveev wrote: > Ken, > > As the author of pmdaCache, what is the behaviour you would expect > of the following sequence of calls (assuming that the cached file > for the indom exists and contains entries for ook and eek): > > pmdaCacheOp(indom, PMDA_CACHE_LOAD); > pmdaCacheStore(indom, PMDA_CACHE_ADD, "ook", NULL); > pmdaCacheStore(indom, PMDA_CACHE_ADD, "eek", NULL); > pmdaCacheOp(indom, PMDA_CACHE_STORE); > pmdaCacheOp(indom, PMDA_CACHE_LOAD); > > In particular, how many entries will be in the cache after CACHE_LOAD, > how many will be active and how many will be inactive? > > The reason I'm asking is because I've had to chase a bug in my code > which did just that and broke pmdaInstance callback. > > max > > _______________________________________________ > pcp mailing list > pcp@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/pcp From makc@iinet.net.au Sun Jan 24 15:52:46 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0OLqjvt013088 for ; Sun, 24 Jan 2010 15:52:46 -0600 X-ASG-Debug-ID: 1264370026-459b01640000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from outbound.icp-qv1-irony-out3.iinet.net.au (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id AE3ADF450B8 for ; Sun, 24 Jan 2010 13:53:46 -0800 (PST) Received: from outbound.icp-qv1-irony-out3.iinet.net.au (outbound.icp-qv1-irony-out3.iinet.net.au [203.59.1.148]) by cuda.sgi.com with ESMTP id MpUlHHx76D9Bw87E for ; Sun, 24 Jan 2010 13:53:46 -0800 (PST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAAtQXEvL2Rwk/2dsb2JhbADUD4Q7BA X-IronPort-AV: E=Sophos;i="4.49,335,1262534400"; d="scan'208";a="546270924" Received: from unknown (HELO alma.crabbed.net) ([203.217.28.36]) by outbound.icp-qv1-irony-out3.iinet.net.au with ESMTP; 25 Jan 2010 05:53:33 +0800 Received: by alma.crabbed.net (Postfix, from userid 501) id 7E423C810A; Mon, 25 Jan 2010 08:53:33 +1100 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19292.49501.402549.217702@iinet.net.au> Date: Mon, 25 Jan 2010 08:53:33 +1100 From: Max Matveev To: kenj@internode.on.net Cc: pcp@oss.sgi.com X-ASG-Orig-Subj: Re: [pcp] pmda instance cache operations Subject: Re: [pcp] pmda instance cache operations In-Reply-To: <1264365282.5401.3.camel@bozo.localdomain> References: <19292.18578.486513.899049@iinet.net.au> <1264365282.5401.3.camel@bozo.localdomain> X-Mailer: VM 7.17 under 21.4 (patch 19) "Constant Variable" XEmacs Lucid X-Barracuda-Connect: outbound.icp-qv1-irony-out3.iinet.net.au[203.59.1.148] X-Barracuda-Start-Time: 1264370028 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20699 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Mon, 25 Jan 2010 07:34:42 +1100, Ken McDonell wrote: kenj> Max, kenj> I'd expect 2 entries (assuming the initial PMDA_CACHE_LOAD loads kenj> nothing), and both of these should be inactive. kenj> As the man page says ... kenj> This operation loads the cache from the external file, and then kenj> all cache entries are marked inactive, and the additional data kenj> pointer is set to NULL. Consequently, a PMDA is only likely to kenj> perform this operation once per execution. kenj> What are you seeing? I'm seeing 4 entries: 2 active, 2 inactive, one for each instance ID, i.e 0 (ook) active and inactive, 1 (eek) active and inactive. kenj> Is there some reason you need to call PMDA_CACHE_LOAD a second time? It was a bug in my code, I did not want to do that but it could be considered that other people may. max From kenj@internode.on.net Sun Jan 24 16:39:04 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.3 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0OMd4KY015154 for ; Sun, 24 Jan 2010 16:39:04 -0600 X-ASG-Debug-ID: 1264372805-17cf01ce0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id C9C231C75B43 for ; Sun, 24 Jan 2010 14:40:06 -0800 (PST) Received: from mail.internode.on.net (bld-mail19.adl2.internode.on.net [150.101.137.104]) by cuda.sgi.com with ESMTP id l3071H6N1HZ5nwjl for ; Sun, 24 Jan 2010 14:40:06 -0800 (PST) Received: from [192.168.1.100] (unverified [118.209.153.242]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11468954-1927428 for multiple; Mon, 25 Jan 2010 09:10:05 +1030 (CDT) X-ASG-Orig-Subj: Re: [pcp] pmda instance cache operations Subject: Re: [pcp] pmda instance cache operations From: Ken McDonell Reply-To: kenj@internode.on.net To: Max Matveev Cc: pcp@oss.sgi.com In-Reply-To: <19292.49501.402549.217702@iinet.net.au> References: <19292.18578.486513.899049@iinet.net.au> <1264365282.5401.3.camel@bozo.localdomain> <19292.49501.402549.217702@iinet.net.au> Content-Type: text/plain; charset="UTF-8" Date: Mon, 25 Jan 2010 09:39:56 +1100 Message-ID: <1264372796.5401.13.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail19.adl2.internode.on.net[150.101.137.104] X-Barracuda-Start-Time: 1264372807 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0080 1.0000 -1.9689 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.97 X-Barracuda-Spam-Status: No, SCORE=-1.97 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20702 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean OK, there are NO checks in the code at the moment! So, what do you think the correct outcome should be? a) second pmdaCacheOp(indom, PMDA_CACHE_LOAD) returns an error? b) pmdaCacheOp(indom, PMDA_CACHE_LOAD) fails if anything already in the cache? c) purge cache first then load, so 2 inactive instances? d) cache state wins if loaded instance already in cache? I'd vote for b) which is a very similar to a), but a little easier to explain and deals with the more subtle no load, store an instance, then try to load flawed logic. On Mon, 2010-01-25 at 08:53 +1100, Max Matveev wrote: > On Mon, 25 Jan 2010 07:34:42 +1100, Ken McDonell wrote: > > kenj> Max, > kenj> I'd expect 2 entries (assuming the initial PMDA_CACHE_LOAD loads > kenj> nothing), and both of these should be inactive. > > kenj> As the man page says ... > kenj> This operation loads the cache from the external file, and then > kenj> all cache entries are marked inactive, and the additional data > kenj> pointer is set to NULL. Consequently, a PMDA is only likely to > kenj> perform this operation once per execution. > > kenj> What are you seeing? > I'm seeing 4 entries: 2 active, 2 inactive, one for each instance ID, > i.e 0 (ook) active and inactive, 1 (eek) active and inactive. > > kenj> Is there some reason you need to call PMDA_CACHE_LOAD a second time? > It was a bug in my code, I did not want to do that but it could be > considered that other people may. > > max From makc@iinet.net.au Sun Jan 24 19:50:31 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0P1oUiF023436 for ; Sun, 24 Jan 2010 19:50:31 -0600 X-ASG-Debug-ID: 1264384291-41c402090000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from outbound.icp-qv1-irony-out2.iinet.net.au (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id E8B861C75DC6 for ; Sun, 24 Jan 2010 17:51:32 -0800 (PST) Received: from outbound.icp-qv1-irony-out2.iinet.net.au (outbound.icp-qv1-irony-out2.iinet.net.au [203.59.1.107]) by cuda.sgi.com with ESMTP id wrqbdPcmNDHnuB8O for ; Sun, 24 Jan 2010 17:51:32 -0800 (PST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAEuIXEvL2Rwk/2dsb2JhbADVSIQ7BA X-IronPort-AV: E=Sophos;i="4.49,336,1262534400"; d="scan'208";a="599817698" Received: from unknown (HELO alma.crabbed.net) ([203.217.28.36]) by outbound.icp-qv1-irony-out2.iinet.net.au with ESMTP; 25 Jan 2010 09:51:29 +0800 Received: by alma.crabbed.net (Postfix, from userid 501) id CE7D1C827C; Mon, 25 Jan 2010 12:51:28 +1100 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19292.63776.791122.269945@iinet.net.au> Date: Mon, 25 Jan 2010 12:51:28 +1100 From: Max Matveev To: kenj@internode.on.net Cc: pcp@oss.sgi.com X-ASG-Orig-Subj: Re: [pcp] pmda instance cache operations Subject: Re: [pcp] pmda instance cache operations In-Reply-To: <1264372796.5401.13.camel@bozo.localdomain> References: <19292.18578.486513.899049@iinet.net.au> <1264365282.5401.3.camel@bozo.localdomain> <19292.49501.402549.217702@iinet.net.au> <1264372796.5401.13.camel@bozo.localdomain> X-Mailer: VM 7.17 under 21.4 (patch 19) "Constant Variable" XEmacs Lucid X-Barracuda-Connect: outbound.icp-qv1-irony-out2.iinet.net.au[203.59.1.107] X-Barracuda-Start-Time: 1264384293 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0001 1.0000 -2.0204 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20716 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Mon, 25 Jan 2010 09:39:56 +1100, Ken McDonell wrote: kenj> So, what do you think the correct outcome should be? kenj> a) second pmdaCacheOp(indom, PMDA_CACHE_LOAD) returns an error? kenj> b) pmdaCacheOp(indom, PMDA_CACHE_LOAD) fails if anything already in the kenj> cache? kenj> c) purge cache first then load, so 2 inactive instances? kenj> d) cache state wins if loaded instance already in cache? kenj> I'd vote for b) which is a very similar to a), but a little easier to kenj> explain and deals with the more subtle no load, store an instance, then kenj> try to load flawed logic. In my particular case d) is what I was expecting but then I wasn't expecting the second LOAD. I can live with b), just need to get into the habit of checking return values from LOAD. On the somewhat related note, am I correct in assuming that pmdaCacheOp(indom, PMDA_CACHE_CULL) is the only option to clean all the entires in the cache in preparation to the second loading? max From kenj@internode.on.net Sun Jan 24 23:42:19 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.3 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0P5gJ1v033771 for ; Sun, 24 Jan 2010 23:42:19 -0600 X-ASG-Debug-ID: 1264398200-3581033b0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id D6F141887FC for ; Sun, 24 Jan 2010 21:43:21 -0800 (PST) Received: from mail.internode.on.net (bld-mail18.adl2.internode.on.net [150.101.137.103]) by cuda.sgi.com with ESMTP id TPg5Zdikgt4TE8e7 for ; Sun, 24 Jan 2010 21:43:21 -0800 (PST) Received: from [192.168.1.100] (unverified [118.209.153.242]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11549051-1927428 for multiple; Mon, 25 Jan 2010 16:13:20 +1030 (CDT) X-ASG-Orig-Subj: Re: [pcp] pmda instance cache operations Subject: Re: [pcp] pmda instance cache operations From: Ken McDonell Reply-To: kenj@internode.on.net To: Max Matveev Cc: pcp@oss.sgi.com In-Reply-To: <19292.63776.791122.269945@iinet.net.au> References: <19292.18578.486513.899049@iinet.net.au> <1264365282.5401.3.camel@bozo.localdomain> <19292.49501.402549.217702@iinet.net.au> <1264372796.5401.13.camel@bozo.localdomain> <19292.63776.791122.269945@iinet.net.au> Content-Type: text/plain; charset="UTF-8" Date: Mon, 25 Jan 2010 16:43:11 +1100 Message-ID: <1264398191.5401.17.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail18.adl2.internode.on.net[150.101.137.103] X-Barracuda-Start-Time: 1264398202 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0353 1.0000 -1.7928 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.79 X-Barracuda-Spam-Status: No, SCORE=-1.79 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20730 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean OK, d) is probably most sensible and not hard (now I've looked at the code), so I'll implement that option. And yep, pmdaCacheOp(indom, PMDA_CACHE_CULL) will clean the cache for that indom. On Mon, 2010-01-25 at 12:51 +1100, Max Matveev wrote: > On Mon, 25 Jan 2010 09:39:56 +1100, Ken McDonell wrote: > > kenj> So, what do you think the correct outcome should be? > > kenj> a) second pmdaCacheOp(indom, PMDA_CACHE_LOAD) returns an error? > kenj> b) pmdaCacheOp(indom, PMDA_CACHE_LOAD) fails if anything already in the > kenj> cache? > kenj> c) purge cache first then load, so 2 inactive instances? > kenj> d) cache state wins if loaded instance already in cache? > > kenj> I'd vote for b) which is a very similar to a), but a little easier to > kenj> explain and deals with the more subtle no load, store an instance, then > kenj> try to load flawed logic. > > In my particular case d) is what I was expecting but then I wasn't > expecting the second LOAD. I can live with b), just need to get into > the habit of checking return values from LOAD. > > On the somewhat related note, am I correct in assuming that > pmdaCacheOp(indom, PMDA_CACHE_CULL) is the only option to clean > all the entires in the cache in preparation to the second loading? > > max From daw@sgi.com Mon Jan 25 12:46:57 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0PIkv5b070278 for ; Mon, 25 Jan 2010 12:46:57 -0600 Received: from zion.americas.sgi.com (zion.americas.sgi.com [128.162.236.17]) by relay2.corp.sgi.com (Postfix) with ESMTP id 9BC6B304098 for ; Mon, 25 Jan 2010 10:47:58 -0800 (PST) Received: (from daw@localhost) by zion.americas.sgi.com (8.12.9/ASC-news-1.4) id o0PIlwVD33846485 for pcp@oss.sgi.com; Mon, 25 Jan 2010 12:47:58 -0600 (CST) Message-Id: <201001251847.o0PIlwVD33846485@zion.americas.sgi.com> Subject: Oracle PMDA To: pcp@oss.sgi.com Date: Mon, 25 Jan 2010 12:47:58 -0600 (CST) From: David Wright X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Hello, Are there plans to revive the Oracle PMDA we had in IRIX days? thanks, Dave Wright From nscott@aconex.com Mon Jan 25 15:05:54 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0PL5sHO075923 for ; Mon, 25 Jan 2010 15:05:54 -0600 X-ASG-Debug-ID: 1264453616-319f01a10000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 6744D1C79488 for ; Mon, 25 Jan 2010 13:06:57 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id 5d8GBCH71kMPgGc7 for ; Mon, 25 Jan 2010 13:06:57 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id B67DD20876F; Tue, 26 Jan 2010 08:06:55 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id ILU2e2b4bz1ZDiL1; Tue, 26 Jan 2010 08:06:55 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id E623CA5028C; Tue, 26 Jan 2010 08:04:36 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id A5944488398; Tue, 26 Jan 2010 08:06:55 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0UZ9lWU8fq08; Tue, 26 Jan 2010 08:06:51 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id B255D488396; Tue, 26 Jan 2010 08:06:51 +1100 (EST) Date: Tue, 26 Jan 2010 08:06:51 +1100 (EST) From: Nathan Scott To: David Wright Cc: pcp@oss.sgi.com Message-ID: <1722051001.2023621264453611632.JavaMail.root@mail-au.aconex.com> In-Reply-To: <201001251847.o0PIlwVD33846485@zion.americas.sgi.com> X-ASG-Orig-Subj: Re: [pcp] Oracle PMDA Subject: Re: [pcp] Oracle PMDA MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [211.28.150.226] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - SAF3 (Mac)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1264453618 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20781 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ----- "David Wright" wrote: > Hello, > > Are there plans to revive the Oracle PMDA we had in IRIX days? > Sort of. The original version of the Oracle PMDA was a maintenance nightmare - trying to make a single binary work for more than one Oracle release was extremely painful (it was C code back then). Since then, other ways of addressing that problem have come about - in particular, the Perl PMDA API and DBI::Oracle solve the worst of the problems in that space. SGI kindly made available enough of the original Oracle PMDA (pmns, help text and metric descriptors) to seed development of a revised PMDA. I wrote an initial strawman pmdaoracle.pl - it is in the git tree (not the source tarballs) at src/pmdas/oracle/pmdaoracle.pl. Since I'm not currently using Oracle myself nowadays though, its not complete and needs someone who needs it to take that code, finish it it off and use it in anger. There are other working Perl DB PMDAs - like pmdadbping.pl and pmdamysql.pl, that might be useful references for someone tackling that project. cheers. -- Nathan From kenj@internode.on.net Mon Jan 25 18:53:23 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0Q0rMhw088298 for ; Mon, 25 Jan 2010 18:53:22 -0600 X-ASG-Debug-ID: 1264467264-5ac0037c0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5D4391C79AB5 for ; Mon, 25 Jan 2010 16:54:24 -0800 (PST) Received: from mail.internode.on.net (bld-mail16.adl2.internode.on.net [150.101.137.101]) by cuda.sgi.com with ESMTP id 3aNNUSGB8HAQuEu1 for ; Mon, 25 Jan 2010 16:54:24 -0800 (PST) Received: from [192.168.1.100] (unverified [118.209.153.242]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11566930-1927428 for ; Tue, 26 Jan 2010 11:24:23 +1030 (CDT) X-ASG-Orig-Subj: pcp updates Subject: pcp updates From: Ken McDonell Reply-To: kenj@internode.on.net To: pcp@oss.sgi.com Content-Type: text/plain; charset="UTF-8" Date: Tue, 26 Jan 2010 11:54:14 +1100 Message-ID: <1264467254.20487.5.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail16.adl2.internode.on.net[150.101.137.101] X-Barracuda-Start-Time: 1264467266 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0026 1.0000 -2.0042 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.00 X-Barracuda-Spam-Status: No, SCORE=-2.00 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20795 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean I regression fix (mmv Install) and one late-breaking issue (pmdaCache LOAD). Changes committed to git://oss.sgi.com/kenj/pcp.git dev man/man1/pmnsadd.1 | 12 +++++++++ man/man3/pmdacache.3 | 20 ++++++++++++++-- src/include/pmda.h | 1 src/libpcp_pmda/src/cache.c | 55 +++++++++++++++++++++++++++++++++----------- src/pmdas/mmv/GNUmakefile | 2 - src/pmdas/mmv/Install | 1 src/pmns/pmnsadd | 52 ++++++++++++++++++++++++----------------- 7 files changed, 106 insertions(+), 37 deletions(-) commit 3e39dcd55b327dfebd5039238a8ae6e4018dd8cc Merge: 6a10cc8 775e969 Author: Ken McDonell Date: Tue Jan 26 10:29:44 2010 +1100 Merge branch 'pmdacache' into dev commit 6a10cc8f47eff40dfccd7f25a4caf1b774c75087 Author: Ken McDonell Date: Tue Jan 26 10:25:09 2010 +1100 mmv Install issue fixed Since the mmv PMDA was promoted to one of the "install by default" PMDAs, the Install script comman no longer worked ... a fall out from going from root + pmns to describe the PMDA's PMNS to using root_mmv. The fix is to extend pmnsadd to recognize when it is given a complete PMNS to work with, rather than the usual subtree of the PMNS case and make sure root_mmv is available in the PMDA directory. commit 775e969acedb9e41aa1a9f7e030cd321bdc99267 Author: Ken McDonell Date: Tue Jan 26 09:25:48 2010 +1100 pmdaCache Fix corner case in LOAD logic Problem identified by Max Matveev. When the cache is already populated, the LOAD operation needs to honour existing cache state and report any inconsistencies (and not load the offending entries). Also added PMDA_CACHE_DUMP to pmdaCacheOp() to aid debugging. From kenj@internode.on.net Mon Jan 25 18:57:07 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX,J_CHICKENPOX_34 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0Q0v7m5088731 for ; Mon, 25 Jan 2010 18:57:07 -0600 X-ASG-Debug-ID: 1264467489-2dfb02240000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 4FDF51C79BBD for ; Mon, 25 Jan 2010 16:58:10 -0800 (PST) Received: from mail.internode.on.net (bld-mail17.adl2.internode.on.net [150.101.137.102]) by cuda.sgi.com with ESMTP id DzJiaSCMIIB5AkL2 for ; Mon, 25 Jan 2010 16:58:10 -0800 (PST) Received: from [192.168.1.100] (unverified [118.209.153.242]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11429437-1927428 for ; Tue, 26 Jan 2010 11:28:08 +1030 (CDT) X-ASG-Orig-Subj: pcpqa updates Subject: pcpqa updates From: Ken McDonell Reply-To: kenj@internode.on.net To: pcp@oss.sgi.com Content-Type: text/plain; charset="UTF-8" Date: Tue, 26 Jan 2010 11:57:59 +1100 Message-ID: <1264467479.20487.6.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail17.adl2.internode.on.net[150.101.137.102] X-Barracuda-Start-Time: 1264467491 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20795 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Changes committed to git://oss.sgi.com/pcp/pcpqa.git 003 | 3 213 | 2 341 | 59 +++++++++++++++++++ 341.out | 160 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 639.out | 4 + group | 1 owner | 1 src-oss/.gitignore | 2 src-oss/GNUmakefile | 6 + src-oss/pmdacache.c | 98 +++++++++++++++++++++++++++++++ 10 files changed, 332 insertions(+), 4 deletions(-) commit b87340aad451c751a73b94d6241f261417569abd Author: Ken McDonell Date: Tue Jan 26 11:50:38 2010 +1100 639 pmnsadd change I think this has been wrong forever ... result now appears correct after recent pmnsadd change. commit 2133709e94dd8b9f011336cca2eef0e68c75e087 Author: Ken McDonell Date: Tue Jan 26 09:25:01 2010 +1100 003 Small tweak for mem.numa filtering commit 27f57c065fcece360d2a6aa50d6b782687e6544f Author: Ken McDonell Date: Tue Jan 26 09:22:42 2010 +1100 341 Check corner cases for pmdaCache ... LOAD Problem identified by Max. commit 5e29278bc2d007b8e5b976990469f6d84b84a337 Merge: 7e1e1c8 b4f6a34 Author: Ken McDonell Date: Mon Jan 25 20:51:08 2010 +1100 Merge branch 'master' of git://oss.sgi.com/pcp/pcpqa commit 7e1e1c8fda6f35186b35421f65a821a7a4e87750 Merge: 6a33236 010cb6b Author: Ken McDonell Date: Mon Jan 25 14:13:25 2010 +1100 Merge branch 'master' of git://oss.sgi.com/pcp/pcpqa commit 6a3323682f152201ebf9b9f53d274389fa7c1728 Author: Ken McDonell Date: Tue Jan 19 21:13:33 2010 +1100 213 tweak to use local pmns Don't assume the mmv pmda is installed. From makc@iinet.net.au Mon Jan 25 21:34:19 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0Q3YH1f096983 for ; Mon, 25 Jan 2010 21:34:18 -0600 X-ASG-Debug-ID: 1264476919-48c503bd0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from outbound.icp-qv1-irony-out6.iinet.net.au (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id D5A1D18B969 for ; Mon, 25 Jan 2010 19:35:20 -0800 (PST) Received: from outbound.icp-qv1-irony-out6.iinet.net.au (outbound.icp-qv1-irony-out6.iinet.net.au [203.59.1.109]) by cuda.sgi.com with ESMTP id 3wD5lNNBGPb1UdpD for ; Mon, 25 Jan 2010 19:35:20 -0800 (PST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAIPxXUvL2Rwk/2dsb2JhbADZSYQ5BA X-IronPort-AV: E=Sophos;i="4.49,344,1262534400"; d="scan'208";a="54891789" Received: from unknown (HELO alma.crabbed.net) ([203.217.28.36]) by outbound.icp-qv1-irony-out6.iinet.net.au with ESMTP; 26 Jan 2010 11:35:18 +0800 Received: by alma.crabbed.net (Postfix, from userid 501) id B61F5C8929; Tue, 26 Jan 2010 14:35:17 +1100 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19294.25333.630904.326323@iinet.net.au> Date: Tue, 26 Jan 2010 14:35:17 +1100 From: Max Matveev To: pcp@oss.sgi.com X-ASG-Orig-Subj: pcp updates Subject: pcp updates X-Mailer: VM 7.17 under 21.4 (patch 19) "Constant Variable" XEmacs Lucid X-Barracuda-Connect: outbound.icp-qv1-irony-out6.iinet.net.au[203.59.1.109] X-Barracuda-Start-Time: 1264476921 X-Barracuda-Bayes: INNOCENT GLOBAL 0.1459 1.0000 -1.1243 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.12 X-Barracuda-Spam-Status: No, SCORE=-1.12 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20804 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Small fix to teach pmdaproc about Solaris' ping. The following changes since commit 4318547118e4ab304bf4c2acf6baf7e6c116fb00: Nathan Scott (1): Bump development branch version to 3.1.0 for planned release. are available in the git repository at: git://oss.sgi.com/makc/pcp pmdaproc Max Matveev (1): Teach pmdaproc about Solaris' ping. src/pmcd/pmdaproc.sh | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) From kenj@internode.on.net Tue Jan 26 13:31:30 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.9 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX, URIBL_BLACK autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0QJVTR1142059 for ; Tue, 26 Jan 2010 13:31:30 -0600 X-ASG-Debug-ID: 1264534352-459c03590000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id CCE561202FA6 for ; Tue, 26 Jan 2010 11:32:32 -0800 (PST) Received: from mail.internode.on.net (bld-mail13.adl6.internode.on.net [150.101.137.98]) by cuda.sgi.com with ESMTP id gOfATPyg8IpGqxIY for ; Tue, 26 Jan 2010 11:32:32 -0800 (PST) Received: from [192.168.1.100] (unverified [118.209.153.242]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11671894-1927428 for ; Wed, 27 Jan 2010 06:02:30 +1030 (CDT) X-ASG-Orig-Subj: pcp updates Subject: pcp updates From: Ken McDonell Reply-To: kenj@internode.on.net To: pcp@oss.sgi.com Content-Type: text/plain; charset="UTF-8" Date: Wed, 27 Jan 2010 06:32:20 +1100 Message-ID: <1264534340.27611.1.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail13.adl6.internode.on.net[150.101.137.98] X-Barracuda-Start-Time: 1264534353 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0569 1.0000 -1.6569 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.66 X-Barracuda-Spam-Status: No, SCORE=-1.66 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20863 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean I'll leave to the release consortium to decide if this should be in 3.1 or held over. Works fine on all the platforms I can test, passes QA -g dbpmda on Linux. Changes committed to git://oss.sgi.com/kenj/pcp.git dev configure.in | 31 ++++++++++ man/man1/dbpmda.1 | 16 +++++ src/dbpmda/src/GNUmakefile | 2 src/dbpmda/src/dbpmda.c | 2 src/dbpmda/src/lex.l | 117 ++++++++++++++++++++++++++++++++++------- src/include/builddefs.in | 2 src/include/platform_defs.h.in | 1 7 files changed, 150 insertions(+), 21 deletions(-) commit aa965191c671b0148bc99bd5fbc82dacc8ef44a2 Author: Ken McDonell Date: Wed Jan 27 06:25:23 2010 +1100 readline for dbpmda Thanks to Andrew Wansink fo showing how this could be done and providing the initial patches. This checkin refines that work so that readline() is used when it is available (and when the lexer is flex) but only when the command input is coming from a tty device. This version also works on vanilla Mac OS X. The same approach could also be used also for the non-flex lexers, but I don't have any way of testing these. From kenj@internode.on.net Tue Jan 26 13:39:14 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0QJdE85142576 for ; Tue, 26 Jan 2010 13:39:14 -0600 X-ASG-Debug-ID: 1264534816-6c3b03640000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 980B81C7DADA for ; Tue, 26 Jan 2010 11:40:16 -0800 (PST) Received: from mail.internode.on.net (bld-mail14.adl6.internode.on.net [150.101.137.99]) by cuda.sgi.com with ESMTP id 5bU9MOJZAsXAYWfb for ; Tue, 26 Jan 2010 11:40:16 -0800 (PST) Received: from [192.168.1.100] (unverified [118.209.153.242]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11732529-1927428 for ; Wed, 27 Jan 2010 06:10:15 +1030 (CDT) X-ASG-Orig-Subj: pcp updates Subject: pcp updates From: Ken McDonell Reply-To: kenj@internode.on.net To: pcp@oss.sgi.com Content-Type: text/plain; charset="UTF-8" Date: Wed, 27 Jan 2010 06:40:04 +1100 Message-ID: <1264534804.27611.2.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail14.adl6.internode.on.net[150.101.137.99] X-Barracuda-Start-Time: 1264534818 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0356 1.0000 -1.7913 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.79 X-Barracuda-Spam-Status: No, SCORE=-1.79 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20864 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Changes committed to git://oss.sgi.com/kenj/pcp.git dev src/libpcp/src/derive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d225623b22db8a7be83d2b932a2c8a4da23ca2b7 Author: Ken McDonell Date: Wed Jan 27 06:34:57 2010 +1100 derived metrics - 64-bit platform fix Small fix to address Nathan's reported QA 225 failure on 64-bit platforms. From nscott@aconex.com Tue Jan 26 21:24:01 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX,J_CHICKENPOX_53 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0R3O0BG163937 for ; Tue, 26 Jan 2010 21:24:00 -0600 X-ASG-Debug-ID: 1264562703-2d6200c80000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id AEF99F5C943 for ; Tue, 26 Jan 2010 19:25:03 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id ZyZ8Q6MYVMGDZsPq for ; Tue, 26 Jan 2010 19:25:03 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id DD9DF6FEC8D; Wed, 27 Jan 2010 14:24:59 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id 6X7TDwCLOU2Fhzsb; Wed, 27 Jan 2010 14:24:59 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 680FBA50133; Wed, 27 Jan 2010 14:22:40 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id CDB8D4883AA; Wed, 27 Jan 2010 14:24:59 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NQAmZ21MBR96; Wed, 27 Jan 2010 14:24:55 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id CF48048839F; Wed, 27 Jan 2010 14:24:55 +1100 (EST) Date: Wed, 27 Jan 2010 14:24:55 +1100 (EST) From: Nathan Scott To: kenj@internode.on.net Cc: pcp@oss.sgi.com Message-ID: <942897914.2064401264562695268.JavaMail.root@mail-au.aconex.com> In-Reply-To: <1264467479.20487.6.camel@bozo.localdomain> X-ASG-Orig-Subj: Re: [pcp] pcpqa updates Subject: Re: [pcp] pcpqa updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1264562704 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20895 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ----- "Ken McDonell" wrote: > Changes committed to git://oss.sgi.com/pcp/pcpqa.git > ... > 341 | 59 +++++++++++++++++++ > 341.out | 160 > ++++++++++++++++++++++++++++++++++++++++++++++++++++ I'm getting this from 341: 341 - output mismatch (see 341.out.bad) 115c115 < store(urk a bit tricky) -> 0 --- > store(urk\) -> 0 117,118c117,118 < [DATE] pmdacache(PID) Warning: pmdaCacheOp: $PCP_VAR_DIR/config/pmda/0.123: loading instance 0 ("eek") ignored, already in cache as 0 ("urk a bit tricky") < [DATE] pmdacache(PID) Warning: pmdaCacheOp: $PCP_VAR_DIR/config/pmda/0.123: loading instance 1 ("urk") ignored, already in cache as 0 ("urk a bit tricky") --- > [DATE] pmdacache(PID) Warning: pmdaCacheOp: $PCP_VAR_DIR/config/pmda/0.123: loading instance 0 ("eek") ignored, already in cache as 0 ("urk\") > [DATE] pmdacache(PID) Warning: pmdaCacheOp: $PCP_VAR_DIR/config/pmda/0.123: loading instance 1 ("urk") ignored, already in cache as 1 ("eek") 121c121 < 0 active (nil) urk a bit tricky [match len=3] --- > 0 active (nil) urk\ 125c125 < 0 active (nil) urk a bit tricky [match len=3] --- > 0 active (nil) urk\ 152c152 < [007] -> 0 --- > [007] 158c158 < [013] --- > [013] -> 0 cheers. -- Nathan From nscott@aconex.com Tue Jan 26 23:55:48 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0R5tmV2171237 for ; Tue, 26 Jan 2010 23:55:48 -0600 X-ASG-Debug-ID: 1264571810-208100da0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 65539F114F1 for ; Tue, 26 Jan 2010 21:56:51 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id cEGQuMzANgTSpIWX for ; Tue, 26 Jan 2010 21:56:51 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id A448B88FFE9 for ; Wed, 27 Jan 2010 16:56:48 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id 3Bce312I58i8ln03 for ; Wed, 27 Jan 2010 16:56:48 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 8E5ECA5028C for ; Wed, 27 Jan 2010 16:54:26 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 09BD14883A4 for ; Wed, 27 Jan 2010 16:56:46 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bQ2FJ8ODezhK for ; Wed, 27 Jan 2010 16:56:42 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 0D3C24883AB for ; Wed, 27 Jan 2010 16:56:42 +1100 (EST) Date: Wed, 27 Jan 2010 16:56:41 +1100 (EST) From: Nathan Scott To: pcp@oss.sgi.com Message-ID: <2110358696.2071351264571801882.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcpqa updates Subject: pcpqa updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1264571812 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.52 X-Barracuda-Spam-Status: No, SCORE=-1.52 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20904 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M X-Virus-Status: Clean Changes committed to git://oss.sgi.com/pcp/pcpqa.git 008.out.edge | 17 ++++--------- 213.out | 1 262 | 1 647 | 15 +++-------- 648 | 25 +++++++------------ 649 | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++- 649.out | 21 ++++++++++++++++ group | 1 owner | 1 src-oss/mmv_poke.c | 10 ++++--- 10 files changed, 115 insertions(+), 44 deletions(-) commit e44f2079ff805e7ac446802d494e5ab0ae15f160 Author: Nathan Scott Date: Wed Jan 27 16:51:04 2010 +1100 Minor consistency/cleanup in 647 in pmdammv area. commit 5cc2b56f673bf601240ecb28a42b34146c5cf785 Author: Nathan Scott Date: Wed Jan 27 16:50:28 2010 +1100 Make test match (correct) error handling behaviour of pmdammv for pid==0. commit 4eaff4ad85174ceed0b61ec4a71a8538880a1c1e Author: Nathan Scott Date: Wed Jan 27 16:22:27 2010 +1100 Stop creating an unused file (pmie.conf). commit 61ae1cc576bfe7f3ea9af4161177fce3f95cf98d Author: Nathan Scott Date: Wed Jan 27 16:13:09 2010 +1100 Remove delays from some mmv tests - no longer needed with dynamic PMNS. commit be725417a0e9fd7e64ce226db489d92e3409b4b6 Author: Nathan Scott Date: Wed Jan 27 16:12:24 2010 +1100 pmdammv was changed to be less verbose on startup, make 213 output match. commit 630a27f40eef9eba9f8ce0f6919d7ff2e92f3fcc Author: Nathan Scott Date: Wed Jan 27 16:11:36 2010 +1100 Tweak my local host disk config once more. commit d92165d39e04cb3d3a389642e7e9582c523ec7a5 Author: Nathan Scott Date: Wed Jan 27 16:10:21 2010 +1100 Add new pmdammv test exercising the various client flags. Modified mmv_poke test program to allow invalid PIDs to be set, and also to ensure it updates the generation number whenever it modifies the contents of the file. From kenj@internode.on.net Wed Jan 27 06:00:13 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX, J_CHICKENPOX_53 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0RC0DGE189215 for ; Wed, 27 Jan 2010 06:00:13 -0600 X-ASG-Debug-ID: 1264593676-1b3d03480000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id ED53A19A74FE for ; Wed, 27 Jan 2010 04:01:16 -0800 (PST) Received: from mail.internode.on.net (bld-mail19.adl2.internode.on.net [150.101.137.104]) by cuda.sgi.com with ESMTP id UBWxR9W8BJ4SPg22 for ; Wed, 27 Jan 2010 04:01:16 -0800 (PST) Received: from [192.168.1.100] (unverified [118.209.153.242]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11479153-1927428 for multiple; Wed, 27 Jan 2010 22:31:14 +1030 (CDT) X-ASG-Orig-Subj: Re: [pcp] pcpqa updates Subject: Re: [pcp] pcpqa updates From: Ken McDonell Reply-To: kenj@internode.on.net To: Nathan Scott Cc: pcp@oss.sgi.com In-Reply-To: <942897914.2064401264562695268.JavaMail.root@mail-au.aconex.com> References: <942897914.2064401264562695268.JavaMail.root@mail-au.aconex.com> Content-Type: multipart/mixed; boundary="=-YotM8F1OT7eY47Rc6b2V" Date: Wed, 27 Jan 2010 23:01:04 +1100 Message-ID: <1264593664.14810.8.camel@bozo.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 X-Barracuda-Connect: bld-mail19.adl2.internode.on.net[150.101.137.104] X-Barracuda-Start-Time: 1264593677 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20926 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean --=-YotM8F1OT7eY47Rc6b2V Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit OK, I think this is a shell escaping inconsistency in the QA test, not a problem with the pmdaCache code ... could you please try the attached 341 and see if it passes? On Wed, 2010-01-27 at 14:24 +1100, Nathan Scott wrote: > ----- "Ken McDonell" wrote: > > > Changes committed to git://oss.sgi.com/pcp/pcpqa.git > > ... > > 341 | 59 +++++++++++++++++++ > > 341.out | 160 > > ++++++++++++++++++++++++++++++++++++++++++++++++++++ > > I'm getting this from 341: > > 341 - output mismatch (see 341.out.bad) > 115c115 > < store(urk a bit tricky) -> 0 > --- > > store(urk\) -> 0 > 117,118c117,118 > < [DATE] pmdacache(PID) Warning: pmdaCacheOp: $PCP_VAR_DIR/config/pmda/0.123: loading instance 0 ("eek") ignored, already in cache as 0 ("urk a bit tricky") > < [DATE] pmdacache(PID) Warning: pmdaCacheOp: $PCP_VAR_DIR/config/pmda/0.123: loading instance 1 ("urk") ignored, already in cache as 0 ("urk a bit tricky") > --- > > [DATE] pmdacache(PID) Warning: pmdaCacheOp: $PCP_VAR_DIR/config/pmda/0.123: loading instance 0 ("eek") ignored, already in cache as 0 ("urk\") > > [DATE] pmdacache(PID) Warning: pmdaCacheOp: $PCP_VAR_DIR/config/pmda/0.123: loading instance 1 ("urk") ignored, already in cache as 1 ("eek") > 121c121 > < 0 active (nil) urk a bit tricky [match len=3] > --- > > 0 active (nil) urk\ > 125c125 > < 0 active (nil) urk a bit tricky [match len=3] > --- > > 0 active (nil) urk\ > 152c152 > < [007] -> 0 > --- > > [007] > 158c158 > < [013] > --- > > [013] -> 0 > > > cheers. > --=-YotM8F1OT7eY47Rc6b2V Content-Type: application/x-shellscript; name="341" Content-Disposition: attachment; filename="341" Content-Transfer-Encoding: 7bit #!/bin/sh # PCP QA Test No. 341 # # exercise corner cases for pmdaCacheOp(...LOAD...) # # Copyright (c) 2010 Ken McDonell. All Rights Reserved. # creator owner=kenj # get standard environment, filters and checks . ./common.product . ./common.filter . ./common.check seq=`basename $0` echo "QA output created by $seq" tmp=/tmp/$$ here=`pwd` sudo=$here/sudo status=0 # success is the default! $sudo rm -rf $tmp.* $seq.full trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15 # [Tue Jan 26 09:10:16] pmdacache(22270) Warning: pmdaCacheOp: /var/lib/pcp/config/pmda/0.123: loading instance 0 ("eek") ignored, already in cache as 0 ("urk") _filter() { sed \ -e 's/^\[[A-Z].. [A-Z].. *[0-9][0-9]* ..:..:..]/[DATE]/' \ -e 's/cache([0-9][0-9]*)/cache(PID)/' \ -e "s;$PCP_VAR_DIR;\$PCP_VAR_DIR;" } # note - need to do everything as sudo because $PCP_VAR_DIR/config/pmda # is not world writeable # $sudo rm -f $PCP_VAR_DIR/config/pmda/0.123 # real QA test starts here echo "load without save, store a couple and save ..." $sudo src-oss/pmdacache -D indom -L -s eek -s urk -S 2>&1 | _filter echo echo "store one, load, store another couple ..." $sudo src-oss/pmdacache -D indom -s eek -L -s urk -s foo -d 2>&1 | _filter echo echo "store some, hide some, load ..." $sudo src-oss/pmdacache -D indom -s eek -s urk -s foo -h eek -h foo -s bar -L -d 2>&1 | _filter echo echo "error case ..." echo "src-oss/pmdacache -D indom -s 'urk a bit tricky' -s eek -L -d" \ | $sudo sh 2>&1 | _filter # success, all done exit --=-YotM8F1OT7eY47Rc6b2V-- From makc@iinet.net.au Wed Jan 27 06:14:51 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0RCEoVs190179 for ; Wed, 27 Jan 2010 06:14:50 -0600 X-ASG-Debug-ID: 1264594553-746f01f70000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from outbound.icp-qv1-irony-out5.iinet.net.au (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 16CB41925D4 for ; Wed, 27 Jan 2010 04:15:53 -0800 (PST) Received: from outbound.icp-qv1-irony-out5.iinet.net.au (outbound.icp-qv1-irony-out5.iinet.net.au [203.59.1.105]) by cuda.sgi.com with ESMTP id aYsUt9NyBlAP0RhJ for ; Wed, 27 Jan 2010 04:15:53 -0800 (PST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAE69X0vL2Rwk/2dsb2JhbADXQ4Q4BA X-IronPort-AV: E=Sophos;i="4.49,353,1262534400"; d="scan'208";a="95997190" Received: from unknown (HELO alma.crabbed.net) ([203.217.28.36]) by outbound.icp-qv1-irony-out5.iinet.net.au with ESMTP; 27 Jan 2010 20:15:51 +0800 Received: by alma.crabbed.net (Postfix, from userid 501) id 9B54BC913A; Wed, 27 Jan 2010 23:15:50 +1100 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19296.11894.92915.864501@iinet.net.au> Date: Wed, 27 Jan 2010 23:15:50 +1100 From: Max Matveev To: pcp@oss.sgi.com X-ASG-Orig-Subj: pcp updates Subject: pcp updates X-Mailer: VM 7.17 under 21.4 (patch 19) "Constant Variable" XEmacs Lucid X-Barracuda-Connect: outbound.icp-qv1-irony-out5.iinet.net.au[203.59.1.105] X-Barracuda-Start-Time: 1264594555 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0451 1.0000 -1.7310 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.73 X-Barracuda-Spam-Status: No, SCORE=-1.73 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20926 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Ken has attempted to use pcp on Solaris and promptly discovered a bunch of deficiencies which I've tried to address. While working on the stuff he needed I've discovered a few other minor problems in the Solaris PMDA which I've also attempted to plug. The following changes since commit 3300d8ecf365ba7a7365a3177f1de730fcd66300: Nathan Scott (1): Get pmdaoracle.pl to the point that it actually Installs. are available in the git repository at: git://oss.sgi.com/makc/pcp onefetch Max Matveev (5): Don't allow internal cache iterators change cache walking state. Tell solaris pmda to only update instances of the domain which is been fetched. Minor cleanup in Solaris' netmib module Plug a memory leak in Solaris PMDA Export physmem size, page size and uname from Solaris pmda man/man3/pmdacache.3 | 6 ++++++ src/libpcp_pmda/src/cache.c | 36 ++++++++++++------------------------ src/pmdas/solaris/common.h | 1 + src/pmdas/solaris/data.c | 16 ++++++++++++++++ src/pmdas/solaris/help | 8 ++++++++ src/pmdas/solaris/netmib2.c | 5 ++--- src/pmdas/solaris/pmns.hinv | 2 ++ src/pmdas/solaris/root | 5 +++++ src/pmdas/solaris/solaris.c | 15 ++++++++------- src/pmdas/solaris/sysinfo.c | 36 ++++++++++++++++++++++++++++++++++++ src/pmdas/solaris/zpool.c | 4 +--- src/pmdas/solaris/zpool_perdisk.c | 5 ++--- 12 files changed, 99 insertions(+), 40 deletions(-) From nscott@aconex.com Wed Jan 27 13:56:49 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0RJun6O211225 for ; Wed, 27 Jan 2010 13:56:49 -0600 X-ASG-Debug-ID: 1264622272-6f3b03b50000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 54C201940EB for ; Wed, 27 Jan 2010 11:57:52 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id ev0lBLQDna7zboKC for ; Wed, 27 Jan 2010 11:57:52 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 699B08908E7; Thu, 28 Jan 2010 06:57:51 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id lrja59co3IMPzP8b; Thu, 28 Jan 2010 06:57:51 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 91351A5011D; Thu, 28 Jan 2010 06:55:31 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 5C773488396; Thu, 28 Jan 2010 06:57:51 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fUwU1bKLosva; Thu, 28 Jan 2010 06:57:46 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id A53034883A4; Thu, 28 Jan 2010 06:57:46 +1100 (EST) Date: Thu, 28 Jan 2010 06:57:46 +1100 (EST) From: Nathan Scott To: Max Matveev Cc: pcp@oss.sgi.com Message-ID: <2101253038.2076101264622266589.JavaMail.root@mail-au.aconex.com> In-Reply-To: <1992950383.2076011264621949257.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: Re: [pcp] pcp updates Subject: Re: [pcp] pcp updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [211.28.150.226] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - SAF3 (Mac)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1264622274 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0037 1.0000 -1.9968 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.00 X-Barracuda-Spam-Status: No, SCORE=-2.00 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20954 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Hi Max, ----- "Max Matveev" wrote: > Ken has attempted to use pcp on Solaris and promptly discovered a > bunch of deficiencies which I've tried to address. While working > on the stuff he needed I've discovered a few other minor problems > in the Solaris PMDA which I've also attempted to plug. As Yoda would say, "Do or Do Not - there is no 'attempted'"! Are you expecting more attempts, or are we good to go for 3.1 (which is planned for today). The cache.c change looks to be low-medium-level risk & OK if it passes QA (I'll do another run this morning); haven't looked at the Solaris changes ... hopefully people with vested interest there will take a close look today. cheers. -- Nathan From makc@iinet.net.au Wed Jan 27 15:25:19 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0RLPIGC217877 for ; Wed, 27 Jan 2010 15:25:19 -0600 X-ASG-Debug-ID: 1264627581-0261018c0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from outbound.icp-qv1-irony-out1.iinet.net.au (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 8E5BB1C830C6 for ; Wed, 27 Jan 2010 13:26:22 -0800 (PST) Received: from outbound.icp-qv1-irony-out1.iinet.net.au (outbound.icp-qv1-irony-out1.iinet.net.au [203.59.1.106]) by cuda.sgi.com with ESMTP id VNPdedEfHAWKvBDm for ; Wed, 27 Jan 2010 13:26:22 -0800 (PST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAHI+YEvL2Rwk/2dsb2JhbADZA4Q5BA X-IronPort-AV: E=Sophos;i="4.49,356,1262534400"; d="scan'208";a="623804767" Received: from unknown (HELO alma.crabbed.net) ([203.217.28.36]) by outbound.icp-qv1-irony-out1.iinet.net.au with ESMTP; 28 Jan 2010 05:26:20 +0800 Received: by alma.crabbed.net (Postfix, from userid 501) id B79E1C92B2; Thu, 28 Jan 2010 08:26:19 +1100 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19296.44923.634056.41880@iinet.net.au> Date: Thu, 28 Jan 2010 08:26:19 +1100 From: Max Matveev To: Nathan Scott Cc: pcp@oss.sgi.com X-ASG-Orig-Subj: Re: [pcp] pcp updates Subject: Re: [pcp] pcp updates In-Reply-To: <2101253038.2076101264622266589.JavaMail.root@mail-au.aconex.com> References: <1992950383.2076011264621949257.JavaMail.root@mail-au.aconex.com> <2101253038.2076101264622266589.JavaMail.root@mail-au.aconex.com> X-Mailer: VM 7.17 under 21.4 (patch 19) "Constant Variable" XEmacs Lucid X-Barracuda-Connect: outbound.icp-qv1-irony-out1.iinet.net.au[203.59.1.106] X-Barracuda-Start-Time: 1264627583 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20960 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Thu, 28 Jan 2010 06:57:46 +1100 (EST), Nathan Scott wrote: nscott> Are you expecting more attempts, or are we good to go for 3.1 nscott> (which is planned for today). It "works for me", unless Ken finds something else it should be all I need for 3.1. nscott> The cache.c change looks to be low-medium-level risk & OK if nscott> it passes QA (I'll do another run this morning); FWIW I've discussed it with Ken and it was the least worst option we could come up with. max From makc@iinet.net.au Wed Jan 27 17:02:10 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0RN298Z236405 for ; Wed, 27 Jan 2010 17:02:10 -0600 X-ASG-Debug-ID: 1264633393-7024028c0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from outbound.icp-qv1-irony-out5.iinet.net.au (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 2A037194E30 for ; Wed, 27 Jan 2010 15:03:13 -0800 (PST) Received: from outbound.icp-qv1-irony-out5.iinet.net.au (outbound.icp-qv1-irony-out5.iinet.net.au [203.59.1.105]) by cuda.sgi.com with ESMTP id 0YmzE7lGqFBPQVG9 for ; Wed, 27 Jan 2010 15:03:13 -0800 (PST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAHtUYEvL2Rwk/2dsb2JhbADYZYQ5BA X-IronPort-AV: E=Sophos;i="4.49,356,1262534400"; d="scan'208";a="96065709" Received: from unknown (HELO alma.crabbed.net) ([203.217.28.36]) by outbound.icp-qv1-irony-out5.iinet.net.au with ESMTP; 28 Jan 2010 07:03:11 +0800 Received: by alma.crabbed.net (Postfix, from userid 501) id 1F687C931E; Thu, 28 Jan 2010 10:03:11 +1100 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19296.50735.2935.693707@iinet.net.au> Date: Thu, 28 Jan 2010 10:03:11 +1100 From: Max Matveev To: Nathan Scott , pcp@oss.sgi.com X-ASG-Orig-Subj: Re: [pcp] pcp updates Subject: Re: [pcp] pcp updates In-Reply-To: <19296.44923.634056.41880@iinet.net.au> References: <1992950383.2076011264621949257.JavaMail.root@mail-au.aconex.com> <2101253038.2076101264622266589.JavaMail.root@mail-au.aconex.com> <19296.44923.634056.41880@iinet.net.au> X-Mailer: VM 7.17 under 21.4 (patch 19) "Constant Variable" XEmacs Lucid X-Barracuda-Connect: outbound.icp-qv1-irony-out5.iinet.net.au[203.59.1.105] X-Barracuda-Start-Time: 1264633395 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0002 1.0000 -2.0194 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20962 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Thu, 28 Jan 2010 08:26:19 +1100, Max Matveev wrote: makc> On Thu, 28 Jan 2010 06:57:46 +1100 (EST), Nathan Scott wrote: nscott> Are you expecting more attempts, or are we good to go for 3.1 nscott> (which is planned for today). makc> It "works for me", unless Ken finds something else it should be all I makc> need for 3.1. So I've lied - found one more thing: top commit on onefetch branch in my git tree: he following changes since commit 43bc1d2b6ae2142ac9684d1980cf49698b2eafda: Max Matveev (1): Export physmem size, page size and uname from Solaris pmda are available in the git repository at: git://oss.sgi.com/makc/pcp onefetch Max Matveev (1): Don't assume size of values in unix/system_pages. src/pmdas/solaris/sysinfo.c | 19 ++++++++++++++++++- 1 files changed, 18 insertions(+), 1 deletions(-) max From nscott@aconex.com Wed Jan 27 20:38:25 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0S2cOZ6256436 for ; Wed, 27 Jan 2010 20:38:24 -0600 X-ASG-Debug-ID: 1264646367-743a02c50000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id BA6AF1C84221 for ; Wed, 27 Jan 2010 18:39:28 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id fFEyMl0Nk1AKtCCg for ; Wed, 27 Jan 2010 18:39:28 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id E395821884D; Thu, 28 Jan 2010 13:39:26 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id RZbGpas9pnWWVsLD; Thu, 28 Jan 2010 13:39:26 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id E9A0FA5011D; Thu, 28 Jan 2010 13:37:06 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id D9C50488396; Thu, 28 Jan 2010 13:39:26 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8BE-FAssu-1P; Thu, 28 Jan 2010 13:39:22 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 2F6E44883B7; Thu, 28 Jan 2010 13:39:22 +1100 (EST) Date: Thu, 28 Jan 2010 13:39:21 +1100 (EST) From: Nathan Scott To: kenj@internode.on.net Cc: pcp@oss.sgi.com Message-ID: <1287272150.2093901264646361821.JavaMail.root@mail-au.aconex.com> In-Reply-To: <1264593664.14810.8.camel@bozo.localdomain> X-ASG-Orig-Subj: Re: [pcp] pcpqa updates Subject: Re: [pcp] pcpqa updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1264646369 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0021 1.0000 -2.0073 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.01 X-Barracuda-Spam-Status: No, SCORE=-2.01 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20976 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ----- "Ken McDonell" wrote: > OK, I think this is a shell escaping inconsistency in the QA test, not > a > problem with the pmdaCache code ... could you please try the attached > 341 and see if it passes? Yep, that's done the trick - thanks! Still plowing through a final full QA run - so far, so good though. cheers. -- Nathan From nscott@aconex.com Thu Jan 28 00:39:56 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0S6dtMh008918 for ; Thu, 28 Jan 2010 00:39:56 -0600 X-ASG-Debug-ID: 1264660859-082400170000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id F03121C8474F for ; Wed, 27 Jan 2010 22:40:59 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id P6tPC0TSKnHPAivW for ; Wed, 27 Jan 2010 22:40:59 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 701B221A84A for ; Thu, 28 Jan 2010 17:40:57 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id cWMKOiz1N0QOMyx6 for ; Thu, 28 Jan 2010 17:40:57 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 57EFEA5028C for ; Thu, 28 Jan 2010 17:38:37 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 595394883BA for ; Thu, 28 Jan 2010 17:40:57 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OvRFMoi6jcta for ; Thu, 28 Jan 2010 17:40:53 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 5A8004883B7 for ; Thu, 28 Jan 2010 17:40:53 +1100 (EST) Date: Thu, 28 Jan 2010 17:40:53 +1100 (EST) From: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1010743175.2106931264660853070.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcp updates Subject: pcp updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1264660860 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20989 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Changes committed to git://oss.sgi.com/nathans/pcp.git src/include/pmda.h | 4 src/libpcp_pmda/src/tree.c | 8 src/pmdas/mmv/mmv.c | 655 ++++++++++++++++++++++++++------------------ src/pmdas/oracle/.gitignore | 2 4 files changed, 399 insertions(+), 270 deletions(-) commit e33fd21ae7df94386138efc5eafcae321072a83d Author: Nathan Scott Date: Thu Jan 28 17:39:08 2010 +1100 Add gitignore files in pmdaoracle area. commit 88dccc5b547a1c42a7467be9937373680dc1166e Author: Nathan Scott Date: Thu Jan 28 17:38:22 2010 +1100 Rework pmdammv internals to support cross-file instances. Refactored alot of the code dealing with the mmap files to allow this, and to make the code alot more readable (esp. the map_stats() routine, which was getting quite large). commit 987220939d2814b2148fbb96185878bb517b9670 Author: Nathan Scott Date: Thu Jan 28 17:36:09 2010 +1100 Use const pointers for some pmdaTree interfaces, where warranted. From nscott@aconex.com Thu Jan 28 04:40:14 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0SAeDOA020250 for ; Thu, 28 Jan 2010 04:40:13 -0600 X-ASG-Debug-ID: 1264675277-0440030e0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 364021C84FE7 for ; Thu, 28 Jan 2010 02:41:17 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id jHqEz4CfUpyH4v0u for ; Thu, 28 Jan 2010 02:41:17 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 6E5BC21B828 for ; Thu, 28 Jan 2010 21:41:16 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id IW01oSJ17mBNX6Gc for ; Thu, 28 Jan 2010 21:41:16 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 439BFA5011D for ; Thu, 28 Jan 2010 21:38:56 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 60D084883C7 for ; Thu, 28 Jan 2010 21:41:16 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZjOVwTIHB-pB for ; Thu, 28 Jan 2010 21:41:12 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 62B894883BD for ; Thu, 28 Jan 2010 21:41:12 +1100 (EST) Date: Thu, 28 Jan 2010 21:41:12 +1100 (EST) From: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1592911670.2108811264675272206.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcpqa updates Subject: pcpqa updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [211.28.150.226] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - SAF3 (Mac)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1264675279 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.52 X-Barracuda-Spam-Status: No, SCORE=-1.52 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.21001 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M X-Virus-Status: Clean Changes committed to git://oss.sgi.com/pcp/pcpqa.git 341 | 3 ++- 648 | 12 +----------- 648.out | 31 +++++++++++++++++++------------ 649 | 57 +++++++++++++++++++++++++++++++++++++++++++++++---------- 649.out | 30 ++++++++++++++++++++++++++++++ 5 files changed, 99 insertions(+), 34 deletions(-) commit 99f1c0d9239205e6300a745beaaa9eacc68ceea1 Author: Ken McDonell Date: Thu Jan 28 21:39:37 2010 +1100 Resolve a quirky shell quoting issue in test 341. commit 2042618f9a7de733abce979a4ebad2c24084b4b6 Author: Nathan Scott Date: Thu Jan 28 21:32:23 2010 +1100 Update mmv tests to be deterministic, reenable 648 (mmv instances). From nscott@aconex.com Thu Jan 28 04:57:23 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0SAvN5S021167 for ; Thu, 28 Jan 2010 04:57:23 -0600 X-ASG-Debug-ID: 1264676307-694100c50000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id B1347196456 for ; Thu, 28 Jan 2010 02:58:27 -0800 (PST) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id qXKahvaPdepDNm1i for ; Thu, 28 Jan 2010 02:58:27 -0800 (PST) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 6787D21B9D7 for ; Thu, 28 Jan 2010 21:58:26 +1100 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id aRZ72jwhA2cjBOVd for ; Thu, 28 Jan 2010 21:58:26 +1100 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 377B2A5011D for ; Thu, 28 Jan 2010 21:56:06 +1100 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 52FB74883C7 for ; Thu, 28 Jan 2010 21:58:26 +1100 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JzI-eOoaLQCL for ; Thu, 28 Jan 2010 21:58:22 +1100 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 4FE0A4883C4 for ; Thu, 28 Jan 2010 21:58:22 +1100 (EST) Date: Thu, 28 Jan 2010 21:58:22 +1100 (EST) From: Nathan Scott To: pcp Message-ID: <515888684.2109021264676302119.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcpqa updates Subject: pcpqa updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [211.28.150.226] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - SAF3 (Mac)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1264676308 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.21003 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Changes committed to git://oss.sgi.com/pcp/pcpqa.git 213.out | 4 +--- src-oss/mmv_instances.c | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) commit 47735e0779decbcaf6c8c5a3bf5bde930008965d Author: Nathan Scott Date: Thu Jan 28 21:56:42 2010 +1100 pmdammv became less verbose by default, update 213 output to match. commit 91fe6ed0aa45923d9e6e7c5d15e6c53ff746aa81 Author: Nathan Scott Date: Thu Jan 28 21:48:18 2010 +1100 Fix call to mmv_stats_set in instance test so values propogated. From daw@sgi.com Thu Jan 28 07:43:00 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0SDgxWq029402 for ; Thu, 28 Jan 2010 07:43:00 -0600 Received: from zion.americas.sgi.com (zion.americas.sgi.com [128.162.236.17]) by relay3.corp.sgi.com (Postfix) with ESMTP id BA028AC016 for ; Thu, 28 Jan 2010 05:44:02 -0800 (PST) Received: (from daw@localhost) by zion.americas.sgi.com (8.12.9/ASC-news-1.4) id o0SDi2hw34223846 for pcp@oss.sgi.com; Thu, 28 Jan 2010 07:44:02 -0600 (CST) Message-Id: <201001281344.o0SDi2hw34223846@zion.americas.sgi.com> Subject: Installing git dev tree To: pcp@oss.sgi.com Date: Thu, 28 Jan 2010 07:44:02 -0600 (CST) From: David Wright X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Hello, With Nathans help, I have built the pcp git dev tree. It seems to build fine but when I do the make I get this... tar cvf PCP-PMDA-1.08.tar PCP-PMDA-1.08 PCP-PMDA-1.08/ PCP-PMDA-1.08/test.pl PCP-PMDA-1.08/COPYING PCP-PMDA-1.08/Changes PCP-PMDA-1.08/cvalue.c PCP-PMDA-1.08/local.c PCP-PMDA-1.08/MANIFEST PCP-PMDA-1.08/typemap PCP-PMDA-1.08/PMDA.pm PCP-PMDA-1.08/PMDA.xs PCP-PMDA-1.08/local.h PCP-PMDA-1.08/Makefile.PL PCP-PMDA-1.08/META.yml rm -rf PCP-PMDA-1.08 gzip --best PCP-PMDA-1.08.tar /usr/bin/gmake -f Makefile install DESTDIR=$DIST_ROOT Files found in blib/arch: installing files in blib/lib into architecture dependent library tree Writing /usr/lib/perl5/vendor_perl/5.10.0/ia64-linux-thread-multi/auto/PCP/PMDA/.packlist Appending installation info to /usr/lib/perl5/5.10.0/ia64-linux-thread-multi/perllocal.pod find $DIST_ROOT -name .packlist -exec mv '{}' ../../../perl-pcp-pmda.list ';' sed -e s@$DIST_ROOT@@ -e 's/\.[0-9]pm$/&.gz/' -e '/\.bs$/d' -i.tmp ../../../perl-pcp-pmda.list sed: can't read ../../../perl-pcp-pmda.list: No such file or directory gmake[3]: *** [install] Error 2 gmake[2]: *** [install] Error 2 gmake[1]: *** [install_pcp] Error 2 gmake[1]: Leaving directory `/root/pcp/src' gmake: *** [install_pcp] Error 2 PCP-PMDA-1.08 From goodwinos@gmail.com Thu Jan 28 17:45:00 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0SNj0KI065744 for ; Thu, 28 Jan 2010 17:45:00 -0600 X-ASG-Debug-ID: 1264722365-5c8d02e10000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mx1.redhat.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 86A5B199327 for ; Thu, 28 Jan 2010 15:46:05 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id VhgY5n3Idd4h4PAP for ; Thu, 28 Jan 2010 15:46:05 -0800 (PST) Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0SNjxEQ018757 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 28 Jan 2010 18:45:59 -0500 Received: from [10.11.10.214] (vpn-10-214.rdu.redhat.com [10.11.10.214]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0SNjv2r025908 for ; Thu, 28 Jan 2010 18:45:58 -0500 Message-ID: <4B6221B4.4090507@gmail.com> Date: Fri, 29 Jan 2010 10:45:56 +1100 From: Mark Goodwin User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0 MIME-Version: 1.0 To: pcp@oss.sgi.com X-ASG-Orig-Subj: Re: [pcp] Installing git dev tree Subject: Re: [pcp] Installing git dev tree References: <201001281344.o0SDi2hw34223846@zion.americas.sgi.com> In-Reply-To: <201001281344.o0SDi2hw34223846@zion.americas.sgi.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 10.5.11.17 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1264722366 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0688 1.0000 -1.5827 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.58 X-Barracuda-Spam-Status: No, SCORE=-1.58 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.21042 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On 01/29/2010 12:44 AM, David Wright wrote: > Hello, > > With Nathans help, I have built the pcp git dev tree. It seems to build fine > but when I do the make I get this... > > ... > sed -e s@$DIST_ROOT@@ -e 's/\.[0-9]pm$/&.gz/' -e '/\.bs$/d' -i.tmp ../../../perl-pcp-pmda.list > sed: can't read ../../../perl-pcp-pmda.list: No such file or directory > gmake[3]: *** [install] Error 2 > gmake[2]: *** [install] Error 2 > gmake[1]: *** [install_pcp] Error 2 > gmake[1]: Leaving directory `/root/pcp/src' > gmake: *** [install_pcp] Error 2 Hi Dave, I just updated a fresh 3.1 git tree (dev branch) and ran make and it works fine for x86_64/fedora12. What is your build/root environment? Does the Makepkgs script work? Cheers -- Mark From kenj@internode.on.net Sat Jan 30 15:50:33 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX,J_CHICKENPOX_43 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0ULoWNL239948 for ; Sat, 30 Jan 2010 15:50:32 -0600 X-ASG-Debug-ID: 1264888296-577002e50000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 2A6B219E4D0 for ; Sat, 30 Jan 2010 13:51:37 -0800 (PST) Received: from mail.internode.on.net (bld-mail16.adl2.internode.on.net [150.101.137.101]) by cuda.sgi.com with ESMTP id LvmYfCjWbiAQ4z2b for ; Sat, 30 Jan 2010 13:51:37 -0800 (PST) Received: from [124.176.229.186] (unverified [124.176.229.186]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11937280-1927428 for multiple; Sun, 31 Jan 2010 08:19:31 +1030 (CDT) X-ASG-Orig-Subj: pcpqa updates Subject: pcpqa updates From: Ken McDonell Reply-To: kenj@internode.on.net To: pcp@oss.sgi.com Cc: Andrew Wansink Content-Type: text/plain; charset="UTF-8" Date: Sun, 31 Jan 2010 08:49:04 +1100 Message-ID: <1264888144.3634.0.camel@bozo-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail16.adl2.internode.on.net[150.101.137.101] X-Barracuda-Start-Time: 1264888299 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0968 1.0000 -1.4119 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.41 X-Barracuda-Spam-Status: No, SCORE=-1.41 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.21214 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Changes committed to git://oss.sgi.com/pcp/pcpqa.git 213.out | 4 +++- 226 | 10 ++++------ 342 | 47 +++++++++++++++++++++++++++++++++++++++++++++++ 342.out | 23 +++++++++++++++++++++++ 617.out | 1 + group | 33 +++++++++++++++++---------------- owner | 1 + 7 files changed, 96 insertions(+), 23 deletions(-) commit 94519f1c31d3a38bdbe9756ac126ddedd3eac6a1 Author: Ken McDonell Date: Sun Jan 31 08:12:43 2010 +1100 342 open socket command for dbpmda 342 is new, other changes in this commit are as a result of the new "open socket socketname" command being added to dbpmda. commit 3112c664ed172a459f67a8a84da5947582af757a Author: Ken McDonell Date: Fri Jan 29 06:39:45 2010 +1100 Group pmdampi -> pmda.mpi for consistency with other pmda groups From kenj@internode.on.net Sat Jan 30 15:52:21 2010 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0ULqKHQ240056 for ; Sat, 30 Jan 2010 15:52:21 -0600 X-ASG-Debug-ID: 1264888406-577f02ea0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 1BC5D19E4AF for ; Sat, 30 Jan 2010 13:53:26 -0800 (PST) Received: from mail.internode.on.net (bld-mail12.adl6.internode.on.net [150.101.137.97]) by cuda.sgi.com with ESMTP id jFoywcImMNpuK0GY for ; Sat, 30 Jan 2010 13:53:26 -0800 (PST) Received: from [124.176.229.186] (unverified [124.176.229.186]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11958450-1927428 for multiple; Sun, 31 Jan 2010 08:21:22 +1030 (CDT) X-ASG-Orig-Subj: pcp updates Subject: pcp updates From: Ken McDonell Reply-To: kenj@internode.on.net To: pcp@oss.sgi.com Cc: Andrew Wansink Content-Type: text/plain; charset="UTF-8" Date: Sun, 31 Jan 2010 08:50:56 +1100 Message-ID: <1264888256.3634.1.camel@bozo-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail12.adl6.internode.on.net[150.101.137.97] X-Barracuda-Start-Time: 1264888408 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0451 1.0000 -1.7310 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.73 X-Barracuda-Spam-Status: No, SCORE=-1.73 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.21214 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Thanks for this Andrew. Changes committed to git://oss.sgi.com/kenj/pcp.git dev src/dbpmda/src/dbpmda.h | 1 src/dbpmda/src/gram.y | 6 +++- src/dbpmda/src/lex.l | 1 src/dbpmda/src/pmda.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++-- src/dbpmda/src/util.c | 11 +++++--- 5 files changed, 74 insertions(+), 7 deletions(-) commit 8a6d082f8398f2d322b70ecf9642dc3a9e73ffce Author: Ken McDonell Date: Sun Jan 31 08:44:29 2010 +1100 dbmda - cosmetic #if -> #ifdef commit 3bd41f461564ee04c36f74b3d68c0e62b106b2c9 Author: Ken McDonell Date: Sun Jan 31 08:18:36 2010 +1100 dbpmda - add open socket sockname command Based on a patch from Andrew Wansink, this change adds an open socket command (alongside the existing open dso and open pipe commands). In this context a "socket" is a UNIX domain socket, aka a named pipe. This is useful 1. because -u socketname is supported for PMDAs and dbpmda previously could not use/exercise this 2. it is sometimes easier to debug a pmda by running it from within a debugger with a -u socketname option where it will hang waiting for pmcd/dbpmda and then running dbpmda in another window