From mailman-bounces@oss.sgi.com Tue Sep 1 06:37:28 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=ALL_TRUSTED,BAYES_00, J_CHICKENPOX_25 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n81BCQjA170702 for ; Tue, 1 Sep 2009 06:12:26 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Subject: oss.sgi.com mailing list memberships reminder From: mailman-owner@oss.sgi.com To: pcp@oss.sgi.com X-No-Archive: yes Message-ID: Date: Tue, 01 Sep 2009 05:00:30 -0500 Precedence: bulk X-BeenThere: mailman@oss.sgi.com X-Mailman-Version: 2.1.11 List-Id: Mailman mail X-List-Administrivia: yes Sender: mailman-bounces@oss.sgi.com Errors-To: mailman-bounces@oss.sgi.com This is a reminder, sent out once a month, about your oss.sgi.com mailing list memberships. It includes your subscription info and how to use it to change it or unsubscribe from a list. You can visit the URLs to change your membership status or configuration, including unsubscribing, setting digest-style delivery or disabling delivery altogether (e.g., for a vacation), and so on. In addition to the URL interfaces, you can also use email to make such changes. For more info, send a message to the '-request' address of the list (for example, mailman-request@oss.sgi.com) containing just the word 'help' in the message body, and an email message will be sent to you with instructions. If you have questions, problems, comments, etc, send them to mailman-owner@oss.sgi.com. Thanks! Passwords for pcp@oss.sgi.com: List Password // URL ---- -------- pcp-announce@oss.sgi.com xE+IBctR http://oss.sgi.com/mailman/options/pcp-announce/pcp%40oss.sgi.com From mort@sgi.com Tue Sep 1 11:41:06 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n81GekAS187573 for ; Tue, 1 Sep 2009 11:40:56 -0500 Received: from attica.americas.sgi.com (attica.americas.sgi.com [128.162.236.44]) by relay1.corp.sgi.com (Postfix) with ESMTP id CC7648F808F for ; Tue, 1 Sep 2009 09:41:42 -0700 (PDT) Received: by attica.americas.sgi.com (Postfix, from userid 44682) id 785FCA23CA70; Tue, 1 Sep 2009 11:31:52 -0500 (CDT) Date: Tue, 1 Sep 2009 11:31:52 -0500 From: Martin Hicks To: pcp@oss.sgi.com Subject: QA tests and pmlogreduce setting hours to "01" Message-ID: <20090901163152.GC16972@alcatraz.americas.sgi.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="x+6KMIRAuhnl3hBn" Content-Disposition: inline User-Agent: Mutt/1.5.17 (2007-11-01) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean --x+6KMIRAuhnl3hBn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I've started playing with the QA tests, running them against PCP-2.9.0 So far I've managed to get through nearly the first 150 tests, fixing a few things along the way. The thing I started hitting in the 100's was that the hours on the archives are coming out incorrectly (or the archives are wrong, or the 144.out is incorrect). pmdumplog is telling me the same thing as pmlogreduce is: pcpqa@laplace:/home/mort/src/pcpqa.git$ pmdumplog -a src-oss/naslog | head -n 4 Log Label (Log Format Version 2) Performance metrics from host snort commencing Thu Apr 8 01:11:09.969 2004 ending Thu Apr 8 01:21:25.942 2004 The full log is attached. pcpqa@laplace:/home/mort/src/pcpqa.git$ diff -u 144.out 144.out.bad --- 144.out 2009-08-27 09:08:26.000000000 -0400 +++ 144.out.bad 2009-09-01 12:28:17.000000000 -0400 @@ -3,30 +3,30 @@ === network.interface.baudrate === 5c5 -< end: Thu Apr 8 15:21:25 2004 +< end: Thu Apr 8 01:21:25 2004 --- -> end: Thu Apr 8 15:21:00 2004 +> end: Thu Apr 8 01:21:00 2004 === network.interface.in.packets === 5c5 -< end: Thu Apr 8 15:21:25 2004 +< end: Thu Apr 8 01:21:25 2004 --- -> end: Thu Apr 8 15:21:00 2004 +> end: Thu Apr 8 01:21:00 2004 === kernel.all.load === 5c5 -< end: Thu Apr 8 15:21:25 2004 +< end: Thu Apr 8 01:21:25 2004 --- -> end: Thu Apr 8 15:21:00 2004 +> end: Thu Apr 8 01:21:00 2004 === kernel.all.cpu.idle === 5c5 -< end: Thu Apr 8 15:21:25 2004 +< end: Thu Apr 8 01:21:25 2004 --- -> end: Thu Apr 8 15:21:00 2004 +> end: Thu Apr 8 01:21:00 2004 === disk.all.total === 5c5 -< end: Thu Apr 8 15:21:25 2004 +< end: Thu Apr 8 01:21:25 2004 --- -> end: Thu Apr 8 15:21:00 2004 +> end: Thu Apr 8 01:21:00 2004 --x+6KMIRAuhnl3hBn Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="144.full" === network.interface.baudrate === --- original --- metric: network.interface.baudrate archive: src-oss/naslog host: snort start: Thu Apr 8 01:11:30 2004 end: Thu Apr 8 01:21:25 2004 semantics: discrete instantaneous value units: byte / sec samples: 19 interval: 30.00 sec lo0 ef2 ef0 01:11:30.000 0 10000000 10000000 01:12:00.000 0 10000000 10000000 01:12:30.000 0 10000000 10000000 01:13:00.000 0 10000000 10000000 01:13:30.000 0 10000000 10000000 01:14:00.000 0 10000000 10000000 01:14:30.000 0 10000000 10000000 01:15:00.000 0 10000000 10000000 01:15:30.000 0 10000000 10000000 01:16:00.000 0 10000000 10000000 01:16:30.000 0 10000000 10000000 01:17:00.000 0 10000000 10000000 01:17:30.000 0 10000000 10000000 01:18:00.000 0 10000000 10000000 01:18:30.000 0 10000000 10000000 01:19:00.000 0 10000000 10000000 01:19:30.000 0 10000000 10000000 01:20:00.000 0 10000000 10000000 01:20:30.000 0 10000000 10000000 --- reduced --- metric: network.interface.baudrate archive: /tmp/22795 host: snort start: Thu Apr 8 01:11:30 2004 end: Thu Apr 8 01:21:00 2004 semantics: discrete instantaneous value units: byte / sec samples: 19 interval: 30.00 sec lo0 ef2 ef0 01:11:30.000 0 10000000 10000000 01:12:00.000 0 10000000 10000000 01:12:30.000 0 10000000 10000000 01:13:00.000 0 10000000 10000000 01:13:30.000 0 10000000 10000000 01:14:00.000 0 10000000 10000000 01:14:30.000 0 10000000 10000000 01:15:00.000 0 10000000 10000000 01:15:30.000 0 10000000 10000000 01:16:00.000 0 10000000 10000000 01:16:30.000 0 10000000 10000000 01:17:00.000 0 10000000 10000000 01:17:30.000 0 10000000 10000000 01:18:00.000 0 10000000 10000000 01:18:30.000 0 10000000 10000000 01:19:00.000 0 10000000 10000000 01:19:30.000 0 10000000 10000000 01:20:00.000 0 10000000 10000000 01:20:30.000 0 10000000 10000000 === network.interface.in.packets === --- original --- metric: network.interface.in.packets archive: src-oss/naslog host: snort start: Thu Apr 8 01:11:30 2004 end: Thu Apr 8 01:21:25 2004 semantics: cumulative counter (converting to rate) units: count (converting to count / sec) samples: 19 interval: 30.00 sec lo0 ef2 ef0 01:12:00.000 52.37 0.0 678.5 01:12:30.000 71.47 0.0 762.9 01:13:00.000 73.03 0.0 688.8 01:13:30.000 80.43 0.0 616.1 01:14:00.000 70.87 0.0 560.6 01:14:30.000 66.73 0.0 691.8 01:15:00.000 61.70 0.0 697.8 01:15:30.000 89.37 0.0 709.7 01:16:00.000 82.57 0.0 762.4 01:16:30.000 82.67 0.0 673.0 01:17:00.000 52.67 0.0 639.4 01:17:30.000 57.20 0.0 646.4 01:18:00.000 50.07 0.0 216.8 01:18:30.000 50.93 0.0 115.3 01:19:00.000 57.53 0.0 160.8 01:19:30.000 57.93 0.0 240.8 01:20:00.000 53.47 0.0 167.5 01:20:30.000 64.93 0.0 182.0 01:21:00.000 49.33 0.0 187.2 --- reduced --- metric: network.interface.in.packets archive: /tmp/22795 host: snort start: Thu Apr 8 01:11:30 2004 end: Thu Apr 8 01:21:00 2004 semantics: cumulative counter (converting to rate) units: count (converting to count / sec) samples: 19 interval: 30.00 sec lo0 ef2 ef0 01:12:00.000 52.37 0.0 678.5 01:12:30.000 71.47 0.0 762.9 01:13:00.000 73.03 0.0 688.8 01:13:30.000 80.43 0.0 616.1 01:14:00.000 70.87 0.0 560.6 01:14:30.000 66.73 0.0 691.8 01:15:00.000 61.70 0.0 697.8 01:15:30.000 89.37 0.0 709.7 01:16:00.000 82.57 0.0 762.4 01:16:30.000 82.67 0.0 673.0 01:17:00.000 52.67 0.0 639.4 01:17:30.000 57.20 0.0 646.4 01:18:00.000 50.07 0.0 216.8 01:18:30.000 50.93 0.0 115.3 01:19:00.000 57.53 0.0 160.8 01:19:30.000 57.93 0.0 240.8 01:20:00.000 53.47 0.0 167.5 01:20:30.000 64.93 0.0 182.0 01:21:00.000 49.33 0.0 187.2 === kernel.all.load === --- original --- metric: kernel.all.load archive: src-oss/naslog host: snort start: Thu Apr 8 01:11:30 2004 end: Thu Apr 8 01:21:25 2004 semantics: instantaneous value units: none samples: 19 interval: 30.00 sec 1 minute 5 minute 15 minute 01:11:30.000 3.269 2.493 1.818 01:12:00.000 3.271 2.573 1.867 01:12:30.000 2.763 2.511 1.867 01:13:00.000 2.867 2.564 1.906 01:13:30.000 3.208 2.674 1.970 01:14:00.000 3.173 2.713 2.007 01:14:30.000 3.099 2.750 2.043 01:15:00.000 2.827 2.717 2.051 01:15:30.000 2.815 2.728 2.077 01:16:00.000 3.036 2.788 2.119 01:16:30.000 2.591 2.702 2.111 01:17:00.000 2.105 2.580 2.085 01:17:30.000 1.681 2.413 2.038 01:18:00.000 1.290 2.252 1.988 01:18:30.000 0.7969 2.026 1.915 01:19:00.000 0.8037 1.916 1.876 01:19:30.000 0.8369 1.805 1.832 01:20:00.000 0.5811 1.649 1.771 01:20:30.000 0.9023 1.605 1.750 --- reduced --- metric: kernel.all.load archive: /tmp/22795 host: snort start: Thu Apr 8 01:11:30 2004 end: Thu Apr 8 01:21:00 2004 semantics: instantaneous value units: none samples: 19 interval: 30.00 sec 1 minute 5 minute 15 minute 01:11:30.000 3.269 2.493 1.818 01:12:00.000 3.271 2.573 1.867 01:12:30.000 2.763 2.511 1.867 01:13:00.000 2.867 2.564 1.906 01:13:30.000 3.208 2.674 1.970 01:14:00.000 3.173 2.713 2.007 01:14:30.000 3.099 2.750 2.043 01:15:00.000 2.827 2.717 2.051 01:15:30.000 2.815 2.728 2.077 01:16:00.000 3.036 2.788 2.119 01:16:30.000 2.591 2.702 2.111 01:17:00.000 2.105 2.580 2.085 01:17:30.000 1.681 2.413 2.038 01:18:00.000 1.290 2.252 1.988 01:18:30.000 0.7969 2.026 1.915 01:19:00.000 0.8037 1.916 1.876 01:19:30.000 0.8369 1.805 1.832 01:20:00.000 0.5811 1.649 1.771 01:20:30.000 0.9023 1.605 1.750 === kernel.all.cpu.idle === --- original --- metric: kernel.all.cpu.idle archive: src-oss/naslog host: snort start: Thu Apr 8 01:11:30 2004 end: Thu Apr 8 01:21:25 2004 semantics: cumulative counter (converting to rate) units: millisec (converting to time utilization) samples: 19 interval: 30.00 sec 01:12:00.000 6.414 01:12:30.000 7.266 01:13:00.000 7.443 01:13:30.000 7.031 01:14:00.000 6.765 01:14:30.000 7.076 01:15:00.000 7.417 01:15:30.000 7.253 01:16:00.000 7.239 01:16:30.000 7.682 01:17:00.000 8.709 01:17:30.000 8.743 01:18:00.000 9.470 01:18:30.000 9.731 01:19:00.000 9.599 01:19:30.000 9.448 01:20:00.000 9.549 01:20:30.000 9.461 01:21:00.000 9.581 --- reduced --- metric: kernel.all.cpu.idle archive: /tmp/22795 host: snort start: Thu Apr 8 01:11:30 2004 end: Thu Apr 8 01:21:00 2004 semantics: cumulative counter (converting to rate) units: millisec (converting to time utilization) samples: 19 interval: 30.00 sec 01:12:00.000 6.414 01:12:30.000 7.266 01:13:00.000 7.443 01:13:30.000 7.031 01:14:00.000 6.765 01:14:30.000 7.076 01:15:00.000 7.417 01:15:30.000 7.253 01:16:00.000 7.239 01:16:30.000 7.682 01:17:00.000 8.709 01:17:30.000 8.743 01:18:00.000 9.470 01:18:30.000 9.731 01:19:00.000 9.599 01:19:30.000 9.448 01:20:00.000 9.549 01:20:30.000 9.461 01:21:00.000 9.581 === disk.all.total === --- original --- metric: disk.all.total archive: src-oss/naslog host: snort start: Thu Apr 8 01:11:30 2004 end: Thu Apr 8 01:21:25 2004 semantics: cumulative counter (converting to rate) units: count (converting to count / sec) samples: 19 interval: 30.00 sec 01:12:00.000 355.9 01:12:30.000 239.3 01:13:00.000 168.0 01:13:30.000 119.7 01:14:00.000 211.2 01:14:30.000 235.7 01:15:00.000 188.2 01:15:30.000 152.6 01:16:00.000 164.9 01:16:30.000 190.7 01:17:00.000 154.1 01:17:30.000 138.1 01:18:00.000 32.77 01:18:30.000 18.87 01:19:00.000 14.50 01:19:30.000 19.37 01:20:00.000 18.03 01:20:30.000 21.40 01:21:00.000 18.63 --- reduced --- metric: disk.all.total archive: /tmp/22795 host: snort start: Thu Apr 8 01:11:30 2004 end: Thu Apr 8 01:21:00 2004 semantics: cumulative counter (converting to rate) units: count (converting to count / sec) samples: 19 interval: 30.00 sec 01:12:00.000 355.9 01:12:30.000 239.3 01:13:00.000 168.0 01:13:30.000 119.7 01:14:00.000 211.2 01:14:30.000 235.7 01:15:00.000 188.2 01:15:30.000 152.6 01:16:00.000 164.9 01:16:30.000 190.7 01:17:00.000 154.1 01:17:30.000 138.1 01:18:00.000 32.77 01:18:30.000 18.87 01:19:00.000 14.50 01:19:30.000 19.37 01:20:00.000 18.03 01:20:30.000 21.40 01:21:00.000 18.63 --x+6KMIRAuhnl3hBn-- From mort@sgi.com Tue Sep 1 13:16:06 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_56 autolearn=no version=3.3.0-rupdated Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n81IFkdM198676 for ; Tue, 1 Sep 2009 13:15:56 -0500 Received: from attica.americas.sgi.com (attica.americas.sgi.com [128.162.236.44]) by relay1.corp.sgi.com (Postfix) with ESMTP id A2B0B8F80E3 for ; Tue, 1 Sep 2009 11:16:42 -0700 (PDT) Received: by attica.americas.sgi.com (Postfix, from userid 44682) id 8E3E4A23CA70; Tue, 1 Sep 2009 13:09:59 -0500 (CDT) Date: Tue, 1 Sep 2009 13:09:59 -0500 From: Martin Hicks To: pcp@oss.sgi.com Subject: Re: [pcp] QA tests and pmlogreduce setting hours to "01" Message-ID: <20090901180959.GE16972@alcatraz.americas.sgi.com> References: <20090901163152.GC16972@alcatraz.americas.sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090901163152.GC16972@alcatraz.americas.sgi.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean aha. Perhaps timezone related? pcpqa@laplace:/home/mort/src/pcpqa.git$ git diff 144 diff --git a/144 b/144 index e20e566..54b5198 100755 --- a/144 +++ b/144 @@ -9,6 +9,8 @@ # creator owner=kenmcd +TZ=EST-10 +export TZ seq=`basename $0` if which pmlogreduce >/dev/null 2>&1 On Tue, Sep 01, 2009 at 11:31:52AM -0500, Martin Hicks wrote: > > I've started playing with the QA tests, running them against PCP-2.9.0 > So far I've managed to get through nearly the first 150 tests, fixing a > few things along the way. > > The thing I started hitting in the 100's was that the hours on the > archives are coming out incorrectly (or the archives are wrong, or the > 144.out is incorrect). > > pmdumplog is telling me the same thing as pmlogreduce is: > > pcpqa@laplace:/home/mort/src/pcpqa.git$ pmdumplog -a src-oss/naslog | head -n 4 > Log Label (Log Format Version 2) > Performance metrics from host snort > commencing Thu Apr 8 01:11:09.969 2004 > ending Thu Apr 8 01:21:25.942 2004 > > The full log is attached. > > pcpqa@laplace:/home/mort/src/pcpqa.git$ diff -u 144.out 144.out.bad > --- 144.out 2009-08-27 09:08:26.000000000 -0400 > +++ 144.out.bad 2009-09-01 12:28:17.000000000 -0400 > @@ -3,30 +3,30 @@ > > === network.interface.baudrate === > 5c5 > -< end: Thu Apr 8 15:21:25 2004 > +< end: Thu Apr 8 01:21:25 2004 > --- > -> end: Thu Apr 8 15:21:00 2004 > +> end: Thu Apr 8 01:21:00 2004 > > === network.interface.in.packets === > 5c5 > -< end: Thu Apr 8 15:21:25 2004 > +< end: Thu Apr 8 01:21:25 2004 > --- > -> end: Thu Apr 8 15:21:00 2004 > +> end: Thu Apr 8 01:21:00 2004 > > === kernel.all.load === > 5c5 > -< end: Thu Apr 8 15:21:25 2004 > +< end: Thu Apr 8 01:21:25 2004 > --- > -> end: Thu Apr 8 15:21:00 2004 > +> end: Thu Apr 8 01:21:00 2004 > > === kernel.all.cpu.idle === > 5c5 > -< end: Thu Apr 8 15:21:25 2004 > +< end: Thu Apr 8 01:21:25 2004 > --- > -> end: Thu Apr 8 15:21:00 2004 > +> end: Thu Apr 8 01:21:00 2004 > > === disk.all.total === > 5c5 > -< end: Thu Apr 8 15:21:25 2004 > +< end: Thu Apr 8 01:21:25 2004 > --- > -> end: Thu Apr 8 15:21:00 2004 > +> end: Thu Apr 8 01:21:00 2004 > > > === network.interface.baudrate === > --- original --- > > metric: network.interface.baudrate > archive: src-oss/naslog > host: snort > start: Thu Apr 8 01:11:30 2004 > end: Thu Apr 8 01:21:25 2004 > semantics: discrete instantaneous value > units: byte / sec > samples: 19 > interval: 30.00 sec > > lo0 ef2 ef0 > 01:11:30.000 0 10000000 10000000 > 01:12:00.000 0 10000000 10000000 > 01:12:30.000 0 10000000 10000000 > 01:13:00.000 0 10000000 10000000 > 01:13:30.000 0 10000000 10000000 > 01:14:00.000 0 10000000 10000000 > 01:14:30.000 0 10000000 10000000 > 01:15:00.000 0 10000000 10000000 > 01:15:30.000 0 10000000 10000000 > 01:16:00.000 0 10000000 10000000 > 01:16:30.000 0 10000000 10000000 > 01:17:00.000 0 10000000 10000000 > 01:17:30.000 0 10000000 10000000 > 01:18:00.000 0 10000000 10000000 > 01:18:30.000 0 10000000 10000000 > 01:19:00.000 0 10000000 10000000 > 01:19:30.000 0 10000000 10000000 > 01:20:00.000 0 10000000 10000000 > 01:20:30.000 0 10000000 10000000 > --- reduced --- > > metric: network.interface.baudrate > archive: /tmp/22795 > host: snort > start: Thu Apr 8 01:11:30 2004 > end: Thu Apr 8 01:21:00 2004 > semantics: discrete instantaneous value > units: byte / sec > samples: 19 > interval: 30.00 sec > > lo0 ef2 ef0 > 01:11:30.000 0 10000000 10000000 > 01:12:00.000 0 10000000 10000000 > 01:12:30.000 0 10000000 10000000 > 01:13:00.000 0 10000000 10000000 > 01:13:30.000 0 10000000 10000000 > 01:14:00.000 0 10000000 10000000 > 01:14:30.000 0 10000000 10000000 > 01:15:00.000 0 10000000 10000000 > 01:15:30.000 0 10000000 10000000 > 01:16:00.000 0 10000000 10000000 > 01:16:30.000 0 10000000 10000000 > 01:17:00.000 0 10000000 10000000 > 01:17:30.000 0 10000000 10000000 > 01:18:00.000 0 10000000 10000000 > 01:18:30.000 0 10000000 10000000 > 01:19:00.000 0 10000000 10000000 > 01:19:30.000 0 10000000 10000000 > 01:20:00.000 0 10000000 10000000 > 01:20:30.000 0 10000000 10000000 > === network.interface.in.packets === > --- original --- > > metric: network.interface.in.packets > archive: src-oss/naslog > host: snort > start: Thu Apr 8 01:11:30 2004 > end: Thu Apr 8 01:21:25 2004 > semantics: cumulative counter (converting to rate) > units: count (converting to count / sec) > samples: 19 > interval: 30.00 sec > > lo0 ef2 ef0 > 01:12:00.000 52.37 0.0 678.5 > 01:12:30.000 71.47 0.0 762.9 > 01:13:00.000 73.03 0.0 688.8 > 01:13:30.000 80.43 0.0 616.1 > 01:14:00.000 70.87 0.0 560.6 > 01:14:30.000 66.73 0.0 691.8 > 01:15:00.000 61.70 0.0 697.8 > 01:15:30.000 89.37 0.0 709.7 > 01:16:00.000 82.57 0.0 762.4 > 01:16:30.000 82.67 0.0 673.0 > 01:17:00.000 52.67 0.0 639.4 > 01:17:30.000 57.20 0.0 646.4 > 01:18:00.000 50.07 0.0 216.8 > 01:18:30.000 50.93 0.0 115.3 > 01:19:00.000 57.53 0.0 160.8 > 01:19:30.000 57.93 0.0 240.8 > 01:20:00.000 53.47 0.0 167.5 > 01:20:30.000 64.93 0.0 182.0 > 01:21:00.000 49.33 0.0 187.2 > --- reduced --- > > metric: network.interface.in.packets > archive: /tmp/22795 > host: snort > start: Thu Apr 8 01:11:30 2004 > end: Thu Apr 8 01:21:00 2004 > semantics: cumulative counter (converting to rate) > units: count (converting to count / sec) > samples: 19 > interval: 30.00 sec > > lo0 ef2 ef0 > 01:12:00.000 52.37 0.0 678.5 > 01:12:30.000 71.47 0.0 762.9 > 01:13:00.000 73.03 0.0 688.8 > 01:13:30.000 80.43 0.0 616.1 > 01:14:00.000 70.87 0.0 560.6 > 01:14:30.000 66.73 0.0 691.8 > 01:15:00.000 61.70 0.0 697.8 > 01:15:30.000 89.37 0.0 709.7 > 01:16:00.000 82.57 0.0 762.4 > 01:16:30.000 82.67 0.0 673.0 > 01:17:00.000 52.67 0.0 639.4 > 01:17:30.000 57.20 0.0 646.4 > 01:18:00.000 50.07 0.0 216.8 > 01:18:30.000 50.93 0.0 115.3 > 01:19:00.000 57.53 0.0 160.8 > 01:19:30.000 57.93 0.0 240.8 > 01:20:00.000 53.47 0.0 167.5 > 01:20:30.000 64.93 0.0 182.0 > 01:21:00.000 49.33 0.0 187.2 > === kernel.all.load === > --- original --- > > metric: kernel.all.load > archive: src-oss/naslog > host: snort > start: Thu Apr 8 01:11:30 2004 > end: Thu Apr 8 01:21:25 2004 > semantics: instantaneous value > units: none > samples: 19 > interval: 30.00 sec > > 1 minute 5 minute 15 minute > 01:11:30.000 3.269 2.493 1.818 > 01:12:00.000 3.271 2.573 1.867 > 01:12:30.000 2.763 2.511 1.867 > 01:13:00.000 2.867 2.564 1.906 > 01:13:30.000 3.208 2.674 1.970 > 01:14:00.000 3.173 2.713 2.007 > 01:14:30.000 3.099 2.750 2.043 > 01:15:00.000 2.827 2.717 2.051 > 01:15:30.000 2.815 2.728 2.077 > 01:16:00.000 3.036 2.788 2.119 > 01:16:30.000 2.591 2.702 2.111 > 01:17:00.000 2.105 2.580 2.085 > 01:17:30.000 1.681 2.413 2.038 > 01:18:00.000 1.290 2.252 1.988 > 01:18:30.000 0.7969 2.026 1.915 > 01:19:00.000 0.8037 1.916 1.876 > 01:19:30.000 0.8369 1.805 1.832 > 01:20:00.000 0.5811 1.649 1.771 > 01:20:30.000 0.9023 1.605 1.750 > --- reduced --- > > metric: kernel.all.load > archive: /tmp/22795 > host: snort > start: Thu Apr 8 01:11:30 2004 > end: Thu Apr 8 01:21:00 2004 > semantics: instantaneous value > units: none > samples: 19 > interval: 30.00 sec > > 1 minute 5 minute 15 minute > 01:11:30.000 3.269 2.493 1.818 > 01:12:00.000 3.271 2.573 1.867 > 01:12:30.000 2.763 2.511 1.867 > 01:13:00.000 2.867 2.564 1.906 > 01:13:30.000 3.208 2.674 1.970 > 01:14:00.000 3.173 2.713 2.007 > 01:14:30.000 3.099 2.750 2.043 > 01:15:00.000 2.827 2.717 2.051 > 01:15:30.000 2.815 2.728 2.077 > 01:16:00.000 3.036 2.788 2.119 > 01:16:30.000 2.591 2.702 2.111 > 01:17:00.000 2.105 2.580 2.085 > 01:17:30.000 1.681 2.413 2.038 > 01:18:00.000 1.290 2.252 1.988 > 01:18:30.000 0.7969 2.026 1.915 > 01:19:00.000 0.8037 1.916 1.876 > 01:19:30.000 0.8369 1.805 1.832 > 01:20:00.000 0.5811 1.649 1.771 > 01:20:30.000 0.9023 1.605 1.750 > === kernel.all.cpu.idle === > --- original --- > > metric: kernel.all.cpu.idle > archive: src-oss/naslog > host: snort > start: Thu Apr 8 01:11:30 2004 > end: Thu Apr 8 01:21:25 2004 > semantics: cumulative counter (converting to rate) > units: millisec (converting to time utilization) > samples: 19 > interval: 30.00 sec > 01:12:00.000 6.414 > 01:12:30.000 7.266 > 01:13:00.000 7.443 > 01:13:30.000 7.031 > 01:14:00.000 6.765 > 01:14:30.000 7.076 > 01:15:00.000 7.417 > 01:15:30.000 7.253 > 01:16:00.000 7.239 > 01:16:30.000 7.682 > 01:17:00.000 8.709 > 01:17:30.000 8.743 > 01:18:00.000 9.470 > 01:18:30.000 9.731 > 01:19:00.000 9.599 > 01:19:30.000 9.448 > 01:20:00.000 9.549 > 01:20:30.000 9.461 > 01:21:00.000 9.581 > --- reduced --- > > metric: kernel.all.cpu.idle > archive: /tmp/22795 > host: snort > start: Thu Apr 8 01:11:30 2004 > end: Thu Apr 8 01:21:00 2004 > semantics: cumulative counter (converting to rate) > units: millisec (converting to time utilization) > samples: 19 > interval: 30.00 sec > 01:12:00.000 6.414 > 01:12:30.000 7.266 > 01:13:00.000 7.443 > 01:13:30.000 7.031 > 01:14:00.000 6.765 > 01:14:30.000 7.076 > 01:15:00.000 7.417 > 01:15:30.000 7.253 > 01:16:00.000 7.239 > 01:16:30.000 7.682 > 01:17:00.000 8.709 > 01:17:30.000 8.743 > 01:18:00.000 9.470 > 01:18:30.000 9.731 > 01:19:00.000 9.599 > 01:19:30.000 9.448 > 01:20:00.000 9.549 > 01:20:30.000 9.461 > 01:21:00.000 9.581 > === disk.all.total === > --- original --- > > metric: disk.all.total > archive: src-oss/naslog > host: snort > start: Thu Apr 8 01:11:30 2004 > end: Thu Apr 8 01:21:25 2004 > semantics: cumulative counter (converting to rate) > units: count (converting to count / sec) > samples: 19 > interval: 30.00 sec > 01:12:00.000 355.9 > 01:12:30.000 239.3 > 01:13:00.000 168.0 > 01:13:30.000 119.7 > 01:14:00.000 211.2 > 01:14:30.000 235.7 > 01:15:00.000 188.2 > 01:15:30.000 152.6 > 01:16:00.000 164.9 > 01:16:30.000 190.7 > 01:17:00.000 154.1 > 01:17:30.000 138.1 > 01:18:00.000 32.77 > 01:18:30.000 18.87 > 01:19:00.000 14.50 > 01:19:30.000 19.37 > 01:20:00.000 18.03 > 01:20:30.000 21.40 > 01:21:00.000 18.63 > --- reduced --- > > metric: disk.all.total > archive: /tmp/22795 > host: snort > start: Thu Apr 8 01:11:30 2004 > end: Thu Apr 8 01:21:00 2004 > semantics: cumulative counter (converting to rate) > units: count (converting to count / sec) > samples: 19 > interval: 30.00 sec > 01:12:00.000 355.9 > 01:12:30.000 239.3 > 01:13:00.000 168.0 > 01:13:30.000 119.7 > 01:14:00.000 211.2 > 01:14:30.000 235.7 > 01:15:00.000 188.2 > 01:15:30.000 152.6 > 01:16:00.000 164.9 > 01:16:30.000 190.7 > 01:17:00.000 154.1 > 01:17:30.000 138.1 > 01:18:00.000 32.77 > 01:18:30.000 18.87 > 01:19:00.000 14.50 > 01:19:30.000 19.37 > 01:20:00.000 18.03 > 01:20:30.000 21.40 > 01:21:00.000 18.63 > _______________________________________________ > pcp mailing list > pcp@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/pcp From mort@sgi.com Tue Sep 1 14:56:06 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_65 autolearn=no version=3.3.0-rupdated Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n81JtkaP203648 for ; Tue, 1 Sep 2009 14:55:56 -0500 Received: from attica.americas.sgi.com (attica.americas.sgi.com [128.162.236.44]) by relay1.corp.sgi.com (Postfix) with ESMTP id 3A4E88F80BA for ; Tue, 1 Sep 2009 12:56:43 -0700 (PDT) Received: by attica.americas.sgi.com (Postfix, from userid 44682) id DEF20A23CA70; Tue, 1 Sep 2009 14:50:23 -0500 (CDT) Date: Tue, 1 Sep 2009 14:50:23 -0500 From: Martin Hicks To: pcp@oss.sgi.com Subject: QA: pmval showing one less sample Message-ID: <20090901195023.GG16972@alcatraz.americas.sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.17 (2007-11-01) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Tests 166 and 176 are showing one less sample than the expected output with pcp 2.9.0. Not sure what's going on here. Is this just a bug that's been fixed? If I pmdumptext the original archive I see 54 samples, but the first one is a "?". Maybe pmval is now reporting how many intervals (samples-1) ? mh pcpqa@laplace:/home/mort/src/pcpqa.git$ diff -u 166.out 166.out.bad --- 166.out 2009-08-27 09:08:26.000000000 -0400 +++ 166.out.bad 2009-09-01 15:42:43.000000000 -0400 @@ -15,7 +15,7 @@ end: Wed Jan 19 22:10:26 2005 semantics: cumulative counter (converting to rate) units: millisec (converting to time utilization) -samples: 54 +samples: 53 interval: 15.00 sec 21:57:15.000 1.000 21:57:30.000 1.000 @@ -83,7 +83,7 @@ end: Wed Jan 19 22:10:26 2005 semantics: cumulative counter units: millisec -samples: 54 +samples: 53 interval: 15.00 sec 21:57:00.000 3394854 21:57:15.000 3409854 @@ -138,7 +138,6 @@ 22:09:30.000 4144854 22:09:45.000 4159854 22:10:00.000 4174854 -22:10:15.000 4189854 --- pmval -U using reduced archive --- Note: timezone set to local timezone of host "kenj-pc" from archive @@ -207,7 +206,7 @@ end: Wed Jan 19 22:10:00 2005 semantics: cumulative counter (converting to rate) units: millisec (converting to time utilization) -samples: 53 +samples: 52 interval: 15.00 sec 21:57:15.000 1.000 21:57:30.000 1.000 @@ -274,7 +273,7 @@ end: Wed Jan 19 22:10:00 2005 semantics: cumulative counter units: millisec -samples: 53 +samples: 52 interval: 15.00 sec 21:57:00.000 3394854 21:57:15.000 3409854 @@ -328,7 +327,6 @@ 22:09:15.000 4129854 22:09:30.000 4144854 22:09:45.000 4159854 -22:10:00.000 4174854 === sample.drift === --- pmval using input archive --- @@ -341,7 +339,7 @@ end: Wed Jan 19 22:10:26 2005 semantics: instantaneous value units: none -samples: 54 +samples: 53 interval: 15.00 sec 21:57:00.000 479 21:57:15.000 399 @@ -396,7 +394,6 @@ 22:09:30.000 326 22:09:45.000 311 22:10:00.000 314 -22:10:15.000 284 --- pmval -U using reduced archive --- Note: timezone set to local timezone of host "kenj-pc" from archive @@ -437,7 +434,7 @@ end: Wed Jan 19 22:10:00 2005 semantics: instantaneous value units: none -samples: 53 +samples: 52 interval: 15.00 sec 21:57:00.000 479 21:57:15.000 479 @@ -491,4 +488,3 @@ 22:09:15.000 360 22:09:30.000 360 22:09:45.000 360 -22:10:00.000 314 From nscott@aconex.com Tue Sep 1 18:53:49 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n81NrSs2217071 for ; Tue, 1 Sep 2009 18:53:39 -0500 X-ASG-Debug-ID: 1251849238-044501620000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 46609419217 for ; Tue, 1 Sep 2009 16:53:59 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id dKk6vPJtwh3SfMmx for ; Tue, 01 Sep 2009 16:53:59 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 647F5337161; Wed, 2 Sep 2009 09:53:56 +1000 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id u2EVqa43jfe8WQBb; Wed, 02 Sep 2009 09:53:56 +1000 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id B8BC3A50123; Wed, 2 Sep 2009 09:52:55 +1000 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 4C46A4FD86; Wed, 2 Sep 2009 09:53:56 +1000 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at gatekeeper.yarra.acx Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bKnnPYFe3-or; Wed, 2 Sep 2009 09:53:51 +1000 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 95AA54FD85; Wed, 2 Sep 2009 09:53:51 +1000 (EST) Date: Wed, 2 Sep 2009 09:53:51 +1000 (EST) From: Nathan Scott To: Martin Hicks Cc: pcp@oss.sgi.com Message-ID: <1278431359.194371251849231568.JavaMail.root@mail-au.aconex.com> In-Reply-To: <97071382.194351251849196103.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: Re: [pcp] QA: pmval showing one less sample Subject: Re: [pcp] QA: pmval showing one less sample MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1251849265 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.7857 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ----- "Martin Hicks" wrote: > Tests 166 and 176 are showing one less sample than the expected > output > with pcp 2.9.0. Not sure what's going on here. > > Is this just a bug that's been fixed? If I pmdumptext the original > archive I see 54 samples, but the first one is a "?". Maybe pmval is > now reporting how many intervals (samples-1) ? I can't think of any changes that could have caused this, don't think there have been any pmval changes, nor libpcp fetch related changes. When was the last successful run of this test for you? I'll try to get to doing a full QA run today/tomorrow, see if it happens here too. cheers. -- Nathan From mort@bork.org Tue Sep 1 19:21:07 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n820KlRh218684 for ; Tue, 1 Sep 2009 19:20:57 -0500 X-ASG-Debug-ID: 1251850878-44b0022c0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from darwin.bork.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 6D48A15A64F1 for ; Tue, 1 Sep 2009 17:21:18 -0700 (PDT) Received: from darwin.bork.org (darwin.bork.org [65.49.60.145]) by cuda.sgi.com with ESMTP id cF3bcOWFbHorpHq1 for ; Tue, 01 Sep 2009 17:21:18 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by darwin.bork.org (Postfix) with ESMTP id 6080A19252; Tue, 1 Sep 2009 20:16:03 -0400 (EDT) Received: from darwin.bork.org ([127.0.0.1]) by localhost (darwin.bork.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id eUUDyp0+gqY7; Tue, 1 Sep 2009 20:16:03 -0400 (EDT) Received: from socrates.bork.org (localhost [127.0.0.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "socrates.bork.org", Issuer "Bork Consulting CA" (not verified)) by darwin.bork.org (Postfix) with ESMTPS id 595A819149; Tue, 1 Sep 2009 20:16:02 -0400 (EDT) Received: by socrates.bork.org (Postfix, from userid 1000) id 9AE51CBA7C; Tue, 1 Sep 2009 20:20:25 -0400 (EDT) Date: Tue, 1 Sep 2009 20:20:25 -0400 From: Martin Hicks To: Nathan Scott Cc: Martin Hicks , pcp@oss.sgi.com X-ASG-Orig-Subj: Re: [pcp] QA: pmval showing one less sample Subject: Re: [pcp] QA: pmval showing one less sample Message-ID: <20090902002025.GF12979@socrates.bork.org> References: <97071382.194351251849196103.JavaMail.root@mail-au.aconex.com> <1278431359.194371251849231568.JavaMail.root@mail-au.aconex.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1278431359.194371251849231568.JavaMail.root@mail-au.aconex.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-Barracuda-Connect: darwin.bork.org[65.49.60.145] X-Barracuda-Start-Time: 1251850900 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.7859 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Wed, Sep 02, 2009 at 09:53:51AM +1000, Nathan Scott wrote: > > ----- "Martin Hicks" wrote: > > > Tests 166 and 176 are showing one less sample than the expected > > output > > with pcp 2.9.0. Not sure what's going on here. > > > > Is this just a bug that's been fixed? If I pmdumptext the original > > archive I see 54 samples, but the first one is a "?". Maybe pmval is > > now reporting how many intervals (samples-1) ? > > I can't think of any changes that could have caused this, don't think > there have been any pmval changes, nor libpcp fetch related changes. > When was the last successful run of this test for you? I'll try to > get to doing a full QA run today/tomorrow, see if it happens here too. This is the first time I've tried to use the QA stuff. I'll see if the older PCP that we're still shipping has the bug. (2.7.8 right around the 2.8.0 release time. March-ish) mh > > cheers. > > -- > Nathan > > _______________________________________________ > pcp mailing list > pcp@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/pcp From nscott@aconex.com Tue Sep 1 21:41:47 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n822fRFk227181 for ; Tue, 1 Sep 2009 21:41:37 -0500 X-ASG-Debug-ID: 1251859318-267601780000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 555574196E7 for ; Tue, 1 Sep 2009 19:41:59 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id MGBpTbZG3YiyMC9G for ; Tue, 01 Sep 2009 19:41:59 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 10CC180D4DB for ; Wed, 2 Sep 2009 12:41:55 +1000 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id QPWYvnMM3BjUQ1f5 for ; Wed, 02 Sep 2009 12:41:55 +1000 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 63202A50123 for ; Wed, 2 Sep 2009 12:40:54 +1000 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 071274FD85 for ; Wed, 2 Sep 2009 12:41:55 +1000 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at gatekeeper.yarra.acx Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fJ4SMP4S1eZE for ; Wed, 2 Sep 2009 12:41:51 +1000 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 04E4C4FD82 for ; Wed, 2 Sep 2009 12:41:51 +1000 (EST) Date: Wed, 2 Sep 2009 12:41:50 +1000 (EST) From: Nathan Scott To: pcp Message-ID: <1227112811.201761251859310912.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcp updates Subject: pcp updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1251859343 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.7866 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Changes committed to git://oss.sgi.com/nathans/pcp.git src/pmdas/mmv/.gitignore | 5 +- src/pmdas/mmv/GNUmakefile | 26 +++++++----- src/pmdas/mmv/Install | 6 ++ src/pmdas/mmv/Remove | 5 +- src/pmdas/mmv/mmv.c | 98 +++++++++++++++++++++++++++------------------- src/pmdas/windows/open.c | 2 src/pmdas/windows/pmda.c | 6 +- 7 files changed, 89 insertions(+), 59 deletions(-) commit 3323bb90ad5f66480c05b7fe182a72a0813c9b41 Author: Nathan Scott Date: Wed Sep 2 12:30:47 2009 +1000 Fix a segv observed in the Windows PMDA accessing SQL Server metrics. The recent optimisation added for direct instance domain lookup added a flaw that could case an array index of -1 to be used to access into the metric value table. Observed on SQL Server 2008 & Windows Server 2008 R2 only so far. commit 1112ac636cae6feac624279c76239003662d4a35 Author: Nathan Scott Date: Wed Sep 2 11:49:20 2009 +1000 Small MMV pmda changes to allow DSO builds in the future. Turns out that the current protocol for getting pmcd to update its namespace cannot be used from DSO agents ... one more reason to revamp this area. commit 677c6f2cea7fce4ff5f10f939fc5a942861719dd Author: Nathan Scott Date: Wed Sep 2 11:46:40 2009 +1000 Fix logic error causing wrong windows version to be reported. From kenj@internode.on.net Tue Sep 1 22:35:37 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_56 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n823ZHmh230094 for ; Tue, 1 Sep 2009 22:35:27 -0500 X-ASG-Debug-ID: 1251862550-63ff021e0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id C4C95148BCFD for ; Tue, 1 Sep 2009 20:35:51 -0700 (PDT) Received: from mail.internode.on.net (bld-mail18.adl2.internode.on.net [150.101.137.103]) by cuda.sgi.com with ESMTP id 2FGbewRmomU0884j for ; Tue, 01 Sep 2009 20:35:51 -0700 (PDT) Received: from [192.168.1.100] (unverified [118.208.196.130]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 4555406-1927428 for multiple; Wed, 02 Sep 2009 13:05:32 +0930 (CST) X-ASG-Orig-Subj: Re: [pcp] QA tests and pmlogreduce setting hours to "01" Subject: Re: [pcp] QA tests and pmlogreduce setting hours to "01" From: Ken McDonell Reply-To: kenj@internode.on.net To: Martin Hicks Cc: pcp@oss.sgi.com In-Reply-To: <20090901180959.GE16972@alcatraz.americas.sgi.com> References: <20090901163152.GC16972@alcatraz.americas.sgi.com> <20090901180959.GE16972@alcatraz.americas.sgi.com> Content-Type: multipart/mixed; boundary="=-DE5VbUeAw6JwOoMtAbj4" Date: Wed, 02 Sep 2009 13:35:25 +1000 Message-Id: <1251862525.16149.1480.camel@bozo> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 X-Barracuda-Connect: bld-mail18.adl2.internode.on.net[150.101.137.103] X-Barracuda-Start-Time: 1251862572 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.7870 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean --=-DE5VbUeAw6JwOoMtAbj4 Content-Type: text/plain Content-Transfer-Encoding: 7bit Good guess Martin. A better fix would be to use -z on the two pmval commands ... unfortunately this produces output that is off by one hour, as the 144.out was created when the local timezone was EST-10, but the archive was created when the timezone was EST-11. I've attached updated versions of 144 and 144.out. On Tue, 2009-09-01 at 13:09 -0500, Martin Hicks wrote: > > aha. Perhaps timezone related? > > > pcpqa@laplace:/home/mort/src/pcpqa.git$ git diff 144 > diff --git a/144 b/144 > index e20e566..54b5198 100755 > --- a/144 > +++ b/144 > @@ -9,6 +9,8 @@ > # creator > owner=kenmcd > > +TZ=EST-10 > +export TZ > seq=`basename $0` > > if which pmlogreduce >/dev/null 2>&1 > > > On Tue, Sep 01, 2009 at 11:31:52AM -0500, Martin Hicks wrote: > > > > I've started playing with the QA tests, running them against PCP-2.9.0 > > So far I've managed to get through nearly the first 150 tests, fixing a > > few things along the way. > > > > The thing I started hitting in the 100's was that the hours on the > > archives are coming out incorrectly (or the archives are wrong, or the > > 144.out is incorrect). > > > > pmdumplog is telling me the same thing as pmlogreduce is: > > > > pcpqa@laplace:/home/mort/src/pcpqa.git$ pmdumplog -a src-oss/naslog | head -n 4 > > Log Label (Log Format Version 2) > > Performance metrics from host snort > > commencing Thu Apr 8 01:11:09.969 2004 > > ending Thu Apr 8 01:21:25.942 2004 > > > > The full log is attached. > > > > pcpqa@laplace:/home/mort/src/pcpqa.git$ diff -u 144.out 144.out.bad > > --- 144.out 2009-08-27 09:08:26.000000000 -0400 > > +++ 144.out.bad 2009-09-01 12:28:17.000000000 -0400 > > @@ -3,30 +3,30 @@ > > > > === network.interface.baudrate === > > 5c5 > > -< end: Thu Apr 8 15:21:25 2004 > > +< end: Thu Apr 8 01:21:25 2004 > > --- > > -> end: Thu Apr 8 15:21:00 2004 > > +> end: Thu Apr 8 01:21:00 2004 > > > > === network.interface.in.packets === > > 5c5 > > -< end: Thu Apr 8 15:21:25 2004 > > +< end: Thu Apr 8 01:21:25 2004 > > --- > > -> end: Thu Apr 8 15:21:00 2004 > > +> end: Thu Apr 8 01:21:00 2004 > > > > === kernel.all.load === > > 5c5 > > -< end: Thu Apr 8 15:21:25 2004 > > +< end: Thu Apr 8 01:21:25 2004 > > --- > > -> end: Thu Apr 8 15:21:00 2004 > > +> end: Thu Apr 8 01:21:00 2004 > > > > === kernel.all.cpu.idle === > > 5c5 > > -< end: Thu Apr 8 15:21:25 2004 > > +< end: Thu Apr 8 01:21:25 2004 > > --- > > -> end: Thu Apr 8 15:21:00 2004 > > +> end: Thu Apr 8 01:21:00 2004 > > > > === disk.all.total === > > 5c5 > > -< end: Thu Apr 8 15:21:25 2004 > > +< end: Thu Apr 8 01:21:25 2004 > > --- > > -> end: Thu Apr 8 15:21:00 2004 > > +> end: Thu Apr 8 01:21:00 2004 > > > > > > > === network.interface.baudrate === > > --- original --- > > > > metric: network.interface.baudrate > > archive: src-oss/naslog > > host: snort > > start: Thu Apr 8 01:11:30 2004 > > end: Thu Apr 8 01:21:25 2004 > > semantics: discrete instantaneous value > > units: byte / sec > > samples: 19 > > interval: 30.00 sec > > > > lo0 ef2 ef0 > > 01:11:30.000 0 10000000 10000000 > > 01:12:00.000 0 10000000 10000000 > > 01:12:30.000 0 10000000 10000000 > > 01:13:00.000 0 10000000 10000000 > > 01:13:30.000 0 10000000 10000000 > > 01:14:00.000 0 10000000 10000000 > > 01:14:30.000 0 10000000 10000000 > > 01:15:00.000 0 10000000 10000000 > > 01:15:30.000 0 10000000 10000000 > > 01:16:00.000 0 10000000 10000000 > > 01:16:30.000 0 10000000 10000000 > > 01:17:00.000 0 10000000 10000000 > > 01:17:30.000 0 10000000 10000000 > > 01:18:00.000 0 10000000 10000000 > > 01:18:30.000 0 10000000 10000000 > > 01:19:00.000 0 10000000 10000000 > > 01:19:30.000 0 10000000 10000000 > > 01:20:00.000 0 10000000 10000000 > > 01:20:30.000 0 10000000 10000000 > > --- reduced --- > > > > metric: network.interface.baudrate > > archive: /tmp/22795 > > host: snort > > start: Thu Apr 8 01:11:30 2004 > > end: Thu Apr 8 01:21:00 2004 > > semantics: discrete instantaneous value > > units: byte / sec > > samples: 19 > > interval: 30.00 sec > > > > lo0 ef2 ef0 > > 01:11:30.000 0 10000000 10000000 > > 01:12:00.000 0 10000000 10000000 > > 01:12:30.000 0 10000000 10000000 > > 01:13:00.000 0 10000000 10000000 > > 01:13:30.000 0 10000000 10000000 > > 01:14:00.000 0 10000000 10000000 > > 01:14:30.000 0 10000000 10000000 > > 01:15:00.000 0 10000000 10000000 > > 01:15:30.000 0 10000000 10000000 > > 01:16:00.000 0 10000000 10000000 > > 01:16:30.000 0 10000000 10000000 > > 01:17:00.000 0 10000000 10000000 > > 01:17:30.000 0 10000000 10000000 > > 01:18:00.000 0 10000000 10000000 > > 01:18:30.000 0 10000000 10000000 > > 01:19:00.000 0 10000000 10000000 > > 01:19:30.000 0 10000000 10000000 > > 01:20:00.000 0 10000000 10000000 > > 01:20:30.000 0 10000000 10000000 > > === network.interface.in.packets === > > --- original --- > > > > metric: network.interface.in.packets > > archive: src-oss/naslog > > host: snort > > start: Thu Apr 8 01:11:30 2004 > > end: Thu Apr 8 01:21:25 2004 > > semantics: cumulative counter (converting to rate) > > units: count (converting to count / sec) > > samples: 19 > > interval: 30.00 sec > > > > lo0 ef2 ef0 > > 01:12:00.000 52.37 0.0 678.5 > > 01:12:30.000 71.47 0.0 762.9 > > 01:13:00.000 73.03 0.0 688.8 > > 01:13:30.000 80.43 0.0 616.1 > > 01:14:00.000 70.87 0.0 560.6 > > 01:14:30.000 66.73 0.0 691.8 > > 01:15:00.000 61.70 0.0 697.8 > > 01:15:30.000 89.37 0.0 709.7 > > 01:16:00.000 82.57 0.0 762.4 > > 01:16:30.000 82.67 0.0 673.0 > > 01:17:00.000 52.67 0.0 639.4 > > 01:17:30.000 57.20 0.0 646.4 > > 01:18:00.000 50.07 0.0 216.8 > > 01:18:30.000 50.93 0.0 115.3 > > 01:19:00.000 57.53 0.0 160.8 > > 01:19:30.000 57.93 0.0 240.8 > > 01:20:00.000 53.47 0.0 167.5 > > 01:20:30.000 64.93 0.0 182.0 > > 01:21:00.000 49.33 0.0 187.2 > > --- reduced --- > > > > metric: network.interface.in.packets > > archive: /tmp/22795 > > host: snort > > start: Thu Apr 8 01:11:30 2004 > > end: Thu Apr 8 01:21:00 2004 > > semantics: cumulative counter (converting to rate) > > units: count (converting to count / sec) > > samples: 19 > > interval: 30.00 sec > > > > lo0 ef2 ef0 > > 01:12:00.000 52.37 0.0 678.5 > > 01:12:30.000 71.47 0.0 762.9 > > 01:13:00.000 73.03 0.0 688.8 > > 01:13:30.000 80.43 0.0 616.1 > > 01:14:00.000 70.87 0.0 560.6 > > 01:14:30.000 66.73 0.0 691.8 > > 01:15:00.000 61.70 0.0 697.8 > > 01:15:30.000 89.37 0.0 709.7 > > 01:16:00.000 82.57 0.0 762.4 > > 01:16:30.000 82.67 0.0 673.0 > > 01:17:00.000 52.67 0.0 639.4 > > 01:17:30.000 57.20 0.0 646.4 > > 01:18:00.000 50.07 0.0 216.8 > > 01:18:30.000 50.93 0.0 115.3 > > 01:19:00.000 57.53 0.0 160.8 > > 01:19:30.000 57.93 0.0 240.8 > > 01:20:00.000 53.47 0.0 167.5 > > 01:20:30.000 64.93 0.0 182.0 > > 01:21:00.000 49.33 0.0 187.2 > > === kernel.all.load === > > --- original --- > > > > metric: kernel.all.load > > archive: src-oss/naslog > > host: snort > > start: Thu Apr 8 01:11:30 2004 > > end: Thu Apr 8 01:21:25 2004 > > semantics: instantaneous value > > units: none > > samples: 19 > > interval: 30.00 sec > > > > 1 minute 5 minute 15 minute > > 01:11:30.000 3.269 2.493 1.818 > > 01:12:00.000 3.271 2.573 1.867 > > 01:12:30.000 2.763 2.511 1.867 > > 01:13:00.000 2.867 2.564 1.906 > > 01:13:30.000 3.208 2.674 1.970 > > 01:14:00.000 3.173 2.713 2.007 > > 01:14:30.000 3.099 2.750 2.043 > > 01:15:00.000 2.827 2.717 2.051 > > 01:15:30.000 2.815 2.728 2.077 > > 01:16:00.000 3.036 2.788 2.119 > > 01:16:30.000 2.591 2.702 2.111 > > 01:17:00.000 2.105 2.580 2.085 > > 01:17:30.000 1.681 2.413 2.038 > > 01:18:00.000 1.290 2.252 1.988 > > 01:18:30.000 0.7969 2.026 1.915 > > 01:19:00.000 0.8037 1.916 1.876 > > 01:19:30.000 0.8369 1.805 1.832 > > 01:20:00.000 0.5811 1.649 1.771 > > 01:20:30.000 0.9023 1.605 1.750 > > --- reduced --- > > > > metric: kernel.all.load > > archive: /tmp/22795 > > host: snort > > start: Thu Apr 8 01:11:30 2004 > > end: Thu Apr 8 01:21:00 2004 > > semantics: instantaneous value > > units: none > > samples: 19 > > interval: 30.00 sec > > > > 1 minute 5 minute 15 minute > > 01:11:30.000 3.269 2.493 1.818 > > 01:12:00.000 3.271 2.573 1.867 > > 01:12:30.000 2.763 2.511 1.867 > > 01:13:00.000 2.867 2.564 1.906 > > 01:13:30.000 3.208 2.674 1.970 > > 01:14:00.000 3.173 2.713 2.007 > > 01:14:30.000 3.099 2.750 2.043 > > 01:15:00.000 2.827 2.717 2.051 > > 01:15:30.000 2.815 2.728 2.077 > > 01:16:00.000 3.036 2.788 2.119 > > 01:16:30.000 2.591 2.702 2.111 > > 01:17:00.000 2.105 2.580 2.085 > > 01:17:30.000 1.681 2.413 2.038 > > 01:18:00.000 1.290 2.252 1.988 > > 01:18:30.000 0.7969 2.026 1.915 > > 01:19:00.000 0.8037 1.916 1.876 > > 01:19:30.000 0.8369 1.805 1.832 > > 01:20:00.000 0.5811 1.649 1.771 > > 01:20:30.000 0.9023 1.605 1.750 > > === kernel.all.cpu.idle === > > --- original --- > > > > metric: kernel.all.cpu.idle > > archive: src-oss/naslog > > host: snort > > start: Thu Apr 8 01:11:30 2004 > > end: Thu Apr 8 01:21:25 2004 > > semantics: cumulative counter (converting to rate) > > units: millisec (converting to time utilization) > > samples: 19 > > interval: 30.00 sec > > 01:12:00.000 6.414 > > 01:12:30.000 7.266 > > 01:13:00.000 7.443 > > 01:13:30.000 7.031 > > 01:14:00.000 6.765 > > 01:14:30.000 7.076 > > 01:15:00.000 7.417 > > 01:15:30.000 7.253 > > 01:16:00.000 7.239 > > 01:16:30.000 7.682 > > 01:17:00.000 8.709 > > 01:17:30.000 8.743 > > 01:18:00.000 9.470 > > 01:18:30.000 9.731 > > 01:19:00.000 9.599 > > 01:19:30.000 9.448 > > 01:20:00.000 9.549 > > 01:20:30.000 9.461 > > 01:21:00.000 9.581 > > --- reduced --- > > > > metric: kernel.all.cpu.idle > > archive: /tmp/22795 > > host: snort > > start: Thu Apr 8 01:11:30 2004 > > end: Thu Apr 8 01:21:00 2004 > > semantics: cumulative counter (converting to rate) > > units: millisec (converting to time utilization) > > samples: 19 > > interval: 30.00 sec > > 01:12:00.000 6.414 > > 01:12:30.000 7.266 > > 01:13:00.000 7.443 > > 01:13:30.000 7.031 > > 01:14:00.000 6.765 > > 01:14:30.000 7.076 > > 01:15:00.000 7.417 > > 01:15:30.000 7.253 > > 01:16:00.000 7.239 > > 01:16:30.000 7.682 > > 01:17:00.000 8.709 > > 01:17:30.000 8.743 > > 01:18:00.000 9.470 > > 01:18:30.000 9.731 > > 01:19:00.000 9.599 > > 01:19:30.000 9.448 > > 01:20:00.000 9.549 > > 01:20:30.000 9.461 > > 01:21:00.000 9.581 > > === disk.all.total === > > --- original --- > > > > metric: disk.all.total > > archive: src-oss/naslog > > host: snort > > start: Thu Apr 8 01:11:30 2004 > > end: Thu Apr 8 01:21:25 2004 > > semantics: cumulative counter (converting to rate) > > units: count (converting to count / sec) > > samples: 19 > > interval: 30.00 sec > > 01:12:00.000 355.9 > > 01:12:30.000 239.3 > > 01:13:00.000 168.0 > > 01:13:30.000 119.7 > > 01:14:00.000 211.2 > > 01:14:30.000 235.7 > > 01:15:00.000 188.2 > > 01:15:30.000 152.6 > > 01:16:00.000 164.9 > > 01:16:30.000 190.7 > > 01:17:00.000 154.1 > > 01:17:30.000 138.1 > > 01:18:00.000 32.77 > > 01:18:30.000 18.87 > > 01:19:00.000 14.50 > > 01:19:30.000 19.37 > > 01:20:00.000 18.03 > > 01:20:30.000 21.40 > > 01:21:00.000 18.63 > > --- reduced --- > > > > metric: disk.all.total > > archive: /tmp/22795 > > host: snort > > start: Thu Apr 8 01:11:30 2004 > > end: Thu Apr 8 01:21:00 2004 > > semantics: cumulative counter (converting to rate) > > units: count (converting to count / sec) > > samples: 19 > > interval: 30.00 sec > > 01:12:00.000 355.9 > > 01:12:30.000 239.3 > > 01:13:00.000 168.0 > > 01:13:30.000 119.7 > > 01:14:00.000 211.2 > > 01:14:30.000 235.7 > > 01:15:00.000 188.2 > > 01:15:30.000 152.6 > > 01:16:00.000 164.9 > > 01:16:30.000 190.7 > > 01:17:00.000 154.1 > > 01:17:30.000 138.1 > > 01:18:00.000 32.77 > > 01:18:30.000 18.87 > > 01:19:00.000 14.50 > > 01:19:30.000 19.37 > > 01:20:00.000 18.03 > > 01:20:30.000 21.40 > > 01:21:00.000 18.63 > > > _______________________________________________ > > pcp mailing list > > pcp@oss.sgi.com > > http://oss.sgi.com/mailman/listinfo/pcp > > _______________________________________________ > pcp mailing list > pcp@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/pcp --=-DE5VbUeAw6JwOoMtAbj4 Content-Disposition: attachment; filename="144.out" Content-Type: text/plain; name="144.out"; charset="UTF-8" Content-Transfer-Encoding: 7bit QA output created by 144 Data reduction: .0476 === network.interface.baudrate === 6c6 < end: Thu Apr 8 16:21:25 2004 --- > end: Thu Apr 8 16:21:00 2004 === network.interface.in.packets === 6c6 < end: Thu Apr 8 16:21:25 2004 --- > end: Thu Apr 8 16:21:00 2004 === kernel.all.load === 6c6 < end: Thu Apr 8 16:21:25 2004 --- > end: Thu Apr 8 16:21:00 2004 === kernel.all.cpu.idle === 6c6 < end: Thu Apr 8 16:21:25 2004 --- > end: Thu Apr 8 16:21:00 2004 === disk.all.total === 6c6 < end: Thu Apr 8 16:21:25 2004 --- > end: Thu Apr 8 16:21:00 2004 --=-DE5VbUeAw6JwOoMtAbj4 Content-Disposition: attachment; filename="144" Content-Type: application/x-shellscript; name="144" Content-Transfer-Encoding: 7bit #! /bin/sh # PCP QA Test No. 144 # $Revision: 2.13 $ # # pmlogreduce data values # # Copyright (c) 2002 Silicon Graphics, Inc. All Rights Reserved. # creator owner=kenmcd seq=`basename $0` if which pmlogreduce >/dev/null 2>&1 then : else echo "No pmlogreduce binary installed" >$seq.notrun echo "$seq: [not run] `cat $seq.notrun`" exit 0 fi echo "QA output created by $seq" # get standard environment, filters and checks . ./common.product . ./common.filter . ./common.check _filter() { sed \ -e '/^archive:/d' \ -e 's/ */ /g' } tmp=/tmp/$$ here=`pwd` sudo=$here/sudo status=0 # success is the default! $sudo rm -rf $tmp.* trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15 rm -f $seq.full # real QA test starts here pmlogreduce -A 30sec -t 30sec src-oss/naslog $tmp nch_in=`wc -c >$seq.full echo "--- original ---" >>$seq.full pmval -z -a src-oss/naslog -t 30sec -A 30sec $metric 2>&1 \ | tee -a $seq.full \ | _filter >$tmp.in echo "--- reduced ---" >>$seq.full pmval -z -a $tmp -t 30sec -A 30sec $metric 2>&1 \ | tee -a $seq.full \ | _filter >$tmp.out diff $tmp.in $tmp.out done --=-DE5VbUeAw6JwOoMtAbj4-- From kenj@internode.on.net Tue Sep 1 22:36:33 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n823aDo3230149 for ; Tue, 1 Sep 2009 22:36:23 -0500 X-ASG-Debug-ID: 1251862623-640302260000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 0076B1574BAB for ; Tue, 1 Sep 2009 20:37:04 -0700 (PDT) Received: from mail.internode.on.net (bld-mail15.adl6.internode.on.net [150.101.137.100]) by cuda.sgi.com with ESMTP id StW4BQtYiWEtFHiw for ; Tue, 01 Sep 2009 20:37:04 -0700 (PDT) Received: from [192.168.1.100] (unverified [118.208.196.130]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 4602597-1927428 for multiple; Wed, 02 Sep 2009 13:06:59 +0930 (CST) X-ASG-Orig-Subj: Re: [pcp] QA tests and pmlogreduce setting hours to "01" Subject: Re: [pcp] QA tests and pmlogreduce setting hours to "01" From: Ken McDonell Reply-To: kenj@internode.on.net To: Martin Hicks Cc: pcp@oss.sgi.com In-Reply-To: <20090901163152.GC16972@alcatraz.americas.sgi.com> References: <20090901163152.GC16972@alcatraz.americas.sgi.com> Content-Type: text/plain Date: Wed, 02 Sep 2009 13:36:53 +1000 Message-Id: <1251862613.16149.1483.camel@bozo> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail15.adl6.internode.on.net[150.101.137.100] X-Barracuda-Start-Time: 1251862627 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.7870 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Tue, 2009-09-01 at 11:31 -0500, Martin Hicks wrote: > I've started playing with the QA tests, running them against PCP-2.9.0 > So far I've managed to get through nearly the first 150 tests, fixing a > few things along the way. Martin, if you could send me your "fixes" I can compare them with the changes I've been making for dynamic PMNS stuff, just to head off any possible merge conflicts down the track. Cheers, Ken. From nscott@aconex.com Wed Sep 2 01:33:00 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n826We6f241358 for ; Wed, 2 Sep 2009 01:32:50 -0500 X-ASG-Debug-ID: 1251873191-60a403ce0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 92983419DE3 for ; Tue, 1 Sep 2009 23:33:11 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id x4bdXNOUuuQazdet for ; Tue, 01 Sep 2009 23:33:11 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 6118833797F for ; Wed, 2 Sep 2009 16:33:07 +1000 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id GN2ka2XUFeMFX8ay for ; Wed, 02 Sep 2009 16:33:07 +1000 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 9D100A50123 for ; Wed, 2 Sep 2009 16:32:06 +1000 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 536F84FD85 for ; Wed, 2 Sep 2009 16:33:07 +1000 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at gatekeeper.yarra.acx Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MS29U39vbyz5 for ; Wed, 2 Sep 2009 16:33:03 +1000 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 4CF1D4FD84 for ; Wed, 2 Sep 2009 16:33:03 +1000 (EST) Date: Wed, 2 Sep 2009 16:32:59 +1000 (EST) From: Nathan Scott To: pcp Message-ID: <2025615859.212021251873179372.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcp-gui updates (1.4.5) Subject: pcp-gui updates (1.4.5) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1251873215 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.7881 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Changes committed to git://oss.sgi.com/pcp/pcp-gui.git VERSION | 2 +- aclocal.m4 | 10 +++------- debian/changelog | 7 +++++++ doc/CHANGES | 4 ++++ m4/package_utilies.m4 | 8 ++------ src/libqmc/GNUmakefile | 4 ++-- src/libqwt/GNUmakefile | 4 ++-- 7 files changed, 21 insertions(+), 18 deletions(-) commit 87c2940a2d7f6a892c29fc9f90cbb1bbc9f64c42 Author: Nathan Scott Date: Wed Sep 2 16:19:38 2009 +1000 Bump version number to 1.4.5 in stable branch. commit 96874e046677d3abe80016ff9c34621d1744bb20 Author: Nathan Scott Date: Wed Sep 2 16:03:20 2009 +1000 Workaround another oddity in (very) recent versions of autoconf. Problem found by the Debian autobuilders, in the pcp-gui build but it affects pcp too. Latest versions of autoconf evaluate AC_PROG_LEX in the compiler check macro, and complete remove any trace of AC_PROG_LEX from its original callsite. This results in a syntax error inside our configure script, as we call it within if ... fi, which then evaluates to having no body to the if. Ugh. Fix is trivial though, since these macros do the user-env-variable expansion thing already. Resolves Debian bug #539373. commit 7a9aaa2efbd7bd2b2a1c49c23f584a39f6aea63f Author: Nathan Scott Date: Wed Sep 2 13:35:10 2009 +1000 Tighten up the SOURCES macro for libs so generated moc_* files not included. From mort@sgi.com Wed Sep 2 07:46:06 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n82CjkY0002536 for ; Wed, 2 Sep 2009 07:45:56 -0500 Received: from attica.americas.sgi.com (attica.americas.sgi.com [128.162.236.44]) by relay2.corp.sgi.com (Postfix) with ESMTP id 492EA3040BC for ; Wed, 2 Sep 2009 05:46:43 -0700 (PDT) Received: by attica.americas.sgi.com (Postfix, from userid 44682) id 5B1E0A1FAFA0; Wed, 2 Sep 2009 07:39:26 -0500 (CDT) Date: Wed, 2 Sep 2009 07:39:26 -0500 From: Martin Hicks To: Ken McDonell Cc: pcp@oss.sgi.com Subject: Re: [pcp] QA tests and pmlogreduce setting hours to "01" Message-ID: <20090902123926.GH16972@alcatraz.americas.sgi.com> References: <20090901163152.GC16972@alcatraz.americas.sgi.com> <1251862613.16149.1483.camel@bozo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1251862613.16149.1483.camel@bozo> User-Agent: Mutt/1.5.17 (2007-11-01) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Wed, Sep 02, 2009 at 01:36:53PM +1000, Ken McDonell wrote: > On Tue, 2009-09-01 at 11:31 -0500, Martin Hicks wrote: > > I've started playing with the QA tests, running them against PCP-2.9.0 > > So far I've managed to get through nearly the first 150 tests, fixing a > > few things along the way. > > Martin, if you could send me your "fixes" I can compare them with the > changes I've been making for dynamic PMNS stuff, just to head off any > possible merge conflicts down the track. I've got a few more changesets in my QA tree on oss.sgi.com that I've been fixing as I work my way through the QA tests. git://oss.sgi.com/mort/pcpqa.git I only made it to about test 180, and I have to run away to deal with some other fire... mh From mort@sgi.com Wed Sep 2 08:46:06 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n82DjkgR006059 for ; Wed, 2 Sep 2009 08:45:56 -0500 Received: from attica.americas.sgi.com (attica.americas.sgi.com [128.162.236.44]) by relay2.corp.sgi.com (Postfix) with ESMTP id B49F430406B for ; Wed, 2 Sep 2009 06:46:43 -0700 (PDT) Received: by attica.americas.sgi.com (Postfix, from userid 44682) id 47F20A1FAFA0; Wed, 2 Sep 2009 08:41:04 -0500 (CDT) Date: Wed, 2 Sep 2009 08:41:04 -0500 From: Martin Hicks To: pcp@oss.sgi.com Cc: Ken McDonell Subject: mort's pcpqa updates Message-ID: <20090902134104.GJ16972@alcatraz.americas.sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.17 (2007-11-01) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Here are the fixes that I found while looking through QA in the last few days. Ken, I rolled your fixes for 144 and applied the same fix for 150. git://oss.sgi.com/mort/pcpqa.git commit 87ccf9a28b960d977158cf5d705e4c08d19c696f Author: Martin Hicks Date: Wed Sep 2 09:32:24 2009 -0400 150: Use '-z' in pmval Use the archive-local timezone for test 144. Unfortunately, there is a 1hr difference between the archive and the current .out file. commit f052c6c2f529eaf1862a2e84a0646417c659e1ff Author: Martin Hicks Date: Wed Sep 2 09:31:05 2009 -0400 144: Use '-z' in pmval Use the archive-local timezone for test 144. Unfortunately, there is a 1hr difference between the archive and the current .out file. commit 711065f99e7e632be060ad549071a4061a1f0aae Author: Martin Hicks Date: Tue Sep 1 08:37:58 2009 -0400 128: A fix when there are NFSv4 client/server running The test doesn't know how to deal with nfsv4, and ends up with duplicate statistics because the $prefix remains the same while processing the nfsv4 output from nfsstat. Skip nfsv4 stats. Also, fix join complaining about unsorted file 1. commit 6e565e9a53c6ac8ab00df75a5b3a4596593319fc Author: Martin Hicks Date: Tue Sep 1 08:36:58 2009 -0400 113: use sudo on the df command My Debian machine, with encrypted LVM, gives permission denied when using the df commands. Use sudo. commit 1614f78e5b87ddcf9dc1cc708fad77c64de0dba1 Author: Martin Hicks Date: Tue Sep 1 08:34:25 2009 -0400 083: more strict wait for pmlogger start There was a "sh -c" process that was used in the startup of pmlogger. This was causing two processes to be found and included in logger_pid. Just limit the search more strictly by removing the sh -c process. commit 24fb70f09f77e41bedc17e8c4ddb617c9cf29787 Author: pcpqa Date: Thu Aug 27 11:34:13 2009 -0400 Fix test 003 for machines without HIGHMEM Highmem memory stats are lacking on x86_64 workstations From nscott@aconex.com Wed Sep 2 20:03:16 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_65 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n8312tuW057940 for ; Wed, 2 Sep 2009 20:03:06 -0500 X-ASG-Debug-ID: 1251939810-06a5003d0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 1644015B8883 for ; Wed, 2 Sep 2009 18:03:31 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id 2pZ9Uhg7v5Hhp6BL for ; Wed, 02 Sep 2009 18:03:31 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 3ED8134080D; Thu, 3 Sep 2009 11:03:13 +1000 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id rVEEYMRGw8D6VyKl; Thu, 03 Sep 2009 11:03:13 +1000 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 0579BA50299; Thu, 3 Sep 2009 11:02:12 +1000 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 1CAD2C7B07; Thu, 3 Sep 2009 11:03:13 +1000 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at gatekeeper.yarra.acx Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3S2PAb0ik+o5; Thu, 3 Sep 2009 11:03:08 +1000 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 5EDA6C7AF3; Thu, 3 Sep 2009 11:03:08 +1000 (EST) Date: Thu, 3 Sep 2009 11:03:08 +1000 (EST) From: Nathan Scott To: Martin Hicks , kenj Cc: pcp@oss.sgi.com Message-ID: <256314019.229001251939788289.JavaMail.root@mail-au.aconex.com> In-Reply-To: <931067231.228961251939716234.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: Re: [pcp] QA: pmval showing one less sample Subject: Re: [pcp] QA: pmval showing one less sample MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_15705_1792033942.1251939788288" X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1251939832 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.7950 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ------=_Part_15705_1792033942.1251939788288 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit ----- "Martin Hicks" wrote: > On Wed, Sep 02, 2009 at 09:53:51AM +1000, Nathan Scott wrote: > > ----- "Martin Hicks" wrote: > > > Tests 166 and 176 are showing one less sample than the expected > > > output with pcp 2.9.0. Not sure what's going on here. > > > > > > Is this just a bug that's been fixed? If I pmdumptext the original > > > archive I see 54 samples, but the first one is a "?". Maybe pmval > > > is now reporting how many intervals (samples-1) ? > > > > I can't think of any changes that could have caused this, don't think > > there have been any pmval changes, nor libpcp fetch related changes. > > When was the last successful run of this test for you? I'll try to > > get to doing a full QA run today/tomorrow, see if it happens here too. > > This is the first time I've tried to use the QA stuff. I'll see if the > older PCP that we're still shipping has the bug. (2.7.8 right around > the 2.8.0 release time. March-ish) Hoo-boy, this was a good one. AFAICT, this is a day-1 pmval bug. Ken & Martin, could you guys review the attached patch carefully? What I've found, is the problem either exists/doesn't exist depending on several factors: - running on a 32 bit machine, Debian unstable, the problem never occurs no matter how pmval is built. - running on a 64 bit machine, Debian unstable, the problem only happens with the packaged binaries. The key factor appears to be the introduction of -O2, which looks like it reliably changes certain values on the stack, that would otherwise be zero (used uninitialised, in either case). There's two problems here, I believe: - in pmval.c the getargs() call initialises the value of "smpls" (number of samples to take) based on cntxt->desc.sem. However, at that point, we have not established a context yet, and so that field is uninitialised. - this test doesn't match the comment above it, and doesn't make sense: /* counters require 2 samples to produce reported sample */ if (*smpls > 0 && cntxt->desc.sem != PM_SEM_COUNTER) that would seem to me that it should be "cntxt->desc.sem == PM_SEM_COUNTER" should it not? Anyway, attached patch fixes test case 125, which is a simple test case for this. Some of the other QA tests now fail, like 261 - the sample.drift bit fails though, which is an instantaneous metric, showing we used to go down the wrong pmval code path in that case. cheers. -- Nathan ------=_Part_15705_1792033942.1251939788288 Content-Type: application/octet-stream; name=patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=patch diff --git a/src/pmval/pmval.c b/src/pmval/pmval.c index 61bb835..06946bd 100644 --- a/src/pmval/pmval.c +++ b/src/pmval/pmval.c @@ -1119,6 +1119,9 @@ getargs(int argc, /* in - command line argument count */ exit(EXIT_FAILURE); } + initapi(cntxt); + initinsts(cntxt); + if (!(gui || port != -1) && *smpls == ALL_SAMPLES && last.tv_sec != INT_MAX && @@ -1129,7 +1132,7 @@ getargs(int argc, /* in - command line argument count */ /* if end is before start, no samples thanks */ if (*smpls < 0) *smpls = 0; /* counters require 2 samples to produce reported sample */ - if (*smpls > 0 && cntxt->desc.sem != PM_SEM_COUNTER) + if (*smpls > 0 && cntxt->desc.sem == PM_SEM_COUNTER) (*smpls)++; #ifdef PCP_DEBUG if (pmDebug & DBG_TRACE_APPL0) @@ -1173,8 +1176,6 @@ main(int argc, char *argv[]) getargs(argc, argv, &cntxt, &now, &delta, &smpls, &cols); forever = (smpls == ALL_SAMPLES || gui); - initapi(&cntxt); - initinsts(&cntxt); if (cols <= 0) cols = howide(cntxt.desc.type); ------=_Part_15705_1792033942.1251939788288-- From nscott@aconex.com Wed Sep 2 21:40:28 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_46 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n832e7r1062668 for ; Wed, 2 Sep 2009 21:40:18 -0500 X-ASG-Debug-ID: 1251945660-06a902e20000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id E826D15BA617 for ; Wed, 2 Sep 2009 19:41:01 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id woCGLi1ANWa6cJfA for ; Wed, 02 Sep 2009 19:41:01 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 74ADB340903 for ; Thu, 3 Sep 2009 12:40:59 +1000 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id rMDcJ8p1Pa3gtDjh for ; Thu, 03 Sep 2009 12:40:59 +1000 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 1D75CA502AC for ; Thu, 3 Sep 2009 12:39:58 +1000 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 407924FD86 for ; Thu, 3 Sep 2009 12:40:59 +1000 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at gatekeeper.yarra.acx Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kZ+TvNBwct4x for ; Thu, 3 Sep 2009 12:40:55 +1000 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 36C714FD84 for ; Thu, 3 Sep 2009 12:40:55 +1000 (EST) Date: Thu, 3 Sep 2009 12:40:55 +1000 (EST) From: Nathan Scott To: pcp@oss.sgi.com Message-ID: <809571258.233741251945655129.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcpqa updates Subject: pcpqa updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1251945661 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.7956 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Changes committed to git://oss.sgi.com/pcp/pcpqa.git 574.out.linux | 1 + 628 | 1 + 2 files changed, 2 insertions(+) commit 743b7c7607fe6da25ac69a35725a81d4324670e7 Author: Nathan Scott Date: Thu Sep 3 12:37:34 2009 +1000 Make test 628 copy perl pmdasimple code as well, else Install fails. commit e446c875ef46fa30b28995ede0201e5c99f21bc2 Author: Nathan Scott Date: Thu Sep 3 12:35:45 2009 +1000 Make test 574 cater for relatively recently added pmcd.client metrics. From nscott@aconex.com Wed Sep 2 21:42:33 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_37, J_CHICKENPOX_65,LOCAL_GNU_PATCH autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n832gDuc062756 for ; Wed, 2 Sep 2009 21:42:23 -0500 X-ASG-Debug-ID: 1251945781-3ad201320000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 21E9815BA624 for ; Wed, 2 Sep 2009 19:43:01 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id 9lm4IQm6xVkAlcDY for ; Wed, 02 Sep 2009 19:43:01 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id E3B24345D96; Thu, 3 Sep 2009 12:42:59 +1000 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id fFMCgF8AGqDBCC0c; Thu, 03 Sep 2009 12:42:59 +1000 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id AAD3FA5028C; Thu, 3 Sep 2009 12:41:58 +1000 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id BE7AF4FD86; Thu, 3 Sep 2009 12:42:59 +1000 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at gatekeeper.yarra.acx Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N8SzOGIou0dg; Thu, 3 Sep 2009 12:42:55 +1000 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id EE1354FD82; Thu, 3 Sep 2009 12:42:54 +1000 (EST) Date: Thu, 3 Sep 2009 12:42:54 +1000 (EST) From: Nathan Scott To: Martin Hicks , kenj Cc: pcp@oss.sgi.com Message-ID: <930421966.233821251945774896.JavaMail.root@mail-au.aconex.com> In-Reply-To: <615364748.233801251945770898.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: Re: [pcp] QA: pmval showing one less sample Subject: Re: [pcp] QA: pmval showing one less sample MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_16139_738200955.1251945774895" X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1251945786 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.02 X-Barracuda-Spam-Status: No, SCORE=-1.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M, BSF_RULE_7582B X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.7956 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M 0.50 BSF_RULE_7582B Custom Rule 7582B X-Virus-Status: Clean ------=_Part_16139_738200955.1251945774895 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit ----- "Nathan Scott" wrote: > > Anyway, attached patch fixes test case 125, which is a simple test > case for this. Some of the other QA tests now fail, like 261 - the > sample.drift bit fails though, which is an instantaneous metric, > showing we used to go down the wrong pmval code path in that case. Attached patch addresses most of the fallout so far... some remain and are less clearcut though, needing even more careful checking. cheers. -- Nathan ------=_Part_16139_738200955.1251945774895 Content-Type: text/x-patch; name=qafallout Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=qafallout diff --git a/080.out b/080.out index d728c20..f86fc1f 100644 --- a/080.out +++ b/080.out @@ -66,7 +66,7 @@ start: Wed Feb 28 16:49:20 2001 end: Wed Feb 28 16:49:40 2001 semantics: instantaneous value units: none -samples: 21 +samples: 20 interval: 1.00 sec 1 minute 5 minute 15 minute @@ -90,7 +90,6 @@ interval: 1.00 sec 16:49:37.000 5.176E-02 ? 1.953E-03 16:49:38.000 5.176E-02 ? 1.953E-03 16:49:39.000 5.176E-02 ? 1.953E-03 -16:49:40.000 4.785E-02 ? 9.766E-04 -- -z -S @16:49:20 -T 20sec -a ... -- Note: timezone set to local timezone of host "omen" from archive @@ -102,7 +101,7 @@ start: Wed Feb 28 16:49:20 2001 end: Wed Feb 28 16:49:40 2001 semantics: instantaneous value units: none -samples: 21 +samples: 20 interval: 1.00 sec 1 minute 5 minute 15 minute @@ -126,7 +125,6 @@ interval: 1.00 sec 16:49:37.000 5.176E-02 ? 1.953E-03 16:49:38.000 5.176E-02 ? 1.953E-03 16:49:39.000 5.176E-02 ? 1.953E-03 -16:49:40.000 4.785E-02 ? 9.766E-04 -- -z -S +15s -T -10s -a ... -- Note: timezone set to local timezone of host "omen" from archive @@ -138,7 +136,7 @@ start: Wed Feb 28 16:49:29 2001 end: Wed Feb 28 16:49:54 2001 semantics: instantaneous value units: none -samples: 26 +samples: 25 interval: 1.00 sec 1 minute 5 minute 15 minute @@ -167,7 +165,6 @@ interval: 1.00 sec 16:49:51.035 3.809E-02 ? 0.0 16:49:52.035 3.809E-02 ? 0.0 16:49:53.035 3.809E-02 ? 0.0 -16:49:54.035 3.809E-02 ? 0.0 -- -Z UTC -S +15s -T -10s -a ... -- Note: timezone set to "TZ=UTC" @@ -179,7 +176,7 @@ start: Wed Feb 28 05:49:29 2001 end: Wed Feb 28 05:49:54 2001 semantics: instantaneous value units: none -samples: 26 +samples: 25 interval: 1.00 sec 1 minute 5 minute 15 minute @@ -208,7 +205,6 @@ interval: 1.00 sec 05:49:51.035 3.809E-02 ? 0.0 05:49:52.035 3.809E-02 ? 0.0 05:49:53.035 3.809E-02 ? 0.0 -05:49:54.035 3.809E-02 ? 0.0 -- -z -S @16:49:20 -T 10 arch/... -- Note: timezone set to local timezone of host "omen" from archive @@ -220,7 +216,7 @@ start: Wed Feb 28 16:49:20 2001 end: Wed Feb 28 16:49:30 2001 semantics: instantaneous value units: none -samples: 11 +samples: 10 interval: 1.00 sec 1 minute 5 minute 15 minute @@ -234,7 +230,6 @@ interval: 1.00 sec 16:49:27.000 5.957E-02 ? 3.906E-03 16:49:28.000 5.957E-02 ? 3.906E-03 16:49:29.000 5.957E-02 ? 3.906E-03 -16:49:30.000 5.566E-02 ? 2.930E-03 -- -z -S @16:49:20 -T 10 arch/...[...] -- Note: timezone set to local timezone of host "omen" from archive @@ -246,7 +241,7 @@ start: Wed Feb 28 16:49:20 2001 end: Wed Feb 28 16:49:30 2001 semantics: instantaneous value units: none -samples: 11 +samples: 10 interval: 1.00 sec 1 minute 15 minute @@ -260,7 +255,6 @@ interval: 1.00 sec 16:49:27.000 5.957E-02 3.906E-03 16:49:28.000 5.957E-02 3.906E-03 16:49:29.000 5.957E-02 3.906E-03 -16:49:30.000 5.566E-02 2.930E-03 -- -z -S 15 -A 1 -T10 -a ... -- Note: timezone set to local timezone of host "omen" from archive @@ -272,7 +266,7 @@ start: Wed Feb 28 16:49:30 2001 end: Wed Feb 28 16:49:40 2001 semantics: instantaneous value units: none -samples: 11 +samples: 10 interval: 1.00 sec 1 minute 5 minute 15 minute @@ -286,4 +280,3 @@ interval: 1.00 sec 16:49:37.000 5.176E-02 ? 1.953E-03 16:49:38.000 5.176E-02 ? 1.953E-03 16:49:39.000 5.176E-02 ? 1.953E-03 -16:49:40.000 4.785E-02 ? 9.766E-04 diff --git a/088.out b/088.out index a45b672..9b1d13b 100755 --- a/088.out +++ b/088.out @@ -11,14 +11,13 @@ semantics: instantaneous value units: none bin-100 bin-500 bin-700 bin-900 -TIMESTAMP 100 ? ? 900 TIMESTAMP 100 500 ? ? TIMESTAMP 100 500 ? 900 TIMESTAMP No values available archive: src-oss/bar interval: 0.50 sec metric: sampledso.bin -samples: 11 +samples: 10 semantics: instantaneous value units: none @@ -33,14 +32,13 @@ semantics: instantaneous value units: none bin-100 bin-500 bin-700 bin-900 -TIMESTAMP 100 ? ? 900 TIMESTAMP 100 500 ? ? TIMESTAMP 100 500 ? 900 TIMESTAMP No values available archive: src-oss/mv-bar interval: 0.50 sec metric: sampledso.bin -samples: 11 +samples: 10 semantics: instantaneous value units: none @@ -55,14 +53,13 @@ semantics: instantaneous value units: none bin-100 bin-500 bin-700 bin-900 -TIMESTAMP 100 ? ? 900 TIMESTAMP 100 500 ? ? TIMESTAMP 100 500 ? 900 TIMESTAMP No values available archive: src-oss/noti-bar interval: 0.50 sec metric: sampledso.bin -samples: 11 +samples: 10 semantics: instantaneous value units: none Note: timezone set to local timezone of host "rattle" from archive diff --git a/166.out b/166.out index af063e7..b0d49ac 100644 --- a/166.out +++ b/166.out @@ -15,7 +15,7 @@ start: Wed Jan 19 21:57:00 2005 end: Wed Jan 19 22:10:26 2005 semantics: cumulative counter (converting to rate) units: millisec (converting to time utilization) -samples: 54 +samples: 53 interval: 15.00 sec 21:57:15.000 1.000 21:57:30.000 1.000 @@ -83,7 +83,7 @@ start: Wed Jan 19 21:57:00 2005 end: Wed Jan 19 22:10:26 2005 semantics: cumulative counter units: millisec -samples: 54 +samples: 53 interval: 15.00 sec 21:57:00.000 3394854 21:57:15.000 3409854 @@ -138,7 +138,6 @@ interval: 15.00 sec 22:09:30.000 4144854 22:09:45.000 4159854 22:10:00.000 4174854 -22:10:15.000 4189854 --- pmval -U using reduced archive --- Note: timezone set to local timezone of host "kenj-pc" from archive @@ -207,7 +206,7 @@ start: Wed Jan 19 21:57:00 2005 end: Wed Jan 19 22:10:00 2005 semantics: cumulative counter (converting to rate) units: millisec (converting to time utilization) -samples: 53 +samples: 52 interval: 15.00 sec 21:57:15.000 1.000 21:57:30.000 1.000 @@ -274,7 +273,7 @@ start: Wed Jan 19 21:57:00 2005 end: Wed Jan 19 22:10:00 2005 semantics: cumulative counter units: millisec -samples: 53 +samples: 52 interval: 15.00 sec 21:57:00.000 3394854 21:57:15.000 3409854 @@ -328,7 +327,6 @@ interval: 15.00 sec 22:09:15.000 4129854 22:09:30.000 4144854 22:09:45.000 4159854 -22:10:00.000 4174854 === sample.drift === --- pmval using input archive --- @@ -341,7 +339,7 @@ start: Wed Jan 19 21:57:00 2005 end: Wed Jan 19 22:10:26 2005 semantics: instantaneous value units: none -samples: 54 +samples: 53 interval: 15.00 sec 21:57:00.000 479 21:57:15.000 399 @@ -396,7 +394,6 @@ interval: 15.00 sec 22:09:30.000 326 22:09:45.000 311 22:10:00.000 314 -22:10:15.000 284 --- pmval -U using reduced archive --- Note: timezone set to local timezone of host "kenj-pc" from archive @@ -437,7 +434,7 @@ start: Wed Jan 19 21:57:00 2005 end: Wed Jan 19 22:10:00 2005 semantics: instantaneous value units: none -samples: 53 +samples: 52 interval: 15.00 sec 21:57:00.000 479 21:57:15.000 479 @@ -491,4 +488,3 @@ interval: 15.00 sec 22:09:15.000 360 22:09:30.000 360 22:09:45.000 360 -22:10:00.000 314 diff --git a/177 b/177 index d8292d7..e7b604e 100755 --- a/177 +++ b/177 @@ -20,7 +20,7 @@ trap "rm -f $tmp.*; exit" 0 1 2 3 15 _filter() { $PCP_AWK_PROG ' -BEGIN { min["0.1"] = 58; max["0.1"] = 62 +BEGIN { min["0.1"] = 57; max["0.1"] = 61 min["0.2"] = 28; max["0.2"] = 32 min["0.4"] = 13; max["0.4"] = 17 xx = "'$1'" diff --git a/180.out.1 b/180.out.1 index 3e7da08..c0f2312 100755 --- a/180.out.1 +++ b/180.out.1 @@ -9,7 +9,7 @@ start: Tue Nov 21 16:02:31 1995 end: Tue Nov 21 16:12:57 1995 semantics: cumulative counter (converting to rate) units: millisec (converting to time utilization) -samples: 32 +samples: 31 interval: 20.00 sec 16:02:31.554 No values available full label for instance[0]: 327685 (NULL) NETWORK HANDLER @@ -98,7 +98,7 @@ start: Tue Nov 21 16:02:31 1995 end: Tue Nov 21 16:12:57 1995 semantics: cumulative counter (converting to rate) units: millisec (converting to time utilization) -samples: 32 +samples: 31 interval: 20.00 sec 16:02:31.554 No values available diff --git a/261.out b/261.out index b5d7f16..2f736db 100644 --- a/261.out +++ b/261.out @@ -269,7 +269,7 @@ sample.drift: *************** *** 9,15 **** units: none - samples: 9 + samples: 8 interval: 30.00 sec ! 10:51:07.407 26 10:51:37.407 74 @@ -277,7 +277,7 @@ sample.drift: 10:52:37.407 75 --- 9,15 ---- units: none - samples: 9 + samples: 8 interval: 30.00 sec ! 10:51:07.407 74 10:51:37.407 74 diff --git a/288.out b/288.out index fc0e69e..b080e07 100644 --- a/288.out +++ b/288.out @@ -9,7 +9,7 @@ start: Thu Nov 25 10:10:06 2004 end: Thu Nov 25 10:58:06 2004 semantics: discrete instantaneous value units: Kbyte -samples: 25 +samples: 24 interval: 120.00 sec 10:10:06.248 No values available 10:12:06.248 514216 @@ -35,7 +35,6 @@ interval: 120.00 sec 10:52:06.248 514216 10:54:06.248 514216 10:56:06.248 514216 -10:58:06.248 514216 reported samples: total log reads: forward 51 backwards 1 @@ -49,7 +48,7 @@ start: Thu Nov 25 10:11:00 2004 end: Thu Nov 25 10:58:06 2004 semantics: discrete instantaneous value units: Kbyte -samples: 24 +samples: 23 interval: 120.00 sec 10:11:00.000 514216 10:13:00.000 514216 @@ -74,7 +73,6 @@ interval: 120.00 sec 10:51:00.000 514216 10:53:00.000 514216 10:55:00.000 514216 -10:57:00.000 514216 reported samples: total log reads: forward 49 backwards 1 @@ -88,7 +86,7 @@ start: Thu Nov 25 10:10:06 2004 end: Thu Nov 25 10:58:06 2004 semantics: instantaneous value units: Kbyte -samples: 25 +samples: 24 interval: 120.00 sec 10:10:06.248 No values available 10:12:06.248 1672 @@ -114,10 +112,9 @@ interval: 120.00 sec 10:52:06.248 146312 10:54:06.248 146248 10:56:06.248 145792 -10:58:06.248 146056 reported samples: -total log reads: forward 51 backwards 1 +total log reads: forward 49 backwards 1 === metric mem.freemem alignment -A 1min === @@ -128,7 +125,7 @@ start: Thu Nov 25 10:11:00 2004 end: Thu Nov 25 10:58:06 2004 semantics: instantaneous value units: Kbyte -samples: 24 +samples: 23 interval: 120.00 sec 10:11:00.000 No values available 10:13:00.000 148808 @@ -153,7 +150,6 @@ interval: 120.00 sec 10:51:00.000 146248 10:53:00.000 146248 10:55:00.000 146248 -10:57:00.000 146056 reported samples: -total log reads: forward 47 backwards 3 +total log reads: forward 45 backwards 3 diff --git a/313.62_6512plus b/313.62_6512plus index b4c0ab0..ed34fe7 100644 --- a/313.62_6512plus +++ b/313.62_6512plus @@ -10,7 +10,7 @@ start: Tue Aug 5 07:45:41 1997 end: Tue Aug 5 07:45:59 1997 semantics: cumulative counter (converting to rate) units: sec (converting to time utilization) -samples: 19 +samples: 18 interval: 1.00 sec 07:45:41.422 No values available 07:45:42.422 No values available @@ -44,7 +44,7 @@ start: Tue Aug 5 07:45:41 1997 end: Tue Aug 5 07:45:59 1997 semantics: cumulative counter (converting to rate) units: millisec (converting to time utilization) -samples: 19 +samples: 18 interval: 1.00 sec 07:45:41.422 No values available 07:45:42.422 No values available @@ -66,8 +66,6 @@ interval: 1.00 sec 07:45:58.422 No values available 07:45:59.422 No values available -pmval: pmFetch: End of PCP archive log - === delta=1sec instantaneous in 1st and 3rd sections === Note: timezone set to local timezone of host "gonzo" from archive @@ -78,7 +76,7 @@ start: Tue Aug 5 07:45:41 1997 end: Tue Aug 5 07:45:59 1997 semantics: instantaneous value units: none -samples: 19 +samples: 18 interval: 1.00 sec 07:45:41.422 No values available 07:45:42.422 184 @@ -98,7 +96,6 @@ interval: 1.00 sec 07:45:56.422 No values available 07:45:57.422 70 07:45:58.422 50 -07:45:59.422 40 === delta=1sec discrete and logged once in the 1st and 3rd sections === Note: timezone set to local timezone of host "gonzo" from archive @@ -110,7 +107,7 @@ start: Tue Aug 5 07:45:41 1997 end: Tue Aug 5 07:45:59 1997 semantics: discrete instantaneous value units: none -samples: 19 +samples: 18 interval: 1.00 sec 07:45:41.422 No values available 07:45:42.422 1 @@ -130,7 +127,6 @@ interval: 1.00 sec 07:45:56.422 1 07:45:57.422 1 07:45:58.422 1 -07:45:59.422 1 === delta=1sec counter and indom all over the place === lo0 ec0 ec2 section @@ -146,7 +142,7 @@ start: Tue Aug 5 07:45:41 1997 end: Tue Aug 5 07:45:59 1997 semantics: cumulative counter (converting to rate) units: count (converting to count / sec) -samples: 19 +samples: 18 interval: 1.00 sec 07:45:41.422 No values available @@ -188,7 +184,7 @@ start: Tue Aug 5 07:45:41 1997 end: Tue Aug 5 07:45:59 1997 semantics: instantaneous value units: none -samples: 19 +samples: 18 interval: 1.00 sec 07:45:41.422 No values available @@ -214,7 +210,6 @@ interval: 1.00 sec bin-100 bin-200 bin-300 bin-400 bin-500 07:45:57.422 ? 200 300 400 500 07:45:58.422 ? 200 300 400 500 -07:45:59.422 ? 200 300 400 500 === delta=1sec discrete logged once, different indom in each section === Note: timezone set to local timezone of host "gonzo" from archive @@ -226,7 +221,7 @@ start: Tue Aug 5 07:45:41 1997 end: Tue Aug 5 07:45:59 1997 semantics: discrete instantaneous value units: none -samples: 19 +samples: 18 interval: 1.00 sec 1318 1342 1368 @@ -252,7 +247,6 @@ interval: 1.00 sec 07:45:56.422 ? ? 4331 07:45:57.422 ? ? 4331 07:45:58.422 ? ? 4331 -07:45:59.422 ? ? 4331 === delta=0.5sec counter in each non-preamble result in all 3 sections === Note: timezone set to local timezone of host "gonzo" from archive @@ -264,7 +258,7 @@ start: Tue Aug 5 07:45:41 1997 end: Tue Aug 5 07:45:59 1997 semantics: cumulative counter (converting to rate) units: sec (converting to time utilization) -samples: 37 +samples: 36 interval: 0.50 sec 07:45:41.422 No values available 07:45:41.922 No values available @@ -316,7 +310,7 @@ start: Tue Aug 5 07:45:41 1997 end: Tue Aug 5 07:45:59 1997 semantics: cumulative counter (converting to rate) units: millisec (converting to time utilization) -samples: 37 +samples: 36 interval: 0.50 sec 07:45:41.422 No values available 07:45:41.922 No values available @@ -356,8 +350,6 @@ interval: 0.50 sec 07:45:58.922 No values available 07:45:59.422 No values available -pmval: pmFetch: End of PCP archive log - === delta=0.5sec instantaneous in 1st and 3rd sections === Note: timezone set to local timezone of host "gonzo" from archive @@ -368,7 +360,7 @@ start: Tue Aug 5 07:45:41 1997 end: Tue Aug 5 07:45:59 1997 semantics: instantaneous value units: none -samples: 37 +samples: 36 interval: 0.50 sec 07:45:41.422 No values available 07:45:41.922 No values available @@ -406,7 +398,6 @@ interval: 0.50 sec 07:45:57.922 50 07:45:58.422 50 07:45:58.922 40 -07:45:59.422 40 === delta=0.5sec discrete and logged once in the 1st and 3rd sections === Note: timezone set to local timezone of host "gonzo" from archive @@ -418,7 +409,7 @@ start: Tue Aug 5 07:45:41 1997 end: Tue Aug 5 07:45:59 1997 semantics: discrete instantaneous value units: none -samples: 37 +samples: 36 interval: 0.50 sec 07:45:41.422 No values available 07:45:41.922 1 @@ -456,7 +447,6 @@ interval: 0.50 sec 07:45:57.922 1 07:45:58.422 1 07:45:58.922 1 -07:45:59.422 1 === delta=0.5sec counter and indom all over the place === lo0 ec0 ec2 section @@ -472,7 +462,7 @@ start: Tue Aug 5 07:45:41 1997 end: Tue Aug 5 07:45:59 1997 semantics: cumulative counter (converting to rate) units: count (converting to count / sec) -samples: 37 +samples: 36 interval: 0.50 sec 07:45:41.422 No values available 07:45:41.922 No values available @@ -532,7 +522,7 @@ start: Tue Aug 5 07:45:41 1997 end: Tue Aug 5 07:45:59 1997 semantics: instantaneous value units: none -samples: 37 +samples: 36 interval: 0.50 sec 07:45:41.422 No values available 07:45:41.922 No values available @@ -576,7 +566,6 @@ interval: 0.50 sec 07:45:57.922 ? 200 300 400 500 07:45:58.422 ? 200 300 400 500 07:45:58.922 ? 200 300 400 500 -07:45:59.422 ? 200 300 400 500 === delta=0.5sec discrete logged once, different indom in each section === Note: timezone set to local timezone of host "gonzo" from archive @@ -588,7 +577,7 @@ start: Tue Aug 5 07:45:41 1997 end: Tue Aug 5 07:45:59 1997 semantics: discrete instantaneous value units: none -samples: 37 +samples: 36 interval: 0.50 sec 1318 1342 1368 @@ -632,7 +621,6 @@ interval: 0.50 sec 07:45:57.922 ? ? 4331 07:45:58.422 ? ? 4331 07:45:58.922 ? ? 4331 -07:45:59.422 ? ? 4331 === the whole shooting match === Note: timezone set to local timezone of host "gonzo" from archive diff --git a/634.out b/634.out index f0d5da4..5a2a8a4 100755 --- a/634.out +++ b/634.out @@ -9,11 +9,10 @@ start: Wed May 30 03:54:49 2001 end: Wed May 30 03:55:03 2001 semantics: discrete instantaneous value units: none -samples: 3 +samples: 2 interval: 5.00 sec 03:54:49.319 No values available 03:54:54.319 2 -03:54:59.319 2 GMT via -Z ... Note: timezone set to "TZ=GMT" @@ -25,11 +24,10 @@ start: Wed May 30 02:54:49 2001 end: Wed May 30 02:55:03 2001 semantics: discrete instantaneous value units: none -samples: 3 +samples: 2 interval: 5.00 sec 02:54:49.319 No values available 02:54:54.319 2 -02:54:59.319 2 GMT via default local timezone ... @@ -40,11 +38,10 @@ start: Wed May 30 02:54:49 2001 end: Wed May 30 02:55:03 2001 semantics: discrete instantaneous value units: none -samples: 3 +samples: 2 interval: 5.00 sec 02:54:49.319 No values available 02:54:54.319 2 -02:54:59.319 2 Default timezone ... should be different to -z ... Different, as expected ------=_Part_16139_738200955.1251945774895-- From kenj@internode.on.net Fri Sep 4 02:54:26 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FRT_LEVITRA, J_CHICKENPOX_15,J_CHICKENPOX_43,J_CHICKENPOX_65,J_CHICKENPOX_73, J_CHICKENPOX_74 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n847s6pL186091 for ; Fri, 4 Sep 2009 02:54:16 -0500 X-ASG-Debug-ID: 1252050890-144001e90000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 1FA471A4D3A5 for ; Fri, 4 Sep 2009 00:54:50 -0700 (PDT) Received: from mail.internode.on.net (bld-mail15.adl6.internode.on.net [150.101.137.100]) by cuda.sgi.com with ESMTP id ja4QelvgaCQBopP9 for ; Fri, 04 Sep 2009 00:54:50 -0700 (PDT) Received: from [192.168.1.100] (unverified [118.208.169.2]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 4725047-1927428 for multiple; Fri, 04 Sep 2009 17:24:48 +0930 (CST) X-ASG-Orig-Subj: Re: [pcp] QA: pmval showing one less sample Subject: Re: [pcp] QA: pmval showing one less sample From: Ken McDonell Reply-To: kenj@internode.on.net To: Nathan Scott Cc: Martin Hicks , pcp@oss.sgi.com In-Reply-To: <256314019.229001251939788289.JavaMail.root@mail-au.aconex.com> References: <256314019.229001251939788289.JavaMail.root@mail-au.aconex.com> Content-Type: multipart/mixed; boundary="=-MnC4JexGmSvZal1eFzYa" Date: Fri, 04 Sep 2009 17:54:40 +1000 Message-Id: <1252050880.27743.184.camel@bozo> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 X-Barracuda-Connect: bld-mail15.adl6.internode.on.net[150.101.137.100] X-Barracuda-Start-Time: 1252050900 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.28 X-Barracuda-Spam-Status: No, SCORE=-1.28 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=FRT_LEVITRA X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.8065 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.74 FRT_LEVITRA BODY: ReplaceTags: Levitra X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean --=-MnC4JexGmSvZal1eFzYa Content-Type: text/plain Content-Transfer-Encoding: 7bit On Thu, 2009-09-03 at 11:03 +1000, Nathan Scott wrote: > ----- "Martin Hicks" wrote: > > > On Wed, Sep 02, 2009 at 09:53:51AM +1000, Nathan Scott wrote: > > > ----- "Martin Hicks" wrote: > > > > Tests 166 and 176 are showing one less sample than the expected > > > > output with pcp 2.9.0. Not sure what's going on here. > > > > > > > > Is this just a bug that's been fixed? If I pmdumptext the original > > > > archive I see 54 samples, but the first one is a "?". Maybe pmval > > > > is now reporting how many intervals (samples-1) ? > > > > > > I can't think of any changes that could have caused this, don't think > > > there have been any pmval changes, nor libpcp fetch related changes. > > > When was the last successful run of this test for you? I'll try to > > > get to doing a full QA run today/tomorrow, see if it happens here too. > > > > This is the first time I've tried to use the QA stuff. I'll see if the > > older PCP that we're still shipping has the bug. (2.7.8 right around > > the 2.8.0 release time. March-ish) > > Hoo-boy, this was a good one. AFAICT, this is a day-1 pmval bug. Ken > & Martin, could you guys review the attached patch carefully? > > What I've found, is the problem either exists/doesn't exist depending on > several factors: > - running on a 32 bit machine, Debian unstable, the problem never occurs > no matter how pmval is built. > - running on a 64 bit machine, Debian unstable, the problem only happens > with the packaged binaries. The key factor appears to be the introduction > of -O2, which looks like it reliably changes certain values on the stack, > that would otherwise be zero (used uninitialised, in either case). > > There's two problems here, I believe: > - in pmval.c the getargs() call initialises the value of "smpls" (number > of samples to take) based on cntxt->desc.sem. However, at that point, > we have not established a context yet, and so that field is uninitialised. > - this test doesn't match the comment above it, and doesn't make sense: > > /* counters require 2 samples to produce reported sample */ > if (*smpls > 0 && cntxt->desc.sem != PM_SEM_COUNTER) > > that would seem to me that it should be "cntxt->desc.sem == PM_SEM_COUNTER" > should it not? > > Anyway, attached patch fixes test case 125, which is a simple test case for > this. Some of the other QA tests now fail, like 261 - the sample.drift bit > fails though, which is an instantaneous metric, showing we used to go down > the wrong pmval code path in that case. Looking at qa/166 ... $ pmdumplog -L -z src-oss/reduce-gap Note: timezone set to local timezone of host "kenj-pc" from archive Log Label (Log Format Version 2) Performance metrics from host kenj-pc commencing Wed Jan 19 21:56:48.422 2005 ending Wed Jan 19 22:10:26.410 2005 Archive timezone: EST-11 PID for pmlogger: 28161 So archive starts at 21:56:48.422. pmval -A 1m moves this to 21:57:00.000 First reported sample would be 21:57:15 (the metric is a counter) and last sample would be 22:10:15 ... which is 13mins + 1 sample or 53 samples ... which should be the number of samples reported by pmval. So the summary (samples: 54) at the start is wrong and should be 53. Nathan's explanation is correct and a good catch. My (similar) patch is attached for comparison ... we've made mistakes in this section of the code before so I've added some verbose comments (those who know me will understand just how unnatural this feels!). I'll work through the qa issues to independently verify the changes Nathan has found ... since I expect these to be correct, Nathan would you like to commit yours to the oss pcpqa tree? --=-MnC4JexGmSvZal1eFzYa Content-Disposition: attachment; filename="pmval.patch" Content-Type: text/x-patch; name="pmval.patch"; charset="UTF-8" Content-Transfer-Encoding: 7bit diff --git a/src/pmval/pmval.c b/src/pmval/pmval.c index 61bb835..6fd1896 100644 --- a/src/pmval/pmval.c +++ b/src/pmval/pmval.c @@ -1119,6 +1119,9 @@ getargs(int argc, /* in - command line argument count */ exit(EXIT_FAILURE); } + initapi(cntxt); + initinsts(cntxt); + if (!(gui || port != -1) && *smpls == ALL_SAMPLES && last.tv_sec != INT_MAX && @@ -1126,16 +1129,43 @@ getargs(int argc, /* in - command line argument count */ *smpls = (long)((__pmtimevalToReal(&last) - __pmtimevalToReal(posn)) / __pmtimevalToReal(delta)); - /* if end is before start, no samples thanks */ - if (*smpls < 0) *smpls = 0; - /* counters require 2 samples to produce reported sample */ - if (*smpls > 0 && cntxt->desc.sem != PM_SEM_COUNTER) - (*smpls)++; + if (*smpls < 0) + /* if end is before start, no samples thanks */ + *smpls = 0; + else { + /* + * p stands for posn + * + p + p+delta + p+2*delta + p+3*delta + last + * | | | | | | + * +-----------+-----------+-----------+-- ...... ----+---+---> time + * 1 2 3 smpls + */ + if (cntxt->desc.sem != PM_SEM_COUNTER) { + /* non-counters are reported on the first sample as well */ + (*smpls)++; + } + } #ifdef PCP_DEBUG - if (pmDebug & DBG_TRACE_APPL0) - fprintf(stderr, "getargs: first=%.6f posn=%.6f last=%.6f\ngetargs: delta=%.6f samples=%ld\n", - __pmtimevalToReal(&first), __pmtimevalToReal(posn), - __pmtimevalToReal(&last), __pmtimevalToReal(delta), *smpls); + if (pmDebug & DBG_TRACE_APPL0) { + char tbfr[26]; + char *tp; + fprintf(stderr, "getargs: first=%.6f", __pmtimevalToReal(&first)); + tp = pmCtime((time_t *)&first.tv_sec, tbfr); + /* + * tp -> Ddd Mmm DD HH:MM:SS YYYY\n + * 0 4 8 1 1 2 2 2 + * 1 8 0 3 4 + */ + fprintf(stderr, "[%8.8s]\n", &tp[11]); + fprintf(stderr, "getargs: posn=%.6f", __pmtimevalToReal(posn)); + tp = pmCtime((time_t *)&posn->tv_sec, tbfr); + fprintf(stderr, "[%8.8s]\n", &tp[11]); + fprintf(stderr, "getargs: last=%.6f", __pmtimevalToReal(&last)); + tp = pmCtime((time_t *)&last.tv_sec, tbfr); + fprintf(stderr, "[%8.8s]\n", &tp[11]); + fprintf(stderr, "getargs: delta=%.6f samples=%ld\n", + __pmtimevalToReal(delta), *smpls); + } #endif } @@ -1173,8 +1203,6 @@ main(int argc, char *argv[]) getargs(argc, argv, &cntxt, &now, &delta, &smpls, &cols); forever = (smpls == ALL_SAMPLES || gui); - initapi(&cntxt); - initinsts(&cntxt); if (cols <= 0) cols = howide(cntxt.desc.type); --=-MnC4JexGmSvZal1eFzYa-- From kenj@internode.on.net Fri Sep 4 16:03:07 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_65, J_CHICKENPOX_73 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n84L2kt6240344 for ; Fri, 4 Sep 2009 16:02:57 -0500 X-ASG-Debug-ID: 1252098197-0acf01780000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 104CC15D7389 for ; Fri, 4 Sep 2009 14:03:17 -0700 (PDT) Received: from mail.internode.on.net (bld-mail19.adl2.internode.on.net [150.101.137.104]) by cuda.sgi.com with ESMTP id HMwqmmsLG7Rg0oZr for ; Fri, 04 Sep 2009 14:03:17 -0700 (PDT) Received: from [192.168.1.100] (unverified [118.208.169.2]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 4647826-1927428 for multiple; Sat, 05 Sep 2009 06:33:07 +0930 (CST) X-ASG-Orig-Subj: Re: [pcp] QA: pmval showing one less sample Subject: Re: [pcp] QA: pmval showing one less sample From: Ken McDonell Reply-To: kenj@internode.on.net To: Nathan Scott Cc: Martin Hicks , pcp@oss.sgi.com In-Reply-To: <256314019.229001251939788289.JavaMail.root@mail-au.aconex.com> References: <256314019.229001251939788289.JavaMail.root@mail-au.aconex.com> Content-Type: text/plain Date: Sat, 05 Sep 2009 07:02:59 +1000 Message-Id: <1252098179.9881.4.camel@bozo> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail19.adl2.internode.on.net[150.101.137.104] X-Barracuda-Start-Time: 1252098224 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.8115 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On closer inspection, Nathan's suggested patch is not correct. Specifically this chunk .. @@ -1129,7 +1132,7 @@ getargs(int argc, /* in - command line argument count */ /* if end is before start, no samples thanks */ if (*smpls < 0) *smpls = 0; /* counters require 2 samples to produce reported sample */ - if (*smpls > 0 && cntxt->desc.sem != PM_SEM_COUNTER) + if (*smpls > 0 && cntxt->desc.sem == PM_SEM_COUNTER) (*smpls)++; And so the QA changes are not correct either, for example qa/080.out _is_ correct and should not be changed. This is another case where the comments are misleading (I rest my case) ... the increment is needed for all cases _except_ PM_SEM_COUNTER metrics. My alternative patch is probably closer to correct. On Thu, 2009-09-03 at 11:03 +1000, Nathan Scott wrote: > ----- "Martin Hicks" wrote: > > > On Wed, Sep 02, 2009 at 09:53:51AM +1000, Nathan Scott wrote: > > > ----- "Martin Hicks" wrote: > > > > Tests 166 and 176 are showing one less sample than the expected > > > > output with pcp 2.9.0. Not sure what's going on here. > > > > > > > > Is this just a bug that's been fixed? If I pmdumptext the original > > > > archive I see 54 samples, but the first one is a "?". Maybe pmval > > > > is now reporting how many intervals (samples-1) ? > > > > > > I can't think of any changes that could have caused this, don't think > > > there have been any pmval changes, nor libpcp fetch related changes. > > > When was the last successful run of this test for you? I'll try to > > > get to doing a full QA run today/tomorrow, see if it happens here too. > > > > This is the first time I've tried to use the QA stuff. I'll see if the > > older PCP that we're still shipping has the bug. (2.7.8 right around > > the 2.8.0 release time. March-ish) > > Hoo-boy, this was a good one. AFAICT, this is a day-1 pmval bug. Ken > & Martin, could you guys review the attached patch carefully? > > What I've found, is the problem either exists/doesn't exist depending on > several factors: > - running on a 32 bit machine, Debian unstable, the problem never occurs > no matter how pmval is built. > - running on a 64 bit machine, Debian unstable, the problem only happens > with the packaged binaries. The key factor appears to be the introduction > of -O2, which looks like it reliably changes certain values on the stack, > that would otherwise be zero (used uninitialised, in either case). > > There's two problems here, I believe: > - in pmval.c the getargs() call initialises the value of "smpls" (number > of samples to take) based on cntxt->desc.sem. However, at that point, > we have not established a context yet, and so that field is uninitialised. > - this test doesn't match the comment above it, and doesn't make sense: > > /* counters require 2 samples to produce reported sample */ > if (*smpls > 0 && cntxt->desc.sem != PM_SEM_COUNTER) > > that would seem to me that it should be "cntxt->desc.sem == PM_SEM_COUNTER" > should it not? > > Anyway, attached patch fixes test case 125, which is a simple test case for > this. Some of the other QA tests now fail, like 261 - the sample.drift bit > fails though, which is an instantaneous metric, showing we used to go down > the wrong pmval code path in that case. > > cheers. > From pcp-announce-bounces@oss.sgi.com Fri Sep 4 17:07:29 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_41 autolearn=no version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n84Lxae0244637; Fri, 4 Sep 2009 16:59:36 -0500 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n84Lwmst244532 for ; Fri, 4 Sep 2009 16:58:58 -0500 X-ASG-Debug-ID: 1252101552-0ad002750000-87ZIJf X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 6A7BA1B2BFEF for ; Fri, 4 Sep 2009 14:59:12 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id XzhHjk7Nacw0nCG6 for ; Fri, 04 Sep 2009 14:59:12 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id D7C36810D44 for ; Sat, 5 Sep 2009 07:58:55 +1000 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id UNHCcn3YN5mLgUqC for ; Sat, 05 Sep 2009 07:58:55 +1000 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id A43C2A50123 for ; Sat, 5 Sep 2009 07:57:53 +1000 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id BA13C4FD82 for ; Sat, 5 Sep 2009 07:58:55 +1000 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at gatekeeper.yarra.acx Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IpP8oJXboF75 for ; Sat, 5 Sep 2009 07:58:51 +1000 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id D7339C7B45 for ; Sat, 5 Sep 2009 07:58:51 +1000 (EST) Date: Sat, 5 Sep 2009 07:58:46 +1000 (EST) From: Nathan Scott To: pcp-announce Message-ID: <1320234161.272561252101526735.JavaMail.root@mail-au.aconex.com> In-Reply-To: <1050452163.269141252046581535.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: New PCP packages released MIME-Version: 1.0 X-Originating-IP: [211.28.150.226] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - SAF3 (Mac)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1252101577 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.8119 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Subject: [pcp-announce] New PCP packages released X-BeenThere: pcp-announce@oss.sgi.com X-Mailman-Version: 2.1.11 Precedence: list List-Id: pcp announcements List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: pcp-announce-bounces@oss.sgi.com Errors-To: pcp-announce-bounces@oss.sgi.com Hi all, New versions of all the major components of PCP have been released. See the usual location described on http://oss.sgi.com/projects/pcp Thanks to everyone who contributed to this release, and especially to Petter Reinholdtsen (first patch) and Max Matveev for picking up the Solaris port (packaging, ZFS and other kernel stats). Here's the highlights of this release... pcp-2.9.1 - Fix a long-standing pmval sample count miscalculation. - Add missing runlevels and dependencies in start scripts. - Fix a segv observed in the Windows PMDA accessing SQL Server metrics. - Fix logic error causing wrong Windows version to be reported sometimes. - Add kernel.all.uptime to the Windows kernel agent. - Initial version of the (perl-based) Samba PMDA. - Fixes to pmdasimple.pl so it functions correctly on all platforms. - Add PCP::PMDA helper routines for determining native long sizes. - Extend MMV to allow teardown of MMV file, and set errno on failure. - Initial stable (1.00) version of MMV Perl interface. - Correct the metric units for several Windows per-process memory metrics. - Add network metrics to Solaris PMDA - Report ZFS statistics from Solaris PMDA - Export zpool stats from Solaris PMDA - Generate packages for Solaris - Allow user to choose her compiler (proper use of AC_PROG_CC) pcp-gui-1.4.5 - Fix problem with latest autoconf handling of AC_CONF_LEX. - Fix uninit'd variable causing spurious non-rate-conversion. - Source tarball no longer includes generated sources (resolve srpm builds). pcp-glider-0.9.1 - Upgrade to pcp-0.9.1 - Upgrade to pcp-gui-1.4.5 - Upgrade Coin3D libraries for pmview development (ongoing). Enjoy! -- Nathan _______________________________________________ pcp-announce mailing list pcp-announce@oss.sgi.com http://oss.sgi.com/mailman/listinfo/pcp-announce From kenj@internode.on.net Sun Sep 6 20:07:12 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FRT_LEVITRA, J_CHICKENPOX_15,J_CHICKENPOX_73 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n8716qqA193123 for ; Sun, 6 Sep 2009 20:07:02 -0500 X-ASG-Debug-ID: 1252285640-10eb021a0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 7AB4442EE91 for ; Sun, 6 Sep 2009 18:07:20 -0700 (PDT) Received: from mail.internode.on.net (bld-mail14.adl6.internode.on.net [150.101.137.99]) by cuda.sgi.com with ESMTP id 9qZqFnZRPqz5qcEo for ; Sun, 06 Sep 2009 18:07:20 -0700 (PDT) Received: from [192.168.1.100] (unverified [118.208.169.2]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 4823801-1927428 for multiple; Mon, 07 Sep 2009 10:37:18 +0930 (CST) X-ASG-Orig-Subj: Re: [pcp] QA: pmval showing one less sample Subject: Re: [pcp] QA: pmval showing one less sample From: Ken McDonell Reply-To: kenj@internode.on.net To: Nathan Scott Cc: Martin Hicks , pcp@oss.sgi.com In-Reply-To: <1252098179.9881.4.camel@bozo> References: <256314019.229001251939788289.JavaMail.root@mail-au.aconex.com> <1252098179.9881.4.camel@bozo> Content-Type: multipart/mixed; boundary="=-eB5mO/d9URyg2oDOtqWz" Date: Mon, 07 Sep 2009 10:41:35 +1000 Message-Id: <1252284095.4302.45.camel@bozo> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 X-Barracuda-Connect: bld-mail14.adl6.internode.on.net[150.101.137.99] X-Barracuda-Start-Time: 1252285668 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.28 X-Barracuda-Spam-Status: No, SCORE=-1.28 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=FRT_LEVITRA X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.8323 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.74 FRT_LEVITRA BODY: ReplaceTags: Levitra X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean --=-eB5mO/d9URyg2oDOtqWz Content-Type: text/plain Content-Transfer-Encoding: 7bit This whole thing is getting ugly and evolving into something between a rat hole excursion and a turd polishing exercise. Nevertheless, I now have a patch I'm comfortable with ... it is much simpler than any of the earlier variants and is attached. For those who care, it turns out that the number of _fetches_ may be known, the number of _reported_ samples cannot be precomputed correctly in all cases ... - only works for archives with -a (not -U or -h) - is known for non-counter metrics - most of the time is known for counter metrics but there are some important corner cases where this is not the case, specifically there will be one more reported sample than expected for a counter when the report starting time is not at the start of the archive and the metric has a defined value before the report starting time with no intervening mark record (interpolate mode does return a value at the first report sample in this case!). With this pmval patch, the QA fallout is nil, except for 144 that is an unrelated timezone problem. Also this patch avoids referencing the context too soon, as there is no point in inspecting the metric's semantics to try and better guess the value of smpls. As a bonus, this patch also documents pmval's -U option that has remained a secret for nearly a decade. --=-eB5mO/d9URyg2oDOtqWz Content-Disposition: attachment; filename="patch" Content-Type: text/x-patch; name="patch"; charset="UTF-8" Content-Transfer-Encoding: 7bit diff --git a/man/man1/pmval.1 b/man/man1/pmval.1 index c9e2235..2fc1ef6 100644 --- a/man/man1/pmval.1 +++ b/man/man1/pmval.1 @@ -34,6 +34,7 @@ [\f3\-s\f1 \f2samples\f1] [\f3\-T\f1 \f2endtime\f1] [\f3\-t\f1 \f2interval\f1] +[\f3\-U\f1 \f2archive\f1] [\f3\-w\f1 \f2width\f1] [\f3\-Z\f1 \f2timezone\f1] \f2metricname\f1 @@ -67,7 +68,9 @@ Unless directed to another host by the option, or to an archive by the .B \-a -option, +or +.B \-U +options, .B pmval will contact the Performance Metrics Collector Daemon (PMCD) on the local host to obtain the required information. @@ -232,6 +235,26 @@ argument follows the syntax described in and in the simplest form may be an unsigned integer (the implied units in this case are seconds). .TP +.B \-U +Performance metric values are retrieved from the Performance Co-Pilot (PCP) +archive log file identified by the base name +.IR archive , +although unlike +.B \-a +every recorded value in the archive for the selected metric +and instances is reported (so no interpolation mode, and the sample +interval (\c +.B \-t +option) is ignored. +.RS +5n +.PP +At most one of the options +.B \-a +and +.B \-U +may be specified. +.RE +.TP .B \-w Set the width of each column of output to be .I width @@ -261,6 +284,8 @@ the source of the performance metrics, as identified via either the .B \-h or .B \-a +of +.B \-U options. .PP The following symbols may occasionally appear, in place of a metric value, in diff --git a/src/pmval/pmval.c b/src/pmval/pmval.c index 61bb835..0d7707f 100644 --- a/src/pmval/pmval.c +++ b/src/pmval/pmval.c @@ -433,7 +433,7 @@ printhdr(Context *x, long smpls, struct timeval delta, struct timeval first) } putchar('\n'); - /* sample count */ + /* sample count and interval */ if (smpls == ALL_SAMPLES) printf("samples: all\n"); else printf("samples: %ld\n", smpls); if (smpls != ALL_SAMPLES && smpls > 1 && @@ -1126,16 +1126,48 @@ getargs(int argc, /* in - command line argument count */ *smpls = (long)((__pmtimevalToReal(&last) - __pmtimevalToReal(posn)) / __pmtimevalToReal(delta)); + if (*smpls < 0) /* if end is before start, no samples thanks */ - if (*smpls < 0) *smpls = 0; - /* counters require 2 samples to produce reported sample */ - if (*smpls > 0 && cntxt->desc.sem != PM_SEM_COUNTER) + *smpls = 0; + else { + /* + * p stands for posn + * + p + p+delta + p+2*delta + p+3*delta + last + * | | | | | | + * +-----------+-----------+-----------+-- ...... ----+---+---> time + * 1 2 3 smpls + * + * So we will perform smpls+1 fetches ... the number of reported + * values cannot be determined as it is usually (but not always + * thanks to interpolation mode in archives) one less for + * PM_SEM_COUNTER metrics. + * + * samples: as reported in the header output is the number + * of fetches to be attempted. + */ (*smpls)++; + } #ifdef PCP_DEBUG - if (pmDebug & DBG_TRACE_APPL0) - fprintf(stderr, "getargs: first=%.6f posn=%.6f last=%.6f\ngetargs: delta=%.6f samples=%ld\n", - __pmtimevalToReal(&first), __pmtimevalToReal(posn), - __pmtimevalToReal(&last), __pmtimevalToReal(delta), *smpls); + if (pmDebug & DBG_TRACE_APPL0) { + char tbfr[26]; + char *tp; + fprintf(stderr, "getargs: first=%.6f", __pmtimevalToReal(&first)); + tp = pmCtime((time_t *)&first.tv_sec, tbfr); + /* + * tp -> Ddd Mmm DD HH:MM:SS YYYY\n + * 0 4 8 1 1 2 2 2 + * 1 8 0 3 4 + */ + fprintf(stderr, "[%8.8s]\n", &tp[11]); + fprintf(stderr, "getargs: posn=%.6f", __pmtimevalToReal(posn)); + tp = pmCtime((time_t *)&posn->tv_sec, tbfr); + fprintf(stderr, "[%8.8s]\n", &tp[11]); + fprintf(stderr, "getargs: last=%.6f", __pmtimevalToReal(&last)); + tp = pmCtime((time_t *)&last.tv_sec, tbfr); + fprintf(stderr, "[%8.8s]\n", &tp[11]); + fprintf(stderr, "getargs: delta=%.6f samples=%ld\n", + __pmtimevalToReal(delta), *smpls); + } #endif } --=-eB5mO/d9URyg2oDOtqWz-- From nscott@aconex.com Sun Sep 6 20:25:11 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n871OoII194373 for ; Sun, 6 Sep 2009 20:25:00 -0500 X-ASG-Debug-ID: 1252286722-414003500000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 0D14D15F1AC0 for ; Sun, 6 Sep 2009 18:25:23 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id 6YTFlz8E8SPHB7kC for ; Sun, 06 Sep 2009 18:25:23 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 34ECE814B21; Mon, 7 Sep 2009 11:25:21 +1000 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id nSn3L8OlipuvArye; Mon, 07 Sep 2009 11:25:21 +1000 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id D5077A50297; Mon, 7 Sep 2009 11:24:17 +1000 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 1B59B4FD86; Mon, 7 Sep 2009 11:25:21 +1000 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at gatekeeper.yarra.acx Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EJPNal5GHaKH; Mon, 7 Sep 2009 11:25:16 +1000 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 56FCD4FD82; Mon, 7 Sep 2009 11:25:16 +1000 (EST) Date: Mon, 7 Sep 2009 11:25:16 +1000 (EST) From: Nathan Scott To: kenj@internode.on.net Cc: Martin Hicks , pcp@oss.sgi.com Message-ID: <361605960.17551252286716282.JavaMail.root@mail-au.aconex.com> In-Reply-To: <1804203597.17161252286369976.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: Re: [pcp] QA: pmval showing one less sample Subject: Re: [pcp] QA: pmval showing one less sample MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1252286747 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.8325 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ----- "Ken McDonell" wrote: > ... > Nevertheless, I now have a patch I'm comfortable with ... it is much > simpler than any of the earlier variants and is attached. Great! I did a 2.9.1 on Friday with that initial patch ... I'll get a 2.9.2 out with this (and a Mac/Win build issue sorted out too that came up since), and that should give Mark that initial 3.0.0 target tree he's after. Nice comments in that patch, its all clear now. ;) cheers. -- Nathan From nscott@aconex.com Mon Sep 7 01:38:33 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_73 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n876cD2N218399 for ; Mon, 7 Sep 2009 01:38:23 -0500 X-ASG-Debug-ID: 1252305523-237600870000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 9030142F633 for ; Sun, 6 Sep 2009 23:38:43 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id fpxxTbBpoOiLXi2A for ; Sun, 06 Sep 2009 23:38:43 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 4E8DA35E24A for ; Mon, 7 Sep 2009 16:38:40 +1000 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id zUrNV3PsfXJYXCIF for ; Mon, 07 Sep 2009 16:38:40 +1000 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id B1328A50297 for ; Mon, 7 Sep 2009 16:37:36 +1000 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 1784E4FD82 for ; Mon, 7 Sep 2009 16:38:40 +1000 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at gatekeeper.yarra.acx Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id svapr1CrpTW1 for ; Mon, 7 Sep 2009 16:38:36 +1000 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 2B49C4FD86 for ; Mon, 7 Sep 2009 16:38:36 +1000 (EST) Date: Mon, 7 Sep 2009 16:38:35 +1000 (EST) From: Nathan Scott To: pcp Message-ID: <1376433117.33591252305515501.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcp updates (2.9.2) Subject: pcp updates (2.9.2) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1252305546 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.8344 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Changes committed to git://oss.sgi.com/pcp/pcp.git CHANGELOG | 5 +++ VERSION.pcp | 2 - configure.in | 55 +++++++++++++++++++++++++++-------------- debian/changelog | 7 +++++ man/man1/pmval.1 | 27 +++++++++++++++++++- src/libpcp_mmv/src/mmv_stats.c | 1 src/pmval/pmval.c | 48 +++++++++++++++++++++++++++++------ 7 files changed, 117 insertions(+), 28 deletions(-) commit 11549aca86588c4695d26829e02f2ec9e7b43c3d Author: Nathan Scott Date: Mon Sep 7 16:29:34 2009 +1000 Bump pcp stable version to 2.9.2. commit 7997eea93ad9c240d2cbc7c2bfbd9ae21bb29e35 Author: Ken McDonell Date: Mon Sep 7 11:59:21 2009 +1000 Fix the number-of-samples value calculated in pmval once and for all. For those who care, it turns out that the number of _fetches_ may be known, the number of _reported_ samples cannot be precomputed correctly in all cases ... - only works for archives with -a (not -U or -h) - is known for non-counter metrics - most of the time is known for counter metrics but there are some important corner cases where this is not the case, specifically there will be one more reported sample than expected for a counter when the report starting time is not at the start of the archive and the metric has a defined value before the report starting time with no intervening mark record (interpolate mode does return a value at the first report sample in this case!). With this pmval patch, the QA fallout is nil, except for 144 that is an unrelated timezone problem. Also this patch avoids referencing the context too soon, as there is no point in inspecting the metric's semantics to try and better guess the value of smpls. As a bonus, this patch also documents pmval's -U option that has remained a secret for nearly a decade. commit f4e6d55fd0466a706144ca61b4428436ecea7eb7 Author: Nathan Scott Date: Mon Sep 7 11:51:58 2009 +1000 Attempt to resolve sys/stat related build issue on Alpha. Not having access to an Alpha makes this difficult, but one thing that is clearly not helping is that with Linux glibc on Alpha, we end up defining *both* HAVE_STAT_TIMESPEC and HAVE_STAT_TIME_T, & that breaks otherwise valid pmns.c coding assumptions. This change means only one type for the stat time fields can be defined, and it errs on the side of timespec (which should be the one Alpha uses, AFAICT) - so perhaps this issue will finally be resolved and PCP can progress in the Debian build/release system. commit be8793c58935362184a1dd4351388ca6a0013f3b Author: Nathan Scott Date: Mon Sep 7 11:26:09 2009 +1000 Fix mmv library build on mac/win - missing a header. From nscott@aconex.com Tue Sep 8 22:55:15 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n893stNV125636 for ; Tue, 8 Sep 2009 22:55:05 -0500 X-ASG-Debug-ID: 1252468522-57ff024f0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 59BFA1612504 for ; Tue, 8 Sep 2009 20:55:22 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id 0sgVrcSQ25bTzjaI for ; Tue, 08 Sep 2009 20:55:22 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id BF9AC728D21 for ; Wed, 9 Sep 2009 13:55:18 +1000 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id gnjxJ8cTS8PBtGfq for ; Wed, 09 Sep 2009 13:55:18 +1000 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 4D361A50299 for ; Wed, 9 Sep 2009 13:54:14 +1000 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id A8CA14FD84 for ; Wed, 9 Sep 2009 13:55:18 +1000 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at gatekeeper.yarra.acx Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aZOKZg2WDjsV for ; Wed, 9 Sep 2009 13:55:14 +1000 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id C819D4FD82 for ; Wed, 9 Sep 2009 13:55:14 +1000 (EST) Date: Wed, 9 Sep 2009 13:55:14 +1000 (EST) From: Nathan Scott To: pcp@oss.sgi.com Message-ID: <1226821249.76681252468514749.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcp-gui updates Subject: pcp-gui updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [211.28.150.226] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - SAF3 (Mac)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1252468549 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.8517 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Changes committed to git://oss.sgi.com/pcp/pcp-gui.git images/pmview.icns |binary src/view/GNUmakefile | 2 src/view/pmview.pro.in | 10 - src/view/views/GNUmakefile | 2 src/view/views/hadoopvis | 339 +++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 347 insertions(+), 6 deletions(-) commit 6b967f79c79647e7a80b1ba93df35051029c7cb3 Author: Nathan Scott Date: Wed Sep 9 13:47:29 2009 +1000 Update pmview icons file for Mac OS X. commit 749d35af76315a620a8bcebddc381c5d633f2e7c Author: Nathan Scott Date: Wed Sep 9 13:12:04 2009 +1000 Qt project file rejigging to get pmview to build and run on Mac OS X. commit 74239a0a649012d433c54beacbf4d89780f8e56c Author: Nathan Scott Date: Wed Sep 9 13:09:28 2009 +1000 Remove reference to non-existent header in pmview makefile. commit c17374491a39e3b50128d01507cd864caf60ae69 Author: Nathan Scott Date: Wed Sep 9 13:06:47 2009 +1000 Initial pmview front-end for visualising Hadoop cluster activity. From goodwinos@gmail.com Tue Sep 8 23:57:01 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,J_CHICKENPOX_53, J_CHICKENPOX_65,J_CHICKENPOX_66,LOCAL_GNU_PATCH autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n894ue7C129205 for ; Tue, 8 Sep 2009 23:56:51 -0500 X-ASG-Debug-ID: 1252472244-5817034f0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mx1.redhat.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 9D1581BE4554 for ; Tue, 8 Sep 2009 21:57:24 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id MquRWVT98B5UaD3s for ; Tue, 08 Sep 2009 21:57:24 -0700 (PDT) Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n894vIf4014589 for ; Wed, 9 Sep 2009 00:57:18 -0400 Received: from [10.64.6.24] (vpn6-6-24.bne.redhat.com [10.64.6.24]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n894vFep010757 for ; Wed, 9 Sep 2009 00:57:16 -0400 Message-ID: <4AA735AA.60509@gmail.com> Date: Wed, 09 Sep 2009 14:57:14 +1000 From: Mark Goodwin User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: pcp@oss.sgi.com X-ASG-Orig-Subj: [PATCH review] perl-pcp RPM packaging integration Subject: [PATCH review] perl-pcp RPM packaging integration Content-Type: multipart/mixed; boundary="------------000901080106070804090508" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1252472251 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.52 X-Barracuda-Spam-Status: No, SCORE=-1.52 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.8521 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean This is a multi-part message in MIME format. --------------000901080106070804090508 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit For review - this patch integrates the perl-pcp RPM packaging into the standard build. This step was previously done manually with cpanflute and other tools. --------------000901080106070804090508 Content-Type: text/x-patch; name="perl-pcp-rpm-packaging.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="perl-pcp-rpm-packaging.patch" diff --git a/.gitignore b/.gitignore index c0dc0d6..1581608 100644 --- a/.gitignore +++ b/.gitignore @@ -18,3 +18,4 @@ devel_files.rpm libs_files libs_files.rpm gram*.tab.c +perl-pcp-*.list diff --git a/CHANGELOG b/CHANGELOG index 884390e..f9aac2a 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,4 +1,4 @@ -pcp-3.0.0 (7 September 2009) +pcp-3.0.0 (9 September 2009) - packaging split into pcp, pcp-libs and pcp-libs-devel pcp-libs is common - it's required by pcp and by pcp-libs-devel but pcp and pcp-devel can be installed with or without each other. @@ -29,6 +29,8 @@ pcp-3.0.0 (7 September 2009) - reconciled build/rpm/pcp.spec.in with build/rpm/pcp_fedora.spec - git merged the final 2.9.1 source tree - numerous other minor changes, mostly for inclusion in Fedora + - integrated RPM packaging support for perl-PCP-PMDA, perl-PCP-MMV and + perl-PCP-LogSummary pcp-2.9.2 (7 September 2009) - Final iteration on pmval sample count changes. diff --git a/GNUmakefile b/GNUmakefile index 621f38f..56f43ce 100644 --- a/GNUmakefile +++ b/GNUmakefile @@ -55,7 +55,7 @@ LDIRT = config.cache config.status config.log files.rpm pro_files.rpm \ root-*/include root-*/lib root-*/*.rpm root-*/default_pro \ autom4te.cache install.manifest install_pro.manifest \ debug*.list devel_files libs_files base_files.rpm libs_files.rpm \ - devel_files.rpm + devel_files.rpm perl-pcp*.list SUBDIRS = src man build debian ifeq "$(MAKECMDGOALS)" "clobber" diff --git a/VERSION.pcp b/VERSION.pcp index d3e3757..bbf8a89 100644 --- a/VERSION.pcp +++ b/VERSION.pcp @@ -4,4 +4,4 @@ PACKAGE_MAJOR=3 PACKAGE_MINOR=0 PACKAGE_REVISION=0 -PACKAGE_BUILD=5 +PACKAGE_BUILD=6 diff --git a/build/rpm/pcp.spec.in b/build/rpm/pcp.spec.in index ac2b42d..42ea6e2 100644 --- a/build/rpm/pcp.spec.in +++ b/build/rpm/pcp.spec.in @@ -93,11 +93,64 @@ Requires: pcp-libs = @package_version@ %description libs-devel Performance Co-Pilot (PCP) headers, documentation and tools for development. +# +# perl-PCP-PMDA. This is the PCP agent perl binding. +# +%package -n perl-PCP-PMDA +License: GPLv2 +Group: Applications/System +Summary: Performance Co-Pilot (PCP) Perl bindings and documentation +URL: http://oss.sgi.com/projects/pcp/ +Requires: pcp = @package_version@ + +%description -n perl-PCP-PMDA +The PCP::PMDA Perl module contains the language bindings for +building Performance Metric Domain Agents (PMDAs) using Perl. +Each PMDA exports performance data for one specific domain, for +example the operating system kernel, Cisco routers, a database, +an application, etc. + +# +# perl-PCP-SUMMARY +# +%package -n perl-PCP-LogSummary +License: GPLv2 +Group: Applications/System +Summary: Performance Co-Pilot (PCP) Perl bindings for pmlogsummary +URL: http://oss.sgi.com/projects/pcp/ +Requires: pcp = @package_version@ + +%description -n perl-PCP-LogSummary +The PCP::LogSummary module provides a Perl module for using the +statistical summary data produced by the Performance Co-Pilot +pmlogsummary utility. This utility produces various averages, +minima, maxima, and other calculations based on the performance +data stored in a PCP archive. The Perl interface is ideal for +exporting this data into third-party tools (e.g. spreadsheets). + +# +# perl-PCP-MMV +# +%package -n perl-PCP-MMV +License: GPLv2 +Group: Applications/System +Summary: Performance Co-Pilot (PCP) Perl bindings for PCP Memory Mapped Values +URL: http://oss.sgi.com/projects/pcp/ +Requires: pcp = @package_version@ + +%description -n perl-PCP-MMV +The PCP::MMV module contains the Perl language bindings for +building scripts instrumented with the Performance Co-Pilot +(PCP) Memory Mapped Value (MMV) mechanism. +This mechanism allows arbitrary values to be exported from an +instrumented script into the PCP infrastructure for monitoring +and analysis with pmchart, pmie, pmlogger and other PCP tools. + %if %sgi_chroot_build %debug_package %endif -# In .census is exist, then no setup is necessary, just go and do the build, +# If .census exists, then no setup is necessary, just go and do the build, # otherwise run setup %prep if [ -f .census ] ; then @@ -211,6 +264,15 @@ fi %files libs-devel -f devel_files.rpm %defattr(-,root,root) +%files -n perl-PCP-PMDA -f perl-pcp-pmda.list +%defattr(-,root,root) + +%files -n perl-PCP-LogSummary -f perl-pcp-logsummary.list +%defattr(-,root,root) + +%files -n perl-PCP-MMV -f perl-pcp-mmv.list +%defattr(-,root,root) + %changelog * Fri Sep 04 2009 Mark Goodwin - 3.0.0-5 - bump to v3.0.0 and reconcile spec with Fedora spec diff --git a/build/rpm/pcp_fedora.spec b/build/rpm/pcp_fedora.spec index 6500473..da885fe 100644 --- a/build/rpm/pcp_fedora.spec +++ b/build/rpm/pcp_fedora.spec @@ -1,11 +1,11 @@ Summary: System-level performance monitoring and performance management Name: pcp Version: 3.0.0 -Release: 5%{?dist} +Release: 6%{?dist} License: GPLv2 URL: http://oss.sgi.com/projects/pcp Group: Applications/System -Source0: ftp://oss.sgi.com/projects/pcp/download/v3/pcp-3.0.0-5.src.tar.gz +Source0: ftp://oss.sgi.com/projects/pcp/download/v3/pcp-3.0.0-6.src.tar.gz # Infiniband monitoring support turned off (for now) %define have_ibdev 0 @@ -57,6 +57,59 @@ Requires: pcp-libs = %{version} %description libs-devel Performance Co-Pilot (PCP) headers, documentation and tools for development. +# +# perl-PCP-PMDA. This is the PCP agent perl binding. +# +%package -n perl-PCP-PMDA +License: GPLv2 +Group: Applications/System +Summary: Performance Co-Pilot (PCP) Perl bindings and documentation +URL: http://oss.sgi.com/projects/pcp/ +Requires: pcp = @package_version@ + +%description -n perl-PCP-PMDA +The PCP::PMDA Perl module contains the language bindings for +building Performance Metric Domain Agents (PMDAs) using Perl. +Each PMDA exports performance data for one specific domain, for +example the operating system kernel, Cisco routers, a database, +an application, etc. + +# +# perl-PCP-SUMMARY +# +%package -n perl-PCP-LogSummary +License: GPLv2 +Group: Applications/System +Summary: Performance Co-Pilot (PCP) Perl bindings for pmlogsummary +URL: http://oss.sgi.com/projects/pcp/ +Requires: pcp = @package_version@ + +%description -n perl-PCP-LogSummary +The PCP::LogSummary module provides a Perl module for using the +statistical summary data produced by the Performance Co-Pilot +pmlogsummary utility. This utility produces various averages, +minima, maxima, and other calculations based on the performance +data stored in a PCP archive. The Perl interface is ideal for +exporting this data into third-party tools (e.g. spreadsheets). + +# +# perl-PCP-MMV +# +%package -n perl-PCP-MMV +License: GPLv2 +Group: Applications/System +Summary: Performance Co-Pilot (PCP) Perl bindings for PCP Memory Mapped Values +URL: http://oss.sgi.com/projects/pcp/ +Requires: pcp = @package_version@ + +%description -n perl-PCP-MMV +The PCP::MMV module contains the Perl language bindings for +building scripts instrumented with the Performance Co-Pilot +(PCP) Memory Mapped Value (MMV) mechanism. +This mechanism allows arbitrary values to be exported from an +instrumented script into the PCP infrastructure for monitoring +and analysis with pmchart, pmie, pmlogger and other PCP tools. + %prep %setup -q autoconf @@ -199,6 +252,15 @@ fi %{_localstatedir}/lib/pcp/pmdas/trivial %{_localstatedir}/lib/pcp/pmdas/txmon +%files -n perl-PCP-PMDA -f perl-pcp-pmda.list +%defattr(-,root,root) + +%files -n perl-PCP-LogSummary -f perl-pcp-logsummary.list +%defattr(-,root,root) + +%files -n perl-PCP-MMV -f perl-pcp-mmv.list +%defattr(-,root,root) + %changelog -* Fri Sep 04 2009 Mark Goodwin - 3.0.0-5 +* Tue Sep 09 2009 Mark Goodwin - 3.0.0-6 - initial import into Fedora diff --git a/src/cpan/LogSummary/GNUmakefile b/src/cpan/LogSummary/GNUmakefile index aa4154b..6ea16f6 100644 --- a/src/cpan/LogSummary/GNUmakefile +++ b/src/cpan/LogSummary/GNUmakefile @@ -50,6 +50,9 @@ test dist: Makefile include $(BUILDRULES) install: default + $(PERLMAKE) -f Makefile pure_install PERL_INSTALL_ROOT=$$DIST_ROOT + find $$DIST_ROOT -name .packlist -exec mv '{}' $(TOPDIR)/perl-pcp-logsummary.list ';' + sed -e 's@'$$DIST_ROOT'@@' -i $(TOPDIR)/perl-pcp-logsummary.list install_perl: $(PERLMAKE) -f Makefile install $(INSTALLER_OPTIONS) diff --git a/src/cpan/MMV/GNUmakefile b/src/cpan/MMV/GNUmakefile index ec9f78a..63390e7 100644 --- a/src/cpan/MMV/GNUmakefile +++ b/src/cpan/MMV/GNUmakefile @@ -55,6 +55,9 @@ test dist: MMV.o include $(BUILDRULES) install: default + $(PERLMAKE) -f Makefile pure_install PERL_INSTALL_ROOT=$$DIST_ROOT + find $$DIST_ROOT -name .packlist -exec mv '{}' $(TOPDIR)/perl-pcp-mmv.list ';' + sed -e 's@'$$DIST_ROOT'@@' -i $(TOPDIR)/perl-pcp-mmv.list install_perl: $(PERLMAKE) -f Makefile install $(INSTALLER_OPTIONS) diff --git a/src/cpan/PMDA/GNUmakefile b/src/cpan/PMDA/GNUmakefile index 565f3f2..5b203e1 100644 --- a/src/cpan/PMDA/GNUmakefile +++ b/src/cpan/PMDA/GNUmakefile @@ -60,6 +60,9 @@ test dist: PMDA.o include $(BUILDRULES) install: default + $(PERLMAKE) -f Makefile pure_install PERL_INSTALL_ROOT=$$DIST_ROOT + find $$DIST_ROOT -name .packlist -exec mv '{}' $(TOPDIR)/perl-pcp-pmda.list ';' + sed -e 's@'$$DIST_ROOT'@@' -i $(TOPDIR)/perl-pcp-pmda.list install_perl: $(PERLMAKE) -f Makefile install $(INSTALLER_OPTIONS) diff --git a/src/pmns/.gitignore b/src/pmns/.gitignore index c586d41..ea82cdb 100644 --- a/src/pmns/.gitignore +++ b/src/pmns/.gitignore @@ -1,3 +1,4 @@ pmnsdel pmnsmerge stdpmid +.NeedRebuild --------------000901080106070804090508-- From nscott@aconex.com Wed Sep 16 22:54:14 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n8H3sDjr149413 for ; Wed, 16 Sep 2009 22:54:13 -0500 X-ASG-Debug-ID: 1253159726-5e6400310000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 52E4645ACB8 for ; Wed, 16 Sep 2009 20:55:27 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id YNFuS3NyzqkplwiD for ; Wed, 16 Sep 2009 20:55:27 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id B1FD83C4A9F for ; Thu, 17 Sep 2009 13:55:24 +1000 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id rPWzLcut24BAaJQf for ; Thu, 17 Sep 2009 13:55:24 +1000 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 02C07A5017F for ; Thu, 17 Sep 2009 13:54:16 +1000 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 9756C4FD85 for ; Thu, 17 Sep 2009 13:55:24 +1000 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at gatekeeper.yarra.acx Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q+gyw+sExqMK for ; Thu, 17 Sep 2009 13:55:20 +1000 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 913284FD82 for ; Thu, 17 Sep 2009 13:55:20 +1000 (EST) Date: Thu, 17 Sep 2009 13:55:20 +1000 (EST) From: Nathan Scott To: pcp Message-ID: <1933294736.261931253159720463.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: pcp updates Subject: pcp updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1253159728 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.9228 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Changes committed to git://oss.sgi.com/nathans/pcp.git src/libpcp_gui/src/timeclient.c | 4 src/pmdas/windows/fetch.c | 21 ++- src/pmdas/windows/libpdh.h | 3 src/pmdas/windows/open.c | 42 +++++- src/pmdas/windows/pmda.c | 256 ++++++++++++++++++++++++---------------- 5 files changed, 208 insertions(+), 118 deletions(-) commit 5084f633af27d29c9d54fcbf03192eb9629d540e Author: Nathan Scott Date: Thu Sep 17 13:18:09 2009 +1000 Fix the Windows SQL Server buffer_cache metric for more platforms. This metric is a (32 bit float) PERF_RAW_FRACTION metric under Windows 2003 Server and SQL Server 2000, but under Windows and SQL Server 2008 its a 64 bit double (PERF_LARGE_RAW_FRACTION). Needed additional code to handle this type, which we've not come across before. In addition reworked startup slightly to reduce the warnings and correct types being used in the metric table for several Windows metrics - when going to 64 bit Windows 2008, lots of types have changed and pmcd.log was spammed with warnings as a result. This is now figured out on the fly, at PMDA startup, for the affected metrics (using M_AUTO64 flag to identify those that will change). commit 0ec55c66fc9fee6a971d4c9f2d98a9bf4b78b64c Author: Nathan Scott Date: Thu Sep 17 12:39:46 2009 +1000 Use errnos that exist on all platforms. From nscott@aconex.com Wed Sep 16 23:14:17 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_53, J_CHICKENPOX_65,J_CHICKENPOX_66,LOCAL_GNU_PATCH autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n8H4EHlP150751 for ; Wed, 16 Sep 2009 23:14:17 -0500 X-ASG-Debug-ID: 1253160929-3a4d01ee0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 55335167A216 for ; Wed, 16 Sep 2009 21:15:29 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id nDUVYsQP3qPKuTcK for ; Wed, 16 Sep 2009 21:15:29 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 16AD3666814; Thu, 17 Sep 2009 14:14:47 +1000 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id HfNNE9iUwDC69Rub; Thu, 17 Sep 2009 14:14:47 +1000 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 5D2BEA5017F; Thu, 17 Sep 2009 14:13:38 +1000 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id F30F54FD89; Thu, 17 Sep 2009 14:14:46 +1000 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at gatekeeper.yarra.acx Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JZJU1hAavmvD; Thu, 17 Sep 2009 14:14:43 +1000 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id F32B84FD85; Thu, 17 Sep 2009 14:14:42 +1000 (EST) Date: Thu, 17 Sep 2009 14:14:42 +1000 (EST) From: Nathan Scott To: Mark Goodwin Cc: pcp@oss.sgi.com Message-ID: <1076304519.262691253160882911.JavaMail.root@mail-au.aconex.com> In-Reply-To: <4AA735AA.60509@gmail.com> X-ASG-Orig-Subj: Re: [pcp] [PATCH review] perl-pcp RPM packaging integration Subject: Re: [pcp] [PATCH review] perl-pcp RPM packaging integration MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_19257_1403907844.1253160882910" X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1253160931 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.52 X-Barracuda-Spam-Status: No, SCORE=-1.52 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.9228 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M X-Virus-Status: Clean ------=_Part_19257_1403907844.1253160882910 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit ----- "Mark Goodwin" wrote: > For review - this patch integrates the perl-pcp RPM packaging into the > standard > build. This step was previously done manually with cpanflute and other > tools. Looks good to me. Simplifies things nicely, really, by reducing the build toolchain. We should remove the cpanflute2 references everywhere after we apply this patch though, shouldn't we? cheers. -- Nathan ------=_Part_19257_1403907844.1253160882910 Content-Type: text/x-patch; name=perl-pcp-rpm-packaging.patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=perl-pcp-rpm-packaging.patch diff --git a/.gitignore b/.gitignore index c0dc0d6..1581608 100644 --- a/.gitignore +++ b/.gitignore @@ -18,3 +18,4 @@ devel_files.rpm libs_files libs_files.rpm gram*.tab.c +perl-pcp-*.list diff --git a/CHANGELOG b/CHANGELOG index 884390e..f9aac2a 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,4 +1,4 @@ -pcp-3.0.0 (7 September 2009) +pcp-3.0.0 (9 September 2009) - packaging split into pcp, pcp-libs and pcp-libs-devel pcp-libs is common - it's required by pcp and by pcp-libs-devel but pcp and pcp-devel can be installed with or without each other. @@ -29,6 +29,8 @@ pcp-3.0.0 (7 September 2009) - reconciled build/rpm/pcp.spec.in with build/rpm/pcp_fedora.spec - git merged the final 2.9.1 source tree - numerous other minor changes, mostly for inclusion in Fedora + - integrated RPM packaging support for perl-PCP-PMDA, perl-PCP-MMV and + perl-PCP-LogSummary pcp-2.9.2 (7 September 2009) - Final iteration on pmval sample count changes. diff --git a/GNUmakefile b/GNUmakefile index 621f38f..56f43ce 100644 --- a/GNUmakefile +++ b/GNUmakefile @@ -55,7 +55,7 @@ LDIRT = config.cache config.status config.log files.rpm pro_files.rpm \ root-*/include root-*/lib root-*/*.rpm root-*/default_pro \ autom4te.cache install.manifest install_pro.manifest \ debug*.list devel_files libs_files base_files.rpm libs_files.rpm \ - devel_files.rpm + devel_files.rpm perl-pcp*.list SUBDIRS = src man build debian ifeq "$(MAKECMDGOALS)" "clobber" diff --git a/VERSION.pcp b/VERSION.pcp index d3e3757..bbf8a89 100644 --- a/VERSION.pcp +++ b/VERSION.pcp @@ -4,4 +4,4 @@ PACKAGE_MAJOR=3 PACKAGE_MINOR=0 PACKAGE_REVISION=0 -PACKAGE_BUILD=5 +PACKAGE_BUILD=6 diff --git a/build/rpm/pcp.spec.in b/build/rpm/pcp.spec.in index ac2b42d..42ea6e2 100644 --- a/build/rpm/pcp.spec.in +++ b/build/rpm/pcp.spec.in @@ -93,11 +93,64 @@ Requires: pcp-libs = @package_version@ %description libs-devel Performance Co-Pilot (PCP) headers, documentation and tools for development. +# +# perl-PCP-PMDA. This is the PCP agent perl binding. +# +%package -n perl-PCP-PMDA +License: GPLv2 +Group: Applications/System +Summary: Performance Co-Pilot (PCP) Perl bindings and documentation +URL: http://oss.sgi.com/projects/pcp/ +Requires: pcp = @package_version@ + +%description -n perl-PCP-PMDA +The PCP::PMDA Perl module contains the language bindings for +building Performance Metric Domain Agents (PMDAs) using Perl. +Each PMDA exports performance data for one specific domain, for +example the operating system kernel, Cisco routers, a database, +an application, etc. + +# +# perl-PCP-SUMMARY +# +%package -n perl-PCP-LogSummary +License: GPLv2 +Group: Applications/System +Summary: Performance Co-Pilot (PCP) Perl bindings for pmlogsummary +URL: http://oss.sgi.com/projects/pcp/ +Requires: pcp = @package_version@ + +%description -n perl-PCP-LogSummary +The PCP::LogSummary module provides a Perl module for using the +statistical summary data produced by the Performance Co-Pilot +pmlogsummary utility. This utility produces various averages, +minima, maxima, and other calculations based on the performance +data stored in a PCP archive. The Perl interface is ideal for +exporting this data into third-party tools (e.g. spreadsheets). + +# +# perl-PCP-MMV +# +%package -n perl-PCP-MMV +License: GPLv2 +Group: Applications/System +Summary: Performance Co-Pilot (PCP) Perl bindings for PCP Memory Mapped Values +URL: http://oss.sgi.com/projects/pcp/ +Requires: pcp = @package_version@ + +%description -n perl-PCP-MMV +The PCP::MMV module contains the Perl language bindings for +building scripts instrumented with the Performance Co-Pilot +(PCP) Memory Mapped Value (MMV) mechanism. +This mechanism allows arbitrary values to be exported from an +instrumented script into the PCP infrastructure for monitoring +and analysis with pmchart, pmie, pmlogger and other PCP tools. + %if %sgi_chroot_build %debug_package %endif -# In .census is exist, then no setup is necessary, just go and do the build, +# If .census exists, then no setup is necessary, just go and do the build, # otherwise run setup %prep if [ -f .census ] ; then @@ -211,6 +264,15 @@ fi %files libs-devel -f devel_files.rpm %defattr(-,root,root) +%files -n perl-PCP-PMDA -f perl-pcp-pmda.list +%defattr(-,root,root) + +%files -n perl-PCP-LogSummary -f perl-pcp-logsummary.list +%defattr(-,root,root) + +%files -n perl-PCP-MMV -f perl-pcp-mmv.list +%defattr(-,root,root) + %changelog * Fri Sep 04 2009 Mark Goodwin - 3.0.0-5 - bump to v3.0.0 and reconcile spec with Fedora spec diff --git a/build/rpm/pcp_fedora.spec b/build/rpm/pcp_fedora.spec index 6500473..da885fe 100644 --- a/build/rpm/pcp_fedora.spec +++ b/build/rpm/pcp_fedora.spec @@ -1,11 +1,11 @@ Summary: System-level performance monitoring and performance management Name: pcp Version: 3.0.0 -Release: 5%{?dist} +Release: 6%{?dist} License: GPLv2 URL: http://oss.sgi.com/projects/pcp Group: Applications/System -Source0: ftp://oss.sgi.com/projects/pcp/download/v3/pcp-3.0.0-5.src.tar.gz +Source0: ftp://oss.sgi.com/projects/pcp/download/v3/pcp-3.0.0-6.src.tar.gz # Infiniband monitoring support turned off (for now) %define have_ibdev 0 @@ -57,6 +57,59 @@ Requires: pcp-libs = %{version} %description libs-devel Performance Co-Pilot (PCP) headers, documentation and tools for development. +# +# perl-PCP-PMDA. This is the PCP agent perl binding. +# +%package -n perl-PCP-PMDA +License: GPLv2 +Group: Applications/System +Summary: Performance Co-Pilot (PCP) Perl bindings and documentation +URL: http://oss.sgi.com/projects/pcp/ +Requires: pcp = @package_version@ + +%description -n perl-PCP-PMDA +The PCP::PMDA Perl module contains the language bindings for +building Performance Metric Domain Agents (PMDAs) using Perl. +Each PMDA exports performance data for one specific domain, for +example the operating system kernel, Cisco routers, a database, +an application, etc. + +# +# perl-PCP-SUMMARY +# +%package -n perl-PCP-LogSummary +License: GPLv2 +Group: Applications/System +Summary: Performance Co-Pilot (PCP) Perl bindings for pmlogsummary +URL: http://oss.sgi.com/projects/pcp/ +Requires: pcp = @package_version@ + +%description -n perl-PCP-LogSummary +The PCP::LogSummary module provides a Perl module for using the +statistical summary data produced by the Performance Co-Pilot +pmlogsummary utility. This utility produces various averages, +minima, maxima, and other calculations based on the performance +data stored in a PCP archive. The Perl interface is ideal for +exporting this data into third-party tools (e.g. spreadsheets). + +# +# perl-PCP-MMV +# +%package -n perl-PCP-MMV +License: GPLv2 +Group: Applications/System +Summary: Performance Co-Pilot (PCP) Perl bindings for PCP Memory Mapped Values +URL: http://oss.sgi.com/projects/pcp/ +Requires: pcp = @package_version@ + +%description -n perl-PCP-MMV +The PCP::MMV module contains the Perl language bindings for +building scripts instrumented with the Performance Co-Pilot +(PCP) Memory Mapped Value (MMV) mechanism. +This mechanism allows arbitrary values to be exported from an +instrumented script into the PCP infrastructure for monitoring +and analysis with pmchart, pmie, pmlogger and other PCP tools. + %prep %setup -q autoconf @@ -199,6 +252,15 @@ fi %{_localstatedir}/lib/pcp/pmdas/trivial %{_localstatedir}/lib/pcp/pmdas/txmon +%files -n perl-PCP-PMDA -f perl-pcp-pmda.list +%defattr(-,root,root) + +%files -n perl-PCP-LogSummary -f perl-pcp-logsummary.list +%defattr(-,root,root) + +%files -n perl-PCP-MMV -f perl-pcp-mmv.list +%defattr(-,root,root) + %changelog -* Fri Sep 04 2009 Mark Goodwin - 3.0.0-5 +* Tue Sep 09 2009 Mark Goodwin - 3.0.0-6 - initial import into Fedora diff --git a/src/cpan/LogSummary/GNUmakefile b/src/cpan/LogSummary/GNUmakefile index aa4154b..6ea16f6 100644 --- a/src/cpan/LogSummary/GNUmakefile +++ b/src/cpan/LogSummary/GNUmakefile @@ -50,6 +50,9 @@ test dist: Makefile include $(BUILDRULES) install: default + $(PERLMAKE) -f Makefile pure_install PERL_INSTALL_ROOT=$$DIST_ROOT + find $$DIST_ROOT -name .packlist -exec mv '{}' $(TOPDIR)/perl-pcp-logsummary.list ';' + sed -e 's@'$$DIST_ROOT'@@' -i $(TOPDIR)/perl-pcp-logsummary.list install_perl: $(PERLMAKE) -f Makefile install $(INSTALLER_OPTIONS) diff --git a/src/cpan/MMV/GNUmakefile b/src/cpan/MMV/GNUmakefile index ec9f78a..63390e7 100644 --- a/src/cpan/MMV/GNUmakefile +++ b/src/cpan/MMV/GNUmakefile @@ -55,6 +55,9 @@ test dist: MMV.o include $(BUILDRULES) install: default + $(PERLMAKE) -f Makefile pure_install PERL_INSTALL_ROOT=$$DIST_ROOT + find $$DIST_ROOT -name .packlist -exec mv '{}' $(TOPDIR)/perl-pcp-mmv.list ';' + sed -e 's@'$$DIST_ROOT'@@' -i $(TOPDIR)/perl-pcp-mmv.list install_perl: $(PERLMAKE) -f Makefile install $(INSTALLER_OPTIONS) diff --git a/src/cpan/PMDA/GNUmakefile b/src/cpan/PMDA/GNUmakefile index 565f3f2..5b203e1 100644 --- a/src/cpan/PMDA/GNUmakefile +++ b/src/cpan/PMDA/GNUmakefile @@ -60,6 +60,9 @@ test dist: PMDA.o include $(BUILDRULES) install: default + $(PERLMAKE) -f Makefile pure_install PERL_INSTALL_ROOT=$$DIST_ROOT + find $$DIST_ROOT -name .packlist -exec mv '{}' $(TOPDIR)/perl-pcp-pmda.list ';' + sed -e 's@'$$DIST_ROOT'@@' -i $(TOPDIR)/perl-pcp-pmda.list install_perl: $(PERLMAKE) -f Makefile install $(INSTALLER_OPTIONS) diff --git a/src/pmns/.gitignore b/src/pmns/.gitignore index c586d41..ea82cdb 100644 --- a/src/pmns/.gitignore +++ b/src/pmns/.gitignore @@ -1,3 +1,4 @@ pmnsdel pmnsmerge stdpmid +.NeedRebuild ------=_Part_19257_1403907844.1253160882910-- From goodwinos@gmail.com Thu Sep 17 18:04:47 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n8HN4kFX251462 for ; Thu, 17 Sep 2009 18:04:46 -0500 X-ASG-Debug-ID: 1253228760-60f001220000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mx1.redhat.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id BE133168FA63 for ; Thu, 17 Sep 2009 16:06:00 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id YXHGGL4o4WP3Snws for ; Thu, 17 Sep 2009 16:06:00 -0700 (PDT) Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8HN5vRC016167; Thu, 17 Sep 2009 19:05:57 -0400 Received: from [10.64.176.217] (dhcp-176-217.mel.redhat.com [10.64.176.217]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n8HN5tAE002820; Thu, 17 Sep 2009 19:05:56 -0400 Message-ID: <4AB2C0D3.7020500@gmail.com> Date: Fri, 18 Sep 2009 09:05:55 +1000 From: Mark Goodwin User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Nathan Scott CC: pcp@oss.sgi.com X-ASG-Orig-Subj: Re: [pcp] [PATCH review] perl-pcp RPM packaging integration Subject: Re: [pcp] [PATCH review] perl-pcp RPM packaging integration References: <1076304519.262691253160882911.JavaMail.root@mail-au.aconex.com> In-Reply-To: <1076304519.262691253160882911.JavaMail.root@mail-au.aconex.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 10.5.11.16 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1253228761 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.9293 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Nathan Scott wrote: > ----- "Mark Goodwin" wrote: > >> For review - this patch integrates the perl-pcp RPM packaging into the >> standard >> build. This step was previously done manually with cpanflute and other >> tools. > > Looks good to me. Simplifies things nicely, really, by reducing the build > toolchain. We should remove the cpanflute2 references everywhere after we > apply this patch though, shouldn't we? thanks. Yes I'll nuke all the cpanflute stuff since it's not needed any more. Also, as was discused on IRC, I'll make the 'perl vendor' install the default (rather than 'site', since rpmlint doesn't like /usr/local). I should have that all ready early next week, along with the rest of 3.0.0. Cheers From makc@iinet.net.au Mon Sep 21 04:49:08 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_42 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n8L9n8Bi075382 for ; Mon, 21 Sep 2009 04:49:08 -0500 X-ASG-Debug-ID: 1253526621-076600c00000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from outbound.icp-qv1-irony-out5.iinet.net.au (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id DE6701BEF8E7 for ; Mon, 21 Sep 2009 02:50:22 -0700 (PDT) Received: from outbound.icp-qv1-irony-out5.iinet.net.au (outbound.icp-qv1-irony-out5.iinet.net.au [203.59.1.108]) by cuda.sgi.com with ESMTP id ffr2MzLBX5qf4Q8o for ; Mon, 21 Sep 2009 02:50:22 -0700 (PDT) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqgEAL3otkrL2Rwk/2dsb2JhbACbd7NfhBsF X-IronPort-AV: E=Sophos;i="4.44,424,1249228800"; d="scan'208";a="36395573" Received: from unknown (HELO alma.crabbed.net) ([203.217.28.36]) by outbound.icp-qv1-irony-out5.iinet.net.au with ESMTP; 21 Sep 2009 17:50:20 +0800 Received: by alma.crabbed.net (Postfix, from userid 501) id A763D3BCE61; Mon, 21 Sep 2009 19:48:53 +1000 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19127.19461.625461.331046@iinet.net.au> Date: Mon, 21 Sep 2009 19:48:53 +1000 From: Max Matveev To: pcp@oss.sgi.com X-ASG-Orig-Subj: Building PERL PMDAs on Solaris Subject: Building PERL PMDAs on Solaris X-Mailer: VM 7.17 under 21.4 (patch 19) "Constant Variable" XEmacs Lucid X-Barracuda-Connect: outbound.icp-qv1-irony-out5.iinet.net.au[203.59.1.108] X-Barracuda-Start-Time: 1253526624 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.9615 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean I'm having problems with building Perl PMDAs on Solaris: the defaults which MakeMaker picks do not agree with what I've got - for example, I'm building with compiler set in 64 bit mode but Perl part of the build does not pick that setting and as a result fails to create DSOs. I'm thinking about applying the following changes to the Makefile.PL --- a/src/cpan/PMDA/Makefile.PL +++ b/src/cpan/PMDA/Makefile.PL @@ -14,4 +14,6 @@ WriteMakefile( LDFROM => "-L$ENV{PCP_TOPDIR}/src/libpcp/src -L$ENV{PCP_TOPDIR} INC => "-I$ENV{PCP_TOPDIR}/src/include -I/usr/includ LIBS => ["-L$ENV{PCP_DIR}\\local\\bin", '-lpcp_pmda', '-lpcp' + CC => $ENV{"CC"}, + LD => $ENV{"CC"}, ); We also missing a dependency in the GNUmakefile to remake Makefile when Makefile.PL changes: --- a/src/cpan/PMDA/GNUmakefile +++ b/src/cpan/PMDA/GNUmakefile @@ -46,9 +46,9 @@ endif PMDA.o: Makefile PMDA.xs $(PERLMAKE) -f Makefile -Makefile: COPYING +Makefile: COPYING Makefile.PL export PCP_TOPDIR=`pwd`/$(TOPDIR); \ - perl Makefile.PL $(MAKEMAKER_OPTIONS) + CC="$(CC)" perl Makefile.PL $(MAKEMAKER_OPTIONS) COPYING: $(LN_S) $(TOPDIR)/COPYING COPYING max From nscott@aconex.com Mon Sep 21 22:01:57 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_42 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n8M31u4b153821 for ; Mon, 21 Sep 2009 22:01:57 -0500 X-ASG-Debug-ID: 1253588591-4d27020d0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id E2A9D16B15E3 for ; Mon, 21 Sep 2009 20:03:12 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id eFiDVSpvE24GuSgk for ; Mon, 21 Sep 2009 20:03:12 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id EE8563F1080; Tue, 22 Sep 2009 13:03:09 +1000 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id 9mRlna7n0HbMn7m5; Tue, 22 Sep 2009 13:03:09 +1000 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 9A598A50264; Tue, 22 Sep 2009 13:01:58 +1000 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id C18E84FD84; Tue, 22 Sep 2009 13:03:09 +1000 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at gatekeeper.yarra.acx Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 51Gnm6uJ28VW; Tue, 22 Sep 2009 13:03:05 +1000 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 6DAF84FD85; Tue, 22 Sep 2009 13:03:02 +1000 (EST) Date: Tue, 22 Sep 2009 13:03:02 +1000 (EST) From: Nathan Scott To: Max Matveev Cc: pcp@oss.sgi.com Message-ID: <1172878631.4421253588582478.JavaMail.root@mail-au.aconex.com> In-Reply-To: <19127.19461.625461.331046@iinet.net.au> X-ASG-Orig-Subj: Re: [pcp] Building PERL PMDAs on Solaris Subject: Re: [pcp] Building PERL PMDAs on Solaris MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1253588593 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.9681 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ----- "Max Matveev" wrote: > I'm having problems with building Perl PMDAs on Solaris: the defaults > which MakeMaker picks do not agree with what I've got - for example, > I'm building with compiler set in 64 bit mode but Perl part of the > build does not pick that setting and as a result fails to create > DSOs. > > I'm thinking about applying the following changes to the Makefile.PL > ... That should be fine, I think, though be even better if it handled both cases (with & without $CC set). > --- a/src/cpan/PMDA/Makefile.PL > +++ b/src/cpan/PMDA/Makefile.PL > @@ -14,4 +14,6 @@ WriteMakefile( > LDFROM => "-L$ENV{PCP_TOPDIR}/src/libpcp/src > -L$ENV{PCP_TOPDIR} > INC => "-I$ENV{PCP_TOPDIR}/src/include > -I/usr/includ > LIBS => ["-L$ENV{PCP_DIR}\\local\\bin", > '-lpcp_pmda', '-lpcp' > + CC => $ENV{"CC"}, > + LD => $ENV{"CC"}, > ); > > > We also missing a dependency in the GNUmakefile to remake Makefile > when Makefile.PL changes: > > --- a/src/cpan/PMDA/GNUmakefile > +++ b/src/cpan/PMDA/GNUmakefile > @@ -46,9 +46,9 @@ endif > PMDA.o: Makefile PMDA.xs > $(PERLMAKE) -f Makefile > > -Makefile: COPYING > +Makefile: COPYING Makefile.PL OK, looks good. > export PCP_TOPDIR=`pwd`/$(TOPDIR); \ > - perl Makefile.PL $(MAKEMAKER_OPTIONS) > + CC="$(CC)" perl Makefile.PL $(MAKEMAKER_OPTIONS) Can you do an export on a separate line (like TOPDIR), for readability if/when more env vars needed? cheers. -- Nathan From kenj@internode.on.net Thu Sep 24 16:02:15 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n8OL2EhE110860 for ; Thu, 24 Sep 2009 16:02:14 -0500 X-ASG-Debug-ID: 1253826211-24aa015c0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 7758847C284 for ; Thu, 24 Sep 2009 14:03:31 -0700 (PDT) Received: from mail.internode.on.net (bld-mail19.adl2.internode.on.net [150.101.137.104]) by cuda.sgi.com with ESMTP id 1iuypSHzHKd6RFZo for ; Thu, 24 Sep 2009 14:03:31 -0700 (PDT) Received: from [192.168.1.100] (unverified [118.208.169.2]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 5597641-1927428 for ; Fri, 25 Sep 2009 06:33:30 +0930 (CST) X-ASG-Orig-Subj: pcp qa and mmv pmda Subject: pcp qa and mmv pmda From: Ken McDonell Reply-To: kenj@internode.on.net To: pcp@oss.sgi.com Content-Type: text/plain Date: Fri, 25 Sep 2009 07:03:20 +1000 Message-Id: <1253826200.22439.5.camel@bozo> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail19.adl2.internode.on.net[150.101.137.104] X-Barracuda-Start-Time: 1253826213 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.9884 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Are tests 647 and 648 expected to be passing with the current 2.9.2 pcp code? Both are failing for me, and I see this sort of badness in the mmv pmda's log ... Log for pmdammv on bozo started Fri Sep 25 06:51:30 2009 [Fri Sep 25 06:51:30] pmdammv(30314) Info: pmdammv: pmdaInit - 1 metrics and 0 indoms [Fri Sep 25 06:51:33] pmdammv(30314) Info: pmdammv: reloading [Fri Sep 25 06:51:33] pmdammv(30314) Info: pmdammv: loading mmv client: 1 "/var/tmp/mmv/test" [Fri Sep 25 06:51:33] pmdammv(30314) Info: pmdammv: 7 metrics and 2 indoms after reload /usr/share/pcp/lib/ReplacePmnsSubtree: 1: 1: not found /usr/share/pcp/lib/ReplacePmnsSubtree: 1: 1: not found /usr/share/pcp/lib/ReplacePmnsSubtree: 1: 1: not found /usr/share/pcp/lib/ReplacePmnsSubtree: 1: 1: not found /usr/share/pcp/lib/ReplacePmnsSubtree: 1: 1: not found /usr/share/pcp/lib/ReplacePmnsSubtree: 1: 1: not found [Fri Sep 25 06:51:56] pmdammv(30314) Info: pmdammv: reloading [Fri Sep 25 06:51:56] pmdammv(30314) Info: pmdammv: loading mmv client: 1 "/var/tmp/mmv/test" [Fri Sep 25 06:51:56] pmdammv(30314) Info: pmdammv: 7 metrics and 2 indoms after reload after which we seem to be stuck forever in this mode $ pminfo -f mmv mmv.reload: pmLookupDesc: Try again. Information not currently available From nscott@aconex.com Thu Sep 24 18:09:31 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n8ON9Uda116490 for ; Thu, 24 Sep 2009 18:09:30 -0500 X-ASG-Debug-ID: 1253833848-247803080000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id BE97947CAF9 for ; Thu, 24 Sep 2009 16:10:48 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id Mt0a5HRU33KdUpb4 for ; Thu, 24 Sep 2009 16:10:48 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 1D9BC827018; Fri, 25 Sep 2009 09:10:46 +1000 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id bE7ysItqMmzyDSuv; Fri, 25 Sep 2009 09:10:46 +1000 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 43233A500A6; Fri, 25 Sep 2009 09:09:33 +1000 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 091444FD84; Fri, 25 Sep 2009 09:10:46 +1000 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at gatekeeper.yarra.acx Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id piO7dLleFwZg; Fri, 25 Sep 2009 09:10:41 +1000 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 437024FD82; Fri, 25 Sep 2009 09:10:41 +1000 (EST) Date: Fri, 25 Sep 2009 09:10:41 +1000 (EST) From: Nathan Scott To: kenj@internode.on.net Cc: pcp@oss.sgi.com Message-ID: <1895056662.11141253833841146.JavaMail.root@mail-au.aconex.com> In-Reply-To: <1283680606.11121253833677398.JavaMail.root@mail-au.aconex.com> X-ASG-Orig-Subj: Re: [pcp] pcp qa and mmv pmda Subject: Re: [pcp] pcp qa and mmv pmda MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1253833849 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.9892 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ----- "Ken McDonell" wrote: > Are tests 647 and 648 expected to be passing with the current 2.9.2 > pcp code? 647 should pass, 648 is notrun atm (has some complex indom handling tests that aren't implemented in current pmdammv - on my todo list). > [Fri Sep 25 06:51:33] pmdammv(30314) Info: pmdammv: 7 metrics and 2 > indoms after reload > /usr/share/pcp/lib/ReplacePmnsSubtree: 1: 1: not found This'd be your root cause. > $ pminfo -f mmv > mmv.reload: pmLookupDesc: Try again. Information not currently available Just checked, and it works for me. There is some conditional code in MMV PMDA - see HAVE_MKSTEMP in write_pmnsfile() - perhaps you're going through the alternate path to me (that MACRO is set on my dev box)? cheers. -- Nathan From kenj@internode.on.net Sun Sep 27 01:49:28 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n8R6nR5E029550 for ; Sun, 27 Sep 2009 01:49:27 -0500 X-ASG-Debug-ID: 1254034245-38b902cb0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id B8B3F16F2831 for ; Sat, 26 Sep 2009 23:50:45 -0700 (PDT) Received: from mail.internode.on.net (bld-mail13.adl6.internode.on.net [150.101.137.98]) by cuda.sgi.com with ESMTP id fIGDNE39xf26gTPH for ; Sat, 26 Sep 2009 23:50:45 -0700 (PDT) Received: from [121.214.139.198] (unverified [121.214.139.198]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 5848406-1927428 for multiple; Sun, 27 Sep 2009 16:20:43 +0930 (CST) X-ASG-Orig-Subj: Re: [pcp] pcp qa and mmv pmda [and PMDA_INTERFACE_4 heads up] Subject: Re: [pcp] pcp qa and mmv pmda [and PMDA_INTERFACE_4 heads up] From: Ken McDonell Reply-To: kenj@internode.on.net To: Nathan Scott Cc: pcp@oss.sgi.com In-Reply-To: <1895056662.11141253833841146.JavaMail.root@mail-au.aconex.com> References: <1895056662.11141253833841146.JavaMail.root@mail-au.aconex.com> Content-Type: text/plain Date: Sun, 27 Sep 2009 16:37:40 +1000 Message-Id: <1254033460.4466.5.camel@bozo-laptop.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail13.adl6.internode.on.net[150.101.137.98] X-Barracuda-Start-Time: 1254034247 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.10115 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Hmm ... the real problem was in ReplacePmnsSubtree where the trap and signal handling was fatally broken ... but needed a stale lock file to expose the problem. Which explains the "works for me" syndrome. I have a patch for this, but it is on the tail end of the monster PMDA_INTERFACE_4 (dynamic subtree in the PMNS) patch that is about to be committed to my oss.sgi.com tree. On Fri, 2009-09-25 at 09:10 +1000, Nathan Scott wrote: > ----- "Ken McDonell" wrote: > > > Are tests 647 and 648 expected to be passing with the current 2.9.2 > > pcp code? > > 647 should pass, 648 is notrun atm (has some complex indom handling > tests that aren't implemented in current pmdammv - on my todo list). > > > [Fri Sep 25 06:51:33] pmdammv(30314) Info: pmdammv: 7 metrics and 2 > > indoms after reload > > /usr/share/pcp/lib/ReplacePmnsSubtree: 1: 1: not found > > This'd be your root cause. > > > $ pminfo -f mmv > > mmv.reload: pmLookupDesc: Try again. Information not currently available > > Just checked, and it works for me. There is some conditional code in MMV > PMDA - see HAVE_MKSTEMP in write_pmnsfile() - perhaps you're going through > the alternate path to me (that MACRO is set on my dev box)? > > cheers. > From kenj@internode.on.net Sun Sep 27 01:49:34 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_33, J_CHICKENPOX_41,J_CHICKENPOX_63,J_CHICKENPOX_73,URIBL_BLACK autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n8R6nXW2029567 for ; Sun, 27 Sep 2009 01:49:33 -0500 X-ASG-Debug-ID: 1254034248-6b2602a00000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 739EC48208A for ; Sat, 26 Sep 2009 23:50:48 -0700 (PDT) Received: from mail.internode.on.net (bld-mail17.adl2.internode.on.net [150.101.137.102]) by cuda.sgi.com with ESMTP id 2Sq0Ta1GCsRyCraJ for ; Sat, 26 Sep 2009 23:50:48 -0700 (PDT) Received: from [121.214.139.198] (unverified [121.214.139.198]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 5713568-1927428 for ; Sun, 27 Sep 2009 16:20:45 +0930 (CST) X-ASG-Orig-Subj: Dynamic PMNS changes finally arrive Subject: Dynamic PMNS changes finally arrive From: Ken McDonell Reply-To: kenj@internode.on.net To: pcp@oss.sgi.com Content-Type: text/plain Date: Sun, 27 Sep 2009 16:50:50 +1000 Message-Id: <1254034250.4466.12.camel@bozo-laptop.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail17.adl2.internode.on.net[150.101.137.102] X-Barracuda-Start-Time: 1254034251 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0024 1.0000 -2.0053 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.01 X-Barracuda-Spam-Status: No, SCORE=-1.01 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M, BSF_RULE_7582B X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.10115 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M 0.50 BSF_RULE_7582B Custom Rule 7582B X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Committed to the *master* branch of my PCP tree on oss.sgi.com There are several rounds of commits for this set of changes that became much more complicated and touched more files than I'd originally expected. This all passes my QA ... after I get some feedback on the PCP changes I'll move the QA tree forward. In the logs below there are lots of changes from the *master* and *dev* branches (this is a mess we need to sort out pronto!). Only the ones authored by me are really part of this batch of commmits, the others are innocent bystanders as a result of the passage of time. Changes committed to git://oss.sgi.com/kenj/pcp.git master .gitignore | 2 CHANGELOG | 33 + VERSION.pcp | 10 build/GNUmakefile | 3 build/rpm/pcp.spec.in | 39 +- build/rpm/pcp_fedora.spec | 385 +++++++++++++++++----- build/sun/GNUmakefile | 53 ++- configure.in | 99 ++++- debian/changelog | 21 + debian/control | 72 ++-- man/man1/GNUmakefile | 1 man/man1/newhelp.1 | 24 + man/man1/pmcd.1 | 6 man/man1/pmdaib.1 | 113 ++++++ man/man1/pmval.1 | 27 + man/man3/pmda.3 | 15 man/man3/pmdachildren.3 | 139 +++++++- man/man3/pmdamain.3 | 84 +++- man/man3/pmdaname.3 | 91 +++++ man/man3/pmdapmid.3 | 89 ++++- man/man4/pmns.4 | 45 +- src/cpan/MMV/Changes | 7 src/cpan/MMV/MMV.pm | 6 src/cpan/MMV/MMV.xs | 41 +- src/cpan/MMV/server.pl | 17 src/cpan/PMDA/Changes | 8 src/cpan/PMDA/PMDA.pm | 6 src/cpan/PMDA/PMDA.xs | 39 +- src/cpan/PMDA/local.c | 3 src/dbpmda/src/GNUmakefile | 2 src/dbpmda/src/dbpmda.c | 64 +++ src/dbpmda/src/dbpmda.h | 2 src/dbpmda/src/dso.c | 205 +++++++++-- src/dbpmda/src/gram.y | 43 ++ src/dbpmda/src/lex.l | 30 - src/dbpmda/src/pmda.c | 130 ++++++- src/dbpmda/src/util.c | 20 + src/genpmda/genpmda | 4 src/include/builddefs.in | 13 src/include/impl.h | 31 + src/include/mmv_stats.h | 2 src/include/pmda.h | 73 +++- src/libpcp/src/.gitignore | 3 src/libpcp/src/desc.c | 11 src/libpcp/src/fetchlocal.c | 28 + src/libpcp/src/help.c | 11 src/libpcp/src/instance.c | 46 +- src/libpcp/src/p_pmns.c | 2 src/libpcp/src/pmns.c | 139 ++++++-- src/libpcp/src/store.c | 14 src/libpcp/src/util.c | 34 + src/libpcp_gui/src/.gitignore | 3 src/libpcp_gui/src/GNUmakefile | 2 src/libpcp_mmv/src/.gitignore | 1 src/libpcp_mmv/src/mmv_stats.c | 65 ++- src/libpcp_pmcd/src/.gitignore | 1 src/libpcp_pmda/src/.gitignore | 1 src/libpcp_pmda/src/callback.c | 45 ++ src/libpcp_pmda/src/help.c | 2 src/libpcp_pmda/src/libdefs.h | 3 src/libpcp_pmda/src/mainloop.c | 261 ++++++++++++--- src/libpcp_pmda/src/open.c | 133 ++++--- src/libpcp_trace/src/.gitignore | 3 src/newhelp/chkhelp.c | 6 src/newhelp/newhelp.c | 50 ++ src/pmcd/GNUmakefile | 5 src/pmcd/migrate_pcp_var_dir | 126 ------- src/pmcd/pmdaproc.sh | 242 +++++++------ src/pmcd/rc_pcp | 14 src/pmcd/src/config.c | 163 +++++++-- src/pmcd/src/dofetch.c | 57 ++- src/pmcd/src/dopdus.c | 660 ++++++++++++++++++++++++++++++++------ src/pmcd/src/dostore.c | 14 src/pmcd/src/pmcd.h | 8 src/pmcd/src/pmcd.log | 198 +++++------ src/pmcd/src/sample.log | 4 src/pmcd/src/sendmail.log | 4 src/pmcd/src/simple.log | 4 src/pmcd/src/trace.log | 4 src/pmdas/GNUmakefile | 7 src/pmdas/ib/daemon.c | 20 - src/pmdas/ib/dso.c | 2 src/pmdas/ib/ib.c | 283 +++++++++------- src/pmdas/ib/ibpmda.h | 4 src/pmdas/ib/pmda.c | 4 src/pmdas/linux/proc_cpuinfo.c | 38 -- src/pmdas/linux/proc_cpuinfo.h | 1 src/pmdas/linux/proc_loadavg.c | 7 src/pmdas/mmv/.gitignore | 5 src/pmdas/mmv/GNUmakefile | 28 - src/pmdas/mmv/Install | 6 src/pmdas/mmv/Remove | 5 src/pmdas/mmv/mmv.c | 103 +++-- src/pmdas/mysql/pmdamysql.pl | 3 src/pmdas/named/.gitignore | 2 src/pmdas/named/GNUmakefile | 45 ++ src/pmdas/named/Install | 32 + src/pmdas/named/Remove | 25 + src/pmdas/named/pmdanamed.pl | 155 ++++++++ src/pmdas/pdns/.gitignore | 2 src/pmdas/pdns/GNUmakefile | 45 ++ src/pmdas/pdns/Install | 27 + src/pmdas/pdns/Remove | 25 + src/pmdas/pdns/pmdapdns.pl | 194 ++++++++++- src/pmdas/pmcd/src/pmcd.c | 12 src/pmdas/samba/.gitignore | 2 src/pmdas/samba/GNUmakefile | 49 ++ src/pmdas/samba/Install | 43 ++ src/pmdas/samba/Remove | 25 + src/pmdas/samba/pmdasamba.pl | 205 +++++++++++ src/pmdas/sample/help | 24 + src/pmdas/sample/pmns | 1 src/pmdas/sample/src/pmda.c | 2 src/pmdas/sample/src/sample.c | 362 ++++++++++++++++++-- src/pmdas/simple/pmdasimple.pl | 6 src/pmdas/solaris/GNUmakefile | 15 src/pmdas/solaris/common.h | 14 src/pmdas/solaris/data.c | 212 +++++++++++- src/pmdas/solaris/help | 95 +++++ src/pmdas/solaris/netmib2.c | 344 +++++++++++++++++++ src/pmdas/solaris/netmib2.h | 62 +++ src/pmdas/solaris/pmns.network | 31 + src/pmdas/solaris/pmns.zfs | 15 src/pmdas/solaris/pmns.zpool | 20 + src/pmdas/solaris/root | 5 src/pmdas/solaris/solaris.c | 7 src/pmdas/solaris/zfs.c | 164 ++++++++- src/pmdas/solaris/zpool.c | 226 ++++++++++--- src/pmdas/trace/GNUmakefile | 3 src/pmdas/trace/GNUmakefile.demos | 2 src/pmdas/trace/GNUmakefile.stub | 2 src/pmdas/windows/fetch.c | 91 ++--- src/pmdas/windows/libpdh.def | 1 src/pmdas/windows/libpdh.h | 20 + src/pmdas/windows/open.c | 13 src/pmdas/windows/pmda.c | 32 + src/pmdas/windows/pmns.kernel | 1 src/pmie/rc_pmie | 12 src/pmie/src/GNUmakefile | 2 src/pmlc/GNUmakefile | 2 src/pmlogextract/GNUmakefile | 2 src/pmlogger/GNUmakefile | 2 src/pmlogger/pmlogger.c | 3 src/pmns/Make.stdpmid | 8 src/pmns/ReplacePmnsSubtree | 8 src/pmns/pmnsutil.c | 5 src/pmns/stdpmid.pcp | 8 src/pmpost/GNUmakefile | 2 src/pmproxy/rc_pmproxy | 12 src/pmval/pmval.c | 55 ++- 150 files changed, 6178 insertions(+), 1581 deletions(-) commit 52872f6b735fbf7814443f226df21eee30b35936 Author: Ken McDonell Date: Sun Sep 27 16:30:09 2009 +1000 ReplacePmnsSubtree fix bad signal handling botch The trap handling was totally wrong in cleanup() ... causing the command "1" to be executed instead of the null command "". Exposed by another bug in a related area ... if the PMNS lock exists already, after the timeout in pmlock we fall into the trap cleanup() routine instead of charing on, so the script fails horribly (and leaves the stale lock file around). Also fixed an unlikely buffer over-run in mmv.c. commit 4087051b86b580d7c7cb6e50806edb4eaa63e4d4 Author: Ken McDonell Date: Sun Sep 27 15:20:24 2009 +1000 newhelp, dbpmda, libpcp, libpcp_pmda, pmcd, sample pmda - dynamic PMNS changes This is the final round of changes that get all of the changes for PMDA_INTERFACE_4 and the support of dynamic subtress of the PMNS where the PMDA (not PMCD) maintains knowledge of the PMNS. With these changes and a related round of QA changes, we're passing all of the QA tests (excluding the remote group that I cannot test at the moment, but are unlikely to find problems in this code). commit 40e120d100d8f8f2a638124edef1ac2a16c0b975 Author: Ken McDonell Date: Sun Sep 27 15:18:33 2009 +1000 pmdaproc.sh Revert changes for perl pmda setup. Just put it back the way it was before I started messing with it! commit 4cead6907bf315ed009725db26659d3c6e12c698 Author: Ken McDonell Date: Sun Sep 27 15:11:44 2009 +1000 pmdaproc.sh tweaking to improve QA success Add delays after sending pmcd SIGHUP and before checking for pmcd health to avoid small window where badness happens to pmcd from new PMDA, but after the test has been done. Also wound back previous Perl PMDA setup change as it does not help the QA test for the news PMDA ... reworked the QA test instead! commit 9371a85a8a5b65b43be732e585e1b8f98f4b94e1 Author: Ken McDonell Date: Thu Sep 24 16:59:07 2009 +1000 Only remake pmns file if it does not exist. Part of the perl PMDA support was unconditionally remaking pmns and domain.h ... this was reordering the metrics for the simple PMDA and causing QA tests 255 and 578 to fail ... more importantly if the pmns file already exists then there is no point in using the perl PMDA magic to recreate it. commit 4f6a801b054f92b23064385940a441bc66b758bd Merge: e421a49... 11549ac... Author: Ken McDonell Date: Thu Sep 17 20:00:33 2009 +1000 Merge branch 'master' of git://oss.sgi.com/kenj/pcp Conflicts: CHANGELOG VERSION.pcp src/pmcd/rc_pcp src/pmie/rc_pmie src/pmproxy/rc_pmproxy commit 11549aca86588c4695d26829e02f2ec9e7b43c3d Author: Nathan Scott Date: Mon Sep 7 16:29:34 2009 +1000 Bump pcp stable version to 2.9.2. commit 7997eea93ad9c240d2cbc7c2bfbd9ae21bb29e35 Author: Ken McDonell Date: Mon Sep 7 11:59:21 2009 +1000 Fix the number-of-samples value calculated in pmval once and for all. For those who care, it turns out that the number of _fetches_ may be known, the number of _reported_ samples cannot be precomputed correctly in all cases ... - only works for archives with -a (not -U or -h) - is known for non-counter metrics - most of the time is known for counter metrics but there are some important corner cases where this is not the case, specifically there will be one more reported sample than expected for a counter when the report starting time is not at the start of the archive and the metric has a defined value before the report starting time with no intervening mark record (interpolate mode does return a value at the first report sample in this case!). With this pmval patch, the QA fallout is nil, except for 144 that is an unrelated timezone problem. Also this patch avoids referencing the context too soon, as there is no point in inspecting the metric's semantics to try and better guess the value of smpls. As a bonus, this patch also documents pmval's -U option that has remained a secret for nearly a decade. commit f4e6d55fd0466a706144ca61b4428436ecea7eb7 Author: Nathan Scott Date: Mon Sep 7 11:51:58 2009 +1000 Attempt to resolve sys/stat related build issue on Alpha. Not having access to an Alpha makes this difficult, but one thing that is clearly not helping is that with Linux glibc on Alpha, we end up defining *both* HAVE_STAT_TIMESPEC and HAVE_STAT_TIME_T, & that breaks otherwise valid pmns.c coding assumptions. This change means only one type for the stat time fields can be defined, and it errs on the side of timespec (which should be the one Alpha uses, AFAICT) - so perhaps this issue will finally be resolved and PCP can progress in the Debian build/release system. commit be8793c58935362184a1dd4351388ca6a0013f3b Author: Nathan Scott Date: Mon Sep 7 11:26:09 2009 +1000 Fix mmv library build on mac/win - missing a header. commit 92eb7b896ff6eb83b2feef50e6a89c74c3aa1717 Author: Nathan Scott Date: Fri Sep 4 14:17:37 2009 +1000 Bump pcp stable version to 2.9.1. commit 2e890f3d1d9c4af31fc22af95cb7e0f20336523e Author: Nathan Scott Date: Fri Sep 4 14:15:16 2009 +1000 Correct pmval sample count calculation. Martin reported several QA tests were failing wrt pmval "samples" line. What I've found is the problem either exists/doesn't exist depending on several factors: - running on a 32 bit machine, Debian unstable, the problem never occurs no matter how pmval is built. - running on a 64 bit machine, Debian unstable, the problem only happens with the packaged binaries. The key factor appears to be the introduction of -O2, which looks like it reliably changes certain values on the stack, that would otherwise be zero (used uninitialised, in either case). There's two problems here, I believe: - in pmval.c the getargs() call initialises the value of "smpls" (number of samples to take) based on cntxt->desc.sem. However, at that point, we have not established a context yet, and so that field is uninitialised. - this test doesn't match the comment above it, and doesn't make sense: /* counters require 2 samples to produce reported sample */ if (*smpls > 0 && cntxt->desc.sem != PM_SEM_COUNTER) that would seem to me that it should be "cntxt->desc.sem == PM_SEM_COUNTER". commit 6940bbf89ca10d395fff93eeb7ce7424cec5d2ad Merge: b7bb608... 350246f... Author: Nathan Scott Date: Fri Sep 4 14:08:24 2009 +1000 Merge branch 'dev' of git://oss.sgi.com/nathans/pcp into dev commit 350246f0ba359876660994823d2e37b864040c3f Author: Nathan Scott Date: Thu Sep 3 12:59:57 2009 +1000 Another pass at getting the perl/debian packaging auto-deps right. commit 91c9f4a0a06d8e300c23f49feab09141c488b0f5 Author: Nathan Scott Date: Thu Sep 3 12:59:24 2009 +1000 Correct mmv install targets makefile macro. commit bf33333edbcf48ee84dad07cace240d6aff6cc99 Author: Nathan Scott Date: Wed Sep 2 15:07:19 2009 +1000 Workaround another oddity in (very) recent versions of autoconf. Problem found by the Debian autobuilders, in the pcp-gui build but it affects pcp too. Latest versions of autoconf evaluate AC_PROG_LEX in the compiler check macro, and complete remove any trace of AC_PROG_LEX from its original callsite. This results in a syntax error inside our configure script, as we call it within if ... fi, which then evaluates to having no body to the if. Ugh. Fix is trivial though, since these macros do the user-env-variable expansion thing already. commit efcb3b590f086feb1507f82716d2f0b6eee69d33 Author: Petter Reinholdtsen Date: Wed Sep 2 14:38:34 2009 +1000 Add missing dependencies and runlevels into PCP start scripts. With dependency based boot sequencing, I discovered what I believe is a bug in the init.d scripts of this package. The list of runlevels to stop in is incomplete. The script should stop in runlevel 1 to make sure the service is started again when switching from runlevel 1 to 2-5. Also, the script should probably stop during halt (0) and reboot (6). The package should start in runlevel 4, just like in runlevels 2, 3 and 5. I suspect the list of dependencies are incomplete. The scripts used to start after the syslog collector was operational, and should probably continue to do so. Also, the scripts need files in /usr/ and should depend on $remote_fs. If the scripts themselves need to start in any specific order, the relationship should be listed explicitly in the LSB header too. Make sure the update-rc.d calls in the postinst reflect this ordering if any such dependencies should exist. This patch implement the proposed change. Without it, the script seem to fail to handle runlevel 0, 1, 4 and 6 properly, and might start too early in the boot. commit 4aa31ed00a60c3926a53bbd8d47aa0b2eaf254c4 Merge: 35c230e... 3323bb9... Author: Nathan Scott Date: Wed Sep 2 13:18:44 2009 +1000 Merge branch 'dev' of git://oss.sgi.com/nathans/pcp into dev commit b7bb60801c2fc342b15473f1e3b341dd8ec7b84a Author: Nathan Scott Date: Wed Sep 2 12:38:19 2009 +1000 Update gitignore files for Mac and Windows library file names. commit 3323bb90ad5f66480c05b7fe182a72a0813c9b41 Author: Nathan Scott Date: Wed Sep 2 12:30:47 2009 +1000 Fix a segv observed in the Windows PMDA accessing SQL Server metrics. The recent optimisation added for direct instance domain lookup added a flaw that could case an array index of -1 to be used to access into the metric value table. Observed on SQL Server 2008 & Windows Server 2008 R2 only so far. commit 1112ac636cae6feac624279c76239003662d4a35 Author: Nathan Scott Date: Wed Sep 2 11:49:20 2009 +1000 Small MMV pmda changes to allow DSO builds in the future. Turns out that the current protocol for getting pmcd to update its namespace cannot be used from DSO agents ... one more reason to revamp this area. commit 677c6f2cea7fce4ff5f10f939fc5a942861719dd Author: Nathan Scott Date: Wed Sep 2 11:46:40 2009 +1000 Fix logic error causing wrong windows version to be reported. commit e421a49323307d49f6b897ae87f94c934b6fdcad Author: Ken McDonell Date: Tue Sep 1 17:44:22 2009 +1000 Interim commit for start of daemon PMDA support for dynamic PMNS. commit 210be7f679b10d71dda985fdebc7dd9aec5d606a Author: Nathan Scott Date: Fri Aug 28 08:44:50 2009 +1000 Correct some regular expressions in Samba PMDA. Of particular note, some of the heading lines in the smbstatus --profile output have trailing whitespace. Otherwise, this PMDA is now fully functional; and as it used the stock Samba utilities, is not dependent on the many flavours of Samba shmem format anymore. At the cost of a slight overhead increase, of course, but the original was unmaintainable. Thanks to James Peach for advise on redesigning this. commit 0758690bcbbf26db438560d5b5b94b1644979047 Author: Nathan Scott Date: Thu Aug 27 14:26:32 2009 +1000 Descend into samba PMDA during the build (SUBDIRS update). commit 9e758dd286ee2c49ecd991599a4c87a5520b9892 Author: Nathan Scott Date: Thu Aug 27 14:25:18 2009 +1000 Add kernel.all.uptime to the Windows kernel agent. This code uses the PdhGetFormatterCounterValue API, which we have not used before on Windows, hence the changes to libpdh header and dll definition files. commit b0cbeab4df3aec93a2f9749c7912dc8adc0b27ea Author: Nathan Scott Date: Thu Aug 27 10:21:28 2009 +1000 Rearrange platform-specific handling in pmdaproc.sh. Keep everything that does platform-specific stuff in one place now, run early on, instead of all over the shop. The code that handles determining whether the PCP::PMDA Perl module is installed is also reworked to not fail in the case where perl_opt is set, but user doesn't select that option when Install'ing a PMDA. This bit Mark with the simple PMDA, which has both Perl and C variants. commit ac9170cf888639cc731474d39cb100e9d7b2c519 Author: Nathan Scott Date: Thu Aug 27 09:20:14 2009 +1000 Initial version of the (perl-based) Samba PMDA. commit e00aafe76a538ad09322499c2f669450d3b0c486 Author: Nathan Scott Date: Wed Aug 26 11:46:12 2009 +1000 Fix inconsistent metric name in pmdasimple.pl - simple.now was wrong. commit e937d8332c9dc6a0f4d5ea5fb10b6d3530b7261b Author: Nathan Scott Date: Wed Aug 26 11:02:55 2009 +1000 Remove hard-coded path in the perl variant of the simple PMDA (thanks Mark). commit 531de7440179d323c8774fad2a4c13ac4c21bcbb Author: Nathan Scott Date: Wed Aug 26 11:00:00 2009 +1000 Use PM_IN_NULL in pmdasimple.pl so it functions correctly on all platforms. commit 956be698fe2de60b96c2c6fa72be1555a1c3cf7c Merge: 7bf0f27... b8cb2dd... Author: Nathan Scott Date: Mon Aug 24 10:58:57 2009 +1000 Merge branch 'dev' of git://oss.sgi.com/nathans/pcp into dev commit 7bf0f27d27c11db4002699e74611ef718551add3 Merge: 309e7be... 3db8e4f... Author: Nathan Scott Date: Mon Aug 24 10:57:30 2009 +1000 Merge branch 'solaris' of git://oss.sgi.com/makc/pcp into dev commit 309e7be90719ebc12bc66e9a06999909e7f66c16 Author: Nathan Scott Date: Mon Aug 24 09:03:19 2009 +1000 Add PCP::PMDA helper routines for determining native long sizes. commit 90e8cd865a6bfabf91315feea3743054a1511111 Author: Nathan Scott Date: Mon Aug 24 09:01:38 2009 +1000 Extend MMV to allow teardown of MMV file, and set errno on failure. Setting errno helps alot with diagnosing mmv_stats_init() failures. commit d4732eb5d60d8d31bb6eba69daa2787befb34325 Author: Nathan Scott Date: Mon Aug 24 08:56:24 2009 +1000 Initial stable (1.00) version of MMV Perl interface. Changes include: - added stop interface - added stats_set interface - fixed incorrect memory free on init - extend server.pl example to report idle time - fixed use of av_len return codes (off by one) commit 3db8e4f3626241cb40e52f36a691263c8aaa34ff Author: Max Matveev Date: Mon Aug 17 18:52:49 2009 +1000 Release zpool resources when finished updates It's not documented but it's obvious that zpool_iter expects the callback to call zpool_close to release resources associated with the zpool - it's not a problem for short-lived commands like zpool(1) but it leaks memory like a firehose. commit 35c230ef34a191bbb5b8f12b91d122e2863ac740 Author: Nathan Scott Date: Fri Aug 14 14:58:10 2009 +1000 Correct the metric units for several Windows per-process memory metrics. commit 758b2b7039e878189b42fab6d8d3a789a27810d1 Author: Max Matveev Date: Wed Aug 12 00:01:59 2009 +1000 Eliminate incidents of crime against whitespace commit 012af5fa4e16029513c6d1c2ff7c7a3d4a3069e3 Author: Max Matveev Date: Tue Aug 11 23:55:59 2009 +1000 Hide instances for destroyed pools and filesystems In Solaris PMDA if a zpool or a zfs is removed make sure that the corresponding instance disappears from the list of instances returned on fetch. commit a8cbf7b86b1bab119246006b23b1114fe1b4b9d7 Author: Ken McDonell Date: Fri Aug 7 11:22:23 2009 +1000 Revert __pmProcessTerminate() change. Since perl PMDAs are now all running in their own process group revert to allow kill(0, ...) to proceed. commit 8ea858d245d093ed3285e0e4370303bd678cc468 Merge: 9b4b935... ead91ff... Author: Ken McDonell Date: Thu Aug 6 18:35:49 2009 +1000 Merge branch 'dev' into pmns commit 9b4b9351a7e41bc21f893063e0311accd7cee046 Author: Ken McDonell Date: Thu Aug 6 18:18:10 2009 +1000 Guard in _pmProcessTerminate() to prevent killing all member of process group. Problem exposed by qa/162 and perl implementation of news pmda. commit 7f72e4acff1b876b10e6f6432a55de2e49b9e148 Author: Ken McDonell Date: Thu Aug 6 18:16:49 2009 +1000 Second round of changes for PMDA_INTERFACE_4 dynamic metrics. DSO mode PMDAs (sampledso) is very close to working correctly now. commit ead91ffca2605502c3552ffbc228ffbc0ed3ecc3 Author: Mark Goodwin Date: Thu Aug 6 12:14:25 2009 +1000 update changelog and delete unncessary Vendor string Signed-off-by: Mark Goodwin commit b77cb57bb669b1129c1241f7818fe75935390a3b Author: Mark Goodwin Date: Thu Aug 6 12:06:23 2009 +1000 also bump the src tarball version Signed-off-by: Mark Goodwin commit 6c8311051895092662b8ee1986945a3846577b04 Author: Mark Goodwin Date: Thu Aug 6 12:01:24 2009 +1000 bump to 3.0.0-2 Signed-off-by: Mark Goodwin commit 99aa1c21c22e64350ba750284039653750633540 Merge: ef9852c... f2866c9... Author: Mark Goodwin Date: Thu Aug 6 11:37:29 2009 +1000 merge pcp-2.9.0-1 dev modified: CHANGELOG modified: build/rpm/pcp.spec.in modified: debian/changelog modified: debian/control modified: src/cpan/PMDA/PMDA.xs modified: src/libpcp_pmda/src/open.c modified: src/pmcd/src/config.c modified: src/pmdas/GNUmakefile modified: src/pmdas/mysql/pmdamysql.pl new file: src/pmdas/pdns/.gitignore new file: src/pmdas/pdns/GNUmakefile new file: src/pmdas/pdns/Install new file: src/pmdas/pdns/Remove new file: src/pmdas/pdns/pmdapdns.pl modified: src/pmlogger/pmlogger.c modified: src/pmns/stdpmid.pcp Signed-off-by: Mark Goodwin commit ef9852c99666359cdacb1afe65dcac16460ea0ab Author: Mark Goodwin Date: Thu Aug 6 11:05:12 2009 +1000 Changes to the Fedora RPM spec in response to review feedback: - Incorporate a large number of suggestions and cleanups from Eric Sandeen - Greatly simplified the %post and %postun scriptlets - remove ancient crud - Added ldconfig scriptlets for -libs - Don't explicitly require IB libs, since they're libs and RPM figures it out - No need to explicitly BuildRequire gcc-c++ libstdc++-devel - Add BuildRequires on perl-ExtUtils-MakeMaker - Remove explicit ia64 Requires: libunwind - Have pcp-libs require the base package since Fedora insists - Add and clarify some comments - Create %{_localstatedir}/run/pcp and ship it (so it'll be removed) - Use %doc for CHANGELOG COPYING INSTALL README VERSION.pcp pcp.lsm Signed-off-by: Mark Goodwin commit 88c3b113c45f61d8959b95f0486d5d625b8c85af Author: Mark Goodwin Date: Thu Aug 6 10:17:51 2009 +1000 git ignore generated gram*.tab.c Signed-off-by: Mark Goodwin commit 0fe594271c4635432616eaec4640b38773d150cc Author: Mark Goodwin Date: Thu Aug 6 10:12:55 2009 +1000 preserve generated gram.tab.c because debuginfo needs it Signed-off-by: Mark Goodwin commit 385ce8e19c550792fd61a4e6112408c208b75649 Author: Mark Goodwin Date: Thu Aug 6 09:21:48 2009 +1000 fix minor typo in comment Signed-off-by: Mark Goodwin commit b8cb2dd7c9b5d33e473bf0d89a64da3c2b2eec92 Merge: 1c47a24... 684232a... Author: Nathan Scott Date: Wed Aug 5 16:52:11 2009 +1000 Merge branch 'solaris' of git://oss.sgi.com/makc/pcp into dev commit 1c47a24dbef502d09439e663b727a2bf85e5499d Author: Nathan Scott Date: Wed Aug 5 16:51:47 2009 +1000 Ignore all MMV files that begin with a period. commit 4bc076258e025f86b6215783933f7adcb77ace90 Author: Max Matveev Date: Wed Aug 5 02:10:37 2009 +1000 Add network metrics to Solaris PMDA Use MIB2 interface available via TI to extract IPv4 interfaces and UDP stats from the kernel. The good/bad fetch is on the whole group - if any of the sources fail (even if we don't use them like IPv6 interface stats) then whole fetch will return no data. Fetch callback still uses offset for the metrics which have indoms, for singular metrics a pointer to the global storage is used whence the change of type in md_offset. commit 4e1e119bfb7cfa6d09c81049fec95d3dc9e13356 Author: Mark Goodwin Date: Tue Aug 4 12:19:07 2009 +1000 dont install trace demo binaries since src is installed anyway Signed-off-by: Mark Goodwin commit 234ffe3f3badbf73768f114fa692eac0dd7ec079 Author: Max Matveev Date: Mon Aug 3 10:33:41 2009 +1000 Report ZFS statistics from Solaris PMDA Use libzfs interfaces to extract some data about ZFS "dataset". Datasets are filesystems, snapshots and volumes, the reported data include information about used and available space, compression ratios, number of copies, reserved space per dataset. Space utilization is additionally broken down into space used by children, space used by snapshot and space used by the dataset itself. commit 5da67384ae7719254afd7d76d8b10558b9d3de07 Author: Max Matveev Date: Mon Aug 3 01:59:01 2009 +1000 Export zpool stats from Solaris PMDA Use libzfs to extract zpool stats like capacity, iops, bandwidth etc commit 684232a1b6178de4a07edbd0e3308f49789992fb Author: Max Matveev Date: Sun Aug 2 23:05:11 2009 +1000 Put 64 bit libraries into the right place on Solaris Solaris keeps its 64 bit shared libraries in /usr/lib/64 - use the pointer size to decide if we're building 32 or 64 bit version and push the library in the right place. commit 3cf745f62c0099577265994de97c0a755cb06f9b Author: Max Matveev Date: Sun Aug 2 04:11:32 2009 +1000 Generate packages for Solaris commit 74c7543c88bc3776b81ae8a5eab4de940537ffdd Author: Max Matveev Date: Sun Aug 2 03:03:35 2009 +1000 Allow user to choose her compiler New autoconf attempts to compile the headers as part of AC_HEADER_CHECK. It AC_PROG_CC is not called then AC_HEADER_CHECK generates scary warning - just call AC_PROG_CC unconditionally: it will honour CC from the environment but it will also do the right things about later checks. On Solaris if the alternative compiler is not GCC then don't feed it GNU options. commit 5dc76a384254b3a0b1a72ff1be5faec042effa73 Author: Mark Goodwin Date: Fri Jul 31 15:44:40 2009 +1000 RPM spec specifically for the Fedora Project. Signed-off-by: Mark Goodwin commit 1274605472853400f4297439c433a05829735a64 Author: Mark Goodwin Date: Fri Jul 31 15:40:58 2009 +1000 tweak configure to move PCP_BINADM_DIR out of /usr/share, into /usr/lib. Arch dependent binaries should not be installed below /usr/share. Signed-off-by: Mark Goodwin commit 17700e2bdaa0060178c3d025edb92280f36451f6 Author: Mark Goodwin Date: Fri Jul 31 11:47:39 2009 +1000 delete unneeded explicit script interpreter to keep rpmlint happy Signed-off-by: Mark Goodwin commit b971772c281a5aff6408981e7086cbfa4bcee6ba Author: Mark Goodwin Date: Fri Jul 31 11:33:20 2009 +1000 pmpost does not really need to be setuid Signed-off-by: Mark Goodwin commit 0a4cd4b8bfe44265bdccfb93db5e19c28c796f79 Author: Mark Goodwin Date: Fri Jul 31 11:11:48 2009 +1000 Nuke migrate_pcp_var_dir, no longer needed Signed-off-by: Mark Goodwin commit bf98168e8a7cea7697497f4972dd835fa10e29b6 Author: Mark Goodwin Date: Thu Jul 30 18:25:12 2009 +1000 default chkconfig off for all PCP services Signed-off-by: Mark Goodwin commit 679b9d50fa63430066fbf8343607205dd46d20f7 Author: Ken McDonell Date: Wed Jul 29 20:38:59 2009 +1000 Initial work for PMDA_INTERFACE_4 and new sample.secret.* dynamic metrics. commit 6c17c674360b6d6738f37bb9330fdb607dd1c872 Author: Ken McDonell Date: Wed Jul 29 20:38:07 2009 +1000 Remove log files that were added by mistake. commit a707483a5af651b430b9e2b4a193a5b64585e6e9 Author: Ken McDonell Date: Wed Jul 29 20:34:10 2009 +1000 Second round of PMDA_INTERFACE_4 and dynamic PMNS changes. Gets things working for DSO PMDAs. commit 8e0f63dbb6ae77a2d526e9472b85d8de1b5bab84 Author: Ken McDonell Date: Wed Jul 29 20:31:52 2009 +1000 Extending domain number to 9 bits (continued). commit f2866c9e1bf8c9a70213ed4cd859d437b9af6bad Author: Mark Goodwin Date: Mon Jul 27 19:59:39 2009 +1000 Bump version to 2.9.0. commit d3f630a269c73017407b46713bb75b91a7516475 Author: Mark Goodwin Date: Mon Jul 27 19:57:22 2009 +1000 Tweak Debian perl packaging with explicit dependencies, resolving build warnings. commit e69333488d42d8b3b1a8f35ea1f9ea3b2f12ad35 Author: Mark Goodwin Date: Mon Jul 27 19:56:41 2009 +1000 Make the pcp2.x RPM provide pcp-devel and pcp-libs This RPM packaging change makes it easier for dependent packages such as pcp-gui to transition to pcp-3.x, where we have split packaging: pcp, pcp-devel and pcp-libs. commit 3687851ac4ee2ccc1810b25fccb31c9935427cdf Author: Nathan Scott Date: Mon Jul 27 15:23:21 2009 +1000 Split apart the POSIX and Win32 daemon PMDA code in pmcd. No longer use a wrapper for the Win32 implementation either, which allows us to have finer control over opened/closed file descriptors and gives us a better shot at pipe agents (still not functional due to fd inheritance, I think) and also keeps track of the child PIDs. commit ee52cf1d530317ed290e07bf3dc964b362e3ca5c Author: Nathan Scott Date: Mon Jul 27 14:07:54 2009 +1000 When starting a PMDA in socket mode, we must mark the file descriptor as such. In order for socket communication to function on Windows, socket fd's must be flagged (and hence distinct from pipes, so we know whether to write/send there). This gets socket-based daemon PMDAs to startup correctly under Win32 conditions. commit bd5862657c7f532369ea6e760a06a0aa9f81f74f Author: Nathan Scott Date: Mon Jul 27 14:04:17 2009 +1000 Fix a typo in a comment in pmcd code. commit 61c43f8885220a6e7d41624ace23d1157ef90e29 Merge: 910d640... 3baf8e7... Author: Mark Goodwin Date: Mon Jul 27 09:37:33 2009 +1000 Merge branch '3.0.0' of git+ssh://markgw@oss.sgi.com/oss/git/markgw/pcp/pcp into dev commit 3baf8e7a6491c9533a1b0ff00c6d711a32677536 Author: Mark Goodwin Date: Mon Jul 27 09:32:57 2009 +1000 take -fstack-protector-all back out again since it's only supported with newer compilers. Probably should add a configure test for it at some stage Signed-off-by: Mark Goodwin commit eb409a0cb7c638a42e2546d7f6e67ac1aa0ac66c Author: Josef 'Jeff' Sipek Date: Mon Jul 27 08:45:50 2009 +1000 PowerDNS PMDA's packetcache_size and qsize_q are instant values, not counters commit c8728d91900e220159bc925084cb3a862a4a5d26 Author: Nathan Scott Date: Mon Jul 27 08:44:21 2009 +1000 Update pmlogger -x message - kill is now (cross-platform) pmsignal. commit 47a82efaefdc26f37ce62df6d736092b96c2ae61 Author: Nathan Scott Date: Thu Jul 23 15:18:20 2009 +1000 Tweak deb package long descriptions for bug 537563. commit 0b9600ede2f03f15d271ab812a703d0b606c4506 Author: Josef 'Jeff' Sipek Date: Thu Jul 23 14:49:30 2009 +1000 Add a new PMDA for the PowerDNS daemon (www.powerdns.com). commit df6f93cd1b2de0fc1e531cc568f4e53b73adf7e5 Author: Nathan Scott Date: Thu Jul 23 14:32:59 2009 +1000 Remove a duplicated metric from the MySQL PMDA. Problem reported by Josef Sipek, install of this PMDA now fails due to reworking of the pmns generation code, before this would have silently overwritten one metric with the other (122 won in our production environment so I've kept that) but now we check for this condition. commit 737b6904574678e174e5d8b969b91edce66c759a Author: Nathan Scott Date: Thu Jul 23 13:26:31 2009 +1000 Improve error reporting in pmcd on Windows. Should we be asked to open a UNIX domain socket channel to a PMDA on Windows, improve the message for easier diagnosis. commit c87287e790d4636e2abbd98f223daa0c67c644e8 Author: Nathan Scott Date: Thu Jul 23 13:25:11 2009 +1000 Improve error reporting in PCP::PMDA perl module. When failing to build the PMNS file, additional diagnostics would be helpful to pinpoint the source of the error. commit 910d640b1cdd749de83245523a24e2486a8f5cc2 Merge: 7f3bf2c... 0c1b4b2... Author: Mark Goodwin Date: Thu Jul 23 11:39:22 2009 +1000 Merge branch '3.0.0' of git://oss.sgi.com/markgw/pcp/pcp into dev commit 0c1b4b2f4bd9b0759964fb056a1469b2dd052ce6 Author: Mark Goodwin Date: Wed Jul 22 17:02:40 2009 +1000 Tweak RPM dependency rules for 2.x -> 3.x upgrades and massage the PCP RPM spec to reduce rpmlint noise. Also added -fstack-protector-all to Linux PCFLAGS. On branch 3.0.0: modified: build/rpm/pcp.spec.in modified: src/include/builddefs.in Signed-off-by: Mark Goodwin commit 7f3bf2c9a2966801f95c31f049291da8434faae4 Author: Nathan Scott Date: Wed Jul 22 13:37:47 2009 +1000 Ensure the Perl PMDA process runs in its own process group, and ignore SIGTERM in the atexit handler. This resolves an issue with the earlier fix for reaping children. commit d597f63b47a9eb8140c878bbc26c1434431c3096 Author: Nathan Scott Date: Wed Jul 22 11:52:09 2009 +1000 Comment out some diagnostics in named PMDA. commit c9b822c236f1bf219d830d1185d16cc9e87eae4c Author: Rodney McKee Date: Wed Jul 22 11:44:32 2009 +1000 Add the named PMDA, initially supporting BIND 9.4. commit cf003f4dddc1f26d2d7818f7c17bfd942a448ea2 Merge: fee86f6... fcca602... Author: Nathan Scott Date: Wed Jul 22 10:18:55 2009 +1000 Merge branch 'dev' of git://oss.sgi.com/mort/pcp into dev commit fcca6023cd689ea5f48c6f6c538e2e21af67d32e Author: Martin Hicks Date: Tue Jul 21 17:34:05 2009 -0400 Do not create infiniband pmda config file by default In order to simplify monitoring in the simple case where a machine has a single Infiniband interface, the config file is no longer created by default. Instead, only local ports are monitored. This does solve the problem where if an infiniband card is replaced in a machine that the administrator no longer has to remove the /var/lib/pcp/pmdas/ib/config file in order to restore infiniband monitoring. For more advanced usage where static instance naming is required or remote Infiniband ports must be monitored a config file can still be created, but it is the responsibility of the administrator to update the GUIDs if an HCA replacement is done. commit 840243974c106daae11368730043534d4684bc59 Author: Martin Hicks Date: Tue Jul 21 17:31:54 2009 -0400 Manpage for the infiniband PMDA commit fee86f6503252207a236c5eb81c8d092eede1a87 Author: Nathan Scott Date: Thu Jul 16 16:59:45 2009 +1000 Rework the special SGI CPU numbering logic in the Linux PMDA. This resolves a buffer overflow bug in the use of realpath(3) in this routine, which was being passed a too-small buffer. This issue was initially reported to us by Chandana De Silva, but looks like others have come across it too, e.g.: https://bugs.launchpad.net/ubuntu/+source/pcp/+bug/384776 I've removed the unused "cname" field from the per-CPU data structure, and also added some short-circuit logic into this code so that we bail out of this logic early if no hardware- graph filesystem paths are detected (which will be the normal case for most people). commit 67ae7fd90a32a43bbc97b939e57302556e864459 Author: Nathan Scott Date: Thu Jul 16 16:54:11 2009 +1000 Resolve a valgrind reported problem when initing Linux loadavg metric. Ensure read buffer is initialised to zero, and also check the return code for a failed read syscall. commit 7f0167d8410147a6645699b0a385dc0c3bdfa5ac Author: Martin Hicks Date: Tue Jul 14 14:14:31 2009 -0400 Reserve domain ID 99 for SGI Ultra Violet PMDA commit de5188e9814f25c043dd278d3b3b9be0f3d8a306 Author: Ken McDonell Date: Sun Jul 12 07:51:13 2009 +1000 Increase domain from 8-bits to 9-bits. Cleaned up the use of the top bit as a flag for both a pmID and a pmInDom ... now using a 1 bit flag field instead of the 2-bit "pad" field. Changes required for PMNS parsing in libpcp and internal handling of help text. Introduced PMDA_INTERFACE_4, but no code using this yet. Encoding and logic to handle dynamic PMNS entries introduced and some local support in parsing and reporting local PMNS entries (syntax for PMID in PMNS is :*:*) ... this means domain number 511 (DYNAMIC_PMID) is now special and reserved. commit 3a0217c80b84c56d21bdd64f9d6396c9c583556d Author: Nathan Scott Date: Fri Jul 10 10:37:08 2009 +1000 Add a PCP::PMDA module check into PMDA Install path for Perl PMDAs. commit 2c278354dedbb229721ffbb6cd1934896095c4a7 Author: Nathan Scott Date: Fri Jul 10 10:35:08 2009 +1000 Make Perl PMDA module explicit wrt libpcp_pmda interface version used. From goodwinos@gmail.com Mon Sep 28 18:13:57 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_33, J_CHICKENPOX_41,J_CHICKENPOX_63,J_CHICKENPOX_73,URIBL_BLACK autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n8SNDvnq164059 for ; Mon, 28 Sep 2009 18:13:57 -0500 X-ASG-Debug-ID: 1254179715-039002010000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mx1.redhat.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 7669548699B for ; Mon, 28 Sep 2009 16:15:15 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id bKjt56LUOUzmjuqu for ; Mon, 28 Sep 2009 16:15:15 -0700 (PDT) Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8SNFA0Q006094; Mon, 28 Sep 2009 19:15:10 -0400 Received: from [10.11.9.108] (vpn-9-108.rdu.redhat.com [10.11.9.108]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n8SND6sb016824; Mon, 28 Sep 2009 19:13:08 -0400 Message-ID: <4AC14301.204@gmail.com> Date: Tue, 29 Sep 2009 09:13:05 +1000 From: Mark Goodwin User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: kenj@internode.on.net CC: pcp@oss.sgi.com X-ASG-Orig-Subj: Re: [pcp] Dynamic PMNS changes finally arrive Subject: Re: [pcp] Dynamic PMNS changes finally arrive References: <1254034250.4466.12.camel@bozo-laptop.localdomain> In-Reply-To: <1254034250.4466.12.camel@bozo-laptop.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 10.5.11.16 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1254179716 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0148 1.0000 -1.9243 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -0.92 X-Barracuda-Spam-Status: No, SCORE=-0.92 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M, BSF_RULE_7582B X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.10275 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M 0.50 BSF_RULE_7582B Custom Rule 7582B X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Hi Ken, I have a round of changes (v3.0.0-6) to push up to the dev branch (clean up "the mess" following the Fedora keel-haul, and also integrates the perl packaging) - this is under QA at the moment, which is taking longer than I'd hoped. In any case, I'll push 3.0.0-6 to 'dev' asap. Then I'll merge your master branch and run a QA delta. If that goes OK I propose we push this to (v3.0.0-7) for review and soak time in the dev branch since the design is already reviewed. At the very least we'll need to update the cluster PMDA before 3.0 can be considered release worthy. Cheers -- Mark Ken McDonell wrote: > Committed to the *master* branch of my PCP tree on oss.sgi.com > > There are several rounds of commits for this set of changes that became > much more complicated and touched more files than I'd originally > expected. > > This all passes my QA ... after I get some feedback on the PCP changes > I'll move the QA tree forward. > > In the logs below there are lots of changes from the *master* and *dev* > branches (this is a mess we need to sort out pronto!). Only the ones > authored by me are really part of this batch of commmits, the others are > innocent bystanders as a result of the passage of time. > > Changes committed to git://oss.sgi.com/kenj/pcp.git master > > .gitignore | 2 > CHANGELOG | 33 + > VERSION.pcp | 10 > build/GNUmakefile | 3 > build/rpm/pcp.spec.in | 39 +- > build/rpm/pcp_fedora.spec | 385 +++++++++++++++++----- > build/sun/GNUmakefile | 53 ++- > configure.in | 99 ++++- > debian/changelog | 21 + > debian/control | 72 ++-- > man/man1/GNUmakefile | 1 > man/man1/newhelp.1 | 24 + > man/man1/pmcd.1 | 6 > man/man1/pmdaib.1 | 113 ++++++ > man/man1/pmval.1 | 27 + > man/man3/pmda.3 | 15 > man/man3/pmdachildren.3 | 139 +++++++- > man/man3/pmdamain.3 | 84 +++- > man/man3/pmdaname.3 | 91 +++++ > man/man3/pmdapmid.3 | 89 ++++- > man/man4/pmns.4 | 45 +- > src/cpan/MMV/Changes | 7 > src/cpan/MMV/MMV.pm | 6 > src/cpan/MMV/MMV.xs | 41 +- > src/cpan/MMV/server.pl | 17 > src/cpan/PMDA/Changes | 8 > src/cpan/PMDA/PMDA.pm | 6 > src/cpan/PMDA/PMDA.xs | 39 +- > src/cpan/PMDA/local.c | 3 > src/dbpmda/src/GNUmakefile | 2 > src/dbpmda/src/dbpmda.c | 64 +++ > src/dbpmda/src/dbpmda.h | 2 > src/dbpmda/src/dso.c | 205 +++++++++-- > src/dbpmda/src/gram.y | 43 ++ > src/dbpmda/src/lex.l | 30 - > src/dbpmda/src/pmda.c | 130 ++++++- > src/dbpmda/src/util.c | 20 + > src/genpmda/genpmda | 4 > src/include/builddefs.in | 13 > src/include/impl.h | 31 + > src/include/mmv_stats.h | 2 > src/include/pmda.h | 73 +++- > src/libpcp/src/.gitignore | 3 > src/libpcp/src/desc.c | 11 > src/libpcp/src/fetchlocal.c | 28 + > src/libpcp/src/help.c | 11 > src/libpcp/src/instance.c | 46 +- > src/libpcp/src/p_pmns.c | 2 > src/libpcp/src/pmns.c | 139 ++++++-- > src/libpcp/src/store.c | 14 > src/libpcp/src/util.c | 34 + > src/libpcp_gui/src/.gitignore | 3 > src/libpcp_gui/src/GNUmakefile | 2 > src/libpcp_mmv/src/.gitignore | 1 > src/libpcp_mmv/src/mmv_stats.c | 65 ++- > src/libpcp_pmcd/src/.gitignore | 1 > src/libpcp_pmda/src/.gitignore | 1 > src/libpcp_pmda/src/callback.c | 45 ++ > src/libpcp_pmda/src/help.c | 2 > src/libpcp_pmda/src/libdefs.h | 3 > src/libpcp_pmda/src/mainloop.c | 261 ++++++++++++--- > src/libpcp_pmda/src/open.c | 133 ++++--- > src/libpcp_trace/src/.gitignore | 3 > src/newhelp/chkhelp.c | 6 > src/newhelp/newhelp.c | 50 ++ > src/pmcd/GNUmakefile | 5 > src/pmcd/migrate_pcp_var_dir | 126 ------- > src/pmcd/pmdaproc.sh | 242 +++++++------ > src/pmcd/rc_pcp | 14 > src/pmcd/src/config.c | 163 +++++++-- > src/pmcd/src/dofetch.c | 57 ++- > src/pmcd/src/dopdus.c | 660 ++++++++++++++++++++++++++++++++------ > src/pmcd/src/dostore.c | 14 > src/pmcd/src/pmcd.h | 8 > src/pmcd/src/pmcd.log | 198 +++++------ > src/pmcd/src/sample.log | 4 > src/pmcd/src/sendmail.log | 4 > src/pmcd/src/simple.log | 4 > src/pmcd/src/trace.log | 4 > src/pmdas/GNUmakefile | 7 > src/pmdas/ib/daemon.c | 20 - > src/pmdas/ib/dso.c | 2 > src/pmdas/ib/ib.c | 283 +++++++++------- > src/pmdas/ib/ibpmda.h | 4 > src/pmdas/ib/pmda.c | 4 > src/pmdas/linux/proc_cpuinfo.c | 38 -- > src/pmdas/linux/proc_cpuinfo.h | 1 > src/pmdas/linux/proc_loadavg.c | 7 > src/pmdas/mmv/.gitignore | 5 > src/pmdas/mmv/GNUmakefile | 28 - > src/pmdas/mmv/Install | 6 > src/pmdas/mmv/Remove | 5 > src/pmdas/mmv/mmv.c | 103 +++-- > src/pmdas/mysql/pmdamysql.pl | 3 > src/pmdas/named/.gitignore | 2 > src/pmdas/named/GNUmakefile | 45 ++ > src/pmdas/named/Install | 32 + > src/pmdas/named/Remove | 25 + > src/pmdas/named/pmdanamed.pl | 155 ++++++++ > src/pmdas/pdns/.gitignore | 2 > src/pmdas/pdns/GNUmakefile | 45 ++ > src/pmdas/pdns/Install | 27 + > src/pmdas/pdns/Remove | 25 + > src/pmdas/pdns/pmdapdns.pl | 194 ++++++++++- > src/pmdas/pmcd/src/pmcd.c | 12 > src/pmdas/samba/.gitignore | 2 > src/pmdas/samba/GNUmakefile | 49 ++ > src/pmdas/samba/Install | 43 ++ > src/pmdas/samba/Remove | 25 + > src/pmdas/samba/pmdasamba.pl | 205 +++++++++++ > src/pmdas/sample/help | 24 + > src/pmdas/sample/pmns | 1 > src/pmdas/sample/src/pmda.c | 2 > src/pmdas/sample/src/sample.c | 362 ++++++++++++++++++-- > src/pmdas/simple/pmdasimple.pl | 6 > src/pmdas/solaris/GNUmakefile | 15 > src/pmdas/solaris/common.h | 14 > src/pmdas/solaris/data.c | 212 +++++++++++- > src/pmdas/solaris/help | 95 +++++ > src/pmdas/solaris/netmib2.c | 344 +++++++++++++++++++ > src/pmdas/solaris/netmib2.h | 62 +++ > src/pmdas/solaris/pmns.network | 31 + > src/pmdas/solaris/pmns.zfs | 15 > src/pmdas/solaris/pmns.zpool | 20 + > src/pmdas/solaris/root | 5 > src/pmdas/solaris/solaris.c | 7 > src/pmdas/solaris/zfs.c | 164 ++++++++- > src/pmdas/solaris/zpool.c | 226 ++++++++++--- > src/pmdas/trace/GNUmakefile | 3 > src/pmdas/trace/GNUmakefile.demos | 2 > src/pmdas/trace/GNUmakefile.stub | 2 > src/pmdas/windows/fetch.c | 91 ++--- > src/pmdas/windows/libpdh.def | 1 > src/pmdas/windows/libpdh.h | 20 + > src/pmdas/windows/open.c | 13 > src/pmdas/windows/pmda.c | 32 + > src/pmdas/windows/pmns.kernel | 1 > src/pmie/rc_pmie | 12 > src/pmie/src/GNUmakefile | 2 > src/pmlc/GNUmakefile | 2 > src/pmlogextract/GNUmakefile | 2 > src/pmlogger/GNUmakefile | 2 > src/pmlogger/pmlogger.c | 3 > src/pmns/Make.stdpmid | 8 > src/pmns/ReplacePmnsSubtree | 8 > src/pmns/pmnsutil.c | 5 > src/pmns/stdpmid.pcp | 8 > src/pmpost/GNUmakefile | 2 > src/pmproxy/rc_pmproxy | 12 > src/pmval/pmval.c | 55 ++- > 150 files changed, 6178 insertions(+), 1581 deletions(-) > > commit 52872f6b735fbf7814443f226df21eee30b35936 > Author: Ken McDonell > Date: Sun Sep 27 16:30:09 2009 +1000 > > ReplacePmnsSubtree fix bad signal handling botch > > The trap handling was totally wrong in cleanup() ... causing the > command "1" to be executed instead of the null command "". > > Exposed by another bug in a related area ... if the PMNS lock > exists already, after the timeout in pmlock we fall into the > trap cleanup() routine instead of charing on, so the script > fails horribly (and leaves the stale lock file around). > > Also fixed an unlikely buffer over-run in mmv.c. > > commit 4087051b86b580d7c7cb6e50806edb4eaa63e4d4 > Author: Ken McDonell > Date: Sun Sep 27 15:20:24 2009 +1000 > > newhelp, dbpmda, libpcp, libpcp_pmda, pmcd, sample pmda - dynamic PMNS changes > > This is the final round of changes that get all of the changes for > PMDA_INTERFACE_4 and the support of dynamic subtress of the PMNS where > the PMDA (not PMCD) maintains knowledge of the PMNS. > > With these changes and a related round of QA changes, we're passing all > of the QA tests (excluding the remote group that I cannot test at the > moment, but are unlikely to find problems in this code). > > commit 40e120d100d8f8f2a638124edef1ac2a16c0b975 > Author: Ken McDonell > Date: Sun Sep 27 15:18:33 2009 +1000 > > pmdaproc.sh Revert changes for perl pmda setup. > > Just put it back the way it was before I started messing with it! > > commit 4cead6907bf315ed009725db26659d3c6e12c698 > Author: Ken McDonell > Date: Sun Sep 27 15:11:44 2009 +1000 > > pmdaproc.sh tweaking to improve QA success > > Add delays after sending pmcd SIGHUP and before checking for pmcd health > to avoid small window where badness happens to pmcd from new PMDA, but > after the test has been done. > > Also wound back previous Perl PMDA setup change as it does not help the > QA test for the news PMDA ... reworked the QA test instead! > > commit 9371a85a8a5b65b43be732e585e1b8f98f4b94e1 > Author: Ken McDonell > Date: Thu Sep 24 16:59:07 2009 +1000 > > Only remake pmns file if it does not exist. > > Part of the perl PMDA support was unconditionally remaking pmns and > domain.h ... this was reordering the metrics for the simple PMDA and > causing QA tests 255 and 578 to fail ... more importantly if the > pmns file already exists then there is no point in using the perl > PMDA magic to recreate it. > > commit 4f6a801b054f92b23064385940a441bc66b758bd > Merge: e421a49... 11549ac... > Author: Ken McDonell > Date: Thu Sep 17 20:00:33 2009 +1000 > > Merge branch 'master' of git://oss.sgi.com/kenj/pcp > > Conflicts: > CHANGELOG > VERSION.pcp > src/pmcd/rc_pcp > src/pmie/rc_pmie > src/pmproxy/rc_pmproxy > > commit 11549aca86588c4695d26829e02f2ec9e7b43c3d > Author: Nathan Scott > Date: Mon Sep 7 16:29:34 2009 +1000 > > Bump pcp stable version to 2.9.2. > > commit 7997eea93ad9c240d2cbc7c2bfbd9ae21bb29e35 > Author: Ken McDonell > Date: Mon Sep 7 11:59:21 2009 +1000 > > Fix the number-of-samples value calculated in pmval once and for all. > > For those who care, it turns out that the number of _fetches_ may be > known, the number of _reported_ samples cannot be precomputed correctly > in all cases ... > - only works for archives with -a (not -U or -h) > - is known for non-counter metrics > - most of the time is known for counter metrics but there are some > important corner cases where this is not the case, specifically there > will be one more reported sample than expected for a counter when the > report starting time is not at the start of the archive and the metric > has a defined value before the report starting time with no intervening > mark record (interpolate mode does return a value at the first report > sample in this case!). > > With this pmval patch, the QA fallout is nil, except for 144 that is an > unrelated timezone problem. Also this patch avoids referencing the > context too soon, as there is no point in inspecting the metric's > semantics to try and better guess the value of smpls. As a bonus, this > patch also documents pmval's -U option that has remained a secret for > nearly a decade. > > commit f4e6d55fd0466a706144ca61b4428436ecea7eb7 > Author: Nathan Scott > Date: Mon Sep 7 11:51:58 2009 +1000 > > Attempt to resolve sys/stat related build issue on Alpha. > > Not having access to an Alpha makes this difficult, but one thing > that is clearly not helping is that with Linux glibc on Alpha, we > end up defining *both* HAVE_STAT_TIMESPEC and HAVE_STAT_TIME_T, & > that breaks otherwise valid pmns.c coding assumptions. > > This change means only one type for the stat time fields can be > defined, and it errs on the side of timespec (which should be the > one Alpha uses, AFAICT) - so perhaps this issue will finally be > resolved and PCP can progress in the Debian build/release system. > > commit be8793c58935362184a1dd4351388ca6a0013f3b > Author: Nathan Scott > Date: Mon Sep 7 11:26:09 2009 +1000 > > Fix mmv library build on mac/win - missing a header. > > commit 92eb7b896ff6eb83b2feef50e6a89c74c3aa1717 > Author: Nathan Scott > Date: Fri Sep 4 14:17:37 2009 +1000 > > Bump pcp stable version to 2.9.1. > > commit 2e890f3d1d9c4af31fc22af95cb7e0f20336523e > Author: Nathan Scott > Date: Fri Sep 4 14:15:16 2009 +1000 > > Correct pmval sample count calculation. > > Martin reported several QA tests were failing wrt pmval "samples" line. > > What I've found is the problem either exists/doesn't exist depending on > several factors: > - running on a 32 bit machine, Debian unstable, the problem never occurs > no matter how pmval is built. > - running on a 64 bit machine, Debian unstable, the problem only happens > with the packaged binaries. The key factor appears to be the introduction > of -O2, which looks like it reliably changes certain values on the stack, > that would otherwise be zero (used uninitialised, in either case). > > There's two problems here, I believe: > - in pmval.c the getargs() call initialises the value of "smpls" (number > of samples to take) based on cntxt->desc.sem. However, at that point, > we have not established a context yet, and so that field is uninitialised. > - this test doesn't match the comment above it, and doesn't make sense: > > /* counters require 2 samples to produce reported sample */ > if (*smpls > 0 && cntxt->desc.sem != PM_SEM_COUNTER) > > that would seem to me that it should be "cntxt->desc.sem == PM_SEM_COUNTER". > > commit 6940bbf89ca10d395fff93eeb7ce7424cec5d2ad > Merge: b7bb608... 350246f... > Author: Nathan Scott > Date: Fri Sep 4 14:08:24 2009 +1000 > > Merge branch 'dev' of git://oss.sgi.com/nathans/pcp into dev > > commit 350246f0ba359876660994823d2e37b864040c3f > Author: Nathan Scott > Date: Thu Sep 3 12:59:57 2009 +1000 > > Another pass at getting the perl/debian packaging auto-deps right. > > commit 91c9f4a0a06d8e300c23f49feab09141c488b0f5 > Author: Nathan Scott > Date: Thu Sep 3 12:59:24 2009 +1000 > > Correct mmv install targets makefile macro. > > commit bf33333edbcf48ee84dad07cace240d6aff6cc99 > Author: Nathan Scott > Date: Wed Sep 2 15:07:19 2009 +1000 > > Workaround another oddity in (very) recent versions of autoconf. > > Problem found by the Debian autobuilders, in the pcp-gui build but it > affects pcp too. Latest versions of autoconf evaluate AC_PROG_LEX in > the compiler check macro, and complete remove any trace of AC_PROG_LEX > from its original callsite. This results in a syntax error inside our > configure script, as we call it within if ... fi, which then evaluates > to having no body to the if. Ugh. Fix is trivial though, since these > macros do the user-env-variable expansion thing already. > > commit efcb3b590f086feb1507f82716d2f0b6eee69d33 > Author: Petter Reinholdtsen > Date: Wed Sep 2 14:38:34 2009 +1000 > > Add missing dependencies and runlevels into PCP start scripts. > > With dependency based boot sequencing, I discovered what I believe is > a bug in the init.d scripts of this package. The list of runlevels to > stop in is incomplete. The script should stop in runlevel 1 to make > sure the service is started again when switching from runlevel 1 to > 2-5. Also, the script should probably stop during halt (0) and reboot > (6). The package should start in runlevel 4, just like in runlevels > 2, 3 and 5. I suspect the list of dependencies are incomplete. The > scripts used to start after the syslog collector was operational, and > should probably continue to do so. Also, the scripts need files in > /usr/ and should depend on $remote_fs. > > If the scripts themselves need to start in any specific order, the > relationship should be listed explicitly in the LSB header too. Make > sure the update-rc.d calls in the postinst reflect this ordering if > any such dependencies should exist. > > This patch implement the proposed change. Without it, the script seem > to fail to handle runlevel 0, 1, 4 and 6 properly, and might start too > early in the boot. > > commit 4aa31ed00a60c3926a53bbd8d47aa0b2eaf254c4 > Merge: 35c230e... 3323bb9... > Author: Nathan Scott > Date: Wed Sep 2 13:18:44 2009 +1000 > > Merge branch 'dev' of git://oss.sgi.com/nathans/pcp into dev > > commit b7bb60801c2fc342b15473f1e3b341dd8ec7b84a > Author: Nathan Scott > Date: Wed Sep 2 12:38:19 2009 +1000 > > Update gitignore files for Mac and Windows library file names. > > commit 3323bb90ad5f66480c05b7fe182a72a0813c9b41 > Author: Nathan Scott > Date: Wed Sep 2 12:30:47 2009 +1000 > > Fix a segv observed in the Windows PMDA accessing SQL Server metrics. > > The recent optimisation added for direct instance domain lookup added > a flaw that could case an array index of -1 to be used to access into > the metric value table. Observed on SQL Server 2008 & Windows Server > 2008 R2 only so far. > > commit 1112ac636cae6feac624279c76239003662d4a35 > Author: Nathan Scott > Date: Wed Sep 2 11:49:20 2009 +1000 > > Small MMV pmda changes to allow DSO builds in the future. > > Turns out that the current protocol for getting pmcd to > update its namespace cannot be used from DSO agents ... > one more reason to revamp this area. > > commit 677c6f2cea7fce4ff5f10f939fc5a942861719dd > Author: Nathan Scott > Date: Wed Sep 2 11:46:40 2009 +1000 > > Fix logic error causing wrong windows version to be reported. > > commit e421a49323307d49f6b897ae87f94c934b6fdcad > Author: Ken McDonell > Date: Tue Sep 1 17:44:22 2009 +1000 > > Interim commit for start of daemon PMDA support for dynamic PMNS. > > commit 210be7f679b10d71dda985fdebc7dd9aec5d606a > Author: Nathan Scott > Date: Fri Aug 28 08:44:50 2009 +1000 > > Correct some regular expressions in Samba PMDA. > > Of particular note, some of the heading lines in the > smbstatus --profile output have trailing whitespace. > Otherwise, this PMDA is now fully functional; and as > it used the stock Samba utilities, is not dependent > on the many flavours of Samba shmem format anymore. > At the cost of a slight overhead increase, of course, > but the original was unmaintainable. > > Thanks to James Peach for advise on redesigning this. > > commit 0758690bcbbf26db438560d5b5b94b1644979047 > Author: Nathan Scott > Date: Thu Aug 27 14:26:32 2009 +1000 > > Descend into samba PMDA during the build (SUBDIRS update). > > commit 9e758dd286ee2c49ecd991599a4c87a5520b9892 > Author: Nathan Scott > Date: Thu Aug 27 14:25:18 2009 +1000 > > Add kernel.all.uptime to the Windows kernel agent. > > This code uses the PdhGetFormatterCounterValue API, which we > have not used before on Windows, hence the changes to libpdh > header and dll definition files. > > commit b0cbeab4df3aec93a2f9749c7912dc8adc0b27ea > Author: Nathan Scott > Date: Thu Aug 27 10:21:28 2009 +1000 > > Rearrange platform-specific handling in pmdaproc.sh. > > Keep everything that does platform-specific stuff in one > place now, run early on, instead of all over the shop. > > The code that handles determining whether the PCP::PMDA > Perl module is installed is also reworked to not fail in > the case where perl_opt is set, but user doesn't select > that option when Install'ing a PMDA. This bit Mark with > the simple PMDA, which has both Perl and C variants. > > commit ac9170cf888639cc731474d39cb100e9d7b2c519 > Author: Nathan Scott > Date: Thu Aug 27 09:20:14 2009 +1000 > > Initial version of the (perl-based) Samba PMDA. > > commit e00aafe76a538ad09322499c2f669450d3b0c486 > Author: Nathan Scott > Date: Wed Aug 26 11:46:12 2009 +1000 > > Fix inconsistent metric name in pmdasimple.pl - simple.now was wrong. > > commit e937d8332c9dc6a0f4d5ea5fb10b6d3530b7261b > Author: Nathan Scott > Date: Wed Aug 26 11:02:55 2009 +1000 > > Remove hard-coded path in the perl variant of the simple PMDA (thanks Mark). > > commit 531de7440179d323c8774fad2a4c13ac4c21bcbb > Author: Nathan Scott > Date: Wed Aug 26 11:00:00 2009 +1000 > > Use PM_IN_NULL in pmdasimple.pl so it functions correctly on all platforms. > > commit 956be698fe2de60b96c2c6fa72be1555a1c3cf7c > Merge: 7bf0f27... b8cb2dd... > Author: Nathan Scott > Date: Mon Aug 24 10:58:57 2009 +1000 > > Merge branch 'dev' of git://oss.sgi.com/nathans/pcp into dev > > commit 7bf0f27d27c11db4002699e74611ef718551add3 > Merge: 309e7be... 3db8e4f... > Author: Nathan Scott > Date: Mon Aug 24 10:57:30 2009 +1000 > > Merge branch 'solaris' of git://oss.sgi.com/makc/pcp into dev > > commit 309e7be90719ebc12bc66e9a06999909e7f66c16 > Author: Nathan Scott > Date: Mon Aug 24 09:03:19 2009 +1000 > > Add PCP::PMDA helper routines for determining native long sizes. > > commit 90e8cd865a6bfabf91315feea3743054a1511111 > Author: Nathan Scott > Date: Mon Aug 24 09:01:38 2009 +1000 > > Extend MMV to allow teardown of MMV file, and set errno on failure. > > Setting errno helps alot with diagnosing mmv_stats_init() failures. > > commit d4732eb5d60d8d31bb6eba69daa2787befb34325 > Author: Nathan Scott > Date: Mon Aug 24 08:56:24 2009 +1000 > > Initial stable (1.00) version of MMV Perl interface. > > Changes include: > - added stop interface > - added stats_set interface > - fixed incorrect memory free on init > - extend server.pl example to report idle time > - fixed use of av_len return codes (off by one) > > commit 3db8e4f3626241cb40e52f36a691263c8aaa34ff > Author: Max Matveev > Date: Mon Aug 17 18:52:49 2009 +1000 > > Release zpool resources when finished updates > > It's not documented but it's obvious that zpool_iter expects the > callback to call zpool_close to release resources associated with > the zpool - it's not a problem for short-lived commands like zpool(1) > but it leaks memory like a firehose. > > commit 35c230ef34a191bbb5b8f12b91d122e2863ac740 > Author: Nathan Scott > Date: Fri Aug 14 14:58:10 2009 +1000 > > Correct the metric units for several Windows per-process memory metrics. > > commit 758b2b7039e878189b42fab6d8d3a789a27810d1 > Author: Max Matveev > Date: Wed Aug 12 00:01:59 2009 +1000 > > Eliminate incidents of crime against whitespace > > commit 012af5fa4e16029513c6d1c2ff7c7a3d4a3069e3 > Author: Max Matveev > Date: Tue Aug 11 23:55:59 2009 +1000 > > Hide instances for destroyed pools and filesystems > > In Solaris PMDA if a zpool or a zfs is removed make sure that the > corresponding instance disappears from the list of instances returned on > fetch. > > commit a8cbf7b86b1bab119246006b23b1114fe1b4b9d7 > Author: Ken McDonell > Date: Fri Aug 7 11:22:23 2009 +1000 > > Revert __pmProcessTerminate() change. > > Since perl PMDAs are now all running in their own process group revert > to allow kill(0, ...) to proceed. > > commit 8ea858d245d093ed3285e0e4370303bd678cc468 > Merge: 9b4b935... ead91ff... > Author: Ken McDonell > Date: Thu Aug 6 18:35:49 2009 +1000 > > Merge branch 'dev' into pmns > > commit 9b4b9351a7e41bc21f893063e0311accd7cee046 > Author: Ken McDonell > Date: Thu Aug 6 18:18:10 2009 +1000 > > Guard in _pmProcessTerminate() to prevent killing all member of process group. > > Problem exposed by qa/162 and perl implementation of news pmda. > > commit 7f72e4acff1b876b10e6f6432a55de2e49b9e148 > Author: Ken McDonell > Date: Thu Aug 6 18:16:49 2009 +1000 > > Second round of changes for PMDA_INTERFACE_4 dynamic metrics. > > DSO mode PMDAs (sampledso) is very close to working correctly now. > > commit ead91ffca2605502c3552ffbc228ffbc0ed3ecc3 > Author: Mark Goodwin > Date: Thu Aug 6 12:14:25 2009 +1000 > > update changelog and delete unncessary Vendor string > > Signed-off-by: Mark Goodwin > > commit b77cb57bb669b1129c1241f7818fe75935390a3b > Author: Mark Goodwin > Date: Thu Aug 6 12:06:23 2009 +1000 > > also bump the src tarball version > > Signed-off-by: Mark Goodwin > > commit 6c8311051895092662b8ee1986945a3846577b04 > Author: Mark Goodwin > Date: Thu Aug 6 12:01:24 2009 +1000 > > bump to 3.0.0-2 > > Signed-off-by: Mark Goodwin > > commit 99aa1c21c22e64350ba750284039653750633540 > Merge: ef9852c... f2866c9... > Author: Mark Goodwin > Date: Thu Aug 6 11:37:29 2009 +1000 > > merge pcp-2.9.0-1 dev > > modified: CHANGELOG > modified: build/rpm/pcp.spec.in > modified: debian/changelog > modified: debian/control > modified: src/cpan/PMDA/PMDA.xs > modified: src/libpcp_pmda/src/open.c > modified: src/pmcd/src/config.c > modified: src/pmdas/GNUmakefile > modified: src/pmdas/mysql/pmdamysql.pl > new file: src/pmdas/pdns/.gitignore > new file: src/pmdas/pdns/GNUmakefile > new file: src/pmdas/pdns/Install > new file: src/pmdas/pdns/Remove > new file: src/pmdas/pdns/pmdapdns.pl > modified: src/pmlogger/pmlogger.c > modified: src/pmns/stdpmid.pcp > > Signed-off-by: Mark Goodwin > > commit ef9852c99666359cdacb1afe65dcac16460ea0ab > Author: Mark Goodwin > Date: Thu Aug 6 11:05:12 2009 +1000 > > Changes to the Fedora RPM spec in response to review feedback: > - Incorporate a large number of suggestions and cleanups from Eric Sandeen > - Greatly simplified the %post and %postun scriptlets - remove ancient crud > - Added ldconfig scriptlets for -libs > - Don't explicitly require IB libs, since they're libs and RPM figures it out > - No need to explicitly BuildRequire gcc-c++ libstdc++-devel > - Add BuildRequires on perl-ExtUtils-MakeMaker > - Remove explicit ia64 Requires: libunwind > - Have pcp-libs require the base package since Fedora insists > - Add and clarify some comments > - Create %{_localstatedir}/run/pcp and ship it (so it'll be removed) > - Use %doc for CHANGELOG COPYING INSTALL README VERSION.pcp pcp.lsm > > Signed-off-by: Mark Goodwin > > commit 88c3b113c45f61d8959b95f0486d5d625b8c85af > Author: Mark Goodwin > Date: Thu Aug 6 10:17:51 2009 +1000 > > git ignore generated gram*.tab.c > > Signed-off-by: Mark Goodwin > > commit 0fe594271c4635432616eaec4640b38773d150cc > Author: Mark Goodwin > Date: Thu Aug 6 10:12:55 2009 +1000 > > preserve generated gram.tab.c because debuginfo needs it > > Signed-off-by: Mark Goodwin > > commit 385ce8e19c550792fd61a4e6112408c208b75649 > Author: Mark Goodwin > Date: Thu Aug 6 09:21:48 2009 +1000 > > fix minor typo in comment > > Signed-off-by: Mark Goodwin > > commit b8cb2dd7c9b5d33e473bf0d89a64da3c2b2eec92 > Merge: 1c47a24... 684232a... > Author: Nathan Scott > Date: Wed Aug 5 16:52:11 2009 +1000 > > Merge branch 'solaris' of git://oss.sgi.com/makc/pcp into dev > > commit 1c47a24dbef502d09439e663b727a2bf85e5499d > Author: Nathan Scott > Date: Wed Aug 5 16:51:47 2009 +1000 > > Ignore all MMV files that begin with a period. > > commit 4bc076258e025f86b6215783933f7adcb77ace90 > Author: Max Matveev > Date: Wed Aug 5 02:10:37 2009 +1000 > > Add network metrics to Solaris PMDA > > Use MIB2 interface available via TI to extract IPv4 interfaces and UDP stats > from the kernel. > > The good/bad fetch is on the whole group - if any of the sources fail (even if > we don't use them like IPv6 interface stats) then whole fetch will return no > data. > > Fetch callback still uses offset for the metrics which have indoms, for > singular metrics a pointer to the global storage is used whence the change > of type in md_offset. > > commit 4e1e119bfb7cfa6d09c81049fec95d3dc9e13356 > Author: Mark Goodwin > Date: Tue Aug 4 12:19:07 2009 +1000 > > dont install trace demo binaries since src is installed anyway > > Signed-off-by: Mark Goodwin > > commit 234ffe3f3badbf73768f114fa692eac0dd7ec079 > Author: Max Matveev > Date: Mon Aug 3 10:33:41 2009 +1000 > > Report ZFS statistics from Solaris PMDA > > Use libzfs interfaces to extract some data about ZFS "dataset". Datasets > are filesystems, snapshots and volumes, the reported data include information > about used and available space, compression ratios, number of copies, > reserved space per dataset. Space utilization is additionally broken down > into space used by children, space used by snapshot and space used by the > dataset itself. > > commit 5da67384ae7719254afd7d76d8b10558b9d3de07 > Author: Max Matveev > Date: Mon Aug 3 01:59:01 2009 +1000 > > Export zpool stats from Solaris PMDA > > Use libzfs to extract zpool stats like capacity, iops, bandwidth etc > > commit 684232a1b6178de4a07edbd0e3308f49789992fb > Author: Max Matveev > Date: Sun Aug 2 23:05:11 2009 +1000 > > Put 64 bit libraries into the right place on Solaris > > Solaris keeps its 64 bit shared libraries in /usr/lib/64 - use the pointer > size to decide if we're building 32 or 64 bit version and push the library > in the right place. > > commit 3cf745f62c0099577265994de97c0a755cb06f9b > Author: Max Matveev > Date: Sun Aug 2 04:11:32 2009 +1000 > > Generate packages for Solaris > > commit 74c7543c88bc3776b81ae8a5eab4de940537ffdd > Author: Max Matveev > Date: Sun Aug 2 03:03:35 2009 +1000 > > Allow user to choose her compiler > > New autoconf attempts to compile the headers as part of AC_HEADER_CHECK. > It AC_PROG_CC is not called then AC_HEADER_CHECK generates scary warning - > just call AC_PROG_CC unconditionally: it will honour CC from the environment > but it will also do the right things about later checks. > > On Solaris if the alternative compiler is not GCC then don't feed it > GNU options. > > commit 5dc76a384254b3a0b1a72ff1be5faec042effa73 > Author: Mark Goodwin > Date: Fri Jul 31 15:44:40 2009 +1000 > > RPM spec specifically for the Fedora Project. > > Signed-off-by: Mark Goodwin > > commit 1274605472853400f4297439c433a05829735a64 > Author: Mark Goodwin > Date: Fri Jul 31 15:40:58 2009 +1000 > > tweak configure to move PCP_BINADM_DIR out of /usr/share, into /usr/lib. > Arch dependent binaries should not be installed below /usr/share. > > Signed-off-by: Mark Goodwin > > commit 17700e2bdaa0060178c3d025edb92280f36451f6 > Author: Mark Goodwin > Date: Fri Jul 31 11:47:39 2009 +1000 > > delete unneeded explicit script interpreter to keep rpmlint happy > > Signed-off-by: Mark Goodwin > > commit b971772c281a5aff6408981e7086cbfa4bcee6ba > Author: Mark Goodwin > Date: Fri Jul 31 11:33:20 2009 +1000 > > pmpost does not really need to be setuid > > Signed-off-by: Mark Goodwin > > commit 0a4cd4b8bfe44265bdccfb93db5e19c28c796f79 > Author: Mark Goodwin > Date: Fri Jul 31 11:11:48 2009 +1000 > > Nuke migrate_pcp_var_dir, no longer needed > > Signed-off-by: Mark Goodwin > > commit bf98168e8a7cea7697497f4972dd835fa10e29b6 > Author: Mark Goodwin > Date: Thu Jul 30 18:25:12 2009 +1000 > > default chkconfig off for all PCP services > > Signed-off-by: Mark Goodwin > > commit 679b9d50fa63430066fbf8343607205dd46d20f7 > Author: Ken McDonell > Date: Wed Jul 29 20:38:59 2009 +1000 > > Initial work for PMDA_INTERFACE_4 and new sample.secret.* dynamic metrics. > > commit 6c17c674360b6d6738f37bb9330fdb607dd1c872 > Author: Ken McDonell > Date: Wed Jul 29 20:38:07 2009 +1000 > > Remove log files that were added by mistake. > > commit a707483a5af651b430b9e2b4a193a5b64585e6e9 > Author: Ken McDonell > Date: Wed Jul 29 20:34:10 2009 +1000 > > Second round of PMDA_INTERFACE_4 and dynamic PMNS changes. > > Gets things working for DSO PMDAs. > > commit 8e0f63dbb6ae77a2d526e9472b85d8de1b5bab84 > Author: Ken McDonell > Date: Wed Jul 29 20:31:52 2009 +1000 > > Extending domain number to 9 bits (continued). > > commit f2866c9e1bf8c9a70213ed4cd859d437b9af6bad > Author: Mark Goodwin > Date: Mon Jul 27 19:59:39 2009 +1000 > > Bump version to 2.9.0. > > commit d3f630a269c73017407b46713bb75b91a7516475 > Author: Mark Goodwin > Date: Mon Jul 27 19:57:22 2009 +1000 > > Tweak Debian perl packaging with explicit dependencies, resolving build warnings. > > commit e69333488d42d8b3b1a8f35ea1f9ea3b2f12ad35 > Author: Mark Goodwin > Date: Mon Jul 27 19:56:41 2009 +1000 > > Make the pcp2.x RPM provide pcp-devel and pcp-libs > > This RPM packaging change makes it easier for dependent > packages such as pcp-gui to transition to pcp-3.x, where > we have split packaging: pcp, pcp-devel and pcp-libs. > > commit 3687851ac4ee2ccc1810b25fccb31c9935427cdf > Author: Nathan Scott > Date: Mon Jul 27 15:23:21 2009 +1000 > > Split apart the POSIX and Win32 daemon PMDA code in pmcd. > > No longer use a wrapper for the Win32 implementation either, which > allows us to have finer control over opened/closed file descriptors > and gives us a better shot at pipe agents (still not functional due > to fd inheritance, I think) and also keeps track of the child PIDs. > > commit ee52cf1d530317ed290e07bf3dc964b362e3ca5c > Author: Nathan Scott > Date: Mon Jul 27 14:07:54 2009 +1000 > > When starting a PMDA in socket mode, we must mark the file descriptor as such. > > In order for socket communication to function on Windows, socket fd's must be > flagged (and hence distinct from pipes, so we know whether to write/send there). > This gets socket-based daemon PMDAs to startup correctly under Win32 conditions. > > commit bd5862657c7f532369ea6e760a06a0aa9f81f74f > Author: Nathan Scott > Date: Mon Jul 27 14:04:17 2009 +1000 > > Fix a typo in a comment in pmcd code. > > commit 61c43f8885220a6e7d41624ace23d1157ef90e29 > Merge: 910d640... 3baf8e7... > Author: Mark Goodwin > Date: Mon Jul 27 09:37:33 2009 +1000 > > Merge branch '3.0.0' of git+ssh://markgw@oss.sgi.com/oss/git/markgw/pcp/pcp into dev > > commit 3baf8e7a6491c9533a1b0ff00c6d711a32677536 > Author: Mark Goodwin > Date: Mon Jul 27 09:32:57 2009 +1000 > > take -fstack-protector-all back out again since it's only supported with newer compilers. Probably should add a configure test for it at some stage > > Signed-off-by: Mark Goodwin > > commit eb409a0cb7c638a42e2546d7f6e67ac1aa0ac66c > Author: Josef 'Jeff' Sipek > Date: Mon Jul 27 08:45:50 2009 +1000 > > PowerDNS PMDA's packetcache_size and qsize_q are instant values, not counters > > commit c8728d91900e220159bc925084cb3a862a4a5d26 > Author: Nathan Scott > Date: Mon Jul 27 08:44:21 2009 +1000 > > Update pmlogger -x message - kill is now (cross-platform) pmsignal. > > commit 47a82efaefdc26f37ce62df6d736092b96c2ae61 > Author: Nathan Scott > Date: Thu Jul 23 15:18:20 2009 +1000 > > Tweak deb package long descriptions for bug 537563. > > commit 0b9600ede2f03f15d271ab812a703d0b606c4506 > Author: Josef 'Jeff' Sipek > Date: Thu Jul 23 14:49:30 2009 +1000 > > Add a new PMDA for the PowerDNS daemon (www.powerdns.com). > > commit df6f93cd1b2de0fc1e531cc568f4e53b73adf7e5 > Author: Nathan Scott > Date: Thu Jul 23 14:32:59 2009 +1000 > > Remove a duplicated metric from the MySQL PMDA. > > Problem reported by Josef Sipek, install of this PMDA now > fails due to reworking of the pmns generation code, before > this would have silently overwritten one metric with the > other (122 won in our production environment so I've kept > that) but now we check for this condition. > > commit 737b6904574678e174e5d8b969b91edce66c759a > Author: Nathan Scott > Date: Thu Jul 23 13:26:31 2009 +1000 > > Improve error reporting in pmcd on Windows. > > Should we be asked to open a UNIX domain socket channel to a > PMDA on Windows, improve the message for easier diagnosis. > > commit c87287e790d4636e2abbd98f223daa0c67c644e8 > Author: Nathan Scott > Date: Thu Jul 23 13:25:11 2009 +1000 > > Improve error reporting in PCP::PMDA perl module. > > When failing to build the PMNS file, additional diagnostics > would be helpful to pinpoint the source of the error. > > commit 910d640b1cdd749de83245523a24e2486a8f5cc2 > Merge: 7f3bf2c... 0c1b4b2... > Author: Mark Goodwin > Date: Thu Jul 23 11:39:22 2009 +1000 > > Merge branch '3.0.0' of git://oss.sgi.com/markgw/pcp/pcp into dev > > commit 0c1b4b2f4bd9b0759964fb056a1469b2dd052ce6 > Author: Mark Goodwin > Date: Wed Jul 22 17:02:40 2009 +1000 > > Tweak RPM dependency rules for 2.x -> 3.x upgrades and > massage the PCP RPM spec to reduce rpmlint noise. > > Also added -fstack-protector-all to Linux PCFLAGS. > > On branch 3.0.0: > modified: build/rpm/pcp.spec.in > modified: src/include/builddefs.in > > Signed-off-by: Mark Goodwin > > commit 7f3bf2c9a2966801f95c31f049291da8434faae4 > Author: Nathan Scott > Date: Wed Jul 22 13:37:47 2009 +1000 > > Ensure the Perl PMDA process runs in its own process group, > and ignore SIGTERM in the atexit handler. This resolves an > issue with the earlier fix for reaping children. > > commit d597f63b47a9eb8140c878bbc26c1434431c3096 > Author: Nathan Scott > Date: Wed Jul 22 11:52:09 2009 +1000 > > Comment out some diagnostics in named PMDA. > > commit c9b822c236f1bf219d830d1185d16cc9e87eae4c > Author: Rodney McKee > Date: Wed Jul 22 11:44:32 2009 +1000 > > Add the named PMDA, initially supporting BIND 9.4. > > commit cf003f4dddc1f26d2d7818f7c17bfd942a448ea2 > Merge: fee86f6... fcca602... > Author: Nathan Scott > Date: Wed Jul 22 10:18:55 2009 +1000 > > Merge branch 'dev' of git://oss.sgi.com/mort/pcp into dev > > commit fcca6023cd689ea5f48c6f6c538e2e21af67d32e > Author: Martin Hicks > Date: Tue Jul 21 17:34:05 2009 -0400 > > Do not create infiniband pmda config file by default > > In order to simplify monitoring in the simple case where a > machine has a single Infiniband interface, the config file is > no longer created by default. Instead, only local ports are > monitored. This does solve the problem where if an infiniband > card is replaced in a machine that the administrator no longer > has to remove the /var/lib/pcp/pmdas/ib/config file in order > to restore infiniband monitoring. > > For more advanced usage where static instance naming is required > or remote Infiniband ports must be monitored a config file can > still be created, but it is the responsibility of the administrator > to update the GUIDs if an HCA replacement is done. > > commit 840243974c106daae11368730043534d4684bc59 > Author: Martin Hicks > Date: Tue Jul 21 17:31:54 2009 -0400 > > Manpage for the infiniband PMDA > > commit fee86f6503252207a236c5eb81c8d092eede1a87 > Author: Nathan Scott > Date: Thu Jul 16 16:59:45 2009 +1000 > > Rework the special SGI CPU numbering logic in the Linux PMDA. > > This resolves a buffer overflow bug in the use of realpath(3) > in this routine, which was being passed a too-small buffer. > This issue was initially reported to us by Chandana De Silva, > but looks like others have come across it too, e.g.: > https://bugs.launchpad.net/ubuntu/+source/pcp/+bug/384776 > > I've removed the unused "cname" field from the per-CPU data > structure, and also added some short-circuit logic into this > code so that we bail out of this logic early if no hardware- > graph filesystem paths are detected (which will be the normal > case for most people). > > commit 67ae7fd90a32a43bbc97b939e57302556e864459 > Author: Nathan Scott > Date: Thu Jul 16 16:54:11 2009 +1000 > > Resolve a valgrind reported problem when initing Linux loadavg metric. > > Ensure read buffer is initialised to zero, and also check the return > code for a failed read syscall. > > commit 7f0167d8410147a6645699b0a385dc0c3bdfa5ac > Author: Martin Hicks > Date: Tue Jul 14 14:14:31 2009 -0400 > > Reserve domain ID 99 for SGI Ultra Violet PMDA > > commit de5188e9814f25c043dd278d3b3b9be0f3d8a306 > Author: Ken McDonell > Date: Sun Jul 12 07:51:13 2009 +1000 > > Increase domain from 8-bits to 9-bits. > > Cleaned up the use of the top bit as a flag for both a pmID and > a pmInDom ... now using a 1 bit flag field instead of the 2-bit > "pad" field. Changes required for PMNS parsing in libpcp and > internal handling of help text. > > Introduced PMDA_INTERFACE_4, but no code using this yet. > > Encoding and logic to handle dynamic PMNS entries introduced and > some local support in parsing and reporting local PMNS entries > (syntax for PMID in PMNS is :*:*) ... this means domain > number 511 (DYNAMIC_PMID) is now special and reserved. > > commit 3a0217c80b84c56d21bdd64f9d6396c9c583556d > Author: Nathan Scott > Date: Fri Jul 10 10:37:08 2009 +1000 > > Add a PCP::PMDA module check into PMDA Install path for Perl PMDAs. > > commit 2c278354dedbb229721ffbb6cd1934896095c4a7 > Author: Nathan Scott > Date: Fri Jul 10 10:35:08 2009 +1000 > > Make Perl PMDA module explicit wrt libpcp_pmda interface version used. > > > > _______________________________________________ > pcp mailing list > pcp@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/pcp From kenj@internode.on.net Mon Sep 28 18:21:57 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_33, J_CHICKENPOX_41,J_CHICKENPOX_63,J_CHICKENPOX_73,URIBL_BLACK autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n8SNLuuV164462 for ; Mon, 28 Sep 2009 18:21:57 -0500 X-ASG-Debug-ID: 1254180193-037402090000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 0DF36486B54 for ; Mon, 28 Sep 2009 16:23:13 -0700 (PDT) Received: from mail.internode.on.net (bld-mail19.adl2.internode.on.net [150.101.137.104]) by cuda.sgi.com with ESMTP id DtPbHF4qOxZ3y1Do for ; Mon, 28 Sep 2009 16:23:13 -0700 (PDT) Received: from [192.168.1.100] (unverified [118.208.169.2]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 5787217-1927428 for multiple; Tue, 29 Sep 2009 08:53:07 +0930 (CST) X-ASG-Orig-Subj: Re: [pcp] Dynamic PMNS changes finally arrive Subject: Re: [pcp] Dynamic PMNS changes finally arrive From: Ken McDonell Reply-To: kenj@internode.on.net To: Mark Goodwin Cc: pcp@oss.sgi.com In-Reply-To: <4AC14301.204@gmail.com> References: <1254034250.4466.12.camel@bozo-laptop.localdomain> <4AC14301.204@gmail.com> Content-Type: text/plain Date: Tue, 29 Sep 2009 09:22:55 +1000 Message-Id: <1254180175.7661.1.camel@bozo> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail19.adl2.internode.on.net[150.101.137.104] X-Barracuda-Start-Time: 1254180196 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0064 1.0000 -1.9794 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -0.98 X-Barracuda-Spam-Status: No, SCORE=-0.98 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M, BSF_RULE_7582B X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.10277 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M 0.50 BSF_RULE_7582B Custom Rule 7582B X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Sounds like a plan. If you're planning on running QA after merging my changes, you'll probably need my QA ... should I just go ahead and push those changes into the pcpqa tree on oss.sgi.com? On Tue, 2009-09-29 at 09:13 +1000, Mark Goodwin wrote: > Hi Ken, > > I have a round of changes (v3.0.0-6) to push up to the dev branch > (clean up "the mess" following the Fedora keel-haul, and also > integrates the perl packaging) - this is under QA at the moment, > which is taking longer than I'd hoped. > > In any case, I'll push 3.0.0-6 to 'dev' asap. Then I'll merge your > master branch and run a QA delta. If that goes OK I propose we push > this to (v3.0.0-7) for review and soak time in the dev branch since > the design is already reviewed. At the very least we'll need to > update the cluster PMDA before 3.0 can be considered release worthy. > > Cheers > -- Mark > > Ken McDonell wrote: > > Committed to the *master* branch of my PCP tree on oss.sgi.com > > > > There are several rounds of commits for this set of changes that became > > much more complicated and touched more files than I'd originally > > expected. > > > > This all passes my QA ... after I get some feedback on the PCP changes > > I'll move the QA tree forward. > > > > In the logs below there are lots of changes from the *master* and *dev* > > branches (this is a mess we need to sort out pronto!). Only the ones > > authored by me are really part of this batch of commmits, the others are > > innocent bystanders as a result of the passage of time. > > > > Changes committed to git://oss.sgi.com/kenj/pcp.git master > > > > .gitignore | 2 > > CHANGELOG | 33 + > > VERSION.pcp | 10 > > build/GNUmakefile | 3 > > build/rpm/pcp.spec.in | 39 +- > > build/rpm/pcp_fedora.spec | 385 +++++++++++++++++----- > > build/sun/GNUmakefile | 53 ++- > > configure.in | 99 ++++- > > debian/changelog | 21 + > > debian/control | 72 ++-- > > man/man1/GNUmakefile | 1 > > man/man1/newhelp.1 | 24 + > > man/man1/pmcd.1 | 6 > > man/man1/pmdaib.1 | 113 ++++++ > > man/man1/pmval.1 | 27 + > > man/man3/pmda.3 | 15 > > man/man3/pmdachildren.3 | 139 +++++++- > > man/man3/pmdamain.3 | 84 +++- > > man/man3/pmdaname.3 | 91 +++++ > > man/man3/pmdapmid.3 | 89 ++++- > > man/man4/pmns.4 | 45 +- > > src/cpan/MMV/Changes | 7 > > src/cpan/MMV/MMV.pm | 6 > > src/cpan/MMV/MMV.xs | 41 +- > > src/cpan/MMV/server.pl | 17 > > src/cpan/PMDA/Changes | 8 > > src/cpan/PMDA/PMDA.pm | 6 > > src/cpan/PMDA/PMDA.xs | 39 +- > > src/cpan/PMDA/local.c | 3 > > src/dbpmda/src/GNUmakefile | 2 > > src/dbpmda/src/dbpmda.c | 64 +++ > > src/dbpmda/src/dbpmda.h | 2 > > src/dbpmda/src/dso.c | 205 +++++++++-- > > src/dbpmda/src/gram.y | 43 ++ > > src/dbpmda/src/lex.l | 30 - > > src/dbpmda/src/pmda.c | 130 ++++++- > > src/dbpmda/src/util.c | 20 + > > src/genpmda/genpmda | 4 > > src/include/builddefs.in | 13 > > src/include/impl.h | 31 + > > src/include/mmv_stats.h | 2 > > src/include/pmda.h | 73 +++- > > src/libpcp/src/.gitignore | 3 > > src/libpcp/src/desc.c | 11 > > src/libpcp/src/fetchlocal.c | 28 + > > src/libpcp/src/help.c | 11 > > src/libpcp/src/instance.c | 46 +- > > src/libpcp/src/p_pmns.c | 2 > > src/libpcp/src/pmns.c | 139 ++++++-- > > src/libpcp/src/store.c | 14 > > src/libpcp/src/util.c | 34 + > > src/libpcp_gui/src/.gitignore | 3 > > src/libpcp_gui/src/GNUmakefile | 2 > > src/libpcp_mmv/src/.gitignore | 1 > > src/libpcp_mmv/src/mmv_stats.c | 65 ++- > > src/libpcp_pmcd/src/.gitignore | 1 > > src/libpcp_pmda/src/.gitignore | 1 > > src/libpcp_pmda/src/callback.c | 45 ++ > > src/libpcp_pmda/src/help.c | 2 > > src/libpcp_pmda/src/libdefs.h | 3 > > src/libpcp_pmda/src/mainloop.c | 261 ++++++++++++--- > > src/libpcp_pmda/src/open.c | 133 ++++--- > > src/libpcp_trace/src/.gitignore | 3 > > src/newhelp/chkhelp.c | 6 > > src/newhelp/newhelp.c | 50 ++ > > src/pmcd/GNUmakefile | 5 > > src/pmcd/migrate_pcp_var_dir | 126 ------- > > src/pmcd/pmdaproc.sh | 242 +++++++------ > > src/pmcd/rc_pcp | 14 > > src/pmcd/src/config.c | 163 +++++++-- > > src/pmcd/src/dofetch.c | 57 ++- > > src/pmcd/src/dopdus.c | 660 ++++++++++++++++++++++++++++++++------ > > src/pmcd/src/dostore.c | 14 > > src/pmcd/src/pmcd.h | 8 > > src/pmcd/src/pmcd.log | 198 +++++------ > > src/pmcd/src/sample.log | 4 > > src/pmcd/src/sendmail.log | 4 > > src/pmcd/src/simple.log | 4 > > src/pmcd/src/trace.log | 4 > > src/pmdas/GNUmakefile | 7 > > src/pmdas/ib/daemon.c | 20 - > > src/pmdas/ib/dso.c | 2 > > src/pmdas/ib/ib.c | 283 +++++++++------- > > src/pmdas/ib/ibpmda.h | 4 > > src/pmdas/ib/pmda.c | 4 > > src/pmdas/linux/proc_cpuinfo.c | 38 -- > > src/pmdas/linux/proc_cpuinfo.h | 1 > > src/pmdas/linux/proc_loadavg.c | 7 > > src/pmdas/mmv/.gitignore | 5 > > src/pmdas/mmv/GNUmakefile | 28 - > > src/pmdas/mmv/Install | 6 > > src/pmdas/mmv/Remove | 5 > > src/pmdas/mmv/mmv.c | 103 +++-- > > src/pmdas/mysql/pmdamysql.pl | 3 > > src/pmdas/named/.gitignore | 2 > > src/pmdas/named/GNUmakefile | 45 ++ > > src/pmdas/named/Install | 32 + > > src/pmdas/named/Remove | 25 + > > src/pmdas/named/pmdanamed.pl | 155 ++++++++ > > src/pmdas/pdns/.gitignore | 2 > > src/pmdas/pdns/GNUmakefile | 45 ++ > > src/pmdas/pdns/Install | 27 + > > src/pmdas/pdns/Remove | 25 + > > src/pmdas/pdns/pmdapdns.pl | 194 ++++++++++- > > src/pmdas/pmcd/src/pmcd.c | 12 > > src/pmdas/samba/.gitignore | 2 > > src/pmdas/samba/GNUmakefile | 49 ++ > > src/pmdas/samba/Install | 43 ++ > > src/pmdas/samba/Remove | 25 + > > src/pmdas/samba/pmdasamba.pl | 205 +++++++++++ > > src/pmdas/sample/help | 24 + > > src/pmdas/sample/pmns | 1 > > src/pmdas/sample/src/pmda.c | 2 > > src/pmdas/sample/src/sample.c | 362 ++++++++++++++++++-- > > src/pmdas/simple/pmdasimple.pl | 6 > > src/pmdas/solaris/GNUmakefile | 15 > > src/pmdas/solaris/common.h | 14 > > src/pmdas/solaris/data.c | 212 +++++++++++- > > src/pmdas/solaris/help | 95 +++++ > > src/pmdas/solaris/netmib2.c | 344 +++++++++++++++++++ > > src/pmdas/solaris/netmib2.h | 62 +++ > > src/pmdas/solaris/pmns.network | 31 + > > src/pmdas/solaris/pmns.zfs | 15 > > src/pmdas/solaris/pmns.zpool | 20 + > > src/pmdas/solaris/root | 5 > > src/pmdas/solaris/solaris.c | 7 > > src/pmdas/solaris/zfs.c | 164 ++++++++- > > src/pmdas/solaris/zpool.c | 226 ++++++++++--- > > src/pmdas/trace/GNUmakefile | 3 > > src/pmdas/trace/GNUmakefile.demos | 2 > > src/pmdas/trace/GNUmakefile.stub | 2 > > src/pmdas/windows/fetch.c | 91 ++--- > > src/pmdas/windows/libpdh.def | 1 > > src/pmdas/windows/libpdh.h | 20 + > > src/pmdas/windows/open.c | 13 > > src/pmdas/windows/pmda.c | 32 + > > src/pmdas/windows/pmns.kernel | 1 > > src/pmie/rc_pmie | 12 > > src/pmie/src/GNUmakefile | 2 > > src/pmlc/GNUmakefile | 2 > > src/pmlogextract/GNUmakefile | 2 > > src/pmlogger/GNUmakefile | 2 > > src/pmlogger/pmlogger.c | 3 > > src/pmns/Make.stdpmid | 8 > > src/pmns/ReplacePmnsSubtree | 8 > > src/pmns/pmnsutil.c | 5 > > src/pmns/stdpmid.pcp | 8 > > src/pmpost/GNUmakefile | 2 > > src/pmproxy/rc_pmproxy | 12 > > src/pmval/pmval.c | 55 ++- > > 150 files changed, 6178 insertions(+), 1581 deletions(-) > > > > commit 52872f6b735fbf7814443f226df21eee30b35936 > > Author: Ken McDonell > > Date: Sun Sep 27 16:30:09 2009 +1000 > > > > ReplacePmnsSubtree fix bad signal handling botch > > > > The trap handling was totally wrong in cleanup() ... causing the > > command "1" to be executed instead of the null command "". > > > > Exposed by another bug in a related area ... if the PMNS lock > > exists already, after the timeout in pmlock we fall into the > > trap cleanup() routine instead of charing on, so the script > > fails horribly (and leaves the stale lock file around). > > > > Also fixed an unlikely buffer over-run in mmv.c. > > > > commit 4087051b86b580d7c7cb6e50806edb4eaa63e4d4 > > Author: Ken McDonell > > Date: Sun Sep 27 15:20:24 2009 +1000 > > > > newhelp, dbpmda, libpcp, libpcp_pmda, pmcd, sample pmda - dynamic PMNS changes > > > > This is the final round of changes that get all of the changes for > > PMDA_INTERFACE_4 and the support of dynamic subtress of the PMNS where > > the PMDA (not PMCD) maintains knowledge of the PMNS. > > > > With these changes and a related round of QA changes, we're passing all > > of the QA tests (excluding the remote group that I cannot test at the > > moment, but are unlikely to find problems in this code). > > > > commit 40e120d100d8f8f2a638124edef1ac2a16c0b975 > > Author: Ken McDonell > > Date: Sun Sep 27 15:18:33 2009 +1000 > > > > pmdaproc.sh Revert changes for perl pmda setup. > > > > Just put it back the way it was before I started messing with it! > > > > commit 4cead6907bf315ed009725db26659d3c6e12c698 > > Author: Ken McDonell > > Date: Sun Sep 27 15:11:44 2009 +1000 > > > > pmdaproc.sh tweaking to improve QA success > > > > Add delays after sending pmcd SIGHUP and before checking for pmcd health > > to avoid small window where badness happens to pmcd from new PMDA, but > > after the test has been done. > > > > Also wound back previous Perl PMDA setup change as it does not help the > > QA test for the news PMDA ... reworked the QA test instead! > > > > commit 9371a85a8a5b65b43be732e585e1b8f98f4b94e1 > > Author: Ken McDonell > > Date: Thu Sep 24 16:59:07 2009 +1000 > > > > Only remake pmns file if it does not exist. > > > > Part of the perl PMDA support was unconditionally remaking pmns and > > domain.h ... this was reordering the metrics for the simple PMDA and > > causing QA tests 255 and 578 to fail ... more importantly if the > > pmns file already exists then there is no point in using the perl > > PMDA magic to recreate it. > > > > commit 4f6a801b054f92b23064385940a441bc66b758bd > > Merge: e421a49... 11549ac... > > Author: Ken McDonell > > Date: Thu Sep 17 20:00:33 2009 +1000 > > > > Merge branch 'master' of git://oss.sgi.com/kenj/pcp > > > > Conflicts: > > CHANGELOG > > VERSION.pcp > > src/pmcd/rc_pcp > > src/pmie/rc_pmie > > src/pmproxy/rc_pmproxy > > > > commit 11549aca86588c4695d26829e02f2ec9e7b43c3d > > Author: Nathan Scott > > Date: Mon Sep 7 16:29:34 2009 +1000 > > > > Bump pcp stable version to 2.9.2. > > > > commit 7997eea93ad9c240d2cbc7c2bfbd9ae21bb29e35 > > Author: Ken McDonell > > Date: Mon Sep 7 11:59:21 2009 +1000 > > > > Fix the number-of-samples value calculated in pmval once and for all. > > > > For those who care, it turns out that the number of _fetches_ may be > > known, the number of _reported_ samples cannot be precomputed correctly > > in all cases ... > > - only works for archives with -a (not -U or -h) > > - is known for non-counter metrics > > - most of the time is known for counter metrics but there are some > > important corner cases where this is not the case, specifically there > > will be one more reported sample than expected for a counter when the > > report starting time is not at the start of the archive and the metric > > has a defined value before the report starting time with no intervening > > mark record (interpolate mode does return a value at the first report > > sample in this case!). > > > > With this pmval patch, the QA fallout is nil, except for 144 that is an > > unrelated timezone problem. Also this patch avoids referencing the > > context too soon, as there is no point in inspecting the metric's > > semantics to try and better guess the value of smpls. As a bonus, this > > patch also documents pmval's -U option that has remained a secret for > > nearly a decade. > > > > commit f4e6d55fd0466a706144ca61b4428436ecea7eb7 > > Author: Nathan Scott > > Date: Mon Sep 7 11:51:58 2009 +1000 > > > > Attempt to resolve sys/stat related build issue on Alpha. > > > > Not having access to an Alpha makes this difficult, but one thing > > that is clearly not helping is that with Linux glibc on Alpha, we > > end up defining *both* HAVE_STAT_TIMESPEC and HAVE_STAT_TIME_T, & > > that breaks otherwise valid pmns.c coding assumptions. > > > > This change means only one type for the stat time fields can be > > defined, and it errs on the side of timespec (which should be the > > one Alpha uses, AFAICT) - so perhaps this issue will finally be > > resolved and PCP can progress in the Debian build/release system. > > > > commit be8793c58935362184a1dd4351388ca6a0013f3b > > Author: Nathan Scott > > Date: Mon Sep 7 11:26:09 2009 +1000 > > > > Fix mmv library build on mac/win - missing a header. > > > > commit 92eb7b896ff6eb83b2feef50e6a89c74c3aa1717 > > Author: Nathan Scott > > Date: Fri Sep 4 14:17:37 2009 +1000 > > > > Bump pcp stable version to 2.9.1. > > > > commit 2e890f3d1d9c4af31fc22af95cb7e0f20336523e > > Author: Nathan Scott > > Date: Fri Sep 4 14:15:16 2009 +1000 > > > > Correct pmval sample count calculation. > > > > Martin reported several QA tests were failing wrt pmval "samples" line. > > > > What I've found is the problem either exists/doesn't exist depending on > > several factors: > > - running on a 32 bit machine, Debian unstable, the problem never occurs > > no matter how pmval is built. > > - running on a 64 bit machine, Debian unstable, the problem only happens > > with the packaged binaries. The key factor appears to be the introduction > > of -O2, which looks like it reliably changes certain values on the stack, > > that would otherwise be zero (used uninitialised, in either case). > > > > There's two problems here, I believe: > > - in pmval.c the getargs() call initialises the value of "smpls" (number > > of samples to take) based on cntxt->desc.sem. However, at that point, > > we have not established a context yet, and so that field is uninitialised. > > - this test doesn't match the comment above it, and doesn't make sense: > > > > /* counters require 2 samples to produce reported sample */ > > if (*smpls > 0 && cntxt->desc.sem != PM_SEM_COUNTER) > > > > that would seem to me that it should be "cntxt->desc.sem == PM_SEM_COUNTER". > > > > commit 6940bbf89ca10d395fff93eeb7ce7424cec5d2ad > > Merge: b7bb608... 350246f... > > Author: Nathan Scott > > Date: Fri Sep 4 14:08:24 2009 +1000 > > > > Merge branch 'dev' of git://oss.sgi.com/nathans/pcp into dev > > > > commit 350246f0ba359876660994823d2e37b864040c3f > > Author: Nathan Scott > > Date: Thu Sep 3 12:59:57 2009 +1000 > > > > Another pass at getting the perl/debian packaging auto-deps right. > > > > commit 91c9f4a0a06d8e300c23f49feab09141c488b0f5 > > Author: Nathan Scott > > Date: Thu Sep 3 12:59:24 2009 +1000 > > > > Correct mmv install targets makefile macro. > > > > commit bf33333edbcf48ee84dad07cace240d6aff6cc99 > > Author: Nathan Scott > > Date: Wed Sep 2 15:07:19 2009 +1000 > > > > Workaround another oddity in (very) recent versions of autoconf. > > > > Problem found by the Debian autobuilders, in the pcp-gui build but it > > affects pcp too. Latest versions of autoconf evaluate AC_PROG_LEX in > > the compiler check macro, and complete remove any trace of AC_PROG_LEX > > from its original callsite. This results in a syntax error inside our > > configure script, as we call it within if ... fi, which then evaluates > > to having no body to the if. Ugh. Fix is trivial though, since these > > macros do the user-env-variable expansion thing already. > > > > commit efcb3b590f086feb1507f82716d2f0b6eee69d33 > > Author: Petter Reinholdtsen > > Date: Wed Sep 2 14:38:34 2009 +1000 > > > > Add missing dependencies and runlevels into PCP start scripts. > > > > With dependency based boot sequencing, I discovered what I believe is > > a bug in the init.d scripts of this package. The list of runlevels to > > stop in is incomplete. The script should stop in runlevel 1 to make > > sure the service is started again when switching from runlevel 1 to > > 2-5. Also, the script should probably stop during halt (0) and reboot > > (6). The package should start in runlevel 4, just like in runlevels > > 2, 3 and 5. I suspect the list of dependencies are incomplete. The > > scripts used to start after the syslog collector was operational, and > > should probably continue to do so. Also, the scripts need files in > > /usr/ and should depend on $remote_fs. > > > > If the scripts themselves need to start in any specific order, the > > relationship should be listed explicitly in the LSB header too. Make > > sure the update-rc.d calls in the postinst reflect this ordering if > > any such dependencies should exist. > > > > This patch implement the proposed change. Without it, the script seem > > to fail to handle runlevel 0, 1, 4 and 6 properly, and might start too > > early in the boot. > > > > commit 4aa31ed00a60c3926a53bbd8d47aa0b2eaf254c4 > > Merge: 35c230e... 3323bb9... > > Author: Nathan Scott > > Date: Wed Sep 2 13:18:44 2009 +1000 > > > > Merge branch 'dev' of git://oss.sgi.com/nathans/pcp into dev > > > > commit b7bb60801c2fc342b15473f1e3b341dd8ec7b84a > > Author: Nathan Scott > > Date: Wed Sep 2 12:38:19 2009 +1000 > > > > Update gitignore files for Mac and Windows library file names. > > > > commit 3323bb90ad5f66480c05b7fe182a72a0813c9b41 > > Author: Nathan Scott > > Date: Wed Sep 2 12:30:47 2009 +1000 > > > > Fix a segv observed in the Windows PMDA accessing SQL Server metrics. > > > > The recent optimisation added for direct instance domain lookup added > > a flaw that could case an array index of -1 to be used to access into > > the metric value table. Observed on SQL Server 2008 & Windows Server > > 2008 R2 only so far. > > > > commit 1112ac636cae6feac624279c76239003662d4a35 > > Author: Nathan Scott > > Date: Wed Sep 2 11:49:20 2009 +1000 > > > > Small MMV pmda changes to allow DSO builds in the future. > > > > Turns out that the current protocol for getting pmcd to > > update its namespace cannot be used from DSO agents ... > > one more reason to revamp this area. > > > > commit 677c6f2cea7fce4ff5f10f939fc5a942861719dd > > Author: Nathan Scott > > Date: Wed Sep 2 11:46:40 2009 +1000 > > > > Fix logic error causing wrong windows version to be reported. > > > > commit e421a49323307d49f6b897ae87f94c934b6fdcad > > Author: Ken McDonell > > Date: Tue Sep 1 17:44:22 2009 +1000 > > > > Interim commit for start of daemon PMDA support for dynamic PMNS. > > > > commit 210be7f679b10d71dda985fdebc7dd9aec5d606a > > Author: Nathan Scott > > Date: Fri Aug 28 08:44:50 2009 +1000 > > > > Correct some regular expressions in Samba PMDA. > > > > Of particular note, some of the heading lines in the > > smbstatus --profile output have trailing whitespace. > > Otherwise, this PMDA is now fully functional; and as > > it used the stock Samba utilities, is not dependent > > on the many flavours of Samba shmem format anymore. > > At the cost of a slight overhead increase, of course, > > but the original was unmaintainable. > > > > Thanks to James Peach for advise on redesigning this. > > > > commit 0758690bcbbf26db438560d5b5b94b1644979047 > > Author: Nathan Scott > > Date: Thu Aug 27 14:26:32 2009 +1000 > > > > Descend into samba PMDA during the build (SUBDIRS update). > > > > commit 9e758dd286ee2c49ecd991599a4c87a5520b9892 > > Author: Nathan Scott > > Date: Thu Aug 27 14:25:18 2009 +1000 > > > > Add kernel.all.uptime to the Windows kernel agent. > > > > This code uses the PdhGetFormatterCounterValue API, which we > > have not used before on Windows, hence the changes to libpdh > > header and dll definition files. > > > > commit b0cbeab4df3aec93a2f9749c7912dc8adc0b27ea > > Author: Nathan Scott > > Date: Thu Aug 27 10:21:28 2009 +1000 > > > > Rearrange platform-specific handling in pmdaproc.sh. > > > > Keep everything that does platform-specific stuff in one > > place now, run early on, instead of all over the shop. > > > > The code that handles determining whether the PCP::PMDA > > Perl module is installed is also reworked to not fail in > > the case where perl_opt is set, but user doesn't select > > that option when Install'ing a PMDA. This bit Mark with > > the simple PMDA, which has both Perl and C variants. > > > > commit ac9170cf888639cc731474d39cb100e9d7b2c519 > > Author: Nathan Scott > > Date: Thu Aug 27 09:20:14 2009 +1000 > > > > Initial version of the (perl-based) Samba PMDA. > > > > commit e00aafe76a538ad09322499c2f669450d3b0c486 > > Author: Nathan Scott > > Date: Wed Aug 26 11:46:12 2009 +1000 > > > > Fix inconsistent metric name in pmdasimple.pl - simple.now was wrong. > > > > commit e937d8332c9dc6a0f4d5ea5fb10b6d3530b7261b > > Author: Nathan Scott > > Date: Wed Aug 26 11:02:55 2009 +1000 > > > > Remove hard-coded path in the perl variant of the simple PMDA (thanks Mark). > > > > commit 531de7440179d323c8774fad2a4c13ac4c21bcbb > > Author: Nathan Scott > > Date: Wed Aug 26 11:00:00 2009 +1000 > > > > Use PM_IN_NULL in pmdasimple.pl so it functions correctly on all platforms. > > > > commit 956be698fe2de60b96c2c6fa72be1555a1c3cf7c > > Merge: 7bf0f27... b8cb2dd... > > Author: Nathan Scott > > Date: Mon Aug 24 10:58:57 2009 +1000 > > > > Merge branch 'dev' of git://oss.sgi.com/nathans/pcp into dev > > > > commit 7bf0f27d27c11db4002699e74611ef718551add3 > > Merge: 309e7be... 3db8e4f... > > Author: Nathan Scott > > Date: Mon Aug 24 10:57:30 2009 +1000 > > > > Merge branch 'solaris' of git://oss.sgi.com/makc/pcp into dev > > > > commit 309e7be90719ebc12bc66e9a06999909e7f66c16 > > Author: Nathan Scott > > Date: Mon Aug 24 09:03:19 2009 +1000 > > > > Add PCP::PMDA helper routines for determining native long sizes. > > > > commit 90e8cd865a6bfabf91315feea3743054a1511111 > > Author: Nathan Scott > > Date: Mon Aug 24 09:01:38 2009 +1000 > > > > Extend MMV to allow teardown of MMV file, and set errno on failure. > > > > Setting errno helps alot with diagnosing mmv_stats_init() failures. > > > > commit d4732eb5d60d8d31bb6eba69daa2787befb34325 > > Author: Nathan Scott > > Date: Mon Aug 24 08:56:24 2009 +1000 > > > > Initial stable (1.00) version of MMV Perl interface. > > > > Changes include: > > - added stop interface > > - added stats_set interface > > - fixed incorrect memory free on init > > - extend server.pl example to report idle time > > - fixed use of av_len return codes (off by one) > > > > commit 3db8e4f3626241cb40e52f36a691263c8aaa34ff > > Author: Max Matveev > > Date: Mon Aug 17 18:52:49 2009 +1000 > > > > Release zpool resources when finished updates > > > > It's not documented but it's obvious that zpool_iter expects the > > callback to call zpool_close to release resources associated with > > the zpool - it's not a problem for short-lived commands like zpool(1) > > but it leaks memory like a firehose. > > > > commit 35c230ef34a191bbb5b8f12b91d122e2863ac740 > > Author: Nathan Scott > > Date: Fri Aug 14 14:58:10 2009 +1000 > > > > Correct the metric units for several Windows per-process memory metrics. > > > > commit 758b2b7039e878189b42fab6d8d3a789a27810d1 > > Author: Max Matveev > > Date: Wed Aug 12 00:01:59 2009 +1000 > > > > Eliminate incidents of crime against whitespace > > > > commit 012af5fa4e16029513c6d1c2ff7c7a3d4a3069e3 > > Author: Max Matveev > > Date: Tue Aug 11 23:55:59 2009 +1000 > > > > Hide instances for destroyed pools and filesystems > > > > In Solaris PMDA if a zpool or a zfs is removed make sure that the > > corresponding instance disappears from the list of instances returned on > > fetch. > > > > commit a8cbf7b86b1bab119246006b23b1114fe1b4b9d7 > > Author: Ken McDonell > > Date: Fri Aug 7 11:22:23 2009 +1000 > > > > Revert __pmProcessTerminate() change. > > > > Since perl PMDAs are now all running in their own process group revert > > to allow kill(0, ...) to proceed. > > > > commit 8ea858d245d093ed3285e0e4370303bd678cc468 > > Merge: 9b4b935... ead91ff... > > Author: Ken McDonell > > Date: Thu Aug 6 18:35:49 2009 +1000 > > > > Merge branch 'dev' into pmns > > > > commit 9b4b9351a7e41bc21f893063e0311accd7cee046 > > Author: Ken McDonell > > Date: Thu Aug 6 18:18:10 2009 +1000 > > > > Guard in _pmProcessTerminate() to prevent killing all member of process group. > > > > Problem exposed by qa/162 and perl implementation of news pmda. > > > > commit 7f72e4acff1b876b10e6f6432a55de2e49b9e148 > > Author: Ken McDonell > > Date: Thu Aug 6 18:16:49 2009 +1000 > > > > Second round of changes for PMDA_INTERFACE_4 dynamic metrics. > > > > DSO mode PMDAs (sampledso) is very close to working correctly now. > > > > commit ead91ffca2605502c3552ffbc228ffbc0ed3ecc3 > > Author: Mark Goodwin > > Date: Thu Aug 6 12:14:25 2009 +1000 > > > > update changelog and delete unncessary Vendor string > > > > Signed-off-by: Mark Goodwin > > > > commit b77cb57bb669b1129c1241f7818fe75935390a3b > > Author: Mark Goodwin > > Date: Thu Aug 6 12:06:23 2009 +1000 > > > > also bump the src tarball version > > > > Signed-off-by: Mark Goodwin > > > > commit 6c8311051895092662b8ee1986945a3846577b04 > > Author: Mark Goodwin > > Date: Thu Aug 6 12:01:24 2009 +1000 > > > > bump to 3.0.0-2 > > > > Signed-off-by: Mark Goodwin > > > > commit 99aa1c21c22e64350ba750284039653750633540 > > Merge: ef9852c... f2866c9... > > Author: Mark Goodwin > > Date: Thu Aug 6 11:37:29 2009 +1000 > > > > merge pcp-2.9.0-1 dev > > > > modified: CHANGELOG > > modified: build/rpm/pcp.spec.in > > modified: debian/changelog > > modified: debian/control > > modified: src/cpan/PMDA/PMDA.xs > > modified: src/libpcp_pmda/src/open.c > > modified: src/pmcd/src/config.c > > modified: src/pmdas/GNUmakefile > > modified: src/pmdas/mysql/pmdamysql.pl > > new file: src/pmdas/pdns/.gitignore > > new file: src/pmdas/pdns/GNUmakefile > > new file: src/pmdas/pdns/Install > > new file: src/pmdas/pdns/Remove > > new file: src/pmdas/pdns/pmdapdns.pl > > modified: src/pmlogger/pmlogger.c > > modified: src/pmns/stdpmid.pcp > > > > Signed-off-by: Mark Goodwin > > > > commit ef9852c99666359cdacb1afe65dcac16460ea0ab > > Author: Mark Goodwin > > Date: Thu Aug 6 11:05:12 2009 +1000 > > > > Changes to the Fedora RPM spec in response to review feedback: > > - Incorporate a large number of suggestions and cleanups from Eric Sandeen > > - Greatly simplified the %post and %postun scriptlets - remove ancient crud > > - Added ldconfig scriptlets for -libs > > - Don't explicitly require IB libs, since they're libs and RPM figures it out > > - No need to explicitly BuildRequire gcc-c++ libstdc++-devel > > - Add BuildRequires on perl-ExtUtils-MakeMaker > > - Remove explicit ia64 Requires: libunwind > > - Have pcp-libs require the base package since Fedora insists > > - Add and clarify some comments > > - Create %{_localstatedir}/run/pcp and ship it (so it'll be removed) > > - Use %doc for CHANGELOG COPYING INSTALL README VERSION.pcp pcp.lsm > > > > Signed-off-by: Mark Goodwin > > > > commit 88c3b113c45f61d8959b95f0486d5d625b8c85af > > Author: Mark Goodwin > > Date: Thu Aug 6 10:17:51 2009 +1000 > > > > git ignore generated gram*.tab.c > > > > Signed-off-by: Mark Goodwin > > > > commit 0fe594271c4635432616eaec4640b38773d150cc > > Author: Mark Goodwin > > Date: Thu Aug 6 10:12:55 2009 +1000 > > > > preserve generated gram.tab.c because debuginfo needs it > > > > Signed-off-by: Mark Goodwin > > > > commit 385ce8e19c550792fd61a4e6112408c208b75649 > > Author: Mark Goodwin > > Date: Thu Aug 6 09:21:48 2009 +1000 > > > > fix minor typo in comment > > > > Signed-off-by: Mark Goodwin > > > > commit b8cb2dd7c9b5d33e473bf0d89a64da3c2b2eec92 > > Merge: 1c47a24... 684232a... > > Author: Nathan Scott > > Date: Wed Aug 5 16:52:11 2009 +1000 > > > > Merge branch 'solaris' of git://oss.sgi.com/makc/pcp into dev > > > > commit 1c47a24dbef502d09439e663b727a2bf85e5499d > > Author: Nathan Scott > > Date: Wed Aug 5 16:51:47 2009 +1000 > > > > Ignore all MMV files that begin with a period. > > > > commit 4bc076258e025f86b6215783933f7adcb77ace90 > > Author: Max Matveev > > Date: Wed Aug 5 02:10:37 2009 +1000 > > > > Add network metrics to Solaris PMDA > > > > Use MIB2 interface available via TI to extract IPv4 interfaces and UDP stats > > from the kernel. > > > > The good/bad fetch is on the whole group - if any of the sources fail (even if > > we don't use them like IPv6 interface stats) then whole fetch will return no > > data. > > > > Fetch callback still uses offset for the metrics which have indoms, for > > singular metrics a pointer to the global storage is used whence the change > > of type in md_offset. > > > > commit 4e1e119bfb7cfa6d09c81049fec95d3dc9e13356 > > Author: Mark Goodwin > > Date: Tue Aug 4 12:19:07 2009 +1000 > > > > dont install trace demo binaries since src is installed anyway > > > > Signed-off-by: Mark Goodwin > > > > commit 234ffe3f3badbf73768f114fa692eac0dd7ec079 > > Author: Max Matveev > > Date: Mon Aug 3 10:33:41 2009 +1000 > > > > Report ZFS statistics from Solaris PMDA > > > > Use libzfs interfaces to extract some data about ZFS "dataset". Datasets > > are filesystems, snapshots and volumes, the reported data include information > > about used and available space, compression ratios, number of copies, > > reserved space per dataset. Space utilization is additionally broken down > > into space used by children, space used by snapshot and space used by the > > dataset itself. > > > > commit 5da67384ae7719254afd7d76d8b10558b9d3de07 > > Author: Max Matveev > > Date: Mon Aug 3 01:59:01 2009 +1000 > > > > Export zpool stats from Solaris PMDA > > > > Use libzfs to extract zpool stats like capacity, iops, bandwidth etc > > > > commit 684232a1b6178de4a07edbd0e3308f49789992fb > > Author: Max Matveev > > Date: Sun Aug 2 23:05:11 2009 +1000 > > > > Put 64 bit libraries into the right place on Solaris > > > > Solaris keeps its 64 bit shared libraries in /usr/lib/64 - use the pointer > > size to decide if we're building 32 or 64 bit version and push the library > > in the right place. > > > > commit 3cf745f62c0099577265994de97c0a755cb06f9b > > Author: Max Matveev > > Date: Sun Aug 2 04:11:32 2009 +1000 > > > > Generate packages for Solaris > > > > commit 74c7543c88bc3776b81ae8a5eab4de940537ffdd > > Author: Max Matveev > > Date: Sun Aug 2 03:03:35 2009 +1000 > > > > Allow user to choose her compiler > > > > New autoconf attempts to compile the headers as part of AC_HEADER_CHECK. > > It AC_PROG_CC is not called then AC_HEADER_CHECK generates scary warning - > > just call AC_PROG_CC unconditionally: it will honour CC from the environment > > but it will also do the right things about later checks. > > > > On Solaris if the alternative compiler is not GCC then don't feed it > > GNU options. > > > > commit 5dc76a384254b3a0b1a72ff1be5faec042effa73 > > Author: Mark Goodwin > > Date: Fri Jul 31 15:44:40 2009 +1000 > > > > RPM spec specifically for the Fedora Project. > > > > Signed-off-by: Mark Goodwin > > > > commit 1274605472853400f4297439c433a05829735a64 > > Author: Mark Goodwin > > Date: Fri Jul 31 15:40:58 2009 +1000 > > > > tweak configure to move PCP_BINADM_DIR out of /usr/share, into /usr/lib. > > Arch dependent binaries should not be installed below /usr/share. > > > > Signed-off-by: Mark Goodwin > > > > commit 17700e2bdaa0060178c3d025edb92280f36451f6 > > Author: Mark Goodwin > > Date: Fri Jul 31 11:47:39 2009 +1000 > > > > delete unneeded explicit script interpreter to keep rpmlint happy > > > > Signed-off-by: Mark Goodwin > > > > commit b971772c281a5aff6408981e7086cbfa4bcee6ba > > Author: Mark Goodwin > > Date: Fri Jul 31 11:33:20 2009 +1000 > > > > pmpost does not really need to be setuid > > > > Signed-off-by: Mark Goodwin > > > > commit 0a4cd4b8bfe44265bdccfb93db5e19c28c796f79 > > Author: Mark Goodwin > > Date: Fri Jul 31 11:11:48 2009 +1000 > > > > Nuke migrate_pcp_var_dir, no longer needed > > > > Signed-off-by: Mark Goodwin > > > > commit bf98168e8a7cea7697497f4972dd835fa10e29b6 > > Author: Mark Goodwin > > Date: Thu Jul 30 18:25:12 2009 +1000 > > > > default chkconfig off for all PCP services > > > > Signed-off-by: Mark Goodwin > > > > commit 679b9d50fa63430066fbf8343607205dd46d20f7 > > Author: Ken McDonell > > Date: Wed Jul 29 20:38:59 2009 +1000 > > > > Initial work for PMDA_INTERFACE_4 and new sample.secret.* dynamic metrics. > > > > commit 6c17c674360b6d6738f37bb9330fdb607dd1c872 > > Author: Ken McDonell > > Date: Wed Jul 29 20:38:07 2009 +1000 > > > > Remove log files that were added by mistake. > > > > commit a707483a5af651b430b9e2b4a193a5b64585e6e9 > > Author: Ken McDonell > > Date: Wed Jul 29 20:34:10 2009 +1000 > > > > Second round of PMDA_INTERFACE_4 and dynamic PMNS changes. > > > > Gets things working for DSO PMDAs. > > > > commit 8e0f63dbb6ae77a2d526e9472b85d8de1b5bab84 > > Author: Ken McDonell > > Date: Wed Jul 29 20:31:52 2009 +1000 > > > > Extending domain number to 9 bits (continued). > > > > commit f2866c9e1bf8c9a70213ed4cd859d437b9af6bad > > Author: Mark Goodwin > > Date: Mon Jul 27 19:59:39 2009 +1000 > > > > Bump version to 2.9.0. > > > > commit d3f630a269c73017407b46713bb75b91a7516475 > > Author: Mark Goodwin > > Date: Mon Jul 27 19:57:22 2009 +1000 > > > > Tweak Debian perl packaging with explicit dependencies, resolving build warnings. > > > > commit e69333488d42d8b3b1a8f35ea1f9ea3b2f12ad35 > > Author: Mark Goodwin > > Date: Mon Jul 27 19:56:41 2009 +1000 > > > > Make the pcp2.x RPM provide pcp-devel and pcp-libs > > > > This RPM packaging change makes it easier for dependent > > packages such as pcp-gui to transition to pcp-3.x, where > > we have split packaging: pcp, pcp-devel and pcp-libs. > > > > commit 3687851ac4ee2ccc1810b25fccb31c9935427cdf > > Author: Nathan Scott > > Date: Mon Jul 27 15:23:21 2009 +1000 > > > > Split apart the POSIX and Win32 daemon PMDA code in pmcd. > > > > No longer use a wrapper for the Win32 implementation either, which > > allows us to have finer control over opened/closed file descriptors > > and gives us a better shot at pipe agents (still not functional due > > to fd inheritance, I think) and also keeps track of the child PIDs. > > > > commit ee52cf1d530317ed290e07bf3dc964b362e3ca5c > > Author: Nathan Scott > > Date: Mon Jul 27 14:07:54 2009 +1000 > > > > When starting a PMDA in socket mode, we must mark the file descriptor as such. > > > > In order for socket communication to function on Windows, socket fd's must be > > flagged (and hence distinct from pipes, so we know whether to write/send there). > > This gets socket-based daemon PMDAs to startup correctly under Win32 conditions. > > > > commit bd5862657c7f532369ea6e760a06a0aa9f81f74f > > Author: Nathan Scott > > Date: Mon Jul 27 14:04:17 2009 +1000 > > > > Fix a typo in a comment in pmcd code. > > > > commit 61c43f8885220a6e7d41624ace23d1157ef90e29 > > Merge: 910d640... 3baf8e7... > > Author: Mark Goodwin > > Date: Mon Jul 27 09:37:33 2009 +1000 > > > > Merge branch '3.0.0' of git+ssh://markgw@oss.sgi.com/oss/git/markgw/pcp/pcp into dev > > > > commit 3baf8e7a6491c9533a1b0ff00c6d711a32677536 > > Author: Mark Goodwin > > Date: Mon Jul 27 09:32:57 2009 +1000 > > > > take -fstack-protector-all back out again since it's only supported with newer compilers. Probably should add a configure test for it at some stage > > > > Signed-off-by: Mark Goodwin > > > > commit eb409a0cb7c638a42e2546d7f6e67ac1aa0ac66c > > Author: Josef 'Jeff' Sipek > > Date: Mon Jul 27 08:45:50 2009 +1000 > > > > PowerDNS PMDA's packetcache_size and qsize_q are instant values, not counters > > > > commit c8728d91900e220159bc925084cb3a862a4a5d26 > > Author: Nathan Scott > > Date: Mon Jul 27 08:44:21 2009 +1000 > > > > Update pmlogger -x message - kill is now (cross-platform) pmsignal. > > > > commit 47a82efaefdc26f37ce62df6d736092b96c2ae61 > > Author: Nathan Scott > > Date: Thu Jul 23 15:18:20 2009 +1000 > > > > Tweak deb package long descriptions for bug 537563. > > > > commit 0b9600ede2f03f15d271ab812a703d0b606c4506 > > Author: Josef 'Jeff' Sipek > > Date: Thu Jul 23 14:49:30 2009 +1000 > > > > Add a new PMDA for the PowerDNS daemon (www.powerdns.com). > > > > commit df6f93cd1b2de0fc1e531cc568f4e53b73adf7e5 > > Author: Nathan Scott > > Date: Thu Jul 23 14:32:59 2009 +1000 > > > > Remove a duplicated metric from the MySQL PMDA. > > > > Problem reported by Josef Sipek, install of this PMDA now > > fails due to reworking of the pmns generation code, before > > this would have silently overwritten one metric with the > > other (122 won in our production environment so I've kept > > that) but now we check for this condition. > > > > commit 737b6904574678e174e5d8b969b91edce66c759a > > Author: Nathan Scott > > Date: Thu Jul 23 13:26:31 2009 +1000 > > > > Improve error reporting in pmcd on Windows. > > > > Should we be asked to open a UNIX domain socket channel to a > > PMDA on Windows, improve the message for easier diagnosis. > > > > commit c87287e790d4636e2abbd98f223daa0c67c644e8 > > Author: Nathan Scott > > Date: Thu Jul 23 13:25:11 2009 +1000 > > > > Improve error reporting in PCP::PMDA perl module. > > > > When failing to build the PMNS file, additional diagnostics > > would be helpful to pinpoint the source of the error. > > > > commit 910d640b1cdd749de83245523a24e2486a8f5cc2 > > Merge: 7f3bf2c... 0c1b4b2... > > Author: Mark Goodwin > > Date: Thu Jul 23 11:39:22 2009 +1000 > > > > Merge branch '3.0.0' of git://oss.sgi.com/markgw/pcp/pcp into dev > > > > commit 0c1b4b2f4bd9b0759964fb056a1469b2dd052ce6 > > Author: Mark Goodwin > > Date: Wed Jul 22 17:02:40 2009 +1000 > > > > Tweak RPM dependency rules for 2.x -> 3.x upgrades and > > massage the PCP RPM spec to reduce rpmlint noise. > > > > Also added -fstack-protector-all to Linux PCFLAGS. > > > > On branch 3.0.0: > > modified: build/rpm/pcp.spec.in > > modified: src/include/builddefs.in > > > > Signed-off-by: Mark Goodwin > > > > commit 7f3bf2c9a2966801f95c31f049291da8434faae4 > > Author: Nathan Scott > > Date: Wed Jul 22 13:37:47 2009 +1000 > > > > Ensure the Perl PMDA process runs in its own process group, > > and ignore SIGTERM in the atexit handler. This resolves an > > issue with the earlier fix for reaping children. > > > > commit d597f63b47a9eb8140c878bbc26c1434431c3096 > > Author: Nathan Scott > > Date: Wed Jul 22 11:52:09 2009 +1000 > > > > Comment out some diagnostics in named PMDA. > > > > commit c9b822c236f1bf219d830d1185d16cc9e87eae4c > > Author: Rodney McKee > > Date: Wed Jul 22 11:44:32 2009 +1000 > > > > Add the named PMDA, initially supporting BIND 9.4. > > > > commit cf003f4dddc1f26d2d7818f7c17bfd942a448ea2 > > Merge: fee86f6... fcca602... > > Author: Nathan Scott > > Date: Wed Jul 22 10:18:55 2009 +1000 > > > > Merge branch 'dev' of git://oss.sgi.com/mort/pcp into dev > > > > commit fcca6023cd689ea5f48c6f6c538e2e21af67d32e > > Author: Martin Hicks > > Date: Tue Jul 21 17:34:05 2009 -0400 > > > > Do not create infiniband pmda config file by default > > > > In order to simplify monitoring in the simple case where a > > machine has a single Infiniband interface, the config file is > > no longer created by default. Instead, only local ports are > > monitored. This does solve the problem where if an infiniband > > card is replaced in a machine that the administrator no longer > > has to remove the /var/lib/pcp/pmdas/ib/config file in order > > to restore infiniband monitoring. > > > > For more advanced usage where static instance naming is required > > or remote Infiniband ports must be monitored a config file can > > still be created, but it is the responsibility of the administrator > > to update the GUIDs if an HCA replacement is done. > > > > commit 840243974c106daae11368730043534d4684bc59 > > Author: Martin Hicks > > Date: Tue Jul 21 17:31:54 2009 -0400 > > > > Manpage for the infiniband PMDA > > > > commit fee86f6503252207a236c5eb81c8d092eede1a87 > > Author: Nathan Scott > > Date: Thu Jul 16 16:59:45 2009 +1000 > > > > Rework the special SGI CPU numbering logic in the Linux PMDA. > > > > This resolves a buffer overflow bug in the use of realpath(3) > > in this routine, which was being passed a too-small buffer. > > This issue was initially reported to us by Chandana De Silva, > > but looks like others have come across it too, e.g.: > > https://bugs.launchpad.net/ubuntu/+source/pcp/+bug/384776 > > > > I've removed the unused "cname" field from the per-CPU data > > structure, and also added some short-circuit logic into this > > code so that we bail out of this logic early if no hardware- > > graph filesystem paths are detected (which will be the normal > > case for most people). > > > > commit 67ae7fd90a32a43bbc97b939e57302556e864459 > > Author: Nathan Scott > > Date: Thu Jul 16 16:54:11 2009 +1000 > > > > Resolve a valgrind reported problem when initing Linux loadavg metric. > > > > Ensure read buffer is initialised to zero, and also check the return > > code for a failed read syscall. > > > > commit 7f0167d8410147a6645699b0a385dc0c3bdfa5ac > > Author: Martin Hicks > > Date: Tue Jul 14 14:14:31 2009 -0400 > > > > Reserve domain ID 99 for SGI Ultra Violet PMDA > > > > commit de5188e9814f25c043dd278d3b3b9be0f3d8a306 > > Author: Ken McDonell > > Date: Sun Jul 12 07:51:13 2009 +1000 > > > > Increase domain from 8-bits to 9-bits. > > > > Cleaned up the use of the top bit as a flag for both a pmID and > > a pmInDom ... now using a 1 bit flag field instead of the 2-bit > > "pad" field. Changes required for PMNS parsing in libpcp and > > internal handling of help text. > > > > Introduced PMDA_INTERFACE_4, but no code using this yet. > > > > Encoding and logic to handle dynamic PMNS entries introduced and > > some local support in parsing and reporting local PMNS entries > > (syntax for PMID in PMNS is :*:*) ... this means domain > > number 511 (DYNAMIC_PMID) is now special and reserved. > > > > commit 3a0217c80b84c56d21bdd64f9d6396c9c583556d > > Author: Nathan Scott > > Date: Fri Jul 10 10:37:08 2009 +1000 > > > > Add a PCP::PMDA module check into PMDA Install path for Perl PMDAs. > > > > commit 2c278354dedbb229721ffbb6cd1934896095c4a7 > > Author: Nathan Scott > > Date: Fri Jul 10 10:35:08 2009 +1000 > > > > Make Perl PMDA module explicit wrt libpcp_pmda interface version used. > > > > > > > > _______________________________________________ > > pcp mailing list > > pcp@oss.sgi.com > > http://oss.sgi.com/mailman/listinfo/pcp > From goodwinos@gmail.com Mon Sep 28 19:58:12 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_33, J_CHICKENPOX_41,J_CHICKENPOX_63,J_CHICKENPOX_73 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n8T0wBk5169663 for ; Mon, 28 Sep 2009 19:58:12 -0500 X-ASG-Debug-ID: 1254185969-31a0005e0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mx1.redhat.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 22CA2B969C5 for ; Mon, 28 Sep 2009 17:59:30 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id JTXBxzsNUXNkf47G for ; Mon, 28 Sep 2009 17:59:30 -0700 (PDT) Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8T0xOji028307; Mon, 28 Sep 2009 20:59:25 -0400 Received: from [10.11.9.23] (vpn-9-23.rdu.redhat.com [10.11.9.23]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n8T0xC3k025554; Mon, 28 Sep 2009 20:59:16 -0400 Message-ID: <4AC15BDF.8050903@gmail.com> Date: Tue, 29 Sep 2009 10:59:11 +1000 From: Mark Goodwin User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: kenj@internode.on.net CC: pcp@oss.sgi.com X-ASG-Orig-Subj: Re: [pcp] Dynamic PMNS changes finally arrive Subject: Re: [pcp] Dynamic PMNS changes finally arrive References: <1254034250.4466.12.camel@bozo-laptop.localdomain> <4AC14301.204@gmail.com> <1254180175.7661.1.camel@bozo> In-Reply-To: <1254180175.7661.1.camel@bozo> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 10.5.11.17 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1254185971 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0001 1.0000 -2.0201 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.02 X-Barracuda-Spam-Status: No, SCORE=-1.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M, BSF_RULE_7582B X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.10282 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M 0.50 BSF_RULE_7582B Custom Rule 7582B X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Ken McDonell wrote: > Sounds like a plan. > > If you're planning on running QA after merging my changes, you'll > probably need my QA ... should I just go ahead and push those changes > into the pcpqa tree on oss.sgi.com? might as well, perhaps commit a tag first, see git-tag(1), something like "prior to dynamic pmns". What QA platforms h/w and s/w are you running on? Cheers - Mark > > On Tue, 2009-09-29 at 09:13 +1000, Mark Goodwin wrote: >> Hi Ken, >> >> I have a round of changes (v3.0.0-6) to push up to the dev branch >> (clean up "the mess" following the Fedora keel-haul, and also >> integrates the perl packaging) - this is under QA at the moment, >> which is taking longer than I'd hoped. >> >> In any case, I'll push 3.0.0-6 to 'dev' asap. Then I'll merge your >> master branch and run a QA delta. If that goes OK I propose we push >> this to (v3.0.0-7) for review and soak time in the dev branch since >> the design is already reviewed. At the very least we'll need to >> update the cluster PMDA before 3.0 can be considered release worthy. >> >> Cheers >> -- Mark >> >> Ken McDonell wrote: >>> Committed to the *master* branch of my PCP tree on oss.sgi.com >>> >>> There are several rounds of commits for this set of changes that became >>> much more complicated and touched more files than I'd originally >>> expected. >>> >>> This all passes my QA ... after I get some feedback on the PCP changes >>> I'll move the QA tree forward. >>> >>> In the logs below there are lots of changes from the *master* and *dev* >>> branches (this is a mess we need to sort out pronto!). Only the ones >>> authored by me are really part of this batch of commmits, the others are >>> innocent bystanders as a result of the passage of time. >>> >>> Changes committed to git://oss.sgi.com/kenj/pcp.git master >>> >>> .gitignore | 2 >>> CHANGELOG | 33 + >>> VERSION.pcp | 10 >>> build/GNUmakefile | 3 >>> build/rpm/pcp.spec.in | 39 +- >>> build/rpm/pcp_fedora.spec | 385 +++++++++++++++++----- >>> build/sun/GNUmakefile | 53 ++- >>> configure.in | 99 ++++- >>> debian/changelog | 21 + >>> debian/control | 72 ++-- >>> man/man1/GNUmakefile | 1 >>> man/man1/newhelp.1 | 24 + >>> man/man1/pmcd.1 | 6 >>> man/man1/pmdaib.1 | 113 ++++++ >>> man/man1/pmval.1 | 27 + >>> man/man3/pmda.3 | 15 >>> man/man3/pmdachildren.3 | 139 +++++++- >>> man/man3/pmdamain.3 | 84 +++- >>> man/man3/pmdaname.3 | 91 +++++ >>> man/man3/pmdapmid.3 | 89 ++++- >>> man/man4/pmns.4 | 45 +- >>> src/cpan/MMV/Changes | 7 >>> src/cpan/MMV/MMV.pm | 6 >>> src/cpan/MMV/MMV.xs | 41 +- >>> src/cpan/MMV/server.pl | 17 >>> src/cpan/PMDA/Changes | 8 >>> src/cpan/PMDA/PMDA.pm | 6 >>> src/cpan/PMDA/PMDA.xs | 39 +- >>> src/cpan/PMDA/local.c | 3 >>> src/dbpmda/src/GNUmakefile | 2 >>> src/dbpmda/src/dbpmda.c | 64 +++ >>> src/dbpmda/src/dbpmda.h | 2 >>> src/dbpmda/src/dso.c | 205 +++++++++-- >>> src/dbpmda/src/gram.y | 43 ++ >>> src/dbpmda/src/lex.l | 30 - >>> src/dbpmda/src/pmda.c | 130 ++++++- >>> src/dbpmda/src/util.c | 20 + >>> src/genpmda/genpmda | 4 >>> src/include/builddefs.in | 13 >>> src/include/impl.h | 31 + >>> src/include/mmv_stats.h | 2 >>> src/include/pmda.h | 73 +++- >>> src/libpcp/src/.gitignore | 3 >>> src/libpcp/src/desc.c | 11 >>> src/libpcp/src/fetchlocal.c | 28 + >>> src/libpcp/src/help.c | 11 >>> src/libpcp/src/instance.c | 46 +- >>> src/libpcp/src/p_pmns.c | 2 >>> src/libpcp/src/pmns.c | 139 ++++++-- >>> src/libpcp/src/store.c | 14 >>> src/libpcp/src/util.c | 34 + >>> src/libpcp_gui/src/.gitignore | 3 >>> src/libpcp_gui/src/GNUmakefile | 2 >>> src/libpcp_mmv/src/.gitignore | 1 >>> src/libpcp_mmv/src/mmv_stats.c | 65 ++- >>> src/libpcp_pmcd/src/.gitignore | 1 >>> src/libpcp_pmda/src/.gitignore | 1 >>> src/libpcp_pmda/src/callback.c | 45 ++ >>> src/libpcp_pmda/src/help.c | 2 >>> src/libpcp_pmda/src/libdefs.h | 3 >>> src/libpcp_pmda/src/mainloop.c | 261 ++++++++++++--- >>> src/libpcp_pmda/src/open.c | 133 ++++--- >>> src/libpcp_trace/src/.gitignore | 3 >>> src/newhelp/chkhelp.c | 6 >>> src/newhelp/newhelp.c | 50 ++ >>> src/pmcd/GNUmakefile | 5 >>> src/pmcd/migrate_pcp_var_dir | 126 ------- >>> src/pmcd/pmdaproc.sh | 242 +++++++------ >>> src/pmcd/rc_pcp | 14 >>> src/pmcd/src/config.c | 163 +++++++-- >>> src/pmcd/src/dofetch.c | 57 ++- >>> src/pmcd/src/dopdus.c | 660 ++++++++++++++++++++++++++++++++------ >>> src/pmcd/src/dostore.c | 14 >>> src/pmcd/src/pmcd.h | 8 >>> src/pmcd/src/pmcd.log | 198 +++++------ >>> src/pmcd/src/sample.log | 4 >>> src/pmcd/src/sendmail.log | 4 >>> src/pmcd/src/simple.log | 4 >>> src/pmcd/src/trace.log | 4 >>> src/pmdas/GNUmakefile | 7 >>> src/pmdas/ib/daemon.c | 20 - >>> src/pmdas/ib/dso.c | 2 >>> src/pmdas/ib/ib.c | 283 +++++++++------- >>> src/pmdas/ib/ibpmda.h | 4 >>> src/pmdas/ib/pmda.c | 4 >>> src/pmdas/linux/proc_cpuinfo.c | 38 -- >>> src/pmdas/linux/proc_cpuinfo.h | 1 >>> src/pmdas/linux/proc_loadavg.c | 7 >>> src/pmdas/mmv/.gitignore | 5 >>> src/pmdas/mmv/GNUmakefile | 28 - >>> src/pmdas/mmv/Install | 6 >>> src/pmdas/mmv/Remove | 5 >>> src/pmdas/mmv/mmv.c | 103 +++-- >>> src/pmdas/mysql/pmdamysql.pl | 3 >>> src/pmdas/named/.gitignore | 2 >>> src/pmdas/named/GNUmakefile | 45 ++ >>> src/pmdas/named/Install | 32 + >>> src/pmdas/named/Remove | 25 + >>> src/pmdas/named/pmdanamed.pl | 155 ++++++++ >>> src/pmdas/pdns/.gitignore | 2 >>> src/pmdas/pdns/GNUmakefile | 45 ++ >>> src/pmdas/pdns/Install | 27 + >>> src/pmdas/pdns/Remove | 25 + >>> src/pmdas/pdns/pmdapdns.pl | 194 ++++++++++- >>> src/pmdas/pmcd/src/pmcd.c | 12 >>> src/pmdas/samba/.gitignore | 2 >>> src/pmdas/samba/GNUmakefile | 49 ++ >>> src/pmdas/samba/Install | 43 ++ >>> src/pmdas/samba/Remove | 25 + >>> src/pmdas/samba/pmdasamba.pl | 205 +++++++++++ >>> src/pmdas/sample/help | 24 + >>> src/pmdas/sample/pmns | 1 >>> src/pmdas/sample/src/pmda.c | 2 >>> src/pmdas/sample/src/sample.c | 362 ++++++++++++++++++-- >>> src/pmdas/simple/pmdasimple.pl | 6 >>> src/pmdas/solaris/GNUmakefile | 15 >>> src/pmdas/solaris/common.h | 14 >>> src/pmdas/solaris/data.c | 212 +++++++++++- >>> src/pmdas/solaris/help | 95 +++++ >>> src/pmdas/solaris/netmib2.c | 344 +++++++++++++++++++ >>> src/pmdas/solaris/netmib2.h | 62 +++ >>> src/pmdas/solaris/pmns.network | 31 + >>> src/pmdas/solaris/pmns.zfs | 15 >>> src/pmdas/solaris/pmns.zpool | 20 + >>> src/pmdas/solaris/root | 5 >>> src/pmdas/solaris/solaris.c | 7 >>> src/pmdas/solaris/zfs.c | 164 ++++++++- >>> src/pmdas/solaris/zpool.c | 226 ++++++++++--- >>> src/pmdas/trace/GNUmakefile | 3 >>> src/pmdas/trace/GNUmakefile.demos | 2 >>> src/pmdas/trace/GNUmakefile.stub | 2 >>> src/pmdas/windows/fetch.c | 91 ++--- >>> src/pmdas/windows/libpdh.def | 1 >>> src/pmdas/windows/libpdh.h | 20 + >>> src/pmdas/windows/open.c | 13 >>> src/pmdas/windows/pmda.c | 32 + >>> src/pmdas/windows/pmns.kernel | 1 >>> src/pmie/rc_pmie | 12 >>> src/pmie/src/GNUmakefile | 2 >>> src/pmlc/GNUmakefile | 2 >>> src/pmlogextract/GNUmakefile | 2 >>> src/pmlogger/GNUmakefile | 2 >>> src/pmlogger/pmlogger.c | 3 >>> src/pmns/Make.stdpmid | 8 >>> src/pmns/ReplacePmnsSubtree | 8 >>> src/pmns/pmnsutil.c | 5 >>> src/pmns/stdpmid.pcp | 8 >>> src/pmpost/GNUmakefile | 2 >>> src/pmproxy/rc_pmproxy | 12 >>> src/pmval/pmval.c | 55 ++- >>> 150 files changed, 6178 insertions(+), 1581 deletions(-) >>> >>> commit 52872f6b735fbf7814443f226df21eee30b35936 >>> Author: Ken McDonell >>> Date: Sun Sep 27 16:30:09 2009 +1000 >>> >>> ReplacePmnsSubtree fix bad signal handling botch >>> >>> The trap handling was totally wrong in cleanup() ... causing the >>> command "1" to be executed instead of the null command "". >>> >>> Exposed by another bug in a related area ... if the PMNS lock >>> exists already, after the timeout in pmlock we fall into the >>> trap cleanup() routine instead of charing on, so the script >>> fails horribly (and leaves the stale lock file around). >>> >>> Also fixed an unlikely buffer over-run in mmv.c. >>> >>> commit 4087051b86b580d7c7cb6e50806edb4eaa63e4d4 >>> Author: Ken McDonell >>> Date: Sun Sep 27 15:20:24 2009 +1000 >>> >>> newhelp, dbpmda, libpcp, libpcp_pmda, pmcd, sample pmda - dynamic PMNS changes >>> >>> This is the final round of changes that get all of the changes for >>> PMDA_INTERFACE_4 and the support of dynamic subtress of the PMNS where >>> the PMDA (not PMCD) maintains knowledge of the PMNS. >>> >>> With these changes and a related round of QA changes, we're passing all >>> of the QA tests (excluding the remote group that I cannot test at the >>> moment, but are unlikely to find problems in this code). >>> >>> commit 40e120d100d8f8f2a638124edef1ac2a16c0b975 >>> Author: Ken McDonell >>> Date: Sun Sep 27 15:18:33 2009 +1000 >>> >>> pmdaproc.sh Revert changes for perl pmda setup. >>> >>> Just put it back the way it was before I started messing with it! >>> >>> commit 4cead6907bf315ed009725db26659d3c6e12c698 >>> Author: Ken McDonell >>> Date: Sun Sep 27 15:11:44 2009 +1000 >>> >>> pmdaproc.sh tweaking to improve QA success >>> >>> Add delays after sending pmcd SIGHUP and before checking for pmcd health >>> to avoid small window where badness happens to pmcd from new PMDA, but >>> after the test has been done. >>> >>> Also wound back previous Perl PMDA setup change as it does not help the >>> QA test for the news PMDA ... reworked the QA test instead! >>> >>> commit 9371a85a8a5b65b43be732e585e1b8f98f4b94e1 >>> Author: Ken McDonell >>> Date: Thu Sep 24 16:59:07 2009 +1000 >>> >>> Only remake pmns file if it does not exist. >>> >>> Part of the perl PMDA support was unconditionally remaking pmns and >>> domain.h ... this was reordering the metrics for the simple PMDA and >>> causing QA tests 255 and 578 to fail ... more importantly if the >>> pmns file already exists then there is no point in using the perl >>> PMDA magic to recreate it. >>> >>> commit 4f6a801b054f92b23064385940a441bc66b758bd >>> Merge: e421a49... 11549ac... >>> Author: Ken McDonell >>> Date: Thu Sep 17 20:00:33 2009 +1000 >>> >>> Merge branch 'master' of git://oss.sgi.com/kenj/pcp >>> >>> Conflicts: >>> CHANGELOG >>> VERSION.pcp >>> src/pmcd/rc_pcp >>> src/pmie/rc_pmie >>> src/pmproxy/rc_pmproxy >>> >>> commit 11549aca86588c4695d26829e02f2ec9e7b43c3d >>> Author: Nathan Scott >>> Date: Mon Sep 7 16:29:34 2009 +1000 >>> >>> Bump pcp stable version to 2.9.2. >>> >>> commit 7997eea93ad9c240d2cbc7c2bfbd9ae21bb29e35 >>> Author: Ken McDonell >>> Date: Mon Sep 7 11:59:21 2009 +1000 >>> >>> Fix the number-of-samples value calculated in pmval once and for all. >>> >>> For those who care, it turns out that the number of _fetches_ may be >>> known, the number of _reported_ samples cannot be precomputed correctly >>> in all cases ... >>> - only works for archives with -a (not -U or -h) >>> - is known for non-counter metrics >>> - most of the time is known for counter metrics but there are some >>> important corner cases where this is not the case, specifically there >>> will be one more reported sample than expected for a counter when the >>> report starting time is not at the start of the archive and the metric >>> has a defined value before the report starting time with no intervening >>> mark record (interpolate mode does return a value at the first report >>> sample in this case!). >>> >>> With this pmval patch, the QA fallout is nil, except for 144 that is an >>> unrelated timezone problem. Also this patch avoids referencing the >>> context too soon, as there is no point in inspecting the metric's >>> semantics to try and better guess the value of smpls. As a bonus, this >>> patch also documents pmval's -U option that has remained a secret for >>> nearly a decade. >>> >>> commit f4e6d55fd0466a706144ca61b4428436ecea7eb7 >>> Author: Nathan Scott >>> Date: Mon Sep 7 11:51:58 2009 +1000 >>> >>> Attempt to resolve sys/stat related build issue on Alpha. >>> >>> Not having access to an Alpha makes this difficult, but one thing >>> that is clearly not helping is that with Linux glibc on Alpha, we >>> end up defining *both* HAVE_STAT_TIMESPEC and HAVE_STAT_TIME_T, & >>> that breaks otherwise valid pmns.c coding assumptions. >>> >>> This change means only one type for the stat time fields can be >>> defined, and it errs on the side of timespec (which should be the >>> one Alpha uses, AFAICT) - so perhaps this issue will finally be >>> resolved and PCP can progress in the Debian build/release system. >>> >>> commit be8793c58935362184a1dd4351388ca6a0013f3b >>> Author: Nathan Scott >>> Date: Mon Sep 7 11:26:09 2009 +1000 >>> >>> Fix mmv library build on mac/win - missing a header. >>> >>> commit 92eb7b896ff6eb83b2feef50e6a89c74c3aa1717 >>> Author: Nathan Scott >>> Date: Fri Sep 4 14:17:37 2009 +1000 >>> >>> Bump pcp stable version to 2.9.1. >>> >>> commit 2e890f3d1d9c4af31fc22af95cb7e0f20336523e >>> Author: Nathan Scott >>> Date: Fri Sep 4 14:15:16 2009 +1000 >>> >>> Correct pmval sample count calculation. >>> >>> Martin reported several QA tests were failing wrt pmval "samples" line. >>> >>> What I've found is the problem either exists/doesn't exist depending on >>> several factors: >>> - running on a 32 bit machine, Debian unstable, the problem never occurs >>> no matter how pmval is built. >>> - running on a 64 bit machine, Debian unstable, the problem only happens >>> with the packaged binaries. The key factor appears to be the introduction >>> of -O2, which looks like it reliably changes certain values on the stack, >>> that would otherwise be zero (used uninitialised, in either case). >>> >>> There's two problems here, I believe: >>> - in pmval.c the getargs() call initialises the value of "smpls" (number >>> of samples to take) based on cntxt->desc.sem. However, at that point, >>> we have not established a context yet, and so that field is uninitialised. >>> - this test doesn't match the comment above it, and doesn't make sense: >>> >>> /* counters require 2 samples to produce reported sample */ >>> if (*smpls > 0 && cntxt->desc.sem != PM_SEM_COUNTER) >>> >>> that would seem to me that it should be "cntxt->desc.sem == PM_SEM_COUNTER". >>> >>> commit 6940bbf89ca10d395fff93eeb7ce7424cec5d2ad >>> Merge: b7bb608... 350246f... >>> Author: Nathan Scott >>> Date: Fri Sep 4 14:08:24 2009 +1000 >>> >>> Merge branch 'dev' of git://oss.sgi.com/nathans/pcp into dev >>> >>> commit 350246f0ba359876660994823d2e37b864040c3f >>> Author: Nathan Scott >>> Date: Thu Sep 3 12:59:57 2009 +1000 >>> >>> Another pass at getting the perl/debian packaging auto-deps right. >>> >>> commit 91c9f4a0a06d8e300c23f49feab09141c488b0f5 >>> Author: Nathan Scott >>> Date: Thu Sep 3 12:59:24 2009 +1000 >>> >>> Correct mmv install targets makefile macro. >>> >>> commit bf33333edbcf48ee84dad07cace240d6aff6cc99 >>> Author: Nathan Scott >>> Date: Wed Sep 2 15:07:19 2009 +1000 >>> >>> Workaround another oddity in (very) recent versions of autoconf. >>> >>> Problem found by the Debian autobuilders, in the pcp-gui build but it >>> affects pcp too. Latest versions of autoconf evaluate AC_PROG_LEX in >>> the compiler check macro, and complete remove any trace of AC_PROG_LEX >>> from its original callsite. This results in a syntax error inside our >>> configure script, as we call it within if ... fi, which then evaluates >>> to having no body to the if. Ugh. Fix is trivial though, since these >>> macros do the user-env-variable expansion thing already. >>> >>> commit efcb3b590f086feb1507f82716d2f0b6eee69d33 >>> Author: Petter Reinholdtsen >>> Date: Wed Sep 2 14:38:34 2009 +1000 >>> >>> Add missing dependencies and runlevels into PCP start scripts. >>> >>> With dependency based boot sequencing, I discovered what I believe is >>> a bug in the init.d scripts of this package. The list of runlevels to >>> stop in is incomplete. The script should stop in runlevel 1 to make >>> sure the service is started again when switching from runlevel 1 to >>> 2-5. Also, the script should probably stop during halt (0) and reboot >>> (6). The package should start in runlevel 4, just like in runlevels >>> 2, 3 and 5. I suspect the list of dependencies are incomplete. The >>> scripts used to start after the syslog collector was operational, and >>> should probably continue to do so. Also, the scripts need files in >>> /usr/ and should depend on $remote_fs. >>> >>> If the scripts themselves need to start in any specific order, the >>> relationship should be listed explicitly in the LSB header too. Make >>> sure the update-rc.d calls in the postinst reflect this ordering if >>> any such dependencies should exist. >>> >>> This patch implement the proposed change. Without it, the script seem >>> to fail to handle runlevel 0, 1, 4 and 6 properly, and might start too >>> early in the boot. >>> >>> commit 4aa31ed00a60c3926a53bbd8d47aa0b2eaf254c4 >>> Merge: 35c230e... 3323bb9... >>> Author: Nathan Scott >>> Date: Wed Sep 2 13:18:44 2009 +1000 >>> >>> Merge branch 'dev' of git://oss.sgi.com/nathans/pcp into dev >>> >>> commit b7bb60801c2fc342b15473f1e3b341dd8ec7b84a >>> Author: Nathan Scott >>> Date: Wed Sep 2 12:38:19 2009 +1000 >>> >>> Update gitignore files for Mac and Windows library file names. >>> >>> commit 3323bb90ad5f66480c05b7fe182a72a0813c9b41 >>> Author: Nathan Scott >>> Date: Wed Sep 2 12:30:47 2009 +1000 >>> >>> Fix a segv observed in the Windows PMDA accessing SQL Server metrics. >>> >>> The recent optimisation added for direct instance domain lookup added >>> a flaw that could case an array index of -1 to be used to access into >>> the metric value table. Observed on SQL Server 2008 & Windows Server >>> 2008 R2 only so far. >>> >>> commit 1112ac636cae6feac624279c76239003662d4a35 >>> Author: Nathan Scott >>> Date: Wed Sep 2 11:49:20 2009 +1000 >>> >>> Small MMV pmda changes to allow DSO builds in the future. >>> >>> Turns out that the current protocol for getting pmcd to >>> update its namespace cannot be used from DSO agents ... >>> one more reason to revamp this area. >>> >>> commit 677c6f2cea7fce4ff5f10f939fc5a942861719dd >>> Author: Nathan Scott >>> Date: Wed Sep 2 11:46:40 2009 +1000 >>> >>> Fix logic error causing wrong windows version to be reported. >>> >>> commit e421a49323307d49f6b897ae87f94c934b6fdcad >>> Author: Ken McDonell >>> Date: Tue Sep 1 17:44:22 2009 +1000 >>> >>> Interim commit for start of daemon PMDA support for dynamic PMNS. >>> >>> commit 210be7f679b10d71dda985fdebc7dd9aec5d606a >>> Author: Nathan Scott >>> Date: Fri Aug 28 08:44:50 2009 +1000 >>> >>> Correct some regular expressions in Samba PMDA. >>> >>> Of particular note, some of the heading lines in the >>> smbstatus --profile output have trailing whitespace. >>> Otherwise, this PMDA is now fully functional; and as >>> it used the stock Samba utilities, is not dependent >>> on the many flavours of Samba shmem format anymore. >>> At the cost of a slight overhead increase, of course, >>> but the original was unmaintainable. >>> >>> Thanks to James Peach for advise on redesigning this. >>> >>> commit 0758690bcbbf26db438560d5b5b94b1644979047 >>> Author: Nathan Scott >>> Date: Thu Aug 27 14:26:32 2009 +1000 >>> >>> Descend into samba PMDA during the build (SUBDIRS update). >>> >>> commit 9e758dd286ee2c49ecd991599a4c87a5520b9892 >>> Author: Nathan Scott >>> Date: Thu Aug 27 14:25:18 2009 +1000 >>> >>> Add kernel.all.uptime to the Windows kernel agent. >>> >>> This code uses the PdhGetFormatterCounterValue API, which we >>> have not used before on Windows, hence the changes to libpdh >>> header and dll definition files. >>> >>> commit b0cbeab4df3aec93a2f9749c7912dc8adc0b27ea >>> Author: Nathan Scott >>> Date: Thu Aug 27 10:21:28 2009 +1000 >>> >>> Rearrange platform-specific handling in pmdaproc.sh. >>> >>> Keep everything that does platform-specific stuff in one >>> place now, run early on, instead of all over the shop. >>> >>> The code that handles determining whether the PCP::PMDA >>> Perl module is installed is also reworked to not fail in >>> the case where perl_opt is set, but user doesn't select >>> that option when Install'ing a PMDA. This bit Mark with >>> the simple PMDA, which has both Perl and C variants. >>> >>> commit ac9170cf888639cc731474d39cb100e9d7b2c519 >>> Author: Nathan Scott >>> Date: Thu Aug 27 09:20:14 2009 +1000 >>> >>> Initial version of the (perl-based) Samba PMDA. >>> >>> commit e00aafe76a538ad09322499c2f669450d3b0c486 >>> Author: Nathan Scott >>> Date: Wed Aug 26 11:46:12 2009 +1000 >>> >>> Fix inconsistent metric name in pmdasimple.pl - simple.now was wrong. >>> >>> commit e937d8332c9dc6a0f4d5ea5fb10b6d3530b7261b >>> Author: Nathan Scott >>> Date: Wed Aug 26 11:02:55 2009 +1000 >>> >>> Remove hard-coded path in the perl variant of the simple PMDA (thanks Mark). >>> >>> commit 531de7440179d323c8774fad2a4c13ac4c21bcbb >>> Author: Nathan Scott >>> Date: Wed Aug 26 11:00:00 2009 +1000 >>> >>> Use PM_IN_NULL in pmdasimple.pl so it functions correctly on all platforms. >>> >>> commit 956be698fe2de60b96c2c6fa72be1555a1c3cf7c >>> Merge: 7bf0f27... b8cb2dd... >>> Author: Nathan Scott >>> Date: Mon Aug 24 10:58:57 2009 +1000 >>> >>> Merge branch 'dev' of git://oss.sgi.com/nathans/pcp into dev >>> >>> commit 7bf0f27d27c11db4002699e74611ef718551add3 >>> Merge: 309e7be... 3db8e4f... >>> Author: Nathan Scott >>> Date: Mon Aug 24 10:57:30 2009 +1000 >>> >>> Merge branch 'solaris' of git://oss.sgi.com/makc/pcp into dev >>> >>> commit 309e7be90719ebc12bc66e9a06999909e7f66c16 >>> Author: Nathan Scott >>> Date: Mon Aug 24 09:03:19 2009 +1000 >>> >>> Add PCP::PMDA helper routines for determining native long sizes. >>> >>> commit 90e8cd865a6bfabf91315feea3743054a1511111 >>> Author: Nathan Scott >>> Date: Mon Aug 24 09:01:38 2009 +1000 >>> >>> Extend MMV to allow teardown of MMV file, and set errno on failure. >>> >>> Setting errno helps alot with diagnosing mmv_stats_init() failures. >>> >>> commit d4732eb5d60d8d31bb6eba69daa2787befb34325 >>> Author: Nathan Scott >>> Date: Mon Aug 24 08:56:24 2009 +1000 >>> >>> Initial stable (1.00) version of MMV Perl interface. >>> >>> Changes include: >>> - added stop interface >>> - added stats_set interface >>> - fixed incorrect memory free on init >>> - extend server.pl example to report idle time >>> - fixed use of av_len return codes (off by one) >>> >>> commit 3db8e4f3626241cb40e52f36a691263c8aaa34ff >>> Author: Max Matveev >>> Date: Mon Aug 17 18:52:49 2009 +1000 >>> >>> Release zpool resources when finished updates >>> >>> It's not documented but it's obvious that zpool_iter expects the >>> callback to call zpool_close to release resources associated with >>> the zpool - it's not a problem for short-lived commands like zpool(1) >>> but it leaks memory like a firehose. >>> >>> commit 35c230ef34a191bbb5b8f12b91d122e2863ac740 >>> Author: Nathan Scott >>> Date: Fri Aug 14 14:58:10 2009 +1000 >>> >>> Correct the metric units for several Windows per-process memory metrics. >>> >>> commit 758b2b7039e878189b42fab6d8d3a789a27810d1 >>> Author: Max Matveev >>> Date: Wed Aug 12 00:01:59 2009 +1000 >>> >>> Eliminate incidents of crime against whitespace >>> >>> commit 012af5fa4e16029513c6d1c2ff7c7a3d4a3069e3 >>> Author: Max Matveev >>> Date: Tue Aug 11 23:55:59 2009 +1000 >>> >>> Hide instances for destroyed pools and filesystems >>> >>> In Solaris PMDA if a zpool or a zfs is removed make sure that the >>> corresponding instance disappears from the list of instances returned on >>> fetch. >>> >>> commit a8cbf7b86b1bab119246006b23b1114fe1b4b9d7 >>> Author: Ken McDonell >>> Date: Fri Aug 7 11:22:23 2009 +1000 >>> >>> Revert __pmProcessTerminate() change. >>> >>> Since perl PMDAs are now all running in their own process group revert >>> to allow kill(0, ...) to proceed. >>> >>> commit 8ea858d245d093ed3285e0e4370303bd678cc468 >>> Merge: 9b4b935... ead91ff... >>> Author: Ken McDonell >>> Date: Thu Aug 6 18:35:49 2009 +1000 >>> >>> Merge branch 'dev' into pmns >>> >>> commit 9b4b9351a7e41bc21f893063e0311accd7cee046 >>> Author: Ken McDonell >>> Date: Thu Aug 6 18:18:10 2009 +1000 >>> >>> Guard in _pmProcessTerminate() to prevent killing all member of process group. >>> >>> Problem exposed by qa/162 and perl implementation of news pmda. >>> >>> commit 7f72e4acff1b876b10e6f6432a55de2e49b9e148 >>> Author: Ken McDonell >>> Date: Thu Aug 6 18:16:49 2009 +1000 >>> >>> Second round of changes for PMDA_INTERFACE_4 dynamic metrics. >>> >>> DSO mode PMDAs (sampledso) is very close to working correctly now. >>> >>> commit ead91ffca2605502c3552ffbc228ffbc0ed3ecc3 >>> Author: Mark Goodwin >>> Date: Thu Aug 6 12:14:25 2009 +1000 >>> >>> update changelog and delete unncessary Vendor string >>> >>> Signed-off-by: Mark Goodwin >>> >>> commit b77cb57bb669b1129c1241f7818fe75935390a3b >>> Author: Mark Goodwin >>> Date: Thu Aug 6 12:06:23 2009 +1000 >>> >>> also bump the src tarball version >>> >>> Signed-off-by: Mark Goodwin >>> >>> commit 6c8311051895092662b8ee1986945a3846577b04 >>> Author: Mark Goodwin >>> Date: Thu Aug 6 12:01:24 2009 +1000 >>> >>> bump to 3.0.0-2 >>> >>> Signed-off-by: Mark Goodwin >>> >>> commit 99aa1c21c22e64350ba750284039653750633540 >>> Merge: ef9852c... f2866c9... >>> Author: Mark Goodwin >>> Date: Thu Aug 6 11:37:29 2009 +1000 >>> >>> merge pcp-2.9.0-1 dev >>> >>> modified: CHANGELOG >>> modified: build/rpm/pcp.spec.in >>> modified: debian/changelog >>> modified: debian/control >>> modified: src/cpan/PMDA/PMDA.xs >>> modified: src/libpcp_pmda/src/open.c >>> modified: src/pmcd/src/config.c >>> modified: src/pmdas/GNUmakefile >>> modified: src/pmdas/mysql/pmdamysql.pl >>> new file: src/pmdas/pdns/.gitignore >>> new file: src/pmdas/pdns/GNUmakefile >>> new file: src/pmdas/pdns/Install >>> new file: src/pmdas/pdns/Remove >>> new file: src/pmdas/pdns/pmdapdns.pl >>> modified: src/pmlogger/pmlogger.c >>> modified: src/pmns/stdpmid.pcp >>> >>> Signed-off-by: Mark Goodwin >>> >>> commit ef9852c99666359cdacb1afe65dcac16460ea0ab >>> Author: Mark Goodwin >>> Date: Thu Aug 6 11:05:12 2009 +1000 >>> >>> Changes to the Fedora RPM spec in response to review feedback: >>> - Incorporate a large number of suggestions and cleanups from Eric Sandeen >>> - Greatly simplified the %post and %postun scriptlets - remove ancient crud >>> - Added ldconfig scriptlets for -libs >>> - Don't explicitly require IB libs, since they're libs and RPM figures it out >>> - No need to explicitly BuildRequire gcc-c++ libstdc++-devel >>> - Add BuildRequires on perl-ExtUtils-MakeMaker >>> - Remove explicit ia64 Requires: libunwind >>> - Have pcp-libs require the base package since Fedora insists >>> - Add and clarify some comments >>> - Create %{_localstatedir}/run/pcp and ship it (so it'll be removed) >>> - Use %doc for CHANGELOG COPYING INSTALL README VERSION.pcp pcp.lsm >>> >>> Signed-off-by: Mark Goodwin >>> >>> commit 88c3b113c45f61d8959b95f0486d5d625b8c85af >>> Author: Mark Goodwin >>> Date: Thu Aug 6 10:17:51 2009 +1000 >>> >>> git ignore generated gram*.tab.c >>> >>> Signed-off-by: Mark Goodwin >>> >>> commit 0fe594271c4635432616eaec4640b38773d150cc >>> Author: Mark Goodwin >>> Date: Thu Aug 6 10:12:55 2009 +1000 >>> >>> preserve generated gram.tab.c because debuginfo needs it >>> >>> Signed-off-by: Mark Goodwin >>> >>> commit 385ce8e19c550792fd61a4e6112408c208b75649 >>> Author: Mark Goodwin >>> Date: Thu Aug 6 09:21:48 2009 +1000 >>> >>> fix minor typo in comment >>> >>> Signed-off-by: Mark Goodwin >>> >>> commit b8cb2dd7c9b5d33e473bf0d89a64da3c2b2eec92 >>> Merge: 1c47a24... 684232a... >>> Author: Nathan Scott >>> Date: Wed Aug 5 16:52:11 2009 +1000 >>> >>> Merge branch 'solaris' of git://oss.sgi.com/makc/pcp into dev >>> >>> commit 1c47a24dbef502d09439e663b727a2bf85e5499d >>> Author: Nathan Scott >>> Date: Wed Aug 5 16:51:47 2009 +1000 >>> >>> Ignore all MMV files that begin with a period. >>> >>> commit 4bc076258e025f86b6215783933f7adcb77ace90 >>> Author: Max Matveev >>> Date: Wed Aug 5 02:10:37 2009 +1000 >>> >>> Add network metrics to Solaris PMDA >>> >>> Use MIB2 interface available via TI to extract IPv4 interfaces and UDP stats >>> from the kernel. >>> >>> The good/bad fetch is on the whole group - if any of the sources fail (even if >>> we don't use them like IPv6 interface stats) then whole fetch will return no >>> data. >>> >>> Fetch callback still uses offset for the metrics which have indoms, for >>> singular metrics a pointer to the global storage is used whence the change >>> of type in md_offset. >>> >>> commit 4e1e119bfb7cfa6d09c81049fec95d3dc9e13356 >>> Author: Mark Goodwin >>> Date: Tue Aug 4 12:19:07 2009 +1000 >>> >>> dont install trace demo binaries since src is installed anyway >>> >>> Signed-off-by: Mark Goodwin >>> >>> commit 234ffe3f3badbf73768f114fa692eac0dd7ec079 >>> Author: Max Matveev >>> Date: Mon Aug 3 10:33:41 2009 +1000 >>> >>> Report ZFS statistics from Solaris PMDA >>> >>> Use libzfs interfaces to extract some data about ZFS "dataset". Datasets >>> are filesystems, snapshots and volumes, the reported data include information >>> about used and available space, compression ratios, number of copies, >>> reserved space per dataset. Space utilization is additionally broken down >>> into space used by children, space used by snapshot and space used by the >>> dataset itself. >>> >>> commit 5da67384ae7719254afd7d76d8b10558b9d3de07 >>> Author: Max Matveev >>> Date: Mon Aug 3 01:59:01 2009 +1000 >>> >>> Export zpool stats from Solaris PMDA >>> >>> Use libzfs to extract zpool stats like capacity, iops, bandwidth etc >>> >>> commit 684232a1b6178de4a07edbd0e3308f49789992fb >>> Author: Max Matveev >>> Date: Sun Aug 2 23:05:11 2009 +1000 >>> >>> Put 64 bit libraries into the right place on Solaris >>> >>> Solaris keeps its 64 bit shared libraries in /usr/lib/64 - use the pointer >>> size to decide if we're building 32 or 64 bit version and push the library >>> in the right place. >>> >>> commit 3cf745f62c0099577265994de97c0a755cb06f9b >>> Author: Max Matveev >>> Date: Sun Aug 2 04:11:32 2009 +1000 >>> >>> Generate packages for Solaris >>> >>> commit 74c7543c88bc3776b81ae8a5eab4de940537ffdd >>> Author: Max Matveev >>> Date: Sun Aug 2 03:03:35 2009 +1000 >>> >>> Allow user to choose her compiler >>> >>> New autoconf attempts to compile the headers as part of AC_HEADER_CHECK. >>> It AC_PROG_CC is not called then AC_HEADER_CHECK generates scary warning - >>> just call AC_PROG_CC unconditionally: it will honour CC from the environment >>> but it will also do the right things about later checks. >>> >>> On Solaris if the alternative compiler is not GCC then don't feed it >>> GNU options. >>> >>> commit 5dc76a384254b3a0b1a72ff1be5faec042effa73 >>> Author: Mark Goodwin >>> Date: Fri Jul 31 15:44:40 2009 +1000 >>> >>> RPM spec specifically for the Fedora Project. >>> >>> Signed-off-by: Mark Goodwin >>> >>> commit 1274605472853400f4297439c433a05829735a64 >>> Author: Mark Goodwin >>> Date: Fri Jul 31 15:40:58 2009 +1000 >>> >>> tweak configure to move PCP_BINADM_DIR out of /usr/share, into /usr/lib. >>> Arch dependent binaries should not be installed below /usr/share. >>> >>> Signed-off-by: Mark Goodwin >>> >>> commit 17700e2bdaa0060178c3d025edb92280f36451f6 >>> Author: Mark Goodwin >>> Date: Fri Jul 31 11:47:39 2009 +1000 >>> >>> delete unneeded explicit script interpreter to keep rpmlint happy >>> >>> Signed-off-by: Mark Goodwin >>> >>> commit b971772c281a5aff6408981e7086cbfa4bcee6ba >>> Author: Mark Goodwin >>> Date: Fri Jul 31 11:33:20 2009 +1000 >>> >>> pmpost does not really need to be setuid >>> >>> Signed-off-by: Mark Goodwin >>> >>> commit 0a4cd4b8bfe44265bdccfb93db5e19c28c796f79 >>> Author: Mark Goodwin >>> Date: Fri Jul 31 11:11:48 2009 +1000 >>> >>> Nuke migrate_pcp_var_dir, no longer needed >>> >>> Signed-off-by: Mark Goodwin >>> >>> commit bf98168e8a7cea7697497f4972dd835fa10e29b6 >>> Author: Mark Goodwin >>> Date: Thu Jul 30 18:25:12 2009 +1000 >>> >>> default chkconfig off for all PCP services >>> >>> Signed-off-by: Mark Goodwin >>> >>> commit 679b9d50fa63430066fbf8343607205dd46d20f7 >>> Author: Ken McDonell >>> Date: Wed Jul 29 20:38:59 2009 +1000 >>> >>> Initial work for PMDA_INTERFACE_4 and new sample.secret.* dynamic metrics. >>> >>> commit 6c17c674360b6d6738f37bb9330fdb607dd1c872 >>> Author: Ken McDonell >>> Date: Wed Jul 29 20:38:07 2009 +1000 >>> >>> Remove log files that were added by mistake. >>> >>> commit a707483a5af651b430b9e2b4a193a5b64585e6e9 >>> Author: Ken McDonell >>> Date: Wed Jul 29 20:34:10 2009 +1000 >>> >>> Second round of PMDA_INTERFACE_4 and dynamic PMNS changes. >>> >>> Gets things working for DSO PMDAs. >>> >>> commit 8e0f63dbb6ae77a2d526e9472b85d8de1b5bab84 >>> Author: Ken McDonell >>> Date: Wed Jul 29 20:31:52 2009 +1000 >>> >>> Extending domain number to 9 bits (continued). >>> >>> commit f2866c9e1bf8c9a70213ed4cd859d437b9af6bad >>> Author: Mark Goodwin >>> Date: Mon Jul 27 19:59:39 2009 +1000 >>> >>> Bump version to 2.9.0. >>> >>> commit d3f630a269c73017407b46713bb75b91a7516475 >>> Author: Mark Goodwin >>> Date: Mon Jul 27 19:57:22 2009 +1000 >>> >>> Tweak Debian perl packaging with explicit dependencies, resolving build warnings. >>> >>> commit e69333488d42d8b3b1a8f35ea1f9ea3b2f12ad35 >>> Author: Mark Goodwin >>> Date: Mon Jul 27 19:56:41 2009 +1000 >>> >>> Make the pcp2.x RPM provide pcp-devel and pcp-libs >>> >>> This RPM packaging change makes it easier for dependent >>> packages such as pcp-gui to transition to pcp-3.x, where >>> we have split packaging: pcp, pcp-devel and pcp-libs. >>> >>> commit 3687851ac4ee2ccc1810b25fccb31c9935427cdf >>> Author: Nathan Scott >>> Date: Mon Jul 27 15:23:21 2009 +1000 >>> >>> Split apart the POSIX and Win32 daemon PMDA code in pmcd. >>> >>> No longer use a wrapper for the Win32 implementation either, which >>> allows us to have finer control over opened/closed file descriptors >>> and gives us a better shot at pipe agents (still not functional due >>> to fd inheritance, I think) and also keeps track of the child PIDs. >>> >>> commit ee52cf1d530317ed290e07bf3dc964b362e3ca5c >>> Author: Nathan Scott >>> Date: Mon Jul 27 14:07:54 2009 +1000 >>> >>> When starting a PMDA in socket mode, we must mark the file descriptor as such. >>> >>> In order for socket communication to function on Windows, socket fd's must be >>> flagged (and hence distinct from pipes, so we know whether to write/send there). >>> This gets socket-based daemon PMDAs to startup correctly under Win32 conditions. >>> >>> commit bd5862657c7f532369ea6e760a06a0aa9f81f74f >>> Author: Nathan Scott >>> Date: Mon Jul 27 14:04:17 2009 +1000 >>> >>> Fix a typo in a comment in pmcd code. >>> >>> commit 61c43f8885220a6e7d41624ace23d1157ef90e29 >>> Merge: 910d640... 3baf8e7... >>> Author: Mark Goodwin >>> Date: Mon Jul 27 09:37:33 2009 +1000 >>> >>> Merge branch '3.0.0' of git+ssh://markgw@oss.sgi.com/oss/git/markgw/pcp/pcp into dev >>> >>> commit 3baf8e7a6491c9533a1b0ff00c6d711a32677536 >>> Author: Mark Goodwin >>> Date: Mon Jul 27 09:32:57 2009 +1000 >>> >>> take -fstack-protector-all back out again since it's only supported with newer compilers. Probably should add a configure test for it at some stage >>> >>> Signed-off-by: Mark Goodwin >>> >>> commit eb409a0cb7c638a42e2546d7f6e67ac1aa0ac66c >>> Author: Josef 'Jeff' Sipek >>> Date: Mon Jul 27 08:45:50 2009 +1000 >>> >>> PowerDNS PMDA's packetcache_size and qsize_q are instant values, not counters >>> >>> commit c8728d91900e220159bc925084cb3a862a4a5d26 >>> Author: Nathan Scott >>> Date: Mon Jul 27 08:44:21 2009 +1000 >>> >>> Update pmlogger -x message - kill is now (cross-platform) pmsignal. >>> >>> commit 47a82efaefdc26f37ce62df6d736092b96c2ae61 >>> Author: Nathan Scott >>> Date: Thu Jul 23 15:18:20 2009 +1000 >>> >>> Tweak deb package long descriptions for bug 537563. >>> >>> commit 0b9600ede2f03f15d271ab812a703d0b606c4506 >>> Author: Josef 'Jeff' Sipek >>> Date: Thu Jul 23 14:49:30 2009 +1000 >>> >>> Add a new PMDA for the PowerDNS daemon (www.powerdns.com). >>> >>> commit df6f93cd1b2de0fc1e531cc568f4e53b73adf7e5 >>> Author: Nathan Scott >>> Date: Thu Jul 23 14:32:59 2009 +1000 >>> >>> Remove a duplicated metric from the MySQL PMDA. >>> >>> Problem reported by Josef Sipek, install of this PMDA now >>> fails due to reworking of the pmns generation code, before >>> this would have silently overwritten one metric with the >>> other (122 won in our production environment so I've kept >>> that) but now we check for this condition. >>> >>> commit 737b6904574678e174e5d8b969b91edce66c759a >>> Author: Nathan Scott >>> Date: Thu Jul 23 13:26:31 2009 +1000 >>> >>> Improve error reporting in pmcd on Windows. >>> >>> Should we be asked to open a UNIX domain socket channel to a >>> PMDA on Windows, improve the message for easier diagnosis. >>> >>> commit c87287e790d4636e2abbd98f223daa0c67c644e8 >>> Author: Nathan Scott >>> Date: Thu Jul 23 13:25:11 2009 +1000 >>> >>> Improve error reporting in PCP::PMDA perl module. >>> >>> When failing to build the PMNS file, additional diagnostics >>> would be helpful to pinpoint the source of the error. >>> >>> commit 910d640b1cdd749de83245523a24e2486a8f5cc2 >>> Merge: 7f3bf2c... 0c1b4b2... >>> Author: Mark Goodwin >>> Date: Thu Jul 23 11:39:22 2009 +1000 >>> >>> Merge branch '3.0.0' of git://oss.sgi.com/markgw/pcp/pcp into dev >>> >>> commit 0c1b4b2f4bd9b0759964fb056a1469b2dd052ce6 >>> Author: Mark Goodwin >>> Date: Wed Jul 22 17:02:40 2009 +1000 >>> >>> Tweak RPM dependency rules for 2.x -> 3.x upgrades and >>> massage the PCP RPM spec to reduce rpmlint noise. >>> >>> Also added -fstack-protector-all to Linux PCFLAGS. >>> >>> On branch 3.0.0: >>> modified: build/rpm/pcp.spec.in >>> modified: src/include/builddefs.in >>> >>> Signed-off-by: Mark Goodwin >>> >>> commit 7f3bf2c9a2966801f95c31f049291da8434faae4 >>> Author: Nathan Scott >>> Date: Wed Jul 22 13:37:47 2009 +1000 >>> >>> Ensure the Perl PMDA process runs in its own process group, >>> and ignore SIGTERM in the atexit handler. This resolves an >>> issue with the earlier fix for reaping children. >>> >>> commit d597f63b47a9eb8140c878bbc26c1434431c3096 >>> Author: Nathan Scott >>> Date: Wed Jul 22 11:52:09 2009 +1000 >>> >>> Comment out some diagnostics in named PMDA. >>> >>> commit c9b822c236f1bf219d830d1185d16cc9e87eae4c >>> Author: Rodney McKee >>> Date: Wed Jul 22 11:44:32 2009 +1000 >>> >>> Add the named PMDA, initially supporting BIND 9.4. >>> >>> commit cf003f4dddc1f26d2d7818f7c17bfd942a448ea2 >>> Merge: fee86f6... fcca602... >>> Author: Nathan Scott >>> Date: Wed Jul 22 10:18:55 2009 +1000 >>> >>> Merge branch 'dev' of git://oss.sgi.com/mort/pcp into dev >>> >>> commit fcca6023cd689ea5f48c6f6c538e2e21af67d32e >>> Author: Martin Hicks >>> Date: Tue Jul 21 17:34:05 2009 -0400 >>> >>> Do not create infiniband pmda config file by default >>> >>> In order to simplify monitoring in the simple case where a >>> machine has a single Infiniband interface, the config file is >>> no longer created by default. Instead, only local ports are >>> monitored. This does solve the problem where if an infiniband >>> card is replaced in a machine that the administrator no longer >>> has to remove the /var/lib/pcp/pmdas/ib/config file in order >>> to restore infiniband monitoring. >>> >>> For more advanced usage where static instance naming is required >>> or remote Infiniband ports must be monitored a config file can >>> still be created, but it is the responsibility of the administrator >>> to update the GUIDs if an HCA replacement is done. >>> >>> commit 840243974c106daae11368730043534d4684bc59 >>> Author: Martin Hicks >>> Date: Tue Jul 21 17:31:54 2009 -0400 >>> >>> Manpage for the infiniband PMDA >>> >>> commit fee86f6503252207a236c5eb81c8d092eede1a87 >>> Author: Nathan Scott >>> Date: Thu Jul 16 16:59:45 2009 +1000 >>> >>> Rework the special SGI CPU numbering logic in the Linux PMDA. >>> >>> This resolves a buffer overflow bug in the use of realpath(3) >>> in this routine, which was being passed a too-small buffer. >>> This issue was initially reported to us by Chandana De Silva, >>> but looks like others have come across it too, e.g.: >>> https://bugs.launchpad.net/ubuntu/+source/pcp/+bug/384776 >>> >>> I've removed the unused "cname" field from the per-CPU data >>> structure, and also added some short-circuit logic into this >>> code so that we bail out of this logic early if no hardware- >>> graph filesystem paths are detected (which will be the normal >>> case for most people). >>> >>> commit 67ae7fd90a32a43bbc97b939e57302556e864459 >>> Author: Nathan Scott >>> Date: Thu Jul 16 16:54:11 2009 +1000 >>> >>> Resolve a valgrind reported problem when initing Linux loadavg metric. >>> >>> Ensure read buffer is initialised to zero, and also check the return >>> code for a failed read syscall. >>> >>> commit 7f0167d8410147a6645699b0a385dc0c3bdfa5ac >>> Author: Martin Hicks >>> Date: Tue Jul 14 14:14:31 2009 -0400 >>> >>> Reserve domain ID 99 for SGI Ultra Violet PMDA >>> >>> commit de5188e9814f25c043dd278d3b3b9be0f3d8a306 >>> Author: Ken McDonell >>> Date: Sun Jul 12 07:51:13 2009 +1000 >>> >>> Increase domain from 8-bits to 9-bits. >>> >>> Cleaned up the use of the top bit as a flag for both a pmID and >>> a pmInDom ... now using a 1 bit flag field instead of the 2-bit >>> "pad" field. Changes required for PMNS parsing in libpcp and >>> internal handling of help text. >>> >>> Introduced PMDA_INTERFACE_4, but no code using this yet. >>> >>> Encoding and logic to handle dynamic PMNS entries introduced and >>> some local support in parsing and reporting local PMNS entries >>> (syntax for PMID in PMNS is :*:*) ... this means domain >>> number 511 (DYNAMIC_PMID) is now special and reserved. >>> >>> commit 3a0217c80b84c56d21bdd64f9d6396c9c583556d >>> Author: Nathan Scott >>> Date: Fri Jul 10 10:37:08 2009 +1000 >>> >>> Add a PCP::PMDA module check into PMDA Install path for Perl PMDAs. >>> >>> commit 2c278354dedbb229721ffbb6cd1934896095c4a7 >>> Author: Nathan Scott >>> Date: Fri Jul 10 10:35:08 2009 +1000 >>> >>> Make Perl PMDA module explicit wrt libpcp_pmda interface version used. >>> >>> >>> >>> _______________________________________________ >>> pcp mailing list >>> pcp@oss.sgi.com >>> http://oss.sgi.com/mailman/listinfo/pcp > From kenj@internode.on.net Tue Sep 29 04:39:39 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n8T9ddTx197345 for ; Tue, 29 Sep 2009 04:39:39 -0500 X-ASG-Debug-ID: 1254217258-710a02c10000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id A332C1B2F916 for ; Tue, 29 Sep 2009 02:40:58 -0700 (PDT) Received: from mail.internode.on.net (bld-mail12.adl6.internode.on.net [150.101.137.97]) by cuda.sgi.com with ESMTP id Zp8P1FKRHPDcbi0d for ; Tue, 29 Sep 2009 02:40:58 -0700 (PDT) Received: from [192.168.1.100] (unverified [118.208.169.2]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 5887831-1927428 for ; Tue, 29 Sep 2009 19:10:56 +0930 (CST) X-ASG-Orig-Subj: pcpqa updates Subject: pcpqa updates From: Ken McDonell Reply-To: kenj@internode.on.net To: pcp@oss.sgi.com Content-Type: text/plain Date: Tue, 29 Sep 2009 19:40:44 +1000 Message-Id: <1254217244.7661.23.camel@bozo> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail12.adl6.internode.on.net[150.101.137.97] X-Barracuda-Start-Time: 1254217260 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.52 X-Barracuda-Spam-Status: No, SCORE=-1.52 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE7568M X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.10317 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean These are the changes that are required after the PMDA_INTERFACE_4 changes (dynamic subtrees in the PMNS) are merged into PCP (plus some other QA fixups). The pcpqa tree is tagged with prior_to_dynamic_pmns if you want QA that matches PCP before the PMDA_INTERFACE_4 changes ... but the tag is not correct as the PMDA_INTERFACE_4 changes to QA were made over a period of time that overlaps with other unrelated QA commits by others ... c'est la vie mon amis. Changes committed to git://oss.sgi.com/pcp/pcpqa.git .gitignore | 2 002 | 2 003 | 4 029 | 1 031 | 7 031.out.linux | 24 +- 107 | 9 108 | 2 113 | 2 139.out | 9 144 | 4 144.out | 30 +- 156 | 1 162.out.4 | 1 174.out | 2 183 | 2 207 | 164 ++++++++++++++ 207.out | 84 +++++++ 208 | 97 ++++++++ 208.out | 274 +++++++++++++++++++++++- 210 | 120 ++++++++++ 210.out | 127 +++++++++++ 211 | 118 ++++++++++ 211.out | 127 +++++++++++ 213 | 76 ++++++ 213.out | 104 +++++++++ 244 | 4 274.out | 2 279 | 33 ++ 279.out | 4 304.out | 115 +++------- 347 | 2 347.out | 22 - 367.out | 10 427 | 9 569 | 3 569.out | 45 ++++ 574.out.linux | 25 +- 617.out | 6 628 | 1 646 | 1 646.out | 2 647 | 2 group | 47 ++-- new | 25 +- owner | 17 - qa_hosts.master | 10 src-oss/.gitignore | 5 src-oss/GNUmakefile | 4 src-oss/broken_pmda.c | 16 - src-oss/chkoptfetch.c | 4 src-oss/endian.c | 8 src-oss/hex2nbo.c | 12 - src-oss/killparent.c | 13 + src-oss/torture_api.c | 9 src-oss/torture_pmns.c | 542 ++++++++++++++++++++++++++++++++++++++++++++++--- 56 files changed, 2109 insertions(+), 282 deletions(-) commit 9d313205189fc980ee2ad1c8e2e5409fc45ac500 Merge: be5fbb4... b2e1fbd... Author: Ken McDonell Date: Sun Sep 27 17:27:16 2009 +1000 Merge branch 'master' of git://oss.sgi.com/pcp/pcpqa commit be5fbb41aa5bd40af9f0c486676abd57b8e2f56b Merge: cf03f58... c4292a6... Author: Ken McDonell Date: Sun Sep 27 15:46:05 2009 +1000 Merge branch 'pmns' Conflicts: group commit c4292a670b959707b1645df94b473b921b7938e9 Author: Ken McDonell Date: Sun Sep 27 15:39:59 2009 +1000 Resync QA with PMDA_INTERFACE_4 and dynamic subtree of PMNS changes. commit f31499334058d12032807116bb77f4f4c1b363c3 Author: Ken McDonell Date: Sun Sep 27 06:39:55 2009 +1000 213 New test for dbpmda and dynamic metrics Exercise the new dbpmda commands: children metric-name name pmid# pmid metric-name traverse metric-name commit 51bd5b7c3c288ab600d063111528a6c6354f40a0 Author: Ken McDonell Date: Fri Sep 25 10:49:00 2009 +1000 279 Fix timing race in pmcd signalling Replace pmsignal by new src-oss/killparent application to reduce delay between SIGHUP to pmcd and bogus/fungus PMDAs killing pmcd. Root cause problem was likley a timing window in pmdaproc.sh that has been fixed in another pcp commit. commit 03f8202f074f92f494effa71fa67276bf47e4c87 Author: Ken McDonell Date: Fri Sep 25 07:13:31 2009 +1000 274.out broken_pmda.c PMDA_INTERFACE_4 is now valid Bumped BUG_5 case to use version 77 of the PMDA_INTERFACE as version 4 is now valid and the qa test was failing. commit e77bba6fe36b72e03f7ed2e5bf337fe332dcae72 Author: Ken McDonell Date: Fri Sep 25 06:39:00 2009 +1000 628 Additional fallout from adding Perl implementation of simple PMDA Need copy of pmdasimple.pl to make the "idiot" PMDA install work properly. commit 0c5e9b4e24edb8b78a795b006b022d2e985125b5 Author: Ken McDonell Date: Thu Sep 24 22:03:04 2009 +1000 304.out GUI dialog mentions pmsignal rather than kill now commit 79d710889564b3ce57226caa61e9cc17cb8513f5 Author: Ken McDonell Date: Thu Sep 24 17:10:19 2009 +1000 427 Use $PCP_PMLOGGERCONTROL_PATH to find pmlogger control file commit cf03f58e05c90fc70cda7d18428e12602fff6835 Merge: 742573b... 5dec804... Author: Ken McDonell Date: Mon Sep 14 06:40:38 2009 +1000 Merge branch 'master' of git://oss.sgi.com/pcp/pcpqa commit 742573bf8910f1e889cd2ccaba0973c4bead9d07 Author: Ken McDonell Date: Mon Sep 14 06:39:59 2009 +1000 Add Ken's local QA hosts. commit 90d8e6a0a36eed0011a351181c00a2729aa38ddd Author: Ken McDonell Date: Mon Sep 14 06:39:28 2009 +1000 118 reinstate trap for exit handling commit bc4692dc672c56ec1f06ecd03962d5a4a5364fa7 Merge: f375603... 743b7c7... Author: Ken McDonell Date: Mon Sep 7 21:37:18 2009 +1000 Merge branch 'master' of git://oss.sgi.com/pcp/pcpqa commit f37560380d8afac2f85a87da083b06ee94d6f875 Merge: 6eaeed1... 652a5bd... Author: Ken McDonell Date: Mon Sep 7 19:49:46 2009 +1000 Merge branch 'master' of git://oss.sgi.com/mort/pcpqa commit 6eaeed1c691a648bf1a1fda5bb3b3283f85d07cc Author: Ken McDonell Date: Mon Sep 7 11:51:27 2009 +1000 Fix (implicit) timezone problem identified by Martin Hicks. commit d8875849cea36b2fcf36338d53dbb15516d0c1a1 Author: Ken McDonell Date: Mon Sep 7 11:50:33 2009 +1000 Add some overlooked pmval tests to the pmval group. commit c0b61a3c1ed7fcc5b284984e3571d6a093440b07 Merge: f68225d... 24fb70f... Author: Ken McDonell Date: Tue Sep 1 17:58:49 2009 +1000 Merge branch 'master' of git://oss.sgi.com/mort/pcpqa into pmns commit f68225d8980dfc2ac70d81abde67685fc67da121 Author: Ken McDonell Date: Tue Sep 1 17:46:32 2009 +1000 Interim checkin with assorted dynamic pmns changes. commit f3e1fe94c27c7a85f1f88c4d5222037597015131 Author: Ken McDonell Date: Thu Aug 6 18:21:08 2009 +1000 Further refinement in the wake of the dynamic metrics changes. commit 4970fa6d08e41ebfe9300985279b9057275a0a20 Merge: 2ec2632... 475950a... Author: Ken McDonell Date: Wed Jul 29 21:03:01 2009 +1000 Merge branch 'master' into pmns Conflicts: src-oss/GNUmakefile - fixed ... Nathan and I had added two different C progs commit 475950a18191d86bc05159601985e5a819064b8f Merge: 2552cfc... a5f2213... Author: Ken McDonell Date: Wed Jul 29 20:56:49 2009 +1000 Merge branch 'master' of git://oss.sgi.com/pcp/pcpqa commit 2ec2632a8a2584ead0fd1da91e69ddb558a42d9d Author: Ken McDonell Date: Wed Jul 29 20:55:20 2009 +1000 More dynamic PMNS checks. commit 51ba91315d5dbb7ceb010469aa5c8817019b2173 Author: Ken McDonell Date: Wed Jul 29 20:42:50 2009 +1000 More dynamic PMNS checks. commit c371d4d7999905740265b51d23782a99983f9a6c Merge: 124f585... 2552cfc... Author: Ken McDonell Date: Wed Jul 15 17:18:27 2009 +1000 Merge branch 'master' into pmns commit 2552cfc3f0de91b0828d1ac6ad0dd3772e8ea6e9 Merge: 228df42... 52ff618... Author: Ken McDonell Date: Wed Jul 15 17:16:18 2009 +1000 Merge branch 'master' of git://oss.sgi.com/pcp/pcpqa commit 124f585d54c13d1a9336645ce2a187d0580cf844 Author: Ken McDonell Date: Wed Jul 15 17:14:10 2009 +1000 More dynamic PMNS changes. Changes as a result of adding sample.secret.* to the sample PMDA. commit eb72e334be23f598b8f56403aad9bd947c7c0ef0 Author: Ken McDonell Date: Sun Jul 12 20:30:24 2009 +1000 Baseline QA passes after increasing PMDA domain to 9 bits. commit e5694f95f3a6ae9792ee8ed9b0341981c94fe657 Author: Ken McDonell Date: Sun Jul 12 07:25:58 2009 +1000 Baseline QA passes after increasing PMDA domain to 9 bits. commit 228df42225f2710b5ad390be8f3105cf29c94389 Author: Ken McDonell Date: Sat Jul 11 07:28:40 2009 +1000 Check if qualified output exists for the current O/S. From mort@sgi.com Tue Sep 29 08:38:19 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n8TDcItr206823 for ; Tue, 29 Sep 2009 08:38:18 -0500 Received: from attica.americas.sgi.com (attica.americas.sgi.com [128.162.236.44]) by relay1.corp.sgi.com (Postfix) with ESMTP id BB46B8F80BD; Tue, 29 Sep 2009 06:39:37 -0700 (PDT) Received: by attica.americas.sgi.com (Postfix, from userid 44682) id C8CEFA243300; Tue, 29 Sep 2009 08:39:36 -0500 (CDT) Date: Tue, 29 Sep 2009 08:39:36 -0500 From: Martin Hicks To: Mark Goodwin Cc: kenj@internode.on.net, pcp@oss.sgi.com Subject: Re: [pcp] Dynamic PMNS changes finally arrive Message-ID: <20090929133936.GT10563@alcatraz.americas.sgi.com> References: <1254034250.4466.12.camel@bozo-laptop.localdomain> <4AC14301.204@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AC14301.204@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Tue, Sep 29, 2009 at 09:13:05AM +1000, Mark Goodwin wrote: > Hi Ken, > > I have a round of changes (v3.0.0-6) to push up to the dev branch > (clean up "the mess" following the Fedora keel-haul, and also > integrates the perl packaging) - this is under QA at the moment, > which is taking longer than I'd hoped. > > In any case, I'll push 3.0.0-6 to 'dev' asap. Then I'll merge your > master branch and run a QA delta. If that goes OK I propose we push > this to (v3.0.0-7) for review and soak time in the dev branch since > the design is already reviewed. At the very least we'll need to > update the cluster PMDA before 3.0 can be considered release worthy. How much of the cluster PMDA must be done now? I suspect that we *must* at least update the duplicated data structures with the larger domain bit width. I think the optional part would be to also start using the new dynamic namespace stuff... mh From kenj@internode.on.net Tue Sep 29 16:42:35 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n8TLgYsO228924 for ; Tue, 29 Sep 2009 16:42:35 -0500 X-ASG-Debug-ID: 1254260633-10fb00e40000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 4A68448C35E for ; Tue, 29 Sep 2009 14:43:54 -0700 (PDT) Received: from mail.internode.on.net (bld-mail13.adl6.internode.on.net [150.101.137.98]) by cuda.sgi.com with ESMTP id hZNE7rsTqW7lrMV9 for ; Tue, 29 Sep 2009 14:43:54 -0700 (PDT) Received: from [192.168.1.100] (unverified [118.208.169.2]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 5990892-1927428 for multiple; Wed, 30 Sep 2009 07:13:52 +0930 (CST) X-ASG-Orig-Subj: Re: [pcp] Dynamic PMNS changes finally arrive Subject: Re: [pcp] Dynamic PMNS changes finally arrive From: Ken McDonell Reply-To: kenj@internode.on.net To: Martin Hicks Cc: Mark Goodwin , pcp@oss.sgi.com In-Reply-To: <20090929133936.GT10563@alcatraz.americas.sgi.com> References: <1254034250.4466.12.camel@bozo-laptop.localdomain> <4AC14301.204@gmail.com> <20090929133936.GT10563@alcatraz.americas.sgi.com> Content-Type: text/plain Date: Wed, 30 Sep 2009 07:43:39 +1000 Message-Id: <1254260619.12546.12.camel@bozo> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail13.adl6.internode.on.net[150.101.137.98] X-Barracuda-Start-Time: 1254260636 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0002 1.0000 -2.0199 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.10365 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Tue, 2009-09-29 at 08:39 -0500, Martin Hicks wrote: ... > How much of the cluster PMDA must be done now? > > I suspect that we *must* at least update the duplicated data structures > with the larger domain bit width. I think the optional part would be to > also start using the new dynamic namespace stuff... Unless the cluster PMDA is assigned a domain number > 255 (seems unlikely at this stage), it "should just work" (tm) ... the low-order 30 bits of a pmID and pmInDom are unchanged with the PMDA_INTERFACE_4 round of changes. Now you may _want_ to make changes to the cluster PMDA but I'm not sure they are necessary before declaring 3.0 ready to go ... indeed one could argue that 3.0 should happen first then the PMDA_INTERFACE_4 changes are merged ready for a 3.1 release. From nscott@aconex.com Wed Sep 30 02:16:22 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n8U7GMLI001632 for ; Wed, 30 Sep 2009 02:16:22 -0500 X-ASG-Debug-ID: 1254295062-4fad00fb0000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5D720170F7F7 for ; Wed, 30 Sep 2009 00:17:42 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id 8NeIY8CKY6EJc67L for ; Wed, 30 Sep 2009 00:17:42 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id 4DCF0498B66; Wed, 30 Sep 2009 17:17:40 +1000 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id qY008nzx8KUMTDIz; Wed, 30 Sep 2009 17:17:40 +1000 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 9DE20A50280; Wed, 30 Sep 2009 17:16:24 +1000 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 3A4184FD87; Wed, 30 Sep 2009 17:17:40 +1000 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at gatekeeper.yarra.acx Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GBniJJaKYXUu; Wed, 30 Sep 2009 17:17:36 +1000 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id 2FDC84FD86; Wed, 30 Sep 2009 17:17:36 +1000 (EST) Date: Wed, 30 Sep 2009 17:17:36 +1000 (EST) From: Nathan Scott To: kenj@internode.on.net Cc: pcp@oss.sgi.com Message-ID: <500324456.1301254295056118.JavaMail.root@mail-au.aconex.com> In-Reply-To: <1254034250.4466.12.camel@bozo-laptop.localdomain> X-ASG-Orig-Subj: Re: [pcp] Dynamic PMNS changes finally arrive Subject: Re: [pcp] Dynamic PMNS changes finally arrive MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - [unknown] (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1254295064 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.10403 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean Hi Ken, ----- "Ken McDonell" wrote: > Committed to the *master* branch of my PCP tree on oss.sgi.com > > There are several rounds of commits for this set of changes that > became > much more complicated and touched more files than I'd originally > expected. > > This all passes my QA ... after I get some feedback on the PCP > changes I'll move the QA tree forward. I've pulled the dynamic PMNS changes out into a separate patch for reviewing and given it an initial read-through. So far, the only thing that I've noticed is the (leftover?) commented out TODO in src/libpcp_pmda/src/mainloop.c where a manual loadnamespace looks to have been inserted (+ later removed) at some point. Otherwise it looks pretty good. I wonder if we should be bumping the libpcp_pmda shared library soname for this change? Also it'd be good to convert a "real" PMDA like MMV (which it sounds like you've started from that other mail) - maybe a helper routine or two might fall out of that that could live in libpcp_pmda, and if so, good to get those into the library for the dso vesion change. The patch is at http://oss.sgi.com/~nathans/dynamic_pmns.patch if others would like to review it standalone too (please do!). cheers. -- Nathan From kenj@internode.on.net Wed Sep 30 19:59:17 2009 X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n910xGG6059818 for ; Wed, 30 Sep 2009 19:59:17 -0500 X-ASG-Debug-ID: 1254358837-3d1302320000-S8gJnT X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 51197171E720 for ; Wed, 30 Sep 2009 18:00:37 -0700 (PDT) Received: from mail.internode.on.net (bld-mail18.adl2.internode.on.net [150.101.137.103]) by cuda.sgi.com with ESMTP id G9FAew5Ki9xyEoeD for ; Wed, 30 Sep 2009 18:00:37 -0700 (PDT) Received: from [192.168.1.100] (unverified [118.208.169.2]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 5978135-1927428 for multiple; Thu, 01 Oct 2009 10:30:34 +0930 (CST) X-ASG-Orig-Subj: Re: [pcp] Dynamic PMNS changes finally arrive Subject: Re: [pcp] Dynamic PMNS changes finally arrive From: Ken McDonell Reply-To: kenj@internode.on.net To: Nathan Scott Cc: pcp@oss.sgi.com In-Reply-To: <500324456.1301254295056118.JavaMail.root@mail-au.aconex.com> References: <500324456.1301254295056118.JavaMail.root@mail-au.aconex.com> Content-Type: text/plain Date: Thu, 01 Oct 2009 11:00:20 +1000 Message-Id: <1254358820.26275.8.camel@bozo> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: bld-mail18.adl2.internode.on.net[150.101.137.103] X-Barracuda-Start-Time: 1254358839 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0001 1.0000 -2.0204 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.10475 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Wed, 2009-09-30 at 17:17 +1000, Nathan Scott wrote: > ... > I've pulled the dynamic PMNS changes out into a separate patch for > reviewing and given it an initial read-through. So far, the only > thing that I've noticed is the (leftover?) commented out TODO in > src/libpcp_pmda/src/mainloop.c where a manual loadnamespace looks > to have been inserted (+ later removed) at some point. Yep that was a a residual piece from when I was confused ... the code passed QA without this loadnamespace call, and indeed by analysis it is not needed ... it is gone in my local tree. > Otherwise it looks pretty good. I wonder if we should be bumping > the libpcp_pmda shared library soname for this change? ... I don't think this is necessary ... these changes are both forwards and backwards compatible in the sense that there are no loader symbol changes, none of the ABI syntax is changes, and the semantic changes are all guarded by PMDA_INTERFACE_? that will work in the old and the new code. Changing to a 9-bit domain number might be an argument for moving the dso version numbers but that would be for all libraries (I suspect) and not really necessary either as no existing code will break with these library changes, unless a domain number > 255 is assigned. > ... > Also it'd > be good to convert a "real" PMDA like MMV (which it sounds like > you've started from that other mail) - maybe a helper routine or > two might fall out of that that could live in libpcp_pmda, and if > so, good to get those into the library for the dso vesion change. That's probably a good idea ... I can help, but I don't profess any expertise in the mmv pmda, so probably requires some collaborative effort. > The patch is at http://oss.sgi.com/~nathans/dynamic_pmns.patch if > others would like to review it standalone too (please do!). Thanks. > cheers. >