From owner-fam@oss.sgi.com Tue Jan 23 15:35:11 2001 Received: by oss.sgi.com id ; Tue, 23 Jan 2001 15:35:02 -0800 Received: from svn.net ([167.160.200.10]:35844 "EHLO svn.net") by oss.sgi.com with ESMTP id ; Tue, 23 Jan 2001 15:34:42 -0800 Received: from wantelbos (bastian@pm3-136.svn.net [167.160.201.136]) by svn.net (8.10.0/8.10.0) with SMTP id f0NNYZ526259; Tue, 23 Jan 2001 15:34:36 -0800 Content-Type: text/plain; charset="iso-8859-1" From: Waldo Bastian To: kde-core-devel@max.tat.physik.uni-tuebingen.de, "Wilco Greven" , kde-core-devel@kde.org Subject: [fam] Re: kdeinit + kwin <-> fam problem Date: Tue, 23 Jan 2001 15:57:14 -0800 References: <20010123200852.A445@wicky> In-Reply-To: <20010123200852.A445@wicky> Cc: fam@oss.sgi.com MIME-Version: 1.0 Message-Id: <01012315571401.24387@wantelbos> Content-Transfer-Encoding: 8bit Sender: owner-fam@oss.sgi.com Precedence: bulk Return-Path: X-Orcpt: rfc822;fam-outgoing On Tuesday 23 January 2001 11:08, Wilco Greven wrote: > Hi, > > As some people already know, KWin and fam both have a class Client. This > causes kwin to crash when it is started by kdeinit, since kdeinit links > against kio, which in its turn links against fam. > > AFAIK there are two things we can do at the moment to solve the problem. We > can stop using libfam or we can start kwin directly without using kdeinit. > What would be the best thing to do? Use the following patch. FAM tries to let the linker limit the symbols it exports but that doesn't work. This patch puts the Client class in a FAM namespace. Rusty: Could you add this patch to 2.6.5? Cheers, Waldo -- bastian@kde.org | SuSE Labs KDE Developer | bastian@suse.com -- Source code, list archive, and docs: http://oss.sgi.com/projects/fam/ To unsubscribe: echo unsubscribe fam | mail majordomo@oss.sgi.com From owner-fam@oss.sgi.com Tue Jan 23 16:12:32 2001 Received: by oss.sgi.com id ; Tue, 23 Jan 2001 16:12:12 -0800 Received: from svn.net ([167.160.200.10]:7431 "EHLO svn.net") by oss.sgi.com with ESMTP id ; Tue, 23 Jan 2001 16:11:40 -0800 Received: from wantelbos (bastian@pm3-136.svn.net [167.160.201.136]) by svn.net (8.10.0/8.10.0) with SMTP id f0O0BX528982; Tue, 23 Jan 2001 16:11:33 -0800 Content-Type: Multipart/Mixed; charset="iso-8859-1"; boundary="------------Boundary-00=_ZK5NHI00BNGNOHHVCENL" From: Waldo Bastian To: kde-core-devel@max.tat.physik.uni-tuebingen.de, "Wilco Greven" , kde-core-devel@kde.org Subject: [fam] Re: kdeinit + kwin <-> fam problem + PATCH Date: Tue, 23 Jan 2001 16:34:11 -0800 References: <20010123200852.A445@wicky> In-Reply-To: <20010123200852.A445@wicky> Cc: fam@oss.sgi.com MIME-Version: 1.0 Message-Id: <01012315571401.24387@wantelbos> Content-Transfer-Encoding: 8bit Sender: owner-fam@oss.sgi.com Precedence: bulk Return-Path: X-Orcpt: rfc822;fam-outgoing --------------Boundary-00=_ZK5NHI00BNGNOHHVCENL Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit On Tuesday 23 January 2001 11:08, Wilco Greven wrote: > Hi, > > As some people already know, KWin and fam both have a class Client. This > causes kwin to crash when it is started by kdeinit, since kdeinit links > against kio, which in its turn links against fam. > > AFAIK there are two things we can do at the moment to solve the problem. We > can stop using libfam or we can start kwin directly without using kdeinit. > What would be the best thing to do? Use the following patch. FAM tries to let the linker limit the symbols it exports but that doesn't work. This patch puts the Client class in a FAM namespace. Rusty: Could you add this patch to 2.6.5? Cheers, Waldo -- bastian@kde.org | SuSE Labs KDE Developer | bastian@suse.com --------------Boundary-00=_ZK5NHI00BNGNOHHVCENL Content-Type: text/x-c++; charset="iso-8859-1"; name="fam.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="fam.patch" ZGlmZiAtdSBmYW0tb3NzLTIuNi40L2xpYmZhbS9DbGllbnQuYysrIGZhbS1vc3MtMi42LjQubmV3 L2xpYmZhbS9DbGllbnQuYysrCi0tLSBmYW0tb3NzLTIuNi40L2xpYmZhbS9DbGllbnQuYysrCUZy aSBNYXkgMTkgMjE6NDY6MzIgMjAwMAorKysgZmFtLW9zcy0yLjYuNC5uZXcvbGliZmFtL0NsaWVu dC5jKysJVGh1IFNlcCAgNyAxNTo1MjowMCAyMDAwCkBAIC0zOCw2ICszOCw4IEBACiAjaW5jbHVk ZSAiZmFtLmgiCiAjaW5jbHVkZSAiQ2xpZW50LmgiCiAKK3VzaW5nIG5hbWVzcGFjZSBGQU07CisK IHN0YXRpYyB2b2lkIGdldHdvcmQoY29uc3QgY2hhciAqcCwgdV9pbnQzMl90ICpsKTsKIAogQ2xp ZW50OjpDbGllbnQobG9uZyBob3N0LCB1bnNpZ25lZCBpbnQgcHJvZywgaW50IHZlcnMpCmRpZmYg LXUgZmFtLW9zcy0yLjYuNC9saWJmYW0vQ2xpZW50LmggZmFtLW9zcy0yLjYuNC5uZXcvbGliZmFt L0NsaWVudC5oCi0tLSBmYW0tb3NzLTIuNi40L2xpYmZhbS9DbGllbnQuaAlGcmkgTWF5IDE5IDIx OjQ2OjMyIDIwMDAKKysrIGZhbS1vc3MtMi42LjQubmV3L2xpYmZhbS9DbGllbnQuaAlUaHUgU2Vw ICA3IDE1OjUxOjM1IDIwMDAKQEAgLTMxLDYgKzMxLDggQEAKIAogc3RydWN0IEZBTUV2ZW50Owog CituYW1lc3BhY2UgRkFNIHsKKwogY2xhc3MgQ2xpZW50IHsKICAgICBwdWJsaWM6CiAJQ2xpZW50 KGxvbmcgaG9zdGFkZHIsIHVuc2lnbmVkIGludCBwcm9nLCBpbnQgdmVycyk7CkBAIC01OCw0ICs2 MCw2IEBACiAgICAgICAgIEJUcmVlPGludCwgYm9vbD4gICAqZW5kRXhpc3Q7CiAJY2hhciAqaW5l bmQsaW5idWZbTVNHQlVGU0laXTsKIH07CisKK30KICNlbmRpZgpkaWZmIC11IGZhbS1vc3MtMi42 LjQvbGliZmFtL2ZhbS5jKysgZmFtLW9zcy0yLjYuNC5uZXcvbGliZmFtL2ZhbS5jKysKLS0tIGZh bS1vc3MtMi42LjQvbGliZmFtL2ZhbS5jKysJRnJpIE1heSAxOSAyMTo0NjozMiAyMDAwCisrKyBm YW0tb3NzLTIuNi40Lm5ldy9saWJmYW0vZmFtLmMrKwlUaHUgU2VwICA3IDE1OjUzOjE4IDIwMDAK QEAgLTc3LDggKzc3LDggQEAKICAgICB9CiAKICAgICAvLyAgVHJ5IHRvIGNvbm5lY3QuCi0gICAg ZmMtPmNsaWVudCA9IG5ldyBDbGllbnQoTE9DQUxIT1NUTlVNQkVSLCBmYW1udW1iZXIsIGZhbXZl cnNpb24pOwotICAgIGZjLT5mZCA9ICgoQ2xpZW50ICopZmMtPmNsaWVudCktPmdldFNvY2soKTsK KyAgICBmYy0+Y2xpZW50ID0gbmV3IEZBTTo6Q2xpZW50KExPQ0FMSE9TVE5VTUJFUiwgZmFtbnVt YmVyLCBmYW12ZXJzaW9uKTsKKyAgICBmYy0+ZmQgPSAoKEZBTTo6Q2xpZW50ICopZmMtPmNsaWVu dCktPmdldFNvY2soKTsKICAgICBpZiAoZmMtPmZkIDwgMCkgewogCWRlbGV0ZSBmYy0+Y2xpZW50 OwogICAgICAgICBmYy0+Y2xpZW50ID0gTlVMTDsKQEAgLTg5LDcgKzg5LDcgQEAKICAgICBpZiAo YXBwTmFtZSkgewogCWNoYXIgbXNnWzIwMF07CiAJc25wcmludGYobXNnLCBzaXplb2YobXNnKSwg Ik4wICVkICVkICVzXG4iLCBnZXRldWlkKCksIGdldGVnaWQoKSwgYXBwTmFtZSk7Ci0JKChDbGll bnQgKilmYy0+Y2xpZW50KS0+d3JpdGVUb1NlcnZlcihtc2csIHN0cmxlbihtc2cpKzEpOworCSgo RkFNOjpDbGllbnQgKilmYy0+Y2xpZW50KS0+d3JpdGVUb1NlcnZlcihtc2csIHN0cmxlbihtc2cp KzEpOwogICAgIH0KIAogICAgIHJldHVybigwKTsKQEAgLTEwMiw3ICsxMDIsNyBAQAogCiBpbnQg RkFNQ2xvc2UoRkFNQ29ubmVjdGlvbiogZmMpCiB7Ci0gICAgZGVsZXRlIChDbGllbnQgKilmYy0+ Y2xpZW50OworICAgIGRlbGV0ZSAoRkFNOjpDbGllbnQgKilmYy0+Y2xpZW50OwogICAgIHJldHVy bigwKTsKIH0KIApAQCAtMTIyLDcgKzEyMiw3IEBACiAJcmV0dXJuIC0xOwogCiAgICAgaW50IHJl cW51bSA9IGZyLT5yZXFudW07Ci0gICAgQ2xpZW50ICpjbGllbnQgPSAoQ2xpZW50ICopZmMtPmNs aWVudDsKKyAgICBGQU06OkNsaWVudCAqY2xpZW50ID0gKEZBTTo6Q2xpZW50ICopZmMtPmNsaWVu dDsKICAgICAvLyBzdG9yZSB1c2VyIGRhdGEgaWYgbmVjZXNzYXJ5CiAgICAgaWYodXNlckRhdGEg IT0gTlVMTCkgY2xpZW50LT5zdG9yZVVzZXJEYXRhKHJlcW51bSwgdXNlckRhdGEpOwogCkBAIC0x OTEsNyArMTkxLDcgQEAKIHsKICAgICBpZihjaGVja1JlcXVlc3QoZnIsIGZpbGVuYW1lKSAhPSAw KSByZXR1cm4gLTE7CiAKLSAgICBDbGllbnQgKmNsaWVudCA9IChDbGllbnQgKilmYy0+Y2xpZW50 OworICAgIEZBTTo6Q2xpZW50ICpjbGllbnQgPSAoRkFNOjpDbGllbnQgKilmYy0+Y2xpZW50Owog CiAgICAgLy8gc3RvcmUgdXNlciBkYXRhIGlmIG5lY2Vzc2FyeQogICAgIGlmICh1c2VyRGF0YSkg Y2xpZW50LT5zdG9yZVVzZXJEYXRhKGZyLT5yZXFudW0sIHVzZXJEYXRhKTsKQEAgLTI2Miw3ICsy NjIsNyBAQAogaW50IEZBTU5leHRFdmVudChGQU1Db25uZWN0aW9uKiBmYywgRkFNRXZlbnQqIGZl KQogewogICAgIGZlLT5mYyA9IGZjOwotICAgIHJldHVybiAoKENsaWVudCAqKWZjLT5jbGllbnQp LT5uZXh0RXZlbnQoZmUpOworICAgIHJldHVybiAoKEZBTTo6Q2xpZW50ICopZmMtPmNsaWVudCkt Pm5leHRFdmVudChmZSk7CiB9CiAKIC8vICBGQU1QZW5kaW5nIHRyaWVzIHRvIHJlYWQgb25lIGNv bXBsZXRlIG1lc3NhZ2UgaW50byB0aGUgaW5wdXQgYnVmZmVyLgpAQCAtMjcxLDcgKzI3MSw3IEBA CiAKIGludCBGQU1QZW5kaW5nKEZBTUNvbm5lY3Rpb24qIGZjKQogewotICAgIHJldHVybiAoKENs aWVudCAqKWZjLT5jbGllbnQpLT5ldmVudFBlbmRpbmcoKTsKKyAgICByZXR1cm4gKChGQU06OkNs aWVudCAqKWZjLT5jbGllbnQpLT5ldmVudFBlbmRpbmcoKTsKIH0KIAogCkBAIC0zMjQsNyArMzI0 LDcgQEAKICAgICBzbnByaW50Zihtc2csIE1TR0JVRlNJWiwgIiVjJWQgJWQgJWRcbiIsIGNvZGUs IGZyLT5yZXFudW0sIGdldGV1aWQoKSwgZ2V0ZWdpZCgpKTsKIAogICAgIC8vIFNlbmQgdG8gRkFN Ci0gICAgKChDbGllbnQgKilmYy0+Y2xpZW50KS0+d3JpdGVUb1NlcnZlcihtc2csIHN0cmxlbiht c2cpKzEpOworICAgICgoRkFNOjpDbGllbnQgKilmYy0+Y2xpZW50KS0+d3JpdGVUb1NlcnZlciht c2csIHN0cmxlbihtc2cpKzEpOwogICAgIHJldHVybigwKTsKIH0KIAo= --------------Boundary-00=_ZK5NHI00BNGNOHHVCENL-- -- Source code, list archive, and docs: http://oss.sgi.com/projects/fam/ To unsubscribe: echo unsubscribe fam | mail majordomo@oss.sgi.com