From jlan@engr.sgi.com Tue Aug 24 11:11:18 2004 Received: with ECARTIS (v1.0.0; list csa); Tue, 24 Aug 2004 11:11:25 -0700 (PDT) Received: from omx2.sgi.com (omx2-ext.sgi.com [192.48.171.19]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i7OIBIia013872 for ; Tue, 24 Aug 2004 11:11:18 -0700 Received: from cthulhu.engr.sgi.com (cthulhu.engr.sgi.com [192.26.80.2]) by omx2.sgi.com (8.12.11/8.12.9/linux-outbound_gateway-1.1) with ESMTP id i7OJGBBA011553 for ; Tue, 24 Aug 2004 12:16:11 -0700 Received: from aware.engr.sgi.com (aware.engr.sgi.com [163.154.6.184]) by cthulhu.engr.sgi.com (SGI-8.12.5/8.12.5) with ESMTP id i7OIB5Y95612773; Tue, 24 Aug 2004 11:11:10 -0700 (PDT) Received: from engr.sgi.com (aware.engr.sgi.com [127.0.0.1]) by aware.engr.sgi.com (8.12.8/8.12.8) with ESMTP id i7OIAexV000556; Tue, 24 Aug 2004 11:10:40 -0700 Message-ID: <412B849F.1020406@engr.sgi.com> Date: Tue, 24 Aug 2004 11:10:39 -0700 From: Jay Lan User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20030225 X-Accept-Language: en-us, en MIME-Version: 1.0 To: csa@oss.sgi.com CC: Kevin Snow Subject: new CSA patches available for linux kernel 2.6.8 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-archive-position: 15 X-ecartis-version: Ecartis v1.0.0 Sender: csa-bounce@oss.sgi.com Errors-to: csa-bounce@oss.sgi.com X-original-sender: jlan@engr.sgi.com Precedence: bulk X-list: csa Hi guys, Attached below is my announcement letter to oss.sgi.com. A smiliar one will be sent to LKML. Correction to my English is appreciated! --------------------------------------------------------------------------- Hi, I have broken up previously one big CSA kernel patch into four smaller ones: csa_io - collects io accounting data csa_mm - collects mm accounting data csa_eop - provides a hook to perform end-of-process accounting csa_module - builds csa loadable module The files can be found at usual place with the following file names: linux-2.6.8.csa_io.patch linux-2.6.8.csa_mm.patch linux-2.6.8.csa_eop.patch linux-2.6.8.csa_module.patch There is no functional change in this set of csa patches compared to the 2.6.7 patch linux-2.6.7.csa.patch. Patches csa_io, csa_mm, and csa_eop are independent to each other. You may apply any one of the three or all and would be able to build a functional kernel. However, data collected needs an agent to use it. The csa_module is one agent that takes advangtage of the feature and works with csa-2.0.0 or later rpm to report system accounting data of the host system. The csa_module patch requires all three accounting data patches to be fully functional. This set of csa patches have been tested with the pagg and job kernel patches to linux 2.6.8 kernel. The csa_module requires the pagg and job kernel patches. Feedback, bug report, and comments are very welcome! Signed-off-by: Jay Lan --- Jay Lan - Linux System Software Silicon Graphics Inc., Mountain View, CA From jlan@engr.sgi.com Tue Aug 31 15:29:41 2004 Received: with ECARTIS (v1.0.0; list csa); Tue, 31 Aug 2004 15:29:54 -0700 (PDT) Received: from omx2.sgi.com (omx2-ext.sgi.com [192.48.171.19]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i7VMTf7F011032 for ; Tue, 31 Aug 2004 15:29:41 -0700 Received: from cthulhu.engr.sgi.com (cthulhu.engr.sgi.com [192.26.80.2]) by omx2.sgi.com (8.12.11/8.12.9/linux-outbound_gateway-1.1) with ESMTP id i7VNZbF7023274 for ; Tue, 31 Aug 2004 16:35:37 -0700 Received: from aware.engr.sgi.com (aware.engr.sgi.com [163.154.6.184]) by cthulhu.engr.sgi.com (SGI-8.12.5/8.12.5) with ESMTP id i7VMTVY97160326; Tue, 31 Aug 2004 15:29:31 -0700 (PDT) Received: from engr.sgi.com (aware.engr.sgi.com [127.0.0.1]) by aware.engr.sgi.com (8.12.8/8.12.8) with ESMTP id i7VMS9xV032331; Tue, 31 Aug 2004 15:28:09 -0700 Message-ID: <4134FB79.40401@engr.sgi.com> Date: Tue, 31 Aug 2004 15:28:09 -0700 From: Jay Lan User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20030225 X-Accept-Language: en-us, en MIME-Version: 1.0 To: csa@oss.sgi.com Subject: CSA discussion thread at Lse-tech mailing list Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-archive-position: 16 X-ecartis-version: Ecartis v1.0.0 Sender: csa-bounce@oss.sgi.com Errors-to: csa-bounce@oss.sgi.com X-original-sender: jlan@engr.sgi.com Precedence: bulk X-list: csa Hi, SGI tried to push CSA to get accepted into community kernel. I broke up one big CSA patch into 4 smaller ones and announced them to lkml on 8/25. Andrew Morton then moved the discussion to Lse-tech list. The discussion has been great. Looks like the three data collection patches would be admitted at least. We started doing code review. If you or your customers are using or interested in Linux CSA, please inform them of such a discussion so the customers can provide input in what they need, like and miss. You can subscribe to the Lse-tech mailing list below: https://lists.sourceforge.net/lists/listinfo/lse-tech The discussion thread can be viewed from the Lse-tech Archives link from the above URL. You do not need to subscribe to view the archives. I would add csa@oss.sgi.com to the Cc list on my future postings. Thanks, - jay From jlan@engr.sgi.com Tue Aug 31 16:02:45 2004 Received: with ECARTIS (v1.0.0; list csa); Tue, 31 Aug 2004 16:02:55 -0700 (PDT) Received: from omx2.sgi.com (omx2-ext.sgi.com [192.48.171.19]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i7VN2fWd011756 for ; Tue, 31 Aug 2004 16:02:41 -0700 Received: from cthulhu.engr.sgi.com (cthulhu.engr.sgi.com [192.26.80.2]) by omx2.sgi.com (8.12.11/8.12.9/linux-outbound_gateway-1.1) with ESMTP id i8108bvJ030177 for ; Tue, 31 Aug 2004 17:08:37 -0700 Received: from aware.engr.sgi.com (aware.engr.sgi.com [163.154.6.184]) by cthulhu.engr.sgi.com (SGI-8.12.5/8.12.5) with ESMTP id i7VN2TY97187622; Tue, 31 Aug 2004 16:02:29 -0700 (PDT) Received: from engr.sgi.com (aware.engr.sgi.com [127.0.0.1]) by aware.engr.sgi.com (8.12.8/8.12.8) with ESMTP id i7VN12xV032426; Tue, 31 Aug 2004 16:01:04 -0700 Message-ID: <4135032E.7060605@engr.sgi.com> Date: Tue, 31 Aug 2004 16:01:02 -0700 From: Jay Lan User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20030225 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Tim Schmielau CC: Guillaume Thouvenin , Arthur Corliss , Andrew Morton , lkml , erikj@dbear.engr.sgi.com, limin@engr.sgi.com, lse-tech@lists.sourceforge.net, ? , Yoshitaka ISHIKAWA , csa@oss.sgi.com Subject: Re: [Lse-tech] Re: [PATCH] new CSA patchset for 2.6.8 References: <412D2E10.8010406@engr.sgi.com> <20040825221842.72dd83a4.akpm@osdl.org> <412E4C27.1010805@engr.sgi.com> <20040830122614.GA2518@frec.bull.fr> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-archive-position: 17 X-ecartis-version: Ecartis v1.0.0 Sender: csa-bounce@oss.sgi.com Errors-to: csa-bounce@oss.sgi.com X-original-sender: jlan@engr.sgi.com Precedence: bulk X-list: csa Adding csa@oss.sgi.com, the CSA user group mailing list, to Cc. Tim Schmielau wrote: > On Mon, 30 Aug 2004, Guillaume Thouvenin wrote: > > >> Thus, to be clear, the enhanced accounting can be divided into >>three parts: >> >> 1) A common data collection method in the kernel. >> We could start from BSD-accounting and add CSA information. Could >> it be something like BSD version4? > > > I've had a quick look at the CSA data collection patches. To get the > discussion started, here are my comments: > > >>--- linux.orig/drivers/block/ll_rw_blk.c 2004-08-13 22:36:16.000000000 -0700 >>+++ linux/drivers/block/ll_rw_blk.c 2004-08-18 12:07:10.000000000 -0700 >>@@ -1948,10 +1950,12 @@ >> >> if (rw == READ) { >> disk_stat_add(rq->rq_disk, read_sectors, nr_sectors); >>+ current->rblk += nr_sectors; >> if (!new_io) >> disk_stat_inc(rq->rq_disk, read_merges); >> } else if (rw == WRITE) { >> disk_stat_add(rq->rq_disk, write_sectors, nr_sectors); >>+ current->wblk += nr_sectors; >> if (!new_io) >> disk_stat_inc(rq->rq_disk, write_merges); >> } > > > Andi Kleen's comment on the ELSA patch also applies here - most writes > will get accounted to pdflushd. See > > http://www.lib.uaa.alaska.edu/linux-kernel/archive/2004-Week-31/0047.html > > for his comment. I need more time on this. :) > > >>--- /dev/null 1970-01-01 00:00:00.000000000 +0000 >>+++ linux/include/linux/csa_internal.h 2004-08-19 15:19:05.000000000 -0700 > > [...] > >>+#else /* CONFIG_CSA || CONFIG_CSA_MODULE */ >>+ >>+#define csa_update_integrals() do { } while (0); >>+#define csa_clear_integrals(task) do { } while (0); >>+#endif /* CONFIG_CSA || CONFIG_CSA_MODULE */ > > > I suppose the semicolons are unintentional. Good catch! I fixed this in our internal tree. > > >>--- linux.orig/include/linux/sched.h 2004-08-19 15:17:52.000000000 -0700 >>+++ linux/include/linux/sched.h 2004-08-19 15:19:05.000000000 -0700 > > [...] > >>@@ -525,6 +527,10 @@ >> >> /* i/o counters(bytes read/written, blocks read/written, #syscalls, waittime */ >> unsigned long rchar, wchar, rblk, wblk, syscr, syscw, bwtime; >>+#if defined(CONFIG_CSA) || defined(CONFIG_CSA_MODULE) >>+ unsigned long csa_rss_mem1, csa_vm_mem1; >>+ clock_t csa_stimexpd; >>+#endif > > > These probably need to be u64, otherwise they might easily overflow within > a view seconds on 32 bit platforms. Will fix it. > > >>--- /dev/null 1970-01-01 00:00:00.000000000 +0000 >>+++ linux/include/linux/acct_eop.h 2004-08-19 18:48:44.000000000 -0700 > > > This should probably be unified with BSD accounting to a general accounting > hook. Do you suggest to merge acct_eop.h into acct.h? It sounds good to me! Thanks! - jay > > > Tim > > > ------------------------------------------------------- > This SF.Net email is sponsored by BEA Weblogic Workshop > FREE Java Enterprise J2EE developer tools! > Get your free copy of BEA WebLogic Workshop 8.1 today. > http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click > _______________________________________________ > Lse-tech mailing list > Lse-tech@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/lse-tech