[PATCH] incorrect logic in release_control

To:	lockmeter@xxxxxxxxxxx
Subject:	[PATCH] incorrect logic in release_control_space()
From:	"Pat O'Rourke" <orourke@xxxxxxxxxxxxxxxxxxxxxxxx>
Date:	Fri, 07 Apr 2000 14:01:25 -0400
Organization:	MIssion Critical Linux
Sender:	owner-lockmeter@xxxxxxxxxxx

I believe the logic in release_control_space is reversed and should
be as follows:

diff -Nru 1.1/kernel/lockmeter.c 1.2/kernel/lockmeter.c
--- 1.1/kernel/lockmeter.c      Thu Apr  6 18:22:50 2000
+++ 1.2/kernel/lockmeter.c      Fri Apr  7 13:54:26 2000
@@ -315,12 +315,12 @@
         */
        int cpu;
 
-       if (!lstat_control.hashtab) {
+       if (lstat_control.hashtab) {
                kfree(lstat_control.hashtab);
                lstat_control.hashtab = NULL;
        }
 
-       if (!lstat_control.dir) {
+       if (lstat_control.dir) {
                kfree(lstat_control.dir);
                lstat_control.dir = NULL;
        }

-- 
Patrick O'Rourke
orourke@xxxxxxxxxxxxxxxxxxxxxxxx

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] incorrect logic in release_control_space(), Pat O'Rourke <=

Previous by Date:	lockmeter 1.2.1 now available, John Hawkes
Next by Date:	io_remap_page_range macro, Pat O'Rourke
Previous by Thread:	lockmeter 1.2.1 now available, John Hawkes
Next by Thread:	io_remap_page_range macro, Pat O'Rourke
Indexes:	[Date] [Thread] [Top] [All Lists]

[PATCH] incorrect logic in release_control_space()