"Vamsi Krishna S ." wrote:
>
> Hi Matt,
>
> I see that you have already checkin my patch. Yes, it is needed
> and is not affected by the config.in changes. The problem was
> that there was no target in the drivers/dump/Makefile that depends
> on dump_rle.o, so it would never have been compiled, irrespective
> of the config settings. The patch I sent previously added a
> top level target dumpdrv.o that includes all the .o files ever
> built in drivers/dump directory (ofcourse based on config settings).
>
> Thanks for checking the patch in yourself :-)
Yes, thanks for sending it along. :) I figured I'd check
it in after validating what you put in -- yes, you're right,
it was necessary (follows the scsidrv.o model).
--Matt
> Regards,
> Vamsi.
>
> On Fri, Oct 26, 2001 at 12:43:08AM -0700, Matt D. Robinson wrote:
> > Before you check it in ... is this fixed with the config.in
> > modification we just made?
> >
> > --Matt
> >
> > "Vamsi Krishna S ." wrote:
> > >
> > > The patch given below should fix it.
> > >
> > > Matt,
> > >
> > > If it is okay with you, I will check this in.
> > >
> > > Vamsi Krishna S.
> > > Linux Technology Center,
> > > IBM Software Lab, Bangalore.
> > > Ph: +91 80 5262355 Extn: 3959
> > > Internet: vamsi@xxxxxxxxxx
> > >
> > > On Wed, Oct 24, 2001 at 01:13:54PM +0530, shaider@xxxxxxxxxx wrote:
> > >
> > > > I'm having some problems with the new lkcd-4.0 patch. The
> > > > dump_rle.c
> > > > file in the linux/drivers/dump directory is not getting compiled when I
> > > > build the kernel. I have configured the kernel with both CONFIG_DUMP
> > > > and
> > > > CONFIG_DUMP_COMPRESS_RLE set to y (and not loadable modules). However,
> > > > the
> > > > dump_rle.o never gets built.
> > > >
> > > <snip>
> <snip>
> --
> Vamsi Krishna S.
> Linux Technology Center,
> IBM Software Lab, Bangalore.
> Ph: +91 80 5262355 Extn: 3959
> Internet: vamsi@xxxxxxxxxx
|