lkcd
[Top] [All Lists]

Re: dump_rle.o doesn't get compiled for new lkcd patch

To: "Matt D. Robinson" <yakker@xxxxxxxxxxxxxx>
Subject: Re: dump_rle.o doesn't get compiled for new lkcd patch
From: "Vamsi Krishna S ." <vamsi@xxxxxxxxxx>
Date: Mon, 29 Oct 2001 13:26:01 +0530
Cc: shaider@xxxxxxxxxx, lkcd <lkcd@xxxxxxxxxxx>
In-reply-to: <3BD9140C.941A1D4F@xxxxxxxxxxxxxx>; from yakker@xxxxxxxxxxxxxx on Fri, Oct 26, 2001 at 12:43:08AM -0700
References: <CA256AEF.00283F7A.00@xxxxxxxxxxxxxxxxxxx> <20011024134905.A22363@xxxxxxxxxx> <3BD9140C.941A1D4F@xxxxxxxxxxxxxx>
Reply-to: vamsi@xxxxxxxxxx
Sender: owner-lkcd@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
Hi Matt,

I see that you have already checkin my patch. Yes, it is needed
and is not affected by the config.in changes. The problem was
that there was no target in the drivers/dump/Makefile that depends
on dump_rle.o, so it would never have been compiled, irrespective
of the config settings. The patch I sent previously added a
top level target dumpdrv.o that includes all the .o files ever
built in drivers/dump directory (ofcourse based on config settings).

Thanks for checking the patch in yourself :-)

Regards,
Vamsi.



On Fri, Oct 26, 2001 at 12:43:08AM -0700, Matt D. Robinson wrote:
> Before you check it in ... is this fixed with the config.in
> modification we just made?
> 
> --Matt
> 
> "Vamsi Krishna S ." wrote:
> > 
> > The patch given below should fix it.
> > 
> > Matt,
> > 
> > If it is okay with you, I will check this in.
> > 
> > Vamsi Krishna S.
> > Linux Technology Center,
> > IBM Software Lab, Bangalore.
> > Ph: +91 80 5262355 Extn: 3959
> > Internet: vamsi@xxxxxxxxxx
> > 
> > On Wed, Oct 24, 2001 at 01:13:54PM +0530, shaider@xxxxxxxxxx wrote:
> > 
> > >      I'm having some problems with the new lkcd-4.0 patch.  The dump_rle.c
> > > file in the linux/drivers/dump directory is not getting compiled when I
> > > build the kernel.  I have configured the kernel with both CONFIG_DUMP and
> > > CONFIG_DUMP_COMPRESS_RLE set to y (and not loadable modules).  However, 
> > > the
> > > dump_rle.o never gets built.
> > >
> > <snip>
<snip>
-- 
Vamsi Krishna S.
Linux Technology Center,
IBM Software Lab, Bangalore.
Ph: +91 80 5262355 Extn: 3959
Internet: vamsi@xxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>