lkcd
[Top] [All Lists]

Re: [patch] further cleanups - done

To: vamsi_krishna@xxxxxxxxxx
Subject: Re: [patch] further cleanups - done
From: "Matt D. Robinson" <yakker@xxxxxxxxxxxxxx>
Date: Wed, 26 Sep 2001 11:37:57 -0700
Cc: lkcd@xxxxxxxxxxx
Organization: Alacritech, Inc.
References: <CA256AD3.003A230F.00@xxxxxxxxxxxxxxxxxxx>
Sender: owner-lkcd@xxxxxxxxxxx
Great, thanks, Vamsi.  I think this closes 4.0.  The new dump
directory for builds is a perfect launching pad.  The only
thing that won't get in is gzip compression.  I had hoped to
have that done, but haven't finished it yet -- it's now a
4.1 thing, which will be in less time than 3.1.4 -> 4.0.

--Matt

vamsi_krishna@xxxxxxxxxx wrote:
> 
> Matt,
> 
> I have checked in the previously mentioned cleanups along with a few more
> _minor_ things:
> - define dump_in_progress and dumping_cpu only if CONFIG_DUMP(_MODULE) is
> defined.
> - move EXPORT_SYMBOL(panic_timeout) and EXPORT_SYMBOL(get_blkfops) inside
> of #ifdef CONFIG_DUMP. They need not be exported when lkcd is not compiled
> in.
> - include dump.h in sched.c and remove one more #if defined(CONFIG_DUMP)
> code block (extern definitions)
> 
> Regards.. Vamsi.
> 
> Vamsi Krishna S.
> Linux Technology Center,
> IBM Software Lab, Bangalore.
> Ph: +91 80 5262355 Extn: 3959
> Internet: vamsi_krishna@xxxxxxxxxx
> 
> "Matt D. Robinson" <yakker@xxxxxxxxxxxxxx> on 09/26/2001 01:59:49 AM
> 
> Please respond to "Matt D. Robinson" <yakker@xxxxxxxxxxxxxx>
> 
> To:   S Vamsikrishna/India/IBM@IBMIN
> cc:   lkcd@xxxxxxxxxxx
> Subject:  Re: [patch] further cleanups
> 
> "Vamsi Krishna S ." wrote:
> >
> > Hello Matt,
> >
> > I would like you to consider applying the following patch to the
> > latest tree. I could checkin these changes if you are okay with them.
> >
> > What we are trying to do here is to:
> > - reduce #ifdef code by coding a static inline dump function
> > - keep all our extern function definitions in include/linux/dump.h
> > - remove the remaining VMDUMP from alpha/ia64
> >
> > Note: you still need to remove arch/alpha/kernel/dump.c from cvs.
> 
> Feel free to check all this in, Vamsi.  Also, I've removed the
> arch/alpha/kernel/dump.c file, since the new file is in
> drivers/dump/dump_alpha.c.
> 
> --Matt
> 
> > --
> > Regards,
> >
> > Vamsi Krishna S.
> > Linux Technology Center,
> > IBM Software Labs, Bangalore.
> >

<Prev in Thread] Current Thread [Next in Thread>