On Sun, 23 Sep 2001, Bharata B Rao wrote:
|>On Sat, Sep 22, 2001 at 11:55:35PM -0700, Matt D. Robinson wrote:
|>> On Sun, 23 Sep 2001, Bharata B Rao wrote:
|>> |>On Fri, Sep 21, 2001 at 11:49:43AM -0700, Monty Vanderbilt wrote:
|>> |>Just checked out this file from cvs. This is causing "duplicate case
value"
|>> |>error for DIOSDUMPDEV, DIOSDUMPLEVEL, DIOSDUMPFLAGS and DIOSDUMPCOMPRESS.
|>> |>Did you not get this error ?
|>>
|>> Which compiler are you using, Bharata? I think we have an issue
|>> of compiler differences.
|>>
|>Matt,
|>
|>I am using gcc version egcs-2.91.66, looks a bit old. Time to upgrade.
|>But any way, 2 cases for the same switch value... isn't this an error ?
|>I am finding this as an error even in egcs-2.96 (RH 7.1) also(just
|>tried a sample program, not the dump code).
No, it should fall through -- if you don't specify the break, it
should fall through to the next case. Either way, I just fixed it
in the CVS tree so that we do it under each case, so no compiler
complains about it. It's easy enough to avoid the compilation
case.
Bharata, I am checking in all of your fixes, with some changes.
You might want to CVS update and get all the latest stuff and let
me know if I missed something (note, I'll compile it after checking
it in, for this one exception). This includes moving volatile int
dumping_cpu and dump_in_progress to kernel/panic.c, and I've also
now set it up to pass a "stage" unsigned into into both silence
and resume (in case any architecture wants to do global + arch
specific silencing or resuming in various stages.)
|>Bharata
--Matt
Checking in a ton of modifications. This may not build as of yet,
I'm still walking through and adding Bharata's stuff, modifying
Monty's stuff, and doing some general clean-up.
CVS: ----------------------------------------------------------------------
CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
CVS:
CVS: Committing in .
CVS:
CVS: Modified Files:
CVS: 2.4/arch/i386/kernel/dump.c 2.4/arch/i386/kernel/traps.c
CVS: 2.4/drivers/block/dump.c 2.4/drivers/block/dump_gzip.c
CVS: 2.4/drivers/block/dump_rle.c 2.4/include/asm-alpha/dump.h
CVS: 2.4/include/asm-i386/dump.h 2.4/include/asm-ia64/dump.h
CVS: 2.4/include/linux/dump.h 2.4/init/kerntypes.c
CVS: 2.4/kernel/panic.c 2.4/kernel/sched.c
CVS: Added Files:
CVS: 2.4/arch/alpha/kernel/dump.c 2.4/arch/ia64/kernel/dump.c
CVS: Removed Files:
CVS: 2.4/arch/alpha/kernel/vmdump.c 2.4/arch/i386/kernel/vmdump.c
CVS: 2.4/arch/ia64/kernel/vmdump.c 2.4/drivers/block/vmdump.c
CVS: 2.4/include/asm-alpha/vmdump.h 2.4/include/asm-i386/vmdump.h
CVS: 2.4/include/asm-ia64/vmdump.h 2.4/include/linux/vmdump.h
CVS: ----------------------------------------------------------------------
|