lkcd
[Top] [All Lists]

Re: issues with dump compiled as a module

To: "Matt D. Robinson" <yakker@xxxxxxxxxxxxxx>
Subject: Re: issues with dump compiled as a module
From: Keith Owens <kaos@xxxxxxxxxx>
Date: Thu, 13 Sep 2001 08:15:40 +1000
Cc: vamsi_krishna@xxxxxxxxxx, lkcd@xxxxxxxxxxx
In-reply-to: Your message of "Wed, 12 Sep 2001 10:39:39 MST." <3B9F9DDB.6D3C9048@xxxxxxxxxxxxxx>
Sender: owner-lkcd@xxxxxxxxxxx
On Wed, 12 Sep 2001 10:39:39 -0700, 
"Matt D. Robinson" <yakker@xxxxxxxxxxxxxx> wrote:
>None at this time.  Go ahead and move it.  BTW, if there are variables
>that will remain static at all times (such as dump_function_ptr), make
>sure they are declared in one file.  If this means moving dump_function_ptr
>to init/main.c and declaring everything there, or moving them all to
>kernel/panic.c, that's fine.

It is better to put dump related static variables in their own file
with a globally unique name and export the variables from that file.
Patching an existing file is a bad idea, it results in overlapping
patches for different add on components.  Separate files makes for a
cleaner patch and a cleaner build.


<Prev in Thread] Current Thread [Next in Thread>