lkcd
[Top] [All Lists]

Re: Minor bug in lcrash (kl_savedump.c)

To: Tony Dziedzic <Tony.Dziedzic@xxxxxxxxxxxx>
Subject: Re: Minor bug in lcrash (kl_savedump.c)
From: "Matt D. Robinson" <yakker@xxxxxxxxxxxxxx>
Date: Fri, 06 Jul 2001 14:57:20 -0700
Cc: "'lkcd@xxxxxxxxxxx'" <lkcd@xxxxxxxxxxx>
Organization: Alacritech, Inc.
References: <88D2015B3AF7BF4B91272EC25A9FE097691CA0@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: owner-lkcd@xxxxxxxxxxx
> Tony Dziedzic wrote:
> 
> We ran into an interesting error with lcrash when saving a crash dump.
> While copying the crash dump lcrash ran into an error and displayed the
> message "Error: dump flags in dumpdev page index invalid".  On each
> subsequent reboot lcrash would again attempt to copy the crash dump, and
> would also encounter the same error.  Each attempt would write some number
> of blocks and increment the bounds file contents, resulting in a continual
> series of less-than-useful crash dump files.
> 
> In this particular error __kl_dump_retrieve returns a status of 0 (line 247
> of kl_savedump.c), which prevents the caller (kl_dump_retrieve) from erasing
> the dump.  Every other failure case returns a status of 1, which seems more
> appropriate.  It's probably advisable to modify this line to return a status
> of 1 to be consistent and to allow the crash dump to be erased.

Corrected.  If you're using the CVS tree, grab the latest copy from
there.  Thanks, Tony. :)

--Matt

> FYI,
> Tony Dziedzic
> Storigen Systems

<Prev in Thread] Current Thread [Next in Thread>