On Fri, 24 Dec 1999, Brian Hall wrote:
|>That fixed the vmdump.h problem. Now it actually compiles, with warnings
|>(implied casts). I notice that dh_esp and dh_eip are 32 bits wide; they will
|>need to be 64 bit for Alpha; and the other uint32_t(s) in vmdump.c
|>(__dump_execute) will also need to be uint64_t(s), and the changes
|>Now, should I go ahead and change dump_header_t to (choose one):
|>1) make dh_esp,etc uint64_t(s) in the header;
I'd make them whatever the dh_esp and dh_eip equivalents are in the
pt_regs structure for SP and PC.
|>2) add fields specifically for alpha;
|>3) do #1 and change them to dh_sp and dh_pc while I'm at it?
Do the name change while you're at it. I'll change things in our patch.
|>While it will compile, it fails to link because alpha/vmdump.o can't find
|>dump_page_buf. Here are the errors:
|>arch/alpha/kernel/kernel.o: In function `__dump_write_header':
|>vmdump.c(.text+0xb658): undefined reference to `dump_page_buf'
|>arch/alpha/kernel/kernel.o: In function `__dump_execute':
|>vmdump.c(.text+0xb85c): undefined reference to `dump_page_buf'
|>vmdump.c(.text+0xb934): undefined reference to `dump_page_buf'
|>vmdump.c(.text+0xb968): undefined reference to `dump_page_buf'
|>vmdump.c(.text+0xb97c): undefined reference to `dump_page_buf'
|>arch/alpha/kernel/kernel.o(.text+0xb9bc):vmdump.c: more undefined references
|>Attached is my current version of arch/alpha/kernel/vmdump.c.
Hmmm ... That'd be because for whatever reason, it's not showing up
in your kernel/vmdump.c file. It's defined there for the main build.
Are you sure you're compiling with CONFIG_VMDUMP defined everywhere?
Change the header for vmdump.c in the kernel directory, to the same
thing for the <linux/vmdump.h> file. That should eliminate your
The real question is, why aren't you getting your CONFIG_VMDUMP stuff
defined when you build?
|>Brian Hall <brianw.hall@xxxxxxxxxx>