linux-origin
[Top] [All Lists]

Re: CVS Update@xxxxxxxxxxx: linux

To: Andreas Jaeger <aj@xxxxxxx>
Subject: Re: CVS Update@xxxxxxxxxxx: linux
From: Ralf Baechle <ralf@xxxxxxxxxxx>
Date: Sun, 25 Jun 2000 17:47:20 +0200
Cc: "Maciej W. Rozycki" <macro@xxxxxxxxxxxxx>, linux-origin@xxxxxxxxxxx
In-reply-to: <u8zooank6w.fsf@xxxxxxxxxxxxxxxxxxxxxx>; from aj@xxxxxxx on Sun, Jun 25, 2000 at 12:12:23PM +0200
References: <200006201649.JAA65939@xxxxxxxxxxxxxxxxxxx> <u8zooank6w.fsf@xxxxxxxxxxxxxxxxxxxxxx>
Sender: owner-linux-origin@xxxxxxxxxxx
On Sun, Jun 25, 2000 at 12:12:23PM +0200, Andreas Jaeger wrote:

> this change is wrong (as also pointed out by Maciej).  You removed the
> following fields from struct stat64:
> 
>       char            st_fstype[16];  /* Filesystem type name */
>       long            st_pad4[8];
>       /* Linux specific fields */
>       unsigned int    st_flags;
>       unsigned int    st_gen;
> 
> But if we compile user level programs with -D_FILE_OFFSET_BITS=64,
> struct stat is renamed to struct stat64 - making st_fstype, st_flags
> and st_gen mandatory for struct stat64.
> 
> Could you please either add st_fstype, st_flags and st_gen to struct
> stat64 - or remove them from both structures?

Do you know of any users for those fields?  I don't and we don't even
properly initialize them, so I'd prefer to remove them - before some
autoconf scripts detects and and uses them.  My prefered solution would
be to remove those fields, too.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>