linux-origin
[Top] [All Lists]

Re: CVS Update@xxxxxxxxxxx: linux

To: ralf@xxxxxxxxxxx (Ralf Baechle), linux-origin@xxxxxxxxxxx
Subject: Re: CVS Update@xxxxxxxxxxx: linux
From: Andreas Jaeger <aj@xxxxxxx>
Date: 25 Jun 2000 12:12:23 +0200
In-reply-to: kanoj@xxxxxxxxxxxxxxxxxxx's message of "Tue, 20 Jun 2000 09:49:32 -0700 (PDT)"
References: <200006201649.JAA65939@xxxxxxxxxxxxxxxxxxx>
Sender: owner-linux-origin@xxxxxxxxxxx
User-agent: Gnus/5.0807 (Gnus v5.8.7) XEmacs/21.1 (Capitol Reef)
> 
> CVSROOT:      /home/pub/cvs
> Module name:  linux
> Changes by:   ralf@xxxxxxxxxxx        00/06/20 08:44:53
> 
> Modified files:
>       arch/mips64/kernel: linux32.c scall_o32.S 
>       drivers/char   : Makefile 
>       include/asm-mips: stat.h 
>       include/asm-mips64: stat.h 
> 
> Log message:
>       Fix struct stat64 in the 32-bit kernel and struct stat in the 64-bit
>       kernel to match each other and the the glibc definition.  The glibc
>       part of this change has been sent to Andreas.
> 

Ralf, 

this change is wrong (as also pointed out by Maciej).  You removed the
following fields from struct stat64:

        char            st_fstype[16];  /* Filesystem type name */
        long            st_pad4[8];
        /* Linux specific fields */
        unsigned int    st_flags;
        unsigned int    st_gen;

But if we compile user level programs with -D_FILE_OFFSET_BITS=64,
struct stat is renamed to struct stat64 - making st_fstype, st_flags
and st_gen mandatory for struct stat64.

Could you please either add st_fstype, st_flags and st_gen to struct
stat64 - or remove them from both structures?

Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@xxxxxxx
   private aj@xxxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>