From: "Bill Hartner" <bhartner@xxxxxxxxxx>
To: <kernprof@xxxxxxxxxxx>
Sent: Saturday, January 27, 2001 4:36 PM
Subject: profile patch on 2.4.0
> Hello,
>
> I was successful in applying the profile patch on
> 2.4.0 SMP (i386) and was able to use it to collect
> an acg. [BTW, great performance analysis tool].
>
> So I created another build tree for 2.4.0 and turned off
> SMP support. I turned on APIC support. As before, I also
> turned on "char devices/kernel profiling support",
> "hacking/frame pointers" and "hacking/mcount".
>
> I get a build failure in devices/char/profile.c.
> I needed to add "#include asm/smp.h" to remove the
> build failure.
>
> [I have not tried the kernel yet, so I do not know if it
> functions correctly].
>
> Bug in the patch or did I not select the correct options ?
I think a better patch is a more direct one to include/linux/smp.h,
pulling the #include of <asm/smp.h> out of it's CONFIG_SMP-only hiding
place.
diff -X /build4/hawkes/Build/ignore.dirs -Naur
linux-2.4.0/include/linux/smp.h linux-2.4.0-profile/include/linux/smp.h
--- linux-2.4.0/include/linux/smp.h Tue Jan 9 14:35:06 2001
+++ linux-2.4.0-profile/include/linux/smp.h Mon Jan 29 11:57:15 2001
@@ -7,11 +7,11 @@
*/
#include <linux/config.h>
+#include <asm/smp.h>
#ifdef CONFIG_SMP
#include <linux/kernel.h>
-#include <asm/smp.h>
/*
* main cross-CPU interfaces, handles INIT, TLB flush, STOP, etc.
John Hawkes
|