| To: | jason.wessel@xxxxxxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH 15/37] sparc,sunzilog: Add console polling support for sunzilog serial driver |
| From: | David Miller <davem@xxxxxxxxxxxxx> |
| Date: | Wed, 23 Dec 2009 13:50:28 -0800 (PST) |
| Cc: | linux-kernel@xxxxxxxxxxxxxxx, kgdb-bugreport@xxxxxxxxxxxxxxxxxxxxx, kdb@xxxxxxxxxxx, mingo@xxxxxxx |
| In-reply-to: | <1261603190-5036-16-git-send-email-jason.wessel@xxxxxxxxxxxxx> |
| References: | <1261603190-5036-14-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-15-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-16-git-send-email-jason.wessel@xxxxxxxxxxxxx> |
From: Jason Wessel <jason.wessel@xxxxxxxxxxxxx>
Date: Wed, 23 Dec 2009 15:19:28 -0600
> +static void sunzilog_put_poll_char(struct uart_port *port,
> + unsigned char ch)
> +{
> + struct uart_sunzilog_port *up = (struct uart_sunzilog_port *)port;
> +
> + sunzilog_putchar(&up->port, ch);
> + udelay(2);
> +
> +}
> +#endif /* CONFIG_CONSOLE_POLL */
Just curious, what is the udelay() for?
> static struct uart_ops sunzilog_pops = {
> .tx_empty = sunzilog_tx_empty,
> .set_mctrl = sunzilog_set_mctrl,
> @@ -1013,6 +1061,10 @@ static struct uart_ops sunzilog_pops = {
> .request_port = sunzilog_request_port,
> .config_port = sunzilog_config_port,
> .verify_port = sunzilog_verify_port,
> +#ifdef CONFIG_CONSOLE_POLL
> + .poll_get_char = sunzilog_get_poll_char,
> + .poll_put_char = sunzilog_put_poll_char,
> +#endif
> };
Please make the indentation consistent with the rest of those in
this structure.
|
| Previous by Date: | Re: [PATCH 07/37] kgdb,sparc: Add in kgdb_arch_set_pc for sparc, David Miller |
|---|---|
| Next by Date: | Re: [PATCH 15/37] sparc,sunzilog: Add console polling support for sunzilog serial driver, Jason Wessel |
| Previous by Thread: | Re: [PATCH 37/37] kgdbts,sh: Add in breakpoint pc offset for superh, Paul Mundt |
| Next by Thread: | Re: [PATCH 15/37] sparc,sunzilog: Add console polling support for sunzilog serial driver, Jason Wessel |
| Indexes: | [Date] [Thread] [Top] [All Lists] |