kdb
[Top] [All Lists]

[PATCH 31/37] kgdb: add ops arg to kgdb console active & restore hooks

To: linux-kernel@xxxxxxxxxxxxxxx
Subject: [PATCH 31/37] kgdb: add ops arg to kgdb console active & restore hooks
From: Jason Wessel <jason.wessel@xxxxxxxxxxxxx>
Date: Wed, 23 Dec 2009 15:19:44 -0600
Cc: kgdb-bugreport@xxxxxxxxxxxxxxxxxxxxx, kdb@xxxxxxxxxxx, mingo@xxxxxxx, Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>, Jason Wessel <jason.wessel@xxxxxxxxxxxxx>
In-reply-to: <1261603190-5036-31-git-send-email-jason.wessel@xxxxxxxxxxxxx>
References: <1261603190-5036-1-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-2-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-3-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-4-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-5-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-6-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-7-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-8-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-9-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-10-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-11-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-12-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-13-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-14-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-15-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-16-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-17-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-18-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-19-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-20-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-21-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-22-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-23-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-24-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-25-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-26-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-27-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-28-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-29-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-30-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-31-git-send-email-jason.wessel@xxxxxxxxxxxxx>
From: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>

This allows callers to store the ops structure in a parent device structure.

Signed-off-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
Signed-off-by: Jason Wessel <jason.wessel@xxxxxxxxxxxxx>
---
 drivers/serial/kgdboc.c |    4 ++--
 include/linux/kgdb.h    |    6 ++++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/serial/kgdboc.c b/drivers/serial/kgdboc.c
index 34b0306..93b18f9 100644
--- a/drivers/serial/kgdboc.c
+++ b/drivers/serial/kgdboc.c
@@ -208,7 +208,7 @@ static void kgdboc_pre_exp_handler(void)
 {
        if (kgdboc_use_kms && dbg_kms_console_core &&
            dbg_kms_console_core->activate_console)
-               if (dbg_kms_console_core->activate_console())
+               if 
(dbg_kms_console_core->activate_console(dbg_kms_console_core))
                        printk(KERN_ERR "kgdboc: kernel mode switch error\n");
 
        /* Increment the module count when the debugger is active */
@@ -223,7 +223,7 @@ static void kgdboc_post_exp_handler(void)
                module_put(THIS_MODULE);
        if (kgdboc_use_kms && dbg_kms_console_core &&
            dbg_kms_console_core->restore_console)
-               if (dbg_kms_console_core->restore_console())
+               if (dbg_kms_console_core->restore_console(dbg_kms_console_core))
                        printk(KERN_ERR "kgdboc: graphics restore failed\n");
 #ifdef CONFIG_KDB_KEYBOARD
        /* If using the kdb keyboard driver release all the keys. */
diff --git a/include/linux/kgdb.h b/include/linux/kgdb.h
index 5ce1158..5ba827b 100644
--- a/include/linux/kgdb.h
+++ b/include/linux/kgdb.h
@@ -309,10 +309,12 @@ extern atomic_t                   kgdb_active;
 extern void kgdb_schedule_breakpoint(void);
 
 struct dbg_kms_console_ops {
-       int (*activate_console) (void);
-       int (*restore_console) (void);
+       int (*activate_console) (struct dbg_kms_console_ops *ops);
+       int (*restore_console) (struct dbg_kms_console_ops *ops);
 };
 extern struct dbg_kms_console_ops *dbg_kms_console_core;
+extern int dbg_kms_console_ops_register(struct dbg_kms_console_ops *ops);
+extern int dbg_kms_console_ops_unregister(struct dbg_kms_console_ops *ops);
 
 #ifdef CONFIG_KGDB_SERIAL_CONSOLE
 extern void __init early_kgdboc_init(void);
-- 
1.6.4.rc1

<Prev in Thread] Current Thread [Next in Thread>