kdb
[Top] [All Lists]

Re: [PATCH] Add support for USB Keyboard attached to UHCI

To: "Randy.Dunlap" <randy.dunlap@xxxxxxxxxxx>
Subject: Re: [PATCH] Add support for USB Keyboard attached to UHCI
From: Jay Lan <jlan@xxxxxxx>
Date: Fri, 30 Nov 2007 09:37:14 -0800
Cc: Aaron Young <ayoung@xxxxxxxxxxxxxxxxxxxx>, Konstantin Baydarov <kbaidarov@xxxxxxxxxxxxx>, kdb@xxxxxxxxxxx
In-reply-to: <20071130091912.e89d42ac.randy.dunlap@xxxxxxxxxxx>
References: <200711301552.lAUFqxdA9993872@xxxxxxxxxxxxxxxxxx> <200711301700.lAUH0o8l10107350@xxxxxxxxxxxxxxxxxx> <20071130091912.e89d42ac.randy.dunlap@xxxxxxxxxxx>
Sender: kdb-bounce@xxxxxxxxxxx
User-agent: Thunderbird 1.5 (X11/20060317)
Randy.Dunlap wrote:
> On Fri, 30 Nov 2007 09:00:50 -0800 (PST) Aaron Young wrote:
> 
>>
>>  Another thing, I think we need to update these files:
>>
>> arch/ia64/Kconfig.debug
>> arch/x86/Kconfig.debug
>>
>>  to change this line:
>> depends on KDB && USB_OHCI_HCD
>>
>>  to:
>>
>> depends on KDB && USB_OHCI_HCD && USB_UHCI_HCD && USB_EHCI_HCD
> 
> I don't have the complete patch in front of me, but why would
> all 3 of those HCDs be needed?  I would expect it to be more like
> 
>   depends on KDB && (USB_OHCI_HCD || USB_UHCI_HCD)

Yep, should be a || instead. So, a new depend line will be:
    depends on KDB && (USB_OHCI_HCD || USB_UHCI_HCD || USB_EHCI_HCD)

> 
> and even omit the EHCI_HCD part since it is only for high-speed
> devices and I've never seen a keyboard that is a high-speed USB
> device.

If you connect through a USB 2.0 hub, you will need EHCI_HCD.

Thanks,
 - jay

> 
> (or maybe I'm way out of context...)
> 
>>  Jay?
> 
> 
> ---
> ~Randy

---------------------------
Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.
<Prev in Thread] Current Thread [Next in Thread>