kdb
[Top] [All Lists]

Re: [PATCH] Add support for USB Keyboard attached to UHCI

To: Aaron Young <ayoung@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] Add support for USB Keyboard attached to UHCI
From: Konstantin Baydarov <kbaidarov@xxxxxxxxxxxxx>
Date: Mon, 5 Nov 2007 21:17:16 +0300
Cc: jlan@xxxxxxx (Jay Lan), kdb@xxxxxxxxxxx, ayoung@xxxxxxxxxxxxxxxxxxxx (Aaron Young)
In-reply-to: <200711051724.lA5HOHMV4005128@xxxxxxxxxxxxxxxxxx>
References: <20071105193911.303cc50b@medved> <200711051724.lA5HOHMV4005128@xxxxxxxxxxxxxxxxxx>
Sender: kdb-bounce@xxxxxxxxxxx
On Mon, 5 Nov 2007 09:24:17 -0800 (PST)
Aaron Young <ayoung@xxxxxxxxxxxxxxxxxxxx> wrote:

>   If a USB keyboard (a "low" speed device) is connected directly to
>   a EHCI port, the "companion" controller (i.e. uhci_hcd or ohc_hcd
> driver) will take control of it (and work fine in kdb). However, if
>   the keyboard is connected through a USB2.0
>   hub, the ehci_hcd driver will take control of it. Therefore, the
> problem is that kdb will call a ohci or uhci driver "poll" function
> when the ehci driver is managing the keyboard. This causes kdb itself
> to crash on ohci/ehci based controllers... not sure about uhci, but
> it doesn't seem like it would work right. 
> 
>   I am working on a fix for this problem and also to provide support 
>   for multiple USB keyboards - since right now kdb only makes use of
> a single USB keyboard. It would be better if kdb would "multiplex"
> the input of all connected USB keyboards.
> 
>   So, if any of your code below makes any of the assumptions I mention
>   above (such as there is only one kdb USB keyboard used for input or
>   the keyboard is using either the ohci_hcd or uhci_hcd driver and
> not ehci_hcd), it will have to be changed/incorporated to work with
> my new code...
> 
>   I hope to have this new code within a couple of weeks...
> 
>   -Aaron Young
>   

  Yes my code makes assumption that there is only one Kbd and it's
attached to OHCI/UHCI so definitely should be changed/incorporated.
Aaron, what about UHCI part of code, can you review this?
---------------------------
Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.
<Prev in Thread] Current Thread [Next in Thread>