kdb
[Top] [All Lists]

Re: patch to fix a few bugs for embedded platforms in kdb

To: sdake@xxxxxxxxxx
Subject: Re: patch to fix a few bugs for embedded platforms in kdb
From: Keith Owens <kaos@xxxxxxx>
Date: Wed, 05 Oct 2005 15:56:34 +1000
Cc: kdb@xxxxxxxxxxx
In-reply-to: Your message of "Wed, 31 Aug 2005 13:20:44 MST." <1125519644.9169.16.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: kdb-bounce@xxxxxxxxxxx
On Wed, 31 Aug 2005 13:20:44 -0700, 
Steven Dake <sdake@xxxxxxxxxx> wrote:
>  This patch fixes two things. 1. The Motorola ATCA7101 has no i8042
>  keyboard controller. Thus when the local arch stuff tries to probe
>  the keyboard it hangs. 2. The 7101 uses the serial controller that's
>  PCI instead of the chipset one. Therefore we need to re-init KDB when
>  we pick up the PCI serial as console.
>Index: linux-2.6.10/drivers/serial/8250.c
>===================================================================
>--- linux-2.6.10.orig/drivers/serial/8250.c
>+++ linux-2.6.10/drivers/serial/8250.c
>@@ -2198,10 +2198,19 @@ static int __init serial8250_console_ini
> }
> console_initcall(serial8250_console_init);
> 
>+#ifdef CONFIG_KDB
>+extern void kdb_io_init(void);
>+#endif
>+
> static int __init serial8250_late_console_init(void)
> {
>-      if (!(serial8250_console.flags & CON_ENABLED))
>+      if (!(serial8250_console.flags & CON_ENABLED)) {
>               register_console(&serial8250_console);
>+      }
>+#ifdef CONFIG_KDB
>+      /* pick up any PCI serial controllers */
>+      kdb_io_init();
>+#endif
>       return 0;
> }
> late_initcall(serial8250_late_console_init);

This patch is not against a current kernel.  serial8250_late_console_init() was
removed between 2.6.11-rc5 and 2.6.12, there is no longer a late_initcall in
serial/8250.c.  I do not have the hardware to test this fix, could you do a
patch against 2.6.14-rc* please?

---------------------------
Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.
<Prev in Thread] Current Thread [Next in Thread>
  • Re: patch to fix a few bugs for embedded platforms in kdb, Keith Owens <=