On Wed, Mar 03, 2004 at 09:47:50AM +1100, Keith Owens wrote:
>
> One of the changes on my list for kdb v4.4 is to change kdb_serial_str
> to <escape>KDB. Distributions/users can patch it to whatever they want.
If there's no precedent, then I nominate "startKDB", so that it
behaves as if there were a plain-old command called startKDB.
Some minor nits while I work on this:
-- some places you use spaces instead of tabs in the code, which
results in funky indentation if tabstops is set to anything
other than 8 (set ts=3 in vi, I think)
-- drivers/serial/8250.c: In function `serial8250_console_setup':
drivers/serial/8250.c:2050: warning: cast from pointer to integer of
different size
which works out to:
kdb_serial.iobase = (int)(port->membase);
as compared to
extern struct kdb_serial {
int io_type;
unsigned long iobase;
unsigned long ioreg_shift;
} kdb_serial;
for me, ints are 32-bit, longs are 64-bit.
I've compiled, it boots, testing ...
--linas
---------------------------
Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.
|