kdb
[Top] [All Lists]

Re: kdb ps patch

To: Keith Owens <kaos@xxxxxxx>
Subject: Re: kdb ps patch
From: linas@xxxxxxxxxxxxxx
Date: Fri, 18 Jul 2003 12:38:54 -0500
Cc: kdb@xxxxxxxxxxx, olh@xxxxxxx, linuxppc64-dev@xxxxxxxxxxxxxxxxxx
In-reply-to: <3287.1058492998@xxxxxxxxxxxxxxxxxxxxxx>; from kaos@xxxxxxx on Fri, Jul 18, 2003 at 11:49:58AM +1000
References: <20030717161805.A48376@xxxxxxxxxxxxxxxxxxxx> <3287.1058492998@xxxxxxxxxxxxxxxxxxxxxx>
Sender: kdb-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5.1i
Hi,

OK, thanks.  I'll see what we can fix at this end.

BTW, KDB is great!   It really makes debugging (which is all that I do 
now) a whole lot easier. I dread having to debug a crash on a system 
that doesn't have KDB on it.

--linas

On Fri, Jul 18, 2003 at 11:49:58AM +1000, Keith Owens wrote:
> On Thu, 17 Jul 2003 16:18:05 -0500, 
> linas@xxxxxxxxxxxxxx wrote:
> >Anyway, here's a patch, it allows running tasks to be listed
> >on 64-but machines.
> >
> >Index: kdbsupport.c
> >===================================================================
> >RCS file: /home/linas/cvsroot/linux24/kdb/Attic/kdbsupport.c,v
> >retrieving revision 1.1.2.1
> >diff -u -r1.1.2.1 kdbsupport.c
> >--- kdbsupport.c        15 Jul 2003 18:43:51 -0000      1.1.2.1
> >+++ kdbsupport.c        17 Jul 2003 19:03:30 -0000
> >@@ -672,9 +672,9 @@
> >  *     none.
> >  */
> >  
> >-#define UNRUNNABLE     (1 << (8*sizeof(unsigned long) - 1))    /* 
> >unrunnable is < 0 */
> >-#define RUNNING                (1 << (8*sizeof(unsigned long) - 2))
> >-#define TRACED         (1 << (8*sizeof(unsigned long) - 3))
> >+#define UNRUNNABLE     (1UL << (8*sizeof(unsigned long) - 1))  /* 
> >unrunnable is < 0 */
> >+#define RUNNING                (1UL << (8*sizeof(unsigned long) - 2))
> >+#define TRACED         (1UL << (8*sizeof(unsigned long) - 3))
> >  
> > unsigned long
> > kdb_task_state_string(int argc, const char **argv, const char **envp)
> 
> You must be running off an old version of kdb.  That was fixed around
> October 2002, in kdb v2.4.
> 

<Prev in Thread] Current Thread [Next in Thread>