There is a bug in the dnotify patch that sometimes made it leak monitors
on files. This happens when a file with the same device/inode shows up
in two directories (either because of a hardlink, or because the file
was moved and we read the new file before forgetting the old one).
Here is a new version of the patch, against fam 2.6.10, that fixes this
issue. I've added it to the redhat rpm, and i've done some minimal
testing. It seems to work.
An easy way to reproduce the bug is:
mkdir /tmp/x
mkdir /tmp/y
echo "test" > /tmp/x/file1
ln /tmp/x/file1 /tmp/y/file2
(fam_test -f /tmp/y/file2& fam_test -f /tmp/x/file1)
<Ctrl-C>
Now fam will have an fd open, but no clients. (fam_test is built from
test/test.c++ in the fam sources)
(
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
alexl@xxxxxxxxxx alla@xxxxxxxxxxxxxx
He's a benighted Catholic waffle chef with nothing left to lose. She's a
transdimensional bisexual bounty hunter with a knack for trouble. They fight
crime!
fam-2.6.10-dnotify.patch
Description: Text Data
|