On Mon, Oct 09, 2000 at 06:38:29PM -0700, Rusty Ballinger wrote:
> > So, it would seem that the correct thing to do would be to add an
> > IMON_DELETE event inside vfs_rmdir for the directory that is being deleted.
> > When I tried this out, the first case worked the same, and on the second
> > case I got a deleted and changed event on '/tmp/foo' (in that order). If
> > there are no objections I'll go ahead and add this to a future patch.
>
> That sounds good to me, especially since it works. (I would be curious to
> see whether making vfs_rmdir send the IMON_CHANGED event for the removed
> directory instead of its parent would also make fam work correctly, but that
> is arguably wrong, and your way isn't.)
Ok. It does seem correct that a IMON_CHANGED event gets sent for the parent
directory, which was changed, and another IMON_DELETE event is sent for the
child, which was deleted. This also seems to be the problem with the other
two know bugs -- in each case imon was only generating an event for the
parent directory, which isn't monitored, and the event gets ignored. I should
do a little more testing to make sure I didn't break something else and
then I'll put together an imon-0.0.2 patch for kernels 2.2 and 2.4.
> > Another question: Is there a document available which has a comprehensive
> > list of "when X occurs, imon reports Y" which I haven't stumbled across? It
> > would make knowing what to do in this kind of situation much easier.
>
> Yeah, not that I know of.
I guess I'll just go off of the description of the events on the Fam manpage
and try to back out what Fam expects from imon to get there.
Brian
--
Source code, list archive, and docs: http://oss.sgi.com/projects/fam/
To unsubscribe: echo unsubscribe fam | mail majordomo@xxxxxxxxxxx
|