Re: [PATCH] Graceful failure in devfs

devfs

Re: [PATCH] Graceful failure in devfs_remove() in 2.5.x

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH] Graceful failure in devfs_remove() in 2.5.x
From:	Pavel Roskin <proski@xxxxxxx>
Date:	Wed, 28 May 2003 12:00:20 -0400 (EDT)
Cc:	devfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to:	<20030528104603.A27503@xxxxxxxxxxxxx>
References:	<Pine.LNX.4.55.0305271105110.1412@xxxxxxxxxxxxxxxxxxxxxxxx> <20030528104603.A27503@xxxxxxxxxxxxx>
Sender:	devfs-bounce@xxxxxxxxxxx

On Wed, 28 May 2003, Christoph Hellwig wrote:

> On Tue, May 27, 2003 at 11:29:53AM -0400, Pavel Roskin wrote:
> > This patch makes devfs_remove() print an error to the kernel log and
> > continue.  PRINTK is defined in fs/devfs/base.c to report errors in the
> > cases like this one:
>
> Patch looks okay _except_ for use of this gross macro.  Just
> ise plain printk instead.

I always try to follow the existing code style, but if you want me to make
an exception, here it is.  Fixed patch is attached.

-- 
Regards,
Pavel Roskin

devfs-rm.diff
Description: Text document

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] Graceful failure in devfs_remove() in 2.5.x, Pavel Roskin Re: [PATCH] Graceful failure in devfs_remove() in 2.5.x, Christoph Hellwig Re: [PATCH] Graceful failure in devfs_remove() in 2.5.x, Pavel Roskin <=

Previous by Date:	Re: [PATCH] Graceful failure in devfs_remove() in 2.5.x, Christoph Hellwig
Next by Date:	ide-floppy doesn't register with devfs if no media, Pavel Roskin
Previous by Thread:	Re: [PATCH] Graceful failure in devfs_remove() in 2.5.x, Christoph Hellwig
Next by Thread:	ide-floppy doesn't register with devfs if no media, Pavel Roskin
Indexes:	[Date] [Thread] [Top] [All Lists]