devfs
[Top] [All Lists]

Re: [PATCH] Use mksymlink in the sample devfsd.conf

To: Pavel Roskin <proski@xxxxxxx>
Subject: Re: [PATCH] Use mksymlink in the sample devfsd.conf
From: Richard Gooch <rgooch@xxxxxxxxxxxxxxx>
Date: Thu, 20 Dec 2001 17:18:47 -0700
Cc: devfs@xxxxxxxxxxx
In-reply-to: <Pine.LNX.4.43.0112201902490.1652-100000@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <Pine.LNX.4.43.0112201902490.1652-100000@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: owner-devfs@xxxxxxxxxxx
Pavel Roskin writes:
> Hello!
> 
> The file devfsd.conf included with devfsd-1.3.19 used symlink() whereas 
> the manual recommends using mksymlink().  Here's the patch:
> 
> =========================
> --- devfsd.conf
> +++ devfsd.conf
> @@ -38,6 +38,6 @@
>  # Uncomment this if you want the old /dev/cdrom symlink
>  # (e.g. those specifying CD-ROM type, mouse port, modem port etc)
>  #
> -#LOOKUP              ^cdrom$         CFUNCTION GLOBAL symlink cdroms/cdrom0 
> $devpath
> -#REGISTER    ^cdrom/cdrom0$  CFUNCTION GLOBAL symlink cdroms/cdrom0 cdrom
> +#LOOKUP              ^cdrom$         CFUNCTION GLOBAL mksymlink 
> cdroms/cdrom0 $devpath
> +#REGISTER    ^cdrom/cdrom0$  CFUNCTION GLOBAL mksymlink cdroms/cdrom0 cdrom
>  #UNREGISTER  ^cdrom/cdrom0$  CFUNCTION GLOBAL unlink cdrom
> =========================

Already fixed this in devfsd-v1.3.20 (released 20-NOV).

> By the way, CFUNCTION doesn't work if devfsd is statically linked.  This
> may be a serious limitation for some embedded configurations.  I also can
> imagine that some sysadmins would want to link some basic utilities
> statically to survive possible libc problems.
> 
> What if we implement mksymlink and unlink as separate actions, like COPY?  
> These are very basic operations that most people need.

I'm reluctant to do this, as it adds more code to devfsd. And the main
reason I want to keep devfsd small is for embedded systems. I think an
embedded system is better off including a shared C library. It will
save space overall (at least if you use a decent, lightweight C
library).

                                Regards,

                                        Richard....
Permanent: rgooch@xxxxxxxxxxxxx
Current:   rgooch@xxxxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>