Re: [PATCH] devfs v181 available

[Richard Gooch <rgooch@xxxxxxxxxxxxxxx>]

Alexander Viro writes:
> 
> 
> On Mon, 18 Jun 2001, Richard Gooch wrote:
> 
> > - Widened locking in <devfs_readlink> and <devfs_follow_link>
> 
> No, you hadn't. Both vfs_readlink() and vfs_follow_link() are blocking
> functions, so BKL is worthless there.

Huh? The BKL will protect against other operations which might cause
the devfs entry to be unregistered, where those other operations also
grab the BKL. So, it's an improvement.

Sure, some operations may cause unregistration without grabbing the
BKL, but that's orthogonal (and requires more extensive changes). If
this "widening" is of no use, then what use are the existing grabs of
the BKL in those functions? You're the one who added them in the first
place.

                                Regards,

                                        Richard....
Permanent: rgooch@xxxxxxxxxxxxx
Current:   rgooch@xxxxxxxxxxxxxxx